Re: Review Request 113008: Clean up KWallet before moving to its own tier

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113008/#review41236
---


This review has been submitted with commit 
4e534c2961b7190bc3d350da7d3d118acc6bbd7c by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 2, 2013, 12:53 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113008/
> ---
> 
> (Updated Oct. 2, 2013, 12:53 a.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Makes a bit of sense of the cmake, adds a TODO.
> 
> 
> Diffs
> -
> 
>   staging/kwallet/src/CMakeLists.txt 0aaa39e 
>   staging/kwallet/src/kwallet_mac.cpp d5d522b 
> 
> Diff: http://git.reviewboard.kde.org/r/113008/diff/
> 
> 
> Testing
> ---
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113008: Clean up KWallet before moving to its own tier

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113008/
---

(Updated Oct. 4, 2013, 5:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Repository: kdelibs


Description
---

Makes a bit of sense of the cmake, adds a TODO.


Diffs
-

  staging/kwallet/src/CMakeLists.txt 0aaa39e 
  staging/kwallet/src/kwallet_mac.cpp d5d522b 

Diff: http://git.reviewboard.kde.org/r/113008/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kio-related build error in plasma-framework

[Sebastian Kügler]

On Friday, October 04, 2013 17:56:52 Sebastian Kügler wrote:
> Hi,
> 
> I'm getting a build error in a few places in plasma-framework, kio isn't
> found. I can't seem to figure out why, maybe someone who has a better
> overview of what in KIO is where, and what I need to tell cmake to figure
> this out?
> 
> The error is:
> /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld:
> cannot find -lkio
> collect2: error: ld returned 1 exit status
> 
> Others reproduce it, too, so it's blocking us right now.

It turns out that removing KDE4_KIO_LIBS from the linker targets it needed to 
build.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113105: Move KWallet to tier2

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113105/
---

Review request for KDE Frameworks and Valentin Rusu.


Repository: kdelibs


Description
---

Does the move, adds the missing dependencies


Diffs
-

  staging/CMakeLists.txt afa9c87 
  tier2/CMakeLists.txt 3d3d2cf 
  tier2/kwallet/CMakeLists.txt e8be3ef 
  tier2/kwallet/KWalletConfig.cmake.in 4dec013 

Diff: http://git.reviewboard.kde.org/r/113105/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.2, test failures and rebuilds

[Ben Cooksley]

On Sat, Oct 5, 2013 at 2:12 AM, Aurélien Gâteau  wrote:
> Hi,

Hi Aurélien,

>
> I spent a bit of time this morning investigating why the khtmlparttest was
> failing on build.kde.org after its Qt copy was switched to 5.2 [1].
>
> Error looked very strange:
>
> QMetaType::registerType: Binary compatibility break -- Size mismatch for type
> 'QtMetaTypePrivate::QSequentialIterableImpl' [1033]. Previously registered
> size 96, now registering size 104.
> /srv/jenkins/workspace/kdelibs_frameworks_qt5/build/khtml/tests/khtmlparttest.shell:
> line 4: 15748
> Aborted (core dumped)
>
> It turned out build.kde.org had kept a build of Phonon from before the switch
> to Qt 5.2, and Phonon was registering the type with the wrong size. Rebuilding
> Phonon and kdelibs fixed the build.

I have now configured build.kde.org to automatically execute a build
of libdbusmenu-qt, phonon, libstreams and libstreamanalyzer upon
completing a build of Qt 5 - which should alleviate this in the
future.

>
> @Steve: Could this be related to the BIC changes you mentioned in:
> http://lists.kde.org/?l=kde-frameworks-devel&m=137908400611851&w=2 ? The
> changes touch iterators.
>
> Aurélien

Thanks,
Ben

>
> [1]:
> http://build.kde.org/job/kdelibs_frameworks_qt5/1338/testReport/junit/%28root%29/TestSuite/khtmlparttest/
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113105: Move KWallet to tier2

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113105/#review41252
---

Ship it!


Ship It!

- David Edmundson


On Oct. 4, 2013, 6:17 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113105/
> ---
> 
> (Updated Oct. 4, 2013, 6:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Does the move, adds the missing dependencies
> 
> 
> Diffs
> -
> 
>   staging/CMakeLists.txt afa9c87 
>   tier2/CMakeLists.txt 3d3d2cf 
>   tier2/kwallet/CMakeLists.txt e8be3ef 
>   tier2/kwallet/KWalletConfig.cmake.in 4dec013 
> 
> Diff: http://git.reviewboard.kde.org/r/113105/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113110: Move KNotifyConfig to staging

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113110/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move KNotifyConfig to staging


Diffs
-

  knotify/CMakeLists.txt 842bf10 
  knotify/config/CMakeLists.txt 1d7c3fd 
  knotify/config/knotify-config.h.cmake  
  knotify/config/knotifyconfigactionswidget.h  
  knotify/config/knotifyconfigactionswidget.cpp  
  knotify/config/knotifyconfigactionswidgetbase.ui  
  knotify/config/knotifyconfigelement.h  
  knotify/config/knotifyconfigelement.cpp  
  knotify/config/knotifyconfigwidget.h  
  knotify/config/knotifyconfigwidget.cpp fb4f111 
  knotify/config/knotifyeventlist.h  
  knotify/config/knotifyeventlist.cpp  
  knotify/tests/CMakeLists.txt 9aae033 
  knotify/tests/knotifytest.notifyrc  
  knotify/tests/knotifytestui.rc  
  knotify/tests/knotifytestview.ui  
  knotify/tests/knotifytestwindow.h  
  knotify/tests/knotifytestwindow.cpp  
  knotify/tests/main.cpp  
  staging/CMakeLists.txt afa9c87 
  staging/knotifyconfig/CMakeLists.txt PRE-CREATION 
  staging/knotifyconfig/KNotifyConfigConfig.cmake.in PRE-CREATION 
  staging/knotifyconfig/src/CMakeLists.txt PRE-CREATION 
  staging/knotifyconfig/tests/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113110/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Qt 5.2, test failures and rebuilds

[Aurélien Gâteau]

On Saturday 05 October 2013 08:52:27 you wrote:
> On Sat, Oct 5, 2013 at 2:12 AM, Aurélien Gâteau  wrote:
> > Hi,
> 
> Hi Aurélien,
> 
> > I spent a bit of time this morning investigating why the khtmlparttest was
> > failing on build.kde.org after its Qt copy was switched to 5.2 [1].
> > 
> > Error looked very strange:
> > 
> > QMetaType::registerType: Binary compatibility break -- Size mismatch for
> > type 'QtMetaTypePrivate::QSequentialIterableImpl' [1033]. Previously
> > registered size 96, now registering size 104.
> > /srv/jenkins/workspace/kdelibs_frameworks_qt5/build/khtml/tests/khtmlpartt
> > est.shell: line 4: 15748
> > Aborted (core dumped)
> > 
> > It turned out build.kde.org had kept a build of Phonon from before the
> > switch to Qt 5.2, and Phonon was registering the type with the wrong
> > size. Rebuilding Phonon and kdelibs fixed the build.
> 
> I have now configured build.kde.org to automatically execute a build
> of libdbusmenu-qt, phonon, libstreams and libstreamanalyzer upon
> completing a build of Qt 5 - which should alleviate this in the
> future.

Good idea, thanks Ben!

Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #776

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113112: Notify about fonts and palette changes

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/
---

Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.


Repository: kdelibs


Description
---

Make sure the application can react to changes in the application's defaults 
regarding palette and fonts, when using the kde platform plugin.


Diffs
-

  staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp b3b4f7a 
  staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 

Diff: http://git.reviewboard.kde.org/r/113112/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113112: Notify about fonts and palette changes

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/#review41259
---



staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp


This happens already in QApplication::setFont();

qapplication.cpp:1511


- David Edmundson


On Oct. 4, 2013, 11:52 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113112/
> ---
> 
> (Updated Oct. 4, 2013, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make sure the application can react to changes in the application's defaults 
> regarding palette and fonts, when using the kde platform plugin.
> 
> 
> Diffs
> -
> 
>   staging/frameworkintegration/src/platformtheme/kfontsettingsdata.cpp 
> b3b4f7a 
>   staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 
> 
> Diff: http://git.reviewboard.kde.org/r/113112/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113110: Move KNotifyConfig to staging

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113110/#review41260
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 4, 2013, 8:34 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113110/
> ---
> 
> (Updated Oct. 4, 2013, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Move KNotifyConfig to staging
> 
> 
> Diffs
> -
> 
>   knotify/CMakeLists.txt 842bf10 
>   knotify/config/CMakeLists.txt 1d7c3fd 
>   knotify/config/knotify-config.h.cmake  
>   knotify/config/knotifyconfigactionswidget.h  
>   knotify/config/knotifyconfigactionswidget.cpp  
>   knotify/config/knotifyconfigactionswidgetbase.ui  
>   knotify/config/knotifyconfigelement.h  
>   knotify/config/knotifyconfigelement.cpp  
>   knotify/config/knotifyconfigwidget.h  
>   knotify/config/knotifyconfigwidget.cpp fb4f111 
>   knotify/config/knotifyeventlist.h  
>   knotify/config/knotifyeventlist.cpp  
>   knotify/tests/CMakeLists.txt 9aae033 
>   knotify/tests/knotifytest.notifyrc  
>   knotify/tests/knotifytestui.rc  
>   knotify/tests/knotifytestview.ui  
>   knotify/tests/knotifytestwindow.h  
>   knotify/tests/knotifytestwindow.cpp  
>   knotify/tests/main.cpp  
>   staging/CMakeLists.txt afa9c87 
>   staging/knotifyconfig/CMakeLists.txt PRE-CREATION 
>   staging/knotifyconfig/KNotifyConfigConfig.cmake.in PRE-CREATION 
>   staging/knotifyconfig/src/CMakeLists.txt PRE-CREATION 
>   staging/knotifyconfig/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113110/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113112: Notify about palette changes

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/
---

(Updated Oct. 5, 2013, 12:14 a.m.)


Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.


Changes
---

no need to post the font change, as David ingenuously noticed.


Summary (updated)
-

Notify about palette changes


Repository: kdelibs


Description (updated)
---

Make sure the application can react to changes in the application's defaults 
regarding palette, when using the kde platform plugin.


Diffs (updated)
-

  staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 

Diff: http://git.reviewboard.kde.org/r/113112/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113112: Notify about palette changes

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113112/#review41262
---


Uh, just realized ingenuous doesn't mean what I thought, I guess it's too late 
in the night, at least my brain noticed a few minutes later. :D

Anyway, it was meant as a compliment, now I shut up. :)

Have a good weekend guys!

- Aleix Pol Gonzalez


On Oct. 5, 2013, 12:14 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113112/
> ---
> 
> (Updated Oct. 5, 2013, 12:14 a.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Sebastian Kügler.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Make sure the application can react to changes in the application's defaults 
> regarding palette, when using the kde platform plugin.
> 
> 
> Diffs
> -
> 
>   staging/frameworkintegration/src/platformtheme/khintssettings.cpp 5d5bf82 
> 
> Diff: http://git.reviewboard.kde.org/r/113112/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

[Kurt Hindenburg]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/#review41263
---


Thanks - it appears to fix the kbookmark build - I'm getting the same klocale 
issues as well.

You can add the group konsole or me to any Konsole patches.

- Kurt Hindenburg


On Oct. 4, 2013, 2:35 p.m., Casian Andrei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113091/
> ---
> 
> (Updated Oct. 4, 2013, 2:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: konsole
> 
> 
> Description
> ---
> 
> Build fails following some changes in kdelibs.
> 
> Quick fix!
> 
> 
> Diffs
> -
> 
>   src/BookmarkHandler.h 04e988d 
>   src/BookmarkHandler.cpp 7a54b17 
> 
> Diff: http://git.reviewboard.kde.org/r/113091/diff/
> 
> 
> Testing
> ---
> 
> Not tested, because of some link issue with Ki18n...
> 
> Should work though.
> 
> 
> Thanks,
> 
> Casian Andrei
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

[Casian Andrei]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/
---

(Updated Oct. 5, 2013, 1:59 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: konsole


Description
---

Build fails following some changes in kdelibs.

Quick fix!


Diffs
-

  src/BookmarkHandler.h 04e988d 
  src/BookmarkHandler.cpp 7a54b17 

Diff: http://git.reviewboard.kde.org/r/113091/diff/


Testing
---

Not tested, because of some link issue with Ki18n...

Should work though.


Thanks,

Casian Andrei

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/#review41264
---


This review has been submitted with commit 
346e17428503248654592e3bc6c162d52a79eba3 by Kurt Hindenburg to branch 
frameworks.

- Commit Hook


On Oct. 4, 2013, 2:35 p.m., Casian Andrei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113091/
> ---
> 
> (Updated Oct. 4, 2013, 2:35 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: konsole
> 
> 
> Description
> ---
> 
> Build fails following some changes in kdelibs.
> 
> Quick fix!
> 
> 
> Diffs
> -
> 
>   src/BookmarkHandler.h 04e988d 
>   src/BookmarkHandler.cpp 7a54b17 
> 
> Diff: http://git.reviewboard.kde.org/r/113091/diff/
> 
> 
> Testing
> ---
> 
> Not tested, because of some link issue with Ki18n...
> 
> Should work though.
> 
> 
> Thanks,
> 
> Casian Andrei
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #779

[KDE CI System]

See 

Changes:

[sebas] lower case headers

[sebas] Port away from KStandardDirs

[sebas] lower case headers

[sebas] lower case headers

[sebas] find KDELibs4

--
[...truncated 669 lines...]
[ 38%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/dataengineconsumer.cpp.o
[ 38%] Building CXX object src/plasma/CMakeFiles/plasma.dir/service.cpp.o
:
 In member function ‘void 
Plasma::AssociatedApplicationManager::run(Plasma::Applet*)’:
:120:14:
 warning: unused variable ‘success’ [-Wunused-variable]
[ 39%] Building CXX object src/plasma/CMakeFiles/plasma.dir/servicejob.cpp.o
[ 39%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/datacontainer_p.cpp.o
[ 40%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/dataenginemanager.cpp.o
[ 40%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/storage.cpp.o
[ 41%] In file included from 
:32:0:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:
 In function ‘T KGlobal::findDirectChild(const QObject*)’:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:514:31:
 warning: ‘QObject* KGlobal::findDirectChild_helper(const QObject*, const 
QMetaObject&)’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:504)
 [-Wdeprecated-declarations]
Building CXX object src/plasma/CMakeFiles/plasma.dir/private/storagethread.cpp.o
In file included from 
:35:0:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:
 At global scope:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:822:41:
 warning: ‘KStandardDirs’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:823:53:
 warning: ‘KStandardDirs’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:172)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:823:53:
 warning: ‘KStandardDirs’ is deprecated [-Wdeprecated-declarations]
[ 41%] Building CXX object src/plasma/CMakeFiles/plasma.dir/package.cpp.o
[ 42%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/packagestructure.cpp.o
[ 42%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/packagejob.cpp.o
[ 43%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/packagejobthread.cpp.o
[ 43%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/packages.cpp.o
[ 44%] Building CXX object src/plasma/CMakeFiles/plasma.dir/framesvg.cpp.o
In file included from 
:31:0:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:822:41:
 warning: ‘KStandardDirs’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:823:53:
 warning: ‘KStandardDirs’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:172)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kstandarddirs.h:823:53:
 warning: ‘KStandardDirs’ is deprecated [-Wdeprecated-declarations]
:710:7:
 warning: unused parameter ‘packageName’ [-Wunused-parameter]
[ 44%] Building CXX object src/plasma/CMakeFiles/plasma.dir/svg.cpp.o
[ 45%] Building CXX object src/plasma/CMakeFiles/plasma.dir/theme.cpp.o
[ 45%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/theme_p.cpp.o
[ 46%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/scripting/appletscript.cpp.o
[ 46%] [ 47%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/scripting/runnerscript.cpp.o
Building CXX object 
src/plasma/CMakeFiles/plasma.dir/scripting/dataenginescript.cpp.o
[ 47%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/scripting/scriptengine.cpp.o
[ 48%] Building CXX object 
src/plasma/CMakeFiles/plasma.dir/private/effectwatcher.cpp.o
In file included from 
:39:0:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:
 In function ‘T KGlobal::findDirectChild(const QObject*)’:
/srv/jenkins/install/linux/x86_64/g++/qt5

Jenkins build is back to normal : plasma-framework_master_qt5 #780

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #781

[KDE CI System]

See 

Changes:

[sebas] Reenable tests in declarativeimports

[sebas] Port Plasma::Svg away from KGlobalSettings

[sebas] Port theme away from KGlobalSettings

[sebas] Port declarative theme away from KGlobalSettings`

[sebas] remove unneeded includes

--
[...truncated 609 lines...]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:
 At global scope:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1156:1:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:
 In static member function ‘static int 
QMetaTypeId::qt_metatype_id()’:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1156:1:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1156:1:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140)
 [-Wdeprecated-declarations]
:
 In function ‘int main(int, char**)’:
:26:1:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
:26:1:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
:26:1:
 warning: ‘void KGlobal::ref()’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:448)
 [-Wdeprecated-declarations]
:26:1:
 warning: ‘void KGlobal::ref()’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kglobal.h:448)
 [-Wdeprecated-declarations]
Generating scriptengine.moc
:0:
 Note: No relevant classes found. No output generated.
Generating widget.moc
:0:
 Note: No relevant classes found. No output generated.
[ 20%] Building CXX object 
src/declarativeimports/locale/CMakeFiles/localebindingsplugin.dir/localebindingsplugin.cpp.o
Generating moc_theme.cpp
Generating moc_corebindingsplugin.cpp
Generating moc_datamodel.cpp
Generating moc_datasource.cpp
Generating moc_dialog.cpp
Generating moc_framesvgitem.cpp
Generating moc_iconitem.cpp
Generating moc_runnermodel.cpp
Generating moc_serviceoperationstatus.cpp
Generating moc_svgitem.cpp
Generating moc_tooltip.cpp
Generating moc_tooltipdialog.cpp
Generating moc_windowthumbnail.cpp
[ 20%] Built target corebindingsplugin_automoc
[ 21%] Building CXX object 
src/declarativeimports/locale/CMakeFiles/localebindingsplugin.dir/calendarsystem.cpp.o
:37:6:
 warning: unused parameter ‘newState’ [-Wunused-parameter]
[ 21%] Building CXX object 
src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformcomponentsplugin_automoc.cpp.o
[ 22%] [ 22%] Building CXX object 
src/declarativeimports/dirmodel/CMakeFiles/dirmodelplugin.dir/dirmodelplugin_automoc.cpp.o
Building CXX object 
src/declarativeimports/draganddrop/CMakeFiles/draganddropplugin.dir/DeclarativeDragArea.cpp.o
[ 22%] Building CXX object 
src/declarativeimports/locale/CMakeFiles/localebindingsplugin.dir/localebindingsplugin_automoc.cpp.o
Linking CXX shared library ../../../lib/libdirmodelplugin.so
[ 22%] Building CXX object 
src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/columnproxymodel.cpp.o
[ 22%] [ 23%] Built target dirmodelplugin
Building CXX object 
src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/__/__/core/tests/modeltest.cpp.o
[ 23%] Building CXX object 
src/declarativeimports/qtextracomponents/tests/CMakeFiles/fullmodelaccesstest.dir/fullmodela

Re: Review Request 113045: Prepare KCMUtils for move to tier3

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41196
---

Ship it!


Looks good, but why don't we replace KCategoryDrawer with KCategoryDrawerV3, in 
itemviews? I.e. getting rid of the two oldest ones?
It should be SC since v3 derives from v2 derives from v1.

- David Faure


On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113045/
> ---
> 
> (Updated Oct. 2, 2013, 8:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Only find publicly used libraries in cmake.in
> 
> 
> KCategoryDrawer -> KCategoryDrawerV3
> 
> 
> No QString cast from ascii
> 
> 
> Diffs
> -
> 
>   staging/kcmutils/CMakeLists.txt dc577d3 
>   staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 
>   staging/kcmutils/src/CMakeLists.txt dc19649 
>   staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 
>   staging/kcmutils/src/kcmoduleinfo.cpp f46308c 
>   staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab 
>   staging/kcmutils/src/kcmultidialog.cpp 4812407 
>   staging/kcmutils/src/kpluginselector.cpp 77cbfda 
>   staging/kcmutils/src/kpluginselector_p.h 2dffae0 
>   staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a 
>   staging/kcmutils/src/ksettings/dialog.cpp 131f75f 
>   staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc 
>   staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 
> 
> Diff: http://git.reviewboard.kde.org/r/113045/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

EcmQt4To5Porting

[David Faure]

On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote:
> There were 2 files recently removed from ECM which broke attica's build,
> this puts the removed files as local cmake modules.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt e0efb9b 
>   cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION 
>   cmake/modules/FindQt5Transitional.cmake PRE-CREATION 

I'm confused. Why have they been removed from ECM?
(and where was this explained/announced).

Attica surely isn't the only module which is going to want to build with both 
Qt4 and Qt5, right?
Or if there's a better way to do this, shouldn't attica be ported to the 
better way, before other modules copy these files too?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: EcmQt4To5Porting

[Stephen Kelly]

David Faure wrote:

> On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote:
>> There were 2 files recently removed from ECM which broke attica's build,
>> this puts the removed files as local cmake modules.
>> 
>> 
>> Diffs
>> -
>> 
>>   CMakeLists.txt e0efb9b
>>   cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION
>>   cmake/modules/FindQt5Transitional.cmake PRE-CREATION
> 
> I'm confused. Why have they been removed from ECM?
> (and where was this explained/announced).
> 
> Attica surely isn't the only module which is going to want to build with
> both Qt4 and Qt5, right?

Right. I copied them into the kdelibs repo, so anything using that can make 
use of them.

They're not a long term solution because they're so catch-all. 
QT_QTCORE_LIBRARIES contains the QtConcurrent library also, etc. 

They're only a temporary solution so that you don't have to change eg 
qt4_wrap_ui to qt5_wrap_ui before trying to build your c++ code. I don't 
think they should be maintained/supported long-term. I was considering 
adding EcmQt4To5Porting to Qt as a documentation page, which doesn't need to 
maintain compatibility.

> Or if there's a better way to do this, shouldn't attica be ported to the
> better way, before other modules copy these files too?

The better way is:

* Start with a Qt4 based repo
* Add the files
* Make whatever changes needed to port the c++ code to Qt 5
* Port away from the files (eg s/qt4_wrap_ui/qt5_wrap_ui/ )
* Remove the files

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113045: Prepare KCMUtils for move to tier3

[David Edmundson]

> On Oct. 4, 2013, 7 a.m., David Faure wrote:
> > Looks good, but why don't we replace KCategoryDrawer with 
> > KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones?
> > It should be SC since v3 derives from v2 derives from v1.

It's not entirely source compatible since the constructor changes and v1 needs 
deleting manually. 
Will be easy to change now that everything in kdelibs uses V3 style. Will make 
a new review today.


- David


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41196
---


On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113045/
> ---
> 
> (Updated Oct. 2, 2013, 8:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Only find publicly used libraries in cmake.in
> 
> 
> KCategoryDrawer -> KCategoryDrawerV3
> 
> 
> No QString cast from ascii
> 
> 
> Diffs
> -
> 
>   staging/kcmutils/CMakeLists.txt dc577d3 
>   staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 
>   staging/kcmutils/src/CMakeLists.txt dc19649 
>   staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 
>   staging/kcmutils/src/kcmoduleinfo.cpp f46308c 
>   staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab 
>   staging/kcmutils/src/kcmultidialog.cpp 4812407 
>   staging/kcmutils/src/kpluginselector.cpp 77cbfda 
>   staging/kcmutils/src/kpluginselector_p.h 2dffae0 
>   staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a 
>   staging/kcmutils/src/ksettings/dialog.cpp 131f75f 
>   staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc 
>   staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 
> 
> Diff: http://git.reviewboard.kde.org/r/113045/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: EcmQt4To5Porting

[Martin Klapetek]

On Fri, Oct 4, 2013 at 9:22 AM, David Faure  wrote:

> On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote:
> > There were 2 files recently removed from ECM which broke attica's build,
> > this puts the removed files as local cmake modules.
> >
> >
> > Diffs
> > -
> >
> >   CMakeLists.txt e0efb9b
> >   cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION
> >   cmake/modules/FindQt5Transitional.cmake PRE-CREATION
>
> I'm confused. Why have they been removed from ECM?
> (and where was this explained/announced).
>

I only found out because Attica failed to build for me, so I investigated
and notified Stephen, he suggested to either copy the files over or "do it
properly" as explained in his following email. Being unfamiliar with Attica
completely, I chose the easier way.

I too, however, would appreciate these breaking changes to be at least
announced on this list.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113045: Prepare KCMUtils for move to tier3

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/#review41199
---


This review has been submitted with commit 
23782b73ef829d9b07d352bcac8a6fe455e5d64f by David Edmundson to branch 
frameworks.

- Commit Hook


On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113045/
> ---
> 
> (Updated Oct. 2, 2013, 8:06 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Only find publicly used libraries in cmake.in
> 
> 
> KCategoryDrawer -> KCategoryDrawerV3
> 
> 
> No QString cast from ascii
> 
> 
> Diffs
> -
> 
>   staging/kcmutils/CMakeLists.txt dc577d3 
>   staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 
>   staging/kcmutils/src/CMakeLists.txt dc19649 
>   staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 
>   staging/kcmutils/src/kcmoduleinfo.cpp f46308c 
>   staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab 
>   staging/kcmutils/src/kcmultidialog.cpp 4812407 
>   staging/kcmutils/src/kpluginselector.cpp 77cbfda 
>   staging/kcmutils/src/kpluginselector_p.h 2dffae0 
>   staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a 
>   staging/kcmutils/src/ksettings/dialog.cpp 131f75f 
>   staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc 
>   staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 
> 
> Diff: http://git.reviewboard.kde.org/r/113045/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113045: Prepare KCMUtils for move to tier3

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113045/
---

(Updated Oct. 4, 2013, 9:01 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Only find publicly used libraries in cmake.in


KCategoryDrawer -> KCategoryDrawerV3


No QString cast from ascii


Diffs
-

  staging/kcmutils/CMakeLists.txt dc577d3 
  staging/kcmutils/KCMUtilsConfig.cmake.in c67ad52 
  staging/kcmutils/src/CMakeLists.txt dc19649 
  staging/kcmutils/src/kcmodulecontainer.cpp c08eda2 
  staging/kcmutils/src/kcmoduleinfo.cpp f46308c 
  staging/kcmutils/src/kcmoduleproxy.cpp d2db3ab 
  staging/kcmutils/src/kcmultidialog.cpp 4812407 
  staging/kcmutils/src/kpluginselector.cpp 77cbfda 
  staging/kcmutils/src/kpluginselector_p.h 2dffae0 
  staging/kcmutils/src/ksettings/componentsdialog.cpp 111549a 
  staging/kcmutils/src/ksettings/dialog.cpp 131f75f 
  staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc 
  staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 

Diff: http://git.reviewboard.kde.org/r/113045/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

[Casian Andrei]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/
---

Review request for KDE Frameworks and David Faure.


Repository: konsole


Description
---

Build fails following some changes in kdelibs.

Quick fix!


Diffs
-

  src/BookmarkHandler.h 04e988d 
  src/BookmarkHandler.cpp 7a54b17 

Diff: http://git.reviewboard.kde.org/r/113091/diff/


Testing
---

Not tested, because of some link issue with Ki18n...

Should work though.


Thanks,

Casian Andrei

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113090: Move kcmutils to tier4

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113090/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move kcmutils to tier4.
Simply file moves and a moving a few add_directories.

Note in my last review I mentioned "prepare kcmutils for tier3". Splitting 
kdelibs wiki page says tier4, so I went with that.


Diffs
-

  staging/kcmutils/src/ksettings/dispatcher_p.h  
  staging/kcmutils/src/ksettings/dispatcher.cpp  
  staging/kcmutils/src/ksettings/dispatcher.h  
  staging/kcmutils/src/ksettings/dialog_p.h  
  staging/kcmutils/src/ksettings/dialog.cpp  
  staging/kcmutils/src/ksettings/dialog.h  
  staging/kcmutils/src/ksettings/componentsdialog_p.h  
  staging/kcmutils/src/ksettings/componentsdialog.cpp  
  staging/kcmutils/src/ksettings/TODO  
  staging/kcmutils/src/ksettings/README.dox  
  staging/kcmutils/src/kpluginselector_p.h  
  staging/kcmutils/src/kpluginselector.cpp  
  staging/kcmutils/src/kpluginselector.h  
  staging/kcmutils/src/kdeglobals.kcfgc  
  staging/kcmutils/src/kdeglobals.kcfg  
  staging/kcmutils/src/kcmultidialog_p.h  
  staging/kcmutils/src/kcmultidialog.cpp  
  staging/kcmutils/src/kcmultidialog.h  
  staging/kcmutils/src/kcmoduleproxy_p.h  
  staging/kcmutils/src/kcmoduleproxy.cpp  
  staging/kcmutils/src/kcmoduleproxy.h  
  staging/kcmutils/src/kcmoduleloader.cpp  
  staging/kcmutils/src/kcmoduleloader.h  
  staging/kcmutils/src/kcmoduleinfo.h  
  staging/kcmutils/src/kcmoduleinfo.cpp  
  staging/kcmutils/src/kcmodulecontainer.cpp  
  staging/kcmutils/src/kcmodulecontainer.h  
  staging/kcmutils/src/Mainpage.dox  
  staging/kcmutils/src/CMakeLists.txt  
  staging/kcmutils/TODO  
  staging/kcmutils/KCMUtilsConfig.cmake.in  
  staging/kcmutils/CMakeLists.txt  
  staging/CMakeLists.txt 5c5c80c 
  CMakeLists.txt 3204c11 
  staging/kcmutils/src/ksettings/pluginpage.h  
  staging/kcmutils/src/ksettings/pluginpage.cpp  
  staging/kcmutils/src/ksettingswidgetadaptor.h  
  staging/kcmutils/src/ksettingswidgetadaptor.cpp  
  tier4/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113090/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/#review41200
---



src/BookmarkHandler.h


Don't forget the new currentIcon too.



src/BookmarkHandler.cpp


Just view->url().


- David Faure


On Oct. 4, 2013, 9:11 a.m., Casian Andrei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113091/
> ---
> 
> (Updated Oct. 4, 2013, 9:11 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: konsole
> 
> 
> Description
> ---
> 
> Build fails following some changes in kdelibs.
> 
> Quick fix!
> 
> 
> Diffs
> -
> 
>   src/BookmarkHandler.h 04e988d 
>   src/BookmarkHandler.cpp 7a54b17 
> 
> Diff: http://git.reviewboard.kde.org/r/113091/diff/
> 
> 
> Testing
> ---
> 
> Not tested, because of some link issue with Ki18n...
> 
> Should work though.
> 
> 
> Thanks,
> 
> Casian Andrei
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113094: Last CMake changes for KDESu

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113094/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Some last modifications needed for moving


Diffs
-

  staging/kdesu/src/CMakeLists.txt 60f43a6 
  staging/kdesu/KDESuConfig.cmake.in 44caead 
  staging/kdesu/CMakeLists.txt 93e5eba 

Diff: http://git.reviewboard.kde.org/r/113094/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113094: Last CMake changes for KDESu

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113094/#review41201
---

Ship it!



staging/kdesu/src/CMakeLists.txt


I think now it's "kpty". Does it build?


- Aleix Pol Gonzalez


On Oct. 4, 2013, 9:58 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113094/
> ---
> 
> (Updated Oct. 4, 2013, 9:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Some last modifications needed for moving
> 
> 
> Diffs
> -
> 
>   staging/kdesu/src/CMakeLists.txt 60f43a6 
>   staging/kdesu/KDESuConfig.cmake.in 44caead 
>   staging/kdesu/CMakeLists.txt 93e5eba 
> 
> Diff: http://git.reviewboard.kde.org/r/113094/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

[Teo Mrnjavac]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113095/
---

Review request for KDE Frameworks, David Faure and Kevin Ottens.


Repository: kdelibs


Description
---

Now that https://codereview.qt-project.org/#change,63345 is merged, this commit 
replaces usage of setNameFilters in some QFileDialog instances in favor of 
setMimeTypeFilters to avoid repeating the same conversion from mime types to 
globs in multiple places.


Diffs
-

  staging/kde4support/src/kssl/kcm/cacertificatespage.cpp 
e0a66c54633f457322729eecc0395baae8a5c548 
  kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 

Diff: http://git.reviewboard.kde.org/r/113095/diff/


Testing
---


Thanks,

Teo Mrnjavac

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113090: Move kcmutils to tier4

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113090/#review41203
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Oct. 4, 2013, 9:12 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113090/
> ---
> 
> (Updated Oct. 4, 2013, 9:12 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Move kcmutils to tier4.
> Simply file moves and a moving a few add_directories.
> 
> Note in my last review I mentioned "prepare kcmutils for tier3". Splitting 
> kdelibs wiki page says tier4, so I went with that.
> 
> 
> Diffs
> -
> 
>   staging/kcmutils/src/ksettings/dispatcher_p.h  
>   staging/kcmutils/src/ksettings/dispatcher.cpp  
>   staging/kcmutils/src/ksettings/dispatcher.h  
>   staging/kcmutils/src/ksettings/dialog_p.h  
>   staging/kcmutils/src/ksettings/dialog.cpp  
>   staging/kcmutils/src/ksettings/dialog.h  
>   staging/kcmutils/src/ksettings/componentsdialog_p.h  
>   staging/kcmutils/src/ksettings/componentsdialog.cpp  
>   staging/kcmutils/src/ksettings/TODO  
>   staging/kcmutils/src/ksettings/README.dox  
>   staging/kcmutils/src/kpluginselector_p.h  
>   staging/kcmutils/src/kpluginselector.cpp  
>   staging/kcmutils/src/kpluginselector.h  
>   staging/kcmutils/src/kdeglobals.kcfgc  
>   staging/kcmutils/src/kdeglobals.kcfg  
>   staging/kcmutils/src/kcmultidialog_p.h  
>   staging/kcmutils/src/kcmultidialog.cpp  
>   staging/kcmutils/src/kcmultidialog.h  
>   staging/kcmutils/src/kcmoduleproxy_p.h  
>   staging/kcmutils/src/kcmoduleproxy.cpp  
>   staging/kcmutils/src/kcmoduleproxy.h  
>   staging/kcmutils/src/kcmoduleloader.cpp  
>   staging/kcmutils/src/kcmoduleloader.h  
>   staging/kcmutils/src/kcmoduleinfo.h  
>   staging/kcmutils/src/kcmoduleinfo.cpp  
>   staging/kcmutils/src/kcmodulecontainer.cpp  
>   staging/kcmutils/src/kcmodulecontainer.h  
>   staging/kcmutils/src/Mainpage.dox  
>   staging/kcmutils/src/CMakeLists.txt  
>   staging/kcmutils/TODO  
>   staging/kcmutils/KCMUtilsConfig.cmake.in  
>   staging/kcmutils/CMakeLists.txt  
>   staging/CMakeLists.txt 5c5c80c 
>   CMakeLists.txt 3204c11 
>   staging/kcmutils/src/ksettings/pluginpage.h  
>   staging/kcmutils/src/ksettings/pluginpage.cpp  
>   staging/kcmutils/src/ksettingswidgetadaptor.h  
>   staging/kcmutils/src/ksettingswidgetadaptor.cpp  
>   tier4/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113090/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113095/#review41205
---



staging/kde4support/src/kssl/kcm/cacertificatespage.cpp


You should construct the string using QStringLiteral(). Also you can pass 
it as the QStringList constructor


- Aleix Pol Gonzalez


On Oct. 4, 2013, 10:55 a.m., Teo Mrnjavac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113095/
> ---
> 
> (Updated Oct. 4, 2013, 10:55 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Now that https://codereview.qt-project.org/#change,63345 is merged, this 
> commit replaces usage of setNameFilters in some QFileDialog instances in 
> favor of setMimeTypeFilters to avoid repeating the same conversion from mime 
> types to globs in multiple places.
> 
> 
> Diffs
> -
> 
>   staging/kde4support/src/kssl/kcm/cacertificatespage.cpp 
> e0a66c54633f457322729eecc0395baae8a5c548 
>   kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 
> 
> Diff: http://git.reviewboard.kde.org/r/113095/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Teo Mrnjavac
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113094: Last CMake changes for KDESu

[Martin Klapetek]

> On Oct. 4, 2013, 10:54 a.m., Aleix Pol Gonzalez wrote:
> > staging/kdesu/src/CMakeLists.txt, line 36
> > 
> >
> > I think now it's "kpty". Does it build?

It does not build yet, I'll wait for David to push his changes first. Also 
it'll be KPty.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113094/#review41201
---


On Oct. 4, 2013, 9:58 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113094/
> ---
> 
> (Updated Oct. 4, 2013, 9:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Some last modifications needed for moving
> 
> 
> Diffs
> -
> 
>   staging/kdesu/src/CMakeLists.txt 60f43a6 
>   staging/kdesu/KDESuConfig.cmake.in 44caead 
>   staging/kdesu/CMakeLists.txt 93e5eba 
> 
> Diff: http://git.reviewboard.kde.org/r/113094/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113090: Move kcmutils to tier4

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113090/
---

(Updated Oct. 4, 2013, 11:18 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move kcmutils to tier4.
Simply file moves and a moving a few add_directories.

Note in my last review I mentioned "prepare kcmutils for tier3". Splitting 
kdelibs wiki page says tier4, so I went with that.


Diffs
-

  staging/kcmutils/src/ksettings/dispatcher_p.h  
  staging/kcmutils/src/ksettings/dispatcher.cpp  
  staging/kcmutils/src/ksettings/dispatcher.h  
  staging/kcmutils/src/ksettings/dialog_p.h  
  staging/kcmutils/src/ksettings/dialog.cpp  
  staging/kcmutils/src/ksettings/dialog.h  
  staging/kcmutils/src/ksettings/componentsdialog_p.h  
  staging/kcmutils/src/ksettings/componentsdialog.cpp  
  staging/kcmutils/src/ksettings/TODO  
  staging/kcmutils/src/ksettings/README.dox  
  staging/kcmutils/src/kpluginselector_p.h  
  staging/kcmutils/src/kpluginselector.cpp  
  staging/kcmutils/src/kpluginselector.h  
  staging/kcmutils/src/kdeglobals.kcfgc  
  staging/kcmutils/src/kdeglobals.kcfg  
  staging/kcmutils/src/kcmultidialog_p.h  
  staging/kcmutils/src/kcmultidialog.cpp  
  staging/kcmutils/src/kcmultidialog.h  
  staging/kcmutils/src/kcmoduleproxy_p.h  
  staging/kcmutils/src/kcmoduleproxy.cpp  
  staging/kcmutils/src/kcmoduleproxy.h  
  staging/kcmutils/src/kcmoduleloader.cpp  
  staging/kcmutils/src/kcmoduleloader.h  
  staging/kcmutils/src/kcmoduleinfo.h  
  staging/kcmutils/src/kcmoduleinfo.cpp  
  staging/kcmutils/src/kcmodulecontainer.cpp  
  staging/kcmutils/src/kcmodulecontainer.h  
  staging/kcmutils/src/Mainpage.dox  
  staging/kcmutils/src/CMakeLists.txt  
  staging/kcmutils/TODO  
  staging/kcmutils/KCMUtilsConfig.cmake.in  
  staging/kcmutils/CMakeLists.txt  
  staging/CMakeLists.txt 5c5c80c 
  CMakeLists.txt 3204c11 
  staging/kcmutils/src/ksettings/pluginpage.h  
  staging/kcmutils/src/ksettings/pluginpage.cpp  
  staging/kcmutils/src/ksettingswidgetadaptor.h  
  staging/kcmutils/src/ksettingswidgetadaptor.cpp  
  tier4/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113090/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113090: Move kcmutils to tier4

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113090/#review41211
---


This review has been submitted with commit 
f290ee6dcdb6ce894753fde4e8536b656a64b2e7 by David Edmundson to branch 
frameworks.

- Commit Hook


On Oct. 4, 2013, 9:12 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113090/
> ---
> 
> (Updated Oct. 4, 2013, 9:12 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Move kcmutils to tier4.
> Simply file moves and a moving a few add_directories.
> 
> Note in my last review I mentioned "prepare kcmutils for tier3". Splitting 
> kdelibs wiki page says tier4, so I went with that.
> 
> 
> Diffs
> -
> 
>   staging/kcmutils/src/ksettings/dispatcher_p.h  
>   staging/kcmutils/src/ksettings/dispatcher.cpp  
>   staging/kcmutils/src/ksettings/dispatcher.h  
>   staging/kcmutils/src/ksettings/dialog_p.h  
>   staging/kcmutils/src/ksettings/dialog.cpp  
>   staging/kcmutils/src/ksettings/dialog.h  
>   staging/kcmutils/src/ksettings/componentsdialog_p.h  
>   staging/kcmutils/src/ksettings/componentsdialog.cpp  
>   staging/kcmutils/src/ksettings/TODO  
>   staging/kcmutils/src/ksettings/README.dox  
>   staging/kcmutils/src/kpluginselector_p.h  
>   staging/kcmutils/src/kpluginselector.cpp  
>   staging/kcmutils/src/kpluginselector.h  
>   staging/kcmutils/src/kdeglobals.kcfgc  
>   staging/kcmutils/src/kdeglobals.kcfg  
>   staging/kcmutils/src/kcmultidialog_p.h  
>   staging/kcmutils/src/kcmultidialog.cpp  
>   staging/kcmutils/src/kcmultidialog.h  
>   staging/kcmutils/src/kcmoduleproxy_p.h  
>   staging/kcmutils/src/kcmoduleproxy.cpp  
>   staging/kcmutils/src/kcmoduleproxy.h  
>   staging/kcmutils/src/kcmoduleloader.cpp  
>   staging/kcmutils/src/kcmoduleloader.h  
>   staging/kcmutils/src/kcmoduleinfo.h  
>   staging/kcmutils/src/kcmoduleinfo.cpp  
>   staging/kcmutils/src/kcmodulecontainer.cpp  
>   staging/kcmutils/src/kcmodulecontainer.h  
>   staging/kcmutils/src/Mainpage.dox  
>   staging/kcmutils/src/CMakeLists.txt  
>   staging/kcmutils/TODO  
>   staging/kcmutils/KCMUtilsConfig.cmake.in  
>   staging/kcmutils/CMakeLists.txt  
>   staging/CMakeLists.txt 5c5c80c 
>   CMakeLists.txt 3204c11 
>   staging/kcmutils/src/ksettings/pluginpage.h  
>   staging/kcmutils/src/ksettings/pluginpage.cpp  
>   staging/kcmutils/src/ksettingswidgetadaptor.h  
>   staging/kcmutils/src/ksettingswidgetadaptor.cpp  
>   tier4/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113090/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

[Teo Mrnjavac]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113095/
---

(Updated Oct. 4, 2013, 11:25 a.m.)


Review request for KDE Frameworks, David Faure and Kevin Ottens.


Repository: kdelibs


Description
---

Now that https://codereview.qt-project.org/#change,63345 is merged, this commit 
replaces usage of setNameFilters in some QFileDialog instances in favor of 
setMimeTypeFilters to avoid repeating the same conversion from mime types to 
globs in multiple places.


Diffs (updated)
-

  staging/kde4support/src/kssl/kcm/cacertificatespage.cpp 
e0a66c54633f457322729eecc0395baae8a5c548 
  kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 

Diff: http://git.reviewboard.kde.org/r/113095/diff/


Testing
---


Thanks,

Teo Mrnjavac

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113095/#review41213
---

Ship it!


Ship It!

- David Faure


On Oct. 4, 2013, 11:25 a.m., Teo Mrnjavac wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113095/
> ---
> 
> (Updated Oct. 4, 2013, 11:25 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Now that https://codereview.qt-project.org/#change,63345 is merged, this 
> commit replaces usage of setNameFilters in some QFileDialog instances in 
> favor of setMimeTypeFilters to avoid repeating the same conversion from mime 
> types to globs in multiple places.
> 
> 
> Diffs
> -
> 
>   staging/kde4support/src/kssl/kcm/cacertificatespage.cpp 
> e0a66c54633f457322729eecc0395baae8a5c548 
>   kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 
> 
> Diff: http://git.reviewboard.kde.org/r/113095/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Teo Mrnjavac
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41214
---


Nothing serious, just some nitpicking.


experimental/kdeclarative/bindings/backportglobal.h


missing spaces in `typeName.size()-1` and trailing space after .const.

Would be more readable to move typeName.left(...) to its own var.



experimental/kdeclarative/qmlobject.cpp


This is not exactly the same: if I am not mistaken, qWarning() will add 
extra spaces and maybe quotes around the '\n'.


- Aurélien Gâteau


On Oct. 3, 2013, 10:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 10:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41215
---

Ship it!


Looking good, lots of incremental improvements, too.

I suppose we need to adjust the linker targets in plasma-framework and 
kde-workspace, too? If you don't have a patch for that as well, let me know, 
and I'll change it shortly after you've committed this one.

- Sebastian Kügler


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Sebastian Kügler]

> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote:
> > Looking good, lots of incremental improvements, too.
> > 
> > I suppose we need to adjust the linker targets in plasma-framework and 
> > kde-workspace, too? If you don't have a patch for that as well, let me 
> > know, and I'll change it shortly after you've committed this one.

Ow, the test you mention can just be disabled. It probably needs rewriting, at 
least, it has to move into plasma-framework.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41215
---


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/
---

(Updated Oct. 4, 2013, 11:52 a.m.)


Review request for KDE Frameworks.


Changes
---

Fix all Aleix's comments


Repository: kdelibs


Description
---

Prepare kpty for moving


Diffs (updated)
-

  kpty/tests/CMakeLists.txt 1f39830 
  kpty/src/CMakeLists.txt PRE-CREATION 
  kpty/kptyprocess.cpp  
  kpty/kptyprocess.h  
  kpty/kptydevice.h  
  kpty/kptydevice.cpp  
  kpty/kpty_p.h  
  kpty/kpty.cpp  
  kpty/kgrantpty.c  
  kpty/kpty.h  
  kpty/config-pty.h.cmake  
  kpty/KPtyConfig.cmake.in PRE-CREATION 
  kpty/ConfigureChecks.cmake  
  kpty/CMakeLists.txt ecc296c 

Diff: http://git.reviewboard.kde.org/r/113088/diff/


Testing
---

Builds. 


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/#review41217
---



kpty/CMakeLists.txt


You're missing KCoreAddons here. Though I'm not sure if you need to care 
about it now since we don't care about individual builds of tiers >1 yet...



kpty/KPtyConfig.cmake.in


You probably don't need this as you don't link to it in LINK_PUBLIC.

Actually is there any actual usage of i18n? This was in kdesu as well but 
no i18n was used.


- Martin Klapetek


On Oct. 4, 2013, 11:52 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113088/
> ---
> 
> (Updated Oct. 4, 2013, 11:52 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Prepare kpty for moving
> 
> 
> Diffs
> -
> 
>   kpty/tests/CMakeLists.txt 1f39830 
>   kpty/src/CMakeLists.txt PRE-CREATION 
>   kpty/kptyprocess.cpp  
>   kpty/kptyprocess.h  
>   kpty/kptydevice.h  
>   kpty/kptydevice.cpp  
>   kpty/kpty_p.h  
>   kpty/kpty.cpp  
>   kpty/kgrantpty.c  
>   kpty/kpty.h  
>   kpty/config-pty.h.cmake  
>   kpty/KPtyConfig.cmake.in PRE-CREATION 
>   kpty/ConfigureChecks.cmake  
>   kpty/CMakeLists.txt ecc296c 
> 
> Diff: http://git.reviewboard.kde.org/r/113088/diff/
> 
> 
> Testing
> ---
> 
> Builds. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/#review41218
---



kpty/tests/CMakeLists.txt


Also shouldn't this be replaced with some non-kde4 thing?


- Martin Klapetek


On Oct. 4, 2013, 11:52 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113088/
> ---
> 
> (Updated Oct. 4, 2013, 11:52 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Prepare kpty for moving
> 
> 
> Diffs
> -
> 
>   kpty/tests/CMakeLists.txt 1f39830 
>   kpty/src/CMakeLists.txt PRE-CREATION 
>   kpty/kptyprocess.cpp  
>   kpty/kptyprocess.h  
>   kpty/kptydevice.h  
>   kpty/kptydevice.cpp  
>   kpty/kpty_p.h  
>   kpty/kpty.cpp  
>   kpty/kgrantpty.c  
>   kpty/kpty.h  
>   kpty/config-pty.h.cmake  
>   kpty/KPtyConfig.cmake.in PRE-CREATION 
>   kpty/ConfigureChecks.cmake  
>   kpty/CMakeLists.txt ecc296c 
> 
> Diff: http://git.reviewboard.kde.org/r/113088/diff/
> 
> 
> Testing
> ---
> 
> Builds. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

[Teo Mrnjavac]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113095/
---

(Updated Oct. 4, 2013, 12:02 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure and Kevin Ottens.


Repository: kdelibs


Description
---

Now that https://codereview.qt-project.org/#change,63345 is merged, this commit 
replaces usage of setNameFilters in some QFileDialog instances in favor of 
setMimeTypeFilters to avoid repeating the same conversion from mime types to 
globs in multiple places.


Diffs
-

  staging/kde4support/src/kssl/kcm/cacertificatespage.cpp 
e0a66c54633f457322729eecc0395baae8a5c548 
  kross/ui/view.cpp 9edc3e52b9dc8b57aadf1eec5f5e4069c95339d2 

Diff: http://git.reviewboard.kde.org/r/113095/diff/


Testing
---


Thanks,

Teo Mrnjavac

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41220
---

Ship it!


+1 for taking care of this.

I'm noticing now there are still some qscriptengine remnants that should be 
removed, i would do it after the move tough


experimental/kdeclarative/bindings/backportglobal.h


backportglobal should be not needed anymore since we don't have 
qscriptengine anymore (needs to be tested tough)



experimental/kdeclarative/bindings/i18n.cpp


this file (probably the bindings folder too) could go as well


- Marco Martin


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/
---

(Updated Oct. 4, 2013, 12:14 p.m.)


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Prepare kpty for moving


Diffs (updated)
-

  kpty/kpty.h  
  kpty/kgrantpty.c  
  kpty/config-pty.h.cmake  
  kpty/KPtyConfig.cmake.in PRE-CREATION 
  kpty/ConfigureChecks.cmake  
  kpty/CMakeLists.txt ecc296c 
  kpty/kpty.cpp  
  kpty/kpty_p.h  
  kpty/kptydevice.h  
  kpty/kptydevice.cpp  
  kpty/kptyprocess.h  
  kpty/kptyprocess.cpp  
  kpty/src/CMakeLists.txt PRE-CREATION 
  kpty/tests/CMakeLists.txt 1f39830 

Diff: http://git.reviewboard.kde.org/r/113088/diff/


Testing
---

Builds. 


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/#review41223
---



kpty/CMakeLists.txt


This would break the build iirc, you need to add the if (NOT 
KDELIBS_SRC_dir) thing, look at other fws in tiers2/3


- Martin Klapetek


On Oct. 4, 2013, 12:14 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113088/
> ---
> 
> (Updated Oct. 4, 2013, 12:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Prepare kpty for moving
> 
> 
> Diffs
> -
> 
>   kpty/kpty.h  
>   kpty/kgrantpty.c  
>   kpty/config-pty.h.cmake  
>   kpty/KPtyConfig.cmake.in PRE-CREATION 
>   kpty/ConfigureChecks.cmake  
>   kpty/CMakeLists.txt ecc296c 
>   kpty/kpty.cpp  
>   kpty/kpty_p.h  
>   kpty/kptydevice.h  
>   kpty/kptydevice.cpp  
>   kpty/kptyprocess.h  
>   kpty/kptyprocess.cpp  
>   kpty/src/CMakeLists.txt PRE-CREATION 
>   kpty/tests/CMakeLists.txt 1f39830 
> 
> Diff: http://git.reviewboard.kde.org/r/113088/diff/
> 
> 
> Testing
> ---
> 
> Builds. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Aleix Pol Gonzalez]

> On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote:
> > experimental/kdeclarative/bindings/backportglobal.h, line 24
> > 
> >
> > backportglobal should be not needed anymore since we don't have 
> > qscriptengine anymore (needs to be tested tough)

Note that QtScript is still a dependency of the module.


> On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote:
> > experimental/kdeclarative/bindings/i18n.cpp, line 31
> > 
> >
> > this file (probably the bindings folder too) could go as well

I don't think I have the authority to remove anything. Also note that we're 
supposed to be backwards compatible, at least to some extent...


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41220
---


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Aleix Pol Gonzalez]

> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote:
> > Looking good, lots of incremental improvements, too.
> > 
> > I suppose we need to adjust the linker targets in plasma-framework and 
> > kde-workspace, too? If you don't have a patch for that as well, let me 
> > know, and I'll change it shortly after you've committed this one.
> 
> Sebastian Kügler wrote:
> Ow, the test you mention can just be disabled. It probably needs 
> rewriting, at least, it has to move into plasma-framework.

Still, we want to have the module unit-tested.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41215
---


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

CMake templates

[Aurélien Gâteau]

Hi,

In case you missed them, CMake templates for frameworks were merged into the 
frameworks branch yesterday. You can now find a "template" dir in "kdelibs", 
with all the necessary scaffolding to create a new framework.

These template files can be used for two things:

- To create new frameworks: there is a setup.sh in the folder which will copy 
the files and do the appropriate renaming

- As a reference when splitting frameworks: if you get strange cmake errors 
while building, check your framework structure matches with the templates.

For this to be useful it has to be kept updated, I am going to do my best 
there, but if you spot anything strange or outdated in there, please notify 
the list and/or fix it.

Note that the templates themselves are "buildable": you can create a build 
dir, point cmake to the "template" dir and "make install" a (useless) 
libFooBar.so.

Aurélien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Sebastian Kügler]

> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote:
> > Looking good, lots of incremental improvements, too.
> > 
> > I suppose we need to adjust the linker targets in plasma-framework and 
> > kde-workspace, too? If you don't have a patch for that as well, let me 
> > know, and I'll change it shortly after you've committed this one.
> 
> Sebastian Kügler wrote:
> Ow, the test you mention can just be disabled. It probably needs 
> rewriting, at least, it has to move into plasma-framework.
> 
> Aleix Pol Gonzalez wrote:
> Still, we want to have the module unit-tested.

Sure, but this test doesn't and can't do it.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41215
---


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Qt 5.2, test failures and rebuilds

[Aurélien Gâteau]

Hi,

I spent a bit of time this morning investigating why the khtmlparttest was 
failing on build.kde.org after its Qt copy was switched to 5.2 [1].

Error looked very strange:

QMetaType::registerType: Binary compatibility break -- Size mismatch for type 
'QtMetaTypePrivate::QSequentialIterableImpl' [1033]. Previously registered 
size 96, now registering size 104.
/srv/jenkins/workspace/kdelibs_frameworks_qt5/build/khtml/tests/khtmlparttest.shell:
 
line 4: 15748
Aborted (core dumped) 

It turned out build.kde.org had kept a build of Phonon from before the switch 
to Qt 5.2, and Phonon was registering the type with the wrong size. Rebuilding 
Phonon and kdelibs fixed the build.

@Steve: Could this be related to the BIC changes you mentioned in: 
http://lists.kde.org/?l=kde-frameworks-devel&m=137908400611851&w=2 ? The 
changes touch iterators.

Aurélien

[1]: 
http://build.kde.org/job/kdelibs_frameworks_qt5/1338/testReport/junit/%28root%29/TestSuite/khtmlparttest/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/
---

(Updated Oct. 4, 2013, 1:43 p.m.)


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Prepare kpty for moving


Diffs (updated)
-

  kpty/CMakeLists.txt ecc296c 
  kpty/ConfigureChecks.cmake  
  kpty/KPtyConfig.cmake.in PRE-CREATION 
  kpty/config-pty.h.cmake  
  kpty/kgrantpty.c  
  kpty/kpty.h  
  kpty/kpty.cpp  
  kpty/kpty_p.h  
  kpty/kptydevice.h  
  kpty/kptydevice.cpp  
  kpty/kptyprocess.h  
  kpty/kptyprocess.cpp  
  kpty/src/CMakeLists.txt PRE-CREATION 
  kpty/tests/CMakeLists.txt 1f39830 

Diff: http://git.reviewboard.kde.org/r/113088/diff/


Testing
---

Builds. 


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/#review41228
---

Ship it!


Ship It!

- Martin Klapetek


On Oct. 4, 2013, 1:43 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113088/
> ---
> 
> (Updated Oct. 4, 2013, 1:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Prepare kpty for moving
> 
> 
> Diffs
> -
> 
>   kpty/CMakeLists.txt ecc296c 
>   kpty/ConfigureChecks.cmake  
>   kpty/KPtyConfig.cmake.in PRE-CREATION 
>   kpty/config-pty.h.cmake  
>   kpty/kgrantpty.c  
>   kpty/kpty.h  
>   kpty/kpty.cpp  
>   kpty/kpty_p.h  
>   kpty/kptydevice.h  
>   kpty/kptydevice.cpp  
>   kpty/kptyprocess.h  
>   kpty/kptyprocess.cpp  
>   kpty/src/CMakeLists.txt PRE-CREATION 
>   kpty/tests/CMakeLists.txt 1f39830 
> 
> Diff: http://git.reviewboard.kde.org/r/113088/diff/
> 
> 
> Testing
> ---
> 
> Builds. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/
---

(Updated Oct. 4, 2013, 1:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Prepare kpty for moving


Diffs
-

  kpty/CMakeLists.txt ecc296c 
  kpty/ConfigureChecks.cmake  
  kpty/KPtyConfig.cmake.in PRE-CREATION 
  kpty/config-pty.h.cmake  
  kpty/kgrantpty.c  
  kpty/kpty.h  
  kpty/kpty.cpp  
  kpty/kpty_p.h  
  kpty/kptydevice.h  
  kpty/kptydevice.cpp  
  kpty/kptyprocess.h  
  kpty/kptyprocess.cpp  
  kpty/src/CMakeLists.txt PRE-CREATION 
  kpty/tests/CMakeLists.txt 1f39830 

Diff: http://git.reviewboard.kde.org/r/113088/diff/


Testing
---

Builds. 


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113094: Last CMake changes for KDESu

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113094/#review41230
---


This review has been submitted with commit 
75321bcb9d146b0e3625a3abf8fcce43fbf8749f by Martin Klapetek to branch 
frameworks.

- Commit Hook


On Oct. 4, 2013, 9:58 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113094/
> ---
> 
> (Updated Oct. 4, 2013, 9:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Some last modifications needed for moving
> 
> 
> Diffs
> -
> 
>   staging/kdesu/src/CMakeLists.txt 60f43a6 
>   staging/kdesu/KDESuConfig.cmake.in 44caead 
>   staging/kdesu/CMakeLists.txt 93e5eba 
> 
> Diff: http://git.reviewboard.kde.org/r/113094/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113088/#review41229
---


This review has been submitted with commit 
ebbf43004f9874c25d501cb8e683d8a901cb13a7 by David Edmundson to branch 
frameworks.

- Commit Hook


On Oct. 4, 2013, 1:43 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113088/
> ---
> 
> (Updated Oct. 4, 2013, 1:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Prepare kpty for moving
> 
> 
> Diffs
> -
> 
>   kpty/CMakeLists.txt ecc296c 
>   kpty/ConfigureChecks.cmake  
>   kpty/KPtyConfig.cmake.in PRE-CREATION 
>   kpty/config-pty.h.cmake  
>   kpty/kgrantpty.c  
>   kpty/kpty.h  
>   kpty/kpty.cpp  
>   kpty/kpty_p.h  
>   kpty/kptydevice.h  
>   kpty/kptydevice.cpp  
>   kpty/kptyprocess.h  
>   kpty/kptyprocess.cpp  
>   kpty/src/CMakeLists.txt PRE-CREATION 
>   kpty/tests/CMakeLists.txt 1f39830 
> 
> Diff: http://git.reviewboard.kde.org/r/113088/diff/
> 
> 
> Testing
> ---
> 
> Builds. 
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113094: Last CMake changes for KDESu

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113094/
---

(Updated Oct. 4, 2013, 1:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Some last modifications needed for moving


Diffs
-

  staging/kdesu/src/CMakeLists.txt 60f43a6 
  staging/kdesu/KDESuConfig.cmake.in 44caead 
  staging/kdesu/CMakeLists.txt 93e5eba 

Diff: http://git.reviewboard.kde.org/r/113094/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1343

[KDE CI System]

See 

Changes:

[kde] Prepare kpty for moving

--
[...truncated 16909 lines...]
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:30,
 from 
:30,
 from 
:4,
 from 
:1:
:110:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
:115:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:26,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
 from 
:30,
 from 
:30,
 from 
:4,
 from 
:1:
:159:1:
 warning: "WTF_COMPILER_MSVC" is not defined [-Wundef]
In file included from 
:26:0,
 from 
:25,
 from 
:27,
 from 
:28,
 from 
:36,
 from 
:25,
 from 
:24,
 from 
:28,
 from 
:28,
 from 
:27,
  

Build failed in Jenkins: kdelibs_frameworks_qt5 #1344

[KDE CI System]

See 

Changes:

[mklapetek] Prepare CMakeLists.txt for moving KDESu

--
[...truncated 64686 lines...]
-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Set runtime path of 
"
 to 
"/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64:/srv/jenkins/install/linux/x86_64/g++/qt5/qt5/stable/lib:/srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/attica/master/lib64"
-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

[Casian Andrei]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113091/
---

(Updated Oct. 4, 2013, 2:35 p.m.)


Review request for KDE Frameworks and David Faure.


Repository: konsole


Description
---

Build fails following some changes in kdelibs.

Quick fix!


Diffs (updated)
-

  src/BookmarkHandler.h 04e988d 
  src/BookmarkHandler.cpp 7a54b17 

Diff: http://git.reviewboard.kde.org/r/113091/diff/


Testing
---

Not tested, because of some link issue with Ki18n...

Should work though.


Thanks,

Casian Andrei

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113097: KInit splitting

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113097/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Adapts KInit to be moved to its tier, there's still work to do.

The most important change is the creation of a new KF5_ADD_KDEINIT_EXECUTABLE 
macro.
Also I reorganized the source code in different directories, so it's easier to 
figure out.


Diffs
-

  CMakeLists.txt 3204c11 
  KDE5PORTING.html 88700b0 
  cmake/modules/kde4init_dummy.cpp.in  
  cmake/modules/kde4init_win32lib_dummy.cpp.in 0aa704b 
  kded/CMakeLists.txt 5a09a3a 
  kinit/CMakeLists.txt 2e26d91 
  kinit/ConfigureChecks.cmake  
  kinit/Info.plist.template  
  kinit/Mainpage.dox  
  kinit/README  
  kinit/README.autostart  
  kinit/README.wrapper  
  kinit/autostart.h  
  kinit/autostart.cpp  
  kinit/config-kdeinit.h.cmake  
  kinit/kinit.cpp  
  kinit/kinit_win.cpp  
  kinit/kioslave.cpp  
  kinit/klauncher.h  
  kinit/klauncher.cpp  
  kinit/klauncher_adaptor.h  
  kinit/klauncher_adaptor.cpp  
  kinit/klauncher_cmds.h  
  kinit/klauncher_cmds.cpp  
  kinit/klauncher_main.cpp  
  kinit/kwrapper.cpp d43ffc7 
  kinit/kwrapper_win.cpp  
  kinit/proctitle.h  
  kinit/proctitle.cpp  
  kinit/shell.cpp ccb42ed 
  kinit/start_kdeinit.c  
  kinit/start_kdeinit_wrapper.c  
  kinit/wrapper.cpp  
  kioslave/http/CMakeLists.txt 5dfcbce 
  staging/CMakeLists.txt 5c5c80c 
  staging/kinit/CMakeLists.txt PRE-CREATION 
  staging/kinit/KInitMacros.cmake PRE-CREATION 
  staging/kinit/src/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kdeinit/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kioslave/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/klauncher/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kshell/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/kwrapper/CMakeLists.txt PRE-CREATION 
  staging/kinit/src/start_kdeinit/CMakeLists.txt PRE-CREATION 
  tier1/kwindowsystem/src/CMakeLists.txt 00c92de 

Diff: http://git.reviewboard.kde.org/r/113097/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kio-related build error in plasma-framework

[Sebastian Kügler]

Hi,

I'm getting a build error in a few places in plasma-framework, kio isn't 
found. I can't seem to figure out why, maybe someone who has a better overview 
of what in KIO is where, and what I need to tell cmake to figure this out?

The error is:
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: 
cannot find -lkio
collect2: error: ld returned 1 exit status

Others reproduce it, too, so it's blocking us right now.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41235
---


This review has been submitted with commit 
ab56e2f383b4e55a7af54f0d3aeecb45454674be by Aleix Pol to branch frameworks.

- Commit Hook


On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113086/
> ---
> 
> (Updated Oct. 3, 2013, 8:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Reorganizes the file structure as the KF5 module suggest.
> Adopts newer syntaxes for defining dependencies.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3204c11 
>   experimental/CMakeLists.txt e73a8c4 
>   experimental/COPYING 5185fd3 
>   experimental/COPYING.LIB 2d2d780 
>   experimental/CTestConfig.cmake c383ee1 
>   experimental/KDELibsExperimentalNightly.cmake fd53e0c 
>   experimental/kdeclarative/CMakeLists.txt 72ea7a2 
>   experimental/kdeclarative/bindings/backportglobal.h fca8ade 
>   experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
>   experimental/kdeclarative/bindings/i18n_p.h  
>   experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
>   experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
>   experimental/kdeclarative/bindings/url.cpp 3031a6f 
>   experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
>   experimental/kdeclarative/configpropertymap.h c9ef3ae 
>   experimental/kdeclarative/configpropertymap.cpp 373a655 
>   experimental/kdeclarative/kdeclarative.h  
>   experimental/kdeclarative/kdeclarative.cpp 63ae180 
>   experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
>   experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
>   experimental/kdeclarative/private/kdeclarative_p.h  
>   experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
>   experimental/kdeclarative/private/kiconprovider_p.h  
>   experimental/kdeclarative/private/rootcontext.cpp  
>   experimental/kdeclarative/private/rootcontext_p.h  
>   experimental/kdeclarative/qmlobject.h  
>   experimental/kdeclarative/qmlobject.cpp ee81b41 
>   experimental/kdeclarative/qmlobject_p.h  
>   experimental/kdeclarative/test/test.cpp 3986b77 
>   experimental/kdeclarative/test/test.qml 060c265 
>   experimental/kdeclarative/test/testobject_p.h  
>   staging/CMakeLists.txt 5c5c80c 
>   staging/kdeclarative/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
>   staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
>   staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113086/diff/
> 
> 
> Testing
> ---
> 
> Builds.
> There's a test that tests things that are not part either of this module or 
> its dependencies:
> 
> import Qt 4.7
> import org.kde.plasma.core 0.1 as PlasmaCore
> import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets
> 
> I'm unsure what to do with those. (can do in a further commit, we're not 
> moving the module to its tier yet)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/
---

(Updated Oct. 4, 2013, 4:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Repository: kdelibs


Description
---

Reorganizes the file structure as the KF5 module suggest.
Adopts newer syntaxes for defining dependencies.


Diffs
-

  CMakeLists.txt 3204c11 
  experimental/CMakeLists.txt e73a8c4 
  experimental/COPYING 5185fd3 
  experimental/COPYING.LIB 2d2d780 
  experimental/CTestConfig.cmake c383ee1 
  experimental/KDELibsExperimentalNightly.cmake fd53e0c 
  experimental/kdeclarative/CMakeLists.txt 72ea7a2 
  experimental/kdeclarative/bindings/backportglobal.h fca8ade 
  experimental/kdeclarative/bindings/i18n.cpp 75a67aa 
  experimental/kdeclarative/bindings/i18n_p.h  
  experimental/kdeclarative/bindings/icon.cpp dbdc8fe 
  experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 
  experimental/kdeclarative/bindings/url.cpp 3031a6f 
  experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 
  experimental/kdeclarative/configpropertymap.h c9ef3ae 
  experimental/kdeclarative/configpropertymap.cpp 373a655 
  experimental/kdeclarative/kdeclarative.h  
  experimental/kdeclarative/kdeclarative.cpp 63ae180 
  experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a 
  experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 
  experimental/kdeclarative/private/kdeclarative_p.h  
  experimental/kdeclarative/private/kiconprovider.cpp 8506b8b 
  experimental/kdeclarative/private/kiconprovider_p.h  
  experimental/kdeclarative/private/rootcontext.cpp  
  experimental/kdeclarative/private/rootcontext_p.h  
  experimental/kdeclarative/qmlobject.h  
  experimental/kdeclarative/qmlobject.cpp ee81b41 
  experimental/kdeclarative/qmlobject_p.h  
  experimental/kdeclarative/test/test.cpp 3986b77 
  experimental/kdeclarative/test/test.qml 060c265 
  experimental/kdeclarative/test/testobject_p.h  
  staging/CMakeLists.txt 5c5c80c 
  staging/kdeclarative/CMakeLists.txt PRE-CREATION 
  staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION 
  staging/kdeclarative/src/CMakeLists.txt PRE-CREATION 
  staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113086/diff/


Testing
---

Builds.
There's a test that tests things that are not part either of this module or its 
dependencies:

import Qt 4.7
import org.kde.plasma.core 0.1 as PlasmaCore
import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets

I'm unsure what to do with those. (can do in a further commit, we're not moving 
the module to its tier yet)


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1346

[KDE CI System]

See 

Changes:

[aleixpol] KDeclarative cleanup

--
[...truncated 64701 lines...]
-- Installing: 

-- Set runtime path of 
"
 to 
"/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64:/srv/jenkins/install/linux/x86_64/g++/qt5/qt5/stable/lib:/srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/attica/master/lib64"
-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Installing: 

-- Set runtime path of 
"
 to 
"/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/lib64:/srv/jenkins/install/linux/x86_64/g++/qt5/qt5/stable/lib:/srv/jenkins/install/linux/x86_64/g++/qt5/kdesupport/attica/master/lib64"
-- Installing: 

-- Installing: 

Build failed in Jenkins: plasma-framework_master_qt5 #774

[KDE CI System]

See 

Changes:

[hein] Adapt to kdelibs ab56e2f.

--
[...truncated 510 lines...]
Generating moc_panelshadows_p.cpp
Generating moc_panelview.cpp
Generating appinterface.moc
:0:
 Note: No relevant classes found. No output generated.
Generating applet.moc
:0:
 Note: No relevant classes found. No output generated.
Generating configgroup.moc
:0:
 Note: No relevant classes found. No output generated.
Generating moc_abstractrunner.cpp
Generating moc_applet.cpp
Generating moc_containment.cpp
Generating moc_containmentactions.cpp
Generating moc_corona.cpp
Generating moc_datacontainer.cpp
Generating moc_dataengine.cpp
Generating moc_framesvg.cpp
Generating moc_packagestructure.cpp
Generating moc_associatedapplicationmanager_p.cpp
Generating moc_datacontainer_p.cpp
Generating private/moc_dataengineconsumer_p.cpp
Generating moc_dataenginemanager_p.cpp
Generating moc_packagejob_p.cpp
Generating moc_packagejobthread_p.cpp
Generating moc_storage_p.cpp
Generating moc_storagethread_p.cpp
Generating moc_theme_p.cpp
Generating moc_runnercontext.cpp
Generating moc_runnermanager.cpp
Generating moc_appletscript.cpp
Generating moc_dataenginescript.cpp
Generating moc_runnerscript.cpp
Generating moc_scriptengine.cpp
Generating moc_service.cpp
Generating moc_servicejob.cpp
Generating moc_svg.cpp
Generating moc_theme.cpp
Generating moc_plasma.cpp
Generating moc_effectwatcher_p.cpp
[ 20%] Built target plasma_automoc
Generating containment.moc
:0:
 Note: No relevant classes found. No output generated.
Generating desktopscriptengine.moc
:0:
 Note: No relevant classes found. No output generated.
Scanning dependencies of target localebindingsplugin
[ 20%] Building CXX object 
src/declarativeimports/locale/CMakeFiles/localebindingsplugin.dir/locale.cpp.o
Generating layouttemplatepackagestructure.moc
:0:
 Note: No relevant classes found. No output generated.
:37:6:
 warning: unused parameter ‘newState’ [-Wunused-parameter]
:162:6:
 warning: unused parameter ‘source’ [-Wunused-parameter]
Generating panel.moc
:0:
 Note: No relevant classes found. No output generated.
Generating scriptengine.moc
:0:
 Note: No relevant classes found. No output generated.
In file included from 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/KMimeType:1:0,
 from 
:29:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:54:42:
 warning: ‘KMimeType’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/KDE/../kmimetype.h:50)
 [-Wdeprecated-declarations]
In file included from 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
 from 
:23:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:60:52:
 warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63:
 warning: ‘KCmdLineOptions’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:46)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdlineargs.h:65:63:
 warning: ‘KCmdLineOptions’ is deprecated [-Wdeprecated-declarations]
In file included from 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/qtest_kde.h:28:0,
 from 
:23:
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kcmdli

Review Request 113100: Move KDESu to tier3

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113100/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Depends on KService (one call, hard to replace) and KCoreAddons (could be 
probably replaced (KUser::loginName())).


Diffs
-

  staging/CMakeLists.txt 18df1e4 
  staging/kdesu/CMakeLists.txt  
  staging/kdesu/KDESuConfig.cmake.in  
  staging/kdesu/src/CMakeLists.txt  
  staging/kdesu/src/Mainpage.dox  
  staging/kdesu/src/README  
  staging/kdesu/src/client.h  
  staging/kdesu/src/client.cpp  
  staging/kdesu/src/config-kdesu.h.cmake  
  staging/kdesu/src/defaults.h  
  staging/kdesu/src/kcookie.cpp  
  staging/kdesu/src/kcookie_p.h  
  staging/kdesu/src/kdesu_stub.c  
  staging/kdesu/src/process.h  
  staging/kdesu/src/process.cpp  
  staging/kdesu/src/ssh.h  
  staging/kdesu/src/ssh.cpp  
  staging/kdesu/src/stub.h  
  staging/kdesu/src/stub.cpp  
  staging/kdesu/src/su.h  
  staging/kdesu/src/su.cpp  
  tier3/CMakeLists.txt 5d4743f 

Diff: http://git.reviewboard.kde.org/r/113100/diff/


Testing
---

As discussed in the frameworks meeting, KDESu is excused from tests, so no 
tests added. Builds.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_master_qt5 #775

[KDE CI System]

See 

Changes:

[sebas] cmake fixes

--
[...truncated 603 lines...]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:316:71:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:362:23:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:380:55:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:909:17:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:911:35:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:911:35:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:914:38:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:915:43:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:916:40:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:918:37:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:920:37:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:941:82:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:992:64:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1001:40:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1018:42:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1035:39:
 warning: ‘List’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:140)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1035:39:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1044:39:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1044:39:
 warning: ‘List’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1058:66:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1067:73:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1130:67:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1130:67:
 warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:1155:1:
 warning: ‘KUrl’ is deprecated (declared at 
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:105)
 [-Wdeprecated-declarations]
/srv/jenkins/install/linux/x86_64/g++/qt5/kde/kdelibs/frameworks/include/kurl.h:
 In st

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112797/
---

(Updated Oct. 4, 2013, 5:26 p.m.)


Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser.


Changes
---

Add documentation in KDE5Porting.html


Repository: kdelibs


Description
---

Apparently there's people who still want to have it. Leave it in KCoreAddons 
for the moment, until we decide that it can be replaced for good by QCollator.


Diffs (updated)
-

  KDE5PORTING.html 88700b0 
  staging/kde4support/autotests/CMakeLists.txt 473bdba 
  staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION 
  staging/kde4support/src/CMakeLists.txt 51519a3 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION 
  staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION 
  tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 
  tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a 
  tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 

Diff: http://git.reviewboard.kde.org/r/112797/diff/


Testing
---

Builds, tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel