Re: Jenkins build is back to stable : kdelibs_frameworks_qt5 #1386

2013-10-08 Thread Kevin Ottens 
On Wednesday 09 October 2013 06:22:55 KDE CI System wrote:
> See 

\o/

Let's keep kdelibs-frameworks and plasma-framework green now, shall we?

Note however that I still have a pesky issue with kded5 getting stuck, but 
build.kde.org seems unaffected. So don't label me as a happy camper just yet.

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1386

2013-10-08 Thread KDE CI System 
See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112950: Insert the set shortcuts into the internal hash of actions and shortcuts in KGlobalAccel

2013-10-08 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112950/#review41418
---


This review has been submitted with commit 
63866d5cebef2ccceaa642e45dfd624ba95446f5 by Kevin Ottens to branch frameworks.

- Commit Hook


On Sept. 26, 2013, 8:16 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112950/
> ---
> 
> (Updated Sept. 26, 2013, 8:16 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> When calling setShortcut or setDefaultShortcut the new list of shortcuts is 
> not added to the action(Default)Shortcuts map and so the getter methods 
> return an empty shortcut for the given action. This can also be seen when 
> executing the KGlobalShortcutTest::testSetShortcut() testcase against the 
> kde4 kglobalacceld (on the CI it's just skipping this test!). With this patch 
> the testcase succeeds.
> 
> 
> Diffs
> -
> 
>   staging/xmlgui/src/kglobalaccel.cpp f5bcfca 
> 
> Diff: http://git.reviewboard.kde.org/r/112950/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler 


On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote:
> > There's also runner-related code in 
> > src/declarativeimports/{core,runnermodel}, these should be reenabled as 
> > well. Possibly, they also need changes to make built. I had disabled this 
> > after a discussion with Aaron (who has refactored these classes) and 
> > Vishesh, who plans to work on them. I'm not sure what's the most useful, I 
> > can imagine this leading to a lot of conflicts when merging this 
> > refactoring, while the benefits of this patch are then just going away. 
> > Aaron can weigh in here to say what's easiest moving forward. Mirko is the 
> > best person to review the ThreadWeaver API changes you implement. Could you 
> > add him to the reviewers for this request?
> > 
> > thanks...
> 
> Aleix Pol Gonzalez wrote:
> Well, the only reason I did this was because kickoff in kde-workspace 
> requires runners as well. If those are not good anymore, maybe it's wiser to 
> disable them there as well?

Ah, I've missed these. I was operating under the assumption that nobody would 
use runners in Plasma2 yet -- wrong. We can do both, disable runners in kickoff 
or merge this. Let's hear others' opinions.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/#review41412
---


On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113179/
> ---
> 
> (Updated Oct. 8, 2013, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Recently there's been some big changes in the ThreadWeaver API. So big that 
> they break the source compatibility we were supposed to maintain, big time.
> 
> This patch tries to port plasma-framework to that new API.
> 
> 
> Diffs
> -
> 
>   src/plasma/CMakeLists.txt 411256a 
>   src/plasma/private/runnerjobs.cpp d11f7e9 
>   src/plasma/private/runnerjobs_p.h 7fd7076 
>   src/plasma/private/storage.cpp 35b222e 
>   src/plasma/runnermanager.cpp 135279e 
>   src/plasma/scripting/runnerscript.cpp d5142a2 
> 
> Diff: http://git.reviewboard.kde.org/r/113179/diff/
> 
> 
> Testing
> ---
> 
> Everything builds, including kde-workspace.
> 
> Couldn't test it, there's no tests for it or even an application to test it 
> :/.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez 


On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote:
> > There's also runner-related code in 
> > src/declarativeimports/{core,runnermodel}, these should be reenabled as 
> > well. Possibly, they also need changes to make built. I had disabled this 
> > after a discussion with Aaron (who has refactored these classes) and 
> > Vishesh, who plans to work on them. I'm not sure what's the most useful, I 
> > can imagine this leading to a lot of conflicts when merging this 
> > refactoring, while the benefits of this patch are then just going away. 
> > Aaron can weigh in here to say what's easiest moving forward. Mirko is the 
> > best person to review the ThreadWeaver API changes you implement. Could you 
> > add him to the reviewers for this request?
> > 
> > thanks...

Well, the only reason I did this was because kickoff in kde-workspace requires 
runners as well. If those are not good anymore, maybe it's wiser to disable 
them there as well?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/#review41412
---


On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113179/
> ---
> 
> (Updated Oct. 8, 2013, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Recently there's been some big changes in the ThreadWeaver API. So big that 
> they break the source compatibility we were supposed to maintain, big time.
> 
> This patch tries to port plasma-framework to that new API.
> 
> 
> Diffs
> -
> 
>   src/plasma/CMakeLists.txt 411256a 
>   src/plasma/private/runnerjobs.cpp d11f7e9 
>   src/plasma/private/runnerjobs_p.h 7fd7076 
>   src/plasma/private/storage.cpp 35b222e 
>   src/plasma/runnermanager.cpp 135279e 
>   src/plasma/scripting/runnerscript.cpp d5142a2 
> 
> Diff: http://git.reviewboard.kde.org/r/113179/diff/
> 
> 
> Testing
> ---
> 
> Everything builds, including kde-workspace.
> 
> Couldn't test it, there's no tests for it or even an application to test it 
> :/.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113179: Make the runners compile again

2013-10-08 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/#review41412
---



src/plasma/CMakeLists.txt


These 4 headers should be installed again, too 



src/plasma/private/storage.cpp


This should be reenabled as well


There's also runner-related code in src/declarativeimports/{core,runnermodel}, 
these should be reenabled as well. Possibly, they also need changes to make 
built. I had disabled this after a discussion with Aaron (who has refactored 
these classes) and Vishesh, who plans to work on them. I'm not sure what's the 
most useful, I can imagine this leading to a lot of conflicts when merging this 
refactoring, while the benefits of this patch are then just going away. Aaron 
can weigh in here to say what's easiest moving forward. Mirko is the best 
person to review the ThreadWeaver API changes you implement. Could you add him 
to the reviewers for this request?

thanks...

- Sebastian Kügler


On Oct. 8, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113179/
> ---
> 
> (Updated Oct. 8, 2013, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Recently there's been some big changes in the ThreadWeaver API. So big that 
> they break the source compatibility we were supposed to maintain, big time.
> 
> This patch tries to port plasma-framework to that new API.
> 
> 
> Diffs
> -
> 
>   src/plasma/CMakeLists.txt 411256a 
>   src/plasma/private/runnerjobs.cpp d11f7e9 
>   src/plasma/private/runnerjobs_p.h 7fd7076 
>   src/plasma/private/storage.cpp 35b222e 
>   src/plasma/runnermanager.cpp 135279e 
>   src/plasma/scripting/runnerscript.cpp d5142a2 
> 
> Diff: http://git.reviewboard.kde.org/r/113179/diff/
> 
> 
> Testing
> ---
> 
> Everything builds, including kde-workspace.
> 
> Couldn't test it, there's no tests for it or even an application to test it 
> :/.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Sebastian Kügler 


> On Oct. 1, 2013, 2:47 p.m., Sebastian Kügler wrote:
> > kdeui/colors/kcolorschemetoken.h, line 70
> > 
> >
> > using int here loses the type-safety. Why no use the corresponding 
> > enums? It would also make the code more readable.
> > 
> > (Same issue for all the other methods.)
> 
> Denis Kuplyakov wrote:
> I have tried it, but have such errors:
> Error: Unknown method parameter type: QPalette::ColorGroup
> 
> See this: http://qt-project.org/forums/viewthread/10308/ . It seems that 
> the int is only way to make it works correct.

Have you tried registering that enum using qmlRegisterType?


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41068
---


On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> ---
> 
> (Updated Oct. 6, 2013, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them 
> accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to 
> libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames 
> mailinglists *
> 
> 
> Diffs
> -
> 
>   kdeui/CMakeLists.txt b439e04 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> ---
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112880: Added KColorSchemeToken class.

2013-10-08 Thread Denis Kuplyakov 


> On Sept. 29, 2013, 4:24 p.m., David Faure wrote:
> > The name "token" surprises me a bit. Is this a usual naming scheme for 
> > accessing C++ classes from QML?
> > Otherwise I would think the QML code would want to just write KColorScheme.
> > 
> > Maybe the registration could be done in a static method, rather than 
> > letting the apps do it on their own?
> > 
> > The "NEED TO FIX" in the description can be removed, right?
> > 
> > About the branch: I see that the request is correctly for 5.0 - which means 
> > less merging trouble, so it sounds good to me :)
> >
> 
> Denis Kuplyakov wrote:
> We can register it as KColorScheme for QML but in C++ it can't have such 
> name as KColorScheme already exists. Token was first that came to my mind, 
> maybe we can name it KColorSchemeQMLWrapper or smth like this?
> 
> As Kevin suggested maybe it should be placed at some other place, not 
> kdeui? I don't know all structure of kdelibs so I'm hope you will help me.
> 
> Also how can I implement static registration, or what class I can 
> investigate as example?
> 
> I have removed NEED TO FIX...

What is kdelibs/experimental/libkdeclarative ?? Maybe KColorSchemeToken should 
be put there. Does anybody know something about this?


- Denis


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41002
---


On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> ---
> 
> (Updated Oct. 6, 2013, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them 
> accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to 
> libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames 
> mailinglists *
> 
> 
> Diffs
> -
> 
>   kdeui/CMakeLists.txt b439e04 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> ---
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113179: Make the runners compile again

2013-10-08 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113179/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Recently there's been some big changes in the ThreadWeaver API. So big that 
they break the source compatibility we were supposed to maintain, big time.

This patch tries to port plasma-framework to that new API.


Diffs
-

  src/plasma/CMakeLists.txt 411256a 
  src/plasma/private/runnerjobs.cpp d11f7e9 
  src/plasma/private/runnerjobs_p.h 7fd7076 
  src/plasma/private/storage.cpp 35b222e 
  src/plasma/runnermanager.cpp 135279e 
  src/plasma/scripting/runnerscript.cpp d5142a2 

Diff: http://git.reviewboard.kde.org/r/113179/diff/


Testing
---

Everything builds, including kde-workspace.

Couldn't test it, there's no tests for it or even an application to test it :/.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting Minutes 2013-w41

2013-10-08 Thread Kevin Ottens 
Hello everyone,

This is the minutes of the Week 41 KF5 meeting. As usual it has been held on 
#kde-devel at 4pm Paris time.

Were present: afiestas, agateau, apol, jpwhiting, mck182, sebas, shadeslayer, 
teo, vHanda, wojtask9 and myself.

Announcement:
 * If you didn't read my email on stop the line events yet go read it now;
 * Don't ignore build.kde.org, fixing the build should always have top 
priority (kdelibs-frameworks and plasma-framework should always be green);
 * Try to not break the build in the first place, take measures like clean 
build before pushes;
 * Seriously...

Topics discussed:
 * afiestas finished moving some frameworks to tier 3;
 * he's working on kded at the moment;

 * agateau has finished the kf5 cmake template;
 * kconfigwidgets moved to tier 3;
 * fixed kcookiejartest (you get a cookie then);
 * working on improvements for KMessageBox code;

 * apol is splitting kinit;
 * he's also making sure all modules find their packages properly;
 * he'll also soon prepare kjsembed;

 * jpwhiting is working on knewstuff;

 * mck182 moved kprintutils and kdesu;
 * he's looking at ktimezoned;

 * sebas is removing kde4support uses in plasma-framework;
 * he's also porting away from kde4support in kde-workspace;
 * regularly build fixing;
 * systemtray work is in progress;
 * libdbusmenu-qt cmake work too;

 * shadeslayer is working on QErrorMessage;
 * he's also working on KDialogJobUiDelegate queueing;
 * he's also trying to remove KTextEditSpellInterface;

 * teo is waiting on dfaure's kfile changes to wrap up KEncodingFileDialog 
refactoring;
 * in the meantime he's porting kscmserver

 * vHanda is fixing up kross to get it in the frameworks regular form;
 * he's also removing the nepomuk dependencies from kde4support;

 * wojtask9 is still working on the dependency graph generator, should publish 
tomorrow;

 * ervin is just trying to have a green build.kde.org again... still some 
tests aren't run with "make test" for some reason...

If you got questions, feel free to ask.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5_add_kdeinit_executable broken?

2013-10-08 Thread Aleix Pol 
On Tue, Oct 8, 2013 at 2:28 PM, Sebastian Kügler  wrote:

> Hi,
>
> in Kwin (kde-workspace) we're running into the following error:
>
> CMake Error: File /home/sebas/kf5/src/kde-
> workspace/kwin/kcmkwin/kwinrules/_KDE5INIT_DUMMY_FILEPATH-NOTFOUND does not
> exist.
> CMake Error at
> /home/sebas/kf5/install/lib64/cmake/KInit/KInitMacros.cmake:17
> (configure_file):
>   configure_file Problem configuring file
> Call Stack (most recent call first):
>   kwin/kcmkwin/kwinrules/CMakeLists.txt:12 (kf5_add_kdeinit_executable)
>
> CMake Error at kwin/kcmkwin/kwinrules/CMakeLists.txt:32
> (target_link_libraries):
>   Cannot specify link libraries for target "kdeinit_kwin_rules_dialog"
> which
>   is not built by this project.
>
> -- Configuring incomplete, errors occurred!
>
>
> This cropped up after KInit splitting. Any ideas?
>
> Thanks,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

I'm on it.. building kde-workspace

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113174: Cleanup KJsEmbed

2013-10-08 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Adopt directory organization, naming scheme, cmake structures, documents 
dependencies.


Diffs
-

  CMakeLists.txt 368584e 
  kjsembed/AUTHORS  
  kjsembed/CMakeLists.txt 6cb6727 
  kjsembed/Mainpage.dox  
  kjsembed/examples/calc/calc.js  
  kjsembed/examples/calc/calc.ui  
  kjsembed/examples/console/console.js  
  kjsembed/examples/console/console.ui  
  kjsembed/examples/docviewer/docviewer.js  
  kjsembed/examples/docviewer/docviewer.ui  
  kjsembed/examples/fancy/fancy.js  
  kjsembed/examples/grammar/grammar.js  
  kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b 
  kjsembed/examples/kjsconsole/console.h  
  kjsembed/examples/kjsconsole/console.cpp f65f39b 
  kjsembed/examples/kjsconsole/console.qrc  
  kjsembed/examples/kjsconsole/images/bug.png  
  kjsembed/examples/kjsconsole/images/class.png  
  kjsembed/examples/kjsconsole/images/constant.png  
  kjsembed/examples/kjsconsole/images/method.png  
  kjsembed/examples/kjsconsole/images/next.png  
  kjsembed/examples/kjsconsole/images/no.png  
  kjsembed/examples/kjsconsole/images/property.png  
  kjsembed/examples/kjsconsole/images/runto.png  
  kjsembed/examples/kjsconsole/images/start.png  
  kjsembed/examples/kjsconsole/images/step.png  
  kjsembed/examples/kjsconsole/images/stop.png  
  kjsembed/examples/kjsconsole/jsconsole.ui  
  kjsembed/examples/kjsconsole/kjs_object_model.h  
  kjsembed/examples/kjsconsole/kjs_object_model.cpp  
  kjsembed/examples/kjsconsole/main.cpp  
  kjsembed/examples/kjsconsole/numberedtextview.h  
  kjsembed/examples/kjsconsole/numberedtextview.cpp f144502 
  kjsembed/examples/scribble/scribble.js  
  kjsembed/examples/tests/args.js  
  kjsembed/examples/tests/brush.js  
  kjsembed/examples/tests/builtins.js  
  kjsembed/examples/tests/class.js  
  kjsembed/examples/tests/colortest.js  
  kjsembed/examples/tests/conio.js  
  kjsembed/examples/tests/domtest.js  
  kjsembed/examples/tests/events.js  
  kjsembed/examples/tests/fileio.js  
  kjsembed/examples/tests/fonttest.js  
  kjsembed/examples/tests/frame.js  
  kjsembed/examples/tests/gc.js  
  kjsembed/examples/tests/include.js  
  kjsembed/examples/tests/inner.js  
  kjsembed/examples/tests/jsslot.js  
  kjsembed/examples/tests/layout.js  
  kjsembed/examples/tests/library.js  
  kjsembed/examples/tests/listproperties.js  
  kjsembed/examples/tests/matt.js  
  kjsembed/examples/tests/paintertest.js  
  kjsembed/examples/tests/paintevent.js  
  kjsembed/examples/tests/pixmap.js  
  kjsembed/examples/tests/recttest.js  
  kjsembed/examples/tests/settings.js  
  kjsembed/examples/tests/signslots.js  
  kjsembed/examples/tests/statictest.js  
  kjsembed/examples/tests/stylesheet.js  
  kjsembed/examples/tests/svgtest.js  
  kjsembed/examples/tests/system.js  
  kjsembed/examples/tests/test.svg  
  kjsembed/examples/tests/test.ui  
  kjsembed/examples/tests/typecheck.js  
  kjsembed/examples/tests/uitest.js  
  kjsembed/examples/tests/uitest2.js  
  kjsembed/examples/tests/url.js  
  kjsembed/examples/tests/widgettest.js  
  kjsembed/kjscmd/CMakeLists.txt eeb5667 
  kjsembed/kjscmd/console.js  
  kjsembed/kjscmd/kjscmd.cpp df833db 
  kjsembed/kjscmd/kjscmd.qrc  
  kjsembed/kjsembed/CMakeLists.txt 8089c4b 
  kjsembed/kjsembed/QBrush_bind.h  
  kjsembed/kjsembed/QBrush_bind.cpp  
  kjsembed/kjsembed/application.h  
  kjsembed/kjsembed/application.cpp  
  kjsembed/kjsembed/binding_support.h  
  kjsembed/kjsembed/binding_support.cpp  
  kjsembed/kjsembed/brush.h  
  kjsembed/kjsembed/brush.cpp  
  kjsembed/kjsembed/builtins.h  
  kjsembed/kjsembed/builtins.cpp  
  kjsembed/kjsembed/color.h  
  kjsembed/kjsembed/color.cpp  
  kjsembed/kjsembed/dom.h  
  kjsembed/kjsembed/dom.cpp  
  kjsembed/kjsembed/eventproxy.h  
  kjsembed/kjsembed/eventproxy.cpp  
  kjsembed/kjsembed/filedialog_binding.h  
  kjsembed/kjsembed/filedialog_binding.cpp  
  kjsembed/kjsembed/fileio.h  
  kjsembed/kjsembed/fileio.cpp  
  kjsembed/kjsembed/font.h  
  kjsembed/kjsembed/font.cpp  
  kjsembed/kjsembed/image.h  
  kjsembed/kjsembed/image.cpp  
  kjsembed/kjsembed/iosupport.h  
  kjsembed/kjsembed/iosupport.cpp  
  kjsembed/kjsembed/jseventmapper.h  
  kjsembed/kjsembed/jseventmapper.cpp  
  kjsembed/kjsembed/jseventutils.h  
  kjsembed/kjsembed/jseventutils.cpp  
  kjsembed/kjsembed/kjseglobal.h  
  kjsembed/kjsembed/kjseglobal.cpp  
  kjsembed/kjsembed/kjsembed.h 74dfab8 
  kjsembed/kjsembed/kjsembed.cpp  
  kjsembed/kjsembed/object_binding.h  
  kjsembed/kjsembed/object_binding.cpp  
  kjsembed/kjsembed/pen.h  
  kjsembed/kjsembed/pen.cpp  
  kjsembed/kjsembed/pixmap.h  
  kjsembed/kjsembed/pixmap.cpp  
  kjsembed/kjsembed/point.h  
  kjsembed/kjsembed/point.cpp  
  kjsembed/kjsembed/poin

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

2013-10-08 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112984/#review41393
---

Ship it!


Ship It!

- Aurélien Gâteau


On Oct. 8, 2013, 12:08 a.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112984/
> ---
> 
> (Updated Oct. 8, 2013, 12:08 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Adjust API in KEmoticons framework: KEmoticonsProvider::save()
> 
> -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
> and prefer saveTheme() instead.
> -Adjust plugins.
> -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
> which was empty. Now it's a pure virtual function. Therefore, I deprecate
> it and advice subclassing KEmoticonsProvider.
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 
> 0dc92ed092d87a559fe7fa1a40e804843ab73d59 
>   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 
> 0873a635a300e0ed8e38b1d59a535d6ec15b99cb 
>   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 
> e9f89eecce3d6e6407113a84cb5200ff66564c19 
>   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 
> 70bafa3fe4ba25c9d6a69634024b2c157235e674 
>   staging/kemoticons/src/providers/kde/kde_emoticons.cpp 
> 5b5114a14dd94a6ebcba8a6f7dd163f73048189a 
>   staging/kemoticons/src/providers/kde/kde_emoticons.h 
> 8cba6b194eee1543bf13f1177a0e4092f1a10943 
>   staging/kemoticons/src/providers/adium/adium_emoticons.cpp 
> a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 
>   staging/kemoticons/src/providers/adium/adium_emoticons.h 
> 039a267679919c968bbe4d12c35abb90cf1bcc9b 
>   staging/kemoticons/src/core/kemoticonstheme.cpp 
> ed3407cdd45c84d91f2d0057e108b760ff696ff2 
>   staging/kemoticons/src/core/kemoticonstheme.h 
> b8b25f7607d3741dda78d6302c1ed81fbc9211a0 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp 
> d04c76e87b118f5d45717b3b2ccd9dea47dc2526 
>   staging/kemoticons/src/core/kemoticonsprovider.h 
> 85fc7efb8923d76476f0a16f70f8ebb15e451081 
>   KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d 
> 
> Diff: http://git.reviewboard.kde.org/r/112984/diff/
> 
> 
> Testing
> ---
> 
> It builds. It installs. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Aleix Pol 
On Tue, Oct 8, 2013 at 3:50 PM, Stephen Kelly  wrote:

> Stephen Kelly wrote:
>
> >> These are defined with "1" if acceptable and undefined if the feature is
> >> not present.
> >
> > This is the problem that should be fixed.
> >
> > It should be 0 if the feature is not present. Please fix that instead.
>
> Hmm, or maybe your fix is ok.
>
> I don't know where the values come from, but there seems to be a code smell
> somewhere...
>
> Thanks,
>
> Steve.
>
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

If you take a look at the code, you'll see that it's what the original
author meant.

I thought about adding all the alternatives, but I don't think it would
make sense, especially given they are meant to be checked through the
macros.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Stephen Kelly 
Stephen Kelly wrote:

>> These are defined with "1" if acceptable and undefined if the feature is
>> not present.
> 
> This is the problem that should be fixed.
> 
> It should be 0 if the feature is not present. Please fix that instead.

Hmm, or maybe your fix is ok. 

I don't know where the values come from, but there seems to be a code smell 
somewhere...

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Stephen Kelly 
Aleix Pol Gonzalez wrote:

> This patch adds a defined() first, before checking the value, so the
> pre-processor doesn't need to consider the variable value, if it's not
> present.

This seems like a bad idea.

> These are defined with "1" if acceptable and undefined if the feature is 
> not present.

This is the problem that should be fixed. 

It should be 0 if the feature is not present. Please fix that instead.

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[IMPORTANT] Stop the line events

2013-10-08 Thread Kevin Ottens 
Hello people,

I said it previously but I'll repeat it again:
---
If build.kde.org is not green for kdelibs-frameworks or plasma-framework 
build, no changes should get in apart from attempts at fixing the problem.
---

So far, it has been completely ignored and that's really a bad situation. We 
made lists of tasks, the goal is not to take as many as possible in parallel 
and throw patches at them as fast as possible.
The goal is to get through them while maintaining or increasing the quality. 
Our build history tells me there's either a general lack of disdain for 
quality, or some of us don't know how to look at the clues we have.

I've been spending most of my time on KF5 lately just fixing builds. It's not 
good and not warranted. This week is really over the top in breakages:
 * yesterday we had more than a hundred of our test suites not running on a 
make test (I'm still not done having all of them back, still investigating);
 * today I still have test regressions in two test suites (as can be seen on 
build.kde.org, still investigating).

The issue is not who or what introduced those problems (some of them likely 
come from the switch to qt5/stable), the issue is that we are ignoring 
build.kde.org reports. That has to change, now!

So here is a list of ideas on how to improve:
 * if you are merging a branch or moving something around: then make a clean 
build (removing both build and install dirs) before your push, you will likely 
catch something;
 * if you see that build.kde.org is not green: then try to find a solution, 
don't just keep pushing patches which will introduce further instabilities;
 * if you see that build.kde.org is not green: then don't post or review 
patches which are not working toward getting the build in shape again.

In case you didn't notice, I've been applying all of that myself (for instance 
I reviewed exactly one patch today because it fixed a regression, ignored 
everything else). I'm making myself slower but it's the speed of the team 
which matters, and rework just slows the whole team...

Obviously, for the time being I don't want to see any push in kdelibs 
frameworks which doesn't aim at fixing one of the problems we have in the 
build currently.

Thanks for your attention, I hope I won't need to bring up this topic again.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com


signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-08 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113173/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Modifies how features are checked. This file has some pre-processor macros that 
are used to checking for OS features. These are defined with "1" if acceptable 
and undefined if the feature is not present. These macros are being checked 
with #if, so the pre-processor will complain whenever it's asked about one of 
the variables that haven't been defined.

This patch adds a defined() first, before checking the value, so the 
pre-processor doesn't need to consider the variable value, if it's not present.

This change makes it possible to read the compilation logs from modules that 
use KJS.


Diffs
-

  tier1/kjs/src/wtf/Platform.h 843cfd2 

Diff: http://git.reviewboard.kde.org/r/113173/diff/


Testing
---

Builds, KJS tests pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113170: Document KInit dependencies

2013-10-08 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113170/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Documents KInit dependencies, updates to the newer executable names and adds a 
comment regarding things to be looked into.


Diffs
-

  staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 
  staging/kinit/src/kdeinit/kinit.cpp c4a0908 
  staging/kinit/src/klauncher/CMakeLists.txt 1b173be 
  staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e 
  staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 
  staging/kinit/src/wrapper.cpp c9d40cc 

Diff: http://git.reviewboard.kde.org/r/113170/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kf5_add_kdeinit_executable broken?

2013-10-08 Thread Sebastian Kügler 
Hi,

in Kwin (kde-workspace) we're running into the following error:

CMake Error: File /home/sebas/kf5/src/kde-
workspace/kwin/kcmkwin/kwinrules/_KDE5INIT_DUMMY_FILEPATH-NOTFOUND does not 
exist.
CMake Error at /home/sebas/kf5/install/lib64/cmake/KInit/KInitMacros.cmake:17 
(configure_file):
  configure_file Problem configuring file
Call Stack (most recent call first):
  kwin/kcmkwin/kwinrules/CMakeLists.txt:12 (kf5_add_kdeinit_executable)

CMake Error at kwin/kcmkwin/kwinrules/CMakeLists.txt:32 
(target_link_libraries):
  Cannot specify link libraries for target "kdeinit_kwin_rules_dialog" which
  is not built by this project.

-- Configuring incomplete, errors occurred!


This cropped up after KInit splitting. Any ideas?

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

problem linking against kfile, knewstuff3 and kio

2013-10-08 Thread Sebastian Kügler 
Hi,

I still can't get kde-workspace to build after last week's changes in kdelibs 
and e-c-m. The problem is not unknown, yet I'm puzzled as to the reasons.

Here's the build error:

Linking CXX shared library ../../../../lib/libplasma_wallpaper_imageplugin.so
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: 
cannot find -lkio
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: 
cannot find -lkfile
/usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: 
cannot find -lknewstuff3

We still do not have a solution to this problem. Maybe we should revert the 
patch that introduced it until someone has one that doesn't break the build?

Maybe unnecessary to say, but this *REALLY* is a problem. A number of people 
are blocked by this. In my opinion, it should never have gotten in. Was it 
even reviewed?

Any help is appreciated, I'm lost. :(

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 #790

2013-10-08 Thread KDE CI System 
See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/#review41389
---


This review has been submitted with commit 
8dda23a557ead9013e177467256f6c7f18d915b8 by Aurélien Gâteau to branch 
frameworks.

- Commit Hook


On Oct. 7, 2013, 12:47 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113076/
> ---
> 
> (Updated Oct. 7, 2013, 12:47 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This fixes kcookiejartest, which was failing to parse the date from the Y2K38 
> check.
> 
> The test started failing on build.kde.org when the Qt version here was 
> switched to the "stable" branch, which seems to parse things differently than 
> the version of Qt build.kde.org used to run.
> 
> The code was ported from KDateTime::fromString() to QDateTime::fromString(), 
> whose syntax for date formatting is different, but the format was not updated.
> 
> This patch is incomplete, see the FIXME comments in removeTimeZone(). But I 
> want to ensure this is the correct way to go before getting into timezones.
> 
> 
> Diffs
> -
> 
>   kioslave/http/kcookiejar/kcookiejar.cpp e943da9 
> 
> Diff: http://git.reviewboard.kde.org/r/113076/diff/
> 
> 
> Testing
> ---
> 
> kcookiejartest now passes again (must be run with LANG=C btw)
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/
---

(Updated Oct. 8, 2013, 10:16 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and John Layt.


Repository: kdelibs


Description
---

This fixes kcookiejartest, which was failing to parse the date from the Y2K38 
check.

The test started failing on build.kde.org when the Qt version here was switched 
to the "stable" branch, which seems to parse things differently than the 
version of Qt build.kde.org used to run.

The code was ported from KDateTime::fromString() to QDateTime::fromString(), 
whose syntax for date formatting is different, but the format was not updated.

This patch is incomplete, see the FIXME comments in removeTimeZone(). But I 
want to ensure this is the correct way to go before getting into timezones.


Diffs
-

  kioslave/http/kcookiejar/kcookiejar.cpp e943da9 

Diff: http://git.reviewboard.kde.org/r/113076/diff/


Testing
---

kcookiejartest now passes again (must be run with LANG=C btw)


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Kevin Ottens 


> On Oct. 7, 2013, 2:38 p.m., Martin Gräßlin wrote:
> > You broke the build (and forgot to include the REVIEW tag ;-):
> > [ 41%] Building CXX object 
> > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o
> > In file included from 
> > /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.cpp:20:0:
> > /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.h:23:41: 
> > fatal error: kross/core/krosscore_export.h: No such file or directory
> >  #include 
> >  ^
> > compilation terminated.
> > make[2]: *** [kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o] 
> > Error 1
> > make[1]: *** [kross/src/core/CMakeFiles/KrossCore.dir/all] Error 2
> 
> Martin Gräßlin wrote:
> seems like Kevin already fixed it
> 
> Vishesh Handa wrote:
> Urgh. I don't understand. I compiled it with a fresh build directory. 
> Something like this should have been caught.

You removed the install directory too, right?


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113077/#review41350
---


On Oct. 8, 2013, 7:47 a.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113077/
> ---
> 
> (Updated Oct. 8, 2013, 7:47 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This patch makes kross ready for moving to tier3. The changes were done in a 
> separate branch (which I can push if required). The git log looks like this -
> 
> 783b0a3 Kross: Remove module name from the header includes
> 8b7ac05 Kross: Do not set EXECUTABLE_OUTPUT_PATH
> 6c62ace Kross: Add feature_summary
> d9b63be Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR
> 2c627df Kross: Add CMake stuff along with KrossConfig.cmake
> a28624b Kross: Follow frameworks directory scheme
> 741b86c KRoss: Camel case the library names
> 
> Kross does not have any unit tests, and some of its normal tests seem to be 
> segfaulting as well. I'm not sure what to do about that. Also when Kross is 
> being split, its other plugins will needs to be added as well. Kdelibs only 
> contains the kjs and QtScript plugins.
> 
> And finally, the QtScript plugin has a test - Should that be moved to the 
> tests folder?
> 
> 
> Diffs
> -
> 
>   kross/CMakeLists.txt 3424cb8 
>   kross/KrossConfig.cmake.in PRE-CREATION 
>   kross/console/CMakeLists.txt da73a6f 
>   kross/console/main.cpp  
>   kross/core/CMakeLists.txt 5a8b845 
>   kross/core/action.h 3f4d985 
>   kross/core/action.cpp 5c6ee2c 
>   kross/core/actioncollection.h 9e90df6 
>   kross/core/actioncollection.cpp 89d8282 
>   kross/core/childreninterface.h 0b11b2e 
>   kross/core/errorinterface.h bb23235 
>   kross/core/interpreter.h 95293e4 
>   kross/core/interpreter.cpp  
>   kross/core/krossconfig.h 481c4b6 
>   kross/core/krossconfig.cpp  
>   kross/core/manager.h aefdf87 
>   kross/core/manager.cpp e0dddf1 
>   kross/core/metafunction.h 1413289 
>   kross/core/metatype.h 08f7c6c 
>   kross/core/object.h 6f2b6a4 
>   kross/core/object.cpp  
>   kross/core/script.h 1701883 
>   kross/core/script.cpp  
>   kross/core/wrapperinterface.h  
>   kross/kjs/CMakeLists.txt 94af9ae 
>   kross/kjs/kjsinterpreter.h  
>   kross/kjs/kjsinterpreter.cpp  
>   kross/kjs/kjsscript.h  
>   kross/kjs/kjsscript.cpp  
>   kross/modules/CMakeLists.txt 7391bb0 
>   kross/modules/form.h 2da62c7 
>   kross/modules/form.cpp 862b71b 
>   kross/modules/translation.h  
>   kross/modules/translation.cpp  
>   kross/qts/CMakeLists.txt b85c1c7 
>   kross/qts/interpreter.h  
>   kross/qts/interpreter.cpp  
>   kross/qts/main.cpp  
>   kross/qts/plugin.h  
>   kross/qts/plugin.cpp  
>   kross/qts/script.h  
>   kross/qts/script.cpp  
>   kross/qts/test.es  
>   kross/qts/values_p.h  
>   kross/src/CMakeLists.txt PRE-CREATION 
>   kross/src/modules/CMakeLists.txt PRE-CREATION 
>   kross/test/CMakeLists.txt c931ec4 
>   kross/test/main.cpp da926fb 
>   kross/test/profile.py  
>   kross/test/testguiform.py  
>   kross/test/testguiform.rb  
>   kross/test/testguiform.ui  
>   kross/test/testguiqt.py  
>   kross/test/testguiqt.rb  
>   kross/test/testguitk.py  
>   kross/test/testkross.js  
>   kross/test/testkross.py  
>   kross/test/testobject.h 5383073 
>   kross/test/testobject.cpp 560d88c 
>   kross/test/unittest.es  
>   kross/test/unittest.js  
>   kross/test/unittest.py  
>   kross/test/unittest.rb  
>   kross/ui/CMakeLists.txt 14ba2d8 
>   kross/ui/model.h 314ff24 
>   kross/ui/model.cpp 4849149 
>   kross/ui/plugin.h  
>   kross/ui/plugin.cpp  
>   kross/ui/view.h 4241aad 
>   kross/ui/view.cpp  
> 
> Diff: http://git.reviewboard.kde.org/r/113077/diff/
>

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Vishesh Handa 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113077/
---

(Updated Oct. 8, 2013, 7:47 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

This patch makes kross ready for moving to tier3. The changes were done in a 
separate branch (which I can push if required). The git log looks like this -

783b0a3 Kross: Remove module name from the header includes
8b7ac05 Kross: Do not set EXECUTABLE_OUTPUT_PATH
6c62ace Kross: Add feature_summary
d9b63be Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR
2c627df Kross: Add CMake stuff along with KrossConfig.cmake
a28624b Kross: Follow frameworks directory scheme
741b86c KRoss: Camel case the library names

Kross does not have any unit tests, and some of its normal tests seem to be 
segfaulting as well. I'm not sure what to do about that. Also when Kross is 
being split, its other plugins will needs to be added as well. Kdelibs only 
contains the kjs and QtScript plugins.

And finally, the QtScript plugin has a test - Should that be moved to the tests 
folder?


Diffs
-

  kross/CMakeLists.txt 3424cb8 
  kross/KrossConfig.cmake.in PRE-CREATION 
  kross/console/CMakeLists.txt da73a6f 
  kross/console/main.cpp  
  kross/core/CMakeLists.txt 5a8b845 
  kross/core/action.h 3f4d985 
  kross/core/action.cpp 5c6ee2c 
  kross/core/actioncollection.h 9e90df6 
  kross/core/actioncollection.cpp 89d8282 
  kross/core/childreninterface.h 0b11b2e 
  kross/core/errorinterface.h bb23235 
  kross/core/interpreter.h 95293e4 
  kross/core/interpreter.cpp  
  kross/core/krossconfig.h 481c4b6 
  kross/core/krossconfig.cpp  
  kross/core/manager.h aefdf87 
  kross/core/manager.cpp e0dddf1 
  kross/core/metafunction.h 1413289 
  kross/core/metatype.h 08f7c6c 
  kross/core/object.h 6f2b6a4 
  kross/core/object.cpp  
  kross/core/script.h 1701883 
  kross/core/script.cpp  
  kross/core/wrapperinterface.h  
  kross/kjs/CMakeLists.txt 94af9ae 
  kross/kjs/kjsinterpreter.h  
  kross/kjs/kjsinterpreter.cpp  
  kross/kjs/kjsscript.h  
  kross/kjs/kjsscript.cpp  
  kross/modules/CMakeLists.txt 7391bb0 
  kross/modules/form.h 2da62c7 
  kross/modules/form.cpp 862b71b 
  kross/modules/translation.h  
  kross/modules/translation.cpp  
  kross/qts/CMakeLists.txt b85c1c7 
  kross/qts/interpreter.h  
  kross/qts/interpreter.cpp  
  kross/qts/main.cpp  
  kross/qts/plugin.h  
  kross/qts/plugin.cpp  
  kross/qts/script.h  
  kross/qts/script.cpp  
  kross/qts/test.es  
  kross/qts/values_p.h  
  kross/src/CMakeLists.txt PRE-CREATION 
  kross/src/modules/CMakeLists.txt PRE-CREATION 
  kross/test/CMakeLists.txt c931ec4 
  kross/test/main.cpp da926fb 
  kross/test/profile.py  
  kross/test/testguiform.py  
  kross/test/testguiform.rb  
  kross/test/testguiform.ui  
  kross/test/testguiqt.py  
  kross/test/testguiqt.rb  
  kross/test/testguitk.py  
  kross/test/testkross.js  
  kross/test/testkross.py  
  kross/test/testobject.h 5383073 
  kross/test/testobject.cpp 560d88c 
  kross/test/unittest.es  
  kross/test/unittest.js  
  kross/test/unittest.py  
  kross/test/unittest.rb  
  kross/ui/CMakeLists.txt 14ba2d8 
  kross/ui/model.h 314ff24 
  kross/ui/model.cpp 4849149 
  kross/ui/plugin.h  
  kross/ui/plugin.cpp  
  kross/ui/view.h 4241aad 
  kross/ui/view.cpp  

Diff: http://git.reviewboard.kde.org/r/113077/diff/


Testing
---

Some tests segfault. Some of them run. I should probably convert them into 
autotests.


Thanks,

Vishesh Handa

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113077: Get Kross ready for tier3

2013-10-08 Thread Vishesh Handa 


> On Oct. 7, 2013, 2:38 p.m., Martin Gräßlin wrote:
> > You broke the build (and forgot to include the REVIEW tag ;-):
> > [ 41%] Building CXX object 
> > kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o
> > In file included from 
> > /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.cpp:20:0:
> > /home/martin/kf5/src/kdelibs-frameworks/kross/src/core/krossconfig.h:23:41: 
> > fatal error: kross/core/krosscore_export.h: No such file or directory
> >  #include 
> >  ^
> > compilation terminated.
> > make[2]: *** [kross/src/core/CMakeFiles/KrossCore.dir/krossconfig.cpp.o] 
> > Error 1
> > make[1]: *** [kross/src/core/CMakeFiles/KrossCore.dir/all] Error 2
> 
> Martin Gräßlin wrote:
> seems like Kevin already fixed it

Urgh. I don't understand. I compiled it with a fresh build directory. Something 
like this should have been caught.


- Vishesh


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113077/#review41350
---


On Oct. 3, 2013, 4:09 p.m., Vishesh Handa wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113077/
> ---
> 
> (Updated Oct. 3, 2013, 4:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This patch makes kross ready for moving to tier3. The changes were done in a 
> separate branch (which I can push if required). The git log looks like this -
> 
> 783b0a3 Kross: Remove module name from the header includes
> 8b7ac05 Kross: Do not set EXECUTABLE_OUTPUT_PATH
> 6c62ace Kross: Add feature_summary
> d9b63be Kross: Install the plugins in the QT_PLULGIN_INSTALL_DIR
> 2c627df Kross: Add CMake stuff along with KrossConfig.cmake
> a28624b Kross: Follow frameworks directory scheme
> 741b86c KRoss: Camel case the library names
> 
> Kross does not have any unit tests, and some of its normal tests seem to be 
> segfaulting as well. I'm not sure what to do about that. Also when Kross is 
> being split, its other plugins will needs to be added as well. Kdelibs only 
> contains the kjs and QtScript plugins.
> 
> And finally, the QtScript plugin has a test - Should that be moved to the 
> tests folder?
> 
> 
> Diffs
> -
> 
>   kross/CMakeLists.txt 3424cb8 
>   kross/KrossConfig.cmake.in PRE-CREATION 
>   kross/console/CMakeLists.txt da73a6f 
>   kross/console/main.cpp  
>   kross/core/CMakeLists.txt 5a8b845 
>   kross/core/action.h 3f4d985 
>   kross/core/action.cpp 5c6ee2c 
>   kross/core/actioncollection.h 9e90df6 
>   kross/core/actioncollection.cpp 89d8282 
>   kross/core/childreninterface.h 0b11b2e 
>   kross/core/errorinterface.h bb23235 
>   kross/core/interpreter.h 95293e4 
>   kross/core/interpreter.cpp  
>   kross/core/krossconfig.h 481c4b6 
>   kross/core/krossconfig.cpp  
>   kross/core/manager.h aefdf87 
>   kross/core/manager.cpp e0dddf1 
>   kross/core/metafunction.h 1413289 
>   kross/core/metatype.h 08f7c6c 
>   kross/core/object.h 6f2b6a4 
>   kross/core/object.cpp  
>   kross/core/script.h 1701883 
>   kross/core/script.cpp  
>   kross/core/wrapperinterface.h  
>   kross/kjs/CMakeLists.txt 94af9ae 
>   kross/kjs/kjsinterpreter.h  
>   kross/kjs/kjsinterpreter.cpp  
>   kross/kjs/kjsscript.h  
>   kross/kjs/kjsscript.cpp  
>   kross/modules/CMakeLists.txt 7391bb0 
>   kross/modules/form.h 2da62c7 
>   kross/modules/form.cpp 862b71b 
>   kross/modules/translation.h  
>   kross/modules/translation.cpp  
>   kross/qts/CMakeLists.txt b85c1c7 
>   kross/qts/interpreter.h  
>   kross/qts/interpreter.cpp  
>   kross/qts/main.cpp  
>   kross/qts/plugin.h  
>   kross/qts/plugin.cpp  
>   kross/qts/script.h  
>   kross/qts/script.cpp  
>   kross/qts/test.es  
>   kross/qts/values_p.h  
>   kross/src/CMakeLists.txt PRE-CREATION 
>   kross/src/modules/CMakeLists.txt PRE-CREATION 
>   kross/test/CMakeLists.txt c931ec4 
>   kross/test/main.cpp da926fb 
>   kross/test/profile.py  
>   kross/test/testguiform.py  
>   kross/test/testguiform.rb  
>   kross/test/testguiform.ui  
>   kross/test/testguiqt.py  
>   kross/test/testguiqt.rb  
>   kross/test/testguitk.py  
>   kross/test/testkross.js  
>   kross/test/testkross.py  
>   kross/test/testobject.h 5383073 
>   kross/test/testobject.cpp 560d88c 
>   kross/test/unittest.es  
>   kross/test/unittest.js  
>   kross/test/unittest.py  
>   kross/test/unittest.rb  
>   kross/ui/CMakeLists.txt 14ba2d8 
>   kross/ui/model.h 314ff24 
>   kross/ui/model.cpp 4849149 
>   kross/ui/plugin.h  
>   kross/ui/plugin.cpp  
>   kross/ui/view.h 4241aad 
>   kross/ui/view.cpp  
> 
> Diff: http://git.reviewboard.kde.org/r/113077/diff/
> 
> 
> Testing
> ---
> 
> Some tests segfault. Some of them run. I should pr

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/#review41381
---

Ship it!


Ship It!

- Kevin Ottens


On Oct. 7, 2013, 12:47 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113076/
> ---
> 
> (Updated Oct. 7, 2013, 12:47 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This fixes kcookiejartest, which was failing to parse the date from the Y2K38 
> check.
> 
> The test started failing on build.kde.org when the Qt version here was 
> switched to the "stable" branch, which seems to parse things differently than 
> the version of Qt build.kde.org used to run.
> 
> The code was ported from KDateTime::fromString() to QDateTime::fromString(), 
> whose syntax for date formatting is different, but the format was not updated.
> 
> This patch is incomplete, see the FIXME comments in removeTimeZone(). But I 
> want to ensure this is the correct way to go before getting into timezones.
> 
> 
> Diffs
> -
> 
>   kioslave/http/kcookiejar/kcookiejar.cpp e943da9 
> 
> Diff: http://git.reviewboard.kde.org/r/113076/diff/
> 
> 
> Testing
> ---
> 
> kcookiejartest now passes again (must be run with LANG=C btw)
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-08 Thread Kevin Ottens 


> On Oct. 5, 2013, 8:53 a.m., David Faure wrote:
> > Good catch about the format string syntax changes between kde and qt.
> > 
> > But why not just add "t" to the format string to include the timezone, as 
> > it used to do with %Z, instead of the removeTimeZone() function?
> >
> 
> Aurélien Gâteau wrote:
> As far as I can tell, "t" is not supported in QDateTime format string. 
> There is however the, new in 5.2, QTimeZone class. I am going to rework the 
> patch to use it instead of ignoring the time zone information.

"t" is supported by toString but not fromString.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113076/#review41267
---


On Oct. 7, 2013, 12:47 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113076/
> ---
> 
> (Updated Oct. 7, 2013, 12:47 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> This fixes kcookiejartest, which was failing to parse the date from the Y2K38 
> check.
> 
> The test started failing on build.kde.org when the Qt version here was 
> switched to the "stable" branch, which seems to parse things differently than 
> the version of Qt build.kde.org used to run.
> 
> The code was ported from KDateTime::fromString() to QDateTime::fromString(), 
> whose syntax for date formatting is different, but the format was not updated.
> 
> This patch is incomplete, see the FIXME comments in removeTimeZone(). But I 
> want to ensure this is the correct way to go before getting into timezones.
> 
> 
> Diffs
> -
> 
>   kioslave/http/kcookiejar/kcookiejar.cpp e943da9 
> 
> Diff: http://git.reviewboard.kde.org/r/113076/diff/
> 
> 
> Testing
> ---
> 
> kcookiejartest now passes again (must be run with LANG=C btw)
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel