Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

[Sune Vuorela]

On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote:
> > We are here making a 'hole' for people to do  'bad things' that wasn't 
> > possible in the past. I'm not sure we want that.
> 
> Mark Gaiser wrote:
> Interesting.
> So that mean we simply can't use the new signal/slot syntax because of 
> it? That would seem rather strange to me..
> 
> If you do a stat call, or listEntry or ...
> Then you are supposed to connect to the result slot. For listEntry you 
> are supposed to connect to the finished signal. Both of those are defined as:
> signals:
> private:
> 
> AKA. Private signals.
> I really don't see how you can work around this besides perhaps 
> QSignalMapper, but that would be very odd as well. I'm really curious to see 
> how that "bit of magic" is supposed to work. Do you have some links for me 
> there?

I'm not saying we can't use the new syntax because of it. I'm saying it needs a 
bit more work, and before a 'stable' version is needed.

There is a solution out there. It's applied to QAIM and others.


- Sune


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41570
---


On Oct. 11, 2013, 5:59 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113205/
> ---
> 
> (Updated Oct. 11, 2013, 5:59 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The new signal/slot connection:
> connect(job, &KJob::result,...
> 
> does't like result to be private and throws an compile error:
> error: 'void KJob::result(KJob*)' is private
> 
> Making it public resolves the issue and makes this slot usable in the new 
> syntax. In my case i wanted to use the new syntax and directly use a lambda 
> as slot. Which isn't possible on this signal if it isn't public.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
> 
> Diff: http://git.reviewboard.kde.org/r/113205/diff/
> 
> 
> Testing
> ---
> 
> Works just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

[Mark Gaiser]

On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote:
> > We are here making a 'hole' for people to do  'bad things' that wasn't 
> > possible in the past. I'm not sure we want that.

Interesting.
So that mean we simply can't use the new signal/slot syntax because of it? That 
would seem rather strange to me..

If you do a stat call, or listEntry or ...
Then you are supposed to connect to the result slot. For listEntry you are 
supposed to connect to the finished signal. Both of those are defined as:
signals:
private:

AKA. Private signals.
I really don't see how you can work around this besides perhaps QSignalMapper, 
but that would be very odd as well. I'm really curious to see how that "bit of 
magic" is supposed to work. Do you have some links for me there?


- Mark


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41570
---


On Oct. 11, 2013, 5:59 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113205/
> ---
> 
> (Updated Oct. 11, 2013, 5:59 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The new signal/slot connection:
> connect(job, &KJob::result,...
> 
> does't like result to be private and throws an compile error:
> error: 'void KJob::result(KJob*)' is private
> 
> Making it public resolves the issue and makes this slot usable in the new 
> syntax. In my case i wanted to use the new syntax and directly use a lambda 
> as slot. Which isn't possible on this signal if it isn't public.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
> 
> Diff: http://git.reviewboard.kde.org/r/113205/diff/
> 
> 
> Testing
> ---
> 
> Works just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

[Sune Vuorela]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41570
---



tier1/kcoreaddons/src/lib/jobs/kjob.h


You are kind of now actually making it fully public so that it can be 
emitted by others, contrary to what the documentation seems to imply.

I think QAIM had a similar thing that steve solved with a bit of magic.


We are here making a 'hole' for people to do  'bad things' that wasn't possible 
in the past. I'm not sure we want that.

- Sune Vuorela


On Oct. 11, 2013, 5:59 p.m., Mark Gaiser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113205/
> ---
> 
> (Updated Oct. 11, 2013, 5:59 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> The new signal/slot connection:
> connect(job, &KJob::result,...
> 
> does't like result to be private and throws an compile error:
> error: 'void KJob::result(KJob*)' is private
> 
> Making it public resolves the issue and makes this slot usable in the new 
> syntax. In my case i wanted to use the new syntax and directly use a lambda 
> as slot. Which isn't possible on this signal if it isn't public.
> 
> 
> Diffs
> -
> 
>   tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
> 
> Diff: http://git.reviewboard.kde.org/r/113205/diff/
> 
> 
> Testing
> ---
> 
> Works just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: build.kde.org: Failing ktoolbar_unittest

[Aleix Pol]

On Fri, Oct 11, 2013 at 6:31 PM, Kevin Ottens  wrote:

> Hello,
>
> ktoolbar_unittest segfaults in the CI. I tried to reproduce the error here
> with no luck so far. If someone who manages to reproduce it or who has
> access
> to build.kde.org shell could look into it that would be nice.
>
> Regards.
> --
> Kévin Ottens, http://ervin.ipsquad.net
>
> Sponsored by KDAB to work on KDE Frameworks
> KDAB - proud supporter of KDE, http://www.kdab.com
>
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
>
Should be fixed now. It was a bit tricky to reproduce (here it happened
randomly), it was easily spotted by using valgrind.

Cheers!
Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : kdelibs_frameworks_qt5 #1406

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113206: Make KIconLoader a bit less fragile

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/
---

(Updated Oct. 11, 2013, 6:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that 
would delete the d-pointer.

This patch makes it so instead of deleting it, it will clear the values and 
initialize them again instead.


Diffs
-

  tier3/kiconthemes/src/kiconloader.cpp bf3899a 

Diff: http://git.reviewboard.kde.org/r/113206/diff/


Testing
---

Makes ktoolbartest pass (and valgrind-proof)


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113206: Make KIconLoader a bit less fragile

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/#review41569
---

Ship it!


When I touched this code I was tempted of doing exactly this, but I applied the 
"If it works don't touch it".

Since apparently it does NOT work, it seems that this change is required after 
all :p.


tier3/kiconthemes/src/kiconloader.cpp


Trailing space


- Àlex Fiestas


On Oct. 11, 2013, 5:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113206/
> ---
> 
> (Updated Oct. 11, 2013, 5:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that 
> would delete the d-pointer.
> 
> This patch makes it so instead of deleting it, it will clear the values and 
> initialize them again instead.
> 
> 
> Diffs
> -
> 
>   tier3/kiconthemes/src/kiconloader.cpp bf3899a 
> 
> Diff: http://git.reviewboard.kde.org/r/113206/diff/
> 
> 
> Testing
> ---
> 
> Makes ktoolbartest pass (and valgrind-proof)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113205: Make KJob::result public for the new signal/slot syntax.

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/
---

Review request for KDE Frameworks and kdelibs.


Repository: kdelibs


Description
---

The new signal/slot connection:
connect(job, &KJob::result,...

does't like result to be private and throws an compile error:
error: 'void KJob::result(KJob*)' is private

Making it public resolves the issue and makes this slot usable in the new 
syntax. In my case i wanted to use the new syntax and directly use a lambda as 
slot. Which isn't possible on this signal if it isn't public.


Diffs
-

  tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 

Diff: http://git.reviewboard.kde.org/r/113205/diff/


Testing
---

Works just fine.


Thanks,

Mark Gaiser

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113206: Make KIconLoader a bit less fragile

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113206/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

KIconLoaderPrivate::_k_refreshIcons was calling KIconLoader::reconfigure that 
would delete the d-pointer.

This patch makes it so instead of deleting it, it will clear the values and 
initialize them again instead.


Diffs
-

  tier3/kiconthemes/src/kiconloader.cpp bf3899a 

Diff: http://git.reviewboard.kde.org/r/113206/diff/


Testing
---

Makes ktoolbartest pass (and valgrind-proof)


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113196: kdirwatch: include correct header for time_t and ino_t.

[Nicolás Alvarez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113196/
---

(Updated Oct. 11, 2013, 2:25 p.m.)


Review request for KDE Frameworks.


Changes
---

Submit to the correct review group this time...


Repository: kdelibs


Description
---

kdirwatch: include correct header for time_t and ino_t.

We were including sys/time.h and sys/param.h, but Windows doesn't have
them, and POSIX says those types are defined in sys/types.h.

This doesn't fix the build on Windows, but it's a step.


Diffs
-

  tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 
77c7d6d1f83f0c984043ed1c7e3a83a2e824d0c7 

Diff: http://git.reviewboard.kde.org/r/113196/diff/


Testing
---

Still builds and passes tests on Linux/gcc.

Still fails to build on Windows/MSVC2010 but not for this reason :)


Thanks,

Nicolás Alvarez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113174: Cleanup KJsEmbed

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/
---

(Updated Oct. 11, 2013, 4:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Adopt directory organization, naming scheme, cmake structures, documents 
dependencies.


Diffs
-

  kjsembed/kjsembed/fileio.cpp  
  kjsembed/kjsembed/font.h  
  kjsembed/kjsembed/font.cpp  
  kjsembed/kjsembed/image.h  
  kjsembed/kjsembed/image.cpp  
  kjsembed/kjsembed/iosupport.h  
  kjsembed/kjsembed/iosupport.cpp  
  kjsembed/kjsembed/jseventmapper.h  
  kjsembed/kjsembed/jseventmapper.cpp  
  kjsembed/kjsembed/jseventutils.h  
  kjsembed/kjsembed/jseventutils.cpp  
  kjsembed/kjsembed/kjseglobal.h  
  kjsembed/kjsembed/kjseglobal.cpp  
  kjsembed/kjsembed/kjsembed.h 74dfab8 
  kjsembed/kjsembed/kjsembed.cpp  
  kjsembed/kjsembed/object_binding.h  
  kjsembed/kjsembed/object_binding.cpp  
  kjsembed/kjsembed/pen.h  
  kjsembed/kjsembed/pen.cpp  
  kjsembed/kjsembed/pixmap.h  
  kjsembed/kjsembed/pixmap.cpp  
  kjsembed/kjsembed/point.h  
  kjsembed/kjsembed/point.cpp  
  kjsembed/kjsembed/pointer.h  
  kjsembed/kjsembed/qaction_binding.h  
  kjsembed/kjsembed/qaction_binding.cpp  
  kjsembed/kjsembed/qformbuilder_binding.h  
  kjsembed/kjsembed/qformbuilder_binding.cpp  
  kjsembed/kjsembed/qlayout_binding.h  
  kjsembed/kjsembed/qlayout_binding.cpp  
  kjsembed/kjsembed/qobject_binding.h  
  kjsembed/kjsembed/qobject_binding.cpp  
  kjsembed/kjsembed/qpainter_binding.h  
  kjsembed/kjsembed/qpainter_binding.cpp  
  kjsembed/kjsembed/quiloader_binding.h  
  kjsembed/kjsembed/quiloader_binding.cpp  
  kjsembed/kjsembed/qwidget_binding.h  
  kjsembed/kjsembed/qwidget_binding.cpp  
  kjsembed/kjsembed/rect.h  
  kjsembed/kjsembed/rect.cpp  
  kjsembed/kjsembed/settings.h  
  kjsembed/kjsembed/settings.cpp  
  kjsembed/kjsembed/size.h  
  kjsembed/kjsembed/size.cpp  
  kjsembed/kjsembed/slotproxy.h 48b88ef 
  kjsembed/kjsembed/slotproxy.cpp  
  kjsembed/kjsembed/static_binding.h  
  kjsembed/kjsembed/static_binding.cpp  
  kjsembed/kjsembed/svg_binding.h  
  kjsembed/kjsembed/svg_binding.cpp  
  kjsembed/kjsembed/test/QByteArray_bind.h  
  kjsembed/kjsembed/test/QByteArray_bind.cpp  
  kjsembed/kjsembed/url.h  
  kjsembed/kjsembed/url.cpp  
  kjsembed/kjsembed/util.h  
  kjsembed/kjsembed/value_binding.h  
  kjsembed/kjsembed/value_binding.cpp  
  kjsembed/kjsembed/variant_binding.h  
  kjsembed/kjsembed/variant_binding.cpp  
  staging/CMakeLists.txt 55cc3d3 
  staging/kjsembed/CMakeLists.txt PRE-CREATION 
  staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION 
  staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION 
  staging/kjsembed/src/CMakeLists.txt PRE-CREATION 
  staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION 
  staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION 
  staging/kross/src/kjs/CMakeLists.txt cfa026e 
  tier1/kjs/src/wtf/Platform.h 843cfd2 
  kjsembed/kjsembed/fileio.h  
  kjsembed/kjsembed/filedialog_binding.cpp  
  kjsembed/kjsembed/filedialog_binding.h  
  kjsembed/kjsembed/eventproxy.cpp  
  kjsembed/kjsembed/eventproxy.h  
  kjsembed/kjsembed/dom.cpp  
  kjsembed/kjsembed/dom.h  
  kjsembed/kjsembed/brush.cpp  
  kjsembed/kjsembed/builtins.h  
  kjsembed/kjsembed/builtins.cpp  
  kjsembed/kjsembed/color.h  
  kjsembed/kjsembed/color.cpp  
  kjsembed/kjsembed/brush.h  
  kjsembed/kjsembed/binding_support.cpp  
  kjsembed/kjsembed/binding_support.h  
  kjsembed/kjsembed/application.h  
  kjsembed/kjsembed/application.cpp  
  kjsembed/kjsembed/QBrush_bind.cpp  
  kjsembed/kjsembed/QBrush_bind.h  
  CMakeLists.txt 368584e 
  kjsembed/AUTHORS  
  kjsembed/CMakeLists.txt 6cb6727 
  kjsembed/Mainpage.dox  
  kjsembed/examples/calc/calc.js  
  kjsembed/examples/calc/calc.ui  
  kjsembed/examples/console/console.js  
  kjsembed/examples/console/console.ui  
  kjsembed/examples/docviewer/docviewer.js  
  kjsembed/examples/docviewer/docviewer.ui  
  kjsembed/examples/fancy/fancy.js  
  kjsembed/examples/grammar/grammar.js  
  kjsembed/examples/kjsconsole/CMakeLists.txt d06f27b 
  kjsembed/examples/kjsconsole/console.h  
  kjsembed/examples/kjsconsole/console.cpp f65f39b 
  kjsembed/examples/kjsconsole/console.qrc  
  kjsembed/examples/kjsconsole/images/bug.png  
  kjsembed/examples/kjsconsole/images/class.png  
  kjsembed/examples/kjsconsole/images/constant.png  
  kjsembed/examples/kjsconsole/images/method.png  
  kjsembed/examples/kjsconsole/images/next.png  
  kjsembed/examples/kjsconsole/images/no.png  
  kjsembed/examples/kjsconsole/images/property.png  
  kjsembed/examples/kjsconsole/images/runto.png  
  kjsembed/examples/kjsconsole/images/start.png  
  kjsembed/examples/kjsconsole/images/step.png  
  kjsembed/examples/kjsconsole/images/stop.png  
  kjsembed/exampl

build.kde.org: Failing ktoolbar_unittest

[Kevin Ottens]

Hello,

ktoolbar_unittest segfaults in the CI. I tried to reproduce the error here 
with no luck so far. If someone who manages to reproduce it or who has access 
to build.kde.org shell could look into it that would be nice.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112984: Adjust API in KEmoticons framework: KEmoticonsProvider::save()

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112984/#review41566
---

Ship it!


Ship It!

- Kevin Ottens


On Oct. 7, 2013, 10:08 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112984/
> ---
> 
> (Updated Oct. 7, 2013, 10:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Adjust API in KEmoticons framework: KEmoticonsProvider::save()
> 
> -To make KEmoticons API more consistent, deprecate KEmoticonsProvider::save()
> and prefer saveTheme() instead.
> -Adjust plugins.
> -Before the cleanup, KEmoticonsTheme was calling KEmoticonsProvider::save(),
> which was empty. Now it's a pure virtual function. Therefore, I deprecate
> it and advice subclassing KEmoticonsProvider.
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 
> 0dc92ed092d87a559fe7fa1a40e804843ab73d59 
>   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.h 
> 0873a635a300e0ed8e38b1d59a535d6ec15b99cb 
>   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 
> e9f89eecce3d6e6407113a84cb5200ff66564c19 
>   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.h 
> 70bafa3fe4ba25c9d6a69634024b2c157235e674 
>   staging/kemoticons/src/providers/kde/kde_emoticons.cpp 
> 5b5114a14dd94a6ebcba8a6f7dd163f73048189a 
>   staging/kemoticons/src/providers/kde/kde_emoticons.h 
> 8cba6b194eee1543bf13f1177a0e4092f1a10943 
>   staging/kemoticons/src/providers/adium/adium_emoticons.cpp 
> a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 
>   staging/kemoticons/src/providers/adium/adium_emoticons.h 
> 039a267679919c968bbe4d12c35abb90cf1bcc9b 
>   staging/kemoticons/src/core/kemoticonstheme.cpp 
> ed3407cdd45c84d91f2d0057e108b760ff696ff2 
>   staging/kemoticons/src/core/kemoticonstheme.h 
> b8b25f7607d3741dda78d6302c1ed81fbc9211a0 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp 
> d04c76e87b118f5d45717b3b2ccd9dea47dc2526 
>   staging/kemoticons/src/core/kemoticonsprovider.h 
> 85fc7efb8923d76476f0a16f70f8ebb15e451081 
>   KDE5PORTING.html 57ecf2e007e270b634cc8d16462b73e96553c92d 
> 
> Diff: http://git.reviewboard.kde.org/r/112984/diff/
> 
> 
> Testing
> ---
> 
> It builds. It installs. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112985: Adjust API in KEmoticons framework: map and index methods

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112985/#review41567
---

Ship it!


Ship It!

- Kevin Ottens


On Oct. 6, 2013, 9:02 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112985/
> ---
> 
> (Updated Oct. 6, 2013, 9:02 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Adjust API in KEmoticons framework: map and index methods
> 
> -Make map and index KEmoticons API slightly clearer and deprecate
> the methods that are confusing.
> -Use the new methods in the plugins.
> 
> 
> Diffs
> -
> 
>   staging/kemoticons/src/core/kemoticonsprovider.h 
> 85fc7efb8923d76476f0a16f70f8ebb15e451081 
>   staging/kemoticons/src/core/kemoticonsprovider.cpp 
> d04c76e87b118f5d45717b3b2ccd9dea47dc2526 
>   staging/kemoticons/src/providers/adium/adium_emoticons.cpp 
> a3aaa0fdc0b3dcc862f98865d2e6419e716f4f17 
>   staging/kemoticons/src/providers/kde/kde_emoticons.cpp 
> 5b5114a14dd94a6ebcba8a6f7dd163f73048189a 
>   staging/kemoticons/src/providers/pidgin/pidgin_emoticons.cpp 
> e9f89eecce3d6e6407113a84cb5200ff66564c19 
>   staging/kemoticons/src/providers/xmpp/xmpp_emoticons.cpp 
> 0dc92ed092d87a559fe7fa1a40e804843ab73d59 
> 
> Diff: http://git.reviewboard.kde.org/r/112985/diff/
> 
> 
> Testing
> ---
> 
> It builds. It installs. Tests pass.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113170: Document KInit dependencies

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113170/
---

(Updated Oct. 11, 2013, 3:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Documents KInit dependencies, updates to the newer executable names and adds a 
comment regarding things to be looked into.


Diffs
-

  staging/kinit/src/wrapper.cpp c9d40cc 
  staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 
  staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e 
  staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 
  staging/kinit/src/klauncher/CMakeLists.txt 1b173be 
  staging/kinit/src/kdeinit/kinit.cpp c4a0908 
  staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 
  staging/kinit/src/CMakeLists.txt 9fc6736 

Diff: http://git.reviewboard.kde.org/r/113170/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113174: Cleanup KJsEmbed

[Aleix Pol Gonzalez]

> On Oct. 11, 2013, 2:03 p.m., Àlex Fiestas wrote:
> > tier1/kjs/src/wtf/Platform.h, lines 36-40
> > 
> >
> > This has been already pushed, no?

Yes, it's in already, it wasn't part of that patch.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41564
---


On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113174/
> ---
> 
> (Updated Oct. 10, 2013, 1:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Adopt directory organization, naming scheme, cmake structures, documents 
> dependencies.
> 
> 
> Diffs
> -
> 
>   kjsembed/kjsembed/fileio.cpp  
>   kjsembed/kjsembed/font.h  
>   kjsembed/kjsembed/font.cpp  
>   kjsembed/kjsembed/image.h  
>   kjsembed/kjsembed/image.cpp  
>   kjsembed/kjsembed/iosupport.h  
>   kjsembed/kjsembed/iosupport.cpp  
>   kjsembed/kjsembed/jseventmapper.h  
>   kjsembed/kjsembed/jseventmapper.cpp  
>   kjsembed/kjsembed/jseventutils.h  
>   kjsembed/kjsembed/jseventutils.cpp  
>   kjsembed/kjsembed/kjseglobal.h  
>   kjsembed/kjsembed/kjseglobal.cpp  
>   kjsembed/kjsembed/kjsembed.h 74dfab8 
>   kjsembed/kjsembed/kjsembed.cpp  
>   kjsembed/kjsembed/object_binding.h  
>   kjsembed/kjsembed/object_binding.cpp  
>   kjsembed/kjsembed/pen.h  
>   kjsembed/kjsembed/pen.cpp  
>   kjsembed/kjsembed/pixmap.h  
>   kjsembed/kjsembed/pixmap.cpp  
>   kjsembed/kjsembed/point.h  
>   kjsembed/kjsembed/point.cpp  
>   kjsembed/kjsembed/pointer.h  
>   kjsembed/kjsembed/qaction_binding.h  
>   kjsembed/kjsembed/qaction_binding.cpp  
>   kjsembed/kjsembed/qformbuilder_binding.h  
>   kjsembed/kjsembed/qformbuilder_binding.cpp  
>   kjsembed/kjsembed/qlayout_binding.h  
>   kjsembed/kjsembed/qlayout_binding.cpp  
>   kjsembed/kjsembed/qobject_binding.h  
>   kjsembed/kjsembed/qobject_binding.cpp  
>   kjsembed/kjsembed/qpainter_binding.h  
>   kjsembed/kjsembed/qpainter_binding.cpp  
>   kjsembed/kjsembed/quiloader_binding.h  
>   kjsembed/kjsembed/quiloader_binding.cpp  
>   kjsembed/kjsembed/qwidget_binding.h  
>   kjsembed/kjsembed/qwidget_binding.cpp  
>   kjsembed/kjsembed/rect.h  
>   kjsembed/kjsembed/rect.cpp  
>   kjsembed/kjsembed/settings.h  
>   kjsembed/kjsembed/settings.cpp  
>   kjsembed/kjsembed/size.h  
>   kjsembed/kjsembed/size.cpp  
>   kjsembed/kjsembed/slotproxy.h 48b88ef 
>   kjsembed/kjsembed/slotproxy.cpp  
>   kjsembed/kjsembed/static_binding.h  
>   kjsembed/kjsembed/static_binding.cpp  
>   kjsembed/kjsembed/svg_binding.h  
>   kjsembed/kjsembed/svg_binding.cpp  
>   kjsembed/kjsembed/test/QByteArray_bind.h  
>   kjsembed/kjsembed/test/QByteArray_bind.cpp  
>   kjsembed/kjsembed/url.h  
>   kjsembed/kjsembed/url.cpp  
>   kjsembed/kjsembed/util.h  
>   kjsembed/kjsembed/value_binding.h  
>   kjsembed/kjsembed/value_binding.cpp  
>   kjsembed/kjsembed/variant_binding.h  
>   kjsembed/kjsembed/variant_binding.cpp  
>   staging/CMakeLists.txt 55cc3d3 
>   staging/kjsembed/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION 
>   staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION 
>   staging/kross/src/kjs/CMakeLists.txt cfa026e 
>   tier1/kjs/src/wtf/Platform.h 843cfd2 
>   kjsembed/kjsembed/fileio.h  
>   kjsembed/kjsembed/filedialog_binding.cpp  
>   kjsembed/kjsembed/filedialog_binding.h  
>   kjsembed/kjsembed/eventproxy.cpp  
>   kjsembed/kjsembed/eventproxy.h  
>   kjsembed/kjsembed/dom.cpp  
>   kjsembed/kjsembed/dom.h  
>   kjsembed/kjsembed/brush.cpp  
>   kjsembed/kjsembed/builtins.h  
>   kjsembed/kjsembed/builtins.cpp  
>   kjsembed/kjsembed/color.h  
>   kjsembed/kjsembed/color.cpp  
>   kjsembed/kjsembed/brush.h  
>   kjsembed/kjsembed/binding_support.cpp  
>   kjsembed/kjsembed/binding_support.h  
>   kjsembed/kjsembed/application.h  
>   kjsembed/kjsembed/application.cpp  
>   kjsembed/kjsembed/QBrush_bind.cpp  
>   kjsembed/kjsembed/QBrush_bind.h  
>   CMakeLists.txt 368584e 
>   kjsembed/AUTHORS  
>   kjsembed/CMakeLists.txt 6cb6727 
>   kjsembed/Mainpage.dox  
>   kjsembed/examples/calc/calc.js  
>   kjsembed/examples/calc/calc.ui  
>   kjsembed/examples/console/console.js  
>   kjsembed/examples/console/console.ui  
>   kjsembed/examples/docviewer/docviewer.js  
>   kjsembed/examples/docviewer/docviewer.ui  
>   kjsembed/examples/fancy/fancy.js  
>   kjsembed/examples/grammar/gr

Build failed in Jenkins: kdelibs_frameworks_qt5 #1401

[KDE CI System]

See 

Changes:

[steveire] Update the link interface.

--
[...truncated 1225 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kwallet/src/CMakeLists.txt:
  Target "KWallet" has policy CMP0022 enabled, but also has old-style
  LIN

Build failed in Jenkins: kdelibs_frameworks_qt5 #1400

[KDE CI System]

See 

Changes:

[faure] Fix crash in KBookmarkManagerList destructor

--
[...truncated 1225 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kwallet/src/CMakeLists.txt:
  Target "KWallet" has policy CMP0022 enabled, but also has 

Re: Review Request 113174: Cleanup KJsEmbed

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113174/#review41564
---

Ship it!


Besides this additional changes in the patch that should not be in, the rest 
looks ko.


tier1/kjs/src/wtf/Platform.h


This has been already pushed, no?


- Àlex Fiestas


On Oct. 10, 2013, 1:30 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113174/
> ---
> 
> (Updated Oct. 10, 2013, 1:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Adopt directory organization, naming scheme, cmake structures, documents 
> dependencies.
> 
> 
> Diffs
> -
> 
>   kjsembed/kjsembed/fileio.cpp  
>   kjsembed/kjsembed/font.h  
>   kjsembed/kjsembed/font.cpp  
>   kjsembed/kjsembed/image.h  
>   kjsembed/kjsembed/image.cpp  
>   kjsembed/kjsembed/iosupport.h  
>   kjsembed/kjsembed/iosupport.cpp  
>   kjsembed/kjsembed/jseventmapper.h  
>   kjsembed/kjsembed/jseventmapper.cpp  
>   kjsembed/kjsembed/jseventutils.h  
>   kjsembed/kjsembed/jseventutils.cpp  
>   kjsembed/kjsembed/kjseglobal.h  
>   kjsembed/kjsembed/kjseglobal.cpp  
>   kjsembed/kjsembed/kjsembed.h 74dfab8 
>   kjsembed/kjsembed/kjsembed.cpp  
>   kjsembed/kjsembed/object_binding.h  
>   kjsembed/kjsembed/object_binding.cpp  
>   kjsembed/kjsembed/pen.h  
>   kjsembed/kjsembed/pen.cpp  
>   kjsembed/kjsembed/pixmap.h  
>   kjsembed/kjsembed/pixmap.cpp  
>   kjsembed/kjsembed/point.h  
>   kjsembed/kjsembed/point.cpp  
>   kjsembed/kjsembed/pointer.h  
>   kjsembed/kjsembed/qaction_binding.h  
>   kjsembed/kjsembed/qaction_binding.cpp  
>   kjsembed/kjsembed/qformbuilder_binding.h  
>   kjsembed/kjsembed/qformbuilder_binding.cpp  
>   kjsembed/kjsembed/qlayout_binding.h  
>   kjsembed/kjsembed/qlayout_binding.cpp  
>   kjsembed/kjsembed/qobject_binding.h  
>   kjsembed/kjsembed/qobject_binding.cpp  
>   kjsembed/kjsembed/qpainter_binding.h  
>   kjsembed/kjsembed/qpainter_binding.cpp  
>   kjsembed/kjsembed/quiloader_binding.h  
>   kjsembed/kjsembed/quiloader_binding.cpp  
>   kjsembed/kjsembed/qwidget_binding.h  
>   kjsembed/kjsembed/qwidget_binding.cpp  
>   kjsembed/kjsembed/rect.h  
>   kjsembed/kjsembed/rect.cpp  
>   kjsembed/kjsembed/settings.h  
>   kjsembed/kjsembed/settings.cpp  
>   kjsembed/kjsembed/size.h  
>   kjsembed/kjsembed/size.cpp  
>   kjsembed/kjsembed/slotproxy.h 48b88ef 
>   kjsembed/kjsembed/slotproxy.cpp  
>   kjsembed/kjsembed/static_binding.h  
>   kjsembed/kjsembed/static_binding.cpp  
>   kjsembed/kjsembed/svg_binding.h  
>   kjsembed/kjsembed/svg_binding.cpp  
>   kjsembed/kjsembed/test/QByteArray_bind.h  
>   kjsembed/kjsembed/test/QByteArray_bind.cpp  
>   kjsembed/kjsembed/url.h  
>   kjsembed/kjsembed/url.cpp  
>   kjsembed/kjsembed/util.h  
>   kjsembed/kjsembed/value_binding.h  
>   kjsembed/kjsembed/value_binding.cpp  
>   kjsembed/kjsembed/variant_binding.h  
>   kjsembed/kjsembed/variant_binding.cpp  
>   staging/CMakeLists.txt 55cc3d3 
>   staging/kjsembed/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/KJsEmbedConfig.cmake.in PRE-CREATION 
>   staging/kjsembed/examples/kjsconsole/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/kjscmd/CMakeLists.txt PRE-CREATION 
>   staging/kjsembed/src/kjsembed/CMakeLists.txt PRE-CREATION 
>   staging/kross/src/kjs/CMakeLists.txt cfa026e 
>   tier1/kjs/src/wtf/Platform.h 843cfd2 
>   kjsembed/kjsembed/fileio.h  
>   kjsembed/kjsembed/filedialog_binding.cpp  
>   kjsembed/kjsembed/filedialog_binding.h  
>   kjsembed/kjsembed/eventproxy.cpp  
>   kjsembed/kjsembed/eventproxy.h  
>   kjsembed/kjsembed/dom.cpp  
>   kjsembed/kjsembed/dom.h  
>   kjsembed/kjsembed/brush.cpp  
>   kjsembed/kjsembed/builtins.h  
>   kjsembed/kjsembed/builtins.cpp  
>   kjsembed/kjsembed/color.h  
>   kjsembed/kjsembed/color.cpp  
>   kjsembed/kjsembed/brush.h  
>   kjsembed/kjsembed/binding_support.cpp  
>   kjsembed/kjsembed/binding_support.h  
>   kjsembed/kjsembed/application.h  
>   kjsembed/kjsembed/application.cpp  
>   kjsembed/kjsembed/QBrush_bind.cpp  
>   kjsembed/kjsembed/QBrush_bind.h  
>   CMakeLists.txt 368584e 
>   kjsembed/AUTHORS  
>   kjsembed/CMakeLists.txt 6cb6727 
>   kjsembed/Mainpage.dox  
>   kjsembed/examples/calc/calc.js  
>   kjsembed/examples/calc/calc.ui  
>   kjsembed/examples/console/console.js  
>   kjsembed/examples/console/console.ui  
>   kjsembed/examples/docviewer/docviewer.js  
>   kjsembed/examples/docviewer/docviewer.ui  
>   kjsembed/examples/fancy/fancy.js  
>   kjsembed/examples/grammar/grammar.js  
>   kjsembed/examples/kjsconsole/CMake

Re: Review Request 113170: Document KInit dependencies

[Àlex Fiestas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113170/#review41563
---

Ship it!


Looks good !

- Àlex Fiestas


On Oct. 11, 2013, 2 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113170/
> ---
> 
> (Updated Oct. 11, 2013, 2 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> Documents KInit dependencies, updates to the newer executable names and adds 
> a comment regarding things to be looked into.
> 
> 
> Diffs
> -
> 
>   staging/kinit/src/wrapper.cpp c9d40cc 
>   staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 
>   staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e 
>   staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 
>   staging/kinit/src/klauncher/CMakeLists.txt 1b173be 
>   staging/kinit/src/kdeinit/kinit.cpp c4a0908 
>   staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 
>   staging/kinit/src/CMakeLists.txt 9fc6736 
> 
> Diff: http://git.reviewboard.kde.org/r/113170/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113170: Document KInit dependencies

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113170/
---

(Updated Oct. 11, 2013, 2 p.m.)


Review request for KDE Frameworks.


Changes
---

Small love addition to the patch


Repository: kdelibs


Description
---

Documents KInit dependencies, updates to the newer executable names and adds a 
comment regarding things to be looked into.


Diffs (updated)
-

  staging/kinit/src/wrapper.cpp c9d40cc 
  staging/kinit/src/start_kdeinit/CMakeLists.txt d2eae19 
  staging/kinit/src/kwrapper/kwrapper_win.cpp 881920e 
  staging/kinit/src/klauncher/klauncher_main.cpp e0d46c9 
  staging/kinit/src/klauncher/CMakeLists.txt 1b173be 
  staging/kinit/src/kdeinit/kinit.cpp c4a0908 
  staging/kinit/src/kdeinit/CMakeLists.txt d5e1070 
  staging/kinit/src/CMakeLists.txt 9fc6736 

Diff: http://git.reviewboard.kde.org/r/113170/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113199: KHTML: KComponentData -> KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/#review41558
---

Ship it!


Looks quite straightforward to me, happy to see another kde4support dependency 
less :).

- Aleix Pol Gonzalez


On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113199/
> ---
> 
> (Updated Oct. 11, 2013, 12:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> KComponentData -> KAboutData
> 
> This drops the KDE4Support dependency in KHTML.
> 
> 
> Diffs
> -
> 
>   khtml/src/java/kjavaappletviewer.h 3c3fd77 
>   khtml/src/java/kjavaappletviewer.cpp cf6acf1 
>   khtml/src/java/CMakeLists.txt 02efcd8 
>   khtml/src/CMakeLists.txt dd36945 
>   khtml/src/khtml_global.h 0d16716 
>   khtml/src/khtml_global.cpp 4d7c6ca 
>   khtml/src/khtml_part.cpp 6e7f87e 
>   khtml/src/khtmlimage.h 9623a2a 
>   khtml/src/khtmlimage.cpp a074051 
> 
> Diff: http://git.reviewboard.kde.org/r/113199/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113199: KHTML: KComponentData -> KAboutData

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/#review41556
---



khtml/src/khtmlimage.cpp


To me, deleting a static member when one instance gets deleted seems rather 
bad.

However, the original code did it and it must have worked so I've left it 
the same.



- David Edmundson


On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113199/
> ---
> 
> (Updated Oct. 11, 2013, 12:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> ---
> 
> KComponentData -> KAboutData
> 
> This drops the KDE4Support dependency in KHTML.
> 
> 
> Diffs
> -
> 
>   khtml/src/java/kjavaappletviewer.h 3c3fd77 
>   khtml/src/java/kjavaappletviewer.cpp cf6acf1 
>   khtml/src/java/CMakeLists.txt 02efcd8 
>   khtml/src/CMakeLists.txt dd36945 
>   khtml/src/khtml_global.h 0d16716 
>   khtml/src/khtml_global.cpp 4d7c6ca 
>   khtml/src/khtml_part.cpp 6e7f87e 
>   khtml/src/khtmlimage.h 9623a2a 
>   khtml/src/khtmlimage.cpp a074051 
> 
> Diff: http://git.reviewboard.kde.org/r/113199/diff/
> 
> 
> Testing
> ---
> 
> Compiles.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113199: KHTML: KComponentData -> KAboutData

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

KComponentData -> KAboutData

This drops the KDE4Support dependency in KHTML.


Diffs
-

  khtml/src/java/kjavaappletviewer.h 3c3fd77 
  khtml/src/java/kjavaappletviewer.cpp cf6acf1 
  khtml/src/java/CMakeLists.txt 02efcd8 
  khtml/src/CMakeLists.txt dd36945 
  khtml/src/khtml_global.h 0d16716 
  khtml/src/khtml_global.cpp 4d7c6ca 
  khtml/src/khtml_part.cpp 6e7f87e 
  khtml/src/khtmlimage.h 9623a2a 
  khtml/src/khtmlimage.cpp a074051 

Diff: http://git.reviewboard.kde.org/r/113199/diff/


Testing
---

Compiles.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Compiling Plasma-Framework with a QT5 compiled with -egl -opengl es2

[nerdopolis]

On Thursday, October 10, 2013 12:00:04 PM kde-frameworks-devel-requ...@kde.org 
wrote:
> > Is this a bug I should file?
> no need to file a bug about it. It's code I have written and I know that it 
> currently requires glx. The problem here is that GLX is found on your system 
> but Qt is compiled as gles. This is an unfortunate situation and should not 
> happen in "real world" as one has either desktop gl or gles and not both on a 
> system.
> 
> Cheers
> Martin

Hi. It seems qtwayland needs egl though, which seems to require qt to be built 
with es2?

Checking for wayland... yes
Checking for xkbcommon... yes
Checking for wayland_scanner... yes
Checking for wayland_egl... no
Checking for egl... no
Checking for brcm_egl... no
Checking for glx... yes
Checking for xcomposite... yes
Project MESSAGE: no wayland-egl support detected, cross-toolkit compatibility 
disabled

It doesn't seem to build the plugin when I removed the -egl -opengl es2 and 
rebuilt QT.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1399

[KDE CI System]

See 

Changes:

[faure] Fix wrong usage of ecm_mark_as_test and add_test

--
[...truncated 1225 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kwallet/src/CMakeLists.txt:
  Target "KWallet" has policy CMP0022 enabled, but also 

Build failed in Jenkins: kdelibs_frameworks_qt5 #1398

[KDE CI System]

See 

Changes:

[faure] Make KFileDialog use KFileWidget directly again (no more kfilemodule 
plugin)

[faure] Add missing initialization of "enabled" member variable

[faure] Fix assert when the KLineEdit gets a child on construction

--
[...truncated 1225 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_

Re: update your cmake!

[Stephen Kelly]

Stephen Kelly wrote:

>> Oh... this means we can now make use of ALIAS targets and build truly
>> standalone frameworks \o/
> 
> I have a way to script that, but it can't be done yet.

I added the ALIAS targets with a script and ported some cases to KF5::Foo, 
but I think mostly it has to be done manually.

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1397

[KDE CI System]

See 

Changes:

[steveire] Port some use of the KArchive target to KF5::KArchive

[steveire] Port some KCoreAddons use to KF5::KCoreAddons.

--
[...truncated 1226 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kwallet/src/CMake

Re: KCapacityBar's painting code

[Stephen Kelly]

David Faure wrote:

> Hi Stephen,
> 
> The commit below removed the initialisation of d->ce_capacityBar,
> but this variable is still used in KCapacityBar::drawCapacityBar.
> Can we remove that block of code completely?

> Since the "[...]" contains the actual painting code, I assume the above
> block can be removed, but I'm confused because the commit log seems to
> contradict that. There can't be any styling in the style implementation if
> we never call the style in order to do the drawing...

I think the most likely explanation is that I misunderstood this point when 
porting the class to be KDE-free. I probably thought this was related to a 
style hint that a user of the class would set. If that's not the case, then 
I'll defer to you on the proper fix.

Thanks,

Steve.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KCapacityBar's painting code

[David Faure]

Hi Stephen,

The commit below removed the initialisation of d->ce_capacityBar,
but this variable is still used in KCapacityBar::drawCapacityBar.
Can we remove that block of code completely?

commit daef0997ef7dab76a5b0ace55cbe1009f8a86c0d
Author: Stephen Kelly 
Date:   Mon May 14 22:29:54 2012 +0200

Make KCapacityBar 'KDE free'

All styling should be done in the style implementation.


}

void KCapacityBar::drawCapacityBar(QPainter *p, const QRect &rect) const
{
if (d->ce_capacityBar)
{
QStyleOptionProgressBar opt;
opt.initFrom(this);
opt.rect = rect;
opt.minimum = 0;
opt.maximum = 100;
opt.progress = d->value;
opt.text = d->text;
opt.textAlignment = Qt::AlignCenter;
opt.textVisible = true;
style()->drawControl(d->ce_capacityBar, &opt, p, this);

return;
}

[...]
}

Since the "[...]" contains the actual painting code, I assume the above block 
can be removed, but I'm confused because the commit log seems to contradict 
that. There can't be any styling in the style implementation if we never call 
the style in order to do the drawing...

Or is the idea to add a way for styles to set ce_capacityBar (and to 
initialize it to 0)?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Setting an empty link interface (Was: Build failed in Jenkins: kdelibs_frameworks_qt5 #1395)

[Stephen Kelly]

KDE CI System wrote:

> [steveire] Require CMake 2.8.12.


> CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
> Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
> LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
> the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties

These are causally related of course. I pushed a temporary fix to ECM.

 http://thread.gmane.org/gmane.comp.kde.devel.frameworks/6454
 http://quickgit.kde.org/?p=extra-cmake-modules.git&a=commit&h=ba86148cf

The problem is that in kde4_add_library the LINK_INTERFACE_LIBRARIES 
property was set to empty so that link dependencies listed in 
target_link_libraries are private by default instead of public by default.

To replace that feature of the macro, a new CMAKE_LINK_INTERFACE_LIBRARIES 
variable was added to CMake which populates the default. In ECM, we've been 
setting that to empty.

However, CMake 2.8.12 has introduced a new property called 
INTERFACE_LINK_LIBRARIES as a replacement for LINK_INTERFACE_LIBRARIES. Of 
course, only one of them can be authorative, so policy CMP0022 was 
introduced to control which is so.

By setting the KDE minimum CMake version to 2.8.12, that policy has been set 
to NEW. Part of the NEW behavior of that policy is to error on export, as I 
quoted, if the LINK_INTERFACE_LIBRARIES property is set for a target.

A solution would be to remove the set(CMAKE_LINK_INTERFACE_LIBRARIES "") 
line from ECM. That would mean that a use of 

 target_link_libraries(foo A)

will cause A to be a public dependency of foo, not a private one. To make it 
a private dependency, LINK_PRIVATE would have to be specified.

That is the best solution I see for KDE for now. The use of the LINK_PUBLIC 
and LINK_PRIVATE keywords is now common and pervasive throughout KF5, so the 
mistake of leaving them out entirely is now less likely.

Brad, can you think of any other solution to the problem of 'make the link 
interface private by default'?

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdelibs_frameworks_qt5 #1396

[KDE CI System]

See 

Changes:

[steveire] Add ALIAS targets matching exported names.

--
[...truncated 1225 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kwallet/src/CMakeLists.txt:
  Target "KWallet" has policy CMP0022 enabled, but also has

Build failed in Jenkins: kdelibs_frameworks_qt5 #1395

[KDE CI System]

See 

Changes:

[steveire] Remove erroneous line.

[steveire] Require CMake 2.8.12.

[steveire] Update required ECM to version 0.0.9.

--
[...truncated 1226 lines...]


CMake Error in tier1/sonnet/src/core/CMakeLists.txt:
  Target "SonnetCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/sonnet/src/ui/CMakeLists.txt:
  Target "SonnetUi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/karchive/src/CMakeLists.txt:
  Target "KArchive" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/core/CMakeLists.txt:
  Target "KConfigCore" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kconfig/src/gui/CMakeLists.txt:
  Target "KConfigGui" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kdbusaddons/src/CMakeLists.txt:
  Target "KDBusAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/solid/src/solid/CMakeLists.txt:
  Target "Solid" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kcoreaddons/src/lib/CMakeLists.txt:
  Target "KCoreAddons" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kidletime/src/CMakeLists.txt:
  Target "KIdleTime" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kwindowsystem/src/CMakeLists.txt:
  Target "KWindowSystem" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/CMakeLists.txt:
  Target "KJS" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier1/kjs/src/kjs/api/CMakeLists.txt:
  Target "KJSApi" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kauth/src/CMakeLists.txt:
  Target "KAuth" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcrash/src/CMakeLists.txt:
  Target "KCrash" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/knotifications/src/CMakeLists.txt:
  Target "KNotifications" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kcompletion/src/CMakeLists.txt:
  Target "KCompletion" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/ki18n/src/CMakeLists.txt:
  Target "KI18n" has policy CMP0022 enabled, but also has old-style
  LINK_INTERFACE_LIBRARIES properties populated, but it was exported without
  the EXPORT_LINK_INTERFACE_LIBRARIES to export the old-style properties


CMake Error in tier2/kwallet/src/CMakeLists.

[extra-cmake-modules] /: Require CMake 2.8.12.

[Stephen Kelly]

Git commit 6f4b7ead789b186a1e570366756bf48c34d6ccbf by Stephen Kelly.
Committed on 11/10/2013 at 09:36.
Pushed by skelly into branch 'master'.

Require CMake 2.8.12.

As agreed.

CCMAIL: kde-frameworks-devel@kde.org

M  +1-1CMakeLists.txt

http://commits.kde.org/extra-cmake-modules/6f4b7ead789b186a1e570366756bf48c34d6ccbf

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ccd6ea2..b425a8f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 2.8.11 FATAL_ERROR)
+cmake_minimum_required(VERSION 2.8.12 FATAL_ERROR)
 
 project(extra-cmake-modules NONE)
 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

[Stephen Kelly]

Alex Richardson wrote:

> Am Donnerstag, 10. Oktober 2013, 00:11:45 schrieb Sebastian Kügler:
>> On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote:
>> > I have added this to some of my qt5 projects and it worked:
>> > 
>> > add_definitions(-fPIC)
>> 
>> Thanks Daniel, that helps. :)
>> 
>> > 2013/10/9 Sebastian Kügler :
>> > > 
/home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/global/qglob
>> > > al
>> > > .h:991:4: error: #error "You must build your code with position
>> > > independent code if Qt was built with -reduce-relocations. " "Compile
>> > > your code with -fPIC or -fPIE." make[2]: ***
> 
> I guess a better solution is:
> set(CMAKE_POSITION_INDEPENDENT_CODE ON)
> 
> This will probably also work with other compilers.

Not needed. See my other mail.

Thanks,

Steve.


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113197: KMessageBox: Factorize code between regular and *WId functions

[Aurélien Gâteau]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Factorize code between regular and *WId functions, reducing the file size by 
12%.

This patch adds another level of indirection. For example the sorry() function 
is changed from:

void sorry(QWidget *parent, ...args)
{
QDialog *dialog = new QDialog(parent);
/* fill dialog */
}

to:

static void sorryInternal(QDialog *dialog, ...args)
{
/* fill dialog */
}

void sorry(QWidget *parent, ...args)
{
sorryInternal(new QDialog(parent), ...args);
}

This makes it possible to turn the sorryWId() function into a forward function 
rather than a slightly-different copy of the original sorry() function:

void sorryWId(WId parent_id, ...args)
{
sorryInternal(createWIdDialog(parent_id), ...args);
}

createWIdDialog() is a helper function to create a dialog which is a child of a 
window belonging to another process.

Note: I kept most of the code to the place where it originally was in the file. 
This keeps the diff small, but readability would be improved by grouping 
together similar functions. Let me know if you think it is worth doing so.


Diffs
-

  tier1/kwidgetsaddons/src/kmessagebox.cpp 0cfa491 

Diff: http://git.reviewboard.kde.org/r/113197/diff/


Testing
---

Builds, kmessageboxwidtest.cpp runs correctly. No other tests are available 
though.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-hardware-devel] libnm-qt Qt5 port: -fPIC or fPIE needed?

[Alex Richardson]

Am Donnerstag, 10. Oktober 2013, 00:11:45 schrieb Sebastian Kügler:
> On Wednesday, October 09, 2013 18:14:10 Daniel Nicoletti wrote:
> > I have added this to some of my qt5 projects and it worked:
> > 
> > add_definitions(-fPIC)
> 
> Thanks Daniel, that helps. :)
> 
> > 2013/10/9 Sebastian Kügler :
> > > /home/sebas/kf5/qt5/qtbase/include/QtCore/../../src/corelib/global/qglob
> > > al
> > > .h:991:4: error: #error "You must build your code with position
> > > independent code if Qt was built with -reduce-relocations. " "Compile
> > > your code with -fPIC or -fPIE." make[2]: ***

I guess a better solution is:
set(CMAKE_POSITION_INDEPENDENT_CODE ON)

This will probably also work with other compilers.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2013-w41

[David Faure]

On Tuesday 08 October 2013 17:09:04 Kevin Ottens wrote:
> * teo is waiting on dfaure's kfile changes to wrap up KEncodingFileDialog 
> refactoring;

My changes are in - i.e. KIO::FileWidgets exists now, under 
staging/kio/src/filewidgets.

KEncodingFileDialog should move to that new library.

(What's not done yet is cleaning up the KFileModule stuff, but that's 
unrelated, as long as KEncodingFileDialog is ported away from it.)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: update your cmake!

[Kevin Ottens]

Hello,

On Thursday 10 October 2013 15:17:12 Sebastian Kügler wrote:
> In order to build KF5 and Plasma2 code, you have to update your cmake to
> 2.8.12. Otherwise, you'll get build errors.

Ok... that came as unexpected. I thought we'd handle the upgrade to 2.8.12 in 
a nicer way learning from past problems it caused from doing it too quick. 
>From my point of view the sooner we use it the better, would have been nice to 
give a one week warning though.

Since we already depend on it, I'd say update the version requirement in the 
code ASAP to reflect the change (AFAIK it's not done yet), then Stephen can 
run is script to introduce ALIAS. Which would finally enable to properly build 
in both monolithic and independent ways for the frameworks.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel