KModifierKeyInfo usage and API
We are still a bit unsure what to do about KModifierKeyInfo in KF5: * It's currently only implemented on X11 (PovAddict says querying for modifiers on Windows is easy to add, but getting notified of changes seems quite problematic) * The API (latching vs locking) seems to be a bit too X11 specific, it's unsure that these concepts exist on other platforms (issue raised in http://git.reviewboard.kde.org/r/112443/#review41013) * gwenview was ported away from it (a simple keyPress handler takes care of notifying the app that Ctrl was pressed) * This leaves two users for KModifierKeyInfo as far as lxr.kde.org can see: 1) kile uses it to query the status of Caps Lock at the time when a key is pressed. It uses isKeyLatched()||isKeyLocked() so clearly it doesn't need the distinction. 2) Plasma's KeyService offers the KModifierKeyInfo API in the KeyStatesEngine. Not sure how to then find the users of that general search on keystate found this: http://lxr.kde.org/source/kde/kdeplasma-addons/applets/plasmaboard/widget.cpp but I can't find the actual use of the engine in there? Can a plasma developer tell me how to find the use of this stuff, to see how much we can change its API? Thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113256: KMessageBox: Remove last traces of notification support
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113256/ --- (Updated Oct. 16, 2013, 11:46 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks. Repository: kdelibs Description --- KMessageBox: Remove last traces of notification support Diffs - KDE5PORTING.html acb408c tier1/kwidgetsaddons/src/kmessagebox.h 9a76c23 tier1/kwidgetsaddons/src/kmessagebox.cpp b2345d0 Diff: http://git.reviewboard.kde.org/r/113256/diff/ Testing --- Builds with and without -DKDE_NO_DEPRECATED. KMessageBox tests pass. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review41816 --- Wow, there sure is a lot of code in there catering for all the possible corner cases :-) QTimeZone has a lot less places it checks, so I'll need to do an in-depth comparison, but given Qt5 will only support modern distros I think most of it is redundant. One thought is if we still want to have a signal that the system database has been updated? While Qt doesn't cache the time zone data, the apps probably will cache the QTimeZone instances themselves and may need to be told that the database has changed so they can take action. Then again, it's not something that will happen very often, and what will the apps do in response? If they refresh their cache the shared copies in QDateTime won't update. I guess QTimeZone will need a reloadData() method added instead. I've looked at the Windows code and it mostly looks OK, all it does is monitor the registry for changes. What you do need to change is the DBus signal from configChanged to your new timeZoneChanged signal. With regards the signal name change, does it need to go in the porting guide or somewhere so people know it has changed? In Qt 5.3 I will try adding a QEvent for TimeZoneChanged and TimeZoneDatabaseChanged, but I can't guarantee it will get in so we still need the daemon for now. - John Layt On Oct. 15, 2013, 8:09 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 15, 2013, 8:09 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Porting notice: kDebug and qDebug need to go to qCDebug.
On Tuesday 15 October 2013 21:58:51 Mark wrote: Also, by default when porting to a qCDebug line with a category you won't see log output because custom categories have everything disabled by default. This has just been fixed in Qt, though. https://codereview.qt-project.org/66744 -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Porting notice: kDebug and qDebug need to go to qCDebug.
On Wed, Oct 16, 2013 at 2:39 PM, David Faure fa...@kde.org wrote: On Tuesday 15 October 2013 21:58:51 Mark wrote: Also, by default when porting to a qCDebug line with a category you won't see log output because custom categories have everything disabled by default. This has just been fixed in Qt, though. https://codereview.qt-project.org/66744 Oh interesting! Does that also mean that the porting notes should change from: qCDebug(CAT) some debug line; to // qCDebug(CAT) some debug line; (so commented) since now the default behavior is the same as qDebug() only with the category prefixed. Or (the other option) should people now by default add a line to disable the category logging thus adding this line: QLoggingCategory::setFilterRules(QStringLiteral(category.debug = false)); ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113266: introduce KMessageBoxNotifyInterface to support notifications
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113266/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- This is a 4-commit request which does the following: - moves plugin handling to kmessagebox_p.* - fixes loading of plugin (library name was wrong) - introduces KMessageBoxNotifyInterface - implements KMessageBoxNotifyInterface in the framework integration plugin. Individual patches are available here: http://agateau.com/tmp/kmessagebox-notification.patch.mbox (apply with `git am`) Diffs - staging/frameworkintegration/src/integrationplugin/CMakeLists.txt d8305bf staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.h ccf44d6 staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7 tier1/kwidgetsaddons/src/CMakeLists.txt 50c578a tier1/kwidgetsaddons/src/kmessagebox.h 9a76c23 tier1/kwidgetsaddons/src/kmessagebox.cpp b2345d0 tier1/kwidgetsaddons/src/kmessagebox_p.h PRE-CREATION tier1/kwidgetsaddons/src/kmessagebox_p.cpp PRE-CREATION tier1/kwidgetsaddons/src/kmessageboxnotifyinterface.h PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113266/diff/ Testing --- Ran kmessageboxtest, heard lots of beeps. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113267: Install kglobalshortcutinfo_p.h
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- kglobalshortcutinfo_p.h used to be installed in kde4 times and it is needed to generate the DBus interface from org.kde.KGlobalAccel.xml. Diffs - tier3/xmlgui/src/CMakeLists.txt f5c8fa1 Diff: http://git.reviewboard.kde.org/r/113267/diff/ Testing --- See http://build.kde.org/job/kde-workspace_master_qt5/1362/consoleFull Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Porting notice: kDebug and qDebug need to go to qCDebug.
On Wednesday 16 October 2013 15:08:53 Mark wrote: On Wed, Oct 16, 2013 at 2:39 PM, David Faure fa...@kde.org wrote: On Tuesday 15 October 2013 21:58:51 Mark wrote: Also, by default when porting to a qCDebug line with a category you won't see log output because custom categories have everything disabled by default. This has just been fixed in Qt, though. https://codereview.qt-project.org/66744 Oh interesting! Does that also mean that the porting notes should change from: qCDebug(CAT) some debug line; to // qCDebug(CAT) some debug line; (so commented) since now the default behavior is the same as qDebug() only with the category prefixed. Well, on the other hand the default behavior is now the same as kDebug(area), for most values of area: it prints by default, but it can be turned off. So qCDebug(CAT) some debug line; seems fine to me. It's the whole purpose of this stuff. Or (the other option) should people now by default add a line to disable the category logging thus adding this line: QLoggingCategory::setFilterRules(QStringLiteral(category.debug = false)); Please don't do that, it will prevent any better solution from working... The better solution is for qt to read a config file on startup, and if that doesn't go in, for our qpa theme plugin to do that. Calling setFilterRules from apps leaves no control to the poor user. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/#review41821 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 16, 2013, 7:45 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/ --- (Updated Oct. 16, 2013, 7:45 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds part about KDebug Diffs - KDE5PORTING.html acb408c Diff: http://git.reviewboard.kde.org/r/113181/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w42
On Tuesday 15 October 2013, Kevin Ottens wrote: Hello everyone, .. * steveire recommends _LIBRARIES variables from Config files and the template, Is there a verb missing in this sentence ? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Helping out with Frameworks 5
Hello, I want to help out with Frameworks 5 and/or Plasma 2. Perhaps it is best to start writing some unit tests, since I am not too familiar with the code. My favorite activities include removing chunks of obsolete and ugly code, but this one should be left for another time :-) What should I look into? Where can I find out what needs to be done? Looking at the wiki [1], it is unclear what I can jump into. Currently I have set up an acceptable devel environment, built frameworks5 / plasma2, so I'm ready to start doing something useful. Regards, Casian IRC - skelet [1] http://community.kde.org/Frameworks/Epics ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/#review41837 --- KDE5PORTING.html http://git.reviewboard.kde.org/r/113181/#comment30538 This is not valid anymore. It should now be qCdebug/warning/notice/... and with a category. I think it;s best to just link to the wiki page and skip the other information in this area. - Mark Gaiser On Oct. 16, 2013, 7:45 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113181/ --- (Updated Oct. 16, 2013, 7:45 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adds part about KDebug Diffs - KDE5PORTING.html acb408c Diff: http://git.reviewboard.kde.org/r/113181/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Helping out with Frameworks 5
Hi Casian, On Wednesday, October 16, 2013 14:35:39 Casian Andrei wrote: I want to help out with Frameworks 5 and/or Plasma 2. Perhaps it is best to start writing some unit tests, since I am not too familiar with the code. My favorite activities include removing chunks of obsolete and ugly code, but this one should be left for another time :-) What should I look into? More unittests would definitely be very useful. I know that Plasma is lacking n that area, there are some unittest, but definitely no great coverage. The kdelibs cleanup Epic still has some open todos, this is the current focus for work on frameworks. Where can I find out what needs to be done? Looking at the wiki [1], it is unclear what I can jump into. Currently I have set up an acceptable devel environment, built frameworks5 / plasma2, so I'm ready to start doing something useful. In Plasma, we're currently at a stage where things start to work, but are lacking in many areas. You could have a look at that by trying to set it up as your desktop, that way you'll likely already come across many things that you'll find lacking. There's your almost endless stream of inspiration what to do. ;) Before you begin on a task, check with us on IRC to coordinate, then get cracking. :) Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113276: Fix standalone builds of kidletime, kjs and kwindowsystem
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/#review41850 --- Ship it! tier1/kidletime/CMakeLists.txt http://git.reviewboard.kde.org/r/113276/#comment30542 really needed? Good work! :) - Aleix Pol Gonzalez On Oct. 16, 2013, 4:44 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113276/ --- (Updated Oct. 16, 2013, 4:44 p.m.) Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs Description --- Calls to functions provided by includes must come after includes themselves. This request also includes a separate commit for template/CMakeLists.txt, which moves all calls to find_package() after ecm is setup and provide a hint as to where find_package() calls should be. This should hopefully help prevent future errors. Diffs - template/CMakeLists.txt 96a5363 tier1/kidletime/CMakeLists.txt 21e9f37 tier1/kjs/CMakeLists.txt 9c2acaa tier1/kwindowsystem/CMakeLists.txt e4f984b Diff: http://git.reviewboard.kde.org/r/113276/diff/ Testing --- Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Porting away from KLocale
Hi, I was trying to port some application to Qt/KF5, then I realized that I didn't know how to port KLocale::formatByteSize. I don't see anything in QLocale for this, so I feel a bit stuck. Also I don't see any information in KDE5Porting.html Anybody has an idea of what's the solution? Thanks! Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113297: Remove 'override' from ThreadWeaver::IdDecorator destructor.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113297/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Remove 'override' from ThreadWeaver::IdDecorator destructor. MSVC2010 apparently doesn't support 'override' on destructors, even though it's legal according to C++11. Diffs - tier1/threadweaver/src/Weaver/IdDecorator.h 648d4236cc22015a1d145892daf368084a199053 Diff: http://git.reviewboard.kde.org/r/113297/diff/ Testing --- Still builds on Linux, now builds on Windows too. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113298: KDirWatch code style: cleanup whitespace.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description --- KDirWatch code style: cleanup whitespace. The KDirWatch code had *lots* of ( foo ) and inconsistent indentation and alignment, including a few tabs(!). This is a full cleanup of it. I appreciate any feedback; if I fixed something that didn't need fixing, or if you see more whitespace errors that I didn't fix, or if I should push this to master too, or if I should leave the damn thing alone and discard the review :) This file is also lacking braces for single-line conditionals and loops; I'll fix that in a separate commit for easier reviewing. It's also mixing 2-space and 4-space indentations, but changing everything to 4 spaces (as the kdelibs coding style says) seemed too intrusive. Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.h 7f6ca8ce83426c81a6336514c247aa9d115ec59e tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113298/diff/ Testing --- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113298: KDirWatch code style: cleanup whitespace.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113298/ --- (Updated Oct. 17, 2013, 12:51 a.m.) Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description (updated) --- KDirWatch code style: cleanup whitespace. The KDirWatch code had *lots* of ( foo ) and inconsistent indentation and alignment, including a few tabs(!). This is a full cleanup of it. I appreciate any feedback; if I fixed something that didn't need fixing, or if you see more whitespace errors that I didn't fix, or if I should push this to master too, or if I should leave the damn thing alone and discard the review :) This file is also lacking braces for single-line conditionals and loops; I'll fix that in a separate commit for easier reviewing. It's also mixing 2-space and 4-space indentations, but changing everything to 4 spaces (as the kdelibs coding style says) seemed too intrusive. Perhaps I should change the few 4-space indentations into 2-space for consistency? Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.h 7f6ca8ce83426c81a6336514c247aa9d115ec59e tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113298/diff/ Testing --- Still compiles :) Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113299: KDirWatch code style: braces for one-liner conditionals
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113299/ --- Review request for KDE Frameworks and kdelibs. Repository: kdelibs Description --- KDirWatch code style: braces for one-liner conditionals Added braces around single-line bodies of conditionals and loops, as specified in the kdelibs coding style. --end of commit message-- As in my previous review about whitespace, I appreciate any feedback; if I added braces where the code looked better without or viceversa, or if I should push this to master too, or if I should leave the damn braces alone and discard the review :) In some simple cases like if (stuff) return; I wasn't sure if it was better to leave it without braces... Diffs - tier1/kcoreaddons/src/lib/io/kdirwatch.cpp e4f45441d5ed68e3e34ae2bd68e16fd3dc46656a tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 442d6497b704c179adc13dbb25e450554d31554d Diff: http://git.reviewboard.kde.org/r/113299/diff/ Testing --- It compiles, tests pass. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113267: Install kglobalshortcutinfo_p.h
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/#review41855 --- Clients using this can build a header file from the installed XML service file using qt5_add_dbus_interface. - David Edmundson On Oct. 16, 2013, 1:56 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/ --- (Updated Oct. 16, 2013, 1:56 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- kglobalshortcutinfo_p.h used to be installed in kde4 times and it is needed to generate the DBus interface from org.kde.KGlobalAccel.xml. Diffs - tier3/xmlgui/src/CMakeLists.txt f5c8fa1 Diff: http://git.reviewboard.kde.org/r/113267/diff/ Testing --- See http://build.kde.org/job/kde-workspace_master_qt5/1362/consoleFull Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
CMake fails configuring KF5
Hi! I'm getting this error from CMake while building KF5: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5/Qt5Config.cmake:26 (find_package): Could not find a package configuration file provided by Qt5X11Extras with any of the following names: Qt5X11ExtrasConfig.cmake qt5x11extras-config.cmake Add the installation prefix of Qt5X11Extras to CMAKE_PREFIX_PATH or set Qt5X11Extras_DIR to a directory containing one of the above files. If Qt5X11Extras provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): tier1/kidletime/CMakeLists.txt:15 (find_package) -- Configuring incomplete, errors occurred! Anyone can tell me why could this be happening? Maybe is Qt5 not well built or is something KF5-only related? :-/ Thanks in advance David Gil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113300: Improve porting to Qt/KF5 scripts
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113300/ --- Review request for KDE Frameworks. Repository: plasma-framework Description --- Improve the porting scripts in plasma-framework (maybe they should be in kdesdk?). - Add a script to remove the Qt module part of an include (QtGui/QLabel becomes QLabel). - Add more cases when porting cmake files, adding the Qt libraries as well. Diffs - tools/port-cmake.sh 832cdd2 tools/port-includes.sh PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113300/diff/ Testing --- Been trying to port an application, to see how it worked. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: CMake fails configuring KF5
On Thu, Oct 17, 2013 at 6:59 AM, David Gil Oliva davidgilol...@gmail.comwrote: Hi! I'm getting this error from CMake while building KF5: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5/Qt5Config.cmake:26 (find_package): Could not find a package configuration file provided by Qt5X11Extras with any of the following names: Qt5X11ExtrasConfig.cmake qt5x11extras-config.cmake Add the installation prefix of Qt5X11Extras to CMAKE_PREFIX_PATH or set Qt5X11Extras_DIR to a directory containing one of the above files. If Qt5X11Extras provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): tier1/kidletime/CMakeLists.txt:15 (find_package) -- Configuring incomplete, errors occurred! Anyone can tell me why could this be happening? Maybe is Qt5 not well built or is something KF5-only related? :-/ Thanks in advance David Gil ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Well, is Qt5X11Extras installed? :) Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: CMake fails configuring KF5
2013/10/17 David Gil Oliva davidgilol...@gmail.com: Hi! I'm getting this error from CMake while building KF5: -- Found KF5: /home/david/devel/kf5-development/share/ECM/find-modules/FindKF5.cmake (found suitable version 5.0.0, minimum required is 5.0.0) found components: CMake Compiler InstallDirs CMake Error at /home/david/devel/kf5-development/qt5/qtbase/lib/cmake/Qt5/Qt5Config.cmake:26 (find_package): Could not find a package configuration file provided by Qt5X11Extras with any of the following names: Qt5X11ExtrasConfig.cmake qt5x11extras-config.cmake Add the installation prefix of Qt5X11Extras to CMAKE_PREFIX_PATH or set Qt5X11Extras_DIR to a directory containing one of the above files. If Qt5X11Extras provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): tier1/kidletime/CMakeLists.txt:15 (find_package) -- Configuring incomplete, errors occurred! Anyone can tell me why could this be happening? Maybe is Qt5 not well built or is something KF5-only related? :-/ Did you only compile qtbase? To compile all of KF5, you need qtbase, qtdeclarative, qtx11extras, qtsvg, and maybe one or two more I'm forgetting. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Update Meeting Minutes 2013-w42
On Wednesday 16 October 2013 19:17:06 Alexander Neundorf wrote: On Tuesday 15 October 2013, Kevin Ottens wrote: Hello everyone, .. * steveire recommends _LIBRARIES variables from Config files and the template, Is there a verb missing in this sentence ? Oops, yes indeed... * steveire recommends removing _LIBRARIES variables from Config files and the template, Regards. -- Kévin Ottens, http://ervin.ipsquad.net Sponsored by KDAB to work on KDE Frameworks KDAB - proud supporter of KDE, http://www.kdab.com ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113267: Install kglobalshortcutinfo_p.h
On Oct. 17, 2013, 6:36 a.m., David Edmundson wrote: Clients using this can build a header file from the installed XML service file using qt5_add_dbus_interface. try it! It doesn't work. That's the whole point why I opened the review request. The build fails because it needs to include the private header. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/#review41855 --- On Oct. 16, 2013, 3:56 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267/ --- (Updated Oct. 16, 2013, 3:56 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- kglobalshortcutinfo_p.h used to be installed in kde4 times and it is needed to generate the DBus interface from org.kde.KGlobalAccel.xml. Diffs - tier3/xmlgui/src/CMakeLists.txt f5c8fa1 Diff: http://git.reviewboard.kde.org/r/113267/diff/ Testing --- See http://build.kde.org/job/kde-workspace_master_qt5/1362/consoleFull Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
