Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB
On Oct. 29, 2013, 3:42 a.m., Fredrik Höglund wrote: Looks much better, but it doesn't handle depth 30 pixmaps. I'm lacking ideas on how to test this. Do you know any application which uses 30 bit pixmaps? - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review42568 --- On Oct. 24, 2013, 12:22 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Oct. 24, 2013, 12:22 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Implements the createPixmapFromHandle by getting the image for the pixmaps and using it as either the Pixmap or the bitmap mask. Diffs - tier1/kwindowsystem/src/kxutils.cpp 33bd678 tier1/kwindowsystem/src/kxutils_p.h 84d639b tier1/kwindowsystem/tests/CMakeLists.txt 5cf5868 tier1/kwindowsystem/tests/createpixmapfromhandletest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112755/diff/ Testing --- Adjusted KWin to take this codepath and say thanks to Iceweasel for having a mask Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 4, 2013, 9:14 a.m.) Review request for KDE Frameworks. Changes --- * added the missing static to the two helper methods * added a check to early quit if big endian system. If someone has a big endian system I would appreciate if he could look into properly supporting this. Repository: kdelibs Description --- Implements the createPixmapFromHandle by getting the image for the pixmaps and using it as either the Pixmap or the bitmap mask. Diffs (updated) - tier1/kwindowsystem/src/kxutils.cpp 33bd678 tier1/kwindowsystem/src/kxutils_p.h 84d639b tier1/kwindowsystem/tests/CMakeLists.txt 0060903 tier1/kwindowsystem/tests/createpixmapfromhandletest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112755/diff/ Testing --- Adjusted KWin to take this codepath and say thanks to Iceweasel for having a mask Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113530: Adapt KDED to use DBus to communicate with KSplash
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113530/#review42932 --- This review has been submitted with commit 501cc1c00994dbf6f3eb167a2e6e28e9a7cdd51d by Martin Klapetek to branch frameworks. - Commit Hook On Nov. 1, 2013, 12:38 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113530/ --- (Updated Nov. 1, 2013, 12:38 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- The xatom interface was removed from KSplash and replaced with a DBus one. This makes kded use the DBus interface. Diffs - tier3/kded/src/kded.cpp a07c2fe Diff: http://git.reviewboard.kde.org/r/113530/diff/ Testing --- Works. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113530: Adapt KDED to use DBus to communicate with KSplash
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113530/ --- (Updated Nov. 4, 2013, 10:12 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- The xatom interface was removed from KSplash and replaced with a DBus one. This makes kded use the DBus interface. Diffs - tier3/kded/src/kded.cpp a07c2fe Diff: http://git.reviewboard.kde.org/r/113530/diff/ Testing --- Works. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113533: Adapt KCMInit to use DBus to communicate with KSplash
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113533/#review42935 --- This review has been submitted with commit 4948675621c409d3b724fcc3ffb0668c21b3306d by Martin Klapetek to branch master. - Commit Hook On Nov. 1, 2013, 12:55 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113533/ --- (Updated Nov. 1, 2013, 12:55 p.m.) Review request for kde-workspace and KDE Frameworks. Repository: kde-workspace Description --- The xatom interface was removed from KSplash and replaced with a DBus one. This makes kcminit use the DBus interface and also removes the Xlib dependency (two commits). Diffs - kcminit/main.cpp 856d8b7 Diff: http://git.reviewboard.kde.org/r/113533/diff/ Testing --- KCMInit is still disabled for building, not much to test yet, but it works elsewhere, no reason to not work here. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KEmailSettings and ksendbugmail
On Sunday 03 November 2013 13:05:09 Kevin Ottens wrote: Hello, On Sunday 03 November 2013 10:14:57 David Faure wrote: KEmailSettings has historically been in KIO. It's however, just a bunch of KConfig calls. ksendbugmail is a separate program used by tier3/xmlgui/src/kbugreport.cpp and it needs KEmailSettings (and in kde4 it didn't even link to kio for that, it just compiled that file alone from the kio sources...). Any objections against moving KEmailSettings to KConfigCore? Then I can move ksendbugmail to xmlgui and avoid an unwanted xmlgui-kio dependency. Why not both in xmlgui? What else uses KEmailSettings? I know that dependency wise it can go in KConfigCore, I'm just wondering if it'll look out of place there. KEmailSettings in xmlgui? This looks even stranger to me. It's not related at all to the xmlgui technology (or in fact, to anything gui). ksendbugmail is an SMTP client, it needs to read the config that holds your email address and preferred smtp server - this is completely unrelated to anything GUI, it definitely shouldn't have to link to xmlgui for this. Neither should the imap and pop akonadi resources, or kio_smtp. KEmailSettings definitely belongs to a core library, not to a gui one. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/ --- (Updated Nov. 4, 2013, 11:13 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Improve documentation in ECMInstallIcons.cmake Diffs - modules/ECMInstallIcons.cmake 1114805 Diff: http://git.reviewboard.kde.org/r/113522/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/#review42936 --- This review has been submitted with commit c4a1d70dc4e8501fbbfeec287bc06d30223f15b4 by David Edmundson to branch master. - Commit Hook On Oct. 31, 2013, 5:07 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/ --- (Updated Oct. 31, 2013, 5:07 p.m.) Review request for KDE Frameworks. Repository: extra-cmake-modules Description --- Improve documentation in ECMInstallIcons.cmake Diffs - modules/ECMInstallIcons.cmake 1114805 Diff: http://git.reviewboard.kde.org/r/113522/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KEmailSettings and ksendbugmail
On Monday 04 November 2013 11:24:37 David Faure wrote: On Sunday 03 November 2013 13:05:09 Kevin Ottens wrote: Hello, On Sunday 03 November 2013 10:14:57 David Faure wrote: KEmailSettings has historically been in KIO. It's however, just a bunch of KConfig calls. ksendbugmail is a separate program used by tier3/xmlgui/src/kbugreport.cpp and it needs KEmailSettings (and in kde4 it didn't even link to kio for that, it just compiled that file alone from the kio sources...). Any objections against moving KEmailSettings to KConfigCore? Then I can move ksendbugmail to xmlgui and avoid an unwanted xmlgui-kio dependency. Why not both in xmlgui? What else uses KEmailSettings? I know that dependency wise it can go in KConfigCore, I'm just wondering if it'll look out of place there. KEmailSettings in xmlgui? This looks even stranger to me. It's not related at all to the xmlgui technology (or in fact, to anything gui). ksendbugmail is an SMTP client, it needs to read the config that holds your email address and preferred smtp server - this is completely unrelated to anything GUI, it definitely shouldn't have to link to xmlgui for this. Neither should the imap and pop akonadi resources, or kio_smtp. KEmailSettings definitely belongs to a core library, not to a gui one. OK then. I still think that semantically, it'd fit better in something more PIM or desktop consistency related... but since I can't find anything where it'd make sense for now. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- While installing frameworks I noticed some of them have .SOVERSION instead of real version appended. This sets proper SO version in respective cmake files and libs now have proper .5.0.0 suffix. Diffs - tier3/kemoticons/src/core/CMakeLists.txt d25a863 tier3/knewstuff/src/CMakeLists.txt dd5c69a tier3/kprintutils/src/CMakeLists.txt b7ce265 tier3/kpty/src/CMakeLists.txt 4948dcc tier3/kross/src/core/CMakeLists.txt d66f273 tier3/kross/src/qts/CMakeLists.txt b25adee tier3/kross/src/ui/CMakeLists.txt 9736ec0 tier4/kcmutils/src/CMakeLists.txt e0a87be Diff: http://git.reviewboard.kde.org/r/113601/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KEmailSettings and ksendbugmail
On Monday, November 04, 2013 12:15:50 Kevin Ottens wrote: KEmailSettings definitely belongs to a core library, not to a gui one. OK then. I still think that semantically, it'd fit better in something more PIM or desktop consistency related... but since I can't find anything where it'd make sense for now. What's the email settings? is something I'd search in KConfig* before I went looking into XmlGui. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113506: Add a sb_all target and sb_$framework targets to make it easier to build frameworks standalone
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113506/ --- (Updated Nov. 4, 2013, 4:41 p.m.) Review request for KDE Frameworks, Alexander Neundorf and Stephen Kelly. Repository: kdelibs Description --- This patch rework superbuild to integrate it more closely with kdelibs build system: one no longer needs to run cmake path/to/kdelibs/superbuild separately. Instead targets are created for all frameworks declared in superbuild/CMakeLists.txt. For example to build and install ki18n standalone, one can run `make sb_ki18n`. It also adds a special sb_all target, which builds and install all standalone frameworks. Diffs (updated) - CMakeLists.txt feb5b43 superbuild/CMakeLists.txt 7d9617c superbuild/README 7a4e52e superbuild/SuperBuild.cmake 33ed151 Diff: http://git.reviewboard.kde.org/r/113506/diff/ Testing --- kdelibs still builds standalone, all sb_* targets work as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113406: Add a macro to automatically generate forward headers
On Oct. 30, 2013, 10:47 a.m., David Faure wrote: Looks good to me (apart from the expired pastebin links in the initial description). I can't Ship it because I'm not a cmake guru/maintainer though. Same here, looks OK, but I'd like Alex or Stephen to give it the ship it. - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/#review42700 --- On Oct. 29, 2013, 10:52 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113406/ --- (Updated Oct. 29, 2013, 10:52 a.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Repository: extra-cmake-modules Description --- Create a macro that will generate the forward headers like we used to, in cmake configure time. Here's an example of how we'd port KParts to that macro: http://paste.opensuse.org/9880051 After the change, these are the installed headers: http://paste.opensuse.org/90980400 Diffs - modules/ECMGenerateHeaders.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113406/diff/ Testing --- Ported KParts and still everything works. File Attachments kparts changes example http://git.reviewboard.kde.org/media/uploaded/files/2013/10/29/a3557579-801b-4ee6-8e3d-5d487428759a__kf5-kparts-headers-test.patch Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/#review42955 --- tier4/kde4support/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/113527/#comment31022 Shouldn't that be KF5::KNotifications? - Kevin Ottens On Oct. 31, 2013, 11:30 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- (Updated Oct. 31, 2013, 11:30 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Alternative to RR 113393. Commit 1: Move KPassivePopup to KNotifications As well as being a conceptual fit, KPassivePopup needs to do X11 magic, and this is a lot easier if it can make use of the KWindowSystem library. Commit 2: Fix KPassivePopup placement The non-X11 code is largely untested. Diffs - tier1/kwidgetsaddons/CMakeLists.txt 01bae90e235fae424f3af48fb95dc24286e60562 tier1/kwidgetsaddons/src/CMakeLists.txt beb5ecad9e063936dea9ca38f42238988ca3f51b tier1/kwidgetsaddons/src/kpassivepopup.h d7cef3dd94713554010547001de6b4d81e3e2961 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/tests/CMakeLists.txt d0140ea2489a629949b7022f310dcd6349c06f20 tier1/kwidgetsaddons/tests/kpassivepopuptest.h tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 tier2/knotifications/src/CMakeLists.txt 7f5a332d6650f998d72c97b7cfddd27362756b08 tier2/knotifications/tests/CMakeLists.txt 6f3be50819ffef19644b77c397e5b4966d61abd6 tier4/kde4support/tests/CMakeLists.txt b22e2e818fc13519318fa32de44f5d4a32301661 Diff: http://git.reviewboard.kde.org/r/113527/diff/ Testing --- Test app (in tests/ folder) works as expected on X11: if _NET_WM_ICON_GEOMETRY is set and a window id is passed, the popup is placed by the taskbar entry; if it is not set, it is place by the window; if a window id is not passed, it is placed top left (avoiding any panels) on the desktop. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42954 --- Looks OK to me, but I'd like John to give it a last look. - Kevin Ottens On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113516: Implement queueing directly in KDialogJobUiDelegate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/#review42956 --- Small nitpick, otherwise looks fine. tier2/kjobwidgets/src/kdialogjobuidelegate.cpp http://git.reviewboard.kde.org/r/113516/#comment31023 What about using shared pointers? - Kevin Ottens On Oct. 31, 2013, 9:41 a.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113516/ --- (Updated Oct. 31, 2013, 9:41 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Implement queueing directly in KDialogJobUiDelegate by queueing calls to KDialogJobUiDelegate::Private::next which shows 1 KMessageBox at the time. Diffs - tier2/kjobwidgets/src/kdialogjobuidelegate.cpp 29c2bae tier2/kjobwidgets/tests/kjobtrackerstest.cpp 7a61407 Diff: http://git.reviewboard.kde.org/r/113516/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review42957 --- Ship it! Ship It! - Kevin Ottens On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp tier1/kguiaddons/src/plugins/png.desktop tier1/kguiaddons/src/plugins/pnm.desktop
Re: Review Request 112896: Rework NETWM classes
On Sept. 26, 2013, 2:27 a.m., Fredrik Höglund wrote: I'm just going to point out something I know you already know since we've discussed it many times; that an xcb port of the NETWM classes already exists in a branch. Martin Gräßlin wrote: my aim was to write the unit test and that was the big junk of this work compared to the xcb changes (which I thought to be easier than trying to rebase the branch :-( ) Fredrik Höglund wrote: The problem with rebasing the branch was solved a long time ago. There shouldn't be any conflicts except maybe in CMakeLists.txt files. Martin Gräßlin wrote: ah, I didn't know that. I will have a look and see whether I can integrate the unit tests and the bug fixes on top of your branch. Kevin Ottens wrote: Any news about that patch? Kevin Ottens wrote: Should I close this one too next monday? Last warning: I'll close it next time I do my review round and there's no activity. ;-) - Kevin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/#review40840 --- On Sept. 23, 2013, 1:11 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112896/ --- (Updated Sept. 23, 2013, 1:11 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- This is a patch series, if needed I can push the branch. The patches address the following topics: * add unit tests for NETRootInfo and NETWinInfo which do not require a running window manager. Test coverage of netwm.h is: ** line coverage: 75 % ** functions coverage: 84 % ** branch coverage: 62 % The tests start their own Xvfb to have a clean state and not mess up with the Window Manager of a user or cause followint tests to fail on the CI system * areas which are covered by unit tests are changed from XLib to XCB. This mostly affects changing and reading window properties * API is changed from XLib types to XCB types. E.g. xcb_window_t instead of Window. Note: this is an API break, which I consider as necessary, given that especially the type Window is problematic. * several bugs which were discovered through the added tests are fixed * NETWinInfo2 is merged into NETWinInfo (marked as TODO KDE5) * Small wrapper class for intern atom added to KXUtils. Similar code already in usage in KWin. = Commits: commit 2e50845a5d0df436106aeb776e3936691c32a753 Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 23 14:31:42 2013 +0200 Use XCB for reading properties in NETRootInfo::update Viewport handling was incorrect and is adjusted to be read correctly. commit 23887726c03c49b4e0021c01f319653d3b9f36c5 Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 23 11:41:26 2013 +0200 Use XCB for reading properties in NETWinInfo::update Those areas which are covered by unit tests are migrated from XGetWindowProperty to the xcb variant. BlocksCompositing had an incorrect read - it expected a string atom, but actually uses a cardinal. This bug is fixed. commit 2731ebbc85eddb885700232f98e0e429cb0e066b Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 23 09:41:28 2013 +0200 Use XCB to change the Client dependent properties of NETWinInfo Those properties for which we have unit tests are changed to XCB to either change or delete the property. commit 1bb85e440ec0004ef6b18b6fa1855c08c8f6697a Author: Martin Gräßlin mgraess...@kde.org Date: Fri Sep 20 09:58:09 2013 +0200 Unit test for Client aspect of NETWinInfo Similar to the NETWinInfo test with WindowManager aspect, just verifying the properties which can only be set by a Client. The test found highlights a few possible problems: * for some window types a fallback type is specified, but the lenght is set to 1, thus the fallback type is not set at all * Fullscreen monitors property is not handled in the event function commit 2731ebbc85eddb885700232f98e0e429cb0e066b Author: Martin Gräßlin mgraess...@kde.org Date: Mon Sep 23 09:41:28 2013 +0200 Use XCB to change the Client dependent properties of NETWinInfo Those properties for which we have unit tests are changed to XCB to either change or delete the property. commit 1bb85e440ec0004ef6b18b6fa1855c08c8f6697a Author: Martin Gräßlin mgraess...@kde.org Date: Fri Sep 20 09:58:09 2013 +0200 Unit test for Client aspect of NETWinInfo Similar to the NETWinInfo test with WindowManager aspect, just verifying the properties which can only be set by a Client.
Re: Review Request 113589: Allow test-kconf_update to run before kconfig is installed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/#review42958 --- Ship it! Ship It! - Kevin Ottens On Nov. 3, 2013, 3:05 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/ --- (Updated Nov. 3, 2013, 3:05 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Allow test-kconf_update to run before kconfig is installed While we can't reasonably expect make test to work before make install in frameworks as a whole, as various tests depend on an installed kded for example, it should be possible to run the tests of any individual framework before that framework is itself installed. Tests should depend on the current *build*, not the current installation. Diffs - tier1/kconfig/autotests/test_kconf_update.cpp 5226c60b9b275a7faa599507d3238107c6361ba7 tier1/kconfig/src/kconf_update/config-kconf.h.cmake 27cdb98d7a85a70fd4299b095d4b9aa032cca126 Diff: http://git.reviewboard.kde.org/r/113589/diff/ Testing --- make test in kconfig now succeeds before the frameworks are installed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review42959 --- Ship it! Ship It! - Kevin Ottens On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/#review42960 --- Ship it! Ship It! - Kevin Ottens On Nov. 4, 2013, 11:33 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/ --- (Updated Nov. 4, 2013, 11:33 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- While installing frameworks I noticed some of them have .SOVERSION instead of real version appended. This sets proper SO version in respective cmake files and libs now have proper .5.0.0 suffix. Diffs - tier3/kemoticons/src/core/CMakeLists.txt d25a863 tier3/knewstuff/src/CMakeLists.txt dd5c69a tier3/kprintutils/src/CMakeLists.txt b7ce265 tier3/kpty/src/CMakeLists.txt 4948dcc tier3/kross/src/core/CMakeLists.txt d66f273 tier3/kross/src/qts/CMakeLists.txt b25adee tier3/kross/src/ui/CMakeLists.txt 9736ec0 tier4/kcmutils/src/CMakeLists.txt e0a87be Diff: http://git.reviewboard.kde.org/r/113601/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting 2013-w45 Reminder
Hello all, Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris time. See you there! Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42961 --- I've asked on the Qt Development list about Qt 5 Solaris support. I'm told it builds and works to some extent, and patches are welcome, but not without having been tested on a real Solaris build first, which I have no desire to do. I don't think much is required, Solaris uses the Olsen tz files, just with different patches and possibly a different zonetab layout, but I don't want to code blind. So we have two options, one is not worry about Solaris support for now, and if anyone (Ade?) complains then ask them to contribute upstream (with my help). The alternative is to keep the Solaris code in ktimezoned, including calls to return the current system time zone and the list of available time zones, and on other platforms just wrap the Qt calls. Opinions? - John Layt On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
On Nov. 4, 2013, 4:12 p.m., John Layt wrote: I've asked on the Qt Development list about Qt 5 Solaris support. I'm told it builds and works to some extent, and patches are welcome, but not without having been tested on a real Solaris build first, which I have no desire to do. I don't think much is required, Solaris uses the Olsen tz files, just with different patches and possibly a different zonetab layout, but I don't want to code blind. So we have two options, one is not worry about Solaris support for now, and if anyone (Ade?) complains then ask them to contribute upstream (with my help). The alternative is to keep the Solaris code in ktimezoned, including calls to return the current system time zone and the list of available time zones, and on other platforms just wrap the Qt calls. Opinions? s/patches/paths - John --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42961 --- On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113606: Fix standalone build of KConfigWidgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Add missing Qt5::Xml dependency in KConfigGui, add some missing KF5:: prefix. Diffs - superbuild/CMakeLists.txt 7d9617c tier1/kconfig/KConfigConfig.cmake.in 7325c5e tier3/kconfigwidgets/src/CMakeLists.txt 1cd6794 tier3/kconfigwidgets/tests/CMakeLists.txt e225952 Diff: http://git.reviewboard.kde.org/r/113606/diff/ Testing --- Builds and install standalone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/#review42975 --- This review has been submitted with commit 1e1b33ea862bcbcfdf24a769f36bfcc672bc0f02 by Martin Klapetek to branch frameworks. - Commit Hook On Nov. 4, 2013, 11:33 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/ --- (Updated Nov. 4, 2013, 11:33 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- While installing frameworks I noticed some of them have .SOVERSION instead of real version appended. This sets proper SO version in respective cmake files and libs now have proper .5.0.0 suffix. Diffs - tier3/kemoticons/src/core/CMakeLists.txt d25a863 tier3/knewstuff/src/CMakeLists.txt dd5c69a tier3/kprintutils/src/CMakeLists.txt b7ce265 tier3/kpty/src/CMakeLists.txt 4948dcc tier3/kross/src/core/CMakeLists.txt d66f273 tier3/kross/src/qts/CMakeLists.txt b25adee tier3/kross/src/ui/CMakeLists.txt 9736ec0 tier4/kcmutils/src/CMakeLists.txt e0a87be Diff: http://git.reviewboard.kde.org/r/113601/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113260: Port KTimeZoned to Qt5/KF5
On Nov. 4, 2013, 4:12 p.m., John Layt wrote: I've asked on the Qt Development list about Qt 5 Solaris support. I'm told it builds and works to some extent, and patches are welcome, but not without having been tested on a real Solaris build first, which I have no desire to do. I don't think much is required, Solaris uses the Olsen tz files, just with different patches and possibly a different zonetab layout, but I don't want to code blind. So we have two options, one is not worry about Solaris support for now, and if anyone (Ade?) complains then ask them to contribute upstream (with my help). The alternative is to keep the Solaris code in ktimezoned, including calls to return the current system time zone and the list of available time zones, and on other platforms just wrap the Qt calls. Opinions? John Layt wrote: s/patches/paths I'd like to reiterate the (imho) bigger issue here - there's no effort at all to have KF5 and/or PW2 running on Solaris (unlike the Windows effort), so I wouldn't push it (only) to the smallest component in the workspace, it makes no sense at this time. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/#review42961 --- On Oct. 22, 2013, 4:49 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113260/ --- (Updated Oct. 22, 2013, 4:49 p.m.) Review request for KDE Runtime, KDE Frameworks, Plasma, and John Layt. Repository: kde-runtime Description --- Originally I wanted to port KTimeZoned 1:1 to Qt5/KF5, but then I found out that all the stuff KTZD was doing was added in QTimeZone, that includes reading correct system files/env variables to obtain the timezone and returning the proper system zone (KTZD did all this by itself). It also doesn't need to parse the timezone files itself or watch for their changes as QTimeZone objects are not stored. So now it's just a thin module watching /etc/timezone (used by Debian-based distros) and /etc/localtime (used by eg. Fedora or Suse, but also by Debian in conjunction with /etc/timezone) for changes and if it detects a change, it checks if the new timezone is really different and if it is, it sends out a DBus signal timeZoneChange. I changed it from configChanged as I think timeZoneChanged makes way more sense. I didn't touch the Windows part as I have no way to test, would be nice if someone could help with that. EDIT: I removed the other two DBus signals which were not used and I'm unsure KTZD is the correct place for that now anyway. The only usage in KSystemTimeZone can be replaced by own KDirWatch instance. Diffs - CMakeLists.txt a5ec93d ktimezoned/CMakeLists.txt bafc85e ktimezoned/ktimezoned.h ff21807 ktimezoned/ktimezoned.cpp f380c09 ktimezoned/ktimezoned_win.h 26e21cc ktimezoned/ktimezoned_win.cpp cadfe3a ktimezoned/ktimezonedbase.h ca00aca ktimezoned/org.kde.KTimeZoned.xml daaa0b7 Diff: http://git.reviewboard.kde.org/r/113260/diff/ Testing --- Tested by changing the timezone in different ways, change was detected and signalled out. Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113601: Replace ${GENERIC_LIB_(SO)VERSION} with actual version variables
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113601/ --- (Updated Nov. 4, 2013, 4:54 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- While installing frameworks I noticed some of them have .SOVERSION instead of real version appended. This sets proper SO version in respective cmake files and libs now have proper .5.0.0 suffix. Diffs - tier3/kemoticons/src/core/CMakeLists.txt d25a863 tier3/knewstuff/src/CMakeLists.txt dd5c69a tier3/kprintutils/src/CMakeLists.txt b7ce265 tier3/kpty/src/CMakeLists.txt 4948dcc tier3/kross/src/core/CMakeLists.txt d66f273 tier3/kross/src/qts/CMakeLists.txt b25adee tier3/kross/src/ui/CMakeLists.txt 9736ec0 tier4/kcmutils/src/CMakeLists.txt e0a87be Diff: http://git.reviewboard.kde.org/r/113601/diff/ Testing --- Thanks, Martin Klapetek ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113609: Fix standalone build of kservice
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kservice. Usual addition of KF5:: prefix and find_packages() call. Diffs - superbuild/CMakeLists.txt 7d9617c tier3/kservice/CMakeLists.txt 4f8b631 tier3/kservice/tests/CMakeLists.txt 444d7db Diff: http://git.reviewboard.kde.org/r/113609/diff/ Testing --- Builds standalone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113625: Prepare KHTML for moving into tier4.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Tidy target_link for KHTML. Diffs - khtml/src/CMakeLists.txt ed113f5 khtml/src/java/CMakeLists.txt 3dd2d88 Diff: http://git.reviewboard.kde.org/r/113625/diff/ Testing --- Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113625: Prepare KHTML for moving into tier4.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/#review42979 --- khtml/src/CMakeLists.txt http://git.reviewboard.kde.org/r/113625/#comment31025 Super-small-nitpick - this could be merged with the target_link_libraries above (the big one) as is the case with other frameworks, makes it more readable imho - Martin Klapetek On Nov. 4, 2013, 6:13 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113625/ --- (Updated Nov. 4, 2013, 6:13 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Tidy target_link for KHTML. Diffs - khtml/src/CMakeLists.txt ed113f5 khtml/src/java/CMakeLists.txt 3dd2d88 Diff: http://git.reviewboard.kde.org/r/113625/diff/ Testing --- Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113606: Fix standalone build of KConfigWidgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/#review42982 --- Ship it! Ship It! - Kevin Ottens On Nov. 4, 2013, 4:31 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113606/ --- (Updated Nov. 4, 2013, 4:31 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add missing Qt5::Xml dependency in KConfigGui, add some missing KF5:: prefix. Diffs - superbuild/CMakeLists.txt 7d9617c tier1/kconfig/KConfigConfig.cmake.in 7325c5e tier3/kconfigwidgets/src/CMakeLists.txt 1cd6794 tier3/kconfigwidgets/tests/CMakeLists.txt e225952 Diff: http://git.reviewboard.kde.org/r/113606/diff/ Testing --- Builds and install standalone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113609: Fix standalone build of kservice
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/#review42981 --- Ship it! Ship It! - Kevin Ottens On Nov. 4, 2013, 5:38 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113609/ --- (Updated Nov. 4, 2013, 5:38 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Fix standalone build of kservice. Usual addition of KF5:: prefix and find_packages() call. Diffs - superbuild/CMakeLists.txt 7d9617c tier3/kservice/CMakeLists.txt 4f8b631 tier3/kservice/tests/CMakeLists.txt 444d7db Diff: http://git.reviewboard.kde.org/r/113609/diff/ Testing --- Builds standalone and as part of kdelibs. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43004 --- This review has been submitted with commit 586362f10e1a34f30df4d519b9ae62041222b7b6 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113589: Allow test-kconf_update to run before kconfig is installed
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/#review43012 --- This review has been submitted with commit cdde13df711e2e0f4ae6378a06123385a7b60298 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 3:05 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113589/ --- (Updated Nov. 3, 2013, 3:05 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Allow test-kconf_update to run before kconfig is installed While we can't reasonably expect make test to work before make install in frameworks as a whole, as various tests depend on an installed kded for example, it should be possible to run the tests of any individual framework before that framework is itself installed. Tests should depend on the current *build*, not the current installation. Diffs - tier1/kconfig/autotests/test_kconf_update.cpp 5226c60b9b275a7faa599507d3238107c6361ba7 tier1/kconfig/src/kconf_update/config-kconf.h.cmake 27cdb98d7a85a70fd4299b095d4b9aa032cca126 Diff: http://git.reviewboard.kde.org/r/113589/diff/ Testing --- make test in kconfig now succeeds before the frameworks are installed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43009 --- This review has been submitted with commit 0c5d856cade6fd0c06d239744c97a4223cb9fe16 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43011 --- This review has been submitted with commit 7fcde34e2cb197250e46e935d6948a1582955567 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43006 --- This review has been submitted with commit 4fa0949c5a60ed9d282735552ea5addf5aff6da3 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43005 --- This review has been submitted with commit 9b07bdb0fcf04ea7fa31a27f8cc1cdcceb3cf293 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43006 --- This review has been submitted with commit dc2ee505b6dbc3e11b949566ed24eac307a6a5eb by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43002 --- This review has been submitted with commit 0c6dad468d06d45a68ce08e47563d4b6825a2685 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43008 --- This review has been submitted with commit 66ada97096ef1b01af247ebcd45600bd748a42ed by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43010 --- This review has been submitted with commit 8404a524f2f9902144015f7247500f9ed8e7ec2e by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/#review43003 --- This review has been submitted with commit 7d21b11b3cbb464e4ef9477157e84a411df59fd4 by Alex Merry to branch frameworks. - Commit Hook On Nov. 3, 2013, 5:24 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 3, 2013, 5:24 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43014 --- This review has been submitted with commit cced5d95d5b4ad47d882889440f7ba8f562dcced by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43019 --- This review has been submitted with commit a4f04712a73f46d740f3f0a316910643b9190c17 by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43017 --- This review has been submitted with commit bd1734a09bb18ec9db1075153b15e3160b91fd7c by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43018 --- This review has been submitted with commit 928e22dba193fc1b412974ccaad36f651d12863b by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43015 --- This review has been submitted with commit 10470bbdd1dd58f65379c62ab227474e584bdbef by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 113586: More general warning cleanups
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113586/ --- (Updated Nov. 4, 2013, 7:58 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Another bunch of fairly obvious warning fixes; this should be pretty much all the noise that can easily be dealt with. Everything else requires either more consideration or the enabling of KDE_NO_DEPRECATED. Speaking of which, several of the fixes get us closer to kf5 actually compiling with that defined. Remove call to KUrlRequester::fileDialog() from test This is (a) unnecessary and (b) deprecated. KIO::RenameDialog: use KIO::suggestName instead of local method Also, wrap the local implementation of suggestName in KDE_NO_DEPRECATED, like its declaration. Remove use of deprecated form of KRecentDocument::add KCategoryDrawerV3 - KCategoryDrawer in KPluginSelector Mark KPluginInfo::fromServices as deprecated It is simply the multiple-at-once version of the deprecated KPluginInfo constructor that takes a KService. Mark unused (except for debugging) args with Q_UNUSED Wrap test of deprecated method in KDE_NO_DEPRECATED The test will not compile with KDE_NO_DEPRECATED set... Do not compile KComboBox::setUrlDropsEnabled if KDE_NO_DEPRECATED is set It calls a deprecated method, and its declaration is wrapped in KDE_NO_DEPRECATED as well. KAuth: handle QtTraceMsg messages We just treat them like debug messages. Fix warnings in Solid UDisks2 backend Make it explicit that UDisks2 does not support Keyboard or PointingDevice. Also make the switch statement easier to read. Wrap assertion function in #ifndef QT_NO_DEBUG This function is only used in a Q_ASSERT, so prevent it from being compiled if assertions are disabled. Diffs - staging/kio/src/filewidgets/kencodingfiledialog.cpp c6c159fb016b8b8b1a7caa20d814f62e1989bb57 staging/kio/src/filewidgets/kfilewidget.cpp 48215315ea1a4c335992185735b8a717b8d5add6 staging/kio/src/widgets/renamedialog.cpp 0830c90a199a780e79966d3220e595866c8f7b96 staging/kio/tests/kurlrequestertest_gui.cpp 948085f090e3c388246ae7b11ae348a089a5893c tier1/itemmodels/src/kselectionproxymodel.cpp df83ae6c51edcdf01d1d16b351a63507d6a5a982 tier1/solid/src/solid/backends/udisks2/udisksdeviceinterface.h 43a1b6f896834e9fe9e94e9580ff5845036aa754 tier2/kauth/src/backends/dbus/DBusHelperProxy.cpp ee44d930eddd647e8ad5d1cf20097a1b8a719efa tier2/kauth/src/kauthhelpersupport.cpp 8eaa97dead64e745ab9e4e674ffa02f3d4b72bdb tier2/kcompletion/src/kcombobox.cpp 4043ea5448a67c01751cc849d56c3fdd4d61035c tier2/kcompletion/tests/klineedittest.cpp 233bdd3afd8b489e9f32f81ac89b57114948c034 tier3/kservice/src/kbuildsycoca/kmimeassociations.cpp dfd2a6d83c637215219c7fd928dcd4fb37097ddf tier3/kservice/src/services/kplugininfo.h 2555ef27d1ccc2fa58a905175bdcefab4e6491ea tier3/kservice/src/services/kplugininfo.cpp e19ae7e3fcadfbcadfcecea3795a0d9afad09753 tier3/xmlgui/src/kxmlguifactory.cpp d2980f45fe8e32f1b4aa535661eb002c69969698 tier4/kcmutils/src/kpluginselector.cpp 768dbf33b136b79f3cab4c6f09e84d2a4378a022 tier4/kcmutils/src/kpluginselector_p.h de42f03a99ba35e4c43927a7e2c07fc3a541de5a Diff: http://git.reviewboard.kde.org/r/113586/diff/ Testing --- Builds; tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43013 --- This review has been submitted with commit 3fc2059cfc863b5b99c63105e4761d9daa78c3a9 by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 4, 2013, 7:59 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp tier1/kguiaddons/src/plugins/png.desktop tier1/kguiaddons/src/plugins/pnm.desktop tier1/kguiaddons/src/plugins/ppm.desktop tier1/kguiaddons/src/plugins/psd.cpp tier1/kguiaddons/src/plugins/psd.desktop tier1/kguiaddons/src/plugins/psd.h tier1/kguiaddons/src/plugins/psd.json da33c688c0a2a75cdbe24637ca8fd4ae1ffe807f tier1/kguiaddons/src/plugins/qimageio_plugin.desktop tier1/kguiaddons/src/plugins/ras.cpp tier1/kguiaddons/src/plugins/ras.desktop
Re: Review Request 113536: General cleanups of kguiaddons/plugins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/#review43016 --- This review has been submitted with commit ba89f8a1dd8bf958c11f93d82190aae65b97600b by Alex Merry to branch frameworks. - Commit Hook On Nov. 2, 2013, 2:32 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113536/ --- (Updated Nov. 2, 2013, 2:32 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- A whole bunch of commits (listed below in reverse order, like git log). This is a preliminary to actually fixing up some of the plugins (like the EPS one). Also, I intend to run astyle on the directory, which is a horrible mess of different styles (even within the same file). But that's not included in this request, since it would make the diff fairly useless. Remove the unhelpful ChangeLog Improve README file Mostly remove the list of plugins, since that is the sort of information that will not be kept in sync. Remove uppercase keys from imageformat json files QImageReader/Writer lowercases image formats before searching for plugins, so uppercase keys are useless. Add desktop file for WBMP plugin This is provided by the qtimageformats module Do not install desktop files for imageformat plugins that are not built If missing libraries etc. mean we do not build a plugin, we should not install the desktop file for it. Add imageconverter app to test imageformat plugins It is a command-line utility that converts images from one format to another using QImageReader and QImageWriter. Move kguiaddons/src/plugins to kguiaddons/src/plugins/imageformats This allows the plugins to be used prior to installation (for example, by tests) by adding kguiaddons/src/plugins to Qt's search path. Diffs - tier1/kguiaddons/src/CMakeLists.txt e1b17f4fcbda1052e21303f61f313058a9190da5 tier1/kguiaddons/src/plugins/AUTHORS tier1/kguiaddons/src/plugins/CMakeLists.txt 0536abeddb40220626be2ca80bf68c4a5cf79351 tier1/kguiaddons/src/plugins/ChangeLog 3d9f6dc1463d628db8a9f8fadab18475cd15160e tier1/kguiaddons/src/plugins/Mainpage.dox tier1/kguiaddons/src/plugins/README 20f3ef0019b571947d390cecdadcdd4745e4fe28 tier1/kguiaddons/src/plugins/bmp.desktop tier1/kguiaddons/src/plugins/config-kimgio.h.cmake tier1/kguiaddons/src/plugins/dds.cpp tier1/kguiaddons/src/plugins/dds.desktop tier1/kguiaddons/src/plugins/dds.h tier1/kguiaddons/src/plugins/dds.json 38b3d9adb13ab959d53190b218f083ed02f7d0eb tier1/kguiaddons/src/plugins/eps.h tier1/kguiaddons/src/plugins/eps.cpp tier1/kguiaddons/src/plugins/eps.desktop tier1/kguiaddons/src/plugins/eps.json 225c2895efecec14f09e1d5bd1f115aaee6eb0a0 tier1/kguiaddons/src/plugins/exr.cpp tier1/kguiaddons/src/plugins/exr.desktop tier1/kguiaddons/src/plugins/exr.h tier1/kguiaddons/src/plugins/exr.json 26fb4978de5d69ea4a8c10939f1b7ac026a63d0f tier1/kguiaddons/src/plugins/g3r.h tier1/kguiaddons/src/plugins/g3r.cpp tier1/kguiaddons/src/plugins/gif.desktop tier1/kguiaddons/src/plugins/gimp.h tier1/kguiaddons/src/plugins/hdr.cpp tier1/kguiaddons/src/plugins/hdr.desktop tier1/kguiaddons/src/plugins/hdr.h tier1/kguiaddons/src/plugins/ico.desktop tier1/kguiaddons/src/plugins/imageformats/README PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/eps.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/rgb.json PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/wbmp.desktop PRE-CREATION tier1/kguiaddons/src/plugins/imageformats/xview.json PRE-CREATION tier1/kguiaddons/src/plugins/jp2.h tier1/kguiaddons/src/plugins/jp2.cpp tier1/kguiaddons/src/plugins/jp2.desktop tier1/kguiaddons/src/plugins/jp2.json 5a92b36c58e3852f71493b6fe5db8b271b9f8513 tier1/kguiaddons/src/plugins/jpeg.desktop tier1/kguiaddons/src/plugins/mng.desktop tier1/kguiaddons/src/plugins/pbm.desktop tier1/kguiaddons/src/plugins/pcx.h tier1/kguiaddons/src/plugins/pcx.cpp tier1/kguiaddons/src/plugins/pcx.desktop tier1/kguiaddons/src/plugins/pcx.json b3a7fc97fcb43eda91e90278af71b71b5f1066a6 tier1/kguiaddons/src/plugins/pgm.desktop tier1/kguiaddons/src/plugins/pic.cpp tier1/kguiaddons/src/plugins/pic.desktop tier1/kguiaddons/src/plugins/pic.h tier1/kguiaddons/src/plugins/pic.json 68f6f37ad08f3a0b3199240f5a135806a2b8ef46 tier1/kguiaddons/src/plugins/pic_read.cpp tier1/kguiaddons/src/plugins/pic_rw.h tier1/kguiaddons/src/plugins/pic_write.cpp
Re: Review Request 112755: Reimplement KXUtils::createPixmapFromHandle with XCB
On Oct. 29, 2013, 2:42 a.m., Fredrik Höglund wrote: Looks much better, but it doesn't handle depth 30 pixmaps. Martin Gräßlin wrote: I'm lacking ideas on how to test this. Do you know any application which uses 30 bit pixmaps? The default depth is 30 when you're using the NVIDIA driver and the monitor supports 30 bits. This is the reason why it's important. The X server can be told to use a 30 bit visual even when the monitor only supports 24 bits by starting it with -depth 30. But this isn't supported by all drivers. Note that the raster graphics system is completely broken when the default depth is 30 since Qt assumes that any depth = 24 means 8 bits per channel. - Fredrik --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/#review42568 --- On Nov. 4, 2013, 8:14 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112755/ --- (Updated Nov. 4, 2013, 8:14 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Implements the createPixmapFromHandle by getting the image for the pixmaps and using it as either the Pixmap or the bitmap mask. Diffs - tier1/kwindowsystem/src/kxutils.cpp 33bd678 tier1/kwindowsystem/src/kxutils_p.h 84d639b tier1/kwindowsystem/tests/CMakeLists.txt 0060903 tier1/kwindowsystem/tests/createpixmapfromhandletest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112755/diff/ Testing --- Adjusted KWin to take this codepath and say thanks to Iceweasel for having a mask Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113631: Allow compiling kwindowsystem on Windows
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113631/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Allow compiling kwindowsystem on Windows Diffs - tier1/CMakeLists.txt 277b3f0 tier1/kwindowsystem/CMakeLists.txt dc8fcae tier1/kwindowsystem/src/CMakeLists.txt d9d141e tier1/kwindowsystem/src/kkeyserver_win.h 6328f41 tier1/kwindowsystem/src/kstartupinfo.h 39c2935 tier1/kwindowsystem/src/kstartupinfo.cpp 402cc97 tier1/kwindowsystem/src/kwindowinfo_win.cpp d392fe9 tier1/kwindowsystem/src/kwindowsystem.h 0c6a930 tier1/kwindowsystem/src/kwindowsystem_win.cpp 23a6616 Diff: http://git.reviewboard.kde.org/r/113631/diff/ Testing --- Compiles (Windows 7, VS 2012 x64) Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113527: Move KPassivePopup to KNotifications and fix placement
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113527/ --- (Updated Nov. 4, 2013, 10:17 p.m.) Review request for KDE Frameworks. Changes --- Use KF5:: prefix in kde4support/tests/CMakeLists.txt Repository: kdelibs Description --- Alternative to RR 113393. Commit 1: Move KPassivePopup to KNotifications As well as being a conceptual fit, KPassivePopup needs to do X11 magic, and this is a lot easier if it can make use of the KWindowSystem library. Commit 2: Fix KPassivePopup placement The non-X11 code is largely untested. Diffs (updated) - tier1/kwidgetsaddons/CMakeLists.txt 01bae90e235fae424f3af48fb95dc24286e60562 tier1/kwidgetsaddons/src/CMakeLists.txt beb5ecad9e063936dea9ca38f42238988ca3f51b tier1/kwidgetsaddons/src/kpassivepopup.h d7cef3dd94713554010547001de6b4d81e3e2961 tier1/kwidgetsaddons/src/kpassivepopup.cpp 663f63af413b7660c9c1b21af3e3ae4d7c424bbe tier1/kwidgetsaddons/tests/CMakeLists.txt d0140ea2489a629949b7022f310dcd6349c06f20 tier1/kwidgetsaddons/tests/kpassivepopuptest.h tier1/kwidgetsaddons/tests/kpassivepopuptest.cpp 4e7138523bdbe4166bf0e899d39d9ae1f8b8b447 tier2/knotifications/src/CMakeLists.txt 7f5a332d6650f998d72c97b7cfddd27362756b08 tier2/knotifications/tests/CMakeLists.txt 6f3be50819ffef19644b77c397e5b4966d61abd6 tier4/kde4support/tests/CMakeLists.txt b22e2e818fc13519318fa32de44f5d4a32301661 Diff: http://git.reviewboard.kde.org/r/113527/diff/ Testing --- Test app (in tests/ folder) works as expected on X11: if _NET_WM_ICON_GEOMETRY is set and a window id is passed, the popup is placed by the taskbar entry; if it is not set, it is place by the window; if a window id is not passed, it is placed top left (avoiding any panels) on the desktop. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
