Re: Review Request 115285: Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115285/#review48355
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 24, 2014, 9:36 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115285/
> ---
> 
> (Updated Jan. 24, 2014, 9:36 a.m.)
> 
> 
> Review request for KDE Frameworks and Hugo Pereira Da Costa.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Pass the KDE_COLOR_SCHEME_PATH application property to toplevel windows
> 
> This feature is upstreamed from the Oxygen style. It is a general
> feature for integration with our window manager and thus should be in
> the generic style implementation and not just in Oxygen.
> 
> So far the implementation only supports X11 and installs an X property
> on all toplevel windows. On other platforms it is currently a no-op.
> 
> This introduces an optional dependency on XCB and QtX11Extras. If they
> are not found the feature is obviously not compiled.
> 
> 
> Diffs
> -
> 
>   src/kstyle/CMakeLists.txt 41c92c266a92e4e3534114c982ed98cf529456d5 
>   src/kstyle/kstyle.cpp f79675b85a58d0f132bc3d336996d51a2661e567 
> 
> Diff: https://git.reviewboard.kde.org/r/115285/diff/
> 
> 
> Testing
> ---
> 
> Tested with the kcolorschemedemo in kconfigwidgets/tests and an adjusted 
> Oxygen without the feature.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115255: Add x11 platform detection to kkeyserver_x11

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115255/#review48354
---



src/kkeyserver_x11.cpp


Warning? And/or assert?


- Kevin Ottens


On Jan. 23, 2014, 11:30 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115255/
> ---
> 
> (Updated Jan. 23, 2014, 11:30 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add x11 platform detection to kkeyserver_x11
> 
> Just because it's only compiled for X11 doesn't mean it's running on
> X11. So before we go into code paths which call into X11 we should
> verify. That's better than:
> "QX11Info::display() returns 0.  I'm probably going to crash now."
> 
> Not adjusted are obvious X11 methods which take an XLib or xcb data
> type. If one calls those from non-x11 unconditionally it's an
> application bug and the application deserves to crash :-P
> 
> 
> Diffs
> -
> 
>   src/kkeyserver_x11.cpp fd0ca5b25f09808e211198ce0f7aa56aa21e05f4 
> 
> Diff: https://git.reviewboard.kde.org/r/115255/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115248: Add runtime detection to KXMessages

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115248/#review48353
---



src/kxmessages.cpp


Warning?



src/kxmessages.cpp


Warning for the !d->valid case?


- Kevin Ottens


On Jan. 23, 2014, 9:03 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115248/
> ---
> 
> (Updated Jan. 23, 2014, 9:03 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add runtime detection to KXMessages
> 
> KXMessages should only be used if we are on platformX11. A compile time
> check is not enough.
> 
> 
> Diffs
> -
> 
>   src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 
> 
> Diff: https://git.reviewboard.kde.org/r/115248/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115230: Add platform check to KSelectionOwner and KSelectionWatcher

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115230/#review48352
---



src/kselectionowner.h


No chance to issue a warning at runtime when hitting that case?


- Kevin Ottens


On Jan. 22, 2014, 3:18 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115230/
> ---
> 
> (Updated Jan. 22, 2014, 3:18 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add platform check to KSelectionOwner and KSelectionWatcher
> 
> These are highly X11 specific classes and don't make any sense on a
> platform other than xcb and were potentially crashy by using QX11Info
> without verifying that the platform is used.
> 
> The implementation will now only create the d-ptr in case that the
> code is running on the xcb platform and ensures that no call to xcb
> is done unconditionally. All methods perform an early return in case
> the d-ptr is null. Non-void methods return a sensible default value
> in this case.
> 
> 
> Diffs
> -
> 
>   src/kselectionowner.h 512bd5ebc6336c3a07d78dd964599d3f48d8eb33 
>   src/kselectionowner.cpp 3715267e280822ba541196d9c63fd28f58cdc7ee 
>   src/kselectionwatcher.h 798fe70bfc8175764f3fc3d09de97d971d5e57ad 
>   src/kselectionwatcher.cpp 87e0a9612f2bc6ced3de7c31797411b1eb183d41 
> 
> Diff: https://git.reviewboard.kde.org/r/115230/diff/
> 
> 
> Testing
> ---
> 
> unit test is not failing. No test on non-X11, though.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115203: Allow compiling with MSVC

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115203/#review48351
---


Looks good to me, opinion of someone from kdewin would be welcome though.

- Kevin Ottens


On Jan. 22, 2014, 3:13 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115203/
> ---
> 
> (Updated Jan. 22, 2014, 3:13 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcrash
> 
> 
> Description
> ---
> 
> Allow compiling with MSVC
> 
> 
> Diffs
> -
> 
>   src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 
>   src/kcrash.cpp 13b64adff7bce5782b054bf43ef9e357e9aa1622 
> 
> Diff: https://git.reviewboard.kde.org/r/115203/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115209: Fix KDoctools build on Windows

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115209/#review48350
---


Looks good to me, would be nice to have the opinion of someone from kdewin 
though.

- Kevin Ottens


On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115209/
> ---
> 
> (Updated Jan. 22, 2014, 3:12 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Two separate commits: 
> 
> ---
> 
> Print a message when a file is not found
> 
> This way meinproc no longer fails silently
> 
> --
> 
> Allow compiling on Windows with MSVC
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 56877a3f39b39a6d919c6b18a9c4ab1c0b5a9106 
>   src/CMakeLists.txt 752604190a4b527d757d4b819dc6d85085a96e4b 
>   src/meinproc.cpp f34084581205ad4f63a84823cd1a582b2f37ed69 
>   src/meinproc_common.cpp 16234f70e45a703859fce42dcdb2ac1c2fdadade 
>   src/xslt.cpp 79578ed8fb6cc3faccf63b8d86e29db9948b33e7 
> 
> Diff: https://git.reviewboard.kde.org/r/115209/diff/
> 
> 
> Testing
> ---
> 
> Works on windows once https://git.reviewboard.kde.org/r/115210/ is also 
> applied
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

[Martin Gräßlin]

> On Jan. 27, 2014, 8:36 a.m., Kevin Ottens wrote:
> > Why not... makes me want to ask the same for the other HAVE_FOO we have in 
> > the other frameworks. You might have opened the pandora box. :-)

yes the same reasoning applies to all frameworks. Though one could also say 
that using a HAVE_FOO in a public header is clearly wrong and the API needs 
fixing ;-) (That's certainly the case in KWindowSystem)

This change could break downstream usages as we often got the HAVE_X11 through 
kwindowsystem. So if we have something like:

#include 

#if HAVE_X11
KWindowsystem::foo();
#endif

it would break. It's obviously wrong, but some usages of Q_WS_X11 got fast 
ported to HAVE_X11 and it continued to compile thanks to the kwindowsystem 
include. (In such a pattern also having the ifdef at all is wrong, but also 
this is quite common that KWindowsystem is incorrectly wrapped around ifdef)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48343
---


On Jan. 26, 2014, 6:36 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115148/
> ---
> 
> (Updated Jan. 26, 2014, 6:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines
> 
> config-kwindowsystem.h is installed and included by public headers, so
> it should not define things as generic as "HAVE_X11", which are likely
> to also be defined by users of the framework.
> 
> 
> Diffs
> -
> 
>   src/netwm.cpp 266afccaf111e6707493b18dad1d9c03dde1d912 
>   src/netwm.h aee6cea5e3b65cf6252b50515e4920cb9c96f240 
>   src/kxerrorhandler.cpp 612e62a345ec9c8503bab9fb12afa08426974828 
>   src/kxerrorhandler_p.h ad670fec6ff35e1c9df81b91517c02e6e0893ad1 
>   src/kxmessages.h 5d57e06d702afb5ceaed05de97ca40116b7f3aa3 
>   src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 
>   src/kxutils.cpp e47ba68c08a14597e49fd33901b0a7c079924112 
>   src/kxutils_p.h 1e229801aac929bc596685dbfa5260d55d0f5298 
>   src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b 
>   src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
>   src/kkeyserver.h 8869fe7331e98846183ab37814b1d95e75ab9647 
>   src/config-kwindowsystem.h.cmake 58949d87f4254531ba57de86b6303cba05053222 
>   src/CMakeLists.txt b453af11a46615ecd94911f0d2f86922087bde0e 
>   CMakeLists.txt 2479237e574e86c9094b557dfa146c85b7b19b65 
>   src/kwindoweffects.cpp 91ef52f149a781df9308bb1587629dbaaf571b8e 
>   src/kwindoweffects_p.h 266b5f3e7f24bdca6ce467138ee067335225da78 
>   src/kwindowsystem.h 5bcfd062dcca42d282b70d0683d4ee1da88cc814 
>   src/kwindowsystem_x11.cpp 8634240cabc708a608277b34f21c41cee295e48a 
> 
> Diff: https://git.reviewboard.kde.org/r/115148/diff/
> 
> 
> Testing
> ---
> 
> Clean configure-build-test-install on a system with X11.  KWindowSystem 
> already failed to build on a non-windows, non-mac system when X11 is not 
> found (one of the tests fails to link if you comment out the 
> find_package(X11) calls, as KWindowSystem::activeWindow() is never defined).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115190: Add unit test for KWindowInfo on X11

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115190/#review48348
---


Looks good to me, can likely go in once it's running on build.kde.org

- Kevin Ottens


On Jan. 22, 2014, 9:20 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115190/
> ---
> 
> (Updated Jan. 22, 2014, 9:20 a.m.)
> 
> 
> Review request for KDE Frameworks and Ben Cooksley.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add unit test for KWindowInfo on X11
> 
> Unit test for most methods provided by KWindowInfo. The general pattern
> is to create a window, show it, test the property, change it and
> verify that the change worked. This is a little bit tricky as the test
> needs to interact with large parts of the window manager. In case a
> property is updated by the window manager we need to send the client
> message, wait till the window manager has reacted on it and updated
> the property and then wait for the property update. This is mostly done
> by waiting for the signal KWindowSystem::windowChanged. Unfortunately
> that reports globally and not just for the window we are interested in.
> So we have to filter out till we got the correct one. If there is at
> the same time further interaction with the windowing system tests can
> fail, but a re-run normally fixes it.
> 
> The unit test is so far written against KWin. It's possible that it
> needs adjustments for succeeding on build.kde.org. Given that
> KWindowInfo::actionSupported is not tested as that is clearly to
> specific to the used window manager.
> 
> ---
> 
> @Ben: is it possible that you try the patch on build.kde.org while it's under 
> review, so that I can fix any possible failures.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 58803aec9c807f68ff2bac227d0d9cf0305fa1f6 
>   autotests/kwindowinfox11test.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115190/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review48347
---



src/lib/kaboutdata.cpp


Not really my type of thing. It's acting on an object behind our back 
without knowing... what happens to code where setApplication* was called 
before? Information would be lost and it's not obvious to the user. Looks 
dangerous to me.

If we want to factorize the qApp call, and I see the need for that indeed, 
then that block should be provided by a separate method 
(setupApplication(QCoreApplication *)?).


- Kevin Ottens


On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> ---
> 
> (Updated Jan. 21, 2014, 11:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Let the KAboutData set information to QApplication. This way we don't have to 
> duplicate information by passing it to the KAboutData _and_ the QApplication.
> 
> 
> Diffs
> -
> 
>   src/lib/kaboutdata.h c9e 
>   src/lib/kaboutdata.cpp f24006b 
> 
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114989: kapidox and other components from frameworks should use kde5-config instead of kde4-config, remove kde4 references

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114989/#review48344
---



src/doxygen-preprocess-kcfg.sh


Should indeed just say kconfig_compiler.


- Kevin Ottens


On Jan. 12, 2014, 8:08 p.m., Siddharth Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114989/
> ---
> 
> (Updated Jan. 12, 2014, 8:08 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> kapidox and other components from frameworks should use kde5-config instead 
> of kde4-config, remove kde4 references
> 
> 
> Diffs
> -
> 
>   src/doxygen-preprocess-kcfg.sh 567a248 
> 
> Diff: https://git.reviewboard.kde.org/r/114989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Siddharth Sharma
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48343
---

Ship it!


Why not... makes me want to ask the same for the other HAVE_FOO we have in the 
other frameworks. You might have opened the pandora box. :-)

- Kevin Ottens


On Jan. 26, 2014, 5:36 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115148/
> ---
> 
> (Updated Jan. 26, 2014, 5:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines
> 
> config-kwindowsystem.h is installed and included by public headers, so
> it should not define things as generic as "HAVE_X11", which are likely
> to also be defined by users of the framework.
> 
> 
> Diffs
> -
> 
>   src/netwm.cpp 266afccaf111e6707493b18dad1d9c03dde1d912 
>   src/netwm.h aee6cea5e3b65cf6252b50515e4920cb9c96f240 
>   src/kxerrorhandler.cpp 612e62a345ec9c8503bab9fb12afa08426974828 
>   src/kxerrorhandler_p.h ad670fec6ff35e1c9df81b91517c02e6e0893ad1 
>   src/kxmessages.h 5d57e06d702afb5ceaed05de97ca40116b7f3aa3 
>   src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 
>   src/kxutils.cpp e47ba68c08a14597e49fd33901b0a7c079924112 
>   src/kxutils_p.h 1e229801aac929bc596685dbfa5260d55d0f5298 
>   src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b 
>   src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
>   src/kkeyserver.h 8869fe7331e98846183ab37814b1d95e75ab9647 
>   src/config-kwindowsystem.h.cmake 58949d87f4254531ba57de86b6303cba05053222 
>   src/CMakeLists.txt b453af11a46615ecd94911f0d2f86922087bde0e 
>   CMakeLists.txt 2479237e574e86c9094b557dfa146c85b7b19b65 
>   src/kwindoweffects.cpp 91ef52f149a781df9308bb1587629dbaaf571b8e 
>   src/kwindoweffects_p.h 266b5f3e7f24bdca6ce467138ee067335225da78 
>   src/kwindowsystem.h 5bcfd062dcca42d282b70d0683d4ee1da88cc814 
>   src/kwindowsystem_x11.cpp 8634240cabc708a608277b34f21c41cee295e48a 
> 
> Diff: https://git.reviewboard.kde.org/r/115148/diff/
> 
> 
> Testing
> ---
> 
> Clean configure-build-test-install on a system with X11.  KWindowSystem 
> already failed to build on a non-windows, non-mac system when X11 is not 
> found (one of the tests fails to link if you comment out the 
> find_package(X11) calls, as KWindowSystem::activeWindow() is never defined).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114997: Improve KAuth README.md

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114997/#review48342
---



README.md


Agreed, this part needs to be less ambiguous. Looks fine otherwise.


- Kevin Ottens


On Jan. 26, 2014, 5:39 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114997/
> ---
> 
> (Updated Jan. 26, 2014, 5:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Dario Freddi.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Improve KAuth README.md
> 
> 
> Diffs
> -
> 
>   README.md a8a011a147d2dcc0fb5db39e263412005a86def4 
> 
> Diff: https://git.reviewboard.kde.org/r/114997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Allow the building of deprecated code to be disabled

[Kevin Ottens]

> On Jan. 27, 2014, 2:14 a.m., Aleix Pol Gonzalez wrote:
> > Shouldn't we maybe just remove these? Especially considerign they already 
> > are deprecated in kdelibs 4.
> > 
> > I don't really like disabling compilation of deprecated symbols, especially 
> > in this case we're not winning that much.

The better approach would be to make it inline so that it's not in the cpp file 
at all:

#ifndef KDE_NO_DEPRECATED
QString fullName() const { return property(KUser::FullName); }
#endif


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review48324
---


On Jan. 15, 2014, 1:56 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Jan. 15, 2014, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This is mostly an example of how we could improve the deprecation handling.  
> There are two parts: preventing deprecation warnings when building the 
> library itself (see 
> http://build.kde.org/view/Frameworks/job/kwidgetsaddons_master_qt5/11/warnings17Result/NORMAL/package.-1402078525/
>  for examples) and allowing the framework to be built with no deprecated code.
> 
> We possibly want to export the fact that the framework was built without 
> deprecated code via the CMake config file, so that downstream stuff (like 
> kde4support) can check for it and complain if necessary.
> 
> 
> Allow the building of deprecated code to be disabled
> 
> This adds a CMake option to enable or disable the building of deprected
> code.  It just changes the kcoreaddons_export.h file.
> 
> Part of this change is to use KCOREADDONS_NO_DEPRECATED instead of
> KDE_NO_DEPRECATED.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt 8cc71f34e671962f2d7268b3db0d50e6750c26a2 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115251: Add better runtime detection for X11 usage in KStartupInfo

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115251/
---

(Updated Jan. 27, 2014, 8:31 a.m.)


Review request for KDE Frameworks.


Changes
---

improved as suggested


Repository: kwindowsystem


Description
---

Add better runtime detection for X11 usage in KStartupInfo

Compile time checks for X11 is no longer sufficient. This adds a
runtime check to all the code paths which look dangerous if executed
on a non-X11 platform.


Diffs (updated)
-

  src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 

Diff: https://git.reviewboard.kde.org/r/115251/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115123/#review48339
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 19, 2014, 3:49 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115123/
> ---
> 
> (Updated Jan. 19, 2014, 3:49 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> Add an imported target to FindOpenEXR.cmake
> 
> This simplifies using the find module.
> 
> 
> Diffs
> -
> 
>   cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e 
>   src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115123/diff/
> 
> 
> Testing
> ---
> 
> Builds (tested when OpenEXR is found).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115268: Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115268/#review48338
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 23, 2014, 6:18 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115268/
> ---
> 
> (Updated Jan. 23, 2014, 6:18 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Replace the KDE_ENABLE_EXCEPTIONS variable with a pair of functions
> 
> kde_enable_exceptions() essentially does what
> set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}  ${KDE_ENABLE_EXCEPTIONS}")
> used to do.  kde_target_enable_exceptions does it on a per-target basis.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDECompilerSettings.cmake 
> 7891136124ced0273ff05bbe521d93acc22a00f7 
> 
> Diff: https://git.reviewboard.kde.org/r/115268/diff/
> 
> 
> Testing
> ---
> 
> Both macros tested with ThreadWeaver (compilation and tests).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115295: Do not set CMAKE_REQUIRED_DEFINES

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115295/#review48336
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 24, 2014, 2:45 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115295/
> ---
> 
> (Updated Jan. 24, 2014, 2:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kjs
> 
> 
> Description
> ---
> 
> Do not set CMAKE_REQUIRED_DEFINES
> 
> The variable _KDE4_PLATFORM_DEFINITIONS is no longer set by
> KDEFrameworkCompilerSettings.cmake / KDECompilerSettings.cmake, but
> CMAKE_REQUIRED_DEFINES is set properly by it.
> 
> 
> Diffs
> -
> 
>   src/kjs/ConfigureChecks.cmake 94de6e71f750bdd62b512c680e5d767c1f0e199b 
> 
> Diff: https://git.reviewboard.kde.org/r/115295/diff/
> 
> 
> Testing
> ---
> 
> Compiles fine (although it did before).  Feature tests seem to be producing 
> sensible results.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115296: Do not set CMAKE_REQUIRED_DEFINES

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115296/#review48337
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 24, 2014, 2:45 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115296/
> ---
> 
> (Updated Jan. 24, 2014, 2:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kde4support
> 
> 
> Description
> ---
> 
> Do not set CMAKE_REQUIRED_DEFINES
> 
> The variable _KDE4_PLATFORM_DEFINITIONS is no longer set by
> KDEFrameworkCompilerSettings.cmake / KDECompilerSettings.cmake, but
> CMAKE_REQUIRED_DEFINES is set properly by it.
> 
> 
> Diffs
> -
> 
>   src/ConfigureChecks.cmake 7c8951f685f57f771b1cee5758dab0e87e614bf7 
> 
> Diff: https://git.reviewboard.kde.org/r/115296/diff/
> 
> 
> Testing
> ---
> 
> Compiles fine, while it didn't before.  Feature tests seem to be producing 
> sensible results.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115249: Add runtime detection to KUserTimestamp

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115249/
---

(Updated Jan. 27, 2014, 7:25 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Add runtime detection to KUserTimestamp

KUserTimestamp methods should only be used if we are on platformX11.
A compile time check is not enough.


Diffs
-

  src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b 

Diff: https://git.reviewboard.kde.org/r/115249/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115294: Add system API feature macros to CMAKE_REQUIRED_DEFINES

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115294/#review48334
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 24, 2014, 2:45 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115294/
> ---
> 
> (Updated Jan. 24, 2014, 2:45 p.m.)
> 
> 
> Review request for Build System, Extra Cmake Modules and KDE Frameworks.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Add system API feature macros to CMAKE_REQUIRED_DEFINES
> 
> Various defines we set affect the API offered by the system; subsequent
> CMake configure checks should happen in a matching environment.
> 
> 
> See also: https://git.reviewboard.kde.org/r/115295/ and 
> https://git.reviewboard.kde.org/r/115296/
> 
> 
> Diffs
> -
> 
>   kde-modules/KDECompilerSettings.cmake 
> 7891136124ced0273ff05bbe521d93acc22a00f7 
> 
> Diff: https://git.reviewboard.kde.org/r/115294/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115249: Add runtime detection to KUserTimestamp

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115249/#review48335
---


This review has been submitted with commit 
f14651c0ae62a90c8bda748242b38721654014c7 by Martin Gräßlin to branch master.

- Commit Hook


On Jan. 23, 2014, 9:05 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115249/
> ---
> 
> (Updated Jan. 23, 2014, 9:05 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add runtime detection to KUserTimestamp
> 
> KUserTimestamp methods should only be used if we are on platformX11.
> A compile time check is not enough.
> 
> 
> Diffs
> -
> 
>   src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b 
> 
> Diff: https://git.reviewboard.kde.org/r/115249/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115266: Split up Mainpage.dox

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115266/#review48333
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 23, 2014, 4:43 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115266/
> ---
> 
> (Updated Jan. 23, 2014, 4:43 p.m.)
> 
> 
> Review request for KDE Frameworks, Àlex Fiestas and Kevin Ottens.
> 
> 
> Repository: solid
> 
> 
> Description
> ---
> 
> I'm not sure what should happen to the song, really.
> 
> 
> Split up Mainpage.dox
> 
> The examples do not appear to exist any more; README.md gets some usage
> info and link to the song, which goes in docs/song.md.
> 
> Unfortunately, the song still needs  tags due to a lack of markdown
> line-break support in doxygen
> (https://bugzilla.gnome.org/show_bug.cgi?id=679710).
> 
> 
> Diffs
> -
> 
>   Mainpage.dox 79993535605efff7b1807f11f36b830bf566 
>   README.md 215b7dda8fa0c4aa68e29ee633c6ab5a6465de94 
>   docs/song.md PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115266/diff/
> 
> 
> Testing
> ---
> 
> Generated dox.  Home page and song page look right.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115264: Split up Mainpage.dox

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115264/#review48332
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 23, 2014, 4:15 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115264/
> ---
> 
> (Updated Jan. 23, 2014, 4:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Mirko Boehm.
> 
> 
> Repository: threadweaver
> 
> 
> Description
> ---
> 
> Split up Mainpage.dox
> 
> Front page content and usage in README.md, other pages in separate files
> in docs/.
> 
> 
> Diffs
> -
> 
>   Mainpage.dox ed4e7b9bf1669c73d676a8895deb15cbca61e95f 
>   README.md 204436362878ed0d62f56866555a6649343a39c1 
>   docs/use-cases.md PRE-CREATION 
>   docs/whymultithreading.md PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115264/diff/
> 
> 
> Testing
> ---
> 
> Generated apidocs; other pages ("use cases" and "why multithreading") are 
> still accessible from main page.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115120: Clean up the CMake files (and a couple of other bits)

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115120/#review48331
---

Ship it!


Ship It!

- Kevin Ottens


On Jan. 19, 2014, 12:23 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115120/
> ---
> 
> (Updated Jan. 19, 2014, 12:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> Clean up the CMake files (and a couple of other bits)
> 
> src/imageformats/CMakeLists.txt is now much clearer and more consistent.
> 
> Also, removed an unnecessary/unimplemented method from exr.cpp.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt c39d6f322d335fa5d19e934d0f7c5c602ba1a502 
>   cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e 
>   src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 
>   src/imageformats/config-kimgio.h.cmake  
>   src/imageformats/exr.h 3ae9e16e3d6e74240e14ce8994a1d9126c4bdd36 
>   src/imageformats/exr.cpp f8c70b7547781614b05936f893a526d12b4a41b1 
>   src/imageformats/jp2.cpp 5be5063d034b048aa47c5491796a89bc4519d3e4 
> 
> Diff: https://git.reviewboard.kde.org/r/115120/diff/
> 
> 
> Testing
> ---
> 
> Compiles, installs.
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Schedule

[Kevin Ottens]

Hello,

On Monday 27 January 2014 00:28:25 Alex Merry wrote:
> Is there a schedule anywhere?  I think I wasn't the only one taken by
> surprise by Kévin's announcement about the alpha last week.

It was in my email about governance.
 
> http://community.kde.org/Frameworks should either host the schedule or
> contain a link to it.

Agreed, should get more exposure, added on top of the 5.0 epics:
http://community.kde.org/Frameworks/Epics

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KF5 Update Meeting 2014-w5 Reminder

[Kevin Ottens]

Hello all,

Just a quick reminder:
The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris 
time.

See you there!

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115316: Add demo for KRecentFileList

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115316/#review48327
---


It's a test, not a demo. If you want, it's for demonstrating the developer that 
he did it right, but I wouldn't see it as documentation.

I would rename it to KRecentFilesActionTest

- Aleix Pol Gonzalez


On Jan. 25, 2014, 10:56 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115316/
> ---
> 
> (Updated Jan. 25, 2014, 10:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> This is a demo test for KRecentFileList (in combination with KSharedConfig).
> 
> The patch also contains a documentation update for 
> krecentfilesaction.h/loadEntries() saying that "Local file entries that do 
> not exist anymore are not restored.".
> 
> As a side note: Does it makes sense to optionally disable the automated 
> removal of non-existing recent files? Or have the possibility to return the 
> files that were automatically removed?
> 
> 
> Diffs
> -
> 
>   src/krecentfilesaction.h 38d1b5e3455d081304b064d13bccfc2164d12a14 
>   tests/CMakeLists.txt 617a55944b2c91c9b09125ad92d070d3cd9a6551 
>   tests/krecentfilesactiondemo.h PRE-CREATION 
>   tests/krecentfilesactiondemo.cpp PRE-CREATION 
>   tests/krecentfilesactiondemo.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/115316/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/#review48326
---

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Jan. 26, 2014, 5:36 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115148/
> ---
> 
> (Updated Jan. 26, 2014, 5:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines
> 
> config-kwindowsystem.h is installed and included by public headers, so
> it should not define things as generic as "HAVE_X11", which are likely
> to also be defined by users of the framework.
> 
> 
> Diffs
> -
> 
>   src/netwm.cpp 266afccaf111e6707493b18dad1d9c03dde1d912 
>   src/netwm.h aee6cea5e3b65cf6252b50515e4920cb9c96f240 
>   src/kxerrorhandler.cpp 612e62a345ec9c8503bab9fb12afa08426974828 
>   src/kxerrorhandler_p.h ad670fec6ff35e1c9df81b91517c02e6e0893ad1 
>   src/kxmessages.h 5d57e06d702afb5ceaed05de97ca40116b7f3aa3 
>   src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 
>   src/kxutils.cpp e47ba68c08a14597e49fd33901b0a7c079924112 
>   src/kxutils_p.h 1e229801aac929bc596685dbfa5260d55d0f5298 
>   src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b 
>   src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
>   src/kkeyserver.h 8869fe7331e98846183ab37814b1d95e75ab9647 
>   src/config-kwindowsystem.h.cmake 58949d87f4254531ba57de86b6303cba05053222 
>   src/CMakeLists.txt b453af11a46615ecd94911f0d2f86922087bde0e 
>   CMakeLists.txt 2479237e574e86c9094b557dfa146c85b7b19b65 
>   src/kwindoweffects.cpp 91ef52f149a781df9308bb1587629dbaaf571b8e 
>   src/kwindoweffects_p.h 266b5f3e7f24bdca6ce467138ee067335225da78 
>   src/kwindowsystem.h 5bcfd062dcca42d282b70d0683d4ee1da88cc814 
>   src/kwindowsystem_x11.cpp 8634240cabc708a608277b34f21c41cee295e48a 
> 
> Diff: https://git.reviewboard.kde.org/r/115148/diff/
> 
> 
> Testing
> ---
> 
> Clean configure-build-test-install on a system with X11.  KWindowSystem 
> already failed to build on a non-windows, non-mac system when X11 is not 
> found (one of the tests fails to link if you comment out the 
> find_package(X11) calls, as KWindowSystem::activeWindow() is never defined).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114997: Improve KAuth README.md

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114997/#review48325
---



README.md


Need to use? link against?

Also the "(or similar)" looks unsure. I would say:
If you are using cmake, you can find KAuth by using:
find_package(KF5Auth NO_MODULE)

or finding KF5 with the Auth component, from your CMake scripts.


- Aleix Pol Gonzalez


On Jan. 26, 2014, 5:39 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114997/
> ---
> 
> (Updated Jan. 26, 2014, 5:39 p.m.)
> 
> 
> Review request for KDE Frameworks and Dario Freddi.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> Improve KAuth README.md
> 
> 
> Diffs
> -
> 
>   README.md a8a011a147d2dcc0fb5db39e263412005a86def4 
> 
> Diff: https://git.reviewboard.kde.org/r/114997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Allow the building of deprecated code to be disabled

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review48324
---


Shouldn't we maybe just remove these? Especially considerign they already are 
deprecated in kdelibs 4.

I don't really like disabling compilation of deprecated symbols, especially in 
this case we're not winning that much.

- Aleix Pol Gonzalez


On Jan. 15, 2014, 1:56 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Jan. 15, 2014, 1:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This is mostly an example of how we could improve the deprecation handling.  
> There are two parts: preventing deprecation warnings when building the 
> library itself (see 
> http://build.kde.org/view/Frameworks/job/kwidgetsaddons_master_qt5/11/warnings17Result/NORMAL/package.-1402078525/
>  for examples) and allowing the framework to be built with no deprecated code.
> 
> We possibly want to export the fact that the framework was built without 
> deprecated code via the CMake config file, so that downstream stuff (like 
> kde4support) can check for it and complain if necessary.
> 
> 
> Allow the building of deprecated code to be disabled
> 
> This adds a CMake option to enable or disable the building of deprected
> code.  It just changes the kcoreaddons_export.h file.
> 
> Part of this change is to use KCOREADDONS_NO_DEPRECATED instead of
> KDE_NO_DEPRECATED.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt 8cc71f34e671962f2d7268b3db0d50e6750c26a2 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Schedule

[Aleix Pol]

On Mon, Jan 27, 2014 at 1:28 AM, Alex Merry  wrote:

> Speaking of alphas and releases...
>
> Is there a schedule anywhere?  I think I wasn't the only one taken by
> surprise by Kévin's announcement about the alpha last week.
>
> http://community.kde.org/Frameworks should either host the schedule or
> contain a link to it.
>
> Alex
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>

+1, it can be useful to prepare the KF5 presentation for FOSDEM.

So far, my plan was to say that we're planning to release by June and an
alpha ASAP.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Schedule

[Alex Merry]

Speaking of alphas and releases...

Is there a schedule anywhere?  I think I wasn't the only one taken by
surprise by Kévin's announcement about the alpha last week.

http://community.kde.org/Frameworks should either host the schedule or
contain a link to it.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KDECompilerSettings

[Alex Merry]

A quick warning: since the alpha is looming close, and we want these
changes to have the maximum testing possible, I'm going to commit the
various changes to KDECompilerSettings that I have queued up tomorrow.

This includes the changes currently on reviewboard, as well as a broad
reorganisation of the file.  There are then a few more changes that can
be made (which will be marked with TODOs or FIXMEs in the file), but I'd
like some compile-everything tests first.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

[David Gil Oliva]

> On Jan. 21, 2014, 11:43 p.m., Alex Merry wrote:
> > src/kcompletion.h, line 501
> > 
> >
> > One sentence: "This signal is emitted by makeCompletion() when a match 
> > is found.
> 
> David Gil Oliva wrote:
> Since more methods emit this signal, I have rephrased it further. 
> makeCompletion() doesn't emit empty strings, but previousMatch() and 
> nextMatch() do emit empty strings when there is no match. In the next days I 
> will update the patch.
> 
>  /**
>  * This signal is emitted by makeCompletion() when a match is found.
>  * @param item the match. In previousMatch() and nextMatch() it can
>  * be a QString() if none is found.
>  */
> 
> Alex Merry wrote:
> How about
>  /**
>  * This signal is emitted when a match is found.
>  *
>  * In particular, makeCompletion(), previousMatch() and nextMatch() 
> all
>  * emit this signal; makeCompletion() will only emit it when a match 
> is
>  * found, but the other methods will always emit it (and so may emit 
> it
>  * with an empty string).
>  *
>  * @param item  the matching item, or QString() if there were no more
>  *  matching items.
>  */
> 
> And a similar thing for matches().

I think matches() is ok, since it is only used by makeCompletion().


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/#review47958
---


On Jan. 26, 2014, 10:46 p.m., David Gil Oliva wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115206/
> ---
> 
> (Updated Jan. 26, 2014, 10:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcompletion
> 
> 
> Description
> ---
> 
> Correct spelling, grammar and style of kcompletion.h docs
> 
> 
> Diffs
> -
> 
>   src/kcompletion.h 46b63a4 
> 
> Diff: https://git.reviewboard.kde.org/r/115206/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115206: Correct spelling, grammar and style of kcompletion.h docs

[David Gil Oliva]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115206/
---

(Updated Jan. 26, 2014, 10:46 p.m.)


Review request for KDE Frameworks.


Changes
---

Addressed all issues told by Alex, except the one in the signal matches(), 
which AFAICS is not necessary.


Repository: kcompletion


Description
---

Correct spelling, grammar and style of kcompletion.h docs


Diffs (updated)
-

  src/kcompletion.h 46b63a4 

Diff: https://git.reviewboard.kde.org/r/115206/diff/


Testing
---


Thanks,

David Gil Oliva

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: add test for QFileDialog::getExistingDirectory / bug?

[Gregor Mi]

With another addition to qfiledialogtest in
frameworks/frameworkintegration another potential bug can be exposed:

Calling

$ ./qfiledialogtest --nameFilter "c (*.cpp)" --nameFilter "h (*.h)"
--selectNameFilter "h (*.h)"

does not select the second filter. Can this be confirmed or maybe I am
using the API wrong?

Gregor



On 26/01/14 17:15, Gregor Mi wrote:
> Hi,
> 
> with 2c1ee08a21a1f16f9c2523718224598de8fc0d4f I added a test for
> QFileDialog::getExistingDirectory.
> 
> When I execute
> 
> ./qfiledialogtest --staticFunction getExistingDirectory
> 
> then a dialog opens that lets the user select files but not directories.
> This seems to be a bug.
> 
> Greetings
> 
> Gregor
> 
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : frameworkintegration_master_qt5 #23

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115123: Add an imported target to FindOpenEXR.cmake

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115123/#review48307
---


I'll commit this if there are no objections in the next couple of days.

- Alex Merry


On Jan. 19, 2014, 3:49 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115123/
> ---
> 
> (Updated Jan. 19, 2014, 3:49 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> Add an imported target to FindOpenEXR.cmake
> 
> This simplifies using the find module.
> 
> 
> Diffs
> -
> 
>   cmake/FindOpenEXR.cmake b4ae656722a78e8f3494415e4583709e9b29065e 
>   src/imageformats/CMakeLists.txt 053054a54ef53b7695b244748c3e5c0f252cc8c3 
> 
> Diff: https://git.reviewboard.kde.org/r/115123/diff/
> 
> 
> Testing
> ---
> 
> Builds (tested when OpenEXR is found).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Allow the building of deprecated code to be disabled

[Alex Merry]

Bump; does anyone have any comments on this idea?

Alex



On 15/01/14 13:56, Alex Merry wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> 
> 
> Review request for KDE Frameworks.
> By Alex Merry.
> *Repository: * kcoreaddons
> 
> 
>   Description
> 
> This is mostly an example of how we could improve the deprecation handling.  
> There are two parts: preventing deprecation warnings when building the 
> library itself (see 
> http://build.kde.org/view/Frameworks/job/kwidgetsaddons_master_qt5/11/warnings17Result/NORMAL/package.-1402078525/
>  for examples) and allowing the framework to be built with no deprecated code.
> 
> We possibly want to export the fact that the framework was built without 
> deprecated code via the CMake config file, so that downstream stuff (like 
> kde4support) can check for it and complain if necessary.
> 
> 
> Allow the building of deprecated code to be disabled
> 
> This adds a CMake option to enable or disable the building of deprected
> code.  It just changes the kcoreaddons_export.h file.
> 
> Part of this change is to use KCOREADDONS_NO_DEPRECATED instead of
> KDE_NO_DEPRECATED.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
>   Diffs
> 
>   * src/lib/CMakeLists.txt (8cc71f34e671962f2d7268b3db0d50e6750c26a2)
>   * src/lib/util/kuser.h (2b6e6ed92bc1465945f36f2fde821f36fa51585f)
>   * src/lib/util/kuser_unix.cpp (8a3a39d379ca863b4906bb01228c5e01a5b955b0)
>   * src/lib/util/kuser_win.cpp (6a6cbb1751bd569d8684f8e11add1ef304c0a94d)
> 
> View Diff 
> 
> 
> 
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114997: Improve KAuth README.md

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114997/
---

(Updated Jan. 26, 2014, 5:39 p.m.)


Review request for KDE Frameworks and Dario Freddi.


Repository: kauth


Description (updated)
---

Improve KAuth README.md


Diffs (updated)
-

  README.md a8a011a147d2dcc0fb5db39e263412005a86def4 

Diff: https://git.reviewboard.kde.org/r/114997/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115148: Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115148/
---

Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

Add KWINDOWSYSTEM_ namespace to HAVE_FOO defines

config-kwindowsystem.h is installed and included by public headers, so
it should not define things as generic as "HAVE_X11", which are likely
to also be defined by users of the framework.


Diffs
-

  src/netwm.cpp 266afccaf111e6707493b18dad1d9c03dde1d912 
  src/netwm.h aee6cea5e3b65cf6252b50515e4920cb9c96f240 
  src/kxerrorhandler.cpp 612e62a345ec9c8503bab9fb12afa08426974828 
  src/kxerrorhandler_p.h ad670fec6ff35e1c9df81b91517c02e6e0893ad1 
  src/kxmessages.h 5d57e06d702afb5ceaed05de97ca40116b7f3aa3 
  src/kxmessages.cpp b409ef2114c18190188ba5503d2f357bd9336e76 
  src/kxutils.cpp e47ba68c08a14597e49fd33901b0a7c079924112 
  src/kxutils_p.h 1e229801aac929bc596685dbfa5260d55d0f5298 
  src/kusertimestamp.cpp de8ca61e7e9dd0ae9492ccf61883560d80501e2b 
  src/kstartupinfo.cpp 5dbf47cb666fbed17c943491efe93e17f27d581e 
  src/kkeyserver.h 8869fe7331e98846183ab37814b1d95e75ab9647 
  src/config-kwindowsystem.h.cmake 58949d87f4254531ba57de86b6303cba05053222 
  src/CMakeLists.txt b453af11a46615ecd94911f0d2f86922087bde0e 
  CMakeLists.txt 2479237e574e86c9094b557dfa146c85b7b19b65 
  src/kwindoweffects.cpp 91ef52f149a781df9308bb1587629dbaaf571b8e 
  src/kwindoweffects_p.h 266b5f3e7f24bdca6ce467138ee067335225da78 
  src/kwindowsystem.h 5bcfd062dcca42d282b70d0683d4ee1da88cc814 
  src/kwindowsystem_x11.cpp 8634240cabc708a608277b34f21c41cee295e48a 

Diff: https://git.reviewboard.kde.org/r/115148/diff/


Testing
---

Clean configure-build-test-install on a system with X11.  KWindowSystem already 
failed to build on a non-windows, non-mac system when X11 is not found (one of 
the tests fails to link if you comment out the find_package(X11) calls, as 
KWindowSystem::activeWindow() is never defined).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115300: Fix KKeySequence shortcut types flags

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115300/#review48304
---


This review has been submitted with commit 
d52c0bc09ec1da30dd3c87cb605cd56c5257a63b by David Edmundson to branch master.

- Commit Hook


On Jan. 24, 2014, 4:13 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115300/
> ---
> 
> (Updated Jan. 24, 2014, 4:13 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> I assume the code was /trying/ to default to checking against local and 
> global shortcuts, in practice it was only ever going to select local 
> shortcuts.
> 
> 
> Diffs
> -
> 
>   src/kkeysequencewidget.cpp cc9016b 
>   src/kkeysequencewidget.h d5d70ea 
> 
> Diff: https://git.reviewboard.kde.org/r/115300/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115300: Fix KKeySequence shortcut types flags

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115300/
---

(Updated Jan. 26, 2014, 5:24 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kxmlgui


Description
---

I assume the code was /trying/ to default to checking against local and global 
shortcuts, in practice it was only ever going to select local shortcuts.


Diffs
-

  src/kkeysequencewidget.cpp cc9016b 
  src/kkeysequencewidget.h d5d70ea 

Diff: https://git.reviewboard.kde.org/r/115300/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/
---

(Updated Jan. 26, 2014, 5:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Chusslove Illich.


Repository: ki18n


Description
---

Search for LibIntl, not all platforms include it in libc

This is required on e.g. Windows, but also any other system that does
not use glibc as the default C library


Fix linking on MSVC by using KTRANSCRIPT_EXPORT


Diffs
-

  cmake/FindLibIntl.cmake PRE-CREATION 
  src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
  src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
  src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
  src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
  CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 

Diff: https://git.reviewboard.kde.org/r/115289/diff/


Testing
---

Compiles on Windows, no change to Linux


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

add test for QFileDialog::getExistingDirectory / bug?

[Gregor Mi]

Hi,

with 2c1ee08a21a1f16f9c2523718224598de8fc0d4f I added a test for
QFileDialog::getExistingDirectory.

When I execute

./qfiledialogtest --staticFunction getExistingDirectory

then a dialog opens that lets the user select files but not directories.
This seems to be a bug.

Greetings

Gregor

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/#review48298
---

Ship it!


Looks good!

- Alex Merry


On Jan. 26, 2014, 3:54 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115289/
> ---
> 
> (Updated Jan. 26, 2014, 3:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> Search for LibIntl, not all platforms include it in libc
> 
> This is required on e.g. Windows, but also any other system that does
> not use glibc as the default C library
> 
> 
> Fix linking on MSVC by using KTRANSCRIPT_EXPORT
> 
> 
> Diffs
> -
> 
>   cmake/FindLibIntl.cmake PRE-CREATION 
>   src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
>   src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
>   src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
>   src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
>   CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 
> 
> Diff: https://git.reviewboard.kde.org/r/115289/diff/
> 
> 
> Testing
> ---
> 
> Compiles on Windows, no change to Linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: Search for LibIntl, not all platforms include it in libc

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/
---

(Updated Jan. 26, 2014, 4:54 p.m.)


Review request for KDE Frameworks and Chusslove Illich.


Changes
---

check whether libintl needs a separate library by using check_symbol_exists


Summary (updated)
-

Search for LibIntl, not all platforms include it in libc


Repository: ki18n


Description (updated)
---

Search for LibIntl, not all platforms include it in libc

This is required on e.g. Windows, but also any other system that does
not use glibc as the default C library


Fix linking on MSVC by using KTRANSCRIPT_EXPORT


Diffs (updated)
-

  cmake/FindLibIntl.cmake PRE-CREATION 
  src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
  src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
  src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
  src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
  CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 

Diff: https://git.reviewboard.kde.org/r/115289/diff/


Testing
---

Compiles on Windows, no change to Linux


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115289: MSVC fix: Check for libintl.h and libintl.lib

[Alexander Richardson]

> On Jan. 24, 2014, 9:09 p.m., Alex Merry wrote:
> > cmake/FindLibIntl.cmake, line 26
> > 
> >
> > Why not check if a libintl symbol exists without linking against any 
> > special libraries?
> 
> Alexander Richardson wrote:
> Would be better, but I have to admit that I lack the required CMake 
> skills. What would I have to do for that check?
> 
> Alex Merry wrote:
> I'm a bit rushed today, but you probably want to use 
> http://www.cmake.org/cmake/help/v2.8.12/cmake.html#module:CheckCXXSymbolExists
>  (quoting: "If the header files declare the symbol as a function or variable 
> then the symbol must also be available for linking.").
> 
> If it fails, you need to find libintl.
> 
> Alex Merry wrote:
> If you get stuck, let me know, and I'll try to look at it tomorrow or 
> Monday.

Didn't know about that, nice and clean solution


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115289/#review48246
---


On Jan. 24, 2014, 5:06 p.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115289/
> ---
> 
> (Updated Jan. 24, 2014, 5:06 p.m.)
> 
> 
> Review request for KDE Frameworks and Chusslove Illich.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> MSVC fix: Check for libintl.h and libintl.lib
> 
> On MSVC we have libintl as a separate library and must therefore explicitly
> link to it. This is not required on linux since gettext is part of glibc.
> On Windows libintl.h is not always found in the default include path and
> has to be searched for.
> 
> Fix linking on MSVC by using KTRANSCRIPT_EXPORT
> 
> 
> Diffs
> -
> 
>   src/ktranscript.cpp e0570f1cccabb8e3a59ff952eac2817081ec4e9e 
>   src/kcatalog.cpp d337a50fb973e810e549671b60b2227db78d0628 
>   src/gettext.h 3d3c2733576b5d2b977c3360519636662caf18c5 
>   src/CMakeLists.txt bfb7d793a8cea883378555368eeec7582e8f88b1 
>   cmake/FindLibIntl.cmake PRE-CREATION 
>   CMakeLists.txt 165f8c84156ebdb5034424752cc5f80a5d70319c 
> 
> Diff: https://git.reviewboard.kde.org/r/115289/diff/
> 
> 
> Testing
> ---
> 
> Compiles on Windows, no change to Linux
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

[Michael Palimaka]

> On Jan. 26, 2014, 7:22 a.m., István Kapcsándi wrote:
> > src/CMakeLists.txt, line 17
> > 
> >
> > maybe I'm wrong but my logic says that this should be 
> > install(FILES ${kglobalaccel_component_xml} DESTINATION 
> > ${DBUS_INTERFACES_INSTALL_DIR} RENAME 
> > kf5_org.kde.KGlobalAccel.Component.xml)

Good spot, but it is already fixed in 1d861e0d0513b5e67bdf71e4879ce405fcdcf971.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115078/#review48281
---


On Jan. 21, 2014, 4:24 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115078/
> ---
> 
> (Updated Jan. 21, 2014, 4:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> don't install dbus interface files in kglobalaccel, these overlap with the 
> equivalent files in kdelibs4 which causes problems for some distributions
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt d48e92e 
> 
> Diff: https://git.reviewboard.kde.org/r/115078/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel