Re: [kde-frameworks-devel] Regarding entry.desktop files
On Saturday 29 March 2014 22:06:10 Chusslove Illich wrote: [: Luigi Toscano :] I'm a bit confused now: what files are to be renamed? The ones in the SVN repository under lang/messages/entry.desktop? I think that the best solution at the moment is: don't rename anything in the repositories, and also don't install these files at all. When it is decided how the language selection will work with KF5, revisit this matter. Well, yes, but it's time to decide :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kde-frameworks-devel] Regarding entry.desktop files
[: Chusslove Illich :] I think that the best solution at the moment is: don't rename anything in the repositories, and also don't install these files at all. When it is decided how the language selection will work with KF5, revisit this matter. [: David Faure :] Well, yes, but it's time to decide :-) There I propose not to have language entry.desktop files any more :) -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
qt5 stable: qengineio: fatal: remote error: access denied or repository not exported
Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported
On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported
On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.dewrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Moving KPlugionLoader|Factory to KCoreAddons?
On 29/03/14 15:57, Alex Merry wrote: I just realised a flaw with this: KPluginLoader has a constructor that takes a KService argument. Which is annoying, because the only difference between KPluginLoader(service) and KPluginLoader(service.library()) is the error message you get if the service is not valid or does not provide a library. A solution! https://git.reviewboard.kde.org/r/117185/ Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:28 a.m.) Review request for KDE Frameworks and David Faure. Changes --- Make KService::operator KPluginName() const (fixes compilation of kcmutils and other modules). Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs (updated) - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kde-frameworks-devel] Regarding entry.desktop files
On Sunday 30 March 2014 10:24:28 Chusslove Illich wrote: [: Chusslove Illich :] I think that the best solution at the moment is: don't rename anything in the repositories, and also don't install these files at all. When it is decided how the language selection will work with KF5, revisit this matter. [: David Faure :] Well, yes, but it's time to decide :-) There I propose not to have language entry.desktop files any more :) And, what do we use instead, to show the user a list of languages to choose from (i.e. for which translations are installed)? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117185: Remove KPluginLoader dependency on KService
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117185/ --- (Updated March 30, 2014, 11:41 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Sebastian Kügler. Changes --- Add sebas and ervin. Repository: kservice Description --- Remove KPluginLoader dependency on KService The reason for this is so that KPluginLoader, KPluginFactory and kexportplugin.h do not require anything else from the KService framework, allowing them to be moved to KCoreAddons. A KPluginName class is introduced to act as an intermediary between KService and KPluginLoader. The KPluginLoader(KService) constructor is replaced with KPluginLoader(KPluginName), and KService gains a cast operator to convert it to a KPluginName. Now KService service(blah.desktop); KPluginLoader(service); works as before, maintaining source compatibility. The reason for the intermediary class (rather than just, say, providing a QString() operator to KService) is to make sure this combination is the only one that works (and you can't start using KService everywhere a QString is expected). Diffs - autotests/CMakeLists.txt dcc4a40bd81f7e17f10219649214a8c9aac5cc60 autotests/jsonplugin.h PRE-CREATION autotests/jsonplugin.cpp PRE-CREATION autotests/jsonplugin.json PRE-CREATION autotests/kpluginloadertest.cpp 2b0afb81469f18f93ea43e6ac73df95a60cbd7f3 autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 796abbcc6313d2cfd69bd213281ea30dfebaa421 autotests/noplugin.desktop PRE-CREATION src/plugin/kpluginloader.h 4e10edf0f152b409c6a4031610ff1f2f9771d08d src/plugin/kpluginloader.cpp 1602c180db5e1a5f0765d95d68f90d2046c9ef2b src/services/kservice.h 6df389a130587eea732b1d81718181bbd3df4f6d src/services/kservice.cpp c897d4c2a08d048e817154101b3a212a098f9768 Diff: https://git.reviewboard.kde.org/r/117185/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117161: Drop QApplication usages in units.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/#review54589 --- Ship it! Ship It! - Sebastian Kügler On March 29, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/ --- (Updated March 29, 2014, 7:25 p.m.) Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Drop dependency to QtWidgets from this file. We can start assuming that it might not be that functional in some platforms. Use QGuiApplication counterparts, based mostly on QScreen, which could make it more powerful in the future. I did it because otherwise KAlgebraMobile crashes if using the Plasma Components based interface. Diffs - src/declarativeimports/core/units.cpp f0b8d39 Diff: https://git.reviewboard.kde.org/r/117161/diff/ Testing --- Builds, KAlgebra doesn't have the problem now. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: threadweaver_master_qt5 #42
See http://build.kde.org/job/threadweaver_master_qt5/42/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117146: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 30, 2014, 2:03 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- * Comment out xcb include, since its only usage is ifdefd out * Remove KF5 dependencies that are not used * The KF5::ItemViews link was only indirectly used to link against KIO, but that's fixed there now Diffs - CMakeLists.txt ef8bfede0b878b2c853a8cd17b0c36c997f5a9dc src/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 Diff: https://git.reviewboard.kde.org/r/117146/diff/ Testing --- Builds. Inspected source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117146: Remove unused dependencies
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/#review54602 --- This review has been submitted with commit 7786630bdc8898fb69a98090c544c7d67f9081ba by Michael Palimaka to branch master. - Commit Hook On March 28, 2014, 6:55 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 28, 2014, 6:55 p.m.) Review request for KDE Frameworks. Repository: kde4support Description --- * Comment out xcb include, since its only usage is ifdefd out * Remove KF5 dependencies that are not used * The KF5::ItemViews link was only indirectly used to link against KIO, but that's fixed there now Diffs - CMakeLists.txt ef8bfede0b878b2c853a8cd17b0c36c997f5a9dc src/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 Diff: https://git.reviewboard.kde.org/r/117146/diff/ Testing --- Builds. Inspected source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117190: Improve tests
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117190/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Make it possible to avoid building tests. QtConcurrent is only required for tests. Diffs - CMakeLists.txt 71fe6d6158eaaba18ffc55d1489d9e9edc84a242 autotests/CMakeLists.txt 91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117131: Implement KUser::faceIconPath on Windows.
On March 28, 2014, 10:49 a.m., Alexander Richardson wrote: src/lib/util/kuser_win.cpp, line 391 https://git.reviewboard.kde.org/r/117131/diff/1/?file=257913#file257913line391 WCHAR pathBuf[MAX_PATH]; then you don't need the reinterpret_cast and can use QString::fromWCharArray() Ah nice, I didn't know about fromWCharArray, and without that, using WCHAR meant I needed a reinterpret_cast in the fromUtf16 call anyway. I'll change it. On March 28, 2014, 10:49 a.m., Alexander Richardson wrote: src/lib/util/kuser_win.cpp, line 388 https://git.reviewboard.kde.org/r/117131/diff/1/?file=257913#file257913line388 maybe make this static so it only gets resolved once: static SGUPP_ptr SHGetUserPicturePath = reinterpret_castSGUPP_ptr(GetProcAddress(LoadLibraryW(Lshell32.dll), MAKEINTRESOURCEA(261))); Agreed. And it makes sense to make the library handle static too. On March 28, 2014, 10:49 a.m., Alexander Richardson wrote: src/lib/util/kuser_win.cpp, line 384 https://git.reviewboard.kde.org/r/117131/diff/1/?file=257913#file257913line384 Don't think we need the RAII object here, AFAIK we link to shell32.dll anyway, so it will only be deleted on process exit anyway. -1. You could make the same argument about not needing to uninitialize COM. It's simply good practice to free what you allocate, or in this case, decrement reference counts when you're done even if you know it'll never reach 0 anyway. - Nicolás --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/#review54437 --- On March 27, 2014, 10:07 p.m., Nicolás Alvarez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- (Updated March 27, 2014, 10:07 p.m.) Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- Implement KUser::faceIconPath on Windows. I use an undocumented Windows API (http://undoc.airesoft.co.uk/shell32.dll/SHGetUserPicturePath.php) that stores the profile image in a temporary file and returns the path to it. The previous code was just trying to load that temporary file, and would only work if another app had created the file recently (such as the control panel section where the image is changed). This only works on Windows Vista and later; on Windows XP the undocumented API is different, and faceIconPath will just return an empty string. Diffs - src/lib/util/kuser_win.cpp 96cf2f0b89ac18a68783793d3a8b2827b72dd968 Diff: https://git.reviewboard.kde.org/r/117131/diff/ Testing --- Compiled with MSVC2010, tested via the new faceicontest on Windows 7. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117131: Implement KUser::faceIconPath on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117131/ --- (Updated March 30, 2014, 12:35 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Made library handle and function pointer static. Changed type of buffer to WCHAR[]. Repository: kcoreaddons Description --- Implement KUser::faceIconPath on Windows. I use an undocumented Windows API (http://undoc.airesoft.co.uk/shell32.dll/SHGetUserPicturePath.php) that stores the profile image in a temporary file and returns the path to it. The previous code was just trying to load that temporary file, and would only work if another app had created the file recently (such as the control panel section where the image is changed). This only works on Windows Vista and later; on Windows XP the undocumented API is different, and faceIconPath will just return an empty string. Diffs (updated) - src/lib/util/kuser_win.cpp 96cf2f0 Diff: https://git.reviewboard.kde.org/r/117131/diff/ Testing --- Compiled with MSVC2010, tested via the new faceicontest on Windows 7. Thanks, Nicolás Alvarez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? Gregor ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed
On March 27, 2014, 3:47 p.m., Kevin Ottens wrote:
src/kjsembed/CMakeLists.txt, line 75
https://git.reviewboard.kde.org/r/117012/diff/1/?file=256496#file256496line75
Agreed, that should be the preferred way.
Note that some other frameworks probably carry the same mistake
I'll update the patch as per Cristophe's and Aleix's comments.
From what I can see from the frameworks I've built on Windows at the moment
(all tier1 and most tier2), most of them has
include/KF5/FrameworkName/headers, except:
Attica (include/KF5/Attica/Attica/headers)
KDNSSD (include/KF5/KDNSSD/DNSSD/headers)
Solid (include/KF5/Solid/Solid/headers)
ThreadWeaver (include/KF5/ThreadWeaver/ThreadWeaver/headers)
*Sonnet (include/Kf5/SonnetCore/Sonnet/headers and
include/Kf5/SonnetUi/Sonnet/headers)
*KDocTools (include/KF5/XsltKde/headers)
Can we consider fixing those too? (I'm just not sure about the ones I marked
with *)
- Andrius da Costa
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review54308
---
On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---
(Updated March 24, 2014, 1:33 a.m.)
Review request for KDE Frameworks and kdewin.
Repository: kjsembed
Description
---
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs
-
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
---
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117161: Drop QApplication usages in units.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/#review54645 --- This review has been submitted with commit 018bd82acaf7734126a4fe21f8a54b11a398407b by Aleix Pol to branch master. - Commit Hook On March 29, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/ --- (Updated March 29, 2014, 7:25 p.m.) Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Drop dependency to QtWidgets from this file. We can start assuming that it might not be that functional in some platforms. Use QGuiApplication counterparts, based mostly on QScreen, which could make it more powerful in the future. I did it because otherwise KAlgebraMobile crashes if using the Plasma Components based interface. Diffs - src/declarativeimports/core/units.cpp f0b8d39 Diff: https://git.reviewboard.kde.org/r/117161/diff/ Testing --- Builds, KAlgebra doesn't have the problem now. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117161: Drop QApplication usages in units.cpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/ --- (Updated March 30, 2014, 9:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. Repository: plasma-framework Description --- Drop dependency to QtWidgets from this file. We can start assuming that it might not be that functional in some platforms. Use QGuiApplication counterparts, based mostly on QScreen, which could make it more powerful in the future. I did it because otherwise KAlgebraMobile crashes if using the Plasma Components based interface. Diffs - src/declarativeimports/core/units.cpp f0b8d39 Diff: https://git.reviewboard.kde.org/r/117161/diff/ Testing --- Builds, KAlgebra doesn't have the problem now. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Sun, Mar 30, 2014 at 6:38 PM, Gregor Mi codeminis...@publicstatic.dewrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? Gregor No idea, I never had this problem. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable / SOLVED
On 30/03/14 23:07, Aleix Pol wrote: On Sun, Mar 30, 2014 at 6:38 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? Gregor No idea, I never had this problem. Aleix In my last mail to the topic I wrote how I solved it (by using the gitorious repo). So no further action required. :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: [kde-frameworks-devel] Regarding entry.desktop files
[: Chusslove Illich :] There I propose not to have language entry.desktop files any more :) [: David Faure :] And, what do we use instead, to show the user a list of languages to choose from (i.e. for which translations are installed)? I don't think the concept of installed translations is workable any more, nor useful even if it were. So I'd do away with language packages, and have all KDE software come with translations unconditionally. As is the case now with most other Gettext-based software, with non-SC KDE software, and the only reasonable solution for Frameworks themselves. So always all translations would be installed, and the user would pick among all languages. What all should mean, there are some opinions in the Translations KCM thread. -- Chusslove Illich (Часлав Илић) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Move KDED out of frameworks?
El Divendres, 28 de març de 2014, a les 20:55:02, Boudewijn Rempt va escriure: On Fri, 28 Mar 2014, Kevin Krammer wrote: The D-Bus session/user daemon is also something that needs to be treated in a platform specific way as a dependency. E.g. on Windows there could be a D-Bus installer that applications bundle and run if necessary, very much like Games bunlding an DirectX installer. Oh no, I never would do that... It would still cost me many hours of my life dealing with it, and it would still give my users no advantage at all. There just isn't any reason an application like Krita would need an ipc solution -- and any library that insists on coming with one is just not going to make the cut. (Heck, it's just like sycoca... That thing has cost me weeks of my life, all totted up, and has not delivered anything useful at all.) That's a really not helpful nor constructive sentence. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117194: Remove weird comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- Review request for KDE Frameworks. Repository: kbookmarks Description --- No idea what this comment is about and it also makes lupdate unhappy ./src /home/scripty/prod/git-unstable/frameworks_kbookmarks/src/kbookmark.h:99: Discarding unconsumed meta data Diffs - src/kbookmark.h 2307ca9 Diff: https://git.reviewboard.kde.org/r/117194/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Does KKeyserver QT_TR_NOOP work?
Running lupdate complains so I'm not sure it does /home/scripty/prod/git- unstable/frameworks_kwindowsystem/src/kkeyserver_x11.cpp:88: Class 'KKeyServer' lacks Q_OBJECT macro Note that KKeyServer is not a class... Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Does sonnet tr() work?
/home/scripty/prod/git- unstable/frameworks_sonnet/src/ui/spellcheckdecorator.cpp:35: Ignoring definition of undeclared qualified class /home/scripty/prod/git- unstable/frameworks_sonnet/src/ui/spellcheckdecorator.cpp:137: Qualifying with unknown namespace/class ::SpellCheckDecorator Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117194: Remove weird comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/#review54646 --- Ship it! Well, it's not doing anything useful commented out like that... - Alex Merry On March 30, 2014, 10:05 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- (Updated March 30, 2014, 10:05 p.m.) Review request for KDE Frameworks. Repository: kbookmarks Description --- No idea what this comment is about and it also makes lupdate unhappy ./src /home/scripty/prod/git-unstable/frameworks_kbookmarks/src/kbookmark.h:99: Discarding unconsumed meta data Diffs - src/kbookmark.h 2307ca9 Diff: https://git.reviewboard.kde.org/r/117194/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117194: Remove weird comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/#review54648 --- This review has been submitted with commit 534847c94ae9fb6fcefb95b730542567ea5bb080 by Albert Astals Cid to branch master. - Commit Hook On March 30, 2014, 10:05 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- (Updated March 30, 2014, 10:05 p.m.) Review request for KDE Frameworks. Repository: kbookmarks Description --- No idea what this comment is about and it also makes lupdate unhappy ./src /home/scripty/prod/git-unstable/frameworks_kbookmarks/src/kbookmark.h:99: Discarding unconsumed meta data Diffs - src/kbookmark.h 2307ca9 Diff: https://git.reviewboard.kde.org/r/117194/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117194: Remove weird comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/#review54647 --- Ship it! Ship It! - David Faure On March 30, 2014, 10:05 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- (Updated March 30, 2014, 10:05 p.m.) Review request for KDE Frameworks. Repository: kbookmarks Description --- No idea what this comment is about and it also makes lupdate unhappy ./src /home/scripty/prod/git-unstable/frameworks_kbookmarks/src/kbookmark.h:99: Discarding unconsumed meta data Diffs - src/kbookmark.h 2307ca9 Diff: https://git.reviewboard.kde.org/r/117194/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117194: Remove weird comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117194/ --- (Updated March 30, 2014, 10:18 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kbookmarks Description --- No idea what this comment is about and it also makes lupdate unhappy ./src /home/scripty/prod/git-unstable/frameworks_kbookmarks/src/kbookmark.h:99: Discarding unconsumed meta data Diffs - src/kbookmark.h 2307ca9 Diff: https://git.reviewboard.kde.org/r/117194/diff/ Testing --- Thanks, Albert Astals Cid ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Lots of duplicated catalogs
On Mon, Mar 31, 2014 at 12:15 AM, Albert Astals Cid aa...@kde.org wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot $ find -name kdesud.pot ./frameworks/kdesud.pot ./kde-runtime/kdesud.pot $ find -name kio_help4.pot ./frameworks/kio_help4.pot ./kdelibs/kio_help4.pot $ find -name kpasswdserver.pot ./frameworks/kpasswdserver.pot ./kde-runtime/kpasswdserver.pot $ find -name solid_qt.pot ./frameworks/solid_qt.pot ./kdelibs/solid_qt.pot $ find -name timezones4.pot ./frameworks/timezones4.pot ./kdelibs/timezones4.pot $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Please fix. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel We can wait a week until the splitting is done, can't we? Where should it be deleted from? Note that kdelibs shouldn't be translated anymore and soon kde-workspace and kde-runtime should be the same. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117195: [kio] Replace COULD_NOT with CANNOT in the error code enum
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117195/ --- Review request for KDE Frameworks. Repository: kio Description --- Use the new name for the error codes ERR_COULD_NOT_* has been replaced with ERR_CANNOT_*. Replace COULD_NOT with CANNOT in the error code enum This makes the error code names more consistent. The old versions are kept for backwards-compatibility. Diffs - src/core/global.h be8e5481c8146c2d0737be06f034cdccc1573f79 src/core/job_error.cpp 1ec28c5d9ebdbc2045743c566f473c8cfa02e1bd src/ioslaves/http/http.cpp 3158628af2dc8ee88a0ac0d968748d6b50a8da33 src/ioslaves/help/kio_help.cpp df3e934b5cac7428bd1525d5de1b3fedd9b16394 src/ioslaves/ftp/ftp.cpp 49037701772f88e9a96bc3110f1f04fccb810ca8 src/ioslaves/file/file_unix.cpp bb4d6003985269464c380927d51eaf9ed602ade1 src/ioslaves/file/file.cpp 6387d7f29df2c0a26952be5255438361c37ed082 src/core/tcpslavebase.cpp ea0434e19a7fb35cc708dece1ff904d6739aa4de src/core/slavebase.h 4726915da0757c64ab735f586142806891b517d1 src/widgets/accessmanagerreply_p.cpp 4322e0275f57f10aeba2ea8381f53d06f6b6fe25 Diff: https://git.reviewboard.kde.org/r/117195/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Lots of duplicated catalogs
On Mon, Mar 31, 2014 at 12:30 AM, Luigi Toscano luigi.tosc...@tiscali.itwrote: Aleix Pol ha scritto: On Mon, Mar 31, 2014 at 12:15 AM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot $ find -name kdesud.pot ./frameworks/kdesud.pot ./kde-runtime/kdesud.pot $ find -name kio_help4.pot ./frameworks/kio_help4.pot ./kdelibs/kio_help4.pot $ find -name kpasswdserver.pot ./frameworks/kpasswdserver.pot ./kde-runtime/kpasswdserver.pot $ find -name solid_qt.pot ./frameworks/solid_qt.pot ./kdelibs/solid_qt.pot $ find -name timezones4.pot ./frameworks/timezones4.pot ./kdelibs/timezones4.pot $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Please fix. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org mailto:Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel We can wait a week until the splitting is done, can't we? Where should it be deleted from? Note that kdelibs shouldn't be translated anymore and soon kde-workspace and kde-runtime should be the same. What? As soon as kdelibs still receives fixes, we need to keep the translations. Also, this is not about removing them. As Albert kindly explained to me, this is about renaming in order to install both files at the same time (which will be the case for a long time). So for example change the timezones4.pot - timezones5.pot and so on. Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Ah ok, I clearly misunderstood. Thanks Luigi! Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Lots of duplicated catalogs
El Dilluns, 31 de març de 2014, a les 00:43:09, Aleix Pol va escriure: On Mon, Mar 31, 2014 at 12:30 AM, Luigi Toscano luigi.tosc...@tiscali.itwrote: Aleix Pol ha scritto: On Mon, Mar 31, 2014 at 12:15 AM, Albert Astals Cid aa...@kde.org mailto:aa...@kde.org wrote: $ find -name kdecalendarsystems.pot ./frameworks/kdecalendarsystems.pot ./kdelibs/kdecalendarsystems.pot $ find -name kdelibs_colors4.pot ./frameworks/kdelibs_colors4.pot ./kdelibs/kdelibs_colors4.pot $ find -name kdesud.pot ./frameworks/kdesud.pot ./kde-runtime/kdesud.pot $ find -name kio_help4.pot ./frameworks/kio_help4.pot ./kdelibs/kio_help4.pot $ find -name kpasswdserver.pot ./frameworks/kpasswdserver.pot ./kde-runtime/kpasswdserver.pot $ find -name solid_qt.pot ./frameworks/solid_qt.pot ./kdelibs/solid_qt.pot $ find -name timezones4.pot ./frameworks/timezones4.pot ./kdelibs/timezones4.pot $ find -name xml_mimetypes.pot ./frameworks/xml_mimetypes.pot ./kdelibs/xml_mimetypes.pot Please fix. Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org mailto:Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel We can wait a week until the splitting is done, can't we? Where should it be deleted from? Note that kdelibs shouldn't be translated anymore and soon kde-workspace and kde-runtime should be the same. What? As soon as kdelibs still receives fixes, we need to keep the translations. Also, this is not about removing them. As Albert kindly explained to me, this is about renaming in order to install both files at the same time (which will be the case for a long time). So for example change the timezones4.pot - timezones5.pot and so on. Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Ah ok, I clearly misunderstood. Well, my message clearly was not easy to understand. Sorry about that. Cheers, Albert Thanks Luigi! Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de wrote: On 30/03/14 12:41, Aleix Pol wrote: On Sun, Mar 30, 2014 at 12:02 PM, Gregor Mi codeminis...@publicstatic.de mailto:codeminis...@publicstatic.de wrote: On 30/03/14 11:29, Gregor Mi wrote: Hi, has anyone recently build qt5 from scratch as described here [1]? When doing $ ./init-repository the following error occurs: --- + git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio Cloning into 'qtenginio'... fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. git clone git://anongit.kde.org/qt/qtenginio.git http://anongit.kde.org/qt/qtenginio.git qtenginio exited with status 32768 at ./init-repository line 305. --- The other repos are working fine. Best regards Gregor [1] http://community.kde.org/Frameworks/Building, section QT5 When building QT5 as described in [1] the stable branch of Qt is now 5.3 (and not 5.2). Is this correct? AFAIK, the building dependency is 5.2 and that probably is outdated, as stable is a moving target. Either way, I'd suggest you to use stable too. Aleix Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Gregor Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
