Jenkins build became unstable: kdelibs_stable #1054
See http://build.kde.org/job/kdelibs_stable/1054/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
[sinp] To test translations: 1. Generate a .pot file by following those instructions: http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_System s#Testing_your_Messages.sh_script 2. Create a translation file: cd po cp myframework.pot myframework-fr.po (or -de, -es, -pt...) 3. Edit myframework-fr.po with Lokalize or your text editor, translate strings of interest (no need to translate all, this is just for testing) 4. Rerun cmake so that it notices the new po dir (touch CMakeLists.txt should do) 5. Run make and make install 6. Run the code to test, your translations should appear This is really bad compared to our you do it in kde4 which is basically. * Go do l10n-kde4 * Install your language * Done True. It also makes it much harder for translators to test the translations they are working on since they suddenly have to compile the program they are translating instead of just compiling the translation and using the binaries the distro provides. Even in the current state, I think it would still work: distro would ship packages built from tarballs which contain translations, so the code would load any updated translation. In any case, such a testing workflow is broken, IMO: you want to test translations of version N of the app with code of version N, not version N - 1. Having said that, it is a problem when testing packages for nightly builds (a much better way to test translations), which I assume are not built from tarballs with translations. Any way we can make the old just compile your l10n-kde4 language and install it way work? The cmake code can be changed to always build the .qm loader. This way you can build the .qm separately. It would still require the step compile your l10n-kde4 language and install to know that this particular .po needs to be turned into a .qm, not a .mo. Any ideas how to do that? Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Monday, March 31, 2014 23:24:09 Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Hi Ben, then thanks again for fixing it (again). Question though: Could this error be caught earlier, maybe automated? Honestly we should stop suggesting people to build their own Qt and just use 5.2 distro packages. Heh, that would be the most trivial and a working solution. Greetings, Dominik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Tue, Apr 1, 2014 at 9:23 PM, Dominik Haumann dhaum...@kde.org wrote: On Monday, March 31, 2014 23:24:09 Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Hi Ben, then thanks again for fixing it (again). Question though: Could this error be caught earlier, maybe automated? Honestly we should stop suggesting people to build their own Qt and just use 5.2 distro packages. Heh, that would be the most trivial and a working solution. I've no idea if this will actually end up the case, but won't KF 5.1 end up depending on Qt 5.3? ie. this problem is going to come up again once KF 5.0 is released. Greetings, Dominik Thanks, Ben ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54745 --- Ship it! Thanks. - Christoph Feck On April 1, 2014, 12:25 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 12:25 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs - tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 9:44 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs - tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54752 --- This review has been submitted with commit 8402305be5e3fb4fef5febca7f1b7cab386f5c09 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 12:25 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 12:25 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs - tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/#review54751 --- This review has been submitted with commit f606255894e9c9eca7cbf42cc65556cc7548d706 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 12:25 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 12:25 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs - tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117271: KIconDialog: do not connect to a signal that does not exist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117271/ --- (Updated April 1, 2014, 9:44 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Repository: kiconthemes Description --- Add a new test that just checks kicondialog The old kicondialogtest actually tested KIconButton. That is now renamed to kiconbuttontest, and there is a new kicondialogtest that tests KIconDialog. KIconDialog: do not connect to a signal that does not exist QDialog::finished(int) does what we want, so use that instead. Diffs - tests/CMakeLists.txt b3b4c90a9ffbc9df81dd008f9cfbc668866fafe3 tests/kiconbuttontest.cpp PRE-CREATION src/kicondialog.cpp 4b241c1591b321486c925ef5e61f09bc7b6ddd1c tests/kicondialogtest.cpp 66432ba878a4133ea3210089d3fdfbaec145bf1b Diff: https://git.reviewboard.kde.org/r/117271/diff/ Testing --- Tested with the new kicondialogtest, and everything seems to be in order. The old kiconbuttontest is not working properly, apparently because QIcon::fromTheme() is not working. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 1, 2014, 10:09 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Changes --- Make the constructor require fewer arguments, not more. Repository: kcoreaddons Description (updated) --- This is another thing on the if only we'd spotted it before beta1 list. I went with not allowing any optional arguments to the constructor, to encourage users of the class to use setters, which makes for more readable code. I deliberated giving it just one argument, but in the end went with the formerly-required arguments. The organizationDomain is not automatically set from the home page with this new usage style, as that only happened in the constructor and not in the setter. It could be set if the organizationDomain has not been explicitly set. However, the organizationDomain is not passed to QCoreApplication as I assumed it would be - it that intentional? Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Diffs (updated) - src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- KDatePicker: override changeEvent() instead of setEnabled() As the comment noted, setEnabled() is not virtual. Also, there was no need to separately enabled/disable the individual components, when they are children of the KDatePicker widget. Instead, we override changeEvent() and use it to focus the table (as before). This also extends the kdatepicktest to temporarily disable the picker. Diffs - src/kdatepicker.h 855aeb01ff457394cfbcff57845a57a9eae0a103 src/kdatepicker.cpp 345ee2d97632647789e6762e5e155e75802c2191 tests/kdatepicktest.cpp 5f29110f2335bb110b3470007a59f9cb8b6bcfee Diff: https://git.reviewboard.kde.org/r/117277/diff/ Testing --- Builds. Tests pass. Played around with kdatepicktest; behaviour seems unchanged. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117278: Remove KDE4 TODO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Remove KDE4 TODO This is about scrolling to the first selected size in KFontChooser. As far as I can tell, this happens anyway without the need for an explicit call to QListWidget::scrollToItem(). Diffs - src/kfontchooser.cpp 4fa9699121c9056c58cd35894fd39eb755758a71 Diff: https://git.reviewboard.kde.org/r/117278/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54753 --- src/console/main.cpp https://git.reviewboard.kde.org/r/117274/#comment38250 You might want to keep the context with, i18nc, no? - Aleix Pol Gonzalez On April 1, 2014, 1:17 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 1:17 a.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData
On April 1, 2014, 10:47 a.m., Aleix Pol Gonzalez wrote: src/console/main.cpp, line 130 https://git.reviewboard.kde.org/r/117274/diff/1/?file=262151#file262151line130 You might want to keep the context with, i18nc, no? It wasn't a very useful context, I don't think, and was probably only there because QCoreApplication::translate() requires it. I could put in a more helpful context if you think that's useful, though (like command line argument). - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54753 --- On April 1, 2014, 1:17 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 1:17 a.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117278: Remove KDE4 TODO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/#review54757 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 10:43 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/ --- (Updated April 1, 2014, 10:43 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Remove KDE4 TODO This is about scrolling to the first selected size in KFontChooser. As far as I can tell, this happens anyway without the need for an explicit call to QListWidget::scrollToItem(). Diffs - src/kfontchooser.cpp 4fa9699121c9056c58cd35894fd39eb755758a71 Diff: https://git.reviewboard.kde.org/r/117278/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review54756 --- I think it's fine that you add the other one if you prefer people to use setters, but please don't deprecate the old one. There's little reason for doing so, it's very old API and it has always worked as is. - Aleix Pol Gonzalez On April 1, 2014, 10:09 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 1, 2014, 10:09 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Repository: kcoreaddons Description --- This is another thing on the if only we'd spotted it before beta1 list. I went with not allowing any optional arguments to the constructor, to encourage users of the class to use setters, which makes for more readable code. I deliberated giving it just one argument, but in the end went with the formerly-required arguments. The organizationDomain is not automatically set from the home page with this new usage style, as that only happened in the constructor and not in the setter. It could be set if the organizationDomain has not been explicitly set. However, the organizationDomain is not passed to QCoreApplication as I assumed it would be - it that intentional? Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Diffs - src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix kf5kross i18n, and resurrect its KAboutData
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54758 --- Well, still it sounds a good idea to note that it's from a main() function. - Aleix Pol Gonzalez On April 1, 2014, 1:17 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 1:17 a.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData
On April 1, 2014, 10:55 a.m., Aleix Pol Gonzalez wrote: I think it's fine that you add the other one if you prefer people to use setters, but please don't deprecate the old one. There's little reason for doing so, it's very old API and it has always worked as is. The reason for deprecating the old one is that it forces everyone to set the catalog name, which is useless. The aim is to move everyone away from doing that by KF6. Would the first diff version be more acceptable to you? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review54756 --- On April 1, 2014, 10:09 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 1, 2014, 10:09 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Repository: kcoreaddons Description --- This is another thing on the if only we'd spotted it before beta1 list. I went with not allowing any optional arguments to the constructor, to encourage users of the class to use setters, which makes for more readable code. I deliberated giving it just one argument, but in the end went with the formerly-required arguments. The organizationDomain is not automatically set from the home page with this new usage style, as that only happened in the constructor and not in the setter. It could be set if the organizationDomain has not been explicitly set. However, the organizationDomain is not passed to QCoreApplication as I assumed it would be - it that intentional? Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Diffs - src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117283: Fix i18n in kbuildsycoca5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/ --- Review request for KDE Frameworks. Repository: kservice Description --- Fix i18n in kbuildsycoca5 It should use KI18n, like the rest of KService. Diffs - src/kbuildsycoca/CMakeLists.txt 9ea2d46bd9e4a6bf5e2b5d94759b0740b7f89b69 src/kbuildsycoca/kbuildsycoca.cpp a7799164b4a296ebff849c3d302c197e6aaca437 Diff: https://git.reviewboard.kde.org/r/117283/diff/ Testing --- Builds and installs. Output of kbuildsycoca5 --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117278: Remove KDE4 TODO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/ --- (Updated April 1, 2014, 11:22 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Remove KDE4 TODO This is about scrolling to the first selected size in KFontChooser. As far as I can tell, this happens anyway without the need for an explicit call to QListWidget::scrollToItem(). Diffs - src/kfontchooser.cpp 4fa9699121c9056c58cd35894fd39eb755758a71 Diff: https://git.reviewboard.kde.org/r/117278/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117278: Remove KDE4 TODO
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/#review54761 --- This review has been submitted with commit 2acc257caa5af66822b83ca70dbb20dca7eddc2c by Alex Merry to branch master. - Commit Hook On April 1, 2014, 10:43 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117278/ --- (Updated April 1, 2014, 10:43 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Remove KDE4 TODO This is about scrolling to the first selected size in KFontChooser. As far as I can tell, this happens anyway without the need for an explicit call to QListWidget::scrollToItem(). Diffs - src/kfontchooser.cpp 4fa9699121c9056c58cd35894fd39eb755758a71 Diff: https://git.reviewboard.kde.org/r/117278/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kjs_master_qt5 #32
See http://build.kde.org/job/kjs_master_qt5/32/changes Changes: [vonreth] fixed mingw build -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace http://build.kde.org/job/kjs_master_qt5/ws/ Running Prebuild steps [kjs_master_qt5] $ /bin/sh -xe /tmp/hudson1987074544379264988.sh + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/kjs bdda629..0545f46 master - origin/master Branch jenkins set up to track remote branch master from origin. == Cleaning Source Tree HEAD is now at bdda629 Remove no-longer-needed magic CMake variable Removing build/ Removing dotdata/ Removing install/ Success build forhudson.tasks.Shell@112ce4ea Fetching changes from the remote Git repository Fetching upstream changes from git://anongit.kde.org/kjs Checking out Revision 0545f466ec3466224a777230fe9ae80229661492 (refs/heads/jenkins) Run condition [File exists] enabling prebuild for step [Publish JUnit test result report] Run condition [File exists] enabling prebuild for step [Publish Cppcheck results] [kjs_master_qt5] $ /bin/sh -xe /tmp/hudson1489394071722539155.sh + /home/jenkins/scripts/execute-job.sh KDE Continuous Integration Build == Building Project: kjs - Branch master == Build Dependencies: cmake - Branch master extra-cmake-modules - Branch master qt5 - Branch stable == Applying Patches === No patches to apply == Syncing Dependencies from Master Server == Configuring Build -- The C compiler identification is GNU 4.8.2 -- The CXX compiler identification is GNU 4.8.2 -- Check for working C compiler: /home/jenkins/bin/cc -- Check for working C compiler: /home/jenkins/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /home/jenkins/bin/c++ -- Check for working CXX compiler: /home/jenkins/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Found Perl: /usr/bin/perl (found version 5.16.2) -- Found PkgConfig: /usr/bin/pkg-config (found version 0.27.1) -- Found PCRE: /usr/include -- Looking for include file pthread.h -- Looking for include file pthread.h - found -- Looking for pthread_create -- Looking for pthread_create - not found -- Looking for pthread_create in pthreads -- Looking for pthread_create in pthreads - not found -- Looking for pthread_create in pthread -- Looking for pthread_create in pthread - found -- Found Threads: TRUE -- Looking for pthread_attr_get_np in pthread -- Looking for pthread_attr_get_np in pthread - not found -- Looking for pthread_getattr_np in pthread -- Looking for pthread_getattr_np in pthread - found -- Looking for include file float.h -- Looking for include file float.h - found -- Looking for include file sys/timeb.h -- Looking for include file sys/timeb.h - found -- Looking for include file ieeefp.h -- Looking for include file ieeefp.h - not found -- Looking for include files pthread.h, pthread_np.h -- Looking for include files pthread.h, pthread_np.h - not found -- Looking for include file valgrind/memcheck.h -- Looking for include file valgrind/memcheck.h - not found -- Looking for include file unistd.h -- Looking for include file unistd.h - found -- Looking for include file stdint.h -- Looking for include file stdint.h - found -- Looking for include file sys/time.h -- Looking for include file sys/time.h - found -- Looking for include file errno.h -- Looking for include file errno.h - found -- Looking for include file strings.h -- Looking for include file strings.h - found -- Looking for include file crtdbg.h -- Looking for include file crtdbg.h - not found -- Performing Test HAVE_TM_GMTOFF -- Performing Test HAVE_TM_GMTOFF - Success -- Looking for posix_memalign -- Looking for posix_memalign - found -- Looking for gettimeofday -- Looking for gettimeofday - found -- Performing Test HAVE_FUNC_COPYSIGN -- Performing Test HAVE_FUNC_COPYSIGN - Success -- Performing Test HAVE_FUNC__COPYSIGN -- Performing Test HAVE_FUNC__COPYSIGN - Failed -- Performing Test HAVE_FUNC_SIGNBIT -- Performing Test HAVE_FUNC_SIGNBIT - Failed -- Performing Test HAVE_FUNC___SIGNBIT -- Performing Test HAVE_FUNC___SIGNBIT - Success -- Performing Test HAVE_FUNC_STD_SIGNBIT -- Performing Test HAVE_FUNC_STD_SIGNBIT - Success -- Performing Test HAVE_FUNC__FINITE -- Performing Test HAVE_FUNC__FINITE - Failed -- Performing Test HAVE_FUNC_FINITE -- Performing Test HAVE_FUNC_FINITE - Success -- Performing Test HAVE_FUNC_STD_ISFINITE -- Performing Test HAVE_FUNC_STD_ISFINITE - Success -- Performing Test HAVE_FUNC_ISNAN -- Performing Test HAVE_FUNC_ISNAN - Success -- Performing Test HAVE_FUNC_STD_ISNAN -- Performing Test HAVE_FUNC_STD_ISNAN - Success -- Performing Test HAVE_FUNC_ISINF -- Performing Test HAVE_FUNC_ISINF - Success -- Performing Test
Re: Review Request 117275: Deprecate the catalog name stuff from KAboutData
On April 1, 2014, 10:55 a.m., Aleix Pol Gonzalez wrote: I think it's fine that you add the other one if you prefer people to use setters, but please don't deprecate the old one. There's little reason for doing so, it's very old API and it has always worked as is. Alex Merry wrote: The reason for deprecating the old one is that it forces everyone to set the catalog name, which is useless. The aim is to move everyone away from doing that by KF6. Would the first diff version be more acceptable to you? Yes I think it's better. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/#review54756 --- On April 1, 2014, 10:09 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117275/ --- (Updated April 1, 2014, 10:09 a.m.) Review request for KDE Frameworks, David Faure, Kevin Ottens, and Michael Pyne. Repository: kcoreaddons Description --- This is another thing on the if only we'd spotted it before beta1 list. I went with not allowing any optional arguments to the constructor, to encourage users of the class to use setters, which makes for more readable code. I deliberated giving it just one argument, but in the end went with the formerly-required arguments. The organizationDomain is not automatically set from the home page with this new usage style, as that only happened in the constructor and not in the setter. It could be set if the organizationDomain has not been explicitly set. However, the organizationDomain is not passed to QCoreApplication as I assumed it would be - it that intentional? Deprecate the catalog name stuff from KAboutData This is pretty useless - the translation catalog has to be set before KAboutData is constructed in order to translate its arguments. Diffs - src/lib/kaboutdata.h cff1e3f67e33657fdd265a82166ef2a04cbcc3d1 src/lib/kaboutdata.cpp ce64a13aaa89bb4bc077f05e5f8e175d6a441ead Diff: https://git.reviewboard.kde.org/r/117275/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117283: Fix i18n in kbuildsycoca5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/#review54772 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 11:20 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/ --- (Updated April 1, 2014, 11:20 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Fix i18n in kbuildsycoca5 It should use KI18n, like the rest of KService. Diffs - src/kbuildsycoca/CMakeLists.txt 9ea2d46bd9e4a6bf5e2b5d94759b0740b7f89b69 src/kbuildsycoca/kbuildsycoca.cpp a7799164b4a296ebff849c3d302c197e6aaca437 Diff: https://git.reviewboard.kde.org/r/117283/diff/ Testing --- Builds and installs. Output of kbuildsycoca5 --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
I broke kwin
but I can't fix it? ;) I removed a very old obsolete method from kwindowsystem, then I noticed kwin was still using it, but I can't push the fix? Counting objects: 31, done. Delta compression using up to 8 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 400 bytes | 0 bytes/s, done. Total 4 (delta 3), reused 0 (delta 0) remote: FATAL: W refs/heads/master kde-workspace dfaure DENIED by refs/heads/master remote: error: hook declined to update refs/heads/master To g...@git.kde.org:kde-workspace ! [remote rejected] master - master (hook declined) error: failed to push some refs to 'g...@git.kde.org:kde-workspace' -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: I broke kwin
On Tue, Apr 1, 2014 at 3:01 PM, David Faure fa...@kde.org wrote: but I can't fix it? ;) I removed a very old obsolete method from kwindowsystem, then I noticed kwin was still using it, but I can't push the fix? Kwin was splitted into its own new repository, kde:kwin, the fix should be pushed there, kde-workspace was frozen for master commits (I think). Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: I broke kwin
On Tuesday 01 of April 2014 15:01:20 David Faure wrote: but I can't fix it? ;) I removed a very old obsolete method from kwindowsystem, then I noticed kwin was still using it, but I can't push the fix? [...] To g...@git.kde.org:kde-workspace ! [remote rejected] master - master (hook declined) error: failed to push some refs to 'g...@git.kde.org:kde-workspace' I think because of the split: http://lists.kde.org/?l=kde-develm=139611041905655w=2 Ciao -- Luigi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117296: ecm_create_qm_from_po_files: do not replace - with _ in .po files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Replacing '-' with _ causes problem with .po files whose name contains -. A nice side effect of this approach is we pass a QLocale to QTranslator, which means it will try to load translations for all ui languages [1] instead of just the one returned by QLocale::name(). [1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages Diffs - modules/ECMCreateQmFromPoFiles.cmake b383311 modules/ECMQmLoader.cpp.in 92c0d07 Diff: https://git.reviewboard.kde.org/r/117296/diff/ Testing --- Tested with kbookmarkdialogtest: translations are loaded as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace - with _ in .po files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/#review54776 --- Ship it! Ship It! - Alex Merry On April 1, 2014, 1:16 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/ --- (Updated April 1, 2014, 1:16 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Replacing '-' with _ causes problem with .po files whose name contains -. A nice side effect of this approach is we pass a QLocale to QTranslator, which means it will try to load translations for all ui languages [1] instead of just the one returned by QLocale::name(). [1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages Diffs - modules/ECMCreateQmFromPoFiles.cmake b383311 modules/ECMQmLoader.cpp.in 92c0d07 Diff: https://git.reviewboard.kde.org/r/117296/diff/ Testing --- Tested with kbookmarkdialogtest: translations are loaded as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: I broke kwin
On Tue, Apr 1, 2014 at 3:04 PM, Martin Klapetek martin.klape...@gmail.comwrote: On Tue, Apr 1, 2014 at 3:01 PM, David Faure fa...@kde.org wrote: but I can't fix it? ;) I removed a very old obsolete method from kwindowsystem, then I noticed kwin was still using it, but I can't push the fix? Kwin was splitted into its own new repository, kde:kwin, the fix should be pushed there, kde-workspace was frozen for master commits (I think). Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel Yes, that's exactly what happens. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116568: Fixes to PIC image format handler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/ --- (Updated April 1, 2014, 1:27 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Fixes to PIC image format handler Better error handling (returns false on error in read() and write()) and use the correct format if there is no alpha channel. Diffs - src/imageformats/CMakeLists.txt 44f07dd7bfb7daa1be21ececdfb5061a262e0fc8 src/imageformats/pic.cpp 9d8a7ede31c5c03a699d6a76c88aeb5e3d37ac4a src/imageformats/pic_read.cpp 484c63426723e04e5c7e96ae5355ccceccab03f4 src/imageformats/pic_rw.h 2cc958927403de57049bbd7cb3200f0b7489da3c src/imageformats/pic_write.cpp 0632eebd507e58e480856b53e71c24afc543de26 Diff: https://git.reviewboard.kde.org/r/116568/diff/ Testing --- Builds and tests pass, both with and without https://git.reviewboard.kde.org/r/116567/ applied. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace - with _ in .po files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/ --- (Updated April 1, 2014, 1:38 p.m.) Status -- This change has been marked as submitted. Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Replacing '-' with _ causes problem with .po files whose name contains -. A nice side effect of this approach is we pass a QLocale to QTranslator, which means it will try to load translations for all ui languages [1] instead of just the one returned by QLocale::name(). [1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages Diffs - modules/ECMCreateQmFromPoFiles.cmake b383311 modules/ECMQmLoader.cpp.in 92c0d07 Diff: https://git.reviewboard.kde.org/r/117296/diff/ Testing --- Tested with kbookmarkdialogtest: translations are loaded as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117296: ecm_create_qm_from_po_files: do not replace - with _ in .po files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/#review54778 --- This review has been submitted with commit ddd33b850bb519174511a34eeda40af69a1f7144 by Aurélien Gâteau to branch master. - Commit Hook On April 1, 2014, 1:16 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117296/ --- (Updated April 1, 2014, 1:16 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Repository: extra-cmake-modules Description --- Replacing '-' with _ causes problem with .po files whose name contains -. A nice side effect of this approach is we pass a QLocale to QTranslator, which means it will try to load translations for all ui languages [1] instead of just the one returned by QLocale::name(). [1]: http://doc-snapshot.qt-project.org/qt5-stable/qlocale.html#uiLanguages Diffs - modules/ECMCreateQmFromPoFiles.cmake b383311 modules/ECMQmLoader.cpp.in 92c0d07 Diff: https://git.reviewboard.kde.org/r/117296/diff/ Testing --- Tested with kbookmarkdialogtest: translations are loaded as expected. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
Am Montag, 31. März 2014, 07:30:29 schrieb Aurélien Gâteau: I just committed the necessary build system changes to enable all Qt-translation-based frameworks to build, install and load their translations. Thanks, I see still some problems: solid: solid5 ok, solid-hardware work in progress knotifyconfig: extraction to knotifyconfig5.pot, but catalog apparently not loaded kdesu: extraction to kdesud5.pot, but catalog apparently not loaded kwindowsystem: extraction to kwindowsystem5.pot, but catalog apparently not loaded kpty: extraction to kpty5.pot, but catalog apparently not loaded knewstuff: extraction to knewstuff5.pot, but catalog apparently not loaded kparts5: extraction to kparts5.pot, but catalog apparently not loaded kinit: extraction to kinit5.pot, but catalog apparently not loaded kcmutils: extraction to kcmutils5.pot, but catalog apparently not loaded khtml: extraction to khtml5.pot, but catalog apparently not loaded kdeclarative: extraction to kdeclarative5.pot, but catalog apparently not loaded kservice: extraction to kservice5.pot, but catalog apparently not loaded kde4support: extraction to kdelibs_colors5.pot+kdecalendarsystems5+timezones5, but catalogs apparently not loaded kio/src/kpasswdserver: extraction to kpasswdserver.pot, does KPasswdServerFactory(kpasswdserver) still load the catalog? kconfigwidgets: extraction to kconfigwidgets5.pot, but catalog apparently not loaded kdoctools: extraction to kio_help5.pot, but catalog apparently not loaded to be consistent with the other catalog names this should be kdoctools5 kunitconversion: extraction to kunitconversion5.pot, but catalog apparently not loaded frameworkintegration: extraction to frameworkintegration5.pot, but catalog apparently not loaded kiconthemes: extraction to kiconthemes5.pot, but catalog apparently not loaded kwalletd: extraction to kwalletd5.pot, how is the catalog loaded? kjsembed: extraction to kjsembed5.pot, but catalog apparently not loaded ktextwidgets: extraction to ktextwidgets5.pot, but catalog apparently not loaded ktexteditor: extraction to ktexteditor5.pot, but catalog apparently not loaded kross: extraction to kross5.pot, but catalog apparently not loaded ki18n: extraction to ki18n5.pot, but catalog apparently not loaded knotifications, sonnet, kcoreaddons, kio, kbookmarks, kfileaudiopreview, kcrash, kauth, kdesignerplugin, kjobwidgets, kitemviews, kxmlgui, kglobalaccel, kwidgetsaddons, kcompletion, kdbusaddons, kdnssd, kcodecs5 seem to be OK. Thanks -- Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117268: Deprecate the RESTORE macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/#review54779 --- Ship it! Makes sense to me. You might want to wrap it in a #ifndef KDE_NO_DEPRECATED check though. Ship it from me when wrapped. - Aurélien Gâteau On April 1, 2014, 1:15 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/ --- (Updated April 1, 2014, 1:15 a.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Deprecate the RESTORE macro RESTORE is just a non-typesafe version of kRestoreMainWindows(). Diffs - src/kmainwindow.h 37eed1a37902ce05c12b9288e275757de196639c Diff: https://git.reviewboard.kde.org/r/117268/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117268: Deprecate the RESTORE macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/ --- (Updated April 1, 2014, 2:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kxmlgui Description --- Deprecate the RESTORE macro RESTORE is just a non-typesafe version of kRestoreMainWindows(). Diffs - src/kmainwindow.h 37eed1a37902ce05c12b9288e275757de196639c Diff: https://git.reviewboard.kde.org/r/117268/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117268: Deprecate the RESTORE macro
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/#review54780 --- This review has been submitted with commit 2b9dbeb1d3e43d7c9a6b1caf5036a5f193dc1d6e by Alex Merry to branch master. - Commit Hook On March 31, 2014, 11:15 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117268/ --- (Updated March 31, 2014, 11:15 p.m.) Review request for KDE Frameworks. Repository: kxmlgui Description --- Deprecate the RESTORE macro RESTORE is just a non-typesafe version of kRestoreMainWindows(). Diffs - src/kmainwindow.h 37eed1a37902ce05c12b9288e275757de196639c Diff: https://git.reviewboard.kde.org/r/117268/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117297: Move settings from kde-runtime/doc/api to kapidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Move the settings we used to have in the Doxyfile.local inside kde-runtime/doc/api to kapidox, so we don't miss any warnings now. Diffs - src/Doxyfile.local e2de7c2 Diff: https://git.reviewboard.kde.org/r/117297/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Update Meeting Minutes 2014-w14
Hello everyone, This is the minutes of the Week 14 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, notmart, Riddell, tosky and myself. * afiestas will push the branch with removed interfaces; * he's first making sure no breakage will happen anywhere and will also put some bits in kde4support; * he'll then add async APIs for a couple of classes; * agateau has been working on translation support for tr based frameworks; * he created new script for l10n-kde4 and added Messages.sh scripts where missing; * he also added ecm_create_qm_from_po_files; * alexmerry got the SIC changes he wanted in before beta 1... but found more; * he's still working on removing the kde4 references although at a slower pace; * apol has been moving kde-runtime bits in several frameworks; * he should be all done by the end of this week; * notmart renamed qtextracomponents to kquickcontrolsaddons and adjusted its users; * Riddell still has to sort out the entry.desktop files; * he also got a volunteer working on the kf5options and qtoptions manpages; * he did some co-installing patches, more to come; * tosky is still working on kdoctools; * ervin has been mostly reviewing. If you got questions, feel free to ask. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #226
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/226/changes Changes: [notmart] use buttonBackground color in the css -- [...truncated 574 lines...] Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 22%] Built target corebindingsplugin_automoc [ 22%] [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o [ 23%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformcomponentsplugin_automoc.cpp.o [ 24%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/platformstatusadaptor.cpp.o [ 24%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o [ 24%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 24%] Built target plasma-shell_automoc Linking CXX shared library libcalendarplugin.so Linking CXX shared library libplatformcomponentsplugin.so Scanning dependencies of target KF5Plasma [ 24%] Built target calendarplugin [ 25%] [ 25%] [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o [ 27%] [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o [ 27%] Built target platformcomponentsplugin [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Linking CXX shared module kded_platformstatus.so [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 29%] Built target kded_platformstatus [ 30%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/applet.cpp: In member function ‘virtual void Plasma::Applet::save(KConfigGroup) const’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/applet.cpp:156:38: warning: ‘void KCoreConfigSkeleton::writeConfig()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kconfig/inst/include/KF5/KConfigCore/kcoreconfigskeleton.h:1429) [-Wdeprecated-declarations] d-configLoader-writeConfig(); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44:
Re: Review Request 117283: Fix i18n in kbuildsycoca5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/ --- (Updated April 1, 2014, 2:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kservice Description --- Fix i18n in kbuildsycoca5 It should use KI18n, like the rest of KService. Diffs - src/kbuildsycoca/CMakeLists.txt 9ea2d46bd9e4a6bf5e2b5d94759b0740b7f89b69 src/kbuildsycoca/kbuildsycoca.cpp a7799164b4a296ebff849c3d302c197e6aaca437 Diff: https://git.reviewboard.kde.org/r/117283/diff/ Testing --- Builds and installs. Output of kbuildsycoca5 --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #226
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/226/changes Changes: [notmart] use buttonBackground color in the css -- [...truncated 584 lines...] Linking CXX shared library libplatformcomponentsplugin.so [ 23%] Built target platformcomponentsplugin Scanning dependencies of target KF5Plasma Linking CXX shared library libcalendarplugin.so Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 23%] Built target plasma-shell_automoc [ 24%] [ 24%] [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o [ 25%] [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o [ 26%] Built target calendarplugin [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Linking CXX shared module kded_platformstatus.so [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 28%] Built target kded_platformstatus [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o [ 29%] http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfoForMimeType(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:526:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfoForUrl(const QUrl)’:
Re: Review Request 117283: Fix i18n in kbuildsycoca5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/#review54781 --- This review has been submitted with commit 5e74d463e9222685e1cc264ec9a6862185208c18 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 11:20 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117283/ --- (Updated April 1, 2014, 11:20 a.m.) Review request for KDE Frameworks. Repository: kservice Description --- Fix i18n in kbuildsycoca5 It should use KI18n, like the rest of KService. Diffs - src/kbuildsycoca/CMakeLists.txt 9ea2d46bd9e4a6bf5e2b5d94759b0740b7f89b69 src/kbuildsycoca/kbuildsycoca.cpp a7799164b4a296ebff849c3d302c197e6aaca437 Diff: https://git.reviewboard.kde.org/r/117283/diff/ Testing --- Builds and installs. Output of kbuildsycoca5 --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #227
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/227/changes Changes: [notmart] add a script to fix the definition in the svg -- [...truncated 569 lines...] Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. [ 22%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp Generating moc_tooltipdialog.cpp Generating moc_corebindingsplugin.cpp Generating moc_datamodel.cpp Generating moc_datasource.cpp Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 22%] Built target corebindingsplugin_automoc [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendardata.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o [ 24%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o [ 24%] Built target platformcomponentsplugin Scanning dependencies of target KF5Plasma [ 25%] [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o [ 26%] [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 26%] Built target plasma-shell_automoc [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o Linking CXX shared module kded_platformstatus.so [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o [ 28%] Built target kded_platformstatus [ 28%] Linking CXX shared library libcalendarplugin.so Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o [ 28%] Built target calendarplugin [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 30%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #227
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/227/changes Changes: [notmart] add a script to fix the definition in the svg -- [...truncated 566 lines...] Generating moc_windowthumbnail.cpp [ 21%] Built target corebindingsplugin_automoc [ 22%] [ 22%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/platformstatusadaptor.cpp.o Generating panel.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/panel.cpp:0: Note: No relevant classes found. No output generated. Generating scriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/scriptengine.cpp:0: Note: No relevant classes found. No output generated. Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/declarativeimports/platformcomponents/application.cpp:37:6: warning: unused parameter ‘newState’ [-Wunused-parameter] void Application::Private::stateChanged(QProcess::ProcessState newState) ^ [ 22%] Scanning dependencies of target KF5Plasma Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o [ 23%] [ 24%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/icondialog.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o [ 24%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o [ 24%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformcomponentsplugin_automoc.cpp.o [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o Linking CXX shared library libcalendarplugin.so [ 25%] Built target calendarplugin [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 26%] [ 26%] Built target plasma-shell_automoc [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o Linking CXX shared module kded_platformstatus.so [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 27%] [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Built target kded_platformstatus [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ [ 28%] Built target platformcomponentsplugin http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’:
Re: Review Request 117274: Resurrect the KAboutData for the kross console
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. Changes --- Add context to some of the i18n calls. Summary (updated) - Resurrect the KAboutData for the kross console Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs (updated) - src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117297: Move settings from kde-runtime/doc/api to kapidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/#review54783 --- src/Doxyfile.local https://git.reviewboard.kde.org/r/117297/#comment38262 This is enabled by default already: http://www.stack.nl/~dimitri/doxygen/manual/config.html#cfg_sort_member_docs But SORT_MEMBERS_CTORS_1ST is not enabled by default and would be more interesting IMO. - Aurélien Gâteau On April 1, 2014, 4:19 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/ --- (Updated April 1, 2014, 4:19 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Move the settings we used to have in the Doxyfile.local inside kde-runtime/doc/api to kapidox, so we don't miss any warnings now. Diffs - src/Doxyfile.local e2de7c2 Diff: https://git.reviewboard.kde.org/r/117297/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #228
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/228/changes Changes: [notmart] icons on buttons readable on dark themes -- [...truncated 566 lines...] Generating moc_corebindingsplugin.cpp Generating moc_datamodel.cpp Generating moc_datasource.cpp Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 22%] Built target corebindingsplugin_automoc [ 22%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/declarativeimports/platformcomponents/application.cpp:37:6: warning: unused parameter ‘newState’ [-Wunused-parameter] void Application::Private::stateChanged(QProcess::ProcessState newState) ^ [ 23%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/platformstatusadaptor.cpp.o [ 23%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o [ 24%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o Scanning dependencies of target KF5Plasma [ 25%] Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 25%] [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o Built target plasma-shell_automoc [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o [ 27%] Built target platformcomponentsplugin [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o Linking CXX shared library libcalendarplugin.so [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o [ 28%] Built target calendarplugin [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #228
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/228/changes Changes: [notmart] icons on buttons readable on dark themes -- [...truncated 566 lines...] Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 22%] Built target corebindingsplugin_automoc Generating scriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/scriptengine.cpp:0: Note: No relevant classes found. No output generated. [ 22%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. [ 23%] [ 23%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/icondialog.cpp.o Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o [ 23%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformcomponentsplugin_automoc.cpp.o Scanning dependencies of target KF5Plasma [ 24%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o [ 24%] [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 25%] Built target plasma-shell_automoc [ 26%] Linking CXX shared module kded_platformstatus.so Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o [ 26%] Built target kded_platformstatus [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o Linking CXX shared library libcalendarplugin.so [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 27%] Built target calendarplugin [ 27%] Built target platformcomponentsplugin [ 28%] [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/associatedapplicationmanager.cpp.o [ 30%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/containment_p.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static
Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/ --- Review request for KDE Frameworks. Repository: kio Description --- Resolve a KDE4 TODO in KDesktopFileActions Show an error message when KDesktopFileActions::run() is called with a desktop file that looks like it's an application or runnable service, but KService actually doesn't like it. The comment about the error message already having been shown hasn't been true for around 15 years, as far as I can tell (git commit 7bda6331, svn revision 20718). Diffs - src/widgets/kdesktopfileactions.cpp 686f9f0592473d569d4acbf01a1c8da0ccaf6893 Diff: https://git.reviewboard.kde.org/r/117299/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #229
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/229/changes Changes: [notmart] text areas use textViewColor -- [...truncated 566 lines...] Generating moc_corebindingsplugin.cpp Generating moc_datamodel.cpp Generating moc_datasource.cpp Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 22%] Built target corebindingsplugin_automoc [ 22%] Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. Generating libplasma-theme-global.h, libplasma-theme-global.cpp [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendardata.cpp.o [ 23%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o [ 24%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o Scanning dependencies of target KF5Plasma Linking CXX shared library libplatformcomponentsplugin.so [ 25%] [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o [ 25%] Built target platformcomponentsplugin [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 26%] Built target plasma-shell_automoc [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o Linking CXX shared module kded_platformstatus.so [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o Linking CXX shared library libcalendarplugin.so [ 28%] Built target kded_platformstatus [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o [ 28%] Built target calendarplugin [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 30%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ [ 30%] http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers);
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #229
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/229/changes Changes: [notmart] text areas use textViewColor -- [...truncated 566 lines...] Generating moc_datasource.cpp Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 21%] Built target corebindingsplugin_automoc [ 22%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendar.cpp.o [ 22%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. [ 22%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendardata.cpp.o [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o [ 23%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o Linking CXX shared module kded_platformstatus.so Scanning dependencies of target KF5Plasma [ 24%] [ 24%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 24%] Built target kded_platformstatus [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o [ 25%] Built target platformcomponentsplugin [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 26%] [ 26%] Built target plasma-shell_automoc [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Linking CXX shared library libcalendarplugin.so [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 28%] Built target calendarplugin [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/associatedapplicationmanager.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return
Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #230
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/230/changes Changes: [notmart] fix css -- [...truncated 566 lines...] [ 24%] Generating moc_tooltipdialog.cpp Generating moc_corebindingsplugin.cpp Generating moc_datamodel.cpp Generating moc_datasource.cpp Generating moc_framesvgitem.cpp Generating moc_iconitem.cpp Generating moc_serviceoperationstatus.cpp Generating moc_svgitem.cpp Generating moc_tooltip.cpp Generating moc_units.cpp Generating moc_windowthumbnail.cpp [ 24%] Built target corebindingsplugin_automoc Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/platformstatusadaptor.cpp.o [ 24%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. [ 24%] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o [ 24%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformcomponentsplugin_automoc.cpp.o Scanning dependencies of target KF5Plasma [ 25%] [ 25%] [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o Linking CXX shared library libcalendarplugin.so [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o [ 26%] Built target calendarplugin [ 27%] Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o [ 27%] Built target plasma-shell_automoc [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o [ 28%] Built target platformcomponentsplugin [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Linking CXX shared module kded_platformstatus.so [ 28%] Built target kded_platformstatus [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 30%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o [ 30%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/associatedapplicationmanager.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:258:63: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] engine = new DataEngine(KPluginInfo(offers.first()), 0); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In static member function ‘static KPluginInfo::List Plasma::PluginLoader::listEngineInfoByCategory(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:310:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return KPluginInfo::fromServices(offers); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘KPluginInfo::List Plasma::PluginLoader::listAppletInfo(const QString, const QString)’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=All,label=LINBUILDER/ws/src/plasma/pluginloader.cpp:517:44: warning: ‘static KPluginInfo::List KPluginInfo::fromServices(const List, const KConfigGroup)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:181) [-Wdeprecated-declarations] return
Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #230
See http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/230/changes Changes: [notmart] fix css -- [...truncated 564 lines...] Building CXX object src/platformstatus/CMakeFiles/kded_platformstatus.dir/kded_platformstatus_automoc.cpp.o [ 21%] Built target KF5Plasma_automoc Generating panel.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/panel.cpp:0: Note: No relevant classes found. No output generated. http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/declarativeimports/platformcomponents/application.cpp:37:6: warning: unused parameter ‘newState’ [-Wunused-parameter] void Application::Private::stateChanged(QProcess::ProcessState newState) ^ [ 22%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/daysmodel.cpp.o Generating scriptengine.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/scriptengine.cpp:0: Note: No relevant classes found. No output generated. [ 22%] Building CXX object src/declarativeimports/calendar/CMakeFiles/calendarplugin.dir/calendarplugin_automoc.cpp.o Generating widget.moc http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/shell/scripting/widget.cpp:0: Note: No relevant classes found. No output generated. [ 23%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/icondialog.cpp.o [ 23%] Building CXX object src/declarativeimports/platformcomponents/CMakeFiles/platformcomponentsplugin.dir/platformcomponentsplugin_automoc.cpp.o [ 23%] Generating libplasma-theme-global.h, libplasma-theme-global.cpp Linking CXX shared module kded_platformstatus.so [ 23%] Built target kded_platformstatus Generating moc_shellcorona.cpp Generating moc_activity.cpp Generating moc_interactiveconsole.cpp Generating moc_osd.cpp Generating moc_appinterface.cpp Generating moc_applet.cpp Generating moc_configgroup.cpp Generating moc_containment.cpp Generating moc_desktopscriptengine.cpp Generating moc_panel.cpp Generating moc_scriptengine.cpp Generating moc_widget.cpp Generating moc_shellmanager.cpp [ 23%] Built target plasma-shell_automoc Scanning dependencies of target KF5Plasma [ 24%] [ 24%] [ 25%] [ 25%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/plasma.cpp.o [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/pluginloader.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/componentinstaller.cpp.o [ 26%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/version.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/applet.cpp.o Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/configloader.cpp.o Linking CXX shared library libcalendarplugin.so [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containment.cpp.o [ 27%] Built target calendarplugin [ 27%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/containmentactions.cpp.o Linking CXX shared library libplatformcomponentsplugin.so [ 27%] Built target platformcomponentsplugin [ 28%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/corona.cpp.o [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/applet_p.cpp.o [ 29%] Building CXX object src/plasma/CMakeFiles/KF5Plasma.dir/private/associatedapplicationmanager.cpp.o http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/applet.cpp: In member function ‘virtual void Plasma::Applet::save(KConfigGroup) const’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/applet.cpp:156:38: warning: ‘void KCoreConfigSkeleton::writeConfig()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kconfig/inst/include/KF5/KConfigCore/kcoreconfigskeleton.h:1429) [-Wdeprecated-declarations] d-configLoader-writeConfig(); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/applet.cpp: In member function ‘virtual void Plasma::Applet::configChanged()’: http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/applet.cpp:664:41: warning: ‘void KCoreConfigSkeleton::readConfig()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kconfig/inst/include/KF5/KConfigCore/kcoreconfigskeleton.h:1046) [-Wdeprecated-declarations] d-configLoader-readConfig(); ^ http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/ws/src/plasma/pluginloader.cpp: In member function ‘Plasma::DataEngine* Plasma::PluginLoader::loadDataEngine(const QString)’:
Powerdevil docbooks in kde-workspace/plasma-desktop/doc/kcontrol/
Hi, kde-workspace/plasma-desktop/doc/kcontrol/ (master) has still a subdir powerdevil, this afaik belongs to extragear/base/powerdevil/doc/kcontrol, but I have no idea how to move it properly between different git repos. Btw I'd like to start fixing docbook related issues inside the new kde- workspace repos, any objections? Thanks. -- Burkhard Lück ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix i18n in kross
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54789 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 2:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117297: Move settings from kde-runtime/doc/api to kapidox
On April 1, 2014, 2:53 p.m., Aurélien Gâteau wrote: src/Doxyfile.local, line 9 https://git.reviewboard.kde.org/r/117297/diff/1/?file=262204#file262204line9 This is enabled by default already: http://www.stack.nl/~dimitri/doxygen/manual/config.html#cfg_sort_member_docs But SORT_MEMBERS_CTORS_1ST is not enabled by default and would be more interesting IMO. Well, I can change that, but it's unrelated to the patch then, isn't it? - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/#review54783 --- On April 1, 2014, 2:19 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117297/ --- (Updated April 1, 2014, 2:19 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapidox Description --- Move the settings we used to have in the Doxyfile.local inside kde-runtime/doc/api to kapidox, so we don't miss any warnings now. Diffs - src/Doxyfile.local e2de7c2 Diff: https://git.reviewboard.kde.org/r/117297/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/#review54792 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 3:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/ --- (Updated April 1, 2014, 3:21 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Resolve a KDE4 TODO in KDesktopFileActions Show an error message when KDesktopFileActions::run() is called with a desktop file that looks like it's an application or runnable service, but KService actually doesn't like it. The comment about the error message already having been shown hasn't been true for around 15 years, as far as I can tell (git commit 7bda6331, svn revision 20718). Diffs - src/widgets/kdesktopfileactions.cpp 686f9f0592473d569d4acbf01a1c8da0ccaf6893 Diff: https://git.reviewboard.kde.org/r/117299/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix i18n in kross
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54795 --- This review has been submitted with commit f81033ed266791ac2d9c36fddca1ee3c57eb8ee2 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 2:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/ --- (Updated April 1, 2014, 4:04 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kio Description --- Resolve a KDE4 TODO in KDesktopFileActions Show an error message when KDesktopFileActions::run() is called with a desktop file that looks like it's an application or runnable service, but KService actually doesn't like it. The comment about the error message already having been shown hasn't been true for around 15 years, as far as I can tell (git commit 7bda6331, svn revision 20718). Diffs - src/widgets/kdesktopfileactions.cpp 686f9f0592473d569d4acbf01a1c8da0ccaf6893 Diff: https://git.reviewboard.kde.org/r/117299/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117304: Remove clipboard data re-fetching line and its comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/ --- Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove clipboard data re-fetching line and its comment The comment does not appear to be true. What is more, I cannot see when it was ever true, including in commit 99209e91 where it was introduced. David: can you shed any light on this? Diffs - src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117299: Resolve a KDE4 TODO in KDesktopFileActions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/#review54798 --- This review has been submitted with commit 99055b3b04cd173271e74ac44b0b025656708675 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 3:21 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117299/ --- (Updated April 1, 2014, 3:21 p.m.) Review request for KDE Frameworks. Repository: kio Description --- Resolve a KDE4 TODO in KDesktopFileActions Show an error message when KDesktopFileActions::run() is called with a desktop file that looks like it's an application or runnable service, but KService actually doesn't like it. The comment about the error message already having been shown hasn't been true for around 15 years, as far as I can tell (git commit 7bda6331, svn revision 20718). Diffs - src/widgets/kdesktopfileactions.cpp 686f9f0592473d569d4acbf01a1c8da0ccaf6893 Diff: https://git.reviewboard.kde.org/r/117299/diff/ Testing --- Builds. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix i18n in kross
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 4:02 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix i18n in kross
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54796 --- This review has been submitted with commit b17149e7a97003d69eb221397493e54b437a3d7b by Alex Merry to branch master. - Commit Hook On April 1, 2014, 2:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix i18n in kross
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/#review54797 --- This review has been submitted with commit e7c842103077a647c8b13dafa85c5e1d5b2d84e2 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 2:40 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ --- (Updated April 1, 2014, 2:40 p.m.) Review request for KDE Frameworks. Repository: kross Description --- Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Diffs - src/console/CMakeLists.txt aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2 CMakeLists.txt 5b28a3c210232d9682af43afec9401416b858ca0 src/console/main.cpp f81672e1c15681719943f64698ada19eeebc0bef Diff: https://git.reviewboard.kde.org/r/117274/diff/ Testing --- Ran kf5kross --help. Not investigated how to test the translation stuff. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117304: Remove clipboard data re-fetching line and its comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54803 --- How can you know that it wasn't true? The timer was inside Qt itself. This is about dropping non-URI data onto a file manager and getting the popup how do you want to name the resulting file (to save this data), and by the time you answer the question, the data had been deleted by Qt, so you couldn't save it. I'm not confident about this being removed without at least testing it in KDE4. - David Faure On April 1, 2014, 4:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/ --- (Updated April 1, 2014, 4:01 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove clipboard data re-fetching line and its comment The comment does not appear to be true. What is more, I cannot see when it was ever true, including in commit 99209e91 where it was introduced. David: can you shed any light on this? Diffs - src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated April 1, 2014, 4:31 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Àlex Fiestas. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117160: solid-hardware: rename for co-installability with kdelibs4
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/#review54802 --- submitted in https://git.reviewboard.kde.org/r/117208/ - Hrvoje Senjan On March 31, 2014, 2:44 p.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117160/ --- (Updated March 31, 2014, 2:44 p.m.) Review request for KDE Frameworks and Àlex Fiestas. Repository: solid Description --- kde-runtime4 also installs solid-hardware, so rename it to solid-hardware5 for KF5. Diffs - src/tools/solid-hardware/CMakeLists.txt 7cb604e7bdbee605ecf71e38b050fc8841df8eb9 Diff: https://git.reviewboard.kde.org/r/117160/diff/ Testing --- Built and installed alongside kde-runtime4 Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
On Tue, Apr 1, 2014 at 9:23 PM, Dominik Haumann dhaum...@kde.org wrote: On Monday, March 31, 2014 23:24:09 Albert Astals Cid wrote: El Dilluns, 31 de març de 2014, a les 22:34:21, Dominik Haumann va escriure: On Monday 31 March 2014 17:27:33 Ben Cooksley wrote: On Mon, Mar 31, 2014 at 5:38 AM, Gregor Mi codeminis...@publicstatic.de Ok. Any idea about the qtenginio Could not read from remote repository problem? Do I need special access rights? Or is it possible that the qtenginio repo is offline? This is because the upstream Qt developers have added yet another module to Qt, which wasn't included in our mirror of Qt. Our mirror has now been adjusted to include this new mirror. This is a process which has to be done each time they add a new module. For those wondering why, we maintain a mirror of Qt on the anongit network to ensure that it is always available - at least in the past people have had issues accessing the Gitorious repositories. Hi Ben, then thanks again for fixing it (again). Question though: Could this error be caught earlier, maybe automated? Honestly we should stop suggesting people to build their own Qt and just use 5.2 distro packages. Heh, that would be the most trivial and a working solution. I've no idea if this will actually end up the case, but won't KF 5.1 end up depending on Qt 5.3? ie. this problem is going to come up again once KF 5.0 is released. Looking at the qt list, it might be, that they reconsider to merge all gits into one again which will make tracking easy once again after 5.3. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117304: Remove clipboard data re-fetching line and its comment
On April 1, 2014, 4:28 p.m., David Faure wrote: How can you know that it wasn't true? The timer was inside Qt itself. This is about dropping non-URI data onto a file manager and getting the popup how do you want to name the resulting file (to save this data), and by the time you answer the question, the data had been deleted by Qt, so you couldn't save it. I'm not confident about this being removed without at least testing it in KDE4. The execution appeared to go: get the data from QClipboard, pass it into a function (direct call), which passes it into another function (another direct call), which then re-fetches the data because it reckons the original has been deleted by a QTimer. But we never went back to the event loop in the meantime, so nothing has changed. There also didn't appear to be any QClipboard calls in the meantime that would cause the value returned by QApplication::clipboard()-data() to change. Am I misreading the code? - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54803 --- On April 1, 2014, 4:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/ --- (Updated April 1, 2014, 4:01 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove clipboard data re-fetching line and its comment The comment does not appear to be true. What is more, I cannot see when it was ever true, including in commit 99209e91 where it was introduced. David: can you shed any light on this? Diffs - src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117304: Remove clipboard data re-fetching line and its comment
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54807 --- src/widgets/paste.cpp https://git.reviewboard.kde.org/r/117304/#comment38276 the event loop is here. - David Faure On April 1, 2014, 4:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/ --- (Updated April 1, 2014, 4:01 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove clipboard data re-fetching line and its comment The comment does not appear to be true. What is more, I cannot see when it was ever true, including in commit 99209e91 where it was introduced. David: can you shed any light on this? Diffs - src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)
I've no idea if this will actually end up the case, but won't KF 5.1 end up depending on Qt 5.3? ie. this problem is going to come up again once KF 5.0 is released. Looking at the qt list, it might be, that they reconsider to merge all gits into one again which will make tracking easy once again after 5.3. Ignore me, I hate april fools .P Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117274: Fix i18n in kross
On Tue, Apr 1, 2014 at 6:02 PM, Alex Merry alex.me...@kde.org wrote: This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117274/ This change has been marked as submitted. Review request for KDE Frameworks. By Alex Merry. *Updated April 1, 2014, 4:02 p.m.* *Repository: * kross Description Resurrect the KAboutData for the kross console Use i18n() instead of QCoreApplication::translate() in console app This was probably from copy-pasted command-line parsing code; everything else in this framework uses KI18n. Use the correct translation catalog in the console application Testing Ran kf5kross --help. Not investigated how to test the translation stuff. Diffs - src/console/CMakeLists.txt (aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2) - CMakeLists.txt (5b28a3c210232d9682af43afec9401416b858ca0) - src/console/main.cpp (f81672e1c15681719943f64698ada19eeebc0bef) View Diff https://git.reviewboard.kde.org/r/117274/diff/ FWIW, I've seen that the context being used in drkonqi is: i18nc(@info:shell, ...). Maybe we want to use that, it looks standard. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117304: Remove clipboard data re-fetching line and its comment
On April 1, 2014, 4:58 p.m., David Faure wrote: src/widgets/paste.cpp, line 156 https://git.reviewboard.kde.org/r/117304/diff/1/?file=262229#file262229line156 the event loop is here. Ah, nested event loops, cause of so many issues :-) As far as I can tell, the xcb platform plugin never deletes the mime data, but the windows one might when the clipboard changes. Given that we return early in the function if the clipboard changed while the event loop was running, it should be fine, but I agree that it should be tested. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/#review54807 --- On April 1, 2014, 4:01 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117304/ --- (Updated April 1, 2014, 4:01 p.m.) Review request for KDE Frameworks and David Faure. Repository: kio Description --- Remove clipboard data re-fetching line and its comment The comment does not appear to be true. What is more, I cannot see when it was ever true, including in commit 99209e91 where it was introduced. David: can you shed any light on this? Diffs - src/widgets/paste.cpp 1d1cafca2f494e44f9ba7bd279cefd7df813b9c0 Diff: https://git.reviewboard.kde.org/r/117304/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/#review54813 --- Probably should only try to set the focus if the widget is going to be enabled? - Christoph Feck On April 1, 2014, 10:35 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ --- (Updated April 1, 2014, 10:35 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- KDatePicker: override changeEvent() instead of setEnabled() As the comment noted, setEnabled() is not virtual. Also, there was no need to separately enabled/disable the individual components, when they are children of the KDatePicker widget. Instead, we override changeEvent() and use it to focus the table (as before). This also extends the kdatepicktest to temporarily disable the picker. Diffs - src/kdatepicker.h 855aeb01ff457394cfbcff57845a57a9eae0a103 src/kdatepicker.cpp 345ee2d97632647789e6762e5e155e75802c2191 tests/kdatepicktest.cpp 5f29110f2335bb110b3470007a59f9cb8b6bcfee Diff: https://git.reviewboard.kde.org/r/117277/diff/ Testing --- Builds. Tests pass. Played around with kdatepicktest; behaviour seems unchanged. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/#review54816 --- Ship it! On the other hand, Qt hopefully won't remove the focus from a previous widget, if activating a disabled widget fails. - Christoph Feck On April 1, 2014, 10:35 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ --- (Updated April 1, 2014, 10:35 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- KDatePicker: override changeEvent() instead of setEnabled() As the comment noted, setEnabled() is not virtual. Also, there was no need to separately enabled/disable the individual components, when they are children of the KDatePicker widget. Instead, we override changeEvent() and use it to focus the table (as before). This also extends the kdatepicktest to temporarily disable the picker. Diffs - src/kdatepicker.h 855aeb01ff457394cfbcff57845a57a9eae0a103 src/kdatepicker.cpp 345ee2d97632647789e6762e5e155e75802c2191 tests/kdatepicktest.cpp 5f29110f2335bb110b3470007a59f9cb8b6bcfee Diff: https://git.reviewboard.kde.org/r/117277/diff/ Testing --- Builds. Tests pass. Played around with kdatepicktest; behaviour seems unchanged. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kjs_master_qt5 #33
See http://build.kde.org/job/kjs_master_qt5/33/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Build failed in Jenkins: kio_master_qt5 #142
See http://build.kde.org/job/kio_master_qt5/142/changes Changes: [aiacovitti] Fix setting ssl_was_in_use metadata. -- [...truncated 558 lines...] [ 18%] Automatic moc for target udsentrytest Scanning dependencies of target listdirtest_automoc Generating moc_ktcpsockettest.cpp [ 18%] Automatic moc for target listdirtest [ 18%] Built target ktcpsockettest_automoc Generating knewfilemenutest.moc Scanning dependencies of target upurltest_automoc [ 18%] Built target knewfilemenutest_automoc [ 19%] Automatic moc for target upurltest Scanning dependencies of target httpfiltertest_automoc [ 19%] Automatic moc for target httpfiltertest Generating moc_udsentrytest.cpp [ 19%] Built target udsentrytest_automoc Generating kurlcompletiontest.moc Scanning dependencies of target kioslave-httpauthenticationtest_automoc [ 19%] [ 20%] Generating kurlrequestertest.moc Built target kurlcompletiontest_automoc Automatic moc for target kioslave-httpauthenticationtest [ 20%] Built target kurlrequestertest_automoc Scanning dependencies of target kioslave-httpheaderdispositiontest_automoc Generating upurltest.moc [ 20%] Generating moc_listdirtest.cpp Scanning dependencies of target kioslave-httpheadertokenizetest_automoc Automatic moc for target kioslave-httpheaderdispositiontest [ 20%] [ 20%] Built target upurltest_automoc Built target listdirtest_automoc [ 20%] Automatic moc for target kioslave-httpheadertokenizetest Scanning dependencies of target kioslave-httpobjecttest_automoc [ 21%] Scanning dependencies of target kioslave-kcookiejartest_automoc [ 21%] Automatic moc for target kioslave-httpobjecttest Automatic moc for target kioslave-kcookiejartest Generating moc_httpauthenticationtest.cpp [ 21%] Generating moc_httpheaderdispositiontest.cpp Built target kioslave-httpauthenticationtest_automoc [ 21%] Built target kioslave-httpheaderdispositiontest_automoc Generating moc_httpheadertokenizetest.cpp Scanning dependencies of target kdirlistertest_gui_automoc [ 21%] Built target kioslave-httpheadertokenizetest_automoc [ 21%] Automatic moc for target kdirlistertest_gui Scanning dependencies of target kdirmodeltest_gui_automoc Scanning dependencies of target getalltest_automoc [ 22%] [ 22%] Automatic moc for target getalltest Automatic moc for target kdirmodeltest_gui [ 22%] Built target getalltest_automoc Generating httpfiltertest.moc Generating moc_httpfilter.cpp Scanning dependencies of target kencodingfiledialogtest_gui_automoc [ 22%] [ 22%] Automatic moc for target kencodingfiledialogtest_gui Built target httpfiltertest_automoc [ 22%] Built target kencodingfiledialogtest_gui_automoc Scanning dependencies of target kionetrctest_automoc [ 22%] Generating kcookiejartest.moc Scanning dependencies of target kioslavetest_automoc [ 22%] Built target kioslave-kcookiejartest_automoc [ 22%] Automatic moc for target kionetrctest Automatic moc for target kioslavetest Scanning dependencies of target kmountpoint_debug_automoc [ 22%] Generating moc_kdirlistertest_gui.cpp Built target kionetrctest_automoc [ 22%] [ 22%] Built target kdirlistertest_gui_automoc Automatic moc for target kmountpoint_debug Scanning dependencies of target kopenwithtest_automoc [ 23%] Scanning dependencies of target kpropertiesdialogtest_automoc [ 23%] Automatic moc for target kopenwithtest Automatic moc for target kpropertiesdialogtest [ 23%] [ 23%] Built target kmountpoint_debug_automoc Built target kopenwithtest_automoc Generating kdirmodeltest_gui.moc [ 23%] [ 23%] Built target kpropertiesdialogtest_automoc Generating moc_httpfilter.cpp Generating moc_httpobjecttest.cpp Generating moc_http.cpp Built target kdirmodeltest_gui_automoc Scanning dependencies of target kruntest_automoc Scanning dependencies of target ksycocaupdatetest_automoc [ 23%] [ 23%] Built target kioslave-httpobjecttest_automoc [ 23%] Scanning dependencies of target kurlrequestertest_gui_automoc Automatic moc for target kruntest Scanning dependencies of target listjobtest_automoc Automatic moc for target ksycocaupdatetest Scanning dependencies of target listrecursivetest_automoc [ 23%] [ 24%] [ 24%] Automatic moc for target kurlrequestertest_gui [ 24%] Automatic moc for target listrecursivetest Automatic moc for target listjobtest Built target ksycocaupdatetest_automoc Scanning dependencies of target previewtest_automoc [ 24%] [ 24%] Built target kurlrequestertest_gui_automoc Automatic moc for target previewtest Scanning dependencies of target udsentrybenchmark_automoc [ 24%] Automatic moc for target udsentrybenchmark Generating moc_kioslavetest.cpp [ 24%] Generating moc_kruntest.cpp Built target kioslavetest_automoc [ 24%] Built target kruntest_automoc Generating listrecursivetest.moc [ 24%] [ 24%] Generating listjobtest.moc Generating org.kde.KCookieServer.xml Built target listrecursivetest_automoc [ 24%] Built target listjobtest_automoc [ 25%] Generating org.kde.KCookieServer.xml [ 26%] Generating kcookieserverinterface.cpp, kcookieserverinterface.h
Re: Review Request 117277: KDatePicker: override changeEvent() instead of setEnabled()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/#review54821 --- This review has been submitted with commit d1e542627f907c9512859c0f002210d9bf8b221b by Alex Merry to branch master. - Commit Hook On April 1, 2014, 10:35 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117277/ --- (Updated April 1, 2014, 10:35 a.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- KDatePicker: override changeEvent() instead of setEnabled() As the comment noted, setEnabled() is not virtual. Also, there was no need to separately enabled/disable the individual components, when they are children of the KDatePicker widget. Instead, we override changeEvent() and use it to focus the table (as before). This also extends the kdatepicktest to temporarily disable the picker. Diffs - src/kdatepicker.h 855aeb01ff457394cfbcff57845a57a9eae0a103 src/kdatepicker.cpp 345ee2d97632647789e6762e5e155e75802c2191 tests/kdatepicktest.cpp 5f29110f2335bb110b3470007a59f9cb8b6bcfee Diff: https://git.reviewboard.kde.org/r/117277/diff/ Testing --- Builds. Tests pass. Played around with kdatepicktest; behaviour seems unchanged. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117313: Deprecate ThumbCreatorV2 and improve ThumbCreator apidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117313/ --- Review request for KDE Frameworks. Repository: kio Description --- Improve ThumbCreator apidox Also add a couple of KF6 TODOs Deprecate ThumbCreatorV2 This only existed to add virtual methods to ThumbCreator while keeping binary compatibility. These methods have now been moved into ThumbCreator. Diffs - src/widgets/thumbcreator.h 063ba105cf1dd55f8bfee5ee14e3af8a51276eb7 src/widgets/thumbcreator.cpp 7d3c52bb0f68ce43a11f5b1e732942016be59bf0 Diff: https://git.reviewboard.kde.org/r/117313/diff/ Testing --- Builds and installs, as does kde-runtime (where there is code that implements and makes use of these interfaces). Apidox builds and looks fine. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117314: Improve kross console app i18n
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kross Description --- Improve kross console app i18n Add user interface markers to i18n calls, and change application description a little. Diffs - src/console/main.cpp aba23e2360f76b285db637215d9ac9a273828aa9 Diff: https://git.reviewboard.kde.org/r/117314/diff/ Testing --- Builds, kf5kross --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kservice Description --- [kbuildsycoca] Tidy up command-line parsing and kaboutdata code Including more context (including user interface markers) for i18n calls. Diffs - src/kbuildsycoca/kbuildsycoca.cpp d6b643e7552b2240602696a92a9c85582450b9b9 Diff: https://git.reviewboard.kde.org/r/117315/diff/ Testing --- Builds, kbuildsycoca5 [--help|--author|--license] look sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117316: Bump source-incompatible KDE4 TODO to KF6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/ --- Review request for KDE Frameworks. Repository: kparts Description --- Bump source-incompatible KDE4 TODO to KF6 Diffs - src/browserarguments.h 3d092262af9b374f6fffabbc32cb56d8b3302ab7 Diff: https://git.reviewboard.kde.org/r/117316/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117317: Improve the KAbstractFileItemActionPlugin apidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117317/ --- Review request for KDE Frameworks. Repository: kio Description --- Improve the KAbstractFileItemActionPlugin apidox Diffs - src/widgets/kabstractfileitemactionplugin.h fe4c3d5b3ab49b35f3dd8627245cc8e4bb0fccd3 Diff: https://git.reviewboard.kde.org/r/117317/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117318/ --- Review request for KDE Frameworks. Repository: kcompletion Description --- Move methods from KCompletionPrivate to KCompletionMatchesWrapper, where they actually belong. Diffs - src/kcompletion.cpp 17142f2 src/kcompletion_p.h 1858f23 Diff: https://git.reviewboard.kde.org/r/117318/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Translation support in Qt-translation-based frameworks
El Dimarts, 1 d'abril de 2014, a les 01:07:37, Aurélien Gâteau va escriure: [sinp] To test translations: 1. Generate a .pot file by following those instructions: http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Sy stem s#Testing_your_Messages.sh_script 2. Create a translation file: cd po cp myframework.pot myframework-fr.po (or -de, -es, -pt...) 3. Edit myframework-fr.po with Lokalize or your text editor, translate strings of interest (no need to translate all, this is just for testing) 4. Rerun cmake so that it notices the new po dir (touch CMakeLists.txt should do) 5. Run make and make install 6. Run the code to test, your translations should appear This is really bad compared to our you do it in kde4 which is basically. * Go do l10n-kde4 * Install your language * Done True. It also makes it much harder for translators to test the translations they are working on since they suddenly have to compile the program they are translating instead of just compiling the translation and using the binaries the distro provides. Even in the current state, I think it would still work: distro would ship packages built from tarballs which contain translations, so the code would load any updated translation. In any case, such a testing workflow is broken, IMO: you want to test translations of version N of the app with code of version N, not version N - 1. -1 can be small enough like 4.12.3 vs 4.12.4 that it does not matter. Having said that, it is a problem when testing packages for nightly builds (a much better way to test translations), which I assume are not built from tarballs with translations. There is not such a thing as tarballs with translations at this stage, is there? Of course the frameworks tarballs should include their own translations IMHO but AFAIK this is still not done. Any way we can make the old just compile your l10n-kde4 language and install it way work? The cmake code can be changed to always build the .qm loader. Which code? This way you can build the .qm separately. It would still require the step compile your l10n-kde4 language and install to know that this particular .po needs to be turned into a .qm, not a .mo. Any ideas how to do that? If the .pot contains X-Qt-Contexts: true\n it's quite probable it needs it, the problem for that it's that you're going to need to have the templates folder besides your language folder My understanding is that .po files should still have this, but somehow the few files i found don't seem to have it :S Not sure if it's because maybe they're autogenerated from other .po files Cheers, Albert Aurélien ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117314: Improve kross console app i18n
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/#review54823 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 9:56 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/ --- (Updated April 1, 2014, 9:56 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kross Description --- Improve kross console app i18n Add user interface markers to i18n calls, and change application description a little. Diffs - src/console/main.cpp aba23e2360f76b285db637215d9ac9a273828aa9 Diff: https://git.reviewboard.kde.org/r/117314/diff/ Testing --- Builds, kf5kross --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/#review54824 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 10:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/ --- (Updated April 1, 2014, 10:08 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kservice Description --- [kbuildsycoca] Tidy up command-line parsing and kaboutdata code Including more context (including user interface markers) for i18n calls. Diffs - src/kbuildsycoca/kbuildsycoca.cpp d6b643e7552b2240602696a92a9c85582450b9b9 Diff: https://git.reviewboard.kde.org/r/117315/diff/ Testing --- Builds, kbuildsycoca5 [--help|--author|--license] look sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117318: Move methods from KCompletionPrivate to KCompletionMatchesWrapper
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117318/#review54825 --- Ship it! Looks good to me, and you're the maintainer after all... :) - Aleix Pol Gonzalez On April 1, 2014, 10:37 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117318/ --- (Updated April 1, 2014, 10:37 p.m.) Review request for KDE Frameworks. Repository: kcompletion Description --- Move methods from KCompletionPrivate to KCompletionMatchesWrapper, where they actually belong. Diffs - src/kcompletion.cpp 17142f2 src/kcompletion_p.h 1858f23 Diff: https://git.reviewboard.kde.org/r/117318/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/#review54826 --- Ship it! Ship It! - Aleix Pol Gonzalez On April 1, 2014, 10:14 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/ --- (Updated April 1, 2014, 10:14 p.m.) Review request for KDE Frameworks. Repository: kparts Description --- Bump source-incompatible KDE4 TODO to KF6 Diffs - src/browserarguments.h 3d092262af9b374f6fffabbc32cb56d8b3302ab7 Diff: https://git.reviewboard.kde.org/r/117316/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 117320: Update the kbuildsycoca5 man page
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117320/ --- Review request for KDE Frameworks and David Faure. Repository: kservice Description --- Update the kbuildsycoca5 man page Diffs - docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook dc39386b36c102e8f043b9bd6e9b571c9460ef25 Diff: https://git.reviewboard.kde.org/r/117320/diff/ Testing --- Built and visually inspected the man page. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117314: Improve kross console app i18n
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/ --- (Updated April 1, 2014, 11:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kross Description --- Improve kross console app i18n Add user interface markers to i18n calls, and change application description a little. Diffs - src/console/main.cpp aba23e2360f76b285db637215d9ac9a273828aa9 Diff: https://git.reviewboard.kde.org/r/117314/diff/ Testing --- Builds, kf5kross --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117314: Improve kross console app i18n
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/#review54827 --- This review has been submitted with commit 2b510f9873a8eaafa5610234a6f281e5ed440092 by Alex Merry to branch master. - Commit Hook On April 1, 2014, 9:56 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117314/ --- (Updated April 1, 2014, 9:56 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kross Description --- Improve kross console app i18n Add user interface markers to i18n calls, and change application description a little. Diffs - src/console/main.cpp aba23e2360f76b285db637215d9ac9a273828aa9 Diff: https://git.reviewboard.kde.org/r/117314/diff/ Testing --- Builds, kf5kross --help looks sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/ --- (Updated April 1, 2014, 11:34 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kservice Description --- [kbuildsycoca] Tidy up command-line parsing and kaboutdata code Including more context (including user interface markers) for i18n calls. Diffs - src/kbuildsycoca/kbuildsycoca.cpp d6b643e7552b2240602696a92a9c85582450b9b9 Diff: https://git.reviewboard.kde.org/r/117315/diff/ Testing --- Builds, kbuildsycoca5 [--help|--author|--license] look sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117315: [kbuildsycoca] Tidy up command-line parsing and kaboutdata code
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/#review54828 --- This review has been submitted with commit 3e868952e963604e2d9c0fd398f2fb3452065e2e by Alex Merry to branch master. - Commit Hook On April 1, 2014, 10:08 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117315/ --- (Updated April 1, 2014, 10:08 p.m.) Review request for KDE Frameworks and Aleix Pol Gonzalez. Repository: kservice Description --- [kbuildsycoca] Tidy up command-line parsing and kaboutdata code Including more context (including user interface markers) for i18n calls. Diffs - src/kbuildsycoca/kbuildsycoca.cpp d6b643e7552b2240602696a92a9c85582450b9b9 Diff: https://git.reviewboard.kde.org/r/117315/diff/ Testing --- Builds, kbuildsycoca5 [--help|--author|--license] look sensible. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/ --- (Updated April 1, 2014, 11:35 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kparts Description --- Bump source-incompatible KDE4 TODO to KF6 Diffs - src/browserarguments.h 3d092262af9b374f6fffabbc32cb56d8b3302ab7 Diff: https://git.reviewboard.kde.org/r/117316/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117316: Bump source-incompatible KDE4 TODO to KF6
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/#review54829 --- This review has been submitted with commit a606adb2537d9a63eb6c0f457c2d0521e01195fd by Alex Merry to branch master. - Commit Hook On April 1, 2014, 10:14 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117316/ --- (Updated April 1, 2014, 10:14 p.m.) Review request for KDE Frameworks. Repository: kparts Description --- Bump source-incompatible KDE4 TODO to KF6 Diffs - src/browserarguments.h 3d092262af9b374f6fffabbc32cb56d8b3302ab7 Diff: https://git.reviewboard.kde.org/r/117316/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116037: change entities to reflect new branding
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/ --- (Updated April 1, 2014, 11:43 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard Lück, and Yuri Chornoivan. Repository: kdoctools Description --- -kde; is no longer semantically identified as an acronym, but instead as an organization -new translatable entities for KDE Frameworks are added -new translatable entities for the KDE SC are added -new translatable entities for the various incarnations of Plasma are added with this I can finally kill the temporary entities that have been in kde-runtime.git/doc/fundamentals for over a year now. :-) Diffs - src/customization/en/user.entities 47bfe0d src/customization/entities/general.entities 183fbc9 Diff: https://git.reviewboard.kde.org/r/116037/diff/ Testing --- kdoctools still builds, kate docs still meinproc5 successfully Thanks, T.C. Hollingsworth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116037: change entities to reflect new branding
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review54830 --- This review has been submitted with commit b981a3f02700c197724ebc0f3a0624e5f9fb3a5e by Luigi Toscano on behalf of T.C. Hollingsworth to branch master. - Commit Hook On Feb. 25, 2014, 1:02 a.m., T.C. Hollingsworth wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/ --- (Updated Feb. 25, 2014, 1:02 a.m.) Review request for Documentation, KDE Frameworks, Luigi Toscano, Burkhard Lück, and Yuri Chornoivan. Repository: kdoctools Description --- -kde; is no longer semantically identified as an acronym, but instead as an organization -new translatable entities for KDE Frameworks are added -new translatable entities for the KDE SC are added -new translatable entities for the various incarnations of Plasma are added with this I can finally kill the temporary entities that have been in kde-runtime.git/doc/fundamentals for over a year now. :-) Diffs - src/customization/en/user.entities 47bfe0d src/customization/entities/general.entities 183fbc9 Diff: https://git.reviewboard.kde.org/r/116037/diff/ Testing --- kdoctools still builds, kate docs still meinproc5 successfully Thanks, T.C. Hollingsworth ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build is back to normal : kio_master_qt5 #143
See http://build.kde.org/job/kio_master_qt5/143/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
