Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121098/#review70384
---



src/platformtheme/kdeplatformfiledialoghelper.cpp


Looking at QDialog docs, it says

"modal : bool
This property holds whether show() should pop up the dialog as modal or 
modeless."

So as the modal is being set here, shouldn't the "if (windowModality == 
Qt::NonModal) {" just be removed instead and always call show()?


- Martin Klapetek


On Nov. 10, 2014, 7:17 p.m., Jeremy Whiting wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121098/
> ---
> 
> (Updated Nov. 10, 2014, 7:17 p.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> Before David's astyle commit, the show method used to call m_dialog->exec
> if the window flags weren't nonmodal (i.e. modal dialogs). This got removed 
> somehow.
> BUG:334963
> 
> 
> Diffs
> -
> 
>   src/platformtheme/kdeplatformfiledialoghelper.cpp 
> 44eca192946f0da2b357b33e93a57ef0de05135b 
> 
> Diff: https://git.reviewboard.kde.org/r/121098/diff/
> 
> 
> Testing
> ---
> 
> fifteen puzzle config with patch from 
> https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you 
> choose a file.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/#review70381
---



src/lib/plugin/desktopfileparser.h


Doesn't seem to be used given it's only passed as reference


- Kai Uwe Broulik


On Nov. 14, 2014, 6:08 nachm., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121122/
> ---
> 
> (Updated Nov. 14, 2014, 6:08 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, 
> and Marco Martin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This set of patches moves the code to decode and json-serialize from 
> desktoptojson into its own class, used by the KPluginMetaData(QString file) 
> constructor.
> 
> These functions are not exported, desktoptojson directly includes this class. 
> I've done it this way to avoid littering the API, yet removing as much 
> duplicated code from desktoptojson as possible. These functions have gone 
> into their own class, and made static, since they don't carry state, anyway.
> 
> The purpose of this patch is to allow the package indexer in kpackage (the 
> split-out framework containing Plasma::Package) to create a correct, 
> KPlugin-compatible cache file from package metadata. This patch allows us to 
> just feed a .desktop file into KPluginMetaData and get back correct 
> deserialized KPluginMetaData objects. It allows us to cut out the KService 
> dependency in KPackage.
> 
> In particular, this is split up into the following patches (you can find it 
> in git kcoreaddons[sebas/kpluginmetadata] as well):
> 
> 
> Remove now-duplicated code in desktoptojson
> 
> Use escapeValue, deserializeList and convertToJson from
> desktopfileparser.
> 
> Move the bits to parse .desktop files into its own class
> 
> This encapsulates the desktop file parseing logic into its own class.
> It's fairly self-contained, all static code. This also makes it easier
> to share this code with the desktoptojson binary.
> 
> Allow to read KPluginMetaData from .desktop files
> 
> Move the logic to create a KPluginMetaData object from desktoptojson
> into KPluginMetaData.
> 
> This allows to load metadata from a .desktop file, making it possible to
> load desktop files without going through KPluginInfo (and thus
> KService). This is useful for conversion to json data, which will be
> used to index packages in the KPackage framework for faster lookups,
> similar to the index proof-of-concept for KPluginTrader.
> 
> Add an autotest for loading KPluginMetaData from a .desktop file
> 
> 
> Diffs
> -
> 
>   autotests/data/fakeplugin.desktop PRE-CREATION 
>   autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 
>   src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e 
>   src/desktoptojson/desktoptojson.cpp 
> 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 
>   src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
>   src/lib/plugin/desktopfileparser.h PRE-CREATION 
>   src/lib/plugin/desktopfileparser.cpp PRE-CREATION 
>   src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 
>   src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd 
> 
> Diff: https://git.reviewboard.kde.org/r/121122/diff/
> 
> 
> Testing
> ---
> 
> Added an autotest which compares a KPluginMetaData object created from a 
> desktop file. Also used this code from kpackage.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kio_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kio_stable_qt5] $ /bin/sh -xe /tmp/hudson2074823264439770344.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at e3e4283 cleanup overlay icon usage
Success build forhudson.tasks.Shell@1b545e15
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kio # timeout=10
Fetching upstream changes from git://anongit.kde.org/kio
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kio 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision e3e428375c864d8fb025460110bb1e6e742819d4 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f e3e428375c864d8fb025460110bb1e6e742819d4
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kio_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kio_stable_qt5] $ /bin/sh -xe /tmp/hudson5238950749830809180.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kio - Branch master
== Build Dependencies:
 kdbusaddons - Branch master
 ktextwidgets - Branch master
 sonnet - Branch master
 kcodecs - Branch master
 kbookmarks - Branch master
 dogtail - Branch master
 kxmlgui - Branch master
 cmake - Branch master
 kconfigwidgets - Branch master
 kconfig - Branch master
 kwindowsystem - Branch master
 polkit-qt-1 - Branch master
 solid - Branch master
 karchive - Branch master
 kcrash - Branch master
 kwallet - Branch master
 qt5 - Branch stable
 kcompletion - Branch master
 kjobwidgets - Branch master
 kitemviews - Branch master
 extra-cmake-modules - Branch master
 kcoreaddons - Branch master
 kguiaddons - Branch master
 kiconthemes - Branch master
 kdoctools - Branch master
 attica - Branch master
 kservice - Branch master
 phonon - Branch master
 kwidgetsaddons - Branch master
 kglobalaccel - Branch master
 kauth - Branch master
 ki18n - Branch master
 knotifications - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kwallet/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kio failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdeclarative_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kdeclarative_stable_qt5] $ /bin/sh -xe /tmp/hudson5635768532837703812.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 52d1447 Port away from deprecated API
Success build forhudson.tasks.Shell@50c8be49
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kdeclarative # timeout=10
Fetching upstream changes from git://anongit.kde.org/kdeclarative
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kdeclarative 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 52d14472f3237cbfc0a72e85270b6b30ea0a57e2 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 52d14472f3237cbfc0a72e85270b6b30ea0a57e2
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kdeclarative_stable_qt5-1 # 
 > timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kdeclarative_stable_qt5] $ /bin/sh -xe /tmp/hudson9164157284282962294.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kdeclarative - Branch master
== Build Dependencies:
 kdbusaddons - Branch master
 kcoreaddons - Branch master
 kjobwidgets - Branch master
 ki18n - Branch master
 kio - Branch master
 dogtail - Branch master
 polkit-qt-1 - Branch master
 kcodecs - Branch master
 karchive - Branch master
 kxmlgui - Branch master
 kwallet - Branch master
 qt5 - Branch stable
 kconfigwidgets - Branch master
 kglobalaccel - Branch master
 ktextwidgets - Branch master
 kcompletion - Branch master
 solid - Branch master
 kguiaddons - Branch master
 kconfig - Branch master
 sonnet - Branch master
 kdoctools - Branch master
 kservice - Branch master
 kcrash - Branch master
 attica - Branch master
 cmake - Branch master
 kitemviews - Branch master
 kauth - Branch master
 kiconthemes - Branch master
 extra-cmake-modules - Branch master
 kwindowsystem - Branch master
 knotifications - Branch master
 kbookmarks - Branch master
 kwidgetsaddons - Branch master
 phonon - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kio/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kdeclarative failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/
---

(Updated Nov. 14, 2014, 6:08 p.m.)


Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, 
and Marco Martin.


Changes
---

Described testing


Repository: kcoreaddons


Description
---

This set of patches moves the code to decode and json-serialize from 
desktoptojson into its own class, used by the KPluginMetaData(QString file) 
constructor.

These functions are not exported, desktoptojson directly includes this class. 
I've done it this way to avoid littering the API, yet removing as much 
duplicated code from desktoptojson as possible. These functions have gone into 
their own class, and made static, since they don't carry state, anyway.

The purpose of this patch is to allow the package indexer in kpackage (the 
split-out framework containing Plasma::Package) to create a correct, 
KPlugin-compatible cache file from package metadata. This patch allows us to 
just feed a .desktop file into KPluginMetaData and get back correct 
deserialized KPluginMetaData objects. It allows us to cut out the KService 
dependency in KPackage.

In particular, this is split up into the following patches (you can find it in 
git kcoreaddons[sebas/kpluginmetadata] as well):


Remove now-duplicated code in desktoptojson

Use escapeValue, deserializeList and convertToJson from
desktopfileparser.

Move the bits to parse .desktop files into its own class

This encapsulates the desktop file parseing logic into its own class.
It's fairly self-contained, all static code. This also makes it easier
to share this code with the desktoptojson binary.

Allow to read KPluginMetaData from .desktop files

Move the logic to create a KPluginMetaData object from desktoptojson
into KPluginMetaData.

This allows to load metadata from a .desktop file, making it possible to
load desktop files without going through KPluginInfo (and thus
KService). This is useful for conversion to json data, which will be
used to index packages in the KPackage framework for faster lookups,
similar to the index proof-of-concept for KPluginTrader.

Add an autotest for loading KPluginMetaData from a .desktop file


Diffs
-

  autotests/data/fakeplugin.desktop PRE-CREATION 
  autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 
  src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e 
  src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 
  src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
  src/lib/plugin/desktopfileparser.h PRE-CREATION 
  src/lib/plugin/desktopfileparser.cpp PRE-CREATION 
  src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 
  src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd 

Diff: https://git.reviewboard.kde.org/r/121122/diff/


Testing (updated)
---

Added an autotest which compares a KPluginMetaData object created from a 
desktop file. Also used this code from kpackage.


Thanks,

Sebastian Kügler

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kded_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kded_stable_qt5] $ /bin/sh -xe /tmp/hudson7332514265097133915.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 810b56b Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@723c940b
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kded # timeout=10
Fetching upstream changes from git://anongit.kde.org/kded
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kded 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 810b56b806aa7c30337495c52d601b1782bf07ca 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 810b56b806aa7c30337495c52d601b1782bf07ca
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kded_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kded_stable_qt5] $ /bin/sh -xe /tmp/hudson2514418031168980314.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kded - Branch master
== Build Dependencies:
 cmake - Branch master
 kwindowsystem - Branch master
 kguiaddons - Branch master
 kcodecs - Branch master
 kbookmarks - Branch master
 dogtail - Branch master
 kxmlgui - Branch master
 kdbusaddons - Branch master
 kconfigwidgets - Branch master
 kio - Branch master
 ktextwidgets - Branch master
 polkit-qt-1 - Branch master
 solid - Branch master
 karchive - Branch master
 kconfig - Branch master
 kwallet - Branch master
 qt5 - Branch stable
 kcompletion - Branch master
 kjobwidgets - Branch master
 kcoreaddons - Branch master
 extra-cmake-modules - Branch master
 kitemviews - Branch master
 kiconthemes - Branch master
 kdoctools - Branch master
 kglobalaccel - Branch master
 attica - Branch master
 kcrash - Branch master
 kservice - Branch master
 phonon - Branch master
 kwidgetsaddons - Branch master
 kinit - Branch master
 sonnet - Branch master
 kauth - Branch master
 ki18n - Branch master
 knotifications - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kio/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kded failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kwallet_stable_qt5 #2

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kwallet_stable_qt5] $ /bin/sh -xe /tmp/hudson737622523617245981.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 08459cf use correct ki18n_wrap_ui in ki18n based 
frameworks/kwallet
Success build forhudson.tasks.Shell@31439a80
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kwallet # timeout=10
Fetching upstream changes from git://anongit.kde.org/kwallet
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kwallet 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 08459cfa3ceda9a8a68fdead4e9208309bd4d12f 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 08459cfa3ceda9a8a68fdead4e9208309bd4d12f
 > git rev-list 08459cfa3ceda9a8a68fdead4e9208309bd4d12f # timeout=10
 > git tag -a -f -m Jenkins Build #2 jenkins-kwallet_stable_qt5-2 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kwallet_stable_qt5] $ /bin/sh -xe /tmp/hudson5163885046646772134.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kwallet - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kcrash - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 kdbusaddons - Branch master
 kconfig - Branch master
 kwindowsystem - Branch master
 kcoreaddons - Branch master
 karchive - Branch master
 dogtail - Branch master
 cmake - Branch master
 qt5 - Branch stable
 polkit-qt-1 - Branch master
 extra-cmake-modules - Branch master
 kitemviews - Branch master
 kservice - Branch master
 kiconthemes - Branch master
 kguiaddons - Branch master
 kdoctools - Branch master
 phonon - Branch master
 knotifications - Branch master
 ki18n - Branch master
 kwidgetsaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/kdesupport/phonon/phonon/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kwallet failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121122: Allow loading KPluginMetaData from a .desktop file

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121122/
---

Review request for KDE Frameworks, Plasma, Alexander Richardson, David Faure, 
and Marco Martin.


Repository: kcoreaddons


Description
---

This set of patches moves the code to decode and json-serialize from 
desktoptojson into its own class, used by the KPluginMetaData(QString file) 
constructor.

These functions are not exported, desktoptojson directly includes this class. 
I've done it this way to avoid littering the API, yet removing as much 
duplicated code from desktoptojson as possible. These functions have gone into 
their own class, and made static, since they don't carry state, anyway.

The purpose of this patch is to allow the package indexer in kpackage (the 
split-out framework containing Plasma::Package) to create a correct, 
KPlugin-compatible cache file from package metadata. This patch allows us to 
just feed a .desktop file into KPluginMetaData and get back correct 
deserialized KPluginMetaData objects. It allows us to cut out the KService 
dependency in KPackage.

In particular, this is split up into the following patches (you can find it in 
git kcoreaddons[sebas/kpluginmetadata] as well):


Remove now-duplicated code in desktoptojson

Use escapeValue, deserializeList and convertToJson from
desktopfileparser.

Move the bits to parse .desktop files into its own class

This encapsulates the desktop file parseing logic into its own class.
It's fairly self-contained, all static code. This also makes it easier
to share this code with the desktoptojson binary.

Allow to read KPluginMetaData from .desktop files

Move the logic to create a KPluginMetaData object from desktoptojson
into KPluginMetaData.

This allows to load metadata from a .desktop file, making it possible to
load desktop files without going through KPluginInfo (and thus
KService). This is useful for conversion to json data, which will be
used to index packages in the KPackage framework for faster lookups,
similar to the index proof-of-concept for KPluginTrader.

Add an autotest for loading KPluginMetaData from a .desktop file


Diffs
-

  autotests/data/fakeplugin.desktop PRE-CREATION 
  autotests/kpluginmetadatatest.cpp a1aaf80c8a5e25c2ae031a80fd1f8f96fa5924a0 
  src/desktoptojson/CMakeLists.txt c2d2b8780ab6cb34686bc7a43a3b6d4eaeb12b1e 
  src/desktoptojson/desktoptojson.cpp 3f0cfb129730cf7ba8adbf9c331d967f8a04d4e8 
  src/lib/CMakeLists.txt 1dc56270ab5157af706b7745cfa88ae11e16184a 
  src/lib/plugin/desktopfileparser.h PRE-CREATION 
  src/lib/plugin/desktopfileparser.cpp PRE-CREATION 
  src/lib/plugin/kpluginmetadata.h 67b68a50225e8ac82706caa849fb330567cee1d2 
  src/lib/plugin/kpluginmetadata.cpp f3e68c927370ad9212e8dfc07677ec17c52fdbdd 

Diff: https://git.reviewboard.kde.org/r/121122/diff/


Testing
---


Thanks,

Sebastian Kügler

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kxmlgui_stable_qt5 #3

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : ktextwidgets_stable_qt5 #3

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktextwidgets_stable_qt5 #2

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[ktextwidgets_stable_qt5] $ /bin/sh -xe /tmp/hudson3836507238019937001.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at fb7d6d0 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@697768ad
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/ktextwidgets # timeout=10
Fetching upstream changes from git://anongit.kde.org/ktextwidgets
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/ktextwidgets 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision fb7d6d09c5e2c4156138d9dd5b897881225cfe41 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fb7d6d09c5e2c4156138d9dd5b897881225cfe41
 > git rev-list fb7d6d09c5e2c4156138d9dd5b897881225cfe41 # timeout=10
 > git tag -a -f -m Jenkins Build #2 jenkins-ktextwidgets_stable_qt5-2 # 
 > timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[ktextwidgets_stable_qt5] $ /bin/sh -xe /tmp/hudson1665638497189530178.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: ktextwidgets - Branch master
== Build Dependencies:
 kdbusaddons - Branch master
 ki18n - Branch master
 kconfig - Branch master
 dogtail - Branch master
 cmake - Branch master
 kcodecs - Branch master
 karchive - Branch master
 qt5 - Branch stable
 kconfigwidgets - Branch master
 kcompletion - Branch master
 kguiaddons - Branch master
 kcrash - Branch master
 sonnet - Branch master
 kdoctools - Branch master
 kitemviews - Branch master
 kcoreaddons - Branch master
 kauth - Branch master
 kiconthemes - Branch master
 kwidgetsaddons - Branch master
 polkit-qt-1 - Branch master
 kwindowsystem - Branch master
 kservice - Branch master
 extra-cmake-modules - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kiconthemes/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project ktextwidgets failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kxmlgui_stable_qt5 #2

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kxmlgui_stable_qt5] $ /bin/sh -xe /tmp/hudson6012437445399332985.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 6f854d9 restore KStandardGuiItems
Success build forhudson.tasks.Shell@1b57e111
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kxmlgui # timeout=10
Fetching upstream changes from git://anongit.kde.org/kxmlgui
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kxmlgui 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 6f854d90e4ff52771887315cd1fcb598944fc3fe 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 6f854d90e4ff52771887315cd1fcb598944fc3fe
 > git rev-list 6f854d90e4ff52771887315cd1fcb598944fc3fe # timeout=10
 > git tag -a -f -m Jenkins Build #2 jenkins-kxmlgui_stable_qt5-2 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kxmlgui_stable_qt5] $ /bin/sh -xe /tmp/hudson5749792904824237555.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kxmlgui - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kcrash - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 kconfig - Branch master
 kwindowsystem - Branch master
 kitemviews - Branch master
 karchive - Branch master
 kcoreaddons - Branch master
 sonnet - Branch master
 kdbusaddons - Branch master
 qt5 - Branch stable
 kguiaddons - Branch master
 ktextwidgets - Branch master
 cmake - Branch master
 kwidgetsaddons - Branch master
 kglobalaccel - Branch master
 kiconthemes - Branch master
 kdoctools - Branch master
 dogtail - Branch master
 kcompletion - Branch master
 kservice - Branch master
 ki18n - Branch master
 polkit-qt-1 - Branch master
 extra-cmake-modules - Branch master
 attica - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/ktextwidgets/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kxmlgui failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdesignerplugin_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kdesignerplugin_stable_qt5] $ /bin/sh -xe /tmp/hudson4208139168714496513.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at faac68a Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@657a25fd
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kdesignerplugin # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/kdesignerplugin
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kdesignerplugin 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision faac68a285376a8d27827bdcb3e3ef4f7074398b 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f faac68a285376a8d27827bdcb3e3ef4f7074398b
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kdesignerplugin_stable_qt5-1 # 
 > timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kdesignerplugin_stable_qt5] $ /bin/sh -xe /tmp/hudson8432740598350045885.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kdesignerplugin - Branch master
== Build Dependencies:
 kdbusaddons - Branch master
 kjobwidgets - Branch master
 ki18n - Branch master
 kio - Branch master
 dogtail - Branch master
 polkit-qt-1 - Branch master
 kcodecs - Branch master
 kxmlgui - Branch master
 karchive - Branch master
 kcrash - Branch master
 kwallet - Branch master
 qt5 - Branch stable
 kconfigwidgets - Branch master
 kitemviews - Branch master
 kwindowsystem - Branch master
 kcompletion - Branch master
 kcoreaddons - Branch master
 solid - Branch master
 kglobalaccel - Branch master
 kconfig - Branch master
 kdewebkit - Branch master
 kparts - Branch master
 kservice - Branch master
 kdoctools - Branch master
 kplotting - Branch master
 attica - Branch master
 cmake - Branch master
 kguiaddons - Branch master
 kauth - Branch master
 kiconthemes - Branch master
 extra-cmake-modules - Branch master
 ktextwidgets - Branch master
 sonnet - Branch master
 knotifications - Branch master
 phonon - Branch master
 kbookmarks - Branch master
 kwidgetsaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kio/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kdesignerplugin failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kwallet_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kwallet_stable_qt5] $ /bin/sh -xe /tmp/hudson518680326911595743.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 08459cf use correct ki18n_wrap_ui in ki18n based 
frameworks/kwallet
Success build forhudson.tasks.Shell@31439a80
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kwallet # timeout=10
Fetching upstream changes from git://anongit.kde.org/kwallet
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kwallet 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 08459cfa3ceda9a8a68fdead4e9208309bd4d12f 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 08459cfa3ceda9a8a68fdead4e9208309bd4d12f
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kwallet_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kwallet_stable_qt5] $ /bin/sh -xe /tmp/hudson6403868123137254848.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kwallet - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kcrash - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 kdbusaddons - Branch master
 kconfig - Branch master
 kitemviews - Branch master
 kwindowsystem - Branch master
 kguiaddons - Branch master
 karchive - Branch master
 dogtail - Branch master
 cmake - Branch master
 qt5 - Branch stable
 polkit-qt-1 - Branch master
 extra-cmake-modules - Branch master
 kcoreaddons - Branch master
 kservice - Branch master
 kiconthemes - Branch master
 kdoctools - Branch master
 phonon - Branch master
 knotifications - Branch master
 ki18n - Branch master
 kwidgetsaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kconfigwidgets/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kwallet failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_stable_qt5 » NoX11,LINBUILDER #1

[KDE CI System]

See 


--
Started by upstream project "plasma-framework_stable_qt5" build number 1
originally caused by:
 Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[LINBUILDER] $ /bin/sh -xe /tmp/hudson2986589392087294869.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 0e13fb9 SVN_SILENT made messages (.desktop file)
Success build forhudson.tasks.Shell@7ca7bdea
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-framework.git # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-framework.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision 0e13fb9833ebf443efd6ebc35fca92638413b133 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0e13fb9833ebf443efd6ebc35fca92638413b133
First time build. Skipping changelog.
[LINBUILDER] $ /bin/sh -xe /tmp/hudson1978034257343496793.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kio - Branch master
 kbookmarks - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 kidletime - Branch master
 kconfig - Branch master
 kross - Branch master
 ktexteditor - Branch master
 kwindowsystem - Branch master
 solid - Branch master
 kglobalaccel - Branch master
 karchive - Branch master
 phonon - Branch master
 sonnet - Branch master
 kdbusaddons - Branch master
 qt5 - Branch stable
 kdeclarative - Branch master
 kactivities - Branch master
 kitemmodels - Branch master
 libgit2 - Branch master
 cmake - Branch master
 kjobwidgets - Branch master
 kdoctools - Branch master
 kwidgetsaddons - Branch master
 kguiaddons - Branch master
 kparts - Branch master
 ktextwidgets - Branch master
 kservice - Branch master
 kwallet - Branch master
 kiconthemes - Branch master
 kcmutils - Branch master
 kcrash - Branch master
 kjs - Branch master
 attica - Branch master
 kcompletion - Branch master
 knotifications - Branch master
 kxmlgui - Branch master
 kitemviews - Branch master
 threadweaver - Branch master
 kdnssd - Branch master
 kcoreaddons - Branch master
 ki18n - Branch master
 polkit-qt-1 - Branch master
 extra-cmake-modules - Branch master
 dogtail - Branch master
 kunitconversion - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kio/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-framework failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception
hudson.AbortException: No test report files were found. Configuration error?
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:110)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:86)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2665)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to LinuxSlave - 4(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)

Build failed in Jenkins: kdewebkit_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kdewebkit_stable_qt5] $ /bin/sh -xe /tmp/hudson3882898018674839896.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 9872800 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@bc0f99c
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kdewebkit # timeout=10
Fetching upstream changes from git://anongit.kde.org/kdewebkit
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kdewebkit 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 9872800f66ff221614ee04921a4b03dc9198c624 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 9872800f66ff221614ee04921a4b03dc9198c624
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kdewebkit_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kdewebkit_stable_qt5] $ /bin/sh -xe /tmp/hudson4661932903600747844.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kdewebkit - Branch master
== Build Dependencies:
 kdbusaddons - Branch master
 ki18n - Branch master
 kio - Branch master
 dogtail - Branch master
 cmake - Branch master
 kcodecs - Branch master
 karchive - Branch master
 kxmlgui - Branch master
 kguiaddons - Branch master
 kcrash - Branch master
 kwallet - Branch master
 qt5 - Branch stable
 kconfigwidgets - Branch master
 ktextwidgets - Branch master
 kcompletion - Branch master
 kcoreaddons - Branch master
 solid - Branch master
 kitemviews - Branch master
 kconfig - Branch master
 sonnet - Branch master
 kparts - Branch master
 kservice - Branch master
 kdoctools - Branch master
 attica - Branch master
 kjobwidgets - Branch master
 kglobalaccel - Branch master
 kauth - Branch master
 kiconthemes - Branch master
 extra-cmake-modules - Branch master
 polkit-qt-1 - Branch master
 kwindowsystem - Branch master
 knotifications - Branch master
 phonon - Branch master
 kbookmarks - Branch master
 kwidgetsaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kio/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kdewebkit failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: plasma-framework_stable_qt5 » All,LINBUILDER #1

[KDE CI System]

See 


--
Started by upstream project "plasma-framework_stable_qt5" build number 1
originally caused by:
 Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[LINBUILDER] $ /bin/sh -xe /tmp/hudson2682949658133892304.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 0e13fb9 SVN_SILENT made messages (.desktop file)
Success build forhudson.tasks.Shell@7ca7bdea
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-framework.git # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/plasma-framework.git
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/plasma-framework.git 
 > +refs/heads/*:refs/remotes/origin/*
Checking out Revision 0e13fb9833ebf443efd6ebc35fca92638413b133 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0e13fb9833ebf443efd6ebc35fca92638413b133
First time build. Skipping changelog.
[LINBUILDER] $ /bin/sh -xe /tmp/hudson4488475757748169792.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-framework - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kio - Branch master
 kbookmarks - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 kdbusaddons - Branch master
 kconfig - Branch master
 ktexteditor - Branch master
 ktextwidgets - Branch master
 solid - Branch master
 kguiaddons - Branch master
 karchive - Branch master
 libgit2 - Branch master
 sonnet - Branch master
 kidletime - Branch master
 qt5 - Branch stable
 kross - Branch master
 kdeclarative - Branch master
 kitemmodels - Branch master
 cmake - Branch master
 kjobwidgets - Branch master
 kcmutils - Branch master
 kwidgetsaddons - Branch master
 kcoreaddons - Branch master
 threadweaver - Branch master
 phonon - Branch master
 kservice - Branch master
 kwallet - Branch master
 kiconthemes - Branch master
 kcrash - Branch master
 kitemviews - Branch master
 kjs - Branch master
 attica - Branch master
 kcompletion - Branch master
 kdoctools - Branch master
 knotifications - Branch master
 kwindowsystem - Branch master
 kxmlgui - Branch master
 kactivities - Branch master
 kdnssd - Branch master
 ki18n - Branch master
 polkit-qt-1 - Branch master
 extra-cmake-modules - Branch master
 kparts - Branch master
 dogtail - Branch master
 kglobalaccel - Branch master
 kunitconversion - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kio/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-framework failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Recording test results
ERROR: Publisher hudson.tasks.junit.JUnitResultArchiver aborted due to exception
hudson.AbortException: No test report files were found. Configuration error?
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:110)
at 
hudson.tasks.junit.JUnitParser$ParseResultCallable.invoke(JUnitParser.java:86)
at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2665)
at hudson.remoting.UserRequest.perform(UserRequest.java:121)
at hudson.remoting.UserRequest.perform(UserRequest.java:49)
at hudson.remoting.Request$2.run(Request.java:324)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
at ..remote call to LinuxSlave - 4(Native Method)
at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1356)
at hudson.remoting.UserResponse.retrieve(UserRequest.java:221)

Build failed in Jenkins: ktextwidgets_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[ktextwidgets_stable_qt5] $ /bin/sh -xe /tmp/hudson5396000486650052795.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at fb7d6d0 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@697768ad
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/ktextwidgets # timeout=10
Fetching upstream changes from git://anongit.kde.org/ktextwidgets
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/ktextwidgets 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision fb7d6d09c5e2c4156138d9dd5b897881225cfe41 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fb7d6d09c5e2c4156138d9dd5b897881225cfe41
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-ktextwidgets_stable_qt5-1 # 
 > timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[ktextwidgets_stable_qt5] $ /bin/sh -xe /tmp/hudson926489746946527468.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: ktextwidgets - Branch master
== Build Dependencies:
 kdbusaddons - Branch master
 ki18n - Branch master
 kconfig - Branch master
 dogtail - Branch master
 polkit-qt-1 - Branch master
 kcodecs - Branch master
 karchive - Branch master
 qt5 - Branch stable
 kconfigwidgets - Branch master
 kcompletion - Branch master
 kcoreaddons - Branch master
 kdoctools - Branch master
 sonnet - Branch master
 kguiaddons - Branch master
 kcrash - Branch master
 cmake - Branch master
 kitemviews - Branch master
 kauth - Branch master
 kiconthemes - Branch master
 extra-cmake-modules - Branch master
 kwindowsystem - Branch master
 kservice - Branch master
 kwidgetsaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kconfigwidgets/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project ktextwidgets failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kxmlgui_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kxmlgui_stable_qt5] $ /bin/sh -xe /tmp/hudson622838932430345692.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 6f854d9 restore KStandardGuiItems
Success build forhudson.tasks.Shell@1b57e111
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kxmlgui # timeout=10
Fetching upstream changes from git://anongit.kde.org/kxmlgui
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kxmlgui 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 6f854d90e4ff52771887315cd1fcb598944fc3fe 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 6f854d90e4ff52771887315cd1fcb598944fc3fe
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kxmlgui_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kxmlgui_stable_qt5] $ /bin/sh -xe /tmp/hudson7127846972982709405.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kxmlgui - Branch master
== Build Dependencies:
 kcodecs - Branch master
 kcrash - Branch master
 kauth - Branch master
 kconfigwidgets - Branch master
 kconfig - Branch master
 kglobalaccel - Branch master
 kwindowsystem - Branch master
 kguiaddons - Branch master
 karchive - Branch master
 sonnet - Branch master
 kdbusaddons - Branch master
 qt5 - Branch stable
 ktextwidgets - Branch master
 polkit-qt-1 - Branch master
 cmake - Branch master
 kwidgetsaddons - Branch master
 kcoreaddons - Branch master
 kitemviews - Branch master
 kiconthemes - Branch master
 kdoctools - Branch master
 dogtail - Branch master
 kcompletion - Branch master
 kservice - Branch master
 ki18n - Branch master
 extra-cmake-modules - Branch master
 attica - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kconfigwidgets/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kxmlgui failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kunitconversion_stable_qt5 #2

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kservice_stable_qt5 #1

[KDE CI System]

See 

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kservice_stable_qt5] $ /bin/sh -xe /tmp/hudson2028836930091301447.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 3239a31 Don't access invalid KPluginInfo objects
Success build forhudson.tasks.Shell@7f1a0929
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kservice # timeout=10
Fetching upstream changes from git://anongit.kde.org/kservice
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kservice 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 3239a3158816770d8cb2c4987fcc535c7a49108d 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 3239a3158816770d8cb2c4987fcc535c7a49108d
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kservice_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kservice_stable_qt5] $ /bin/sh -xe /tmp/hudson3007157236370610512.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kservice - Branch master
== Build Dependencies:
 kcrash - Branch master
 extra-cmake-modules - Branch master
 kcoreaddons - Branch master
 ki18n - Branch master
 dogtail - Branch master
 qt5 - Branch stable
 cmake - Branch master
 kdbusaddons - Branch master
 kconfig - Branch master
 kdoctools - Branch master
 karchive - Branch master
 kwindowsystem - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kconfig/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kservice failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

About the _stable_ jenkins jobs

[Albert Astals Cid]

Yes, there's no frameworks stable branch, but our current jenkins setup (which 
hopefully will change in this SoK) is that if we want to have a 
kalgebra_stable_qt5 build, we need stable_qt5 builds for all it's 
dependencies, so i'm building all the frameworks with a stable_qt5 build that 
also tracks master.

Cheers,
  Albert
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kauth_stable_qt5 #2

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kcrash_stable_qt5 #2

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kunitconversion_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kunitconversion_stable_qt5] $ /bin/sh -xe /tmp/hudson1815670749833368400.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at c463327 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@24e0ed77
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kunitconversion # 
 > timeout=10
Fetching upstream changes from git://anongit.kde.org/kunitconversion
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kunitconversion 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision c4633273904b5993e29f224e4d66e279764f0c79 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f c4633273904b5993e29f224e4d66e279764f0c79
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kunitconversion_stable_qt5-1 # 
 > timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kunitconversion_stable_qt5] $ /bin/sh -xe /tmp/hudson3874683841862986371.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kunitconversion - Branch master
== Build Dependencies:
 qt5 - Branch stable
 ki18n - Branch master
 kconfig - Branch master
 dogtail - Branch master
 cmake - Branch master
 extra-cmake-modules - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kconfig/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kunitconversion failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kcrash_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kcrash_stable_qt5] $ /bin/sh -xe /tmp/hudson2930659486643831869.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 3101528 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@2fe1ae9a
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kcrash # timeout=10
Fetching upstream changes from git://anongit.kde.org/kcrash
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kcrash 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 3101528fc7908096333b62af8abce29b303b436c 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 3101528fc7908096333b62af8abce29b303b436c
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kcrash_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kcrash_stable_qt5] $ /bin/sh -xe /tmp/hudson8983514367041135739.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kcrash - Branch master
== Build Dependencies:
 qt5 - Branch stable
 extra-cmake-modules - Branch master
 dogtail - Branch master
 kwindowsystem - Branch master
 cmake - Branch master
 kcoreaddons - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kcoreaddons/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kcrash failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kauth_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kauth_stable_qt5] $ /bin/sh -xe /tmp/hudson6665012513879179678.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 4f6d10c Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@619ab2a4
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kauth # timeout=10
Fetching upstream changes from git://anongit.kde.org/kauth
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kauth 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 4f6d10cdc59aca6819e4189e81ff65150559bc10 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 4f6d10cdc59aca6819e4189e81ff65150559bc10
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kauth_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kauth_stable_qt5] $ /bin/sh -xe /tmp/hudson8711760909529219003.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kauth - Branch master
== Build Dependencies:
 dogtail - Branch master
 polkit-qt-1 - Branch master
 cmake - Branch master
 kcoreaddons - Branch master
 extra-cmake-modules - Branch master
 qt5 - Branch stable

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/kdesupport/polkit-qt-1/inst"
 failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kauth failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kdnssd_stable_qt5 #1

[KDE CI System]

See 

--
Started by user aacid
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[kdnssd_stable_qt5] $ /bin/sh -xe /tmp/hudson8742026721883989030.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

Cloning into '.'...
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 08e28f6 Upgrade KF5 version to 5.5.0.
Success build forhudson.tasks.Shell@16f34b21
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/kdnssd # timeout=10
Fetching upstream changes from git://anongit.kde.org/kdnssd
 > git --version # timeout=10
 > git fetch --tags --progress git://anongit.kde.org/kdnssd 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/jenkins^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/refs/heads/jenkins^{commit} # timeout=10
 > git rev-parse refs/heads/jenkins^{commit} # timeout=10
Checking out Revision 08e28f6fd5df532fe7d999b2b5c23f3f3f36e6fa 
(refs/heads/jenkins)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 08e28f6fd5df532fe7d999b2b5c23f3f3f36e6fa
First time build. Skipping changelog.
 > git tag -a -f -m Jenkins Build #1 jenkins-kdnssd_stable_qt5-1 # timeout=10
Run condition [File exists] enabling prebuild for step [Publish JUnit test 
result report]
Run condition [File exists] enabling prebuild for step [Publish Cppcheck 
results]
[kdnssd_stable_qt5] $ /bin/sh -xe /tmp/hudson2597139038150488349.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: kdnssd - Branch master
== Build Dependencies:
 cmake - Branch master
 qt5 - Branch stable
 extra-cmake-modules - Branch master
 dogtail - Branch master
 kconfig - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++//stable-kf5-qt5/frameworks/kconfig/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project kdnssd failed.
Build step 'Execute shell' marked build as failure
[File exists] check if file exists [build/JUnitTestResults.xml]
Run condition [File exists] preventing perform for step [Publish JUnit test 
result report]
[File exists] check if file exists [build/cppcheck.xml]
Run condition [File exists] preventing perform for step [Publish Cppcheck 
results]
[WARNINGS] Skipping publisher since build result is FAILURE
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kdnssd_stable_qt5 #2

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121118: KEmoticons: Add a KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121118/#review70370
---


I don't know enough about any of this or the other review to give a shipit, but 
the general structure makes sense to me now :)

- Albert Astals Cid


On nov. 14, 2014, 12:36 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121118/
> ---
> 
> (Updated nov. 14, 2014, 12:36 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid and David Faure.
> 
> 
> Repository: kemoticons
> 
> 
> Description
> ---
> 
> This patch is related to /r/121094, which moves KTextToHTML conversion 
> utility from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on 
> KEmoticons needed for smileys conversion, I created a plugin in KEmoticons 
> that implements the interface from KCoreAddons. This is based on the 
> FrameworkIntegrationPlugin.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1550bfe 
>   autotests/CMakeLists.txt 29b7eb6 
>   autotests/ktexttohtmlplugintest.cpp PRE-CREATION 
>   src/CMakeLists.txt 7b10087 
>   src/integrationplugin/CMakeLists.txt PRE-CREATION 
>   src/integrationplugin/kemoticonsintegrationplugin.h PRE-CREATION 
>   src/integrationplugin/kemoticonsintegrationplugin.cpp PRE-CREATION 
>   src/integrationplugin/ktexttohtml.h PRE-CREATION 
>   src/integrationplugin/ktexttohtml.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121118/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/#review70369
---



autotests/ktexttohtmltest.cpp


can you change all these QVERIFY to QCOMPARE?


- Albert Astals Cid


On nov. 14, 2014, 12:37 p.m., Daniel Vrátil wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121094/
> ---
> 
> (Updated nov. 14, 2014, 12:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class 
> takes plaintext string, and converts it to HTML while perserving spacing, 
> converting URLs and email addresses into  links and interpreting 
> highligting markup (*bold*, _underline_, /italic/) and wrapping it to 
> corresponding HTML tags. It can also convert text emoticons into  
> smileys.
> 
> The last - emoticons conversion - depends on KEmoticons, which we can't use 
> directly from KCoreAddons, so I moved the actual KEmoticons code into 
> FrameworkIntegration plugin. There is a dummy implementation provided by 
> default in KCoreAddons that is loaded when the FrameworkIntegration plugin is 
> not available, or when the application is only a QCoreApplication (since 
> KEmoticons require QGuiApplication, so we must not load the plugin). The 
> dummy implementation does nothing and returns the original string unaltered.
> 
> The reason for moving the class from KPimUtils is that KPimUtils is going to 
> die, and while we could make this internal to KDE PIM, I think this is a 
> rather useful code, that can be used by many applications that need to deal 
> with 3rd party text data and want to provide user-friendly clickable links.
> 
> If you compare this with the original KPimUtils::LinkLocator you find, that I 
> removed all public API except for the convertToHTML method. This is because 
> the remaining methods (getUrl, getEmailAddress) depend on the actual state of 
> the LinkLocator object, but LinkLocator provides no API for step-by-step 
> parsing, so they were actually useless for public use. For that reason I 
> decided to only publish the convertToHTML method, and hide the remaining 
> methods as internal methods of the KTextToHTMLHelper (useful for 
> unit-testing).
> 
> This patch also contains a unit-test from KPimUtils.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt d5a5feb 
>   autotests/ktexttohtmltest.h PRE-CREATION 
>   autotests/ktexttohtmltest.cpp PRE-CREATION 
>   src/lib/CMakeLists.txt 1dc5627 
>   src/lib/text/ktexttohtml.h PRE-CREATION 
>   src/lib/text/ktexttohtml.cpp PRE-CREATION 
>   src/lib/text/ktexttohtml_p.h PRE-CREATION 
>   src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/121094/diff/
> 
> 
> Testing
> ---
> 
> Unit test passes
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121047/
---

(Updated Nov. 14, 2014, 1:41 p.m.)


Review request for KDE Frameworks, KDEPIM-Libraries and David Faure.


Repository: kcodecs


Description
---

KCodecs currently provides only decodeRFC2047String(), and even that has a 
comment saying "more robust implementation available in KMime". This patch 
makes KCodecs::decodeRFC2047String() use the "more robust" implementation from 
KMime, and adds KCodecs::encodeRFC2047String() counterpart - also using 
implementation from KMime.

Since KMime also provides codecs implementing various MIME encodings 
(quoted-printable, base64, uuencode), and the KMmime implementation of 
decodeRFC2047String() depends on them, I also brought over all the MIME codecs, 
and make use of them in all the KCodecs static methods. I believe that having a 
proper and more robust implementation available in a more generic framework 
like KCodecs is better, than if it was hidden in the KMime framework. As a 
result, we can make KMime framework to use KCodecs (it already depends on it 
anyway) for all the encodings, and only leave classes for storing and parsing 
the "high-level" message/rfc822 messages, and headers. It also reduces code 
duplication, and makes all applications use the same encode/decode 
implementations (which is cool, right? :-))

The main reason for this move is that I'm trying to move over to KCodecs one 
small class from KPimUtils framework in kdepimlibs (which is our universal 
dumping ground in kdepimlibs that I'm trying to get rid of) for generic email 
address validation, but it depends on proper implementations of 
encode/decodeRFC2047String methods, so I ended up moving all this stuff :-) The 
tiny Email class is not part of this review though, I'll wait for this to get 
in, then post another review. I believe that this is a rather useful tool that 
could find wide adoption outside PIM, therefor I decided not to move it from 
KPimUtils to KMime, but instead move all the interesting, and multi-purpose 
parts from KMime into KCodecs.

I also moved over related KMime unit-tests (that's why the review is so big).


Diffs
-

  autotests/data/codec_q/all-encoded-decode.q PRE-CREATION 
  autotests/data/codec_q/all-encoded-decode.q.expected PRE-CREATION 
  autotests/data/codec_q/basic-encode PRE-CREATION 
  autotests/data/codec_q/basic-encode.expected PRE-CREATION 
  autotests/data/codec_q/null-decode.q PRE-CREATION 
  autotests/data/codec_q/null-decode.q.expected PRE-CREATION 
  autotests/data/codec_q/null-encode PRE-CREATION 
  autotests/data/codec_q/null-encode.expected PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-decode.quoted-printable 
PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-decode.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-encode PRE-CREATION 
  autotests/data/codec_quoted-printable/basic-encode.expected PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt2.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt2.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt3.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt3.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt4.quoted-printable PRE-CREATION 
  autotests/data/codec_quoted-printable/corrupt4.quoted-printable.expected 
PRE-CREATION 
  autotests/data/codec_quoted-printable/wrap-encode PRE-CREATION 
  autotests/data/codec_quoted-printable/wrap-encode.expected PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode 
PRE-CREATION 
  
autotests/data/codec_x-kmime-rfc2231/all-encoded.x-kmime-rfc2231-decode.expected
 PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/basic-encode PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/basic-encode.expected PRE-CREATION 
  autotests/data/codec_x-kmime-rfc2231/null-decode.x-kmime-rfc2231 PRE-CREATION 
  autotests/CMakeLists.txt 4c41ba2 
  autotests/base64benchmark.cpp PRE-CREATION 
  autotests/codectest.h PRE-CREATION 
  autotests/codectest.cpp PRE-CREATION 
  autotests/data/codec_b/basic-decode.b PRE-CREATION 
  autotests/data/codec_b/basic-decode.b.expected PRE-CREATION 
  autotests/data/codec_b/basic-encode PRE-CREATION 
  autotests/data/codec_b/basic-encode.expected PRE-CREATION 
  autotests/data/codec_b/null-decode.b PRE-CREATION 
  autotests/data/codec_b/null-decode.b.expected PRE-CREATION 
  autotests/data/codec_b/null-encode PRE-CREATION 
  autotests/data/codec_b/null-encode.expected PRE-CREATION 
  autotests/data/codec_b/padding0-

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121094/
---

(Updated Nov. 14, 2014, 1:37 p.m.)


Review request for KDE Frameworks and Michael Pyne.


Changes
---

The KEmoticons plugin has been moved to from FrameworkIntegration into 
KEmoticons Framework


Repository: kcoreaddons


Description
---

This class comes from KPimUtils::LinkLocator from kdepimlibs.git. This class 
takes plaintext string, and converts it to HTML while perserving spacing, 
converting URLs and email addresses into  links and interpreting 
highligting markup (*bold*, _underline_, /italic/) and wrapping it to 
corresponding HTML tags. It can also convert text emoticons into  smileys.

The last - emoticons conversion - depends on KEmoticons, which we can't use 
directly from KCoreAddons, so I moved the actual KEmoticons code into 
FrameworkIntegration plugin. There is a dummy implementation provided by 
default in KCoreAddons that is loaded when the FrameworkIntegration plugin is 
not available, or when the application is only a QCoreApplication (since 
KEmoticons require QGuiApplication, so we must not load the plugin). The dummy 
implementation does nothing and returns the original string unaltered.

The reason for moving the class from KPimUtils is that KPimUtils is going to 
die, and while we could make this internal to KDE PIM, I think this is a rather 
useful code, that can be used by many applications that need to deal with 3rd 
party text data and want to provide user-friendly clickable links.

If you compare this with the original KPimUtils::LinkLocator you find, that I 
removed all public API except for the convertToHTML method. This is because the 
remaining methods (getUrl, getEmailAddress) depend on the actual state of the 
LinkLocator object, but LinkLocator provides no API for step-by-step parsing, 
so they were actually useless for public use. For that reason I decided to only 
publish the convertToHTML method, and hide the remaining methods as internal 
methods of the KTextToHTMLHelper (useful for unit-testing).

This patch also contains a unit-test from KPimUtils.


Diffs (updated)
-

  autotests/CMakeLists.txt d5a5feb 
  autotests/ktexttohtmltest.h PRE-CREATION 
  autotests/ktexttohtmltest.cpp PRE-CREATION 
  src/lib/CMakeLists.txt 1dc5627 
  src/lib/text/ktexttohtml.h PRE-CREATION 
  src/lib/text/ktexttohtml.cpp PRE-CREATION 
  src/lib/text/ktexttohtml_p.h PRE-CREATION 
  src/lib/text/ktexttohtmlemoticonsinterface.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121094/diff/


Testing
---

Unit test passes


Thanks,

Daniel Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121118: KEmoticons: Add a KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121118/
---

Review request for KDE Frameworks, Albert Astals Cid and David Faure.


Repository: kemoticons


Description
---

This patch is related to /r/121094, which moves KTextToHTML conversion utility 
from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons 
needed for smileys conversion, I created a plugin in KEmoticons that implements 
the interface from KCoreAddons. This is based on the FrameworkIntegrationPlugin.


Diffs
-

  CMakeLists.txt 1550bfe 
  autotests/CMakeLists.txt 29b7eb6 
  autotests/ktexttohtmlplugintest.cpp PRE-CREATION 
  src/CMakeLists.txt 7b10087 
  src/integrationplugin/CMakeLists.txt PRE-CREATION 
  src/integrationplugin/kemoticonsintegrationplugin.h PRE-CREATION 
  src/integrationplugin/kemoticonsintegrationplugin.cpp PRE-CREATION 
  src/integrationplugin/ktexttohtml.h PRE-CREATION 
  src/integrationplugin/ktexttohtml.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121118/diff/


Testing
---


Thanks,

Daniel Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

[Daniel Vrátil]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121095/
---

(Updated Nov. 14, 2014, 1:33 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, David Faure and Michael Pyne.


Repository: frameworkintegration


Description
---

This patch is related to /r/121094, which moves KTextToHTML conversion utility 
from KPimUtils to KCoreAddons. Since KCoreAddons can't depend on KEmoticons 
needed for smileys conversion, I added the actual KEmoticons code here, to 
create a run-time dependency, similar to the KWidgetsAddons-KConfig dependency 
for KMessageBox.

This patch refactors the FrameworkIntegrationPlugin a bit - I split the 
KMessageBox-specific code into a separate file, and added a new file with the 
KTextToHTMLEmoticonsInterface implementation, as we can't just keep stacking 
more and more classes into a single file :-)


Diffs
-

  CMakeLists.txt 3721bfa 
  src/integrationplugin/CMakeLists.txt 3395368 
  src/integrationplugin/frameworkintegrationplugin.h 6dc6825 
  src/integrationplugin/frameworkintegrationplugin.cpp a45ba9d 
  src/integrationplugin/kmessagebox.h PRE-CREATION 
  src/integrationplugin/kmessagebox.cpp PRE-CREATION 
  src/integrationplugin/ktexttohtml.h PRE-CREATION 
  src/integrationplugin/ktexttohtml.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/121095/diff/


Testing
---

Tested with KTextToHTML code from /r/121094 in a QGuiApplication and it seems 
to work.


Thanks,

Daniel Vrátil

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121113/#review70364
---


hm, i don't really like it.
is it working around a problem in particular?
if i try the patch, the difference during startup (or just duringopening a 
popup on the first time) is pretty noticeable like, the wallpaper appearing 
several *seconds* later.
This way, i think it's not using the incubator at all, and i don't think it's 
really acceptable.
In QML itself, QQuickView does internally use an incubator as well, even tough 
in a slightly different manner it seems.

- Marco Martin


On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121113/
> ---
> 
> (Updated Nov. 13, 2014, 6:24 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> We had a while loop which processed all application events whilst we
> were in the middle of creating objects. This leads to weird bugs, and
> workarounds in ShellCorona.
> 
> Qt's methods forceCompletion does not seem to have the same problems and
> works just as well.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.cpp 029edaf 
> 
> Diff: https://git.reviewboard.kde.org/r/121113/diff/
> 
> 
> Testing
> ---
> 
> Ran plasmashell with many panels filled with applets
> 
> Added debug on void ShellCorona::createWaitingPanels() to make sure it was 
> never called with m_loading true.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120926/#review70361
---


if you want, but the sentence sounds like KRun only reads from that config 
file, while it also writes into it. This is why I consider it an implementation 
detail... the app doesnt need to care about it, right?

- David Faure


On nov. 1, 2014, 10:31 matin, Arjun AK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120926/
> ---
> 
> (Updated nov. 1, 2014, 10:31 matin)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Since `setShowScriptExecutionPrompt()` is used to specify whether a prompt 
> should be shown or not, we don't neither need to check it again nor do we 
> need to call `setRunExecutable()` inside KIO. The caller is anyway forced to 
> do something like:
> 
> if (value == "alwaysAsk") {
> run->setShowScriptExecutionPrompt(true);
> } else {
> run->setRunExecutables(value == "execute");
> }
> 
> 
> Diffs
> -
> 
>   src/widgets/krun.h cd5bcaa 
> 
> Diff: https://git.reviewboard.kde.org/r/120926/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : ksshaskpass_master_qt5 #4

[KDE CI System]

See 

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel