Jenkins build is back to stable : kio_stable_qt5 #15
See http://build.kde.org/job/kio_stable_qt5/15/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins build became unstable: kio_stable_qt5 #16
See http://build.kde.org/job/kio_stable_qt5/16/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: GenericConfigLocation missing in qtpaths tool
Hi David Ben, On 06 Dec 2014, at 21:13 , David Faure fa...@kde.org wrote: Fixed 5 months ago: commit 3b102b026b6fdd8dfbc284741d8df7c1d6dcc9d3 Author: David Faure david.fa...@kdab.com Date: Sun Jul 6 15:30:58 2014 +0200 qtpaths: add missing GenericConfigLocation, exists since Qt 5.2.0 Change-Id: I4d4ef2e0f33896984f436df6c9a033dd8985 Reviewed-by: Sune Vuorela s...@vuorela.dk Reviewed-by: Thiago Macieira thiago.macie...@intel.com $ git tag --contains 3b102b026b6fdd8dfbc284741d8df7c1d6dcc9d3 v5.3.2 v5.4.0-alpha1 v5.4.0-beta1 v5.4.0-rc1 oh, I thought that I am running a rather recent Qt5 installation on the OSX/CI system. I built at the end of November, but I see now that it is 5.3.1: --- $ gtdiag Qt 5.3.1 (Nov 21 2014, Clang 6.0 (clang-600.0.54) (Apple), 64 bit, debug build) on cocoa little endian/ $ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/bin/qtpaths --version qtpaths 1.0 --- That explains it. Greets, Marko signature.asc Description: Message signed with OpenPGP using GPGMail ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/ --- Review request for KDE Frameworks, Christoph Feck and Dominik Haumann. Repository: kwidgetsaddons Description --- As mentioned in [KPageView/KTitleWidget: Remove top right icon](https://forum.kde.org/viewtopic.php?f=285t=123837) the top-right icon serves no visible purpose and can even be a distraction. This patch removes the code that adds the icon. Diffs - src/kpageview.cpp 69d1bf9a20549b74557f3fdf9a7057cb74258cb1 Diff: https://git.reviewboard.kde.org/r/121379/diff/ Testing --- Screenshots: http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_1before.png (before patch) http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after) http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch) http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after) Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: phonon fails to INSTALL on branch master
On 27 Nov 2014, at 08:59 , Marko Käning mk-li...@email.de wrote: Phonon built fine, but failed to install for some reason, as a file must be missing: --- -- Installing: /Users/marko/WC/KDECI-builds/phonon/local-inst/opt/kde/install/darwin/mavericks/clang/kf5-qt5/kdesupport/phonon/phonon/inst/include/phonon4qt5/phonon/VolumeSlider CMake Error at includes/cmake_install.cmake:88 (file): file INSTALL cannot find /Users/marko/WC/KDECI-builds/phonon/includes/old/Phonon/AbstractAudioOutput. Call Stack (most recent call first): cmake_install.cmake:69 (include) make: *** [install] Error 1 KDE Continuous Integration Build Just for the record, I saw this error once again!!! Building phonon a 2nd time it was successful though. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Change in kio[master]: Add debugging output to indicate which file got changed
Jan Kundrát has uploaded a new change for review.
https://gerrit.vesnicky.cesnet.cz/r/206
Change subject: Add debugging output to indicate which file got changed
..
Add debugging output to indicate which file got changed
This test case has failed twice in a row in my CI environment, so let's
take a look to see what is getting changed.
Change-Id: I266394c7f176f4cdfd7b087995dd9031b76fd8be
---
M autotests/kdirlistertest.cpp
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.vesnicky.cesnet.cz:29418/kio refs/changes/06/206/1
diff --git a/autotests/kdirlistertest.cpp b/autotests/kdirlistertest.cpp
index 0ceee4e..867d11d 100644
--- a/autotests/kdirlistertest.cpp
+++ b/autotests/kdirlistertest.cpp
@@ -433,6 +433,10 @@
org::kde::KDirNotify::emitFilesAdded(QUrl::fromLocalFile(path));
QTest::qWait(200);
org::kde::KDirNotify::emitFilesChanged(QListQUrl()
QUrl::fromLocalFile(directoryFile));
+foreach (const QPairKFileItem, KFileItem item, m_refreshedItems) {
+ qDebug() 1st: item.first.url().toLocalFile()
item.first.time(KFileItem::ModificationTime)
item.first.time(KFileItem::AccessTime) item.first.user()
item.first.group();
+ qDebug() 2nd: item.second.url().toLocalFile()
item.second.time(KFileItem::ModificationTime)
item.second.time(KFileItem::AccessTime) item.second.user()
item.second.group();
+}
QCOMPARE(m_refreshedItems.count(), 0);
org::kde::KDirNotify::emitFilesChanged(QListQUrl()
QUrl::fromLocalFile(path));
--
To view, visit https://gerrit.vesnicky.cesnet.cz/r/206
To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I266394c7f176f4cdfd7b087995dd9031b76fd8be
Gerrit-PatchSet: 1
Gerrit-Project: kio
Gerrit-Branch: master
Gerrit-Owner: Jan Kundrát j...@kde.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KIO's KDirListerTest::testRefreshRootItem on RHEL7 and XFS
Hi, there's one test in KIO which keeps failing when I run it inside my CI environment (a RHEL7 VM with XFS). Take a look at [1], the /tmp/kdirlistertest-dIp2zR/subdir's mtime and atime are getting bumped by one second. The patch which introduces this debug output is at [2]. I will admit that I'm not sure what that test is actually testing -- I would have expected some sort of file watcher in the background, but I'm not sure with the manual calls to org::kde::KDirNotify::emitXYZ. Anyway, the comments on lines 401-402 seems to indicate that the sort of behavior I'm seeing is semi-expected. What can I do to fix the test failure I'm seeing? Why is the change of /tmp/kdirlistertest-dIp2zR/subdir encountered too early in this test? With kind regards, Jan [1] http://ci-logs.kde.flaska.net/06/206/2/check/check-kf5qt5-generic-test-el7/95ea34f/shell_output.log [2] http://quickgit.kde.org/?p=kio.gita=commith=55f949798a99158d06d030186204fc0f19365b4a -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 121379: kwidgetsaddons/kpageview.cpp: remove top-right icon
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/#review71519 --- As background: I was the one who added this icon in KDE4 times. I changed the title to be bold and added the icon, which later became the KTitleWidget we know today. The icon in KPageWidget indeed does not have any functionality, I added this simply I personally thought this looked good. But it's not required at all, so I'd be fine with removing it in KF5. Other reviews welcome. - Dominik Haumann On Dec. 7, 2014, 10:49 a.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121379/ --- (Updated Dec. 7, 2014, 10:49 a.m.) Review request for KDE Frameworks, Christoph Feck and Dominik Haumann. Repository: kwidgetsaddons Description --- As mentioned in [KPageView/KTitleWidget: Remove top right icon](https://forum.kde.org/viewtopic.php?f=285t=123837) the top-right icon serves no visible purpose and can even be a distraction. This patch removes the code that adds the icon. Diffs - src/kpageview.cpp 69d1bf9a20549b74557f3fdf9a7057cb74258cb1 Diff: https://git.reviewboard.kde.org/r/121379/diff/ Testing --- Screenshots: http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_1before.png (before patch) http://wstaw.org/m/2014/12/07/kcmshell5_devinfo_-_2after.png (after) http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_1before.png (before patch) http://wstaw.org/m/2014/12/07/kcmshell5_mouse_-_2after.png (after) Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: One kde-baseapps test fails
This is one of my first test results on OSX: FAIL! : KonqPopupMenuTest::testSubDirectory() Received a fatal error. Full test results are attached. kde-baseapps-test-results.tar.bz2 Description: BZip2 compressed data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: All Kate tests failing
All of Kate’s tests are failing on OSX/CI with this message: Unable to find executable: session_test Since other projects are able to run tests successfully, I gather that this is a kate-specific issue. Test results attached. kate-test-results.tar.bz2 Description: BZip2 compressed data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
