Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-09 Thread Martin Graesslin 
On Monday, November 9, 2015 6:00:43 PM CET Jan Kundrát wrote:
> On Monday, 9 November 2015 08:21:21 CET, Martin Graesslin wrote:
> > I'm sorry, but I'm not able to reproduce the failure on my
> > local Qt 5.6 setup.
> > The failures look like there is no WM running on the CI system,
> > maybe openbox
> > crashed? (We had that before that our tests were able to trigger crashes
> > in
> > openbox).
> 
> All Qt versions are hitting the same pool of VMs, and the failure only
> happens on Qt 5.6. Unless there's something in Qt 5.6 which makes openbox
> crash, I don't think that it's a plausible explanation.
> 
> Anyway, if you look at the test log, you can see that the remaining tests
> all passed. Would they still pass even if there was no running WM at that
> point?

Yes, most tests don't require a WM. Especially the Net* tests simulate being a 
window manager. Only the KWindow* tests need a window manager.

> 
> I can add some extra diagnostics to the build scripts if it's really
> needed, but let's figure out other possibilities first, please.

Well for me there is not much to do. I don't get them failing on my system, so 
I have no clue what I should fix to make them work again.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [CRITICAL] KIO Test "threadtest" can enter into infinite loop

2015-11-09 Thread Ben Cooksley 
On Mon, Nov 9, 2015 at 8:30 PM, David Faure  wrote:
> On Monday 09 November 2015 19:36:09 Ben Cooksley wrote:
>> On Mon, Nov 9, 2015 at 10:26 AM, Albert Astals Cid  wrote:
>> > El Saturday 07 November 2015, a les 10:36:18, David Faure va escriure:
>> >> On Saturday 07 November 2015 11:17:31 Ben Cooksley wrote:
>> >> > Hi all,
>> >> >
>> >> > It appears the test running with the binary name of "threadtest" in
>> >> > kio has a grave bug which can lead to it entering into an infinite
>> >> > loop.
>> >> >
>> >> > This was consuming virtually the entire resources of one builder with
>> >> > old hung processes, and the whole core of another builder -
>> >> > drastically limiting the capabilities of the CI system (even though
>> >> > KIO was not being built at the time).
>> >> >
>> >> > Can someone please investigate? Manual intervention (with kill -9) is
>> >> > needed to remove these hung processes.
>> >>
>> >> It of course works fine on my own machine.
>> >>
>> >> And I just tried running it on LinuxNode2, in
>> >> ~/builds/kio/stable-kf5-qt5/build/autotests (after sourcing ~/kio.env 
>> >> which
>> >> I just generated), and it ran fine (multiple times).
>> >>
>> >> Any suggestion on how / where to hit the issue?
>> >
>> > I too have serious problems being able to reproduce the same results on the
>> > build nodes than CI has :(
>> >
>> > I guess we're most probably missing some step (e.g. kdelibs failing test
>> > always work when i try to reproduce it, rocs compiles fine, etc)
>>
>> Albert, did you try with the kf5-qt5 or stable-kf5-qt5 branch group?
>> It seems this is a Qt regression (and the version differs).
>
> Now I'm not sure if you guys are talking about kio's threadtest or about other
> things (kdelibs, rocs).
>
> To get back to the kio threadtest topic, it passes in a loop here, even with 
> Qt 5.6.
>   -> sorry Oswald, false alert.
>
> So I think Nicolás Alvarez is right, this is more likely a bug in asan.
> I forgot that we had that enabled in the CI - which makes one more difference 
> between
> our local setups and the CI ;)
>
> Ben, Albert, do we have a way to turn off asan for kio's threadtest?

Only for all of KIO, which I have now done.
Please file a bug against ASAN support (compiler bug I assume?)

Regards,
Ben

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[sysadmin/ci-builder-tools] build/kio: Disable ASAN for all of KIO. We can't switch it off per test, so for everything it shall have to be...

2015-11-09 Thread Ben Cooksley 
Git commit 7f4c67b4bdf3d2c46a855fc2f7d03f9fc0606caa by Ben Cooksley.
Committed on 10/11/2015 at 06:56.
Pushed by bcooksley into branch 'master'.

Disable ASAN for all of KIO. We can't switch it off per test, so for everything 
it shall have to be...
CCMAIL: kde-frameworks-devel@kde.org

A  +2-0build/kio/kf5-qt5.cfg
A  +2-0build/kio/stable-kf5-qt5.cfg

http://commits.kde.org/sysadmin/ci-builder-tools/7f4c67b4bdf3d2c46a855fc2f7d03f9fc0606caa

diff --git a/build/kio/kf5-qt5.cfg b/build/kio/kf5-qt5.cfg
new file mode 100644
index 000..44c1eb4
--- /dev/null
+++ b/build/kio/kf5-qt5.cfg
@@ -0,0 +1,2 @@
+[Build]
+configureCommand=%(configureExecutable)s %(configurePlatformArgs)s 
%(configureExtraArgs)s -DCMAKE_BUILD_TYPE=%(cmakeBuildType)s -DBUILD_TESTING=ON 
-DSIP_DEFAULT_SIP_DIR={instPrefix}/share/sip/ 
-DCMAKE_INSTALL_PREFIX={instPrefix} {sources}
diff --git a/build/kio/stable-kf5-qt5.cfg b/build/kio/stable-kf5-qt5.cfg
new file mode 100644
index 000..44c1eb4
--- /dev/null
+++ b/build/kio/stable-kf5-qt5.cfg
@@ -0,0 +1,2 @@
+[Build]
+configureCommand=%(configureExecutable)s %(configurePlatformArgs)s 
%(configureExtraArgs)s -DCMAKE_BUILD_TYPE=%(cmakeBuildType)s -DBUILD_TESTING=ON 
-DSIP_DEFAULT_SIP_DIR={instPrefix}/share/sip/ 
-DCMAKE_INSTALL_PREFIX={instPrefix} {sources}
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Nick Shaforostoff 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125951/#review88206
---



src/declarativeimports/calendar/eventpluginsmanager.cpp (line 42)


please use QByteArrayLiteral("configUi")



src/declarativeimports/calendar/eventpluginsmanager.cpp (line 68)


QStringLiteral("MetaData"). this is important because data() method is 
called a lot.



src/declarativeimports/calendar/eventpluginsmanager.cpp (line 79)


in order to reduce malloc/free call count (and the data() method is called 
a lot) please use leftRef() instead of left() and % instead of + three lines 
below (or make sure + is the same as % by adding define -DQT_USE_QSTRINGBUILDER)


- Nick Shaforostoff


On Nov. 9, 2015, 7:56 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125951/
> ---
> 
> (Updated Nov. 9, 2015, 7:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This is also made a QML singleton that will be used for the applet
> config view where it will add the plugin configs once we add that
> possibility.
> 
> The same instance is then set to the DaysModel from QML.
> 
> (this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship 
> it)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/calendar/CMakeLists.txt 
> 40ead911ad5208cae5dbe5333d227f9f8a0d9154 
>   src/declarativeimports/calendar/calendarplugin.cpp 
> bafe80cf7520a08312abfd1dbd6d4648a6710175 
>   src/declarativeimports/calendar/daysmodel.h 
> a5bdac98627f7efa76bd4afd239469b53e06690b 
>   src/declarativeimports/calendar/daysmodel.cpp 
> 2d059a8e8636565adbe52811e602fff37a5eb157 
>   src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION 
>   src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION 
>   src/declarativeimports/calendar/qml/MonthView.qml 
> f698934f850ef3a917b9611c9f9a40c369b23f6c 
> 
> Diff: https://git.reviewboard.kde.org/r/125951/diff/
> 
> 
> Testing
> ---
> 
> Calendar events are still correctly displayed
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

2015-11-09 Thread Emmanuel Pescosta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126009/
---

(Updated Nov. 9, 2015, 10:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 9dbe36f734b5b839b2a6a934fad29d639e954498 by Emmanuel 
Pescosta to branch master.


Bugs: 354678
https://bugs.kde.org/show_bug.cgi?id=354678


Repository: kio


Description
---

Fix url encoding problems (e.g. when the path contains a '%') in KUrlNavigator

These changes also fix a weird behavior of KUrlNavigator when button 0 is
pressed. KUrlNavigator always used the local path '/' for button 0 and ignored
the scheme and authority. The networkPathButtonIndex* and ftpPathButtonIndex*
test rows test exactly this problem.


Diffs
-

  autotests/kurlnavigatortest.h e65e8ef 
  autotests/kurlnavigatortest.cpp 25d1ed6 
  src/filewidgets/kurlnavigator.cpp 28d750e 

Diff: https://git.reviewboard.kde.org/r/126009/diff/


Testing
---

All tests pass


Thanks,

Emmanuel Pescosta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

2015-11-09 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126009/#review88203
---

Ship it!


Ship It!

- David Faure


On Nov. 9, 2015, 7:09 p.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126009/
> ---
> 
> (Updated Nov. 9, 2015, 7:09 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 354678
> https://bugs.kde.org/show_bug.cgi?id=354678
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Fix url encoding problems (e.g. when the path contains a '%') in KUrlNavigator
> 
> These changes also fix a weird behavior of KUrlNavigator when button 0 is
> pressed. KUrlNavigator always used the local path '/' for button 0 and ignored
> the scheme and authority. The networkPathButtonIndex* and ftpPathButtonIndex*
> test rows test exactly this problem.
> 
> 
> Diffs
> -
> 
>   autotests/kurlnavigatortest.h e65e8ef 
>   autotests/kurlnavigatortest.cpp 25d1ed6 
>   src/filewidgets/kurlnavigator.cpp 28d750e 
> 
> Diff: https://git.reviewboard.kde.org/r/126009/diff/
> 
> 
> Testing
> ---
> 
> All tests pass
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

2015-11-09 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125951/
---

(Updated Nov. 9, 2015, 8:56 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Store the enabled plugins in a config


Repository: plasma-framework


Description
---

This is also made a QML singleton that will be used for the applet
config view where it will add the plugin configs once we add that
possibility.

The same instance is then set to the DaysModel from QML.

(this depends on https://git.reviewboard.kde.org/r/125817/ which awaits ship it)


Diffs (updated)
-

  src/declarativeimports/calendar/CMakeLists.txt 
40ead911ad5208cae5dbe5333d227f9f8a0d9154 
  src/declarativeimports/calendar/calendarplugin.cpp 
bafe80cf7520a08312abfd1dbd6d4648a6710175 
  src/declarativeimports/calendar/daysmodel.h 
a5bdac98627f7efa76bd4afd239469b53e06690b 
  src/declarativeimports/calendar/daysmodel.cpp 
2d059a8e8636565adbe52811e602fff37a5eb157 
  src/declarativeimports/calendar/eventpluginsmanager.h PRE-CREATION 
  src/declarativeimports/calendar/eventpluginsmanager.cpp PRE-CREATION 
  src/declarativeimports/calendar/qml/MonthView.qml 
f698934f850ef3a917b9611c9f9a40c369b23f6c 

Diff: https://git.reviewboard.kde.org/r/125951/diff/


Testing
---

Calendar events are still correctly displayed


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126009: [KUrlNavigator] Fix url encoding problems in KUrlNavigator

2015-11-09 Thread Emmanuel Pescosta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126009/
---

Review request for KDE Frameworks and David Faure.


Bugs: 354678
https://bugs.kde.org/show_bug.cgi?id=354678


Repository: kio


Description
---

Fix url encoding problems (e.g. when the path contains a '%') in KUrlNavigator

These changes also fix a weird behavior of KUrlNavigator when button 0 is
pressed. KUrlNavigator always used the local path '/' for button 0 and ignored
the scheme and authority. The networkPathButtonIndex* and ftpPathButtonIndex*
test rows test exactly this problem.


Diffs
-

  autotests/kurlnavigatortest.h e65e8ef 
  autotests/kurlnavigatortest.cpp 25d1ed6 
  src/filewidgets/kurlnavigator.cpp 28d750e 

Diff: https://git.reviewboard.kde.org/r/126009/diff/


Testing
---

All tests pass


Thanks,

Emmanuel Pescosta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Build and test failures with Qt 5.6 and Qt 5.3

2015-11-09 Thread Jan Kundrát 

On Monday, 9 November 2015 08:21:21 CET, Martin Graesslin wrote:
I'm sorry, but I'm not able to reproduce the failure on my 
local Qt 5.6 setup. 
The failures look like there is no WM running on the CI system, 
maybe openbox 
crashed? (We had that before that our tests were able to trigger crashes in 
openbox).


All Qt versions are hitting the same pool of VMs, and the failure only 
happens on Qt 5.6. Unless there's something in Qt 5.6 which makes openbox 
crash, I don't think that it's a plausible explanation.


Anyway, if you look at the test log, you can see that the remaining tests 
all passed. Would they still pass even if there was no running WM at that 
point?


I can add some extra diagnostics to the build scripts if it's really 
needed, but let's figure out other possibilities first, please.


With kind regards,
Jan

--
Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 9, 2015, 3:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Changes
---

Submitted with commit 11a95d31acb8f3622c51f8e9a6eba5cfeb35a292 by Marco Martin 
to branch master.


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/#review88197
---

Ship it!


Not sure if we can use the Package::JobError::Foo syntax in frameworks.


src/kpackage/package.h (line 95)


NewerVersionAlreadyInstalledError



src/kpackage/package.h (line 96)


+Error


- Kai Uwe Broulik


On Nov. 9, 2015, 2:51 nachm., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125976/
> ---
> 
> (Updated Nov. 9, 2015, 2:51 nachm.)
> 
> 
> Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> new job based update() function that compared to install()
> if a package with the same pluginId is already installed,
> removes the old one before installing the new one, if
> and only if the version of the new one is more recent
> 
> 
> Diffs
> -
> 
>   autotests/plasmoidpackagetest.h f730dce 
>   autotests/plasmoidpackagetest.cpp 567 
>   src/kpackage/CMakeLists.txt 3696f37 
>   src/kpackage/package.h 4ada8da 
>   src/kpackage/package.cpp 539b21a 
>   src/kpackage/packagestructure.h 9427b42 
>   src/kpackage/packagestructure.cpp 0070514 
>   src/kpackage/private/packagejob.cpp 0d2241b 
>   src/kpackage/private/packagejob_p.h 267429f 
>   src/kpackage/private/packagejobthread.cpp ca523b3 
>   src/kpackage/private/packagejobthread_p.h bf8a266 
>   src/kpackage/private/versionparser.cpp PRE-CREATION 
>   src/kpackagetool/CMakeLists.txt 78e0fb0 
> 
> Diff: https://git.reviewboard.kde.org/r/125976/diff/
> 
> 
> Testing
> ---
> 
> covered by autotests
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/#review88195
---

Ship it!


Nice. Few issues with the wording in the comments, but generally looks good.


src/kpackage/package.h (line 97)


/tmp may not be /tmp (definitely not on Windows)



src/kpackage/package.h (line 98)


...on the harddisk (though this should probably not say harddisk, but 
filesystem)



src/kpackage/package.h (line 99)


-(from the hard disk)


Nice.

- Sebastian Kügler


On Nov. 9, 2015, 2:40 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125976/
> ---
> 
> (Updated Nov. 9, 2015, 2:40 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> new job based update() function that compared to install()
> if a package with the same pluginId is already installed,
> removes the old one before installing the new one, if
> and only if the version of the new one is more recent
> 
> 
> Diffs
> -
> 
>   autotests/plasmoidpackagetest.h f730dce 
>   autotests/plasmoidpackagetest.cpp 567 
>   src/kpackage/CMakeLists.txt 3696f37 
>   src/kpackage/package.h 4ada8da 
>   src/kpackage/package.cpp 539b21a 
>   src/kpackage/packagestructure.h 9427b42 
>   src/kpackage/packagestructure.cpp 0070514 
>   src/kpackage/private/packagejob.cpp 0d2241b 
>   src/kpackage/private/packagejob_p.h 267429f 
>   src/kpackage/private/packagejobthread.cpp ca523b3 
>   src/kpackage/private/packagejobthread_p.h bf8a266 
>   src/kpackage/private/versionparser.cpp PRE-CREATION 
>   src/kpackagetool/CMakeLists.txt 78e0fb0 
> 
> Diff: https://git.reviewboard.kde.org/r/125976/diff/
> 
> 
> Testing
> ---
> 
> covered by autotests
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 9, 2015, 2:51 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread Matthew Dawson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126001/
---

(Updated Nov. 9, 2015, 2:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 0f1e67051dae0c9b1f23461f7caed594795e8a27 by Matthew 
Dawson to branch master.


Repository: kconfig


Description
---

Due to https://codereview.qt-project.org/#/c/106473/, Qt 5.6 keeps null
characters in QByteArray -> QString conversions, which breaks this test as
one QByteArray contains nulls.  Instead, convert the QByteArray to const
char * first, so QString stops at the first null.

The actual  behaviour of KConfig is unchanged, as internally the conversion
always went through a const char *, which avoids creating QStrings with
null characters.


Diffs
-

  autotests/kconfigtest.cpp 9a2998647b5e5f54d63059172b727505a8ae1c80 

Diff: https://git.reviewboard.kde.org/r/126001/diff/


Testing
---

Tested on both Qt 5.5.1 and Qt 5.6 (commit 
e996d68f6130847637ba287518cff1289cfa48e5), tests all pass now.


Thanks,

Matthew Dawson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126001/#review88194
---

Ship it!


Ah, yes, I read the code too fast.

Indeed I expect QByteArrays to contain embedded NULs, but not QStrings.

- David Faure


On Nov. 9, 2015, 12:23 a.m., Matthew Dawson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126001/
> ---
> 
> (Updated Nov. 9, 2015, 12:23 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Due to https://codereview.qt-project.org/#/c/106473/, Qt 5.6 keeps null
> characters in QByteArray -> QString conversions, which breaks this test as
> one QByteArray contains nulls.  Instead, convert the QByteArray to const
> char * first, so QString stops at the first null.
> 
> The actual  behaviour of KConfig is unchanged, as internally the conversion
> always went through a const char *, which avoids creating QStrings with
> null characters.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.cpp 9a2998647b5e5f54d63059172b727505a8ae1c80 
> 
> Diff: https://git.reviewboard.kde.org/r/126001/diff/
> 
> 
> Testing
> ---
> 
> Tested on both Qt 5.5.1 and Qt 5.6 (commit 
> e996d68f6130847637ba287518cff1289cfa48e5), tests all pass now.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 9, 2015, 2:40 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Changes
---

Painfully detailed error codes for every thing it may fail for.
Not sure if it's needed *that* detailed but can be useful


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126001: In KConfigTest::testEntryMap, convert QByteArray with nulls using a char *

2015-11-09 Thread Matthew Dawson 


> On Nov. 9, 2015, 2:57 a.m., David Faure wrote:
> > Isn't this exactly the wrong fix? The goal of the test with embedded NULs 
> > in a QByteArray is to test that KConfig can be used to store binary data, 
> > isn't it? So I would think the expected value was correct, it's the KConfig 
> > code that is faulty. As a programmer I expect to be able to write binary 
> > data and read it back again, without it stopping at the first \0.

I'm not exactly sure what this test is trying to do, or what the purpose of the 
KConfig::entryMap function is.  KConfig::entryMap only returns QString (not 
QByteArray, or any other type), so its value seems limited when I can get the 
same behaviour through other methods.  There is a test that looks at the raw 
byte string to ensure nulls are passed through correctly (see kconfigtest.cpp, 
line 343), so changing the behaviour just to test nulls isn't useful.

What I'm not sure of is what someone would expect when asking for a QString 
from a value in KConfig containing nulls.  If someone is thinking like a C 
programmer, I'd expect them to expect the string to end at the null character.  
Otherwise, I can see the argument returning the string with nulls embedded in 
at as being the expected outcome.  I think either way, people will end up 
suprised.

I'd also expect the KConfigGroup::readEntry to return the same value as what 
KConfig::entryMap returns.  Currently readEntry also stops at the first null 
character.

I'm not aware of a preference in the Qt/KF5 world of how to deal with nulls in 
a string.  If there is a preference either way, I'm happy to take that to fit 
in with the rest of the ecosystem.


Note: none of this changes how a QByteArray should work, as I'd expect that to 
return the exact binary data you feed into it.  If it stopped processing at the 
first 0 byte, I'd consider that to be a bug regardless of how QString is 
handled.


- Matthew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126001/#review88177
---


On Nov. 8, 2015, 7:23 p.m., Matthew Dawson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126001/
> ---
> 
> (Updated Nov. 8, 2015, 7:23 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Due to https://codereview.qt-project.org/#/c/106473/, Qt 5.6 keeps null
> characters in QByteArray -> QString conversions, which breaks this test as
> one QByteArray contains nulls.  Instead, convert the QByteArray to const
> char * first, so QString stops at the first null.
> 
> The actual  behaviour of KConfig is unchanged, as internally the conversion
> always went through a const char *, which avoids creating QStrings with
> null characters.
> 
> 
> Diffs
> -
> 
>   autotests/kconfigtest.cpp 9a2998647b5e5f54d63059172b727505a8ae1c80 
> 
> Diff: https://git.reviewboard.kde.org/r/126001/diff/
> 
> 
> Testing
> ---
> 
> Tested on both Qt 5.5.1 and Qt 5.6 (commit 
> e996d68f6130847637ba287518cff1289cfa48e5), tests all pass now.
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 9, 2015, 1:18 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Changes
---

most issues adressed, will still give a try in having meaningful error codes 
for the jobs as well


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/
---

(Updated Nov. 9, 2015, 1:15 p.m.)


Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.


Repository: kpackage


Description
---

new job based update() function that compared to install()
if a package with the same pluginId is already installed,
removes the old one before installing the new one, if
and only if the version of the new one is more recent


Diffs (updated)
-

  autotests/plasmoidpackagetest.h f730dce 
  autotests/plasmoidpackagetest.cpp 567 
  src/kpackage/CMakeLists.txt 3696f37 
  src/kpackage/package.h 4ada8da 
  src/kpackage/package.cpp 539b21a 
  src/kpackage/packagestructure.h 9427b42 
  src/kpackage/packagestructure.cpp 0070514 
  src/kpackage/private/packagejob.cpp 0d2241b 
  src/kpackage/private/packagejob_p.h 267429f 
  src/kpackage/private/packagejobthread.cpp ca523b3 
  src/kpackage/private/packagejobthread_p.h bf8a266 
  src/kpackage/private/versionparser.cpp PRE-CREATION 
  src/kpackagetool/CMakeLists.txt 78e0fb0 

Diff: https://git.reviewboard.kde.org/r/125976/diff/


Testing
---

covered by autotests


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125976: add an update() method

2015-11-09 Thread Marco Martin 


> On Nov. 7, 2015, 2:03 p.m., Sebastian Kügler wrote:
> > src/kpackage/private/packagejobthread_p.h, line 58
> > 
> >
> > As you note yourself, perhaps just make it an enum? It's not private 
> > API, OK, but the code here is getting really convoluted that I think 
> > another boolean trap won't help...

if the enum stays in the private packagejobthread class it stays private enough.
as user facing api i would keep separate methods, like install, update and 
eventual new ones like updateUnconditionally or whatever


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125976/#review88138
---


On Nov. 6, 2015, 5:57 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125976/
> ---
> 
> (Updated Nov. 6, 2015, 5:57 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Kai Uwe Broulik.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> new job based update() function that compared to install()
> if a package with the same pluginId is already installed,
> removes the old one before installing the new one, if
> and only if the version of the new one is more recent
> 
> 
> Diffs
> -
> 
>   autotests/plasmoidpackagetest.h f730dce 
>   autotests/plasmoidpackagetest.cpp 567 
>   src/kpackage/CMakeLists.txt 3696f37 
>   src/kpackage/package.h 4ada8da 
>   src/kpackage/package.cpp 539b21a 
>   src/kpackage/packagestructure.h 9427b42 
>   src/kpackage/packagestructure.cpp 0070514 
>   src/kpackage/private/packagejob.cpp 0d2241b 
>   src/kpackage/private/packagejob_p.h 267429f 
>   src/kpackage/private/packagejobthread.cpp ca523b3 
>   src/kpackage/private/packagejobthread_p.h bf8a266 
>   src/kpackage/private/versionparser.cpp PRE-CREATION 
>   src/kpackagetool/CMakeLists.txt 78e0fb0 
> 
> Diff: https://git.reviewboard.kde.org/r/125976/diff/
> 
> 
> Testing
> ---
> 
> covered by autotests
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126004: add symlink verification tech

2015-11-09 Thread Harald Sitter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126004/
---

(Updated Nov. 9, 2015, 12:54 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 5fb092abc5961f4403ac87853ad2f524e62c0983 by Harald Sitter 
to branch master.


Repository: breeze-icons


Description
---

to ensure greatest possible compatibility icon names are often symlinked
to other names. unfortunately symlinks can easily break without anyone
noticing. the symlinktest is supposed to prevent this by iterating the
entire project tree's symlinks and checking if they are actually pointing
to something.
additionally symlinks must not point to out-of-tree files. even if valid.


Diffs
-

  COPYING.LIB PRE-CREATION 
  autotests/CMakeLists.txt PRE-CREATION 
  CMakeLists.txt 130b3346a6dc6dd86e65cc68bac6ccca19edf772 
  autotests/symlinktest.cpp PRE-CREATION 
  autotests/testdata.h.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126004/diff/


Testing
---

ctest with both conditions true and false (master actually doesn't pass right 
now :()


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126002/
---

(Updated Nov. 9, 2015, 12:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 751339bee84b1e7f559eaca484ce35577dad5b03 by David Faure 
to branch master.


Repository: karchive


Description
---

Fix KArchive for behavior change in Qt 5.6

Embedded NULs are now preserved when converting from QByteArray to QString.

+ remove unused var (separate commit)


Diffs
-

  autotests/karchivetest.cpp d9662f5faadf9f08f71a386c0f9ecc8ef89af23a 
  src/karchive.cpp e0a1eb2245767f9d605c44a6da481d290c2b15a5 
  src/ktar.cpp 824395e72e73b23f974614d5eff1fa58c7729dc0 

Diff: https://git.reviewboard.kde.org/r/126002/diff/


Testing
---

karchivetest passes again, with Qt 5.6 from git.

I complained about the behavior change on 
https://codereview.qt-project.org/106473


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [mostly OS X]: KDEHOME vs. ~/.kde best practices, *rc files and related questions

2015-11-09 Thread David Faure 
On Monday 09 November 2015 13:36:33 René J.V. Bertin wrote:
> Being more integrated is a worthy goal, but IMHO not so much if it comes at 
> the detriment of flexibility, for the (borderline) cases where that 
> integration is not desired. (And I wouldn't bet anything that you've been 
> able to foresee all such cases, as well as assess whether they will indeed 
> remain borderline cases ;) )

You would be right not to bet, because I did think about this. It means that 
when if I test multiple versions of KF5
in parallel in the future, using a different XDG_CONFIG_HOME, my non-kde apps 
will suddenly use a different
config directory as well. E.g. google-chrome in a plasma5-stable desktop and 
google-chrome in a plasma5-devel
desktop, assuming I want to separate the settings for these desktops, would 
also get separate settings.
I do call this a corner case though. In practice, when I had two self-compiled 
versions of kde4 installed,
I might run apps from either one, but never the full desktop. So I would only 
change the env in the terminal
where I would start devel apps, which doesn't affect non-kde apps being started 
from elsewhere.

> I don't see why one would expect an autotest to alter a desktop setting 
> persistently (i.e. not restore it).

Yes, that's a bug, you don't need to convince me that it's a bug, you need to 
look into fixing it :)

> >Sounds to me like you could make sonnet use IniFormat on all platforms.
> 
> I'm hoping that's what my patch does. If you're saying I could submit it for 
> review ... I guess I could do that :)

Yes.

> >We call setOrganizationDomain("kde.org") already, in many places (*), but it 
> >sounds like you found an app where that's missing.
> >(*) this is either done when main() calls KAboutData::setApplicationData 
> >(given that KAboutData defaults to domain=="kde.org")
> >or it might call qApp->setOrganizationDomain() directly.
> 
> Should the organisation domain be set to "kde.org" or to "org", given that 
> there is also QSettings::setOrganisationName()?

"kde.org". The domain is the full domain.

> >This made me search for kde.com in our source code and it seems some people 
> >got this wrong -- but that's not the bug you found :-)
> >http://lxr.kde.org/search?_filestring=&_string=%22kde.com%22
> 
> No, it's either my analysis above, or the simple fact that the autotests do 
> not call setOrganizationDomain(), which would be forgivable if it didn't lead 
> to the creation of a Sonnet settings file with an inappropriate domain.

Unittests *should* switch QSP to test mode anyway. They don't all do that, so 
for sure feel free to fix this by toggling
QSP to test mode in unittests that don't do it, especially if they use e.g. 
Sonnet.
This is a much better solution than just setting an org domain, because we 
don't want unittests to alter the user's settings.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126004: add symlink verification tech

2015-11-09 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126004/#review88189
---

Ship it!


Good stuff!

- Sebastian Kügler


On Nov. 9, 2015, 11:21 a.m., Harald Sitter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126004/
> ---
> 
> (Updated Nov. 9, 2015, 11:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> to ensure greatest possible compatibility icon names are often symlinked
> to other names. unfortunately symlinks can easily break without anyone
> noticing. the symlinktest is supposed to prevent this by iterating the
> entire project tree's symlinks and checking if they are actually pointing
> to something.
> additionally symlinks must not point to out-of-tree files. even if valid.
> 
> 
> Diffs
> -
> 
>   COPYING.LIB PRE-CREATION 
>   autotests/CMakeLists.txt PRE-CREATION 
>   CMakeLists.txt 130b3346a6dc6dd86e65cc68bac6ccca19edf772 
>   autotests/symlinktest.cpp PRE-CREATION 
>   autotests/testdata.h.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126004/diff/
> 
> 
> Testing
> ---
> 
> ctest with both conditions true and false (master actually doesn't pass right 
> now :()
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [mostly OS X]: KDEHOME vs. ~/.kde best practices, *rc files and related questions

2015-11-09 Thread René J . V . Bertin 
On Sunday November 08 2015 21:58:21 David Faure wrote:

>Not really. I do exactly that to run KF5 apps in a KDE4 desktop here.

Et te, Brutus? :)

>It's just a matter of writing your export statements in a file that you source
>before running a kf5 app (from a terminal). The sourcing of the env can be

Yeah. Not really what I had in mind, but you're right, it's feasible.

>But anyway the whole point is to let KF5 be more integrated with the rest
>of the system, while you're trying to make it less so ;)

Being more integrated is a worthy goal, but IMHO not so much if it comes at the 
detriment of flexibility, for the (borderline) cases where that integration is 
not desired. (And I wouldn't bet anything that you've been able to foresee all 
such cases, as well as assess whether they will indeed remain borderline cases 
;) )

>> Is it also possible that some autotest from KF5-solid messes up the 
>> Network-Manager state?
>
>Dunno, I thought we were talking about virtual desktops.

Rather about side-effects of running autotests, the number of virtual desktops 
only being an example.
BTW, even if you're guess was right I don't see why one would expect an 
autotest to alter a desktop setting persistently (i.e. not restore it).

>Sounds to me like you could make sonnet use IniFormat on all platforms.

I'm hoping that's what my patch does. If you're saying I could submit it for 
review ... I guess I could do that :)

>We call setOrganizationDomain("kde.org") already, in many places (*), but it 
>sounds like you found an app where that's missing.
>(*) this is either done when main() calls KAboutData::setApplicationData 
>(given that KAboutData defaults to domain=="kde.org")
>or it might call qApp->setOrganizationDomain() directly.

Should the organisation domain be set to "kde.org" or to "org", given that 
there is also QSettings::setOrganisationName()?
Besides, the QSettings documentation says
"If you want to specify a different domain name, call 
QCoreApplication::setOrganizationDomain(), 
QCoreApplication::setOrganizationName(), and 
QCoreApplication::setApplicationName() in your main() function and then use the 
default QSettings constructor"

which I read as "use QSettings::QSettings() and not any of the other 
constructors"; that's also the only way to be sure 
QSettings::setDefaultFormat() is actually used.

>Sounds like you need to check all apps ;)

I'm not sure I care enough to start searching all apps other than on a 
case-by-case basis when I catch one being naughty ;)

>
>This made me search for kde.com in our source code and it seems some people 
>got this wrong -- but that's not the bug you found :-)
>http://lxr.kde.org/search?_filestring=&_string=%22kde.com%22

No, it's either my analysis above, or the simple fact that the autotests do not 
call setOrganizationDomain(), which would be forgivable if it didn't lead to 
the creation of a Sonnet settings file with an inappropriate domain.

R.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 135 - Still Unstable!

2015-11-09 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/135/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 09 Nov 2015 12:28:37 +
Build duration: 2 min 59 sec

CHANGE SET
Revision 29c53a82bf283978a6f8a120ea08d552cdd626d4 by Marco Martin: (adjust 
margins to make tests pass)
  change: edit src/desktoptheme/breeze/dialogs/background.svgz
  change: edit src/desktoptheme/breeze/translucent/dialogs/background.svgz


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3917/10053 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 544/565 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2010 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3640 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 481/1785 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 126 - Still Unstable!

2015-11-09 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/126/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 09 Nov 2015 12:28:37 +
Build duration: 1 min 54 sec

CHANGE SET
Revision 29c53a82bf283978a6f8a120ea08d552cdd626d4 by Marco Martin: (adjust 
margins to make tests pass)
  change: edit src/desktoptheme/breeze/translucent/dialogs/background.svgz
  change: edit src/desktoptheme/breeze/dialogs/background.svgz


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3908/10015 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 543/564 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 355/2009 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3635 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 942/1739 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/184 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 480/1771 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Milian Wolff 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126002/#review88182
---

Ship it!


ouch, I was bitten by that in KDevelop as well...


src/ktar.cpp (line 292)


I agree with Nick, here and below it could be QByteArray::fromRawData. But 
that's an optimization and we could get this in first as a fix and optimize 
later on.


- Milian Wolff


On Nov. 9, 2015, 7:54 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126002/
> ---
> 
> (Updated Nov. 9, 2015, 7:54 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fix KArchive for behavior change in Qt 5.6
> 
> Embedded NULs are now preserved when converting from QByteArray to QString.
> 
> + remove unused var (separate commit)
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d9662f5faadf9f08f71a386c0f9ecc8ef89af23a 
>   src/karchive.cpp e0a1eb2245767f9d605c44a6da481d290c2b15a5 
>   src/ktar.cpp 824395e72e73b23f974614d5eff1fa58c7729dc0 
> 
> Diff: https://git.reviewboard.kde.org/r/126002/diff/
> 
> 
> Testing
> ---
> 
> karchivetest passes again, with Qt 5.6 from git.
> 
> I complained about the behavior change on 
> https://codereview.qt-project.org/106473
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126004: add symlink verification tech

2015-11-09 Thread Harald Sitter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126004/
---

Review request for KDE Frameworks.


Repository: breeze-icons


Description
---

to ensure greatest possible compatibility icon names are often symlinked
to other names. unfortunately symlinks can easily break without anyone
noticing. the symlinktest is supposed to prevent this by iterating the
entire project tree's symlinks and checking if they are actually pointing
to something.
additionally symlinks must not point to out-of-tree files. even if valid.


Diffs
-

  COPYING.LIB PRE-CREATION 
  autotests/CMakeLists.txt PRE-CREATION 
  CMakeLists.txt 130b3346a6dc6dd86e65cc68bac6ccca19edf772 
  autotests/symlinktest.cpp PRE-CREATION 
  autotests/testdata.h.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126004/diff/


Testing
---

ctest with both conditions true and false (master actually doesn't pass right 
now :()


Thanks,

Harald Sitter

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

2015-11-09 Thread Alex Merry 

On 2015-11-09 11:11, Alex Merry wrote:

On 2015-11-09 08:18, David Faure wrote:

On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote:

Does anybody have problems building rocs?

It builds fine here but CI complains
  
https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/console


Maybe it fails with KF 5.16? Can anyone using that give a try to 
compile rocs from the Applications/15.08 branch?


It builds fine for me (from git, both master and Applications/15.08)
with KF 5.16 and  Qt 5.6.

And the json file mentionned in the error message does get generated
in the builddir.

It looks like it's a dependency problem: I tried on the CI node, and
it fails with -j8 because
the json file doesn't get generated before moc needs it. If I type
make again, everything's fine.

cmake 3.2.2
Qt 5.4.3

Locally I have cmake 3.4.0-rc3, dunno if this is the issue.


I've just tried locally with CMake 3.2.2, and it seems to generate the
correct Makefile code (you can have a look at
libgraphtheory/fileformats/tgf/CMakeFiles/tgffileformat_automoc.dir/build.make
and see that tgffileformat_automoc depends on tgffileformat.json).

The Qt version *should* be irrelevant - the generation of this bit of
Makefile should be dependent only on CMake itself and the
desktop_to_json macro from KCoreAddons.



The generated Makefiles on CI also look correct, although the last build 
was successful, so I haven't actually looked at the Makefiles of a 
failing build.


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

2015-11-09 Thread Alex Merry 

On 2015-11-09 08:18, David Faure wrote:

On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote:

Does anybody have problems building rocs?

It builds fine here but CI complains
  
https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/console


Maybe it fails with KF 5.16? Can anyone using that give a try to 
compile rocs from the Applications/15.08 branch?


It builds fine for me (from git, both master and Applications/15.08)
with KF 5.16 and  Qt 5.6.

And the json file mentionned in the error message does get generated
in the builddir.

It looks like it's a dependency problem: I tried on the CI node, and
it fails with -j8 because
the json file doesn't get generated before moc needs it. If I type
make again, everything's fine.

cmake 3.2.2
Qt 5.4.3

Locally I have cmake 3.4.0-rc3, dunno if this is the issue.


I've just tried locally with CMake 3.2.2, and it seems to generate the 
correct Makefile code (you can have a look at 
libgraphtheory/fileformats/tgf/CMakeFiles/tgffileformat_automoc.dir/build.make 
and see that tgffileformat_automoc depends on tgffileformat.json).


The Qt version *should* be irrelevant - the generation of this bit of 
Makefile should be dependent only on CMake itself and the 
desktop_to_json macro from KCoreAddons.


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Nick Shaforostoff 


> On Nov. 9, 2015, 10:42 a.m., Nick Shaforostoff wrote:
> > src/ktar.cpp, line 293
> > 
> >
> > why can't we just use QFile::decodeName(const char * localFileName) 
> > overload?

ok, there is a limit of 100. then i suggest using 
QByteArray::fromRawData(buffer, qstrnlen(buffer, 100)) because qbytearray 
object is 100% temporary.


- Nick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126002/#review88178
---


On Nov. 9, 2015, 7:54 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126002/
> ---
> 
> (Updated Nov. 9, 2015, 7:54 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fix KArchive for behavior change in Qt 5.6
> 
> Embedded NULs are now preserved when converting from QByteArray to QString.
> 
> + remove unused var (separate commit)
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d9662f5faadf9f08f71a386c0f9ecc8ef89af23a 
>   src/karchive.cpp e0a1eb2245767f9d605c44a6da481d290c2b15a5 
>   src/ktar.cpp 824395e72e73b23f974614d5eff1fa58c7729dc0 
> 
> Diff: https://git.reviewboard.kde.org/r/126002/diff/
> 
> 
> Testing
> ---
> 
> karchivetest passes again, with Qt 5.6 from git.
> 
> I complained about the behavior change on 
> https://codereview.qt-project.org/106473
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126002: Fix KArchive for behavior change in Qt 5.6

2015-11-09 Thread Nick Shaforostoff 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126002/#review88178
---



src/ktar.cpp (line 292)


why can't we just use QFile::decodeName(const char * localFileName) 
overload?


- Nick Shaforostoff


On Nov. 9, 2015, 7:54 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126002/
> ---
> 
> (Updated Nov. 9, 2015, 7:54 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> Fix KArchive for behavior change in Qt 5.6
> 
> Embedded NULs are now preserved when converting from QByteArray to QString.
> 
> + remove unused var (separate commit)
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d9662f5faadf9f08f71a386c0f9ecc8ef89af23a 
>   src/karchive.cpp e0a1eb2245767f9d605c44a6da481d290c2b15a5 
>   src/ktar.cpp 824395e72e73b23f974614d5eff1fa58c7729dc0 
> 
> Diff: https://git.reviewboard.kde.org/r/126002/diff/
> 
> 
> Testing
> ---
> 
> karchivetest passes again, with Qt 5.6 from git.
> 
> I complained about the behavior change on 
> https://codereview.qt-project.org/106473
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 134 - Still Unstable!

2015-11-09 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/134/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 09 Nov 2015 10:11:57 +
Build duration: 2 min 48 sec

CHANGE SET
Revision e95de3346504e3a0255135698410c77758139b4d by Martin Gräßlin: 
([declarativeimports/core] Drop xcb shape dependency as it's unused)
  change: edit src/declarativeimports/core/CMakeLists.txt
Revision 286300ad35dbbe2fbe0e9e9b0d8394468ce2a124 by Martin Gräßlin: (Use newer 
cmake syntax for XCB dependencies)
  change: edit src/declarativeimports/core/CMakeLists.txt
  change: edit src/plasma/CMakeLists.txt
  change: edit src/plasmaquick/CMakeLists.txt
Revision fae8384845283a12ef8697d9586411fbfea1c86d by Martin Gräßlin: 
([declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h)
  change: edit src/declarativeimports/core/windowthumbnail.h
  change: edit src/declarativeimports/core/config-x11.h.cmake
  change: edit src/declarativeimports/core/CMakeLists.txt
Revision de0f7d93a8f535be244d4733360205b7c44ac51b by Martin Gräßlin: 
([plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency)
  change: edit src/plasmaquick/CMakeLists.txt
Revision 9030405089bd9cc5ac663913d828e70939c69716 by Martin Gräßlin: 
([plasmaquick] Don't link OpenGL explicitly)
  change: edit src/plasmaquick/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3917/10053 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 544/565 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 356/2010 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1591/3640 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 945/1746 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/194 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 481/1785 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 125 - Still Unstable!

2015-11-09 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/125/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 09 Nov 2015 10:11:57 +
Build duration: 2 min 49 sec

CHANGE SET
Revision e95de3346504e3a0255135698410c77758139b4d by Martin Gräßlin: 
([declarativeimports/core] Drop xcb shape dependency as it's unused)
  change: edit src/declarativeimports/core/CMakeLists.txt
Revision 286300ad35dbbe2fbe0e9e9b0d8394468ce2a124 by Martin Gräßlin: (Use newer 
cmake syntax for XCB dependencies)
  change: edit src/plasma/CMakeLists.txt
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/declarativeimports/core/CMakeLists.txt
Revision fae8384845283a12ef8697d9586411fbfea1c86d by Martin Gräßlin: 
([declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h)
  change: edit src/declarativeimports/core/windowthumbnail.h
  change: edit src/declarativeimports/core/config-x11.h.cmake
  change: edit src/declarativeimports/core/CMakeLists.txt
Revision de0f7d93a8f535be244d4733360205b7c44ac51b by Martin Gräßlin: 
([plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency)
  change: edit src/plasmaquick/CMakeLists.txt
Revision 9030405089bd9cc5ac663913d828e70939c69716 by Martin Gräßlin: 
([plasmaquick] Don't link OpenGL explicitly)
  change: edit src/plasmaquick/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.dialognativetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 63/104 (61%)CLASSES 63/104 (61%)LINE 3908/10015 
(39%)CONDITIONAL 1917/3034 (63%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 543/564 
(96%)CONDITIONAL 338/606 (56%)
src.declarativeimports.core
FILES 7/20 (35%)CLASSES 7/20 (35%)LINE 355/2009 
(18%)CONDITIONAL 148/228 (65%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1588/3635 
(44%)CONDITIONAL 776/1192 (65%)
src.plasma.private
FILES 18/26 (69%)CLASSES 18/26 (69%)LINE 942/1739 
(54%)CONDITIONAL 395/600 (66%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/184 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 4/11 (36%)CLASSES 4/11 (36%)LINE 480/1771 
(27%)CONDITIONAL 260/408 (64%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125975: X11 build system cleanup

2015-11-09 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125975/
---

(Updated Nov. 9, 2015, 10:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Plasma and Marco Martin.


Changes
---

Submitted with commit 9030405089bd9cc5ac663913d828e70939c69716 by Martin 
Gräßlin to branch master.


Repository: plasma-framework


Description
---

Use newer cmake syntax for XCB dependencies


[declarativeimports/core] Specify HAVE_XCB_COMPOSITE in config-x11.h


[plasmaquick] Drop XCB::COMPOSITE and DAMAGE dependency

Not used

[plasmaquick] Don't link OpenGL explicitly

Not needed and anyway pulled in from Qt.


Diffs
-

  src/declarativeimports/core/CMakeLists.txt 
0265d5999dcec533b04f6b38ac2f345ea57f966d 
  src/declarativeimports/core/config-x11.h.cmake 
89858d17de239cfc7eed1f40a8b828803de3299c 
  src/declarativeimports/core/windowthumbnail.h 
576b053229a8cfc15b6fadd8d4e6ff07f937565d 
  src/plasma/CMakeLists.txt 73f308cf5ac8371c1d259c335edcb069117c5c11 
  src/plasmaquick/CMakeLists.txt 1ddc61123e2a061b42d14cbd1065a70458fdd2d7 

Diff: https://git.reviewboard.kde.org/r/125975/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: icon frameworks

2015-11-09 Thread Harald Sitter 
On Sat, Nov 7, 2015 at 8:35 PM, David Faure  wrote:
> On Saturday 07 November 2015 10:04:52 David Faure wrote:
>>
>> Did you check the list from
>> https://community.kde.org/Frameworks/CreationGuidelines
>> ?
>>
>> At first sight I see already one thing missing: no CI job under
>> https://build.kde.org/view/Frameworks%20kf5-qt5/
>
> To get this moving (since it's blocking the release) I looked into
> adding it myself but I don't have permissions or maybe I forgot
> how to go about doing that.

Mh. This was in fact not the page I was looking at, must be blind or
something. I'll take a look at all the points.

Sorry for the trouble.

HS
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: rocs fails to compile? - was -Re: KDE Applications 15.08.3 available for packagers

2015-11-09 Thread David Faure 
On Sunday 08 November 2015 22:21:18 Albert Astals Cid wrote:
> Does anybody have problems building rocs?
> 
> It builds fine here but CI complains 
>   
> https://build.kde.org/job/rocs%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/16/console
> 
> Maybe it fails with KF 5.16? Can anyone using that give a try to compile rocs 
> from the Applications/15.08 branch?

It builds fine for me (from git, both master and Applications/15.08) with KF 
5.16 and  Qt 5.6.

And the json file mentionned in the error message does get generated in the 
builddir.

It looks like it's a dependency problem: I tried on the CI node, and it fails 
with -j8 because
the json file doesn't get generated before moc needs it. If I type make again, 
everything's fine.

cmake 3.2.2
Qt 5.4.3

Locally I have cmake 3.4.0-rc3, dunno if this is the issue.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel