Re: Menu/Command capitalization

2016-01-07 Thread Pino Toscano 
Hi,

In data giovedì 7 gennaio 2016 22:42:18, Jaroslaw Staniek ha scritto:
> Not too long ago MS Windows has moved from "Title Capitalization" to
> "Sentence capitalization" for menus and commands:
> https://msdn.microsoft.com/en-us/library/dn742392.aspx
> 
> What can we do and should we do something about this?

Nothing IMHO -- see below.

> - For everyone else perhaps it's better to offer something officially
> or else some people would fork translations or avoid using KDE's code.

You don't need to fork anything, just provide a "translation" on top of
the untranslated strings.

> - Is automated conversion for capitalization a reasonable approach?
> Runtime or script-based generation.

Definitely not: please never ever mess up with user-visible strings.

> - Do we have checks for semantic strings and capitalization? If so
> would they need updates, or?

By hand, when somebody spots a mistake and fixes it.

> - Some (future?) KF5 users would target Windows expecting that the
> resulting apps look and feel largely native.

> [...]

> - Mac OS X and iOS is consistent with KDE capitalization:
>   
> https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/2957-CH15-SW4

To simplify the situation:
- right now we are like OS-A but different than OS-B
- with your proposal, we would be like OS-B but different than OS-A
So, there would be always a class of users feeling "native" (regarding
the string capitalization),  and another one feeling "alien".

Sorry, but I don't see how mass-changing English strings, to end up in
the very same situation (1 like, 1 different) wrt other OSes. At least
for me, it has been hard enough to keep KDE applications following our
style in the last 10+ years, I don't want to start over again.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126670/#review90784
---

Ship it!


I did it myself because you're a GCI student, but besides compilation, you 
should have checked if tests still pass and specified so in the testing field.

The change looks, good. Thanks!

- Aleix Pol Gonzalez


On Jan. 8, 2016, 2:15 a.m., Andrey Cygankov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126670/
> ---
> 
> (Updated Jan. 8, 2016, 2:15 a.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> Fix some Clazy warnings:
> - qstring-uneeded-heap-allocations
> - isempty-vs-count
> - detaching-temporary
> - variant-sanitizer
> 
> 
> Diffs
> -
> 
>   autotests/persondatatests.cpp 43a7c7b 
>   autotests/personsmodeltest.cpp 1cbc3dc 
>   examples/contactlistwidgets.cpp 56bb01c 
>   examples/personwidget.cpp b4d73c8 
>   src/personmanager.cpp 5c3d3e1 
>   src/personpluginmanager.cpp f5396d9 
>   src/widgets/actions.cpp ffaf16f 
>   src/widgets/mergedelegate.cpp 01c988d 
>   src/widgets/persondetailsview.cpp 7e4e24f 
> 
> Diff: https://git.reviewboard.kde.org/r/126670/diff/
> 
> 
> Testing
> ---
> 
> Compiling without errors.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-07 Thread Andrey Cygankov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126670/
---

(Updated Jan. 8, 2016, 2:15 a.m.)


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Summary (updated)
-

Fix some Clazy warnings in KPeople framework


Repository: kpeople


Description
---

Fix some Clazy warnings:
- qstring-uneeded-heap-allocations
- isempty-vs-count
- detaching-temporary
- variant-sanitizer


Diffs
-

  autotests/persondatatests.cpp 43a7c7b 
  autotests/personsmodeltest.cpp 1cbc3dc 
  examples/contactlistwidgets.cpp 56bb01c 
  examples/personwidget.cpp b4d73c8 
  src/personmanager.cpp 5c3d3e1 
  src/personpluginmanager.cpp f5396d9 
  src/widgets/actions.cpp ffaf16f 
  src/widgets/mergedelegate.cpp 01c988d 
  src/widgets/persondetailsview.cpp 7e4e24f 

Diff: https://git.reviewboard.kde.org/r/126670/diff/


Testing
---

Compiling without errors.


Thanks,

Andrey Cygankov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126665: [GCI] Fix clazy's issues in tests.

2016-01-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126665/#review90783
---

Ship it!


Do you have push rights?

- Aleix Pol Gonzalez


On Jan. 7, 2016, 7:28 p.m., Mihail Ivchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126665/
> ---
> 
> (Updated Jan. 7, 2016, 7:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> GCI task: 
> https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -
> 
>   autotests/fallbackpackagetest.cpp 6e33195 
>   autotests/packagestructuretest.cpp 0b9787e 
>   autotests/plasmoidpackagetest.cpp a22c732 
>   autotests/plasmoidstructure.h 9b5b7b8 
>   autotests/querytest.cpp 854bb21 
> 
> Diff: https://git.reviewboard.kde.org/r/126665/diff/
> 
> 
> Testing
> ---
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126664: [GCI] Apply qstring-related clazy fixes to tests.

2016-01-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126664/#review90782
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Jan. 7, 2016, 7:28 p.m., Mihail Ivchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126664/
> ---
> 
> (Updated Jan. 7, 2016, 7:28 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> QLatin1String -> QStringLiteral where it makes sense.
> Raw string literals -> QStringLiteral.
> GCI task: 
> https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -
> 
>   autotests/fallbackpackagetest.cpp 6e33195 
>   autotests/packagestructuretest.cpp 0b9787e 
>   autotests/plasmoidpackagetest.cpp a22c732 
>   autotests/plasmoidstructure.cpp 4fefbf4 
>   autotests/querytest.cpp 854bb21 
> 
> Diff: https://git.reviewboard.kde.org/r/126664/diff/
> 
> 
> Testing
> ---
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-07 Thread Sergey Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126672/
---

(Updated Янв. 8, 2016, 1:34 д.п.)


Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez.


Repository: plasma-framework


Description
---

Fix almost all the Clazy warnings in plasma-framework.

Related GCI-2015 task: 
[https://codein.withgoogle.com/tasks/6272625345036288/](https://codein.withgoogle.com/tasks/6272625345036288/)


Diffs
-

  autotests/coronatest.cpp 378a4b7 
  autotests/dialogqmltest.cpp 618e64d 
  autotests/fallbackpackagetest.cpp 91bc6e9 
  autotests/packagestructuretest.cpp 67cdb4f 
  autotests/pluginloadertest.cpp 868d5f8 
  autotests/sortfiltermodeltest.cpp 6ee0e35 
  autotests/storagetest.cpp 8a7dbd0 
  src/declarativeimports/calendar/calendar.cpp 5515550 
  src/declarativeimports/calendar/daysmodel.cpp 0f81b5a 
  src/declarativeimports/core/corebindingsplugin.cpp adfdc29 
  src/declarativeimports/core/datamodel.cpp 4449f30 
  src/declarativeimports/core/datasource.cpp 4fe5dc5 
  src/declarativeimports/core/tooltip.cpp a5e223b 
  src/declarativeimports/core/tooltipdialog.cpp 6c3712e 
  src/declarativeimports/core/units.cpp 1798727 
  src/declarativeimports/core/windowthumbnail.cpp 21e655e 
  src/declarativeimports/plasmacomponents/plasmacomponentsplugin.cpp 9e924b3 
  src/declarativeimports/plasmacomponents/qmenuitem.cpp 287e9b3 
  src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp 
1a25f06 
  src/plasma/applet.cpp 4ce2d28 
  src/plasma/containment.cpp 0beb196 
  src/plasma/containmentactions.cpp f42807f 
  src/plasma/corona.cpp bae9244 
  src/plasma/datacontainer.cpp 396bc6d 
  src/plasma/dataengine.cpp dd56807 
  src/plasma/dataengineconsumer.cpp 7c9b5f9 
  src/plasma/framesvg.cpp 81187dc 
  src/plasma/package.cpp 09f36f3 
  src/plasma/packagestructure.cpp 09ea698 
  src/plasma/pluginloader.cpp d7c49f2 
  src/plasma/private/applet_p.cpp 949c92e 
  src/plasma/private/associatedapplicationmanager.cpp e1620e9 
  src/plasma/private/componentinstaller.cpp 8fbef24 
  src/plasma/private/containment_p.cpp 09ed2cd 
  src/plasma/private/dataenginemanager.cpp 7862171 
  src/plasma/private/packages.cpp 1edd55a 
  src/plasma/private/service_p.h 8a48487 
  src/plasma/private/storage.cpp bc6992e 
  src/plasma/private/storagethread.cpp 91b490b 
  src/plasma/private/svg_p.h 1d1000d 
  src/plasma/private/theme_p.cpp 18419bb 
  src/plasma/private/timetracker.cpp cdfe94b 
  src/plasma/scripting/scriptengine.cpp b9f43fe 
  src/plasma/service.cpp d603cf2 
  src/plasma/svg.cpp 28abd00 
  src/plasma/theme.cpp e9420e6 
  src/plasmapkg/main.cpp 336b14e 
  src/plasmapkg/plasmapkg.cpp 4626323 
  src/plasmaquick/appletquickitem.cpp ec2ed24 
  src/plasmaquick/configmodel.cpp df537c1 
  src/plasmaquick/configview.cpp c4ab518 
  src/plasmaquick/dialog.cpp 8f4ee57 
  src/plasmaquick/dialogshadows.cpp db408ae 
  src/plasmaquick/dialogshadows_p.h 7e17c12 
  src/plasmaquick/packageurlinterceptor.cpp 5e349d2 
  src/plasmaquick/private/packages.h aa08b11 
  src/plasmaquick/private/packages.cpp 5275848 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 31285a2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp b15695b 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp 9ecd62b 
  tests/dpi/main.cpp 6767b2d 
  tests/kplugins/main.cpp 421e3fb 
  tests/kplugins/plugintest.h a99701a 
  tests/kplugins/plugintest.cpp 3d98dec 
  tests/testengine/testengine.cpp 76947c3 

Diff: https://git.reviewboard.kde.org/r/126672/diff/


Testing
---

Tests passed


Thanks,

Sergey Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

2016-01-07 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/#review90743
---



src/ioslaves/ftp/ftp.cpp (line 1775)


The porting bug is here. In kdelibs4 tmptr was initialized to the current 
date, and used below.

Now we have two variables, "int year" and "currentTime.year".

To be closer to the orig code and to avoid risking that the day or month is 
still 0 as well, I would suggest to initialize year, day and month directly 
from currentTime, rather than to 0.

I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because 
that's unused (right?)



src/ioslaves/ftp/ftp.cpp (line 1797)


yes, this is a QDate behaviour change in Qt5.


- David Faure


On Jan. 7, 2016, 10 a.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126659/
> ---
> 
> (Updated Jan. 7, 2016, 10 a.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 354597
> https://bugs.kde.org/show_bug.cgi?id=354597
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> - QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so 
> subtracting 1900 is wrong.
> - in the case when no year is mentioned in the server's reply (the year is 
> implicit), it wasn't set to the current year, so the result was either 0 or 
> -1.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/ftp/ftp.cpp 2179179 
> 
> Diff: https://git.reviewboard.kde.org/r/126659/diff/
> 
> 
> Testing
> ---
> 
> Connected to an FTP server with dolphin (15.12.0). The modification 
> times/dates are now shown correctly.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126651: Fix wrong documentation for KIconTheme::iconPath

2016-01-07 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126651/#review90736
---

Ship it!


Yep, copy/paste error from one layer above, KIconLoader.

- David Faure


On Jan. 6, 2016, 8:28 a.m., Holger Kaelberer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126651/
> ---
> 
> (Updated Jan. 6, 2016, 8:28 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kiconthemes
> 
> 
> Description
> ---
> 
> name has to be passed \*with\* extension
> 
> 
> Diffs
> -
> 
>   src/kicontheme.h ca04879 
> 
> Diff: https://git.reviewboard.kde.org/r/126651/diff/
> 
> 
> Testing
> ---
> 
> kapidox output looks fine
> 
> 
> Thanks,
> 
> Holger Kaelberer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

2016-01-07 Thread Wolfgang Bauer 


> On Jan. 7, 2016, 12:15 nachm., David Faure wrote:
> > src/ioslaves/ftp/ftp.cpp, line 1797
> > 
> >
> > yes, this is a QDate behaviour change in Qt5.

According to the documentation, QDate's behaviour was the same in Qt4.
But kio_ftp didn't use QDate for this in kdelibs4... ;-)


> On Jan. 7, 2016, 12:15 nachm., David Faure wrote:
> > src/ioslaves/ftp/ftp.cpp, line 1775
> > 
> >
> > The porting bug is here. In kdelibs4 tmptr was initialized to the 
> > current date, and used below.
> > 
> > Now we have two variables, "int year" and "currentTime.year".
> > 
> > To be closer to the orig code and to avoid risking that the day or 
> > month is still 0 as well, I would suggest to initialize year, day and month 
> > directly from currentTime, rather than to 0.
> > 
> > I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) 
> > because that's unused (right?)

> To be closer to the orig code and to avoid risking that the day or month is 
> still 0 as well, I would suggest to initialize year, day and month directly 
> from currentTime, rather than to 0.

Well, if we don't know the values, taking them from currentTime is likely just 
as wrong as setting them to 0.
But ok, I'll change it.

> I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) because 
> that's unused (right?)

Right, it is unused AFAICS.
Actually we could also just use QDate::currentDate() instead of 
QDateTime::currentDateTime() IMHO.


- Wolfgang


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/#review90743
---


On Jan. 7, 2016, 11 vorm., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126659/
> ---
> 
> (Updated Jan. 7, 2016, 11 vorm.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 354597
> https://bugs.kde.org/show_bug.cgi?id=354597
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> - QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so 
> subtracting 1900 is wrong.
> - in the case when no year is mentioned in the server's reply (the year is 
> implicit), it wasn't set to the current year, so the result was either 0 or 
> -1.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/ftp/ftp.cpp 2179179 
> 
> Diff: https://git.reviewboard.kde.org/r/126659/diff/
> 
> 
> Testing
> ---
> 
> Connected to an FTP server with dolphin (15.12.0). The modification 
> times/dates are now shown correctly.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

2016-01-07 Thread Wolfgang Bauer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/
---

(Updated Jan. 7, 2016, 1:21 nachm.)


Review request for KDE Frameworks, kdelibs and David Faure.


Changes
---

- Use QDate::currentDate() instead of QDateTime::currentDateTime(), we only 
need the date anyway
- initialize day, month, and year to the current date instead of 0


Bugs: 354597
https://bugs.kde.org/show_bug.cgi?id=354597


Repository: kio


Description
---

- QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so 
subtracting 1900 is wrong.
- in the case when no year is mentioned in the server's reply (the year is 
implicit), it wasn't set to the current year, so the result was either 0 or -1.


Diffs (updated)
-

  src/ioslaves/ftp/ftp.cpp 2179179 

Diff: https://git.reviewboard.kde.org/r/126659/diff/


Testing
---

Connected to an FTP server with dolphin (15.12.0). The modification times/dates 
are now shown correctly.


Thanks,

Wolfgang Bauer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126659: [kio_ftp] fix display of file/directory modification time/date

2016-01-07 Thread David Faure 


> On Jan. 7, 2016, 11:15 a.m., David Faure wrote:
> > src/ioslaves/ftp/ftp.cpp, line 1775
> > 
> >
> > The porting bug is here. In kdelibs4 tmptr was initialized to the 
> > current date, and used below.
> > 
> > Now we have two variables, "int year" and "currentTime.year".
> > 
> > To be closer to the orig code and to avoid risking that the day or 
> > month is still 0 as well, I would suggest to initialize year, day and month 
> > directly from currentTime, rather than to 0.
> > 
> > I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) 
> > because that's unused (right?)
> 
> Wolfgang Bauer wrote:
> > To be closer to the orig code and to avoid risking that the day or 
> month is still 0 as well, I would suggest to initialize year, day and month 
> directly from currentTime, rather than to 0.
> 
> Well, if we don't know the values, taking them from currentTime is likely 
> just as wrong as setting them to 0.
> But ok, I'll change it.
> 
> > I guess we can also remove the "currentTime.setTime(QTime(0,0,0)) 
> because that's unused (right?)
> 
> Right, it is unused AFAICS.
> Actually we could also just use QDate::currentDate() instead of 
> QDateTime::currentDateTime() IMHO.

"likely just as wrong" - well with 0 the QDateTime would be invalid, making the 
whole information disappear (even e.g. the valid time information). So using 
the current datetime (as kdelibs4 did) seems better.

Agreed about currentDate().


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126659/#review90743
---


On Jan. 7, 2016, 12:23 p.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126659/
> ---
> 
> (Updated Jan. 7, 2016, 12:23 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs and David Faure.
> 
> 
> Bugs: 354597
> https://bugs.kde.org/show_bug.cgi?id=354597
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> - QDate() treats the year literally (i.e. 90 is really year 90, not 1990), so 
> subtracting 1900 is wrong.
> - Use QDate::currentDate() instead of QDateTime::currentDateTime(), we only 
> need the current date anyway
> - Initialize day, month, and year to the current date instead of 0. In the 
> case when no year is mentioned in the server's reply (the year is implicit), 
> it wasn't set to the current year at all, so the result was either 0 or -1.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/ftp/ftp.cpp 2179179 
> 
> Diff: https://git.reviewboard.kde.org/r/126659/diff/
> 
> 
> Testing
> ---
> 
> Connected to an FTP server with dolphin (15.12.0). The modification 
> times/dates are now shown correctly.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126662: [GCI] Fix clazy's issues in core lib.

2016-01-07 Thread Mihail Ivchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126662/
---

Review request for KDE Frameworks.


Repository: kpackage


Description
---

GCI task: 
https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/


Diffs
-

  src/kpackagetool/kpackagetool.cpp 61a0043 
  src/kpackage/private/packages_p.h 27b8ed9 
  src/kpackage/packageloader.cpp 9f7dd48 

Diff: https://git.reviewboard.kde.org/r/126662/diff/


Testing
---

Tests passed


Thanks,

Mihail Ivchenko

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Andreas Hartmetz 


> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote:
> > src/kpackage/packageloader.cpp, line 190
> > 
> >
> > What does the category have to do with this? We should only be going by 
> > the id (the plugin name).
> 
> Andreas Hartmetz wrote:
> Depends on the scope in which an ID is guaranteed to be unique. If it's 
> guaranteed to be globally unique and independent of category, sure, I'm all 
> for not making it more complicated than necessary.

Given that the ID falls back to the metadata file name without extension, and 
that you can have the same file name in different directories, it seems like 
you *could* have a package of the same name in different categories. The same 
goes for names supplied by the data in the metadata files. Some names make 
sense in several places.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126660/#review90755
---


On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126660/
> ---
> 
> (Updated Jan. 7, 2016, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> That was a problem in a scenario such as mine, where I have distro
> packages and self compiled packages. There were (from the UI)
> indistinguishable, duplicate packages in the panel's add applets
> UI, in the tray config dialog's "additional items" section, and
> probably in other places, too.
> Note that requiring to have no duplicate packages in XDG_DATA_DIRS
> by removing entries from XGD_DATA_DIRS doesn't fly because /usr
> cannot be removed for the non-KF5 things that it brings.
> 
> 
> Diffs
> -
> 
>   src/kpackage/packageloader.cpp 9f7dd48 
> 
> Diff: https://git.reviewboard.kde.org/r/126660/diff/
> 
> 
> Testing
> ---
> 
> Checked for duplicate entries in "add applets" and tray config dialog, no 
> duplicates anymore. Also no duplicates anymore in KWin effects KCM.
> 
> 
> Thanks,
> 
> Andreas Hartmetz
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

2016-01-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126661/#review90761
---



src/kpackage/package.cpp (line 227)


this should be `endsWith(QLatin1Char('/'))`


- Aleix Pol Gonzalez


On Jan. 7, 2016, 4:41 p.m., Mihail Ivchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126661/
> ---
> 
> (Updated Jan. 7, 2016, 4:41 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> QLatin1String -> QStringLiteral where it makes sense.
> Raw string literals -> QStringLiteral and QLatin1String (where possible).
> GCI task: 
> https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -
> 
>   src/kpackage/private/packagejobthread.cpp b7f5d2d 
>   src/kpackage/package.cpp d210015 
>   src/kpackage/packageloader.cpp 9f7dd48 
>   src/kpackage/private/packages.cpp 3de80a0 
>   src/kpackagetool/kpackagetool.cpp 61a0043 
>   src/kpackagetool/main.cpp 453f3e8 
> 
> Diff: https://git.reviewboard.kde.org/r/126661/diff/
> 
> 
> Testing
> ---
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Sebastian Kügler 


> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote:
> > src/kpackage/packageloader.cpp, line 190
> > 
> >
> > What does the category have to do with this? We should only be going by 
> > the id (the plugin name).
> 
> Andreas Hartmetz wrote:
> Depends on the scope in which an ID is guaranteed to be unique. If it's 
> guaranteed to be globally unique and independent of category, sure, I'm all 
> for not making it more complicated than necessary.
> 
> Andreas Hartmetz wrote:
> Given that the ID falls back to the metadata file name without extension, 
> and that you can have the same file name in different directories, it seems 
> like you *could* have a package of the same name in different categories. The 
> same goes for names supplied by the data in the metadata files. Some names 
> make sense in several places.
> 
> Andreas Hartmetz wrote:
> Sorry, the part about the filename doesn't apply. It comes from the 
> documentation of KPluginMetaData::pluginId() which doesn't apply here, given 
> that the files are all called metadata.desktop or metadata.json.

Yes, and the directory name is actually the same as the plugin name -- you can 
rely on that. So just a stringlist would in fact already be enough, but as I 
said ... why not use lst to check if it's already in there. Performance, I 
guess?

But yes, the only thing we need to look at is the plugin id. Nothing else 
matters. Well, we need to make sure that the most-local plugin is actually put 
in the list, otherwise you can't override with locally installed ones.


> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote:
> > src/kpackage/packageloader.cpp, line 187
> > 
> >
> > This doesn't actually add anything. A better name would IMO be: 
> > alreadyListed() or something along those lines.
> 
> Andreas Hartmetz wrote:
> It also adds it to the list, though.
> 
> Andreas Hartmetz wrote:
> The point is that it isn't const, and it also has a return value that 
> matters. The name -sort of- conveys both.

That list is internal and shouldn't be reflected in the API, though... (We may 
entirely circumven this issue, see below.)


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126660/#review90755
---


On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126660/
> ---
> 
> (Updated Jan. 7, 2016, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> That was a problem in a scenario such as mine, where I have distro
> packages and self compiled packages. There were (from the UI)
> indistinguishable, duplicate packages in the panel's add applets
> UI, in the tray config dialog's "additional items" section, and
> probably in other places, too.
> Note that requiring to have no duplicate packages in XDG_DATA_DIRS
> by removing entries from XGD_DATA_DIRS doesn't fly because /usr
> cannot be removed for the non-KF5 things that it brings.
> 
> 
> Diffs
> -
> 
>   src/kpackage/packageloader.cpp 9f7dd48 
> 
> Diff: https://git.reviewboard.kde.org/r/126660/diff/
> 
> 
> Testing
> ---
> 
> Checked for duplicate entries in "add applets" and tray config dialog, no 
> duplicates anymore. Also no duplicates anymore in KWin effects KCM.
> 
> 
> Thanks,
> 
> Andreas Hartmetz
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126661: [GCI] Apply qstring-related clazy fixes to the core lib.

2016-01-07 Thread Mihail Ivchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126661/
---

(Updated Jan. 7, 2016, 8:40 p.m.)


Review request for KDE Frameworks.


Changes
---

Use QLatin1Char where it's possible.


Repository: kpackage


Description
---

QLatin1String -> QStringLiteral where it makes sense.
Raw string literals -> QStringLiteral and QLatin1String (where possible).
GCI task: 
https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/


Diffs (updated)
-

  src/kpackage/package.cpp d210015 
  src/kpackage/packageloader.cpp 9f7dd48 
  src/kpackage/private/packagejobthread.cpp b7f5d2d 
  src/kpackage/private/packages.cpp 3de80a0 
  src/kpackagetool/kpackagetool.cpp 61a0043 
  src/kpackagetool/main.cpp 453f3e8 

Diff: https://git.reviewboard.kde.org/r/126661/diff/


Testing
---

Tests passed


Thanks,

Mihail Ivchenko

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

2016-01-07 Thread Mihail Ivchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126662/
---

(Updated Jan. 7, 2016, 8:40 p.m.)


Review request for KDE Frameworks.


Changes
---

Use Q_FOREACH instead of foreach


Repository: kpackage


Description
---

GCI task: 
https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/


Diffs (updated)
-

  src/kpackage/packageloader.cpp 9f7dd48 
  src/kpackage/private/packages_p.h 27b8ed9 
  src/kpackagetool/kpackagetool.cpp 61a0043 

Diff: https://git.reviewboard.kde.org/r/126662/diff/


Testing
---

Tests passed


Thanks,

Mihail Ivchenko

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 29 - Failure!

2016-01-07 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 07 Jan 2016 17:29:21 +
Build duration: 2.8 sec

CHANGE SET
Revision f79810135d409294e55b2381c02f2900059ceb2a by sergobot: (Fix some Clazy 
warnings REVIEW:126545)
  change: edit src/tools/kquitapp/kquitapp.cpp
  change: edit src/kdeinitinterface.cpp
  change: edit src/kdbusservice.cpp
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Andreas Hartmetz 


> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote:
> > src/kpackage/packageloader.cpp, line 190
> > 
> >
> > What does the category have to do with this? We should only be going by 
> > the id (the plugin name).
> 
> Andreas Hartmetz wrote:
> Depends on the scope in which an ID is guaranteed to be unique. If it's 
> guaranteed to be globally unique and independent of category, sure, I'm all 
> for not making it more complicated than necessary.
> 
> Andreas Hartmetz wrote:
> Given that the ID falls back to the metadata file name without extension, 
> and that you can have the same file name in different directories, it seems 
> like you *could* have a package of the same name in different categories. The 
> same goes for names supplied by the data in the metadata files. Some names 
> make sense in several places.

Sorry, the part about the filename doesn't apply. It comes from the 
documentation of KPluginMetaData::pluginId() which doesn't apply here, given 
that the files are all called metadata.desktop or metadata.json.


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126660/#review90755
---


On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126660/
> ---
> 
> (Updated Jan. 7, 2016, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> That was a problem in a scenario such as mine, where I have distro
> packages and self compiled packages. There were (from the UI)
> indistinguishable, duplicate packages in the panel's add applets
> UI, in the tray config dialog's "additional items" section, and
> probably in other places, too.
> Note that requiring to have no duplicate packages in XDG_DATA_DIRS
> by removing entries from XGD_DATA_DIRS doesn't fly because /usr
> cannot be removed for the non-KF5 things that it brings.
> 
> 
> Diffs
> -
> 
>   src/kpackage/packageloader.cpp 9f7dd48 
> 
> Diff: https://git.reviewboard.kde.org/r/126660/diff/
> 
> 
> Testing
> ---
> 
> Checked for duplicate entries in "add applets" and tray config dialog, no 
> duplicates anymore. Also no duplicates anymore in KWin effects KCM.
> 
> 
> Thanks,
> 
> Andreas Hartmetz
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

2016-01-07 Thread Aleix Pol Gonzalez 


> On Jan. 7, 2016, 4:51 p.m., Aleix Pol Gonzalez wrote:
> > src/kpackagetool/kpackagetool.cpp, line 351
> > 
> >
> > Why's this change?
> 
> Mihail Ivchenko wrote:
> Otherwese clazy warns about detaching temporary. If this change isn't 
> need I can remove that one.

Ok, makes sense.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126662/#review90762
---


On Jan. 7, 2016, 4:42 p.m., Mihail Ivchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126662/
> ---
> 
> (Updated Jan. 7, 2016, 4:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> GCI task: 
> https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 61a0043 
>   src/kpackage/private/packages_p.h 27b8ed9 
>   src/kpackage/packageloader.cpp 9f7dd48 
> 
> Diff: https://git.reviewboard.kde.org/r/126662/diff/
> 
> 
> Testing
> ---
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126670: Fix some Clazy warnings in KPeople framework

2016-01-07 Thread Andrey Cygankov 


> On Янв. 8, 2016, 1:20 д.п., Aleix Pol Gonzalez wrote:
> > I did it myself because you're a GCI student, but besides compilation, you 
> > should have checked if tests still pass and specified so in the testing 
> > field.
> > 
> > The change looks, good. Thanks!

Please tell me how to run the auto-tests?


- Andrey


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126670/#review90784
---


On Янв. 8, 2016, 1:15 д.п., Andrey Cygankov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126670/
> ---
> 
> (Updated Янв. 8, 2016, 1:15 д.п.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> Fix some Clazy warnings:
> - qstring-uneeded-heap-allocations
> - isempty-vs-count
> - detaching-temporary
> - variant-sanitizer
> 
> 
> Diffs
> -
> 
>   autotests/persondatatests.cpp 43a7c7b 
>   autotests/personsmodeltest.cpp 1cbc3dc 
>   examples/contactlistwidgets.cpp 56bb01c 
>   examples/personwidget.cpp b4d73c8 
>   src/personmanager.cpp 5c3d3e1 
>   src/personpluginmanager.cpp f5396d9 
>   src/widgets/actions.cpp ffaf16f 
>   src/widgets/mergedelegate.cpp 01c988d 
>   src/widgets/persondetailsview.cpp 7e4e24f 
> 
> Diff: https://git.reviewboard.kde.org/r/126670/diff/
> 
> 
> Testing
> ---
> 
> Compiling without errors.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126660: Avoid finding the same package multiple times from different paths.

2016-01-07 Thread Andreas Hartmetz 


> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote:
> > Wouldn't it be way easier to simply check if the plugin is already in lst?
> > 
> > Your approach looks very complex for just that...

O(n) vs. O(n^2)


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126660/#review90755
---


On Jan. 7, 2016, 3:21 p.m., Andreas Hartmetz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126660/
> ---
> 
> (Updated Jan. 7, 2016, 3:21 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, Plasma, and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> That was a problem in a scenario such as mine, where I have distro
> packages and self compiled packages. There were (from the UI)
> indistinguishable, duplicate packages in the panel's add applets
> UI, in the tray config dialog's "additional items" section, and
> probably in other places, too.
> Note that requiring to have no duplicate packages in XDG_DATA_DIRS
> by removing entries from XGD_DATA_DIRS doesn't fly because /usr
> cannot be removed for the non-KF5 things that it brings.
> 
> 
> Diffs
> -
> 
>   src/kpackage/packageloader.cpp 9f7dd48 
> 
> Diff: https://git.reviewboard.kde.org/r/126660/diff/
> 
> 
> Testing
> ---
> 
> Checked for duplicate entries in "add applets" and tray config dialog, no 
> duplicates anymore. Also no duplicates anymore in KWin effects KCM.
> 
> 
> Thanks,
> 
> Andreas Hartmetz
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126662: [GCI] Fix clazy's issues in core lib.

2016-01-07 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126662/#review90762
---



src/kpackage/packageloader.cpp (line 219)


I would just change for Q_FOREACH.



src/kpackage/packageloader.cpp (line 274)


I would just change for Q_FOREACH.



src/kpackagetool/kpackagetool.cpp (line 351)


Why's this change?



src/kpackagetool/kpackagetool.cpp (line 516)


I would just change for Q_FOREACH.


- Aleix Pol Gonzalez


On Jan. 7, 2016, 4:42 p.m., Mihail Ivchenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126662/
> ---
> 
> (Updated Jan. 7, 2016, 4:42 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> GCI task: 
> https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/
> 
> 
> Diffs
> -
> 
>   src/kpackagetool/kpackagetool.cpp 61a0043 
>   src/kpackage/private/packages_p.h 27b8ed9 
>   src/kpackage/packageloader.cpp 9f7dd48 
> 
> Diff: https://git.reviewboard.kde.org/r/126662/diff/
> 
> 
> Testing
> ---
> 
> Tests passed
> 
> 
> Thanks,
> 
> Mihail Ivchenko
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126664: [GCI] Apply qstring-related clazy fixes to tests.

2016-01-07 Thread Mihail Ivchenko 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126664/
---

Review request for KDE Frameworks and Aleix Pol Gonzalez.


Repository: kpackage


Description
---

QLatin1String -> QStringLiteral where it makes sense.
Raw string literals -> QStringLiteral.
GCI task: 
https://codein.withgoogle.com/dashboard/task-instances/5822614106800128/


Diffs
-

  autotests/fallbackpackagetest.cpp 6e33195 
  autotests/packagestructuretest.cpp 0b9787e 
  autotests/plasmoidpackagetest.cpp a22c732 
  autotests/plasmoidstructure.cpp 4fefbf4 
  autotests/querytest.cpp 854bb21 

Diff: https://git.reviewboard.kde.org/r/126664/diff/


Testing
---

Tests passed


Thanks,

Mihail Ivchenko

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdbusaddons master stable-kf5-qt5 » Linux,gcc - Build # 30 - Still Failing!

2016-01-07 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdbusaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 07 Jan 2016 17:46:15 +
Build duration: 8.8 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Menu/Command capitalization

2016-01-07 Thread Jaroslaw Staniek 
Hello,
Asking here as this is somewhat a cross platform issue. I do admit it
isn't a massive one but rather strange; I've never noted it before, I
just recently had to help with that for a customer's app.

Not too long ago MS Windows has moved from "Title Capitalization" to
"Sentence capitalization" for menus and commands:
https://msdn.microsoft.com/en-us/library/dn742392.aspx

What can we do and should we do something about this?

Questions and basic research follows:

- Of course for (most) FOSS people with pragmatic "good-enough"
approach such a small difference isn't a problem. Popular Windows FOSS
apps such as LibreOffice and GIMP ignore the guidelines. If this is
all you're interested in, you can stop reading already :)

- For everyone else perhaps it's better to offer something officially
or else some people would fork translations or avoid using KDE's code.

- Some (future?) KF5 users would target Windows expecting that the
resulting apps look and feel largely native.

- Is automated conversion for capitalization a reasonable approach?
Runtime or script-based generation.

- Maintaining the compliance "by hand" basically adds another variant
to each English variant of translation (US, UK,...)

- Are there other locales than English that use the Title
Capitalization? (it's good to know the scale)
  I've spotted this article
https://en.wikipedia.org/wiki/Letter_case#Title_case but did not find
non-english examples.

- Do we have checks for semantic strings and capitalization? If so
would they need updates, or?

- Not just Windows. Android and Windows Phone is similarly "affected"
in the discussed area.
  
https://www.google.com/design/spec/style/writing.html#writing-capitalization-punctuation

- Mac OS X and iOS is consistent with KDE capitalization:
  
https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/2957-CH15-SW4

- The most intrusive but ultimate solution: make our English
translations drop the Title Capitalization
-- Advantage: no special case for English anymore so no mistakes in
message strings (I've commited quite a few such fixes in my career,
have you?)
-- Disadvantage: we would start to be inconsistent with Mac OS X/iOS
guidelines, and I'd guess only with those :)

-- 
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

2016-01-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 07 Jan 2016 20:59:40 +
Build duration: 1 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 225/337 
(67%)CONDITIONAL 68/116 (59%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 131/133 (98%)CONDITIONAL 
29/48 (60%)
src
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 94/204 (46%)CONDITIONAL 
39/68 (57%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: QProcess for GUI apps on OSX (Re: closest equivalent to KApplicationPrivate::init() ?)

2016-01-07 Thread René J . V . Bertin 
Hi,

I'm sure you're on Qt's "development" ML too, but here's a link to a relevant 
thread for the sake of completeness:

http://thread.gmane.org/gmane.comp.lib.qt.devel/24290

Cheers,
René
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdbusaddons master kf5-qt5 » Linux,gcc - Build # 30 - Fixed!

2016-01-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdbusaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 07 Jan 2016 20:59:40 +
Build duration: 1 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 225/337 
(67%)CONDITIONAL 68/116 (59%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 131/133 (98%)CONDITIONAL 
29/48 (60%)
src
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 94/204 (46%)CONDITIONAL 
39/68 (57%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel