Re: Reporting bugs to frameworks

[Ben Cooksley]

On Tue, Jan 19, 2016 at 9:06 PM, David Faure  wrote:
> On Friday 15 January 2016 13:39:12 Christoph Feck wrote:
>> On Friday 15 January 2016 12:55:47 Aleix Pol wrote:
>> > Hi,
>> > I've recently found a bug in kded. I've been trying to report it
>> > but didn't manage to find it on the list [1].
>> >
>> > What did I miss?
>>
>> frameworks-kdaemon
>
> What a  weird name! We don't say kdaemon anywhere else, at all.
>
> I really wonder how it came to be called this way.
>
> Can someone rename it to frameworks-kded, the only name that would
> actually make sense, for a framework called kded?

No idea. Renamed now.

Regards,
Ben

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Deadlock in kded whith Qt 5.6

[Aleix Pol]

On Mon, Jan 18, 2016 at 9:23 AM, David Faure  wrote:
> On Friday 15 January 2016 13:48:14 Aleix Pol wrote:
>> On Fri, Jan 15, 2016 at 1:02 PM, Aleix Pol  wrote:
>> > Hi,
>> > I realized earlier last week that some of my applications were
>> > freezing, it turns out it's because my kded is freezing and any dbus
>> > calls there need to time out (they take 30s to time out btw).
>> >
>> > Anyway, here's the backtrace: https://paste.kde.org/pajbfmoh8
>> >
>> > I saw David did something in that direction earlier but I couldn't
>> > spot exactly where's the problem, so I decided to report it here,
>> > hoping he'd know what's going on. :D
>> >
>> > Thanks!!
>> >
>> > Aleix
>>
>> Now that I know how to report a bug to kded5, I reported it. Here it
>> is, for completion:
>> https://bugs.kde.org/show_bug.cgi?id=358017
>
> Thiago: indeed the BlockingQueuedConnection call from messageFilter to the
> main thread occasionnally leads to deadlocks, we need your
> "postpone incoming messages" idea.

It's good to know there's a plan, would it maybe be possible to expand
a bit? I'd be interested in looking into it as my system is quite
unusable and I can expect other people will become soon enough.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126735: Fix most Clazy warnings in KItemModels.

[Kåre Särs]

> On Jan. 14, 2016, 8:47 a.m., Kåre Särs wrote:
> > tests/proxymodeltestapp/proxyitemselectionwidget.cpp, line 47
> > 
> >
> > QStringLiteral with multiple string initializers does not work on 
> > Windows. All places without arguments could use QLatin1String.
> > 
> > There are multiple cases with the same issue in this review. Clazy 
> > should be fixed to not suggest this change...
> 
> Kåre Särs wrote:
> +1 Good to go from my point of view :) I'll let Aleix give the Shipit.
> 
> Aleix Pol Gonzalez wrote:
> Actually it has, Andrey update your clazy ;).
> 
> ```
> commit 04a6c6665e73da087cec7d66039830d2932305f7
> Author: Sergio Martins 
> Date:   Thu Jan 14 10:23:06 2016 +
> 
> qstring-uneeded-heap-allocations: Rename msvc-compat to no-msvc-compat
> 
> Meaning msvc-compat is the default and if you don't want it you 
> should:
> export 
> CLAZY_EXTRA_OPTIONS="qstring-uneeded-heap-allocations-no-msvc-compat"
> 
> Helps stopping annoying our windows friends.
> 
> Ignoring multi-string literals is not implemented yet, only ignoring 
> list initialization.
> 
> CCBUG: 357966
> ```
> 
> David Faure wrote:
> "update your clazy" is not a helpful suggestion given the line "Ignoring 
> multi-string literals is not implemented yet".

But now just a little bit later, Sergio has fixed also the multi-string issue :)
https://bugs.kde.org/show_bug.cgi?id=357966

Git commit 9c1458765dbdad21739cbe2b9154667657d2352e by Sergio Martins.
Committed on 14/01/2016 at 23:49.
Pushed by smartins into branch 'master'.

qstring-uneeded-heap-allocations: Improve msvc compat

Now we don't warn when using multi token literals like:
QString s = "foo" "bar";


- Kåre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126735/#review91051
---


On Jan. 14, 2016, 11:16 p.m., Andrey Cygankov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126735/
> ---
> 
> (Updated Jan. 14, 2016, 11:16 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Fixed most Clazy warnings in KItemModels.
> 
> 
> Diffs
> -
> 
>   autotests/kconcatenaterowsproxymodeltest.cpp 0a2f794 
>   autotests/kextracolumnsproxymodeltest.cpp 015ea65 
>   autotests/krearrangecolumnsproxymodeltest.cpp 70e6ea9 
>   autotests/krecursivefilterproxymodeltest.cpp 8c7c65e 
>   autotests/kselectionproxymodeltest.cpp ac3d324 
>   autotests/proxymodeltestsuite/dynamictreemodel.cpp d5a12e7 
>   autotests/proxymodeltestsuite/dynamictreewidget.cpp 5a0462b 
>   autotests/proxymodeltestsuite/modelcommander.cpp 8311e5b 
>   autotests/proxymodeltestsuite/modelspy.cpp bb8e520 
>   autotests/proxymodeltestsuite/proxymodeltest.cpp dd596c6 
>   src/kconcatenaterowsproxymodel.cpp 074fcd3 
>   src/kselectionproxymodel.cpp 4d7af29 
>   tests/proxymodeltestapp/breadcrumbdirectionwidget.cpp 1e01ae3 
>   tests/proxymodeltestapp/breadcrumbnavigationwidget.cpp a0493c2 
>   tests/proxymodeltestapp/breadcrumbswidget.cpp d583856 
>   tests/proxymodeltestapp/checkablewidget.cpp d51458a 
>   tests/proxymodeltestapp/descendantpmwidget.cpp 39bd062 
>   tests/proxymodeltestapp/kidentityproxymodelwidget.cpp 0150c70 
>   tests/proxymodeltestapp/kreparentingproxymodel.cpp e79392c 
>   tests/proxymodeltestapp/lessthanwidget.cpp 7af3c1c 
>   tests/proxymodeltestapp/proxyitemselectionwidget.cpp e075dbf 
>   tests/proxymodeltestapp/reparentingpmwidget.cpp 2593732 
>   tests/proxymodeltestapp/selectioninqmlwidget.cpp 68e1d78 
>   tests/proxymodeltestapp/selectionpmwidget.cpp f5b353a 
> 
> Diff: https://git.reviewboard.kde.org/r/126735/diff/
> 
> 
> Testing
> ---
> 
> Build without errors.
> Tests passed.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

[Aleix Pol]

On Tue, Jan 19, 2016 at 9:15 AM, David Faure  wrote:
> Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure.
> Committed on 19/01/2016 at 08:14.
> Pushed by dfaure into branch 'master'.
>
> Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).
>
> Any volunteer for doing this over all frameworks?
> CCMAIL: kde-frameworks-devel@kde.org
>
> M  +1-1CMakeLists.txt
>
> http://commits.kde.org/karchive/3b13ef97925725b2a273a4d3e7d1c0c7e151522d
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 1440f2f..deee520 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -11,7 +11,7 @@ feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND 
> FATAL_ON_MISSING_REQUIRED_PACKA
>  set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
>
>  include(KDEInstallDirs)
> -include(KDEFrameworkCompilerSettings)
> +include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
>  include(KDECMakeSettings)

Hi,
I'll work on a GCI task over it. Should be easy enough.

Good call!

Aleix

PS: Actually we should get this in applications as well, right?
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126769: Fix all Clazy warnings in KDED.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126769/#review91307
---




src/kded.cpp (line 223)


That's new in Qt 5.5, we need this code to compile with Qt >= 5.3 (until 
5.6 is out).

Please revert, or wrap this in
#if QT_VERSION >= QT_VERSION_CHECK(5, 5, 0)


- David Faure


On Jan. 16, 2016, 2:27 p.m., Andrey Cygankov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126769/
> ---
> 
> (Updated Jan. 16, 2016, 2:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Aleix Pol Gonzalez.
> 
> 
> Repository: kded
> 
> 
> Description
> ---
> 
> Fix all Clazy warnings in KDED.
> 
> 
> Diffs
> -
> 
>   src/kded.cpp 0eb6380 
> 
> Diff: https://git.reviewboard.kde.org/r/126769/diff/
> 
> 
> Testing
> ---
> 
> Built without errors.
> No tests available.
> 
> 
> Thanks,
> 
> Andrey Cygankov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

[David Faure]

Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure.
Committed on 19/01/2016 at 08:14.
Pushed by dfaure into branch 'master'.

Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

Any volunteer for doing this over all frameworks?
CCMAIL: kde-frameworks-devel@kde.org

M  +1-1CMakeLists.txt

http://commits.kde.org/karchive/3b13ef97925725b2a273a4d3e7d1c0c7e151522d

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1440f2f..deee520 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -11,7 +11,7 @@ feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND 
FATAL_ON_MISSING_REQUIRED_PACKA
 set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
 
 include(KDEInstallDirs)
-include(KDEFrameworkCompilerSettings)
+include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
 include(KDECMakeSettings)
 
 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Reporting bugs to frameworks

[David Faure]

On Friday 15 January 2016 13:39:12 Christoph Feck wrote:
> On Friday 15 January 2016 12:55:47 Aleix Pol wrote:
> > Hi,
> > I've recently found a bug in kded. I've been trying to report it
> > but didn't manage to find it on the list [1].
> > 
> > What did I miss?
> 
> frameworks-kdaemon

What a  weird name! We don't say kdaemon anywhere else, at all.

I really wonder how it came to be called this way.

Can someone rename it to frameworks-kded, the only name that would
actually make sense, for a framework called kded?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126789: Don't propagate dataChanged upwards when we are not filtering.

[Volker Krause]

> On Jan. 19, 2016, 7:59 a.m., David Faure wrote:
> > I wrote extensive unit tests for this class.
> > 1) does the unittest still pass?
> > 2) if yes, then it should be extended to test for this case

The unit tests all still pass here, I'll look into expanding the tests.


- Volker


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126789/#review91306
---


On Jan. 18, 2016, 9:59 a.m., Volker Krause wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126789/
> ---
> 
> (Updated Jan. 18, 2016, 9:59 a.m.)
> 
> 
> Review request for KDE Frameworks and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> This avoids expensive layoutChange signals from QSFPM. We can only be sure
> we are not filtering if filterAcceptRows isn't overridden, which we can
> check if we assume sub-classes have the Q_OBJECT macro set.
> 
> This will however break sub-classes overriding filterAcceptRows without
> using the Q_OBJECT macro, and using their own filter criteria. However,
> this is a significant performance improvement in the common case of
> KRFPM being used for string-based searching in a tree view, and the search
> being unused.
> 
> 
> Diffs
> -
> 
>   src/krecursivefilterproxymodel.cpp dbb6eba421c0e680fffe43582f210ea3e42e6e7f 
> 
> Diff: https://git.reviewboard.kde.org/r/126789/diff/
> 
> 
> Testing
> ---
> 
> Tested in GammaRay, where the layoutChanges are particularly painful as the 
> source model is in a different process.
> 
> 
> Thanks,
> 
> Volker Krause
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126798: Add multiple installation method per categorie

[Demitrius Belai]

> On Jan. 18, 2016, 4:52 p.m., Aleix Pol Gonzalez wrote:
> > src/core/engine.cpp, line 135
> > 
> >
> > Shouldn't this break? Otherwise some of the installations won't get 
> > connected.

No. I think previous code treat as "fatal error" when can't load installation 
(return false). I didn't change this behaviour. If some category don't have 
installation method by particular installation or default installation this 
return false. If category particular installation method load fail this return 
false because if category has a group I can't fallback to default installation.
Sorry my poor English.


- Demitrius


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126798/#review91273
---


On Jan. 18, 2016, 4:27 p.m., Demitrius Belai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126798/
> ---
> 
> (Updated Jan. 18, 2016, 4:27 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> This allow to configure installation method per categorie. For example, kwin 
> aurorae.knsrc
> 
> ```
> [KNewStuff3]
> ProvidersUrl=http://download.kde.org/ocs/providers.xml
> Categories=Window Decoration Aurorae,KWin Decoration QtQuick
> Uncompress=archive
> TargetDir=aurorae/themes
> 
> [KWin Decoration QtQuick]
> StandardResource=tmp
> InstallationCommand=plasmapkg2 -t kwindecoration -i %f
> UninstallCommand=plasmapkg2 -t kwindecoration -r %f
> ```
> 
> This don't break backward. Category which don't have group in config will be 
> installed by default installation method in [KNewStuff3] group.
> 
> 
> Diffs
> -
> 
>   src/attica/atticaprovider.cpp 07508b05f324f25481bf05c5717c0ca60dce70d1 
>   src/core/engine.cpp c8d0579eed8592c0c210ad61cbd5cbf4add53f95 
>   src/core/engine_p.h 11571bfcd030ed2832ae64781323494365837296 
>   src/core/entryinternal.cpp b05fe24417554b78fc206d3437e4d11ef2eefcb7 
> 
> Diff: https://git.reviewboard.kde.org/r/126798/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Demitrius Belai
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126798: Add multiple installation method per categorie

[Demitrius Belai]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126798/
---

(Updated Jan. 19, 2016, 11:35 a.m.)


Review request for KDE Frameworks and Jeremy Whiting.


Changes
---

* Removed qDebugs
* Initialize with declaration


Repository: knewstuff


Description
---

This allow to configure installation method per categorie. For example, kwin 
aurorae.knsrc

```
[KNewStuff3]
ProvidersUrl=http://download.kde.org/ocs/providers.xml
Categories=Window Decoration Aurorae,KWin Decoration QtQuick
Uncompress=archive
TargetDir=aurorae/themes

[KWin Decoration QtQuick]
StandardResource=tmp
InstallationCommand=plasmapkg2 -t kwindecoration -i %f
UninstallCommand=plasmapkg2 -t kwindecoration -r %f
```

This don't break backward. Category which don't have group in config will be 
installed by default installation method in [KNewStuff3] group.


Diffs (updated)
-

  src/attica/atticaprovider.cpp 07508b05f324f25481bf05c5717c0ca60dce70d1 
  src/core/engine.cpp c8d0579eed8592c0c210ad61cbd5cbf4add53f95 
  src/core/engine_p.h 11571bfcd030ed2832ae64781323494365837296 

Diff: https://git.reviewboard.kde.org/r/126798/diff/


Testing
---


Thanks,

Demitrius Belai

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [karchive] /: Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).

[Elvis Angelaccio]

2016-01-19 10:11 GMT+01:00 Aleix Pol :

> On Tue, Jan 19, 2016 at 9:15 AM, David Faure  wrote:
> > Git commit 3b13ef97925725b2a273a4d3e7d1c0c7e151522d by David Faure.
> > Committed on 19/01/2016 at 08:14.
> > Pushed by dfaure into branch 'master'.
> >
> > Fix CMP0063 warning (the one about CXX_VISIBILITY_PRESET).
> >
> > Any volunteer for doing this over all frameworks?
> > CCMAIL: kde-frameworks-devel@kde.org
> >
> > M  +1-1CMakeLists.txt
> >
> > http://commits.kde.org/karchive/3b13ef97925725b2a273a4d3e7d1c0c7e151522d
> >
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index 1440f2f..deee520 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -11,7 +11,7 @@ feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND
> FATAL_ON_MISSING_REQUIRED_PACKA
> >  set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
> >
> >  include(KDEInstallDirs)
> > -include(KDEFrameworkCompilerSettings)
> > +include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
> >  include(KDECMakeSettings)
>
> Hi,
> I'll work on a GCI task over it. Should be easy enough.
>
> Good call!
>
> Aleix
>
> PS: Actually we should get this in applications as well, right?
>

I think so, according to the new documentation [1].
That's what I did for Ark just yesterday [2].

[1]:
https://quickgit.kde.org/?p=extra-cmake-modules.git=commitdiff=70f8c5f9efaae8f16874d8cfc551e8ae19558fba
[2]:
https://quickgit.kde.org/?p=ark.git=commitdiff=0620063eb33acff078a0cdededb42e822bb802d3


> ___
> Kde-frameworks-devel mailing list
> Kde-frameworks-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/
---

(Updated Jan. 19, 2016, 11:54 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Detected another issue: https://github.com/svg/svgo/issues/490


Repository: breeze-icons


Description
---

Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea that 
right now we're serving right away the svg's from inkscape and there's room for 
improvement, potentially.

This patch just introduces a script that optimizes the svg's using `svgo`.

More could be done, like using gzip files, we can look into that if anyone's 
interested. In fact, we used to use svgz for the icons, I wonder why that 
changed. 

This will change the files in-place rather than as a build step, which is what 
I considered first. The process to run svgo on every file was about 30 minutes 
to 1h on my system, so I doubt it's really desirable.

A reduced file size is important because it will greatly reduce disk IO, which 
is a bottle-neck we have.


Diffs (updated)
-

  optimize.svg.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126740/diff/


Testing
---

```
kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
32M icons
32M icons-dark/

#run the script

kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
17M icons
17M icons-dark/
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/
---

(Updated Jan. 19, 2016, 7:02 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

Detected an issue, disabled an optimization: 
https://github.com/svg/svgo/issues/489

Size-wise the gain is still the same.


Repository: breeze-icons


Description
---

Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea that 
right now we're serving right away the svg's from inkscape and there's room for 
improvement, potentially.

This patch just introduces a script that optimizes the svg's using `svgo`.

More could be done, like using gzip files, we can look into that if anyone's 
interested. In fact, we used to use svgz for the icons, I wonder why that 
changed. 

This will change the files in-place rather than as a build step, which is what 
I considered first. The process to run svgo on every file was about 30 minutes 
to 1h on my system, so I doubt it's really desirable.

A reduced file size is important because it will greatly reduce disk IO, which 
is a bottle-neck we have.


Diffs (updated)
-

  optimize.svg.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126740/diff/


Testing
---

```
kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
32M icons
32M icons-dark/

#run the script

kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
17M icons
17M icons-dark/
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126632: add a "Complementary" color scheme to kcolorscheme

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126632/#review91342
---


Ship it!




Ship It!

- David Edmundson


On Jan. 5, 2016, 11:16 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126632/
> ---
> 
> (Updated Jan. 5, 2016, 11:16 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Since some releases, plasma-frameworks locally expands kcolorscheme to have a 
> new "Complementary" section: this is done for things like the lockscreen and 
> the logout ui, where the colors are flipped from the current theme.
> A local extension there is kinda unfortunate as makes the color configs files 
> not completely compatible, and I think there is an use case for this in 
> normal applications as well (Gwenview switches to a dark palette when in 
> fullscreen mode for instance)
> Since I want to make the default plasma theme follow the system color scheme, 
> I would need for it to support this "complementary" area as well.
> 
> 
> Diffs
> -
> 
>   src/kcolorscheme.h 22bc21b 
>   src/kcolorscheme.cpp 427ffa4 
> 
> Diff: https://git.reviewboard.kde.org/r/126632/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

[andreas kainz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review91352
---



there was also an discussion to use png files cause they are smaler in size but 
than I thing the stylesheet stuff didn't work. I have no problem to change to 
.svgz the only problem is that we have a lot linked files and the links will be 
broken when we change the extension so please include this issue into your 
script.
My decission would to to change to svgz and run the svg optimizing script ones 
in future by each change the dev can say run script if wanted. BUT as we 
already have this stylesheet script (marco) please make one script and say me 
how it works.

- andreas kainz


On Jan. 19, 2016, 10:54 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Jan. 19, 2016, 10:54 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize.svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/
---

Review request for KDE Frameworks.


Repository: kwindowsystem


Description
---

appRootWindow is (relatively) expensive and won't change.
nativeEventFilter is called a lot

This should speed things up.

CCBUG: 356479


Diffs
-

  src/platforms/xcb/kwindowsystem.cpp 9d287043c24894ca3c29c439c7939b139da055e8 
  src/platforms/xcb/kwindowsystem_p_x11.h 
3fa82a436d7fe12b50f7e8efd7338faf817f6579 

Diff: https://git.reviewboard.kde.org/r/126818/diff/


Testing
---

Ran some apps and they seemed to still work.
Not tested any specific functionality.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126774: Fix many warnings presented by clazy

[Russell Greene]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126774/
---

(Updated Jan. 20, 2016, 3 a.m.)


Review request for KDE Frameworks and Aleix Pol Gonzalez.


Repository: kio


Description
---

Fix many warnings presented by clazy

I ran the clazy static anaylizer on the codebase and fixed many of the errors.

Many of these were using QStringLiteral instead of QString, which removes an 
allocation, including Q_OBJECT macros, adding const ref instad of const lvalue, 
stuff like that.


Diffs
-

  autotests/http/httpheaderdispositiontest.cpp ac41656 
  autotests/http/httpheadertokenizetest.cpp e57be09 
  autotests/jobtest.cpp dfbfba9 
  autotests/kacltest.cpp 2b88906 
  autotests/kcookiejar/kcookiejartest.cpp dab6987 
  autotests/kfileitemtest.cpp 49d11e1 
  autotests/kfileplacesmodeltest.cpp effc95b 
  autotests/klocalsocketservertest.cpp 9b7f246 
  autotests/klocalsockettest.cpp 0d831f2 
  autotests/kmountpointtest.cpp f6eccd8 
  autotests/knewfilemenutest.cpp 1b11f15 
  autotests/kprotocolinfotest.cpp 812f7f7 
  autotests/ktcpsockettest.cpp 640d871 
  autotests/kurlnavigatortest.cpp 1b295c3 
  autotests/udsentry_benchmark.cpp 16c8b7e 
  src/core/dataprotocol_p.h 784226b 
  src/core/global.cpp eaa4264 
  src/core/job_error.cpp 7943cb3 
  src/core/kprotocolinfofactory.cpp 1329b6b 
  src/core/kprotocolmanager.cpp bd42c9e 
  src/core/ksambasharedata.cpp b63f518 
  src/core/ksslcertificatemanager.cpp 07feda4 
  src/core/restorejob.cpp ee5cca9 
  src/core/sessiondata.cpp d21ab21 
  src/core/simplejob.cpp 440fa62 
  src/core/slave.cpp 5ae4d97 
  src/core/slavebase.cpp a9bf648 
  src/core/statjob.cpp e55e3b4 
  src/core/storedtransferjob.cpp 3e86cb9 
  src/core/tcpslavebase.cpp 2bd1c0f 
  src/filewidgets/defaults-kfile.h 825a297 
  src/filewidgets/defaultviewadapter_p.h 79381e4 
  src/filewidgets/kdiroperator.cpp 9c2b6be 
  src/filewidgets/kfilecopytomenu.cpp dab5db6 
  src/filewidgets/kfileplacesitem.cpp 1748188 
  src/filewidgets/kfileplacesmodel.cpp e9d37a9 
  src/filewidgets/kfileplacesview.cpp 4121191 
  src/filewidgets/knewfilemenu.cpp b249898 
  src/filewidgets/kurlnavigator.cpp 64d2a6d 
  src/ioslaves/ftp/ftp.cpp 7477a6a 
  src/ioslaves/http/http.cpp 76da711 
  src/ioslaves/http/kcookiejar/kcookiejar.cpp c06882a 
  src/ioslaves/http/kcookiejar/kcookieserver.cpp 3e7dd8c 
  src/ioslaves/trash/kcmtrash.cpp 79c2ca7 
  src/ioslaves/trash/ktrash.cpp 298a201 
  src/ioslaves/trash/tests/testtrash.cpp 339aa19 
  src/ioslaves/trash/trashimpl.cpp 26d9ea8 
  src/kcms/kio/kcookiespolicyselectiondlg.cpp fcd0763 
  src/kcms/kio/kproxydlg.cpp fe2583e 
  src/kcms/kio/main.cpp 387cf89 
  src/kcms/kio/useragentdlg.cpp a6560b5 
  src/kcms/kio/useragentinfo.cpp 1459fcc 
  src/kcms/kio/useragentselectordlg.cpp 3952761 
  src/kioexec/main.cpp 6f4540f 
  src/kntlm/kntlm.cpp ed6f388 
  src/kpac/script.cpp 9b126ca 
  src/kpasswdserver/kpasswdserver.cpp 7a53300 
  src/kssld/kssld.cpp fcc3bed 
  src/protocoltojson/main.cpp 05b9364 
  src/urifilters/ikws/kuriikwsfiltereng.h c8fbcd2 
  src/urifilters/ikws/searchprovider.cpp 8652997 
  src/urifilters/ikws/searchproviderdlg.cpp 4effe08 
  src/urifilters/localdomain/localdomainurifilter.cpp 4ebd1c0 
  src/urifilters/shorturi/kshorturifilter.cpp c9024b0 
  src/widgets/accessmanager.cpp 68f4a27 
  src/widgets/accessmanagerreply_p.cpp 2ade6fd 
  src/widgets/delegateanimationhandler.cpp 8e08a0c 
  src/widgets/fileundomanager.cpp c9790ab 
  src/widgets/kbuildsycocaprogressdialog.cpp 9ee0644 
  src/widgets/kfileitemactions.cpp 4343da7 
  src/widgets/kopenwithdialog.cpp 808af73 
  src/widgets/kpropertiesdialog.cpp a4fdeb9 
  src/widgets/krun.cpp af48473 
  src/widgets/kurlcompletion.cpp 7160491 
  src/widgets/kurlrequester.cpp 06e9ddb 

Diff: https://git.reviewboard.kde.org/r/126774/diff/


Testing
---

I ran the entire test suite with the exact same results as master:


Running tests...
Test project /home/russellg/KDE/kio/build
  Start  1: testtrash
 1/47 Test  #1: testtrash    Passed
1.24 sec
  Start  2: kpasswdservertest
 2/47 Test  #2: kpasswdservertest    Passed
0.73 sec
  Start  3: kiocore-kacltest
 3/47 Test  #3: kiocore-kacltest .***Failed
0.04 sec
  Start  4: kiocore-listdirtest
 4/47 Test  #4: kiocore-listdirtest ..   Passed
0.18 sec
  Start  5: kiocore-kmountpointtest
 5/47 Test  #5: kiocore-kmountpointtest ..   Passed
0.04 sec
  Start  6: kiocore-upurltest
 6/47 Test  #6: kiocore-upurltest    Passed
0.04 sec
  Start  7: kiocore-dataprotocoltest
 7/47 Test  #7: kiocore-dataprotocoltest .   Passed
0.04 sec
  Start  8: kiocore-jobtest
 8/47 Test  #8: 

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/#review91358
---




src/platforms/xcb/kwindowsystem_p_x11.h (line 147)


Should this (maybe) be static? Or rather Q_GLOBAL_STATIC?

Or we'll just have one of those backends anyway?


- Aleix Pol Gonzalez


On Jan. 20, 2016, 12:21 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126818/
> ---
> 
> (Updated Jan. 20, 2016, 12:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> appRootWindow is (relatively) expensive and won't change.
> nativeEventFilter is called a lot
> 
> This should speed things up.
> 
> CCBUG: 356479
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 
> 9d287043c24894ca3c29c439c7939b139da055e8 
>   src/platforms/xcb/kwindowsystem_p_x11.h 
> 3fa82a436d7fe12b50f7e8efd7338faf817f6579 
> 
> Diff: https://git.reviewboard.kde.org/r/126818/diff/
> 
> 
> Testing
> ---
> 
> Ran some apps and they seemed to still work.
> Not tested any specific functionality.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

[Martin Gräßlin]

> On Jan. 20, 2016, 2:58 a.m., Aleix Pol Gonzalez wrote:
> > src/platforms/xcb/kwindowsystem_p_x11.h, line 147
> > 
> >
> > Should this (maybe) be static? Or rather Q_GLOBAL_STATIC?
> > 
> > Or we'll just have one of those backends anyway?

No need to have it static.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/#review91358
---


On Jan. 20, 2016, 12:21 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126818/
> ---
> 
> (Updated Jan. 20, 2016, 12:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> appRootWindow is (relatively) expensive and won't change.
> nativeEventFilter is called a lot
> 
> This should speed things up.
> 
> CCBUG: 356479
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 
> 9d287043c24894ca3c29c439c7939b139da055e8 
>   src/platforms/xcb/kwindowsystem_p_x11.h 
> 3fa82a436d7fe12b50f7e8efd7338faf817f6579 
> 
> Diff: https://git.reviewboard.kde.org/r/126818/diff/
> 
> 
> Testing
> ---
> 
> Ran some apps and they seemed to still work.
> Not tested any specific functionality.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/#review91362
---


Ship it!




Ship It!

- Martin Gräßlin


On Jan. 20, 2016, 12:21 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126818/
> ---
> 
> (Updated Jan. 20, 2016, 12:21 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> appRootWindow is (relatively) expensive and won't change.
> nativeEventFilter is called a lot
> 
> This should speed things up.
> 
> CCBUG: 356479
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 
> 9d287043c24894ca3c29c439c7939b139da055e8 
>   src/platforms/xcb/kwindowsystem_p_x11.h 
> 3fa82a436d7fe12b50f7e8efd7338faf817f6579 
> 
> Diff: https://git.reviewboard.kde.org/r/126818/diff/
> 
> 
> Testing
> ---
> 
> Ran some apps and they seemed to still work.
> Not tested any specific functionality.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 71 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Jan 2016 05:59:16 +
Build duration: 9.9 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Deadlock in kded whith Qt 5.6

[Thiago Macieira]

On Monday 18 January 2016 09:23:51 David Faure wrote:
> Thiago: indeed the BlockingQueuedConnection call from messageFilter to the
> main thread occasionnally leads to deadlocks, we need your
> "postpone incoming messages" idea.

Please try the attached patch, also found at
https://codereview.qt-project.org/146639
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
  PGP/GPG: 0x6EF45358; fingerprint:
  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
>From fafa4b3b89a02e136f8f4af8455ee2fd8a7cf9f4 Mon Sep 17 00:00:00 2001
From: Thiago Macieira 
Date: Tue, 19 Jan 2016 22:29:33 -0800
Subject: [PATCH 1/1] Call out to QtDBus message spies in the main thread

Whenever there are spies installed, we call out to the main thread to
call to the kded/kiod message spies. This allows the spy code to do just
about anything, where previously it was restricted in what it could do
to avoid deadlocking or triggering assertions if it recursed back into
QDBusConnection code in the manager thread.

After the spies are done with, the message is re-inserted into the
QDBusConnection processing pipeline. That means it may be delayed again
if the dispatching is disabled.

Change-Id: I3d11545be52c43119f0f142b0e9d447415c2
---
 src/dbus/qdbusconnection_p.h |  4 +++-
 src/dbus/qdbusintegrator_p.h | 19 +
 src/dbus/qdbusintegrator.cpp | 51 ++--
 3 files changed, 62 insertions(+), 12 deletions(-)

diff --git a/src/dbus/qdbusconnection_p.h b/src/dbus/qdbusconnection_p.h
index f030a3f..d7787fa 100644
--- a/src/dbus/qdbusconnection_p.h
+++ b/src/dbus/qdbusconnection_p.h
@@ -1,7 +1,7 @@
 /
 **
 ** Copyright (C) 2015 The Qt Company Ltd.
-** Copyright (C) 2015 Intel Corporation.
+** Copyright (C) 2016 Intel Corporation.
 ** Contact: http://www.qt.io/licensing/
 **
 ** This file is part of the QtDBus module of the Qt Toolkit.
@@ -228,6 +228,7 @@ public:
 void registerService(const QString );
 void unregisterService(const QString );
 
+bool preHandleMessage(const QDBusMessage );
 bool handleMessage(const QDBusMessage );
 
 QDBusMetaObject *findMetaObject(const QString , const QString ,
@@ -281,6 +282,7 @@ private slots:
 
 signals:
 void dispatchStatusChanged();
+void messageNeedsHandling(const QDBusMessage );
 void messageNeedsSending(QDBusPendingCallPrivate *pcall, void *msg, int timeout = -1);
 void signalNeedsConnecting(const QString , const QDBusConnectionPrivate::SignalHook );
 bool signalNeedsDisconnecting(const QString , const QDBusConnectionPrivate::SignalHook );
diff --git a/src/dbus/qdbusintegrator_p.h b/src/dbus/qdbusintegrator_p.h
index 2038ac9..e266512 100644
--- a/src/dbus/qdbusintegrator_p.h
+++ b/src/dbus/qdbusintegrator_p.h
@@ -1,6 +1,7 @@
 /
 **
 ** Copyright (C) 2015 The Qt Company Ltd.
+** Copyright (C) 2016 Intel Corporation.
 ** Contact: http://www.qt.io/licensing/
 **
 ** This file is part of the QtDBus module of the Qt Toolkit.
@@ -65,6 +66,7 @@
 QT_BEGIN_NAMESPACE
 
 class QDBusConnectionPrivate;
+class QDBusMessage;
 
 // Really private structs used by qdbusintegrator.cpp
 // Things that aren't used by any other file
@@ -133,6 +135,23 @@ private:
 bool handled;
 };
 
+class QDBusSpyCallEvent : public QMetaCallEvent
+{
+public:
+typedef void (*Hook)(const QDBusMessage&);
+QDBusSpyCallEvent(QDBusConnectionPrivate *cp, const QDBusConnection , const QDBusMessage ,
+  const Hook *hooks, int count)
+: QMetaCallEvent(0, 0, Q_NULLPTR, cp, 0), conn(c), msg(msg), hooks(hooks), hookCount(count)
+{}
+~QDBusSpyCallEvent();
+void placeMetaCall(QObject *) Q_DECL_OVERRIDE;
+
+QDBusConnection conn;   // keeps the refcount in QDBusConnectionPrivate up
+QDBusMessage msg;
+const Hook *hooks;
+int hookCount;
+};
+
 QT_END_NAMESPACE
 
 Q_DECLARE_METATYPE(QDBusSlotCache)
diff --git a/src/dbus/qdbusintegrator.cpp b/src/dbus/qdbusintegrator.cpp
index dffdfe2..652924f 100644
--- a/src/dbus/qdbusintegrator.cpp
+++ b/src/dbus/qdbusintegrator.cpp
@@ -1,7 +1,7 @@
 /
 **
 ** Copyright (C) 2015 The Qt Company Ltd.
-** Copyright (C) 2015 Intel Corporation.
+** Copyright (C) 2016 Intel Corporation.
 ** Contact: http://www.qt.io/licensing/
 **
 ** This file is part of the QtDBus module of the Qt Toolkit.
@@ -120,8 +120,7 @@ void qdbusDefaultThreadDebug(int action, int condition, QDBusConnectionPrivate *
 qdbusThreadDebugFunc qdbusThreadDebug = 0;
 #endif
 
-typedef void (*QDBusSpyHook)(const QDBusMessage&);
-typedef QVarLengthArray QDBusSpyHookList;
+typedef QVarLengthArray QDBusSpyHookList;
 

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 72 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/72/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 20 Jan 2016 05:59:16 +
Build duration: 9.9 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Deadlock in kded whith Qt 5.6

[David Faure]

On Tuesday 19 January 2016 22:54:35 Thiago Macieira wrote:
> On Monday 18 January 2016 09:23:51 David Faure wrote:
> > Thiago: indeed the BlockingQueuedConnection call from messageFilter to the
> > main thread occasionnally leads to deadlocks, we need your
> > "postpone incoming messages" idea.
> 
> Please try the attached patch, also found at
>   https://codereview.qt-project.org/146639

Doesn't seem to support service autostart + module autoload together.

If kded5 isn't running, then
$ qdbus org.kde.kcookiejar5  
works (autostart OK)
and then
$ qdbus org.kde.kcookiejar5  /modules/kcookiejar
works (module autoload OK)

but if I kill kded5 again and do this right away:
$ qdbus org.kde.kcookiejar5  /modules/kcookiejar
then it doesn't work: kded5 gets started, but the call gets this reply
Error: org.freedesktop.DBus.Error.UnknownObject
No such object path '/modules/kcookiejar'

This is obviously after reverting my BlockingQueuedConnection hacks in kded and 
kiod.


Same issue with kiod (who has the same logic, but starts much faster).
$ qdbus org.kde.kpasswdserver /modules/kpasswdserver
Error: org.freedesktop.DBus.Error.UnknownObject
No such object path '/modules/kpasswdserver'
$ qdbus org.kde.kpasswdserver /modules/kpasswdserver
works the second time.

The messageFilter doesn't run at all, when doing autostart+autoload together.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126813: Fix build with older polkit

[Alex Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126813/
---

Review request for KDE Frameworks.


Repository: polkit-qt-1


Description
---

Seems like the function exists, but the header declaration is missing


Diffs
-

  core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd 

Diff: https://git.reviewboard.kde.org/r/126813/diff/


Testing
---

compiles now


Thanks,

Alex Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126725: prevent crash-on-exit in KSelectAction::~KSelectAction

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126725/
---

(Updated Jan. 19, 2016, 2:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Submitted with commit 0ea74ebc5ce3e4adcad37b9bb9096988d438848f by René J.V. 
Bertin to branch master.


Repository: kwidgetsaddons


Description
---

I was seeing a systematic crash on exitting kdenlive5, on OS X deep under the 
`delete menu()` instruction in `KSelectAction::~KSelectAction`. The backtrace 
suggested this might be due to a pending event (or an event due to the menu 
deletion) being delivered post-mortem to an instance of a QMenu related class.

My fix is based on 3 principles:
1) release the "foreign" member instance (`menu()`) before releasing the own 
d-ptr
2) Remove the QMenu instance from ourselves before deleting it to have one less 
potential dangling reference to it
3) QMenu is a QObject descendent that corresponds to a UI element: on OS X it 
is safer to dispose these through `deleteLater()` rather than directly.


Diffs
-

  src/kselectaction.cpp 1381099 

Diff: https://git.reviewboard.kde.org/r/126725/diff/


Testing
---

On OS X 10.9.5, Qt 5.5.1 and KF5 Frameworks 5.16.0, built for installation 
under /opt/local .

It seems that points 1) and 2) above already solve the crash issue in kdenlive 
on OS X, but the general principle stands so I suggest keeping 3) in library 
code like this.


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Deadlock in kded whith Qt 5.6

[Andreas Hartmetz]

On Dienstag, 19. Januar 2016 10:02:33 CET Aleix Pol wrote:
> On Mon, Jan 18, 2016 at 9:23 AM, David Faure  wrote:
> > On Friday 15 January 2016 13:48:14 Aleix Pol wrote:
> >> On Fri, Jan 15, 2016 at 1:02 PM, Aleix Pol  
wrote:
> >> > Hi,
> >> > I realized earlier last week that some of my applications were
> >> > freezing, it turns out it's because my kded is freezing and any
> >> > dbus
> >> > calls there need to time out (they take 30s to time out btw).
> >> > 
> >> > Anyway, here's the backtrace: https://paste.kde.org/pajbfmoh8
> >> > 
> >> > I saw David did something in that direction earlier but I
> >> > couldn't
> >> > spot exactly where's the problem, so I decided to report it here,
> >> > hoping he'd know what's going on. :D
> >> > 
> >> > Thanks!!
> >> > 
> >> > Aleix
> >> 
> >> Now that I know how to report a bug to kded5, I reported it. Here
> >> it
> >> is, for completion:
> >> https://bugs.kde.org/show_bug.cgi?id=358017
> > 
> > Thiago: indeed the BlockingQueuedConnection call from messageFilter
> > to the main thread occasionnally leads to deadlocks, we need your
> > "postpone incoming messages" idea.
> 
> It's good to know there's a plan, would it maybe be possible to expand
> a bit? I'd be interested in looking into it as my system is quite
> unusable and I can expect other people will become soon enough.
> 
I briefly talked about this with David yesterday and looked at the code.
What happened previously in kded5:
- it installs a message filter using libdbus API
- when a message to a not-yet-loaded module comes along, the module
  is loaded on the fly and directly from the message filter function 
  before the message is allowed to continue on its way

What happens now:
- the D-Bus connection lives in its own thread, in order to facilitate 
  using the connection from arbitrary threads in the application
- this puts the message filter in the D-Bus thread
- multithreading issues ensue

At the moment, you can pick between various poisons and eventually you 
have two threads waiting for each other and kded5 is mostly deadlocked.
The suggested solution is probably to *queue* messages to not-yet-loaded 
modules and to continue processing other D-Bus message while the 
required modules for the queued message are loading. That would break 
reasonable expectations about message ordering and blocking the least, I 
guess.

Ceteri censeo...
If you do anything blocking in D-Bus, you are going to have a bad time 
unless you have made sure that it is not so. "What could possibly go 
wrong?" is not good enough. Exceptions are calls to quickly replying 
services that are guaranteed to never make D-Bus calls of their own (*), 
and messages to the D-Bus daemon itself.
Please do not use blocking D-Bus calls unless you REALLY know what you 
are doing.
Now I've shamed myself into writing that documentation patch for QtDBus 
that I have wanted to write and submit since a year or three. It should 
have a big fat warning.
Asynchronous code is more tedious but it is in the general case the only 
correct way to make D-Bus calls.

Regarding the current situation, the synchronous module loading was okay 
before the Qt change unless modules somehow made D-Bus calls to 
something else than the daemon (to register their address) just by being 
loaded.
We have had lots of kded5 issues due to blocking calls over the years 
but I don'r remember seeing module loading in any backtraces.

(*) That is where deadlocks happen - directly or indirectly calling out 
to something that is in turn waiting for you.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126813: Fix build with older polkit

[David Jarvie]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126813/#review91338
---



The symbol `polkit_system_bus_name_get_user_sync` doesn't exist in the Debian 
stable polkit libraries (it doesn't exist in the polkit-1 package sources or 
Debian patches either). The Debian stable package version is 0.105-8.

The patch does allow polkit-qt-1 to build, but presumably it might lead to link 
errors if `SystemBusNameSubject::user()` is referenced. Wouldn't it be better 
to deal with the symbol `polkit_system_bus_name_get_user_sync` in the same 
manner as `polkit_authority_get_sync` and `polkit_agent_listener_register`, 
which if they are missing from the libraries, CMakeLists.txt sets the 
conditional define `POLKIT_QT_1_COMPATIBILITY_MODE`. That could also be used to 
conditionally compile the code referencing 
`polkit_system_bus_name_get_user_sync`.

- David Jarvie


On Jan. 19, 2016, 1:09 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126813/
> ---
> 
> (Updated Jan. 19, 2016, 1:09 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: polkit-qt-1
> 
> 
> Description
> ---
> 
> Seems like the function exists, but the header declaration is missing
> 
> 
> Diffs
> -
> 
>   core/polkitqt1-subject.cpp ecb4c0e216d5bacf5dff5cf100611b941d3e8fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/126813/diff/
> 
> 
> Testing
> ---
> 
> compiles now
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126818: Cache QX11Info::appRootWindow in eventFilter

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126818/#review91355
---



+1

Purely unscientific measurement through ksysguard shows that this halves the 
CPU usage of plasmashell during a file copy operation.

- Kai Uwe Broulik


On Jan. 19, 2016, 11:21 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126818/
> ---
> 
> (Updated Jan. 19, 2016, 11:21 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> appRootWindow is (relatively) expensive and won't change.
> nativeEventFilter is called a lot
> 
> This should speed things up.
> 
> CCBUG: 356479
> 
> 
> Diffs
> -
> 
>   src/platforms/xcb/kwindowsystem.cpp 
> 9d287043c24894ca3c29c439c7939b139da055e8 
>   src/platforms/xcb/kwindowsystem_p_x11.h 
> 3fa82a436d7fe12b50f7e8efd7338faf817f6579 
> 
> Diff: https://git.reviewboard.kde.org/r/126818/diff/
> 
> 
> Testing
> ---
> 
> Ran some apps and they seemed to still work.
> Not tested any specific functionality.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126806: DragDropEvent: Add ignore() function

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126806/#review91340
---


Ship it!




Ship It!

- Sebastian Kügler


On Jan. 18, 2016, 9:44 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126806/
> ---
> 
> (Updated Jan. 18, 2016, 9:44 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> Add ignore() function to make it possible to reject events.
> 
> 
> Diffs
> -
> 
>   src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h 9e57531 
>   src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp 679d1ab 
>   src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp b7aeeb7 
> 
> Diff: https://git.reviewboard.kde.org/r/126806/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126806: DragDropEvent: Add ignore() function

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126806/
---

(Updated Jan. 19, 2016, 4:49 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit b67a1ce3a14db308685f2f07ef740bb86ad48de7 by David Rosca 
to branch master.


Repository: kdeclarative


Description
---

Add ignore() function to make it possible to reject events.


Diffs
-

  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.h 9e57531 
  src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp 679d1ab 
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp b7aeeb7 

Diff: https://git.reviewboard.kde.org/r/126806/diff/


Testing
---


Thanks,

David Rosca

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Deadlock in kded whith Qt 5.6

[Thiago Macieira]

On Tuesday 19 January 2016 15:56:47 you wrote:
> I briefly talked about this with David yesterday and looked at the code.
> What happened previously in kded5:
> - it installs a message filter using libdbus API

QtDBus API. In fact, it's QtDBus API that exists and has existed only for kded 
(and now kiod).

> - when a message to a not-yet-loaded module comes along, the module
>   is loaded on the fly and directly from the message filter function
>   before the message is allowed to continue on its way
> 
> What happens now:
> - the D-Bus connection lives in its own thread, in order to facilitate
>   using the connection from arbitrary threads in the application
> - this puts the message filter in the D-Bus thread
> - multithreading issues ensue

Because the new QtDBus code assumes that certain functions will always be 
called from any-thread-but-QDBusConnectionManager's, as the code is very 
careful to not ever call to user code in the manager's thread. The spy 
function breaks that promise and I didn't catch it when designing the threaded 
model.

> At the moment, you can pick between various poisons and eventually you
> have two threads waiting for each other and kded5 is mostly deadlocked.
> The suggested solution is probably to *queue* messages to not-yet-loaded
> modules and to continue processing other D-Bus message while the
> required modules for the queued message are loading. That would break
> reasonable expectations about message ordering and blocking the least, I
> guess.

Actually, we'll queue them all, since we don't know which messages trigger 
loading and which ones don't. So for every incoming message, we'll call out to 
the spy function in the main thread and, after it returns, we'll reinject the 
message into the normal QtDBus processing.

> Regarding the current situation, the synchronous module loading was okay
> before the Qt change unless modules somehow made D-Bus calls to
> something else than the daemon (to register their address) just by being
> loaded.
> We have had lots of kded5 issues due to blocking calls over the years
> but I don'r remember seeing module loading in any backtraces.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
  PGP/GPG: 0x6EF45358; fingerprint:
  E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel