Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-02-23 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127166/#review92707
---



nice refactoring. The code looks much cleaner!


src/klauncher/klauncher.h (line 274)


const QByteArray &


- Martin Gräßlin


On Feb. 24, 2016, 6:19 a.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127166/
> ---
> 
> (Updated Feb. 24, 2016, 6:19 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Martin Gräßlin.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> The ported klauncher at least has two bugs:
> 1. IMHO, it should compare the cached display string with == instead of != 
> (though != has been there since the old kdelibs, but it just doesn't look 
> correct to me, what's the point of assign dpy = mCached_dpy when dpy_str != 
> XDisplayString(dpy)? And what's the point use == in one place and != in other 
> two places? ).
> 2. it might free the cached connection without setting mCached.conn back to 
> nullptr, which could lead to double free or freeze when system logout.
> 
> This patch refactor the code a little bit with a helper function to update 
> the cached connection instead of duplicate the same logic everywhere. 
> getXCBConnection() will make sure the returned connection is error-free, 
> reuse the cached connection if possible, and update the cached connection if 
> needed.
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.h 31bfaaa 
>   src/klauncher/klauncher.cpp 7ea9da9 
> 
> Diff: https://git.reviewboard.kde.org/r/127166/diff/
> 
> 
> Testing
> ---
> 
> Compiles, startup notify works.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-02-23 Thread Xuetian Weng 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127166/
---

Review request for KDE Frameworks, David Faure and Martin Gräßlin.


Repository: kinit


Description
---

The ported klauncher at least has two bugs:
1. IMHO, it should compare the cached display string with == instead of != 
(though != has been there since the old kdelibs, but it just doesn't look 
correct to me, what's the point of assign dpy = mCached_dpy when dpy_str != 
XDisplayString(dpy)? And what's the point use == in one place and != in other 
two places? ).
2. it might free the cached connection without setting mCached.conn back to 
nullptr, which could lead to double free or freeze when system logout.

This patch refactor the code a little bit with a helper function to update the 
cached connection instead of duplicate the same logic everywhere. 
getXCBConnection() will make sure the returned connection is error-free, reuse 
the cached connection if possible, and update the cached connection if needed.


Diffs
-

  src/klauncher/klauncher.h 31bfaaa 
  src/klauncher/klauncher.cpp 7ea9da9 

Diff: https://git.reviewboard.kde.org/r/127166/diff/


Testing
---

Compiles, startup notify works.


Thanks,

Xuetian Weng

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/#review92704
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127164/
> ---
> 
> (Updated Feb. 24, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> The KPeople::ActionType is just a namespaced enum, so here's a wrapper
> that makes it usable from QML
> 
> 
> Diffs
> -
> 
>   src/declarative/peopleqmlplugin.cpp 1e0516a 
> 
> Diff: https://git.reviewboard.kde.org/r/127164/diff/
> 
> 
> Testing
> ---
> 
> Works all good.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Martin Klapetek 


> On Feb. 24, 2016, 1:47 a.m., Aleix Pol Gonzalez wrote:
> > What does it look like on the code?
> > 
> > `ActionTypeWrapper.TextChatAction` might be awkward.

KPeople.ActionType.TextChatAction


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/#review92701
---


On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127164/
> ---
> 
> (Updated Feb. 24, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> The KPeople::ActionType is just a namespaced enum, so here's a wrapper
> that makes it usable from QML
> 
> 
> Diffs
> -
> 
>   src/declarative/peopleqmlplugin.cpp 1e0516a 
> 
> Diff: https://git.reviewboard.kde.org/r/127164/diff/
> 
> 
> Testing
> ---
> 
> Works all good.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127142: Add a property indicating whether the models form a connected chain.

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127142/#review92702
---




src/kmodelindexproxymapper.h (line 84)


Maybe get some API documentation for isConnected?


- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:33 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127142/
> ---
> 
> (Updated Feb. 22, 2016, 5:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Replace existing asserts with a query and notification API.  This makes
> the class more suitable for use in QML.
> 
> 
> Diffs
> -
> 
>   autotests/kmodelindexproxymappertest.cpp PRE-CREATION 
>   src/kmodelindexproxymapper.h 9c4a63d7953ce3572cee47c5acc27f422c383f3b 
>   src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901 
> 
> Diff: https://git.reviewboard.kde.org/r/127142/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/#review92701
---



What does it look like on the code?

`ActionTypeWrapper.TextChatAction` might be awkward.

- Aleix Pol Gonzalez


On Feb. 24, 2016, 12:29 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127164/
> ---
> 
> (Updated Feb. 24, 2016, 12:29 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> The KPeople::ActionType is just a namespaced enum, so here's a wrapper
> that makes it usable from QML
> 
> 
> Diffs
> -
> 
>   src/declarative/peopleqmlplugin.cpp 1e0516a 
> 
> Diff: https://git.reviewboard.kde.org/r/127164/diff/
> 
> 
> Testing
> ---
> 
> Works all good.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127163: Add actionType to the PersonActionsModel

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127163/#review92700
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 24, 2016, 12:27 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127163/
> ---
> 
> (Updated Feb. 24, 2016, 12:27 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> This allows filtering for only specific action types
> 
> 
> Diffs
> -
> 
>   src/declarative/personactionsmodel.cpp ccdc6e6 
>   src/declarative/personactionsmodel_p.h 8032ab9 
> 
> Diff: https://git.reviewboard.kde.org/r/127163/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127159/#review92699
---


Ship it!




Everybody hates red backgrounds /o\.

Thanks!

- Aleix Pol Gonzalez


On Feb. 23, 2016, 10:50 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127159/
> ---
> 
> (Updated Feb. 23, 2016, 10:50 p.m.)
> 
> 
> Review request for KDE Frameworks, KDEPIM and Plasma.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> I've done this quite some time ago but noticed only just now that I still 
> have it locally
> * makes it less aggressive removing the red color
> * removes the other two colorful rectangles serving seemingly no purpose
> * moves the selected contact photo above the data
> * makes the contact grid delegates nicer
> * makes the default window size bigger
> 
> 
> Diffs
> -
> 
>   examples/qml/Main.qml 8d3a100 
> 
> Diff: https://git.reviewboard.kde.org/r/127159/diff/
> 
> 
> Testing
> ---
> 
> Functionality is kept, for looks see screenshots
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127117: Reverse the filtering logic

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127117/#review92698
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 23, 2016, 8:54 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127117/
> ---
> 
> (Updated Feb. 23, 2016, 8:54 p.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> For filtering multiple properties the logic needs to be OR
> rather than AND.
> 
> For example in Plasma Mobile, one can start a conversation
> either with a phonenumber contact or IM contact, so both
> properties need to be requested. But with AND matching it
> won't return anything (or only those contacts that have both
> and user merged them).
> 
> 
> Diffs
> -
> 
>   autotests/fakecontactsource.cpp b227723 
>   autotests/personsproxymodeltest.cpp 1143e5f 
>   src/personssortfilterproxymodel.cpp b011cbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127117/diff/
> 
> 
> Testing
> ---
> 
> I get both phonenumber and IM contacts in Plasma Mobile
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/#review92697
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 23, 2016, 2:50 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127031/
> ---
> 
> (Updated Feb. 23, 2016, 2:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Adds a method similar to qVersion() that returns a string of the
> frameworks version being run. This differs from the header file which
> can only provide the version this app is compiled against.
> 
> The intended usage is in drkonqi system information.
> 
> 
> Diffs
> -
> 
>   src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
>   src/lib/kcoreaddons.h PRE-CREATION 
>   src/lib/kcoreaddons.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127031/diff/
> 
> 
> Testing
> ---
> 
> See https://git.reviewboard.kde.org/r/127032/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127148: KLinkItemSelectionModel: Add new default constructor.

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127148/#review92696
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:31 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127148/
> ---
> 
> (Updated Feb. 22, 2016, 5:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Make it possible to construct this in QML
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127148/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127147: KLinkItemSelectionModel: Make the linked selection model settable

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127147/#review92695
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127147/
> ---
> 
> (Updated Feb. 22, 2016, 5:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KLinkItemSelectionModel: Make the linked selection model settable
> 
> 
> Diffs
> -
> 
>   autotests/klinkitemselectionmodeltest.h 
> 6e9c178cd99ed5479e2cee34492a8acd7e5a3f75 
>   autotests/klinkitemselectionmodeltest.cpp 
> 74d72e4858dfd8bab48a71d260af86d838484d26 
>   src/klinkitemselectionmodel.h c871121fa9a791b6030f5ff3a104d8d3bdcbe79d 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127147/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-23 Thread Aleix Pol Gonzalez 


> On Feb. 24, 2016, 1:36 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!

Eh.. wait, we still support Qt 5.3, will that be a problem?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---


On Feb. 22, 2016, 5:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> ---
> 
> (Updated Feb. 22, 2016, 5:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> ---
> 
> (Updated Feb. 22, 2016, 5:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127139: Add unit test for KModelIndexProxyMapper.

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127139/#review92692
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 5:28 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127139/
> ---
> 
> (Updated Feb. 22, 2016, 5:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Add unit test for KModelIndexProxyMapper.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 731b83b742acf5edb93ba1420845dbdd95751f74 
>   autotests/kmodelindexproxymappertest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127139/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127140: KModelIndexProxyMapper: Add some asserts

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127140/#review92691
---




src/kmodelindexproxymapper.cpp (line 232)


Get the condition inside the assert?

`Q_ASSERT(seekSelection.isEmpty() || seekSelection.first().model() == 
proxy);`


Same for the rest.

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:35 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127140/
> ---
> 
> (Updated Feb. 22, 2016, 4:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KModelIndexProxyMapper: Add some asserts
> 
> 
> Diffs
> -
> 
>   src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901 
> 
> Diff: https://git.reviewboard.kde.org/r/127140/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127141: KModelIndexProxyMapper: Simplify logic of connected check

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127141/#review92690
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:35 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127141/
> ---
> 
> (Updated Feb. 22, 2016, 4:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KModelIndexProxyMapper: Simplify logic of connected check
> 
> 
> Diffs
> -
> 
>   src/kmodelindexproxymapper.cpp ae9e69a558f90bf498da730f96af773e3eb91901 
> 
> Diff: https://git.reviewboard.kde.org/r/127141/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127143: Reset KSelectionProxyModel state when needed

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127143/#review92689
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:34 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127143/
> ---
> 
> (Updated Feb. 22, 2016, 4:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> When the model of the selectionModel is changed, it is necessary to
> reset the proxy and clear any selection state.
> 
> This amends commit v5.9.0~5 (KSPM: Connect properly to the source model if it
> is changed., 2015-03-12)
> 
> 
> Diffs
> -
> 
>   autotests/kselectionproxymodeltest.cpp 
> b9f1277f1469970195dfb1fd0be68c6e8411fb23 
>   src/kselectionproxymodel.cpp 428b849eedd0c4f187be30a5879b72e0df268c5a 
> 
> Diff: https://git.reviewboard.kde.org/r/127143/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127144: KSelectionProxyModel: Fix iteration bug

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127144/#review92688
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:34 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127144/
> ---
> 
> (Updated Feb. 22, 2016, 4:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Two bugs in one line of code.  This exists since the class was introduced, and
> can result in an incomplete selection mapping, and strange behavior.
> 
> 
> Diffs
> -
> 
>   autotests/kselectionproxymodeltest.cpp 
> b9f1277f1469970195dfb1fd0be68c6e8411fb23 
>   src/kselectionproxymodel.cpp 428b849eedd0c4f187be30a5879b72e0df268c5a 
> 
> Diff: https://git.reviewboard.kde.org/r/127144/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127146: KLinkItemSelectionModel: Handle changes to the selectionModel model

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127146/#review92687
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:34 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127146/
> ---
> 
> (Updated Feb. 22, 2016, 4:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KLinkItemSelectionModel: Handle changes to the selectionModel model
> 
> 
> Diffs
> -
> 
>   autotests/klinkitemselectionmodeltest.h 
> 6e9c178cd99ed5479e2cee34492a8acd7e5a3f75 
>   autotests/klinkitemselectionmodeltest.cpp 
> 74d72e4858dfd8bab48a71d260af86d838484d26 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127146/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127149: KLinkItemSelectionModel: Test the effect of separate object network

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127149/#review92686
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:34 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127149/
> ---
> 
> (Updated Feb. 22, 2016, 4:34 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> Create, use and destroy an additional network of objects mapping selection
> to verify the effect on the original selection.
> 
> 
> Diffs
> -
> 
>   autotests/klinkitemselectionmodeltest.h 
> 6e9c178cd99ed5479e2cee34492a8acd7e5a3f75 
>   autotests/klinkitemselectionmodeltest.cpp 
> 74d72e4858dfd8bab48a71d260af86d838484d26 
> 
> Diff: https://git.reviewboard.kde.org/r/127149/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127150: KLinkItemSelectionModel: Test clearing the selection

2016-02-23 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127150/#review92685
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On Feb. 22, 2016, 4:33 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127150/
> ---
> 
> (Updated Feb. 22, 2016, 4:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KLinkItemSelectionModel: Test clearing the selection
> 
> 
> Diffs
> -
> 
>   autotests/klinkitemselectionmodeltest.h 
> 6e9c178cd99ed5479e2cee34492a8acd7e5a3f75 
>   autotests/klinkitemselectionmodeltest.cpp 
> 74d72e4858dfd8bab48a71d260af86d838484d26 
> 
> Diff: https://git.reviewboard.kde.org/r/127150/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-23 Thread Albert Astals Cid 


> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote:
> > I'd prefer if you could fix this at the Qt level, why would 
> > nativeLanguageName ever return empty?
> 
> Andre Heinecke wrote:
> I've just checked. It's a Windows thing. qlocale_win calls windows API 
> getLocaleInfo(LOCALE_SNATIVELANGUAGENAME) ( 
> https://msdn.microsoft.com/en-us/library/windows/desktop/dd373863%28v=vs.85%29.aspx
>  ). So Qt Developers would probably (and rightly) say "This is a Windows bug" 
> and Indeed this might be fixed at some point in the far Future in Windows.
> 
> But my Observation is Qt does not (and for Windows apparently can not) 
> guarantee that QLocale::nativeLanguageName is not Empty. So KXmlGui should 
> try to handle this. As I don't know how this is for other platforms and it 
> only adds a tiny overhead I also don't think this should be Ifdefed for 
> Windows.
> 
> Albert Astals Cid wrote:
> well, reading the documentation of the function never mentions it can be 
> empty, and given all languages probably have a way to call themselves I as an 
> api user find it surprising it returns empty. 
> 
> sure I can agree it is a Windows bug, but why workaround it in every 
> single call to nativeLanguageName instead of inside Qt code? 
> 
> I mean, we probably even have this problem in other KDE code.
> 
> And sure, Qt takes a while to update/release so temporarily we may want 
> this workaround committed so our users get the fix earlier but I would really 
> appreciate if you could create a MR for Qt that either documents that 
> nativeLanguageName can return empty or one that makes sure it is not empty by 
> doing the same fallback we do here.
> 
> Andre Heinecke wrote:
> I'm not a qt contributor and this issue is not important enough to me to 
> spend the time with this. I'm pretty unwilling to work more on this. It would 
> be easier just dropping the exotic languages for which this problem exists. 
> (Although I really love the Plattdeutsch localisation of Kleopatra ;-) )
> As a compromoise I've reported a bug 
> https://bugreports.qt.io/browse/QTBUG-51323 and mentioned this in the patch.
> 
> The only other usages of nativeLanguageName in frameworks are sonnet and 
> kconfigwidgets/klanguagebutton.

Ok, any chance I can convince you to propose patches for those uses of 
nativeLanguageName too?

I guess you can commit this xmlgui patch, i'm not the maintainer though, so i'd 
say wait a few days in case anyone else has a comment and i not commit.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127136/#review92630
---


On Feb. 23, 2016, 3:16 p.m., Andre Heinecke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127136/
> ---
> 
> (Updated Feb. 23, 2016, 3:16 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> While packaging Kleopatra's translations for Gpg4win I've noticed that there 
> were blank entries in the Switchlanguagedialog.
> Apperantly QLocale::nativeLanguageName can return an Empty string (Qt 5.5 on 
> Windows).
> 
> This patch handles this and uses the non native QLocale::languageToString as 
> a fallback. The idea is that a non native Name is better then no name (and a 
> blank entry in the dialog) at all.
> 
> Ideally every language would have a native name but until this is the case I 
> think this fallback makes sense.
> 
> 
> Diffs
> -
> 
>   src/kswitchlanguagedialog_p.cpp 039daea 
> 
> Diff: https://git.reviewboard.kde.org/r/127136/diff/
> 
> 
> Testing
> ---
> 
> See attached screenshots of Kleopatra's switchlanguage dialog before and 
> after the patch. Low German is an example where the native name was empty.
> 
> 
> File Attachments
> 
> 
> Dialog before the patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/a6a31417-1ad6-432e-bee9-65a367fac28d__languages_before.png
> Dialog after the patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127164: Add actionType to the declarative plugin

2016-02-23 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/
---

Review request for KDE Frameworks and KDEPIM.


Repository: kpeople


Description
---

The KPeople::ActionType is just a namespaced enum, so here's a wrapper
that makes it usable from QML


Diffs
-

  src/declarative/peopleqmlplugin.cpp 1e0516a 

Diff: https://git.reviewboard.kde.org/r/127164/diff/


Testing
---

Works all good.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127163: Add actionType to the PersonActionsModel

2016-02-23 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127163/
---

Review request for KDE Frameworks and KDEPIM.


Repository: kpeople


Description
---

This allows filtering for only specific action types


Diffs
-

  src/declarative/personactionsmodel.cpp ccdc6e6 
  src/declarative/personactionsmodel_p.h 8032ab9 

Diff: https://git.reviewboard.kde.org/r/127163/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-23 Thread Varun Joshi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127158/
---

(Updated Feb. 23, 2016, 10:03 p.m.)


Review request for Baloo, KDE Frameworks and Vishesh Handa.


Changes
---

Added license headers


Repository: kfilemetadata


Description
---

Builds upon Boudhyan Gupta's work on external extractors, creating a process 
that runs a script that extracts/writes data, accepting input and producing an 
output (JSON-formatted) via stdin/stdout.

Adds Writer, WriterData, WriterPlugin and WriterCollection classes, analogous 
to the Extractor classes. The only notable difference is that consumer 
applications will be able to use WriteData (analogous to ExtractionResult) 
without subclassing it.

Adds ExternalWriter and ExternalExtractor classes. These handle input/output 
and communication with the external plugins.


Diffs (updated)
-

  README.md 19b1a26a241e6a35c636aaf8162afe762018f073 
  autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1 
  autotests/taglibwritertest.h PRE-CREATION 
  autotests/taglibwritertest.cpp PRE-CREATION 
  src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 
  src/config-kfilemetadata.h.in PRE-CREATION 
  src/externalextractor.h PRE-CREATION 
  src/externalextractor.cpp PRE-CREATION 
  src/externalwriter.h PRE-CREATION 
  src/externalwriter.cpp PRE-CREATION 
  src/extractorcollection.h 8542aed576102be2b0c86bbdf3d65d756d468c6e 
  src/extractorcollection.cpp a1bde65bf57e493918cd3e85ccdb23c4cd623401 
  src/extractorplugin.h 65abad3b2397628ba42a40d9ef2970e02114e250 
  src/extractors/CMakeLists.txt 5dd223e1cf6864a943e848664ad5fae0d0603e77 
  src/extractors/externalextractors/CMakeLists.txt PRE-CREATION 
  src/extractors/externalextractors/exampleextractor/main.py PRE-CREATION 
  src/extractors/externalextractors/exampleextractor/manifest.json PRE-CREATION 
  src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION 
  src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION 
  src/writedata.h PRE-CREATION 
  src/writedata.cpp PRE-CREATION 
  src/writer.h PRE-CREATION 
  src/writer.cpp PRE-CREATION 
  src/writer_p.h PRE-CREATION 
  src/writercollection.h PRE-CREATION 
  src/writercollection.cpp PRE-CREATION 
  src/writerplugin.h PRE-CREATION 
  src/writerplugin.cpp PRE-CREATION 
  src/writers/CMakeLists.txt PRE-CREATION 
  src/writers/externalwriters/CMakeLists.txt PRE-CREATION 
  src/writers/externalwriters/pdfwriter/main.py PRE-CREATION 
  src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION 
  src/writers/taglibwriter.h PRE-CREATION 
  src/writers/taglibwriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127158/diff/


Testing
---

Created a sample PDF reader and extractor in Python, both of which work 
successfully.


Thanks,

Varun Joshi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-02-23 Thread René J . V . Bertin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/
---

(Updated Feb. 23, 2016, 10:54 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

Some more code cleanup, and I got rid of most dependencies on the Carbon 
framework


Repository: kwindowsystem


Description
---

KWindowSystem has been lacking a platform plugin for OS X. This RR presents a 
"backport" of the modified KDE4 KWindowSystem implementation that has been used 
in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.

I have made some initial steps to remove deprecated Carbon API calls, but this 
is clearly a work in progress.

Open questions include
- is there any justification to run an event handler (or Cocoa observer) to 
keep track of running applications, possibly even listing all their open 
windows?
- is there any use for the Qt event listener framework (cf. the NETEventFilter 
in the X11 plugin)? I haven't yet had time to try to figure out what this 
"could be good for", and am very open to suggestions in this departments.
- one application for such an event filter would be a listener that catches the 
opening and closing of all windows by the running process, and keeps track of 
their `WId`s. A new method could then be added (to `KWindowInfo`?) to 
distinguish `WId`s created by the running application from "foreign" ones 
(useful also on Wayland and MS Windows).

`KWindowSystem::setMainWindow` should become a front for payload provided by 
the plugins. I'll leave that to the regular/official maintainer(s) of this 
framework.

This code could probably do with *lots* of comments; I'll try to add them as 
questions about this or that bit of code arise.


Diffs (updated)
-

  src/debug_p.h 5ef8996 
  src/debug_p.cpp 72abfb7 
  src/kwindowsystem.cpp 407a67d 
  src/platforms/osx/CMakeLists.txt 4fc3347 
  src/platforms/osx/SCRAPBOOK PRE-CREATION 
  src/platforms/osx/cocoa.json PRE-CREATION 
  src/platforms/osx/kkeyserver.cpp 3ddb921 
  src/platforms/osx/kwindowinfo.cpp e8555bb 
  src/platforms/osx/kwindowinfo.mm PRE-CREATION 
  src/platforms/osx/kwindowinfo_mac_p.h c8f307e 
  src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION 
  src/platforms/osx/kwindowsystem.cpp 1758829 
  src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION 
  src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION 
  src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION 
  src/platforms/osx/plugin.h PRE-CREATION 
  src/platforms/osx/plugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126291/diff/


Testing
---

On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 .


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-23 Thread Varun Joshi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127158/
---

Review request for Baloo, KDE Frameworks and Vishesh Handa.


Repository: kfilemetadata


Description
---

Builds upon Boudhyan Gupta's work on external extractors, creating a process 
that runs a script that extracts/writes data, accepting input and producing an 
output (JSON-formatted) via stdin/stdout.

Adds Writer, WriterData, WriterPlugin and WriterCollection classes, analogous 
to the Extractor classes. The only notable difference is that consumer 
applications will be able to use WriteData (analogous to ExtractionResult) 
without subclassing it.

Adds ExternalWriter and ExternalExtractor classes. These handle input/output 
and communication with the external plugins.


Diffs
-

  README.md 19b1a26a241e6a35c636aaf8162afe762018f073 
  autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1 
  autotests/taglibwritertest.h PRE-CREATION 
  autotests/taglibwritertest.cpp PRE-CREATION 
  src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 
  src/config-kfilemetadata.h.in PRE-CREATION 
  src/externalextractor.h PRE-CREATION 
  src/externalextractor.cpp PRE-CREATION 
  src/externalwriter.h PRE-CREATION 
  src/externalwriter.cpp PRE-CREATION 
  src/extractorcollection.h 8542aed576102be2b0c86bbdf3d65d756d468c6e 
  src/extractorcollection.cpp a1bde65bf57e493918cd3e85ccdb23c4cd623401 
  src/extractorplugin.h 65abad3b2397628ba42a40d9ef2970e02114e250 
  src/extractors/CMakeLists.txt 5dd223e1cf6864a943e848664ad5fae0d0603e77 
  src/extractors/externalextractors/CMakeLists.txt PRE-CREATION 
  src/extractors/externalextractors/exampleextractor/main.py PRE-CREATION 
  src/extractors/externalextractors/exampleextractor/manifest.json PRE-CREATION 
  src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION 
  src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION 
  src/writedata.h PRE-CREATION 
  src/writedata.cpp PRE-CREATION 
  src/writer.h PRE-CREATION 
  src/writer.cpp PRE-CREATION 
  src/writer_p.h PRE-CREATION 
  src/writercollection.h PRE-CREATION 
  src/writercollection.cpp PRE-CREATION 
  src/writerplugin.h PRE-CREATION 
  src/writerplugin.cpp PRE-CREATION 
  src/writers/CMakeLists.txt PRE-CREATION 
  src/writers/externalwriter.h PRE-CREATION 
  src/writers/externalwriter.cpp PRE-CREATION 
  src/writers/externalwriters/CMakeLists.txt PRE-CREATION 
  src/writers/externalwriters/pdfwriter/main.py PRE-CREATION 
  src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION 
  src/writers/taglibwriter.h PRE-CREATION 
  src/writers/taglibwriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127158/diff/


Testing
---

Created a sample PDF reader and extractor in Python, both of which work 
successfully.


Thanks,

Varun Joshi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-23 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127159/
---

Review request for KDE Frameworks, KDEPIM and Plasma.


Repository: kpeople


Description
---

I've done this quite some time ago but noticed only just now that I still have 
it locally
* makes it less aggressive removing the red color
* removes the other two colorful rectangles serving seemingly no purpose
* moves the selected contact photo above the data
* makes the contact grid delegates nicer
* makes the default window size bigger


Diffs
-

  examples/qml/Main.qml 8d3a100 

Diff: https://git.reviewboard.kde.org/r/127159/diff/


Testing
---

Functionality is kept, for looks see screenshots


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Taking a (semi-)break

2016-02-23 Thread Alex Merry 

On 2016-02-22 22:01, Stephen Kelly wrote:

Alex Merry wrote:


Hi all,

A combination of a serious illness in the family and some of the 
heated

discussions taking place on other KDE mailing lists has led to me
burning out on the KDE front. As a result, I'm taking a step back 
(some

of you may have noticed this already). I expect to get back into the
swing of things when I've recovered my energy, but I don't know how 
long

that will be.


Thanks for all of your efforts in driving ECM forward the last few 
years!


While I was previously quite active in ECM, I left it behind to focus 
on
modernizing CMake itself for the last few years. That particular goal 
is
achieved as far as I am concerned, so I'm not so active in CMake 
anymore.


I'll pick up some of the slack on the ECM front, so that it's not 
something

you need to feel concerned about or feel a nagging responsibility for.

I totally understand the need to create some space between yourself and 
a

mood altering environment as KDE can at times be, and I applaud your
refocusing on giving family and yourself attention instead. Feel good 
about

that!

I'm going to have to catch up on some of what has happened since 
v1.0.0, and
find out what the important issues are these days. If you have some 
pointers
on the latter - which you didn't expand upon to not scare someone off 
:) -

please let me know.

I'll have a look around in the coming weeks at drop questions here if I 
have

any.


Thank you! My vague TODO list was something like:

* improve test coverage
* update the documentation system to have the to-command links CMake's 
docs have (it would be nice to have a Sphinx module that was generically 
usable by projects downstream of CMake that would link to the upstream 
docs properly using intersphinx)
* the ecm_target_link_libraries thing you suggested to allow the 
ecm_add_tests command to be split up a bit
* up the minimum CMake version (need to decide with the Frameworks 
maintainers about how important Ubuntu 14.04 support is, mainly)

* upstream some stuff to CMake

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127117: Reverse the filtering logic

2016-02-23 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127117/
---

(Updated Feb. 23, 2016, 8:54 p.m.)


Review request for KDE Frameworks and KDEPIM.


Changes
---

Add a test


Repository: kpeople


Description
---

For filtering multiple properties the logic needs to be OR
rather than AND.

For example in Plasma Mobile, one can start a conversation
either with a phonenumber contact or IM contact, so both
properties need to be requested. But with AND matching it
won't return anything (or only those contacts that have both
and user merged them).


Diffs (updated)
-

  autotests/fakecontactsource.cpp b227723 
  autotests/personsproxymodeltest.cpp 1143e5f 
  src/personssortfilterproxymodel.cpp b011cbd 

Diff: https://git.reviewboard.kde.org/r/127117/diff/


Testing
---

I get both phonenumber and IM contacts in Plasma Mobile


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-23 Thread Andre Heinecke 


> On Feb. 22, 2016, 9:55 a.m., Albert Astals Cid wrote:
> > I'd prefer if you could fix this at the Qt level, why would 
> > nativeLanguageName ever return empty?
> 
> Andre Heinecke wrote:
> I've just checked. It's a Windows thing. qlocale_win calls windows API 
> getLocaleInfo(LOCALE_SNATIVELANGUAGENAME) ( 
> https://msdn.microsoft.com/en-us/library/windows/desktop/dd373863%28v=vs.85%29.aspx
>  ). So Qt Developers would probably (and rightly) say "This is a Windows bug" 
> and Indeed this might be fixed at some point in the far Future in Windows.
> 
> But my Observation is Qt does not (and for Windows apparently can not) 
> guarantee that QLocale::nativeLanguageName is not Empty. So KXmlGui should 
> try to handle this. As I don't know how this is for other platforms and it 
> only adds a tiny overhead I also don't think this should be Ifdefed for 
> Windows.
> 
> Albert Astals Cid wrote:
> well, reading the documentation of the function never mentions it can be 
> empty, and given all languages probably have a way to call themselves I as an 
> api user find it surprising it returns empty. 
> 
> sure I can agree it is a Windows bug, but why workaround it in every 
> single call to nativeLanguageName instead of inside Qt code? 
> 
> I mean, we probably even have this problem in other KDE code.
> 
> And sure, Qt takes a while to update/release so temporarily we may want 
> this workaround committed so our users get the fix earlier but I would really 
> appreciate if you could create a MR for Qt that either documents that 
> nativeLanguageName can return empty or one that makes sure it is not empty by 
> doing the same fallback we do here.

I'm not a qt contributor and this issue is not important enough to me to spend 
the time with this. I'm pretty unwilling to work more on this. It would be 
easier just dropping the exotic languages for which this problem exists. 
(Although I really love the Plattdeutsch localisation of Kleopatra ;-) )
As a compromoise I've reported a bug 
https://bugreports.qt.io/browse/QTBUG-51323 and mentioned this in the patch.

The only other usages of nativeLanguageName in frameworks are sonnet and 
kconfigwidgets/klanguagebutton.


- Andre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127136/#review92630
---


On Feb. 22, 2016, 9:52 a.m., Andre Heinecke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127136/
> ---
> 
> (Updated Feb. 22, 2016, 9:52 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> While packaging Kleopatra's translations for Gpg4win I've noticed that there 
> were blank entries in the Switchlanguagedialog.
> Apperantly QLocale::nativeLanguageName can return an Empty string (Qt 5.5 on 
> Windows).
> 
> This patch handles this and uses the non native QLocale::languageToString as 
> a fallback. The idea is that a non native Name is better then no name (and a 
> blank entry in the dialog) at all.
> 
> Ideally every language would have a native name but until this is the case I 
> think this fallback makes sense.
> 
> 
> Diffs
> -
> 
>   src/kswitchlanguagedialog_p.cpp 039daea 
> 
> Diff: https://git.reviewboard.kde.org/r/127136/diff/
> 
> 
> Testing
> ---
> 
> See attached screenshots of Kleopatra's switchlanguage dialog before and 
> after the patch. Low German is an example where the native name was empty.
> 
> 
> File Attachments
> 
> 
> Dialog before the patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/a6a31417-1ad6-432e-bee9-65a367fac28d__languages_before.png
> Dialog after the patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

2016-02-23 Thread Andre Heinecke 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127136/
---

(Updated Feb. 23, 2016, 3:16 p.m.)


Review request for KDE Frameworks.


Changes
---

Mentioned Qt bug and that it's platform specific.


Repository: kxmlgui


Description
---

While packaging Kleopatra's translations for Gpg4win I've noticed that there 
were blank entries in the Switchlanguagedialog.
Apperantly QLocale::nativeLanguageName can return an Empty string (Qt 5.5 on 
Windows).

This patch handles this and uses the non native QLocale::languageToString as a 
fallback. The idea is that a non native Name is better then no name (and a 
blank entry in the dialog) at all.

Ideally every language would have a native name but until this is the case I 
think this fallback makes sense.


Diffs (updated)
-

  src/kswitchlanguagedialog_p.cpp 039daea 

Diff: https://git.reviewboard.kde.org/r/127136/diff/


Testing
---

See attached screenshots of Kleopatra's switchlanguage dialog before and after 
the patch. Low German is an example where the native name was empty.


File Attachments


Dialog before the patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/a6a31417-1ad6-432e-bee9-65a367fac28d__languages_before.png
Dialog after the patch
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/22/762062c5-ff18-47da-aeb0-93b16ca28883__languages_after.png


Thanks,

Andre Heinecke

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127121: KWallet::openWallet(Synchronous) : time out after 1 hour rather than 25 seconds.

2016-02-23 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127121/#review92667
---


Ship it!




Ship It!

- David Edmundson


On Feb. 20, 2016, 8:48 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127121/
> ---
> 
> (Updated Feb. 20, 2016, 8:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> The default DBus timeout is 25 seconds, which means that if the user went to
> get a cup of tea during session startup, when they come back they get prompted
> with all sorts of additional non-kwallet password requests due to all kwallet
> requests having timed out.
> 
> I added setTimeout in QDBusAbstractInterface in Qt 4.8 for things like this.
> 
> Testcase:
>  eval `dbus-launch`
>  export SSH_ASKPASS=$KDEDIR/bin/ksshaskpass
>  ssh-add < /dev/null
> (but the same happens with the IMAP resource etc.)
> 
> 
> Diffs
> -
> 
>   src/api/KWallet/kwallet.cpp b72edad19840943f70755c8668668a1881f1fb39 
> 
> Diff: https://git.reviewboard.kde.org/r/127121/diff/
> 
> 
> Testing
> ---
> 
> (see commit log)
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

2016-02-23 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126883/#review92668
---


Ship it!




Ship It!

- Marco Martin


On Jan. 25, 2016, 2:10 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126883/
> ---
> 
> (Updated Jan. 25, 2016, 2:10 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma and Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> This method is intended to replace contentsHash which operates only
> on Sha1. In order to support more secure hashing algorithmns and also
> to support future developments the new implementation does not hard
> code the algorithm but allows to specify it. By that the existing
> implementation can just delegate to the new one.
> 
> Another change in the implementation is that the new cryptographicHash
> method returns a QByteArray instead of a QString. As only a hex
> representation of the hash is returned the conversion to QString is
> not necessary.
> 
> Package::contentsHash() is marked as deprecated.
> 
> 
> Diffs
> -
> 
>   autotests/plasmoidpackagetest.cpp 69f45f57bbec5c0f6d2268869249606c50338765 
>   src/kpackage/package.h b97b70be42df7d9fd09e3fb4e7b82b00ef970be3 
>   src/kpackage/package.cpp 4c0f671965d9ed33b9f52b06205bf6ffcda94c8a 
> 
> Diff: https://git.reviewboard.kde.org/r/126883/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

2016-02-23 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review92662
---


Ship it!




- David Edmundson


On Feb. 16, 2016, 2:02 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Feb. 16, 2016, 2:02 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize.svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

2016-02-23 Thread Andreas Kainz 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/#review92666
---


Ship it!




Ship It!

- Andreas Kainz


On Feb. 16, 2016, 2:02 vorm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126740/
> ---
> 
> (Updated Feb. 16, 2016, 2:02 vorm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: breeze-icons
> 
> 
> Description
> ---
> 
> Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea 
> that right now we're serving right away the svg's from inkscape and there's 
> room for improvement, potentially.
> 
> This patch just introduces a script that optimizes the svg's using `svgo`.
> 
> More could be done, like using gzip files, we can look into that if anyone's 
> interested. In fact, we used to use svgz for the icons, I wonder why that 
> changed. 
> 
> This will change the files in-place rather than as a build step, which is 
> what I considered first. The process to run svgo on every file was about 30 
> minutes to 1h on my system, so I doubt it's really desirable.
> 
> A reduced file size is important because it will greatly reduce disk IO, 
> which is a bottle-neck we have.
> 
> 
> Diffs
> -
> 
>   optimize.svg.sh PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126740/diff/
> 
> 
> Testing
> ---
> 
> ```
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 32M icons
> 32M icons-dark/
> 
> #run the script
> 
> kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
> 17M icons
> 17M icons-dark/
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 237 - Unstable!

2016-02-23 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/237/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 23 Feb 2016 13:42:39 +
Build duration: 5 min 57 sec

CHANGE SET
Revision cf8906a4ddac2472c35915f2c7820195e4562b3d by hein: (A series of changes 
to avoid a directory relist after a file rename in)
  change: edit src/core/kprotocolinfo.cpp
  change: edit src/core/kfileitem.cpp
  change: edit src/core/kdirnotify.h
  change: edit src/core/kdirnotify.cpp
  change: edit src/core/kfileitem.h
  change: edit src/core/kprotocolinfo.h
  change: edit src/core/org.kde.KDirNotify.xml
  change: edit src/core/kprotocolinfo_p.h
  change: edit src/core/kcoredirlister_p.h
  change: edit src/core/simplejob.cpp
  change: edit src/core/kcoredirlister.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
49 test(s)Failed: TestSuite.kiogui-favicontest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 257/335 (77%)CLASSES 257/335 (77%)LINE 26629/50584 
(53%)CONDITIONAL 14532/22537 (64%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7306/7597 
(96%)CONDITIONAL 3965/7280 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7742/14138 
(55%)CONDITIONAL 4063/5642 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1836/3823 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10646 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-23 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 23, 2016, 1:50 p.m.)


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs (updated)
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127079: fix uninitialised var

2016-02-23 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/
---

(Updated Feb. 23, 2016, 2:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 73aa13b26da3a79fa861ec54509c6c0710b2e020 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Valgrind pointed this out whilst debugging something else.

(though I'm not sure what on the desktop creates an Application object)


Diffs
-

  src/declarativeimports/platformcomponents/application.cpp 
a3aecc4a13541d41136fd0b34e58b3107eda060f 

Diff: https://git.reviewboard.kde.org/r/127079/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

2016-02-23 Thread Thomas Pfeiffer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127127/#review92657
---



+1 from the usability side, great improvement!

- Thomas Pfeiffer


On Feb. 21, 2016, 11:28 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127127/
> ---
> 
> (Updated Feb. 21, 2016, 11:28 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Bugs: 110146
> https://bugs.kde.org/show_bug.cgi?id=110146
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> BUG: 110146
> 
> 
> Diffs
> -
> 
>   src/widgets/kopenwithdialog.cpp 808af73ff332834e013bd3727fee54183eee538b 
> 
> Diff: https://git.reviewboard.kde.org/r/127127/diff/
> 
> 
> Testing
> ---
> 
> kio/tests/kopenwithtest
> 
> 
> File Attachments
> 
> 
> screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/20/b3a0babf-43b5-4921-ab7a-899c011c115c__kopenwith-mime.png
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Spread to more platforms - Randa Meetings 2016 open for registration

2016-02-23 Thread Mario Fux 
Good morning everyone

Please excuse this cross-posting but all the above mailing list fit quite well 
this year's topic of the Randa Meetings:

multi-platform end-user application development. This includes stuff like 
improving KDE Frameworks 5 (KF5) on other platforms like MS Windows, Android 
or Apple’s MacOSX, presenting and discussing how software distribution works 
on other systems than GNU/Linux (Windows installers, app stores and 
application bundles) and learning from the experience projects like Krita, 
digiKam, Rkward, Kdenlive & Co collected. We’d like to bring this information 
to more KDE Applications and work on this during a full week.

So if you're interested and can help please go to:
https://sprints.kde.org/sprint/301
and add yourself.

And spread this information and tell people that could be of great help.

This email though is just an informational email and thus not to start a 
discussion.

Thanks and cu soon
Mario
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

2016-02-23 Thread David Faure 


> On Feb. 20, 2016, 7:46 p.m., David Faure wrote:
> > src/filewidgets/kurlnavigator.h, line 428
> > 
> >
> > Signal names usually end with "ed", they reflect a state change or an 
> > action change.
> > 
> > "select" here is what you want the app to do (now that I read the bug 
> > report; otherwise it was very unclear just from the API docs), but you have 
> > no guarantee that the app will do that.
> > 
> > void urlChangedToParent(const QUrl )
> > 
> > ?
> > 
> > An alternative is to let the app do the "finding the immediate child" 
> > logic by just emitting
> > 
> > void urlChangedToParent(const QUrl , const QUrl )
> > 
> > It seems to me that this is a better signal, because it's more generic. 
> > On the other hand, if you are afraid that multiple apps would then need to 
> > implement the "first child" logic, then this could be done by a helper 
> > method in this class. But at least the signal has a much more generic 
> > purpose than being geared towards this specific feature,
> > which increases the chances that it is useful for other things later.
> 
> Frank Reininghaus wrote:
> I also thought first that something like urlChangedToParent(QUrl) would 
> be a good signal name, but it might make people think that this signal will 
> always be emitted when navigating from a URL to its (possibly indirect) 
> parent.
> 
> However, this is not the case - the new signal will only be emitted if 
> the URL change of the KUrlNavigator was triggered by a call of 
> setLocationUrl(const QUrl&). If the URL change was caused by invoking the 
> goBack() or goForward() slots, then the signal will not be emitted. The 
> reason is that the user of KUrlNavigator will try to restore the view state 
> (using the result from KUrlNavigator's locationState() function) then, and 
> selecting any parents would interfere with that (see the discussion in 
> https://git.reviewboard.kde.org/r/123253/ ).
> 
> So the idea is that the new signal is only emitted if no history action 
> was responsible for the URL change. This makes it possible for Dolphin and 
> other users of KUrlNavigator to behave like some other file managers, which 
> also select the parent of the previous URL, unless the URL change was caused 
> by back/forward. So anything with 'changed' is not really accurate, because a 
> change is not sufficient to emit this signal.
> 
> Still, it might make sense to have an 'ed' in the name. 'requested' 
> appears often in signals which are not so much about state changes, but have 
> the purpose to make the receiver do something. How about
> 
> urlSelectionRequested(const QUrl &) ?

OK, I see. Yes, this is better. The comment would still explain this use case 
for requesting selection, but in theory this lets the door open for more use 
cases for the url navigator requesting that a selection be performed. In any 
case the signal name is much easier to understand this way ;)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127111/#review92587
---


On Feb. 18, 2016, 9:53 p.m., Gregor Mi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127111/
> ---
> 
> (Updated Feb. 18, 2016, 9:53 p.m.)
> 
> 
> Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Frank 
> Reininghaus.
> 
> 
> Bugs: 335616
> https://bugs.kde.org/show_bug.cgi?id=335616
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Moved logic from https://git.reviewboard.kde.org/r/123253 to here.
> 
> Provides a signal to implement bug 
> https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent 
> folder selects child folder".
> 
> 
> Diffs
> -
> 
>   src/filewidgets/kurlnavigator.h 4ffe56acf9ef7a80ba27ba3a08327e363f98fb0d 
>   src/filewidgets/kurlnavigator.cpp 64d2a6d1d5cf8ca2e0aaa61d00ac1ffb1a9866b3 
>   src/filewidgets/urlutil.h PRE-CREATION 
>   tests/CMakeLists.txt dc88ce9fd5c5ae6ad135b72785370c0094969b5c 
>   tests/urlutiltest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel