Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Anthony Fieroni]

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote:
> > src/kstatusnotifieritem.cpp, line 934
> > 
> >
> > append
> > associatedWidget->setAttribute(Qt::WA_Moved);
> > 
> > 
> > 
> > This should tell Qt to demand an explicit position and skip placement 
> > by the WM (yes, this generally works in KWin ;-)
> > 
> > However, this flag should be implicitly set by ::move() unless the 
> > point is invalid, so you might want to "qDebug() << associatedWidgetPos;" 
> > to check whether it's invalid for the failing clients.
> 
> Anthony Fieroni wrote:
> Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is 
> called only when you click on tray icon i.e. if i close app with big red X 
> it's not called => i can't store position :)
> 
> Anthony Fieroni wrote:
> More fun facts :) 
> associatedWidget->setGeometry(associatedWidget->frameGeometry()); works in 
> any case ! I will add path if you want, but you will not be happy to set 
> geometry by myself :)
> 
> Anthony Fieroni wrote:
> ^ No, extend geometry with decoration size :)
> 
> Thomas Lübking wrote:
> meehhh...
> 
> That means one will have to filter QEvent::Close of associatedWidget and 
> store the position from there.
> 
> Anthony Fieroni wrote:
> It's strange, about me, associatedWidget has correct frameGeometry even 
> it's hide.
> QObject::connect(KWindowSystem::self(), &KWindowSystem::windowRemoved, q, 
> [this](WId winId) {
> if (associatedWidget && associatedWidget->winId() == winId) {
> associatedWidgetPos = 
> associatedWidget->frameGeometry().topLeft();
> }
> });
> Position is correct, but again not work event with Qt::WA_Moved.
> 
> Anthony Fieroni wrote:
> KWindowInfo info(associatedWidget->winId(), NET::WMDesktop | 
> NET::WMGeometry);
> info.geometry().topLeft(); <- decoration is 
> included again
> to filed bug?
> 
> Thomas Lübking wrote:
> You may file a bug, but I frankly doubt your findings.
> (Just more or less ported my kwindowsystem tool and the values are 
> correct ;-)
> 
> => How exactly did you determine this assumption? (Just from the walking 
> position?)

I can't move widget when new position not match frameGeometry().topLeft by 
itself.
associatedWidgetPos = associatedWidget->geometry().topLeft(); -> can move but 
new position is with decoration offset
associatedWidgetPos = associatedWidget->pos(); -> can't move, this is wanted 
position, not match internal wigdet frameGeometry
I saw qwidget move code, Qt::WA_Moved is setted at start.
I saw the qwidget close code, because when i click X -> now i CAN move to pos ! 
Why the hell, i try setAttribute(Qt::WA_QuitOnClose, false);
What are attribute setted/unsetted on X click?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review93143
---


On Фев. 29, 2016, 7:18 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Фев. 29, 2016, 7:18 преди обяд)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin 
> Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: gcode.xml got into KF5::KTextEditor without review

[Aleix Pol]

On Sat, Mar 5, 2016 at 1:12 AM, Sven Brauch  wrote:
> Hey Alexander,
>
> Thanks for caring and sorry for breaking the string freeze; I missed
> that. I reverted the commit and I will resubmit it after the 5.8 release
> is out.
>
> On 05/03/16 01:01, Alexander Potashev wrote:
>> [2] is clearly a feature, but it was not submitted to reviewboard
>> before pushing to ktexteditor.git:master.
> I thought it was up to the individual projects how to handle that. New
> syntax highlighting files are really not critical changes at all, and I
> consider the reviewing and fixing that happened on kwrite-devel for this
> patch sufficient. It did not seem necessary to make a new and probably
> one-time contributor go through reviewboard for this one submission.
> Additionally, we regularily receive submissions like that and we often
> handle them like this.
> If I'm mistaken here, could you please point me to the policy saying
> otherwise?

Hi Sven,
Here's the link you're requesting:
https://community.kde.org/Frameworks/Policies#Frameworks_commits_are_reviewed

And the policy does apply because ktexteditor is not a different
project. It's a KDE Framework and as such it's under it's quality
measures.

Nevertheless, you reviewed it, so it's fine.

Aleix
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: gcode.xml got into KF5::KTextEditor without review

[Sven Brauch]

Hey Alexander,

Thanks for caring and sorry for breaking the string freeze; I missed
that. I reverted the commit and I will resubmit it after the 5.8 release
is out.

On 05/03/16 01:01, Alexander Potashev wrote:
> [2] is clearly a feature, but it was not submitted to reviewboard
> before pushing to ktexteditor.git:master.
I thought it was up to the individual projects how to handle that. New
syntax highlighting files are really not critical changes at all, and I
consider the reviewing and fixing that happened on kwrite-devel for this
patch sufficient. It did not seem necessary to make a new and probably
one-time contributor go through reviewboard for this one submission.
Additionally, we regularily receive submissions like that and we often
handle them like this.
If I'm mistaken here, could you please point me to the policy saying
otherwise?

Best,
Sven




signature.asc
Description: OpenPGP digital signature
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

[Chusslove Illich]

> On Март 4, 2016, 4:01 по п., Chusslove Illich wrote:
> > src/klocalizedstring.cpp, line 368
> > 
> >
> > I would nevertheless ifdef it. It may be that some strange thing is 
> > intentionally done with locale variables (e.g. to test something or kill 
> > localization), and then the behavior would deviate from that documented for 
> > Gettext.
> 
> Andre Heinecke wrote:
> I'm assuming that QLocale::system() is also changed accodingly in that 
> case so I don't think its a problem. The code looks like it's using the same 
> environment variables: 
> http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale_unix.cpp#n104
> We still have to look at the environment variables in ki18n first because 
> of modifier / charset handling, imo otherwise we could just use QLocale here.
> 
> For ifdef I would probably do an #infdef O_OS_UNIX instead of a Q_OS_WIN 
> ? I'm not sure but I think this probably also makes sense on other platforms 
> like android?

Regardless of modifier/charset handling, we cannot use QLocale, because in 
QLocale that is an implementation detail (Qt does not use Gettext), and in 
ki18n that is a behavioral guarantee (conforming to Gettext).

I'm also not sure what kind of ifdef would be the best, although #infdef 
O_OS_UNIX does sound better than #ifdef Q_OS_WIN to me as well.


- Chusslove


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/#review93158
---


On Март 4, 2016, 3:53 по п., Andre Heinecke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127275/
> ---
> 
> (Updated Март 4, 2016, 3:53 по п.)
> 
> 
> Review request for KDE Frameworks and Localization and Translation (l10n).
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> The intention for this patch is to fix the inital Language selection for 
> Windows where the environment variables used in Ki18n are not set.
> This is not a fix for a regression in Ki18n, afaik this never worked on 
> Windows, we had some hacks in Gpg4win to write the language into kdeglobals 
> during installation in kde4 times.
> 
> I don't think this needs to be ifdefed because it only appends so previous 
> language selection is not affected.
> 
> 
> Diffs
> -
> 
>   src/klocalizedstring.cpp b24fe9b 
> 
> Diff: https://git.reviewboard.kde.org/r/127275/diff/
> 
> 
> Testing
> ---
> 
> Tested on a german Windows system and got a "de" localized application.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

[David Faure]

> On March 5, 2016, 9:27 a.m., David Faure wrote:
> > Looks good and more portable than the
> > qunsetenv("SESSION_MANAGER");
> > which is used in many other places...
> > 
> > Not sure both connects are necessary though?
> 
> Xuetian Weng wrote:
> This is not to disable the whole session manager thing, but just disable 
> the restore. So session manager is still able to terminate kwalletd.
> 
> David Faure wrote:
> Ah. Do you mean that with this code, the process is terminated more 
> gracefully than with the qunsetenv solution which e.g. kiod or kded use (I 
> guess they simply die with an X error when Xorg disappears). Sounds like 
> another reason for this approach indeed, although it probably doesn't make 
> much difference from a user's perspective [other than portability of course].
> 
> Sounds like we should apply the same code in all these:
> 
> kded/src/kded.cpp:682:qunsetenv("SESSION_MANAGER");
> kdesu/src/ptyprocess.cpp:305:unsetenv("SESSION_MANAGER");
> kglobalaccel/src/runtime/main.cpp:56:qunsetenv( "SESSION_MANAGER" );
> kinit/src/klauncher/klauncher_main.cpp:153:
> qunsetenv("SESSION_MANAGER");
> kio/src/kiod/kiod_main.cpp:89:qunsetenv("SESSION_MANAGER"); 
> 
> This also makes me wonder what happens to non-GUI daemons, i.e. what will 
> terminate them when logging out... (all of the above are GUI enabled, but 
> e.g. kio_http_cache_cleaner is core-only).
> 
> Xuetian Weng wrote:
> Well, I doubt this method is useful for cases above. kiod/kded might not 
> want to be exit by session manager maybe? Because when session terminates, it 
> is still possible for application like kwrite/kate to use kio to write or 
> open something.
> 
> I think most of them (at least for klauncher/kded/kiod) are currently 
> doing the right thing.
> 
> kio_http_cache_cleaner should be managed by kio so I don't think we need 
> to worry about it. core-only application could possible leave some garbage 
> behind, for example: https://git.reviewboard.kde.org/r/125746/

Ah, but then it's the same for kwalletd if kwrite uses KIO to save to an 
FTP directory, this might require a password, which would then require 
kwalletd. I see no difference between kwalletd and kiod/kded in that respect.

But I don't even think that's a problem. Closing the session happens in several 
steps (asking all apps to save state, then asking all apps to prompt the user 
for saving open files, and only then closing all windows and quitting the 
apps). So I don't think klauncher/kded/kiod/kwalletd being asked to quit by the 
session manager would break anything, that's only the very last step after all 
the saving is done.

kio_http_cache_cleaner is started by the first kio_http-using apps, but 
quitting it is difficult: it's a "singleton" process, so kio_http can't just 
make it quit on exit. It would need refcounting [difficult in case kio_http 
crashes]  or indeed it could be QGuiApplication (not good for possible 
core-only kio usage). Tricky.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
---


On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> ---
> 
> (Updated March 3, 2016, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I notice a kwalletd5 with "-session ." in its command line started on my 
> desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let 
> session manager to restore it.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> ---
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

[Jean-Baptiste Mardelle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/
---

(Updated March 5, 2016, 8:25 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Bugs: 352882
https://bugs.kde.org/show_bug.cgi?id=352882


Repository: kxmlgui


Description
---

To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
1 - Change the main toolbar setting. 
2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is emitted, 
allowing main app to re-plug its dynamic actions
3 - Click Ok, the ui is rebuild but the signal is not emitted, so app cannot 
re-plug actions, and they are lost.

The problem only happens if you click "apply" and then "ok". This is due to the 
fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers ui 
rebuild), but signal is not emitted.

My solution is to rebuild ui only if something changed when clicking "ok".


Diffs
-

  src/kedittoolbar.cpp b6842f6 
  src/kedittoolbar_p.h 73152ef 

Diff: https://git.reviewboard.kde.org/r/126184/diff/


Testing
---

Tested, fixes the reported problem.


Thanks,

Jean-Baptiste Mardelle

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/#review93208
---


Ship it!




Ship It!

- David Faure


On March 5, 2016, 8:01 p.m., Jean-Baptiste Mardelle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126184/
> ---
> 
> (Updated March 5, 2016, 8:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 352882
> https://bugs.kde.org/show_bug.cgi?id=352882
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
> 1 - Change the main toolbar setting. 
> 2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is 
> emitted, allowing main app to re-plug its dynamic actions
> 3 - Click Ok, the ui is rebuild but the signal is not emitted, so app cannot 
> re-plug actions, and they are lost.
> 
> The problem only happens if you click "apply" and then "ok". This is due to 
> the fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers 
> ui rebuild), but signal is not emitted.
> 
> My solution is to rebuild ui only if something changed when clicking "ok".
> 
> 
> Diffs
> -
> 
>   src/kedittoolbar.cpp b6842f6 
>   src/kedittoolbar_p.h 73152ef 
> 
> Diff: https://git.reviewboard.kde.org/r/126184/diff/
> 
> 
> Testing
> ---
> 
> Tested, fixes the reported problem.
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

[Xuetian Weng]

> On March 5, 2016, 9:27 a.m., David Faure wrote:
> > Looks good and more portable than the
> > qunsetenv("SESSION_MANAGER");
> > which is used in many other places...
> > 
> > Not sure both connects are necessary though?
> 
> Xuetian Weng wrote:
> This is not to disable the whole session manager thing, but just disable 
> the restore. So session manager is still able to terminate kwalletd.
> 
> David Faure wrote:
> Ah. Do you mean that with this code, the process is terminated more 
> gracefully than with the qunsetenv solution which e.g. kiod or kded use (I 
> guess they simply die with an X error when Xorg disappears). Sounds like 
> another reason for this approach indeed, although it probably doesn't make 
> much difference from a user's perspective [other than portability of course].
> 
> Sounds like we should apply the same code in all these:
> 
> kded/src/kded.cpp:682:qunsetenv("SESSION_MANAGER");
> kdesu/src/ptyprocess.cpp:305:unsetenv("SESSION_MANAGER");
> kglobalaccel/src/runtime/main.cpp:56:qunsetenv( "SESSION_MANAGER" );
> kinit/src/klauncher/klauncher_main.cpp:153:
> qunsetenv("SESSION_MANAGER");
> kio/src/kiod/kiod_main.cpp:89:qunsetenv("SESSION_MANAGER"); 
> 
> This also makes me wonder what happens to non-GUI daemons, i.e. what will 
> terminate them when logging out... (all of the above are GUI enabled, but 
> e.g. kio_http_cache_cleaner is core-only).

Well, I doubt this method is useful for cases above. kiod/kded might not want 
to be exit by session manager maybe? Because when session terminates, it is 
still possible for application like kwrite/kate to use kio to write or open 
something.

I think most of them (at least for klauncher/kded/kiod) are currently doing the 
right thing.

kio_http_cache_cleaner should be managed by kio so I don't think we need to 
worry about it. core-only application could possible leave some garbage behind, 
for example: https://git.reviewboard.kde.org/r/125746/


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
---


On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> ---
> 
> (Updated March 3, 2016, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I notice a kwalletd5 with "-session ." in its command line started on my 
> desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let 
> session manager to restore it.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> ---
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 192 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/192/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 05 Mar 2016 19:09:29 +
Build duration: 4.6 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 197 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/197/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 05 Mar 2016 19:09:29 +
Build duration: 2 min 38 sec

CHANGE SET
Revision d472daac5b5580ead6533610b34da95c6ade6415 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.20.0 release.)
  change: edit CMakeLists.txt
Revision c805f75f893300c7bd0e52159bd4aaedd0e8d37a by mail: (Revert "Add 
syntax highlighting for gcode")
  change: delete src/syntax/data/gcode.xml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

[Jean-Baptiste Mardelle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/
---

(Updated March 5, 2016, 8:01 p.m.)


Review request for KDE Frameworks and David Faure.


Bugs: 352882
https://bugs.kde.org/show_bug.cgi?id=352882


Repository: kxmlgui


Description
---

To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
1 - Change the main toolbar setting. 
2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is emitted, 
allowing main app to re-plug its dynamic actions
3 - Click Ok, the ui is rebuild but the signal is not emitted, so app cannot 
re-plug actions, and they are lost.

The problem only happens if you click "apply" and then "ok". This is due to the 
fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers ui 
rebuild), but signal is not emitted.

My solution is to rebuild ui only if something changed when clicking "ok".


Diffs (updated)
-

  src/kedittoolbar.cpp b6842f6 
  src/kedittoolbar_p.h 73152ef 

Diff: https://git.reviewboard.kde.org/r/126184/diff/


Testing
---

Tested, fixes the reported problem.


Thanks,

Jean-Baptiste Mardelle

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

[David Faure]

> On March 5, 2016, 9:27 a.m., David Faure wrote:
> > Looks good and more portable than the
> > qunsetenv("SESSION_MANAGER");
> > which is used in many other places...
> > 
> > Not sure both connects are necessary though?
> 
> Xuetian Weng wrote:
> This is not to disable the whole session manager thing, but just disable 
> the restore. So session manager is still able to terminate kwalletd.

Ah. Do you mean that with this code, the process is terminated more gracefully 
than with the qunsetenv solution which e.g. kiod or kded use (I guess they 
simply die with an X error when Xorg disappears). Sounds like another reason 
for this approach indeed, although it probably doesn't make much difference 
from a user's perspective [other than portability of course].

Sounds like we should apply the same code in all these:

kded/src/kded.cpp:682:qunsetenv("SESSION_MANAGER");
kdesu/src/ptyprocess.cpp:305:unsetenv("SESSION_MANAGER");
kglobalaccel/src/runtime/main.cpp:56:qunsetenv( "SESSION_MANAGER" );
kinit/src/klauncher/klauncher_main.cpp:153:qunsetenv("SESSION_MANAGER");
kio/src/kiod/kiod_main.cpp:89:qunsetenv("SESSION_MANAGER"); 

This also makes me wonder what happens to non-GUI daemons, i.e. what will 
terminate them when logging out... (all of the above are GUI enabled, but e.g. 
kio_http_cache_cleaner is core-only).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
---


On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> ---
> 
> (Updated March 3, 2016, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I notice a kwalletd5 with "-session ." in its command line started on my 
> desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let 
> session manager to restore it.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> ---
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

[Xuetian Weng]

> On March 5, 2016, 9:27 a.m., David Faure wrote:
> > Looks good and more portable than the
> > qunsetenv("SESSION_MANAGER");
> > which is used in many other places...
> > 
> > Not sure both connects are necessary though?

This is not to disable the whole session manager thing, but just disable the 
restore. So session manager is still able to terminate kwalletd.


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
---


On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> ---
> 
> (Updated March 3, 2016, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I notice a kwalletd5 with "-session ." in its command line started on my 
> desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let 
> session manager to restore it.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> ---
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127261: Fix dead lock when program use kauth exits.

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127261/
---

(Updated March 5, 2016, 6:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Edmundson.


Changes
---

Submitted with commit 702475557d5d2f6680f01169b4e33881be9b35b7 by David Faure 
on behalf of Xuetian Weng to branch master.


Repository: kauth


Description
---

I'm on Qt 5.6 RC, and just notice a issue that kded5 never cleanly exits.

With gdb attached to kded5, it shows following backtrace:

#1  0x75c820eb in QWaitConditionPrivate::wait 
(time=18446744073709551615, this=0x74ac70) at thread/qwaitcondition_unix.cpp:136
#2  QWaitCondition::wait (this=this@entry=0x71c308, 
mutex=mutex@entry=0x71c300, time=time@entry=18446744073709551615) at 
thread/qwaitcondition_unix.cpp:208
#3  0x75c7b08b in QSemaphore::acquire 
(this=this@entry=0x7fffd840, n=n@entry=1) at thread/qsemaphore.cpp:137
#4  0x75e80fff in QMetaObject::activate 
(sender=sender@entry=0x976280, signalOffset=, 
local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7fffd8d0)
at kernel/qobject.cpp:3698
#5  0x75e81687 in QMetaObject::activate 
(sender=sender@entry=0x976280, m=m@entry=0x76092760 
, local_signal_index=local_signal_index@entry=0, 
argv=argv@entry=0x7fffd8d0) at kernel/qobject.cpp:3595
#6  0x75e8172f in QObject::destroyed (this=this@entry=0x976280, 
_t1=_t1@entry=0x976280) at .moc/moc_qobject.cpp:213
#7  0x75e886e5 in QObject::~QObject (this=, 
__in_chrg=) at kernel/qobject.cpp:913
#8  0x7fffb39bbb09 in KAuth::DBusHelperProxy::~DBusHelperProxy 
(this=0x976280, __in_chrg=) at 
/chakra/core/kauth/src/kauth-5.19.0/src/backends/dbus/DBusHelperProxy.cpp:55
#9  0x75e49ff9 in QLibraryPrivate::unload (this=0x71dba0, 
flag=QLibraryPrivate::NoUnloadSys) at plugin/qlibrary.cpp:551
#10 0x75e4e521 in QLibraryStore::cleanup () at 
plugin/qlibrary.cpp:397
#11 0x778592ef in __cxa_finalize () from /usr/lib/libc.so.6
#12 0x75c52583 in __do_global_dtors_aux () from 
/usr/lib/libQt5Core.so.5
#13 0x7fffe230 in ?? ()
#14 0x77dea867 in _dl_fini () from /lib64/ld-linux-x86-64.so.2


Which indicates that kauth dbus plugin's QObject::destroyed is being connected 
to QDBusConnectionPrivate with Qt::BlockQueuedConnection. But at this point, 
QApplication is already gone and this call is never being handled. Disconnect 
everything in destructor can fix this issue.

Related upstream qt code:
https://github.com/qtproject/qtbase/blob/5.6.0/src/dbus/qdbusintegrator.cpp#L2135


Diffs
-

  src/backends/dbus/DBusHelperProxy.cpp 20dad0a 

Diff: https://git.reviewboard.kde.org/r/127261/diff/


Testing
---

Now kded5 can exits upon logout/exit. Tested with kquitapp5 kded5.


Thanks,

Xuetian Weng

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

[David Faure]

> On Feb. 27, 2016, 11:11 a.m., David Faure wrote:
> > It seems weird to have a setting for FTP on one side, and a setting for 
> > "SMB and SFTP and any slave where this is implemented in the future".
> > I understand that it was the path of least code changes, but I fear this 
> > creates an inconsistency which will lead to more bug reports down the line.
> > Either we should just have the global option, or it should be per protocol.
> > 
> > Can you tell me more about your use case for this option, so we can 
> > understand better the reason for all this?
> > 
> > In general I find that .part is good, it 1) tells me that the file isn't 
> > ready to be used yet, 2) enables the resuming feature in case the 
> > connection drops.
> > 
> > I can very well imagine that some servers disable renaming and then the 
> > feature breaks the upload in the first place. Is this is the issue here?
> > But then it's not even per-protocol, it's per-protocol-and-host which 
> > might lead to an overblown configuration dialog. But the alternative is for 
> > the user to turn off some global setting (like the one you just added) and 
> > then (forget to) turn it back on. Right? :-)
> 
> Martin Kostolný wrote:
> Sorry for my late response. I agree with every word you said, David. :-) 
> Thanks for taking your time to discuss this.
> 
> My use-case is indeed the (one specific) remote SMB server has problems 
> with renaming and it breaks the upload. So I'd like to offer an option to 
> disable this otherwise very useful ".part" functionality.
> 
> I agree that global-mark-partial-option is not a good idea but I think we 
> should come up with something. So here is my first proposal: I'm up for the 
> overblown configuration dialog which would be hidden behind "Avanced upload 
> options..." button placed in Connection Preferences. Here is one wireframe 
> (warning - very unfinished! I had little time...): 
> https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options 
> would be moved to mentioned configuration dialog as well (to their dedicated 
> tab).
> 
> As I'm looking to the configuration dialog it is really overblown. Second 
> proposal: maybe we could use an entirelly different approach like a runtime 
> option to temporarily but globally disable MarkPartial. Something similar to 
> "Enable Power Management" button available in expanded battery plasmoid.
> 
> Martin Kostolný wrote:
> One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to 
> be used (in KIO::file_copy(..) etc.) in various file managers. That way we 
> can delegate this settings to be picked up by file managers like krusader, 
> dolphin or other tools using KIO.

We can't delegate the setting to the app. All KIO-based apps use this, not just 
file managers. If you save a document in calligra onto an FTP server, kio_ftp 
is used, and needs to know whether to use MarkPartial.

Not sure if I prefer the global option switched on/off temporarily, or the 
precise per-host per-protocol setting. Maybe the VDG (visual design group) has 
an opinion and/or other ideas...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127154/#review92828
---


On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127154/
> ---
> 
> (Updated Feb. 24, 2016, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, David Faure, and Marco 
> Martin.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> We have an option called "Mark partially uploaded files" in System Settings 
> -> Network: Settings -> Connection Preferences -> FTP Options. This one 
> toggles adding ".part" extension to partially transferred files through FTP 
> protocol.
> 
> Other KIO slaves (such as SMB, SFTP) has already working code that supports 
> MarkPartial property read from kioslaverc. This patch is just exposing the 
> property from GUI, specifically I've created "Global Options" section (with 
> one checkbox) above existing "FTP Options" section.
> 
> Originally I've created a bug report for this: 
> https://bugs.kde.org/show_bug.cgi?id=359636
> 
> 
> Diffs
> -
> 
>   src/kcms/kio/kioslave.kcfg d34b691 
>   src/kcms/kio/netpref.h f7a0abc 
>   src/kcms/kio/netpref.cpp 24273a3 
> 
> Diff: https://git.reviewboard.kde.org/r/127154/diff/
> 
> 
> Testing
> ---
> 
> Tested toggling MarkPartial on SMB, SFTP slaves.
> 
> FISH slave was and still is ignoring it (no .part extension).
> 
> I didn't test NFS and others.
> 
> 
> Thanks,
> 
> Martin Kostolný
> 
>

___
Kde-frameworks-devel maili

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Thomas Lübking]

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote:
> > src/kstatusnotifieritem.cpp, line 934
> > 
> >
> > append
> > associatedWidget->setAttribute(Qt::WA_Moved);
> > 
> > 
> > 
> > This should tell Qt to demand an explicit position and skip placement 
> > by the WM (yes, this generally works in KWin ;-)
> > 
> > However, this flag should be implicitly set by ::move() unless the 
> > point is invalid, so you might want to "qDebug() << associatedWidgetPos;" 
> > to check whether it's invalid for the failing clients.
> 
> Anthony Fieroni wrote:
> Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is 
> called only when you click on tray icon i.e. if i close app with big red X 
> it's not called => i can't store position :)
> 
> Anthony Fieroni wrote:
> More fun facts :) 
> associatedWidget->setGeometry(associatedWidget->frameGeometry()); works in 
> any case ! I will add path if you want, but you will not be happy to set 
> geometry by myself :)
> 
> Anthony Fieroni wrote:
> ^ No, extend geometry with decoration size :)
> 
> Thomas Lübking wrote:
> meehhh...
> 
> That means one will have to filter QEvent::Close of associatedWidget and 
> store the position from there.
> 
> Anthony Fieroni wrote:
> It's strange, about me, associatedWidget has correct frameGeometry even 
> it's hide.
> QObject::connect(KWindowSystem::self(), &KWindowSystem::windowRemoved, q, 
> [this](WId winId) {
> if (associatedWidget && associatedWidget->winId() == winId) {
> associatedWidgetPos = 
> associatedWidget->frameGeometry().topLeft();
> }
> });
> Position is correct, but again not work event with Qt::WA_Moved.
> 
> Anthony Fieroni wrote:
> KWindowInfo info(associatedWidget->winId(), NET::WMDesktop | 
> NET::WMGeometry);
> info.geometry().topLeft(); <- decoration is 
> included again
> to filed bug?

You may file a bug, but I frankly doubt your findings.
(Just more or less ported my kwindowsystem tool and the values are correct ;-)

=> How exactly did you determine this assumption? (Just from the walking 
position?)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review93143
---


On Feb. 29, 2016, 5:18 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Feb. 29, 2016, 5:18 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin 
> Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 304 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/304/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 05 Mar 2016 10:06:51 +
Build duration: 2 min 30 sec

CHANGE SET
Revision fa1ca80281621002c3d8c948edc31e8b4b349b78 by nowrep: (Fix iconitem test)
  change: edit autotests/iconitemtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4392/10348 
(42%)CONDITIONAL 2281/3513 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 732/761 
(96%)CONDITIONAL 463/812 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 624/2059 
(30%)CONDITIONAL 278/410 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1662/3665 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 896/1752 
(51%)CONDITIONAL 372/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 478/1806 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 304 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/304/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 05 Mar 2016 10:06:51 +
Build duration: 2 min 59 sec

CHANGE SET
Revision fa1ca80281621002c3d8c948edc31e8b4b349b78 by nowrep: (Fix iconitem test)
  change: edit autotests/iconitemtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3960/9880 
(40%)CONDITIONAL 1995/3102 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 685/714 
(96%)CONDITIONAL 447/780 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 534/1836 
(29%)CONDITIONAL 192/286 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1660/3665 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 850/1678 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 231/1682 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 297 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/297/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 05 Mar 2016 10:06:51 +
Build duration: 2 min 37 sec

CHANGE SET
Revision fa1ca80281621002c3d8c948edc31e8b4b349b78 by nowrep: (Fix iconitem test)
  change: edit autotests/iconitemtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3950/9839 
(40%)CONDITIONAL 1995/3102 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 681/710 
(96%)CONDITIONAL 447/780 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 533/1835 
(29%)CONDITIONAL 192/286 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1657/3660 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 849/1671 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 230/1668 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127266: Fix build with MinGW on Windows

[Thomas Friedrichsmeier]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127266/
---

(Updated March 5, 2016, 10:47 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Changes
---

Submitted with commit 8f58ddf1cfb053147d6d12a3e13ea33b079072ef by Thomas 
Friedrichsmeier to branch master.


Repository: khtml


Description
---

Fix building with MinGW on Windows, by removing conflicting FOCUS_EVENT (also 
"OPTIONAL" and "CreateEvent") defines. Note that there already is a similar 
#undef in dom2_eventsimpl.h, but this is ineffective, if the Windows defines 
are added after dom2_eventsimpl.h was (first) included.

First, I tried solving this by shuffling around includes, but gave up on this 
path after quite some trial and error. (Main route of inclusion for windows.h 
seems to be khtml_part.h -> parts/browserextension.h -> Platform includes.)


Diffs
-

  src/ecma/kjs_dom.cpp e3fedad 
  src/ecma/kjs_html.cpp cc3c08a 
  src/html/html_baseimpl.cpp 539681c 
  src/html/html_elementimpl.cpp 7569192 
  src/html/htmlparser.cpp 064b99b 
  src/xml/dom_docimpl.cpp 4f0be5c 

Diff: https://git.reviewboard.kde.org/r/127266/diff/


Testing
---

Now builds with MinGW.


Thanks,

Thomas Friedrichsmeier

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 297 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/297/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 05 Mar 2016 10:06:51 +
Build duration: 3 min 11 sec

CHANGE SET
Revision fa1ca80281621002c3d8c948edc31e8b4b349b78 by nowrep: (Fix iconitem test)
  change: edit autotests/iconitemtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4386/10307 
(43%)CONDITIONAL 2283/3515 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 728/757 
(96%)CONDITIONAL 463/812 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 623/2058 
(30%)CONDITIONAL 278/410 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1659/3660 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 899/1745 
(52%)CONDITIONAL 374/557 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 477/1792 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 05 Mar 2016 09:55:05 +
Build duration: 6 min 11 sec

CHANGE SET
Revision 9b90b718518f0f6346a4523d371b54951d929014 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.20.0 release.)
  change: edit CMakeLists.txt
Revision 7ce16af2953df10cc191310b2f178967c7b52a93 by David Faure: (Fix KIO 
app-slave connection breaking if appName contains a '/'.)
  change: edit src/core/slavebase.cpp
  change: edit src/core/connectionbackend.cpp
  change: edit autotests/kiotesthelper.h
  change: edit autotests/jobtest.cpp
  change: edit src/core/slave.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
49 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26976/50881 
(53%)CONDITIONAL 14707/22825 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7446/7740 
(96%)CONDITIONAL 4056/7454 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7837/14146 
(55%)CONDITIONAL 4099/5688 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1840/3852 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
146/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10649 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 254 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/254/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 05 Mar 2016 09:55:05 +
Build duration: 6 min 11 sec

CHANGE SET
Revision 9b90b718518f0f6346a4523d371b54951d929014 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.20.0 release.)
  change: edit CMakeLists.txt
Revision 7ce16af2953df10cc191310b2f178967c7b52a93 by David Faure: (Fix KIO 
app-slave connection breaking if appName contains a '/'.)
  change: edit src/core/slavebase.cpp
  change: edit src/core/connectionbackend.cpp
  change: edit autotests/kiotesthelper.h
  change: edit autotests/jobtest.cpp
  change: edit src/core/slave.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
49 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26976/50881 
(53%)CONDITIONAL 14707/22825 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7446/7740 
(96%)CONDITIONAL 4056/7454 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7837/14146 
(55%)CONDITIONAL 4099/5688 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1840/3852 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
146/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10649 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/244/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 05 Mar 2016 09:55:05 +
Build duration: 5 min 39 sec

CHANGE SET
Revision 9b90b718518f0f6346a4523d371b54951d929014 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.20.0 release.)
  change: edit CMakeLists.txt
Revision 7ce16af2953df10cc191310b2f178967c7b52a93 by David Faure: (Fix KIO 
app-slave connection breaking if appName contains a '/'.)
  change: edit autotests/jobtest.cpp
  change: edit src/core/connectionbackend.cpp
  change: edit src/core/slave.cpp
  change: edit src/core/slavebase.cpp
  change: edit autotests/kiotesthelper.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
49 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26995/50883 
(53%)CONDITIONAL 14721/22845 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7448/7742 
(96%)CONDITIONAL 4057/7454 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7845/14146 
(55%)CONDITIONAL 4105/5694 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1849/3852 
(48%)CONDITIONAL 1324/1962 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10649 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 244 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/244/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 05 Mar 2016 09:55:05 +
Build duration: 5 min 39 sec

CHANGE SET
Revision 9b90b718518f0f6346a4523d371b54951d929014 by scripty: (Upgrade ECM and 
KF5 version requirements for 5.20.0 release.)
  change: edit CMakeLists.txt
Revision 7ce16af2953df10cc191310b2f178967c7b52a93 by David Faure: (Fix KIO 
app-slave connection breaking if appName contains a '/'.)
  change: edit autotests/jobtest.cpp
  change: edit src/core/connectionbackend.cpp
  change: edit src/core/slave.cpp
  change: edit src/core/slavebase.cpp
  change: edit autotests/kiotesthelper.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
49 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26995/50883 
(53%)CONDITIONAL 14721/22845 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7448/7742 
(96%)CONDITIONAL 4057/7454 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7845/14146 
(55%)CONDITIONAL 4105/5694 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1849/3852 
(48%)CONDITIONAL 1324/1962 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10649 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

[Martin Kostolný]

> On Feb. 27, 2016, 11:11 a.m., David Faure wrote:
> > It seems weird to have a setting for FTP on one side, and a setting for 
> > "SMB and SFTP and any slave where this is implemented in the future".
> > I understand that it was the path of least code changes, but I fear this 
> > creates an inconsistency which will lead to more bug reports down the line.
> > Either we should just have the global option, or it should be per protocol.
> > 
> > Can you tell me more about your use case for this option, so we can 
> > understand better the reason for all this?
> > 
> > In general I find that .part is good, it 1) tells me that the file isn't 
> > ready to be used yet, 2) enables the resuming feature in case the 
> > connection drops.
> > 
> > I can very well imagine that some servers disable renaming and then the 
> > feature breaks the upload in the first place. Is this is the issue here?
> > But then it's not even per-protocol, it's per-protocol-and-host which 
> > might lead to an overblown configuration dialog. But the alternative is for 
> > the user to turn off some global setting (like the one you just added) and 
> > then (forget to) turn it back on. Right? :-)
> 
> Martin Kostolný wrote:
> Sorry for my late response. I agree with every word you said, David. :-) 
> Thanks for taking your time to discuss this.
> 
> My use-case is indeed the (one specific) remote SMB server has problems 
> with renaming and it breaks the upload. So I'd like to offer an option to 
> disable this otherwise very useful ".part" functionality.
> 
> I agree that global-mark-partial-option is not a good idea but I think we 
> should come up with something. So here is my first proposal: I'm up for the 
> overblown configuration dialog which would be hidden behind "Avanced upload 
> options..." button placed in Connection Preferences. Here is one wireframe 
> (warning - very unfinished! I had little time...): 
> https://sojcaci.cz/temp/disable-mark-partial-mockup.png. Both FTP options 
> would be moved to mentioned configuration dialog as well (to their dedicated 
> tab).
> 
> As I'm looking to the configuration dialog it is really overblown. Second 
> proposal: maybe we could use an entirelly different approach like a runtime 
> option to temporarily but globally disable MarkPartial. Something similar to 
> "Enable Power Management" button available in expanded battery plasmoid.

One more proposal: Add "DisableMarkPartial" to JobFlag enum as a hint to be 
used (in KIO::file_copy(..) etc.) in various file managers. That way we can 
delegate this settings to be picked up by file managers like krusader, dolphin 
or other tools using KIO.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127154/#review92828
---


On Feb. 24, 2016, 11:52 p.m., Martin Kostolný wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127154/
> ---
> 
> (Updated Feb. 24, 2016, 11:52 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, David Faure, and Marco 
> Martin.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> We have an option called "Mark partially uploaded files" in System Settings 
> -> Network: Settings -> Connection Preferences -> FTP Options. This one 
> toggles adding ".part" extension to partially transferred files through FTP 
> protocol.
> 
> Other KIO slaves (such as SMB, SFTP) has already working code that supports 
> MarkPartial property read from kioslaverc. This patch is just exposing the 
> property from GUI, specifically I've created "Global Options" section (with 
> one checkbox) above existing "FTP Options" section.
> 
> Originally I've created a bug report for this: 
> https://bugs.kde.org/show_bug.cgi?id=359636
> 
> 
> Diffs
> -
> 
>   src/kcms/kio/kioslave.kcfg d34b691 
>   src/kcms/kio/netpref.h f7a0abc 
>   src/kcms/kio/netpref.cpp 24273a3 
> 
> Diff: https://git.reviewboard.kde.org/r/127154/diff/
> 
> 
> Testing
> ---
> 
> Tested toggling MarkPartial on SMB, SFTP slaves.
> 
> FISH slave was and still is ignoring it (no .part extension).
> 
> I didn't test NFS and others.
> 
> 
> Thanks,
> 
> Martin Kostolný
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126184: Editing toolbars in KXmlGuiWindow sometimes deletes all UI plugged actions

[David Faure]

> On Dec. 6, 2015, 2:58 p.m., David Faure wrote:
> > src/kedittoolbar.cpp, line 770
> > 
> >
> > this code path didn't call accept() before.
> > 
> > Please investigate when save can fail, or keep former behaviour (by 
> > adding "return;").

OK, save() always returns true, you could just clean up the test for the save() 
ret val and change that method to void. Thanks.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126184/#review89183
---


On Nov. 27, 2015, 1:40 p.m., Jean-Baptiste Mardelle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126184/
> ---
> 
> (Updated Nov. 27, 2015, 1:40 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 352882
> https://bugs.kde.org/show_bug.cgi?id=352882
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> To Reproduce: in a KXmlGuiWindow, open the Configure Toolbars dialog.
> 1 - Change the main toolbar setting. 
> 2 - Click Apply, the ui is rebuild, and the newToolBarConfig signal is 
> emitted, allowing main app to re-plug its dynamic actions
> 3 - Click Ok, the ui is rebuild but the signal is not emitted, so app cannot 
> re-plug actions, and they are lost.
> 
> The problem only happens if you click "apply" and then "ok". This is due to 
> the fact that when Ok is clicked, the ui is rebuild (m_widget->save triggers 
> ui rebuild), but signal is not emitted.
> 
> My solution is to rebuild ui only if something changed when clicking "ok".
> 
> 
> Diffs
> -
> 
>   src/kedittoolbar.cpp ba4ba0f 
> 
> Diff: https://git.reviewboard.kde.org/r/126184/diff/
> 
> 
> Testing
> ---
> 
> Tested, fixes the reported problem.
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127271: Disable session restore for kwalletd5

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127271/#review93187
---



Looks good and more portable than the
qunsetenv("SESSION_MANAGER");
which is used in many other places...

Not sure both connects are necessary though?

- David Faure


On March 3, 2016, 8:34 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127271/
> ---
> 
> (Updated March 3, 2016, 8:34 p.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I notice a kwalletd5 with "-session ." in its command line started on my 
> desktop and kwallet-pam doesn't work.
> 
> Also kwalletd is dbus activated in other cases there's no point to let 
> session manager to restore it.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/main.cpp 740e670 
> 
> Diff: https://git.reviewboard.kde.org/r/127271/diff/
> 
> 
> Testing
> ---
> 
> kwallet-pam back to work.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kconfig question

[David Faure]

On Thursday 28 January 2016 10:06:29 Ralf Habacker wrote:
> 
> In a similar patch I wrote recently for testing
> https://build.opensuse.org/package/view_file/home:rhabacker:branches:windows:mingw:win32:Qt55/mingw32-libqt5-qtbase/0001-Add-QStandardPaths-support-for-qt.conf.patch?expand=1
> I used  QLibraryInfo::location(PrefixPath) as base.

Interesting. Are you going to submit this to Qt gerrit ?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127166/#review93186
---



Looks good to me, but I'd rather let Martin have another look.

- David Faure


On March 4, 2016, 10:51 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127166/
> ---
> 
> (Updated March 4, 2016, 10:51 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Martin Gräßlin.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> The ported klauncher at least has two bugs:
> 1. IMHO, it should compare the cached display string with == instead of != 
> (though != has been there since the old kdelibs, but it just doesn't look 
> correct to me, what's the point of assign dpy = mCached_dpy when dpy_str != 
> XDisplayString(dpy)? And what's the point use == in one place and != in other 
> two places? ).
> 2. it might free the cached connection without setting mCached.conn back to 
> nullptr, which could lead to double free or freeze when system logout.
> 
> This patch refactor the code a little bit with a helper function to update 
> the cached connection instead of duplicate the same logic everywhere. 
> getXCBConnection() will make sure the returned connection is error-free, 
> reuse the cached connection if possible, and update the cached connection if 
> needed.
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.h 31bfaaa 
>   src/klauncher/klauncher.cpp 7ea9da9 
> 
> Diff: https://git.reviewboard.kde.org/r/127166/diff/
> 
> 
> Testing
> ---
> 
> Compiles, startup notify works.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127266: Fix build with MinGW on Windows

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127266/#review93185
---


Ship it!




(Another approach would have been to rename the stuff in the code, it's not 
like it's public API.)

- David Faure


On March 3, 2016, 2:37 p.m., Thomas Friedrichsmeier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127266/
> ---
> 
> (Updated March 3, 2016, 2:37 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: khtml
> 
> 
> Description
> ---
> 
> Fix building with MinGW on Windows, by removing conflicting FOCUS_EVENT (also 
> "OPTIONAL" and "CreateEvent") defines. Note that there already is a similar 
> #undef in dom2_eventsimpl.h, but this is ineffective, if the Windows defines 
> are added after dom2_eventsimpl.h was (first) included.
> 
> First, I tried solving this by shuffling around includes, but gave up on this 
> path after quite some trial and error. (Main route of inclusion for windows.h 
> seems to be khtml_part.h -> parts/browserextension.h -> Platform includes.)
> 
> 
> Diffs
> -
> 
>   src/ecma/kjs_dom.cpp e3fedad 
>   src/ecma/kjs_html.cpp cc3c08a 
>   src/html/html_baseimpl.cpp 539681c 
>   src/html/html_elementimpl.cpp 7569192 
>   src/html/htmlparser.cpp 064b99b 
>   src/xml/dom_docimpl.cpp 4f0be5c 
> 
> Diff: https://git.reviewboard.kde.org/r/127266/diff/
> 
> 
> Testing
> ---
> 
> Now builds with MinGW.
> 
> 
> Thanks,
> 
> Thomas Friedrichsmeier
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127261: Fix dead lock when program use kauth exits.

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127261/#review93184
---


Fix it, then Ship it!




Please push asap, I'm releasing today.


src/backends/dbus/DBusHelperProxy.cpp (line 55)


add a comment here, point to the Qt bug report, maybe even put this in a 
QT_VERSION ifdef, all so that this workaround doesn't get forgotten, and gets 
cleaned up instead.


- David Faure


On March 2, 2016, 8:58 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127261/
> ---
> 
> (Updated March 2, 2016, 8:58 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> I'm on Qt 5.6 RC, and just notice a issue that kded5 never cleanly exits.
> 
> With gdb attached to kded5, it shows following backtrace:
> 
> #1  0x75c820eb in QWaitConditionPrivate::wait 
> (time=18446744073709551615, this=0x74ac70) at 
> thread/qwaitcondition_unix.cpp:136
> #2  QWaitCondition::wait (this=this@entry=0x71c308, 
> mutex=mutex@entry=0x71c300, time=time@entry=18446744073709551615) at 
> thread/qwaitcondition_unix.cpp:208
> #3  0x75c7b08b in QSemaphore::acquire 
> (this=this@entry=0x7fffd840, n=n@entry=1) at thread/qsemaphore.cpp:137
> #4  0x75e80fff in QMetaObject::activate 
> (sender=sender@entry=0x976280, signalOffset=, 
> local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7fffd8d0)
> at kernel/qobject.cpp:3698
> #5  0x75e81687 in QMetaObject::activate 
> (sender=sender@entry=0x976280, m=m@entry=0x76092760 
> , local_signal_index=local_signal_index@entry=0, 
> argv=argv@entry=0x7fffd8d0) at kernel/qobject.cpp:3595
> #6  0x75e8172f in QObject::destroyed (this=this@entry=0x976280, 
> _t1=_t1@entry=0x976280) at .moc/moc_qobject.cpp:213
> #7  0x75e886e5 in QObject::~QObject (this=, 
> __in_chrg=) at kernel/qobject.cpp:913
> #8  0x7fffb39bbb09 in KAuth::DBusHelperProxy::~DBusHelperProxy 
> (this=0x976280, __in_chrg=) at 
> /chakra/core/kauth/src/kauth-5.19.0/src/backends/dbus/DBusHelperProxy.cpp:55
> #9  0x75e49ff9 in QLibraryPrivate::unload (this=0x71dba0, 
> flag=QLibraryPrivate::NoUnloadSys) at plugin/qlibrary.cpp:551
> #10 0x75e4e521 in QLibraryStore::cleanup () at 
> plugin/qlibrary.cpp:397
> #11 0x778592ef in __cxa_finalize () from /usr/lib/libc.so.6
> #12 0x75c52583 in __do_global_dtors_aux () from 
> /usr/lib/libQt5Core.so.5
> #13 0x7fffe230 in ?? ()
> #14 0x77dea867 in _dl_fini () from /lib64/ld-linux-x86-64.so.2
> 
> 
> Which indicates that kauth dbus plugin's QObject::destroyed is being 
> connected to QDBusConnectionPrivate with Qt::BlockQueuedConnection. But at 
> this point, QApplication is already gone and this call is never being 
> handled. Disconnect everything in destructor can fix this issue.
> 
> Related upstream qt code:
> https://github.com/qtproject/qtbase/blob/5.6.0/src/dbus/qdbusintegrator.cpp#L2135
> 
> 
> Diffs
> -
> 
>   src/backends/dbus/DBusHelperProxy.cpp 20dad0a 
> 
> Diff: https://git.reviewboard.kde.org/r/127261/diff/
> 
> 
> Testing
> ---
> 
> Now kded5 can exits upon logout/exit. Tested with kquitapp5 kded5.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127251: [KUnitConversion] Fix downloading currency exchange rates

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127251/#review93183
---



I guess you couldn't trigger the mentionned crashes because I made KIO 
threadsafe meanwhile.

As to why this worked, well, it was a busy loop I guess, polling for 
bytesAvailable (and not waiting in waitForReadyRead)


src/currency.cpp (line 675)


Pass the flag ExcludeUserInputEvents to avoid unexpected reentrancy when 
e.g. the user closes a window.

A socket or a timer firing during the event loop can still create issues 
though, but there's no solution, other than moving all this to a separate 
thread.

It's not the first job->exec() call in our code (which this is equivalent 
to) so I won't insist on that.


- David Faure


On March 2, 2016, 12:48 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127251/
> ---
> 
> (Updated March 2, 2016, 12:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Vishesh Handa.
> 
> 
> Bugs: 345750
> https://bugs.kde.org/show_bug.cgi?id=345750
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> QNetworkReply does not implement waitForReadyRead
> 
> Also, the code never actually created the cache dir it was trying to create a 
> file in.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
> 
> Diff: https://git.reviewboard.kde.org/r/127251/diff/
> 
> 
> Testing
> ---
> 
> Works now. It's downloaded once and then taken from cache file in 
> ~/.local/share/libkunitconversion/currency.xml
> 
> Given it's a Tier 2 framework doesn't make sense to add KIO now, also failed 
> to reproduce the crashes mentioned in the code.
> 
> Tests pass (only if I run them on English locale btw)
> 
> Obviously not happy with this being sync but alas that's how the API works.
> 
> Not sure if this is a KRunner bug or KUnitConverison but if I enter "5 USD" 
> it converts fine, if I enter "5 usd" it returns zero for all the currencies 
> it converted to.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Anthony Fieroni]

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote:
> > src/kstatusnotifieritem.cpp, line 934
> > 
> >
> > append
> > associatedWidget->setAttribute(Qt::WA_Moved);
> > 
> > 
> > 
> > This should tell Qt to demand an explicit position and skip placement 
> > by the WM (yes, this generally works in KWin ;-)
> > 
> > However, this flag should be implicitly set by ::move() unless the 
> > point is invalid, so you might want to "qDebug() << associatedWidgetPos;" 
> > to check whether it's invalid for the failing clients.
> 
> Anthony Fieroni wrote:
> Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is 
> called only when you click on tray icon i.e. if i close app with big red X 
> it's not called => i can't store position :)
> 
> Anthony Fieroni wrote:
> More fun facts :) 
> associatedWidget->setGeometry(associatedWidget->frameGeometry()); works in 
> any case ! I will add path if you want, but you will not be happy to set 
> geometry by myself :)
> 
> Anthony Fieroni wrote:
> ^ No, extend geometry with decoration size :)
> 
> Thomas Lübking wrote:
> meehhh...
> 
> That means one will have to filter QEvent::Close of associatedWidget and 
> store the position from there.
> 
> Anthony Fieroni wrote:
> It's strange, about me, associatedWidget has correct frameGeometry even 
> it's hide.
> QObject::connect(KWindowSystem::self(), &KWindowSystem::windowRemoved, q, 
> [this](WId winId) {
> if (associatedWidget && associatedWidget->winId() == winId) {
> associatedWidgetPos = 
> associatedWidget->frameGeometry().topLeft();
> }
> });
> Position is correct, but again not work event with Qt::WA_Moved.

KWindowInfo info(associatedWidget->winId(), NET::WMDesktop | NET::WMGeometry);
info.geometry().topLeft(); <- decoration is 
included again
to filed bug?


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review93143
---


On Фев. 29, 2016, 7:18 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Фев. 29, 2016, 7:18 преди обяд)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin 
> Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel