Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 242 - Fixed!

2016-11-08 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/242/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 08 Nov 2016 09:54:31 +
Build duration: 3 min 18 sec

CHANGE SET
Revision f37cc1361481a2d6ce530e87c68706d81c326b98 by Marco Martin: (Fix SVG 
icon ID prefix)
  change: edit src/desktoptheme/breeze/icons/nepomuk.svgz
  change: edit src/desktoptheme/breeze/icons/document.svgz
  change: edit src/desktoptheme/breeze/icons/edit.svgz
  change: edit src/desktoptheme/breeze/icons/phone.svgz
  change: edit src/desktoptheme/breeze/icons/configure.svgz
  change: edit src/desktoptheme/breeze/icons/apport.svgz
  change: edit src/desktoptheme/breeze/icons/media.svgz
  change: edit src/desktoptheme/breeze/icons/akregator.svgz
  change: edit src/desktoptheme/breeze/icons/drive.svgz
  change: edit src/desktoptheme/breeze/icons/cantata.svgz
  change: edit src/desktoptheme/breeze/icons/touchpad.svgz
  change: edit src/desktoptheme/breeze/icons/amarok.svgz
  change: edit src/desktoptheme/breeze/icons/akonadi.svgz
  change: edit src/desktoptheme/breeze/icons/kalarm.svgz
  change: edit src/desktoptheme/breeze/icons/konv_message.svgz


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4486/11230 
(40%)CONDITIONAL 2356/8462 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3608 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 868/1567 
(55%)CONDITIONAL 405/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 335/1702 
(20%)CONDITIONAL 157/1293 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 242 - Fixed!

2016-11-08 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/242/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 08 Nov 2016 09:54:31 +
Build duration: 3 min 18 sec

CHANGE SET
Revision f37cc1361481a2d6ce530e87c68706d81c326b98 by Marco Martin: (Fix SVG 
icon ID prefix)
  change: edit src/desktoptheme/breeze/icons/nepomuk.svgz
  change: edit src/desktoptheme/breeze/icons/document.svgz
  change: edit src/desktoptheme/breeze/icons/edit.svgz
  change: edit src/desktoptheme/breeze/icons/phone.svgz
  change: edit src/desktoptheme/breeze/icons/configure.svgz
  change: edit src/desktoptheme/breeze/icons/apport.svgz
  change: edit src/desktoptheme/breeze/icons/media.svgz
  change: edit src/desktoptheme/breeze/icons/akregator.svgz
  change: edit src/desktoptheme/breeze/icons/drive.svgz
  change: edit src/desktoptheme/breeze/icons/cantata.svgz
  change: edit src/desktoptheme/breeze/icons/touchpad.svgz
  change: edit src/desktoptheme/breeze/icons/amarok.svgz
  change: edit src/desktoptheme/breeze/icons/akonadi.svgz
  change: edit src/desktoptheme/breeze/icons/kalarm.svgz
  change: edit src/desktoptheme/breeze/icons/konv_message.svgz


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4486/11230 
(40%)CONDITIONAL 2356/8462 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3608 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 868/1567 
(55%)CONDITIONAL 405/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 335/1702 
(20%)CONDITIONAL 157/1293 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100710
---



On my system (ubuntu 16.04 base) this is achieved by 
${KDE_INSTALL_FULL_LIBDIR}/utempter
What's changed in 16.10 that alters this?

- Jonathan Riddell


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread Romário Rios 


> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 
> > should now be @since 5.29 (which is good because the translators have one 
> > month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove 
> > it, maybe in a commit that you would rebase this one upon, or I can do it 
> > after you push. So at a minimum, replace MTime with "modification time", 
> > fix @since, then push.
> > 
> > Thanks!

No problem.

By the way, how should I apply these changes to git? Should I make one big 
commit or merge my local branch into master?


- Romário


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

[Differential] [Accepted] D3299: Let KPackage know about X-Plasma-RootPath

2016-11-08 Thread mart (Marco Martin) 
mart accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3299

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, lbeltrame, mart

Review Request 129362: [KWindowInfo] Add pid()

2016-11-08 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/
---

Review request for KDE Frameworks and Martin Gräßlin.


Repository: kwindowsystem


Description
---

Allows to retrieve the process ID of the window's application if present.


Diffs
-

  src/kwindowinfo.h e3dea61 
  src/kwindowinfo.cpp e40e397 
  src/kwindowinfo_dummy_p.h 933140d 
  src/kwindowinfo_p.h 7a4ede5 
  src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
  src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 

Diff: https://git.reviewboard.kde.org/r/129362/diff/


Testing
---


Thanks,

Kai Uwe Broulik

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100712
---




cmake/FindUTEMPTER.cmake (line 43)


I think we shouldn't search in fixed path i.e. /usr/...
${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter
So "patch" like above one is error prone


- Anthony Fieroni


On Nov. 8, 2016, 1:02 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 8, 2016, 1:02 a.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Albert Astals Cid 


> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote:
> > On my system (ubuntu 16.04 base) this is achieved by 
> > ${KDE_INSTALL_FULL_LIBDIR}/utempter
> > What's changed in 16.10 that alters this?

That only works under the bogus assumption that one will install KDE (what does 
"installing KDE" mean in a frameworks world anyway) to the same place you have 
installed utempter, which is clearly not the case for me ( i.e. 
${KDE_INSTALL_FULL_LIBDIR} is 
/home/tsdgeos/kde_stuff/instalado/lib/x86_64-linux-gnu )


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100710
---


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Albert Astals Cid 


> On Nov. 8, 2016, 11:57 a.m., Anthony Fieroni wrote:
> > cmake/FindUTEMPTER.cmake, line 43
> > 
> >
> > I think we shouldn't search in fixed path i.e. /usr/...
> > ${CMAKE_PREFIX_PATH}/lib/${CMAKE_LIBRARY_ARCHITECTURE}/utempter
> > So "patch" like above one is error prone

So how do you suggest we fix the fact that the utempter library is not found 
for me?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100712
---


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Jonathan Riddell 


> On Nov. 8, 2016, 11:33 a.m., Jonathan Riddell wrote:
> > On my system (ubuntu 16.04 base) this is achieved by 
> > ${KDE_INSTALL_FULL_LIBDIR}/utempter
> > What's changed in 16.10 that alters this?
> 
> Albert Astals Cid wrote:
> That only works under the bogus assumption that one will install KDE 
> (what does "installing KDE" mean in a frameworks world anyway) to the same 
> place you have installed utempter, which is clearly not the case for me ( 
> i.e. ${KDE_INSTALL_FULL_LIBDIR} is 
> /home/tsdgeos/kde_stuff/instalado/lib/x86_64-linux-gnu )

true enough


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100710
---


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Jonathan Riddell 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100717
---


Ship it!




Ship It!

- Jonathan Riddell


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread David Faure 


> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 
> > should now be @since 5.29 (which is good because the translators have one 
> > month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove 
> > it, maybe in a commit that you would rebase this one upon, or I can do it 
> > after you push. So at a minimum, replace MTime with "modification time", 
> > fix @since, then push.
> > 
> > Thanks!
> 
> Romário Rios wrote:
> No problem.
> 
> By the way, how should I apply these changes to git? Should I make one 
> big commit or merge my local branch into master?

If I was able to review it as a single commit, I'd say it should be pushed as a 
single commit :-)

The removal of ATime and CTime should be a separate commit (ideally before the 
big one).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread Romário Rios 


> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 
> > should now be @since 5.29 (which is good because the translators have one 
> > month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove 
> > it, maybe in a commit that you would rebase this one upon, or I can do it 
> > after you push. So at a minimum, replace MTime with "modification time", 
> > fix @since, then push.
> > 
> > Thanks!
> 
> Romário Rios wrote:
> No problem.
> 
> By the way, how should I apply these changes to git? Should I make one 
> big commit or merge my local branch into master?
> 
> David Faure wrote:
> If I was able to review it as a single commit, I'd say it should be 
> pushed as a single commit :-)
> 
> The removal of ATime and CTime should be a separate commit (ideally 
> before the big one).

Makes sense :)

Do I have to wait for 5.28 final before pushing?


- Romário


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread David Faure 


> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 
> > should now be @since 5.29 (which is good because the translators have one 
> > month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove 
> > it, maybe in a commit that you would rebase this one upon, or I can do it 
> > after you push. So at a minimum, replace MTime with "modification time", 
> > fix @since, then push.
> > 
> > Thanks!
> 
> Romário Rios wrote:
> No problem.
> 
> By the way, how should I apply these changes to git? Should I make one 
> big commit or merge my local branch into master?
> 
> David Faure wrote:
> If I was able to review it as a single commit, I'd say it should be 
> pushed as a single commit :-)
> 
> The removal of ATime and CTime should be a separate commit (ideally 
> before the big one).
> 
> Romário Rios wrote:
> Makes sense :)
> 
> Do I have to wait for 5.28 final before pushing?

No, you can push now. The release process uses temporary branches so that 
development never has to stop ;)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread Romário Rios 


> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 
> > should now be @since 5.29 (which is good because the translators have one 
> > month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove 
> > it, maybe in a commit that you would rebase this one upon, or I can do it 
> > after you push. So at a minimum, replace MTime with "modification time", 
> > fix @since, then push.
> > 
> > Thanks!
> 
> Romário Rios wrote:
> No problem.
> 
> By the way, how should I apply these changes to git? Should I make one 
> big commit or merge my local branch into master?
> 
> David Faure wrote:
> If I was able to review it as a single commit, I'd say it should be 
> pushed as a single commit :-)
> 
> The removal of ATime and CTime should be a separate commit (ideally 
> before the big one).
> 
> Romário Rios wrote:
> Makes sense :)
> 
> Do I have to wait for 5.28 final before pushing?
> 
> David Faure wrote:
> No, you can push now. The release process uses temporary branches so that 
> development never has to stop ;)

About Friederich's request to add the scripts in order to enable translations, 
I can do that in another commit, right?


- Romário


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread David Faure 


> On Nov. 6, 2016, 9:49 a.m., David Faure wrote:
> > Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 
> > should now be @since 5.29 (which is good because the translators have one 
> > month to translate all these new strings).
> > 
> > Neither ATime nor CTime is actually used in this code, feel free to remove 
> > it, maybe in a commit that you would rebase this one upon, or I can do it 
> > after you push. So at a minimum, replace MTime with "modification time", 
> > fix @since, then push.
> > 
> > Thanks!
> 
> Romário Rios wrote:
> No problem.
> 
> By the way, how should I apply these changes to git? Should I make one 
> big commit or merge my local branch into master?
> 
> David Faure wrote:
> If I was able to review it as a single commit, I'd say it should be 
> pushed as a single commit :-)
> 
> The removal of ATime and CTime should be a separate commit (ideally 
> before the big one).
> 
> Romário Rios wrote:
> Makes sense :)
> 
> Do I have to wait for 5.28 final before pushing?
> 
> David Faure wrote:
> No, you can push now. The release process uses temporary branches so that 
> development never has to stop ;)
> 
> Romário Rios wrote:
> About Friederich's request to add the scripts in order to enable 
> translations, I can do that in another commit, right?

Yes, this way it can be reviewed by those who know more about that...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

2016-11-08 Thread Romário Rios 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/
---

(Updated Nov. 8, 2016, 1:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 34f00f0d1402351206a19e6967c29d4d4cc18ba2 by Luiz Romário 
Santana Rios to branch master.


Repository: karchive


Description
---

This method is similar to `QIODevice::errorString()`. I added a public 
`errorString()` method and a protected `setErrorString()` method, to allow 
`KArchive`'s subclasses to implement their own error messages. I also 
implemented most error messages from most subclasses.


Diffs
-

  autotests/karchivetest.cpp d0fbf41 
  src/k7zip.h 5b95f49 
  src/k7zip.cpp 692b1db 
  src/kar.h 85bd650 
  src/kar.cpp 7204fb1 
  src/karchive.h b528a4a 
  src/karchive.cpp a1a160a 
  src/karchive_p.h 256620d 
  src/krcc.h 18c7d00 
  src/krcc.cpp 1947dd6 
  src/ktar.h 4bca898 
  src/ktar.cpp f70b155 
  src/kzip.h 84156c7 
  src/kzip.cpp 94d4276 

Diff: https://git.reviewboard.kde.org/r/129170/diff/


Testing
---

I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps we'll 
need more tests, but I'm not sure how to make an archive to fail in some 
specific way aside from the very basics ("file not found", etc.).


Thanks,

Romário Rios

[Differential] [Updated] D3299: Let KPackage know about X-Plasma-RootPath

2016-11-08 Thread apol (Aleix Pol Gonzalez) 
apol added a dependent revision: D3311: Dependency resolution code was moved to 
KPackagDependency resolution code was moved to KPackagee.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3299

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, lbeltrame, mart

[Differential] [Closed] D3299: Let KPackage know about X-Plasma-RootPath

2016-11-08 Thread apol (Aleix Pol Gonzalez) 
apol closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D3299

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, lbeltrame, mart

Re: Review Request 129361: Add library path so utempter binary is found in Ubuntu 16.10

2016-11-08 Thread Allen Winter 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129361/#review100729
---



Doesn't help me on Fedora 24 though (yes, I know this is about Ubuntu)

On Fedora24 I have /usr/libexec/utempter/utempter except it isn't readable by 
the average user.

$ file /usr/libexec/utempter/utempter
/usr/libexec/utempter/utempter: setgid executable, regular file, no read 
permission


I think the non-privildged user should be able to build kpty.

- Allen Winter


On Nov. 7, 2016, 11:02 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129361/
> ---
> 
> (Updated Nov. 7, 2016, 11:02 p.m.)
> 
> 
> Review request for KDE Frameworks, Jonathan Riddell and Rex Dieter.
> 
> 
> Repository: kpty
> 
> 
> Description
> ---
> 
> Read the summary
> 
> 
> Diffs
> -
> 
>   cmake/FindUTEMPTER.cmake d3236c8 
> 
> Diff: https://git.reviewboard.kde.org/r/129361/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

2016-11-08 Thread Burkhard Lück 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/
---

(Updated Nov. 8, 2016, 5:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and KDE Frameworks.


Changes
---

Submitted with commit 6b9d09c107e90c667ef3884b7e00796292ad6539 by Burkhard Lück 
to branch master.


Repository: kdelibs4support


Description
---

in distributions the doc packages for kdelibs4support and kde-runtime are 
usually designed to be co-installable, 
but this fails in some distributions due to conflicting file paths, therefore:
 
* subdir kcontrol is renamed to kcontrol5
* install target for kcm_ssl docbook changed to kcontrol5
* X-DocPath changed to kcontrol5/kcm_ssl/index.html


Diffs
-

  docs/CMakeLists.txt f90fa81 
  docs/kcontrol/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/details.png  
  docs/kcontrol/kcm_ssl/index.docbook  
  docs/kcontrol/kcm_ssl/module.png  
  docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
  src/kssl/kcm/kcm_ssl.desktop 6ec8be6 

Diff: https://git.reviewboard.kde.org/r/129209/diff/


Testing
---

builds and installs properly


Thanks,

Burkhard Lück

Re: Review Request 129362: [KWindowInfo] Add pid()

2016-11-08 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129362/#review100731
---



You cannot add a virtual method. You need to do an extension dance as my last 
commit.

- Martin Gräßlin


On Nov. 8, 2016, 12:47 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129362/
> ---
> 
> (Updated Nov. 8, 2016, 12:47 nachm.)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> Allows to retrieve the process ID of the window's application if present.
> 
> 
> Diffs
> -
> 
>   src/kwindowinfo.h e3dea61 
>   src/kwindowinfo.cpp e40e397 
>   src/kwindowinfo_dummy_p.h 933140d 
>   src/kwindowinfo_p.h 7a4ede5 
>   src/platforms/xcb/kwindowinfo.cpp 3a3fee6 
>   src/platforms/xcb/kwindowinfo_p_x11.h aeb046a 
> 
> Diff: https://git.reviewboard.kde.org/r/129362/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

2016-11-08 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129327/#review100732
---



It's weird that it's called `desktopFileName` but it doesn't offer a file name? 
I think it should be renamed or fixed to provide the path. In the end it's an 
API that then requires the user to do a rather big look-up.

- Aleix Pol Gonzalez


On Nov. 7, 2016, 7:29 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129327/
> ---
> 
> (Updated Nov. 7, 2016, 7:29 a.m.)
> 
> 
> Review request for KDE Frameworks and Eike Hein.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> This change introduced a new method in KWindowInfo:
> QByteArray KWindowInfo::desktopFileName() const
> 
> It returns the desktop file name of the application if known on the
> given platform. So far only provided on X11 through
> NETWinInfo::desktopFileName.
> 
> 
> Diffs
> -
> 
>   autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab 
>   src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 
>   src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 
>   src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 
>   src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 
>   src/platforms/xcb/kwindowinfo_p_x11.h 
> 68805765fd630c2bc7cf0d77be688333b4a363f7 
> 
> Diff: https://git.reviewboard.kde.org/r/129327/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

[Differential] [Request, 4 lines] D3314: Properly test environment variable

2016-11-08 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added a reviewer: Frameworks.

REVISION SUMMARY
  use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3314

AFFECTED FILES
  src/core/ksharedconfig.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks

[Differential] [Request, 13 lines] D3315: We don't need to iterate through paths

2016-11-08 Thread apol (Aleix Pol Gonzalez) 
apol created this revision.
apol added reviewers: Frameworks, winterz, mart.

REVISION SUMMARY
  ::filePath will do what it has to do
  
  Thanks to Allen Winter for pointing it out

TEST PLAN
  tests pass, projects still compile without complaining

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3315

AFFECTED FILES
  src/kpackage/package.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, winterz, mart