[Differential] [Accepted] D3696: Search for the more precise required version of AppstreamQt
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM. Although, can we expect AppStreamQt to at least avoid breaking SIC in minor releases? Otherwise this problem will appear again... REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D3696 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame
Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129657/#review101464
---
Ship it!
Thanks for working on this!
I noticed that I could remove the change in beginRemoveRows without any unit
test failing.
Please add this test on top of your patch:
diff --git a/autotests/kselectionproxymodeltest.cpp
b/autotests/kselectionproxymodeltest.cpp
index e17fa53..68c8678 100644
--- a/autotests/kselectionproxymodeltest.cpp
+++ b/autotests/kselectionproxymodeltest.cpp
@@ -611,6 +611,13 @@ void KSelectionProxyModelTest::removeRows_data()
<< 1
<< QStringList{"9", "9"} << 2;
++testNumber;
+
+ QTest::newRow(QByteArray("test" +
QByteArray::number(testNumber)).data())
+ << static_cast(kspm_mode) << connectSelectionModelFirst
<< false
+ << QStringList{"6", "8", "11"} << 4
+ << 0
+ << QStringList{"8", "8"} << 4;
+ ++testNumber;
}
}
- Stephen Kelly
On Dec. 15, 2016, 11:15 p.m., David Faure wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129657/
> ---
>
> (Updated Dec. 15, 2016, 11:15 p.m.)
>
>
> Review request for KDE Frameworks and Stephen Kelly.
>
>
> Repository: kitemmodels
>
>
> Description
> ---
>
> After
>int proxyEndRemove = proxyStartRemove;
>proxyEndRemove += rc; was adding 0 (empty root)
> and then --proxyEndRemove; was making us end up with proxyEndRemove <
> proxyStartRemove.
>
>
> Diffs
> -
>
> autotests/kselectionproxymodeltest.cpp
> 483e7c42dabab6aa560622ff0418ee7f90363e15
> src/kselectionproxymodel.cpp 0f57c70f05d4cbde9b14f4257bff1365ef5443f6
>
> Diff: https://git.reviewboard.kde.org/r/129657/diff/
>
>
> Testing
> ---
>
> New unittest + unchecking calendar in korganizer no longer asserts.
>
>
> Thanks,
>
> David Faure
>
>
Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101463 --- Ship it! Ship It! - Stephen Kelly On Dec. 15, 2016, 11:15 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129657/ > --- > > (Updated Dec. 15, 2016, 11:15 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kitemmodels > > > Description > --- > > After >int proxyEndRemove = proxyStartRemove; >proxyEndRemove += rc; was adding 0 (empty root) > and then --proxyEndRemove; was making us end up with proxyEndRemove < > proxyStartRemove. > > > Diffs > - > > autotests/kselectionproxymodeltest.cpp > 483e7c42dabab6aa560622ff0418ee7f90363e15 > src/kselectionproxymodel.cpp 0f57c70f05d4cbde9b14f4257bff1365ef5443f6 > > Diff: https://git.reviewboard.kde.org/r/129657/diff/ > > > Testing > --- > > New unittest + unchecking calendar in korganizer no longer asserts. > > > Thanks, > > David Faure > >
[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists
thiago added a comment. More information on this Windows behaviour: - https://blogs.msdn.microsoft.com/oldnewthing/20070503-00/?p=27003 - https://blogs.msdn.microsoft.com/oldnewthing/20070502-00/?p=27023/#2375204 There doesn't seem to be a way of doing some clean up before the threads are forcibly killed. Maybe if I abuse qtmain(). BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: thiago, albertvaka, mutlaqja, arrowdodger, #frameworks
[Differential] [Updated] D3696: Search for the more precise required version of AppstreamQt
ltoscano set the repository for this revision to R252 Framework Integration. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D3696 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame
[Differential] [Request, 2 lines] D3696: Search for the more precise required version of AppstreamQt
apol created this revision. apol added reviewers: Frameworks, lbeltrame. REVISION SUMMARY With versions older than 0.10.4 it won't compile BRANCH master REVISION DETAIL https://phabricator.kde.org/D3696 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, lbeltrame
Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 337 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/337/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:46 + Build duration: 5 min 15 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 (35%)CONDITIONAL 34/172 (20%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 5/10 (50%) src.kstyle FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 29/162 (18%)
Jenkins-kde-ci: frameworkintegration master kf5-qt5 » Linux,gcc - Build # 337 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/337/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:46 + Build duration: 5 min 15 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 (35%)CONDITIONAL 34/172 (20%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 5/10 (50%) src.kstyle FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 29/162 (18%)
Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 336 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/336/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:49 + Build duration: 1 min 31 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 (35%)CONDITIONAL 34/172 (20%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 5/10 (50%) src.kstyle FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 29/162 (18%)
Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 336 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/336/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 16 Dec 2016 00:31:49 + Build duration: 1 min 31 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 (35%)CONDITIONAL 34/172 (20%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 5/10 (50%) src.kstyle FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 29/162 (18%)
[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists
thiago added a comment. In https://phabricator.kde.org/D2545#69083, @kfunk wrote: > > Here's the other problem: it's possible for threads to simply disappear on Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I can't rule out that this has happened. Qt 5.6 has a workaround to another deadlock caused by Windows. Can you try to cherry-pick 3ec57107cedb154f256e3ad001ea5475cc64fa94 from 5.8? > > With 3ec57107cedb154f256e3ad001ea5475cc64fa94 applied: Still dead-locking, same backtrace. Ok, so I guess this was a different, but similar issue, that got fixed by that commit. The root cause is that at some point during the process shut down (after ExitProcess is called), the Windows runtime kills all other threads, without giving them a chance to clean up. Because of that, when static destructors run, the other threads are no longer running, even though the objects that managed them (QThread) says they are. The application is in an inconsistent state. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: thiago, albertvaka, mutlaqja, arrowdodger, #frameworks
[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists
kfunk added a comment. > Here's the other problem: it's possible for threads to simply disappear on Windows. Given that I see "dllmain" in the backtrace (though not DllMain), I can't rule out that this has happened. Qt 5.6 has a workaround to another deadlock caused by Windows. Can you try to cherry-pick 3ec57107cedb154f256e3ad001ea5475cc64fa94 from 5.8? With 3ec57107cedb154f256e3ad001ea5475cc64fa94 applied: Still dead-locking, same backtrace. BRANCH master REVISION DETAIL https://phabricator.kde.org/D2545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, vonreth, dfaure Cc: thiago, albertvaka, mutlaqja, arrowdodger, #frameworks
Re: Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/#review101460 --- +1 looks good. - Aleix Pol Gonzalez On Dec. 16, 2016, 12:15 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129657/ > --- > > (Updated Dec. 16, 2016, 12:15 a.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kitemmodels > > > Description > --- > > After >int proxyEndRemove = proxyStartRemove; >proxyEndRemove += rc; was adding 0 (empty root) > and then --proxyEndRemove; was making us end up with proxyEndRemove < > proxyStartRemove. > > > Diffs > - > > autotests/kselectionproxymodeltest.cpp > 483e7c42dabab6aa560622ff0418ee7f90363e15 > src/kselectionproxymodel.cpp 0f57c70f05d4cbde9b14f4257bff1365ef5443f6 > > Diff: https://git.reviewboard.kde.org/r/129657/diff/ > > > Testing > --- > > New unittest + unchecking calendar in korganizer no longer asserts. > > > Thanks, > > David Faure > >
Review Request 129657: Fix assert (in beginRemoveRows) when deselecting an empty child of a selected child in korganizer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129657/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmodels Description --- After int proxyEndRemove = proxyStartRemove; proxyEndRemove += rc; was adding 0 (empty root) and then --proxyEndRemove; was making us end up with proxyEndRemove < proxyStartRemove. Diffs - autotests/kselectionproxymodeltest.cpp 483e7c42dabab6aa560622ff0418ee7f90363e15 src/kselectionproxymodel.cpp 0f57c70f05d4cbde9b14f4257bff1365ef5443f6 Diff: https://git.reviewboard.kde.org/r/129657/diff/ Testing --- New unittest + unchecking calendar in korganizer no longer asserts. Thanks, David Faure
Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 335 - Still Failing!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/335/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 15 Dec 2016 21:33:53 + Build duration: 3 min 32 sec CHANGE SET No changes
[Differential] [Accepted] D3636: [kconfig_compiler] Improve documentation about Inherits
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D3636 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, mdawson, dfaure Cc: nalvarez
[Differential] [Updated, 6 lines] D3636: [kconfig_compiler] Improve documentation about Inherits
graesslin updated this revision to Diff 9049.
graesslin added a comment.
Add missing "("
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3636?vs=9046&id=9049
BRANCH
inherits-readme-improvement
REVISION DETAIL
https://phabricator.kde.org/D3636
AFFECTED FILES
src/kconfig_compiler/README.dox
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #frameworks, dfaure, mdawson
Cc: nalvarez
[Differential] [Updated, 674 lines] D3691: Update QMake syntax highlighting file
kfunk updated this revision to Diff 9048. kfunk added a comment. Add generator REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3691?vs=9047&id=9048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3691 AFFECTED FILES data/generators/qmake-gen.py data/syntax/qmake.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks
[Differential] [Updated] D3691: Update QMake syntax highlighting file
kfunk added a reviewer: Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D3691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, #frameworks
[Differential] [Commented On] D3636: [kconfig_compiler] Improve documentation about Inherits
dfaure added inline comments.
INLINE COMMENTS
> README.dox:112
> + KConfigSkeleton and must provide a default constructor (kcfgfile not
> specified), a constructor
> + taking a QString argument kcfgfile with "name" attribute) and a
> constructor taking a
> + KSharedConfig::Ptr as argument (kcfgfile with "arg" attribute).
Missing a '(' somewhere, most likely before kcfgfile.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D3636
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, #frameworks, dfaure, mdawson
Cc: nalvarez
[Differential] [Updated, 6 lines] D3636: [kconfig_compiler] Improve documentation about Inherits
graesslin updated this revision to Diff 9046. graesslin added a comment. Constructor instead of ctor REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3636?vs=9018&id=9046 BRANCH inherits-readme-improvement REVISION DETAIL https://phabricator.kde.org/D3636 AFFECTED FILES src/kconfig_compiler/README.dox EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, dfaure, mdawson Cc: nalvarez
[Differential] [Request, 194 lines] D3690: Generate an instance with KSharedConfig::Ptr for singleton and arg
graesslin created this revision. graesslin added reviewers: Frameworks, dfaure, mdawson. REVISION SUMMARY In case a kcfg with arg="true" was used and singleton the static instance method only accepted a QString config name. This made it impossible to combine a singleton config with an already existing and open KSharedConfig::Ptr. With this change an overloaded instance method is added which takes a KSharedConfig::Ptr as argument. The private ctor, though, only takes a KSharedConfig::Ptr and the instance method taking a QString argument uses KSharedConfig::openConfig on the config file name. The change is source-incompatible in the following situation: - kcfgfile arg="true" - Singleton = true - Inherits is specified In this situation the previous revision created an instance method with a QString argument and passed that to the parent constructor. This is not in accordance with the documentation. Any user of this behavior was relying on a bug. With this change now the call to the parent constructor carries a KSharedConfigPtr. TEST PLAN kconfigcompiler tests still pass and a config with singleton and arg="true" generates the code as I need it REPOSITORY R237 KConfig BRANCH kconfig-change-try2 REVISION DETAIL https://phabricator.kde.org/D3690 AFFECTED FILES autotests/kconfig_compiler/CMakeLists.txt autotests/kconfig_compiler/kconfigcompiler_test.cpp autotests/kconfig_compiler/test8c.cpp.ref autotests/kconfig_compiler/test8c.h.ref autotests/kconfig_compiler/test8c.kcfg autotests/kconfig_compiler/test8c.kcfgc autotests/kconfig_compiler/test8main.cpp src/kconfig_compiler/kconfig_compiler.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks, dfaure, mdawson
[Differential] [Updated] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable
graesslin retitled this revision from "[runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable" to "KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable". REVISION DETAIL https://phabricator.kde.org/D3689 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks
[Differential] [Request, 2 lines] D3689: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable
graesslin created this revision. graesslin added a reviewer: Frameworks. REVISION SUMMARY The idea behind the env variable is to put kgloabalacceld into test mode and let it operate on a in-memory KConfig instead of the normal rc file. From auto tests in KWin we know that the QStandardPath::setTestModeEnabled is not sufficient. If there are multiple tests interacting with kglobalaccel they interact with each other in ways we normally don't want. With this env variable we could get KWin to have an in-memory kconfig and support better testing of the global shortcuts. We can adjust the shortcuts without having side effects on other tests. BRANCH kglobalaccel-test-mode REVISION DETAIL https://phabricator.kde.org/D3689 AFFECTED FILES src/runtime/globalshortcutsregistry.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #frameworks
Re: Review Request 129648: New widget: tooltip that contains another widget
> On Dec. 14, 2016, 7:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same feature with Qt only? > > Martin Gräßlin wrote: > Well there are multiple solutions: > > * don't put it in this framework > * make this framework a tier 2 > * add a property and let Plasma's platform plugin do the blurring > add a property and let Plasma's platform plugin do the blurring Can you expand on this? How would it work? Sounds like the best solution... - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101445 --- On Dec. 13, 2016, 3:45 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129648/ > --- > > (Updated Dec. 13, 2016, 3:45 p.m.) > > > Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin > Gräßlin. > > > Repository: kwidgetsaddons > > > Description > --- > > This new widget is based on the KToolTip code that is duplicated across > multiple products: at least Dolphin, systemsettings, kinfocenter, > ktp-contact-list. > > Rationale: with a single class in frameworks, it will be possible to apply > features/fixes only once. See for example the comments in > https://phabricator.kde.org/D3112 > > A new feature that the old code doesn't have is the delayed hide: this makes > it possible to actually use the widget shown in the tooltip. > > > Diffs > - > > autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b > autotests/ktooltipwidgettest.h PRE-CREATION > autotests/ktooltipwidgettest.cpp PRE-CREATION > src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 > src/ktooltipwidget.h PRE-CREATION > src/ktooltipwidget.cpp PRE-CREATION > tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 > tests/ktooltipwidget_test.h PRE-CREATION > tests/ktooltipwidget_test.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129648/diff/ > > > Testing > --- > > Manual test works both in X11 and Wayland. Unit tests pass. > > Ported Dolphin locally to this new class, everything seems to work (and this > will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and > [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129648: New widget: tooltip that contains another widget
> On Dec. 14, 2016, 8:21 p.m., Martin Gräßlin wrote: > > If I see correctly we are losing a feature here: blur behind. > > Elvis Angelaccio wrote: > Right, I had to drop that because we cannot use KWindowSystem in tier 1. > Is there a way to achieve the same feature with Qt only? Well there are multiple solutions: * don't put it in this framework * make this framework a tier 2 * add a property and let Plasma's platform plugin do the blurring - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129648/#review101445 --- On Dec. 13, 2016, 4:45 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129648/ > --- > > (Updated Dec. 13, 2016, 4:45 p.m.) > > > Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin > Gräßlin. > > > Repository: kwidgetsaddons > > > Description > --- > > This new widget is based on the KToolTip code that is duplicated across > multiple products: at least Dolphin, systemsettings, kinfocenter, > ktp-contact-list. > > Rationale: with a single class in frameworks, it will be possible to apply > features/fixes only once. See for example the comments in > https://phabricator.kde.org/D3112 > > A new feature that the old code doesn't have is the delayed hide: this makes > it possible to actually use the widget shown in the tooltip. > > > Diffs > - > > autotests/CMakeLists.txt ffcce3a046ec98b07c4677578f6bc997de1ef16b > autotests/ktooltipwidgettest.h PRE-CREATION > autotests/ktooltipwidgettest.cpp PRE-CREATION > src/CMakeLists.txt de0a8d965f1541d5ffeec93d1aa06600b0b9c138 > src/ktooltipwidget.h PRE-CREATION > src/ktooltipwidget.cpp PRE-CREATION > tests/CMakeLists.txt fcb348b1ae9d4270468c3f9003c5ba5f3903db84 > tests/ktooltipwidget_test.h PRE-CREATION > tests/ktooltipwidget_test.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129648/diff/ > > > Testing > --- > > Manual test works both in X11 and Wayland. Unit tests pass. > > Ported Dolphin locally to this new class, everything seems to work (and this > will fix bug [#352276](https://bugs.kde.org/show_bug.cgi?id=352276) and > [#371223](https://bugs.kde.org/show_bug.cgi?id=371223)). > > > Thanks, > > Elvis Angelaccio > >
Re: Review Request 129260: Add find module for QtPlatformSupport
> On Oct. 27, 2016, 7:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM > > David Edmundson wrote: > To this specific patch, or the concept in general? To this specific patch - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100323 --- On Oct. 26, 2016, 11:17 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129260/ > --- > > (Updated Oct. 26, 2016, 11:17 a.m.) > > > Review request for KDE Frameworks, Alex Merry and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > --- > > Comes from KWin and will eventually be used in Plasma Integration, hence > moving it to extra-cmake-modules. > > > Diffs > - > > find-modules/FindQt5PlatformSupport.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129260/diff/ > > > Testing > --- > > Removed it from KWin, built KWin, worked. > > Built plasma-integration with QDBusMenu private stuff, worked, although > includes there sometimes omit the QtPlatformSupport/ prefix but this is an > upstream issue since it works with the files Kwin includes. > > > Thanks, > > Kai Uwe Broulik > >
Review Request 129654: Introduce the resource name in the knsrc file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- Discover has been changed to display all installed `knsrc` files in the system instead of having a static list in the system. For that to happen I'd like to include in the `knsrc` file a title that describes the contained resources. This should be accompanied with the following change to scripty to enable translations of the field: ``` Index: findfiles === --- findfiles (revision 1477134) +++ findfiles (working copy) @@ -28,7 +28,7 @@ continue fi echo "$dir" - find "$dir" ( -path "*/test/*" -o -path "*/tests/*" -o -path "*/autotest/*" -o -path "*/autotests/*" ) -prune -o ( ( -name *.directory -o -name *.desktop -o -name *.desktop.cmake -o -name *.kimap -o -name *.themerc -o -name *.kcsrc -o -name *.setdlg -o -name index.theme -o -name *.notifyrc -o -name *.protocol -o -name *.profile -o -name *.actions ) -a ( -type f -o -type l ) -print ) >> $filelist + find "$dir" ( -path "*/test/*" -o -path "*/tests/*" -o -path "*/autotest/*" -o -path "*/autotests/*" ) -prune -o ( ( -name *.directory -o -name *.desktop -o -name *.knsrc -o -name *.desktop.cmake -o -name *.kimap -o -name *.themerc -o -name *.kcsrc -o -name *.setdlg -o -name index.theme -o -name *.notifyrc -o -name *.protocol -o -name *.profile -o -name *.actions ) -a ( -type f -o -type l ) -print ) >> $filelist extradesktopscripts=`find $dir -name ExtraDesktop.sh` initialdir=`pwd` for extradesktopscript in $extradesktopscripts; do ``` Diffs - src/downloaddialog.cpp 5831211 Diff: https://git.reviewboard.kde.org/r/129654/diff/ Testing --- The `Name` field is used when available, also adopted it in Discover. Thanks, Aleix Pol Gonzalez
Re: Review Request 129260: Add find module for QtPlatformSupport
> On Oct. 27, 2016, 5:39 a.m., Martin Gräßlin wrote: > > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding > > to ECM To this specific patch, or the concept in general? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129260/#review100323 --- On Oct. 26, 2016, 9:17 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129260/ > --- > > (Updated Oct. 26, 2016, 9:17 a.m.) > > > Review request for KDE Frameworks, Alex Merry and Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > --- > > Comes from KWin and will eventually be used in Plasma Integration, hence > moving it to extra-cmake-modules. > > > Diffs > - > > find-modules/FindQt5PlatformSupport.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/129260/diff/ > > > Testing > --- > > Removed it from KWin, built KWin, worked. > > Built plasma-integration with QDBusMenu private stuff, worked, although > includes there sometimes omit the QtPlatformSupport/ prefix but this is an > upstream issue since it works with the files Kwin includes. > > > Thanks, > > Kai Uwe Broulik > >
Re: Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 334 - Still Failing!
On Thu, Dec 15, 2016 at 7:19 AM, Ben Cooksley wrote: > > On Thu, Dec 15, 2016 at 7:16 PM, wrote: > > > > GENERAL INFO > > > > BUILD FAILURE > > Build URL: > > https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/334/ > > Project: PLATFORM=Linux,compiler=gcc > > Date of build: Thu, 15 Dec 2016 06:14:40 + > > Build duration: 23 sec > > It would appear that Commit d5652726b30c14033cddd757242db703576b1e95 > introduced a dependency on KNewStuff, but this dependency has not been > declared in the build metadata... > > > > > CHANGE SET > > No changes > > Cheers, > Ben Should be fixed: https://commits.kde.org/kde-build-metadata/a322bb20d90c05e610443d774bc9634e6f2ab7ef Aleix
