[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in ListItem.qml:97
> Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...
> 
> It's barely a behavioral change, in fact it's what it was supposed to happen 
> in the first place: give feedback on hover when the item is clickable.
> Note that at the moment we're dimming the opacity for the invisible 
> background we have.

> in fact it's what it was supposed to happen in the first place

We have the highlight for the item under mouse. 
Why should the delegate change too?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 16 lines] D4214: Make sure we display enabled ListItem on hover

[Aleix Pol Gonzalez]

apol updated this revision to Diff 10379.
apol marked an inline comment as done.
apol added a comment.


  Address David's comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4214?vs=10372&id=10379

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4214

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated] D4214: Make sure we display enabled ListItem on hover

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ListItem.qml:97
> why are you now following containsMouse. That's a behavioural change
> 
> How can background.pressed be true. I don't see where it exists?
> do you mean itemMouse.pressed?

Yes, I meant to put `itemMouse.pressed`. I wonder why QML doesn't complain...

It's barely a behavioral change, in fact it's what it was supposed to happen in 
the first place: give feedback on hover when the item is clickable.
Note that at the moment we're dimming the opacity for the invisible background 
we have.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Updated, 312 lines] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol updated this revision to Diff 10377.
apol added a comment.


  Dropped usage of QMap and QVector from the handler
  
  Still using QPluginLoader and QDirIterator which probably are as bad as those.

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4201?vs=10363&id=10377

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4201

AFFECTED FILES
  src/CMakeLists.txt
  src/config-kcrash.h.cmake
  src/kcrash.cpp
  src/kcrashhandlerplugin.cpp
  src/kcrashhandlerplugin.h
  src/plugins/CMakeLists.txt
  src/plugins/kcoreaddonsplugin.cpp
  src/plugins/kstartupinfoplugin.cpp
  src/plugins/xcbplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Updated] D4213: Mark non-persistent notifications as transient.

[Aleix Pol Gonzalez]

apol added a reviewer: Plasma.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4213

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #frameworks, #plasma
Cc: #frameworks

[Differential] [Commented On] D4214: Make sure we display enabled ListItem on hover

[David Edmundson]

davidedmundson added a comment.


  Concept seems fine. New binding has some typos

INLINE COMMENTS

> ListItem.qml:97
> +prefix: (listItem.sectionDelegate ? "section" :
> +(background.pressed || listItem.checked || 
> listItem.containsMouse) ? "pressed" : "normal")
>  

why are you now following containsMouse. That's a behavioural change

How can background.pressed be true. I don't see where it exists?
do you mean itemMouse.pressed?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4214

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Closed] D4151: Port to categorized logging

[Luigi Toscano]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:c1638e121d4a: Port to categorized logging (authored by 
ltoscano).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D4151?vs=10198&id=10375#toc

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4151?vs=10198&id=10375

REVISION DETAIL
  https://phabricator.kde.org/D4151

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/k7zip.cpp
  src/kar.cpp
  src/karchive.cpp
  src/kbzip2filter.cpp
  src/kcompressiondevice.cpp
  src/kfilterdev.cpp
  src/kgzipfilter.cpp
  src/klimitediodevice.cpp
  src/krcc.cpp
  src/ktar.cpp
  src/kxzfilter.cpp
  src/kzip.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, dfaure
Cc: #frameworks

Re: [kde-dev-scripts/Applications/16.12] /: Add a script to run uncrustify for source code reformatting.

[David Faure]

On jeudi 19 janvier 2017 22:49:07 CET Albert Astals Cid wrote:
> This is a new application in a stable branch.

Application is a big word for a script, but OK, I'll remove it.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

[Differential] [Accepted] D4151: Port to categorized logging

[David Faure]

dfaure accepted this revision.
dfaure added a reviewer: dfaure.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4151

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ltoscano, dfaure
Cc: #frameworks

[Differential] [Request, 16 lines] D4214: Make sure we display enabled ListItem on hover

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  I just realized there was a weird workaround in plasma-nm where it gets
  checked so it's shown.
  Properly use the declarative API instead of listening to a ton of signals.

TEST PLAN
  Tested with plasma-nm and org.kde.plasma.notifications plasmoids

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4214

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D4213: Mark non-persistent notifications as transient.

[Albert Vaca Cintora]

albertvaka added a reviewer: Frameworks.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4213

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka, #frameworks
Cc: #frameworks

[Differential] [Request, 4 lines] D4213: Mark non-persistent notifications as transient.

[Albert Vaca Cintora]

albertvaka created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  On Gnome and other desktops using their extension of the notifications
  spec, notifications are persistent unless they set the transient hint.
  
  This tries to make notifications more consistent across desktops.

TEST PLAN
  Manual testing on Gnome.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4213

AFFECTED FILES
  src/notifybypopup.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: albertvaka
Cc: #frameworks

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 316 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/316/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 19 Jan 2017 22:19:20 +
Build duration: 14 min

CHANGE SET
Revision 1d12abf3349c4c56e339e92a0b16444534ee6c93 by kainz.a: (fix color 
styling in network plasma icon BUG: 373172)
  change: edit src/desktoptheme/breeze/icons/network.svgz


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 83/122 (68%)CLASSES 83/122 (68%)LINE 5017/11838 
(42%)CONDITIONAL 2699/8946 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1062/1108 
(96%)CONDITIONAL 661/1294 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 666/2147 
(31%)CONDITIONAL 312/1322 (24%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1668/3607 
(46%)CONDITIONAL 962/2693 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 925/1641 
(56%)CONDITIONAL 426/1076 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 567/1831 
(31%)CONDITIONAL 310/1427 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1146 (1%)CONDITIONAL 
1/984 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 316 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/316/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 19 Jan 2017 22:19:20 +
Build duration: 14 min

CHANGE SET
Revision 1d12abf3349c4c56e339e92a0b16444534ee6c93 by kainz.a: (fix color 
styling in network plasma icon BUG: 373172)
  change: edit src/desktoptheme/breeze/icons/network.svgz


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 83/122 (68%)CLASSES 83/122 (68%)LINE 5017/11838 
(42%)CONDITIONAL 2699/8946 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1062/1108 
(96%)CONDITIONAL 661/1294 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 666/2147 
(31%)CONDITIONAL 312/1322 (24%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1668/3607 
(46%)CONDITIONAL 962/2693 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 925/1641 
(56%)CONDITIONAL 426/1076 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 567/1831 
(31%)CONDITIONAL 310/1427 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1146 (1%)CONDITIONAL 
1/984 (0%)

Re: [kde-dev-scripts/Applications/16.12] /: Add a script to run uncrustify for source code reformatting.

[Albert Astals Cid]

This is a new application in a stable branch.

I'm sure distributions are going to love it.

Cheers,
  Albert

El dijous, 19 de gener de 2017, a les 10:27:49 CET, David Faure va escriure:
> Git commit e93a28b3eb153695e8edb7ae259243b7b409a29d by David Faure.
> Committed on 16/01/2017 at 19:13.
> Pushed by dfaure into branch 'Applications/16.12'.
> 
> Add a script to run uncrustify for source code reformatting.
> 
> This does a better job than astyle-kdelibs, which I now consider deprecated.
> 
> CCMAIL: kde-frameworks-devel@kde.org, mon...@kde.org
> 
> M  +7-0CMakeLists.txt
> A  +86   -0uncrustify-kf5
> A  +465  -0uncrustify-kf5.cfg
> A  +467  -0uncrustify-qt.cfg
> 
> https://commits.kde.org/kde-dev-scripts/e93a28b3eb153695e8edb7ae259243b7b409
> a29d
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 4879e87..4d7b7f4 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -62,9 +62,16 @@ install(PROGRAMS
>svngettags
>svnlastlog
>svnrevertlast
> +  uncrustify-kf5
>wcgrep
>draw_lib_dependencies
>DESTINATION ${BIN_INSTALL_DIR})
> +
> +install(FILES
> +  uncrustify-kf5.cfg
> +  uncrustify-qt.cfg
> +  DESTINATION ${DATA_INSTALL_DIR}/uncrustify)
> +
>  endif (UNIX)
> 
>  install(PROGRAMS
> diff --git a/uncrustify-kf5 b/uncrustify-kf5
> new file mode 100755
> index 000..1427db7
> --- /dev/null
> +++ b/uncrustify-kf5
> @@ -0,0 +1,86 @@
> +#!/bin/sh
> +
> +# Apply KF5 coding style to all c, cpp and header files in and below the
> current directory +#
> +# The coding style is defined in
> http://techbase.kde.org/Policies/Kdelibs_Coding_Style +#
> +# Requirements:
> +# - installed uncrustify >= 0.63
> +#  Do not use an older version, it will lead to bad reformatting.
> +# - $QT_NORMALIZE_TOOL pointing to qtrepotools/util/normalize/normalize
> (after compiling it) +#
> +# Report bugs in uncrustify at
> https://github.com/uncrustify/uncrustify/issues +#
> +
> +files=`find -type f -name '*.c' -or -name '*.cpp' -or -name '*.cc' -or
> -name '*.h'` +if [ -z "$files" ]; then
> +  # nothing to do
> +  exit 0
> +fi
> +
> +if test -z "$QT_NORMALIZE_TOOL"; then
> +  echo "Please export
> QT_NORMALIZE_TOOL=/qtrepotools/util/normalize/normalize" +  exit 1
> +fi
> +
> +# Change this to uncrustify-qt.cfg to reformat Qt code (TODO: command-line
> option?) +cfgfile=uncrustify-kf5.cfg
> +
> +cfg=`qtpaths --locate-file GenericDataLocation uncrustify/$cfgfile`
> +if test -z "$cfg"; then
> +  echo "Config file uncrustify/$cfgfile not found in prefix/share
> (GenericDataLocation). Check that XDG_DATA_DIRS contains the install prefix
> for kde-dev-scripts." +  exit 1
> +fi
> +
> +uncrustify --no-backup -c "$cfg" $files
> +
> +# Watch out for things that lead to method implementations being parsed as
> if inside other methods, +# e.g. due to '{' inside #ifdef and #else and '}'
> outside.
> +grep '^\S* \S*::.*) {$' $files && echo "WARNING: check for wrong '{'
> placement in method definitions, in above grep results" +
> +# Remove old emacs mode-lines
> +perl -pi -e '$_ = "" if /c-basic-offset: [1-8]/' $files
> +
> +# Remove old kate mode-lines
> +perl -pi -e '$_ = "" if /kate: .*indent-width/ || /kate:.*tab-width/'
> $files +
> +# Remove old vim mode-lines
> +perl -pi -e '$_ = "" if /\/\/.* vim:/' $files
> +# They are often in a two-liner C comment, so we need a bit of perl magic
> to remove these +perl - $files < +  foreach my \$file (@ARGV) {
> +   open F, "+<", \$file or do { print STDERR "open(\$file) failed :
> \"\$!\"\n"; next }; +   my \$str = join '', ;
> +   if( \$str =~ m/vim:/ ) {
> + #print STDERR "Removing multi-line vim modeline from \$file\n";
> + \$str =~ s!/\*\**\s*\**\s*vim:[^\n]*\n\s*\*/!!smg;
> + seek F, 0, 0;
> + print F \$str;
> + truncate F, tell(F);
> +   }
> +   close F;
> +  }
> +EOF
> +
> +# Remove consecutive blank lines
> +perl - $files < +  foreach my \$file (@ARGV) {
> +   open F, "+<", \$file or do { print STDERR "open(\$file) failed :
> \"\$!\"\n"; next }; +   my \$str = join '', ;
> +   if (\$str =~ s/\s*\n\s*\n\s*\n\n*/\n\n/smg ) {
> + seek F, 0, 0;
> + print F \$str;
> + truncate F, tell(F);
> +   }
> +   close F;
> +  }
> +EOF
> +
> +# Normalize signals/slots
> +$QT_NORMALIZE_TOOL --modify .
> +
> +# TODO: add command-line option to trigger this
> +# It's not wanted when working on a fix
> +#git commit -q -a -m "Code reformatted using
> kde-dev-scripts/astyle-kdelibs. +#Use git blame -w `git rev-parse --short
> HEAD` to show authorship as it was before this commit." +
> diff --git a/uncrustify-kf5.cfg b/uncrustify-kf5.cfg
> new file mode 100644
> index 000..b87d65a
> --- /dev/null
> +++ b/uncrustify-kf5.cfg
> @@ -0,0 +1,465 @@
> +set FOR foreach
> +set FOR forever
> +
> +align_assign_span=0
> +align_assign_thresh=0
> +align_enum_equ_span=0
> +align_enum_equ_thresh=0
> +align_func_params=false
> +align_func_proto_gap=0
> +align_func_proto_span=0
> +align_keep_extra_space=false
> +align_keep_tabs=false
> +ali

Re: Review Request 129609: utils.js: Escape backslash in i18n string

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/#review102103
---



Fsck, gettext incorrectly extracts "\s" as "s".

- Alexander Potashev


On Янв. 19, 2017, 7:09 п.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129609/
> ---
> 
> (Updated Янв. 19, 2017, 7:09 п.п.)
> 
> 
> Review request for Kate and KDE Frameworks.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> utils.js: Escape backslash in i18n string
> 
> 
> Diffs
> -
> 
>   src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a 
> 
> Diff: https://git.reviewboard.kde.org/r/129609/diff/
> 
> 
> Testing
> ---
> 
> None!
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

[Ben Cooksley]

bcooksley updated the test plan for this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

Re: platform theme tinkering on Mac (to anyone doing/using KF5 builds on Mac)

[René J . V . Bertin]

On Thursday January 19 2017 18:05:26 René J.V. Bertin wrote:

> There are a few build options, but the one you'll want to activate is 
> OVERRIDE_NATIVE_THEME .

Without that you'll have to set QT_QPA_PLATFORMTHEME=kde in the environment.

I just managed to build the plugin against a stock Qt 5.8.0RC. There are some 
warnings due to using KF5 frameworks built against my own Qt 5 and evidently it 
finds my kdeglobals file because KConfig uses my patched QStandardPath methds.
But on the whole it works as expected. Yay :)

R.

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kcrash.cpp:437
> You have a comment to follow :)

You can't use QVector here. We're crashing, likely due to corrupted memory, the 
whole point of this code is to NOT do any memory allocation. You should revert 
to const char*[], or use something that always allocates on the stack (e.g. 
QVarLengthArray, if preallocated to be big enough).

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol marked an inline comment as done.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Updated, 325 lines] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol updated this revision to Diff 10363.
apol added a comment.


  Use QVector instead of const char*[]

REPOSITORY
  R285 KCrash

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4201?vs=10353&id=10363

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4201

AFFECTED FILES
  src/CMakeLists.txt
  src/config-kcrash.h.cmake
  src/kcrash.cpp
  src/kcrashhandlerplugin.cpp
  src/kcrashhandlerplugin.h
  src/plugins/CMakeLists.txt
  src/plugins/kcoreaddonsplugin.cpp
  src/plugins/kstartupinfoplugin.cpp
  src/plugins/xcbplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D4201#78639, @apol wrote:
  
  > In https://phabricator.kde.org/D4201#78631, @graesslin wrote:
  >
  > > I don't understand why a plugin architecture allows to move it to tier1. 
Is functionality split out? if yes, how does that help?
  >
  >
  > Ah, you are right, I forgot to mention it. I thought about this process as 
a 2-step, where the second step would be moving these handlers to 
`frameworksintegration`.
  
  
  Hmm, I don't like that. That turns frameworksintegration into the everything 
and the kitchen sink. Why should one depend on KIO to get a working KCrash?
  
  In the end that results in worse dependencies than before.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Closed] D4144: Install also CamelCase forward headers for classes from multi-class headers

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:1473382cbd22: Install also CamelCase forward headers for 
classes from multi-class headers (authored by kossebau).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4144?vs=10188&id=10360

REVISION DETAIL
  https://phabricator.kde.org/D4144

AFFECTED FILES
  src/CMakeLists.txt

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, cfeck
Cc: cfeck

[Differential] [Closed] D4137: API dox: Add @class comment with CamelCase include, image title without KDE

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0070f76418c0: API dox: Add @class comment with CamelCase 
include, image title without KDE (authored by kossebau).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4137?vs=10189&id=10361

REVISION DETAIL
  https://phabricator.kde.org/D4137

AFFECTED FILES
  src/kacceleratormanager.h
  src/kactionmenu.h
  src/kactionselector.h
  src/kanimatedbutton.h
  src/kassistantdialog.h
  src/kcapacitybar.h
  src/kcharselect.h
  src/kcollapsiblegroupbox.h
  src/kcolorbutton.h
  src/kcolorcombo.h
  src/kcolumnresizer.h
  src/kcursor.h
  src/kdatecombobox.h
  src/kdatepicker.h
  src/kdatetimeedit.h
  src/kdragwidgetdecorator.h
  src/kdualaction.h
  src/keditlistwidget.h
  src/kfontaction.h
  src/kfontchooser.h
  src/kfontrequester.h
  src/kfontsizeaction.h
  src/kguiitem.h
  src/kled.h
  src/kmessagebox.h
  src/kmessagewidget.h
  src/kmimetypechooser.h
  src/kmultitabbar.h
  src/knewpassworddialog.h
  src/knewpasswordwidget.h
  src/kpagedialog.h
  src/kpagemodel.h
  src/kpageview.h
  src/kpagewidget.h
  src/kpagewidgetmodel.h
  src/kpassworddialog.h
  src/kpixmapregionselectordialog.h
  src/kpixmapregionselectorwidget.h
  src/kpopupframe.h
  src/kratingpainter.h
  src/kratingwidget.h
  src/kruler.h
  src/kselectaction.h
  src/kselector.h
  src/kseparator.h
  src/ksplittercollapserbutton.h
  src/ksqueezedtextlabel.h
  src/ktimecombobox.h
  src/ktitlewidget.h
  src/ktoggleaction.h
  src/ktogglefullscreenaction.h
  src/ktoolbarlabelaction.h
  src/ktoolbarpopupaction.h
  src/ktoolbarspaceraction.h
  src/ktooltipwidget.h
  src/kurllabel.h
  src/kviewstateserializer.h
  src/kxyselector.h
  src/lineediturldropeventfilter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, cfeck
Cc: cfeck

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

[lara croft]

lcroft updated the test plan for this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

[lara croft]

lcroft updated the test plan for this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

[Differential] [Request, 24 lines] D4203: Fix appstream name/summary ends with '.' warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Drops the dot on these tags, possibly the right patch would be to fix the
  translation, but the end result is the same.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4203

AFFECTED FILES
  src/kpackagetool/kpackagetool.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Changed Subscribers] D4201: Make it possible to lower KCrash to tier 1

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kcrash.cpp:437
>  
>  const char *argv[29];  // don't forget to update this
>  int i = 0;

You have a comment to follow :)

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: anthonyfieroni, graesslin

platform theme tinkering on Mac (to anyone doing/using KF5 builds on Mac)

[René J . V . Bertin]

Hello!

I know we don't have strictly identical ideas on how KF5 applications should 
look on Mac. Still, I think it might amuse some of you to check out a platform 
theme plugin that allows applications to use the different font "roles" and 
default colour and icon palettes -- provided it works with a stock Qt5 and 
comes with appropriate "native" default settings?

That should now be the case with my osx-integration project:

https://commits.kde.org/scratch/rjvbb/osx-integration

There are a few build options, but the one you'll want to activate is 
OVERRIDE_NATIVE_THEME .

I've never yet made the effort of rebuilding all KF5 frameworks against a stock 
Qt5 and see how that works out (and where kdeglobals is expected, but it 
shouldn't be required anyway). If you have some time to build this small plugin 
give me some constructive feedback I'd appreciate it.

Thanks, and "enjoy"!

R.

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D4201#78631, @graesslin wrote:
  
  > I don't understand why a plugin architecture allows to move it to tier1. Is 
functionality split out? if yes, how does that help?
  
  
  Ah, you are right, I forgot to mention it. I thought about this process as a 
2-step, where the second step would be moving these handlers to 
`frameworksintegration`.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: graesslin

Re: Review Request 129609: utils.js: Escape backslash in i18n string

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129609/
---

(Updated Jan. 19, 2017, 4:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for Kate and KDE Frameworks.


Changes
---

Submitted with commit 4eac3b9b3c78cc854751ab2e8e128bb6eb030056 by Alexander 
Potashev to branch master.


Repository: ktexteditor


Description
---

utils.js: Escape backslash in i18n string


Diffs
-

  src/script/data/commands/utils.js a47e2b41a3c2bb581c48b566244b108b531be71a 

Diff: https://git.reviewboard.kde.org/r/129609/diff/


Testing
---

None!


Thanks,

Alexander Potashev

[Differential] [Commented On] D4201: Make it possible to lower KCrash to tier 1

[Martin Gräßlin]

graesslin added a comment.


  I don't understand why a plugin architecture allows to move it to tier1. Is 
functionality split out? if yes, how does that help?

INLINE COMMENTS

> kstartupinfoplugin.cpp:26
> +{
> +Q_OBJECT\
> +Q_PLUGIN_METADATA(IID "org.kde.KCrashHandlerPlugin")

is the \ intended?

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure
Cc: graesslin

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

[Anthony Fieroni]

> On Jan. 19, 2017, 5:36 p.m., Stefan Brüns wrote:
> > src/extractorcollection.cpp, line 155
> > 
> >
> > This is broken:
> > 
> > if (plugins.isEmpty()) {
> >   ...
> >   for (; it != d->m_extractors.constEnd(); it++) {
> >  if (plugins.contains( some_value )
> > 
> > The "plugins.contains(...)" is always false.

not always, line 150 appending to list, this guard to protect duplicate 
extractor


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129720/#review102096
---


On Dec. 29, 2016, 9:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129720/
> ---
> 
> (Updated Dec. 29, 2016, 9:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> startsWith is a weak precondition + guard for duplicate plugin
> 
> 
> Diffs
> -
> 
>   src/extractorcollection.cpp d0fbbea 
> 
> Diff: https://git.reviewboard.kde.org/r/129720/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129720: [ExtractorCollection] Use mimetype inheritance to return plugins

[Stefan Brüns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129720/#review102096
---




src/extractorcollection.cpp (line 155)


This is broken:

if (plugins.isEmpty()) {
  ...
  for (; it != d->m_extractors.constEnd(); it++) {
 if (plugins.contains( some_value )

The "plugins.contains(...)" is always false.


- Stefan Brüns


On Dec. 29, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129720/
> ---
> 
> (Updated Dec. 29, 2016, 7:17 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> startsWith is a weak precondition + guard for duplicate plugin
> 
> 
> Diffs
> -
> 
>   src/extractorcollection.cpp d0fbbea 
> 
> Diff: https://git.reviewboard.kde.org/r/129720/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

[Differential] [Request, 281 lines] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Puts in place a plugin system that exposes API to extract information to
  send the handler. This allows us to de-couple from different modules that
  need to be sequentially instanciated at the moment (and ifdef'd).

TEST PLAN
  Crashed kate, still get the right drkonqi.

REPOSITORY
  R285 KCrash

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4201

AFFECTED FILES
  src/CMakeLists.txt
  src/config-kcrash.h.cmake
  src/kcrash.cpp
  src/kcrashhandlerplugin.cpp
  src/kcrashhandlerplugin.h
  src/plugins/CMakeLists.txt
  src/plugins/kcoreaddonsplugin.cpp
  src/plugins/kstartupinfoplugin.cpp
  src/plugins/xcbplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure

[Differential] [Updated] D4201: Make it possible to lower KCrash to tier 1

[Aleix Pol Gonzalez]

apol updated the summary for this revision.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D4201

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 315 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/315/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Thu, 19 Jan 2017 13:30:56 +
Build duration: 4 min 13 sec

CHANGE SET
Revision 17830b10f83fcbfce52ba07a769fa4d555e40aa2 by David Edmundson: (Remove 
excessive debug in CommonDialog)
  change: edit src/declarativeimports/plasmacomponents/qml/CommonDialog.qml
Revision 46c87d5ac39370b17a34dd5a07dedd0ea631f217 by Marco Martin: (it must 
also be possible for the status to be decreased again)
  change: edit src/plasma/private/containment_p.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.plasma-dialogstatetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 83/122 (68%)CLASSES 83/122 (68%)LINE 4972/11838 
(42%)CONDITIONAL 2677/8946 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1039/1108 
(94%)CONDITIONAL 647/1294 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 666/2147 
(31%)CONDITIONAL 312/1322 (24%)
src.plasma
FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1668/3607 
(46%)CONDITIONAL 962/2693 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 915/1641 
(56%)CONDITIONAL 423/1076 (39%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 555/1831 
(30%)CONDITIONAL 305/1427 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1146 (1%)CONDITIONAL 
1/984 (0%)

[Differential] [Closed] D4065: Don't ask if we're getting the file in /tmp

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:2d6dc495fbe9: Don't ask if we're getting the file in /tmp 
(authored by apol).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4065?vs=9968&id=10350

REVISION DETAIL
  https://phabricator.kde.org/D4065

AFFECTED FILES
  src/core/installation.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir

Re: knewstuff's gpg use

[Aleix Pol]

On Thu, Jan 19, 2017 at 12:58 PM, Harald Sitter  wrote:
> Morning,
>
> I had the most peculiar incident just now. KNewstuff shouted at me
> because I have no bin/gpg(2). As it turns out core/security.cpp
> implements some form of gpg signing verification. Based on the gpg CLI
> app.
>
> Naturally, I am perplexed by this because CMake doesn't actually
> report gpg as a RUNTIME dep. that's not really the problem though. The
> problem is in core/installation.cpp where the Security class is
> "used".
>
> It is used by: ctoring and setting up signal connections and then the
> following marvel happens:
>
>> //  FIXME: security code below must go above, when async handling is 
>> complete 
>>
>> // FIXME: security object lifecycle - it is a singleton!
>> Security *sec = Security::ref();
>>
>> // FIXME: change to accept filename + signature
>> sec->checkValidity(QString());
>
> I am pretty sure that is no-op. Except for the fact that knewstuff
> will complain visually [1] if gpg is not found in $PATH.
>
> There is a bunch of issues with all of this:
> - Security isn't actually used
> - Security operates the bin/gpg CLI rather than using libgpgme which
> supposedly would fit here?
> - The gpg requirement is not codified in cmake
> - The class while saying it is private and not meant to be used,
> actually installs its header and exports itself -.-
> - The class doesn't even have an actual development history in git
> (sans mass refactoring and a workaround for the very noop code seen
> above)
>
> I move that we remove every "usage" of the Security class, mark the
> entire thing deprecated and rip it out with KF6.
>
> If no one has objections I'll prep a review for this tomorrow.
>
> [1] http://i.imgur.com/joGDtfT.png
>
> HS

Hi,
While debugging different issues I've also ran through this code and
wondered about its usefulness.

I agree that if it's actually a no-op (which could very well be, the
code is full of FIXMEs from a developer who hasn't touched the
codebase for several years) the best approach would be to keep it out
and if we ever want to add signing again, which would be actually
rather good, we can design it again, properly.

Aleix

knewstuff's gpg use

[Harald Sitter]

Morning,

I had the most peculiar incident just now. KNewstuff shouted at me
because I have no bin/gpg(2). As it turns out core/security.cpp
implements some form of gpg signing verification. Based on the gpg CLI
app.

Naturally, I am perplexed by this because CMake doesn't actually
report gpg as a RUNTIME dep. that's not really the problem though. The
problem is in core/installation.cpp where the Security class is
"used".

It is used by: ctoring and setting up signal connections and then the
following marvel happens:

> //  FIXME: security code below must go above, when async handling is 
> complete 
>
> // FIXME: security object lifecycle - it is a singleton!
> Security *sec = Security::ref();
>
> // FIXME: change to accept filename + signature
> sec->checkValidity(QString());

I am pretty sure that is no-op. Except for the fact that knewstuff
will complain visually [1] if gpg is not found in $PATH.

There is a bunch of issues with all of this:
- Security isn't actually used
- Security operates the bin/gpg CLI rather than using libgpgme which
supposedly would fit here?
- The gpg requirement is not codified in cmake
- The class while saying it is private and not meant to be used,
actually installs its header and exports itself -.-
- The class doesn't even have an actual development history in git
(sans mass refactoring and a workaround for the very noop code seen
above)

I move that we remove every "usage" of the Security class, mark the
entire thing deprecated and rip it out with KF6.

If no one has objections I'll prep a review for this tomorrow.

[1] http://i.imgur.com/joGDtfT.png

HS

[Differential] [Accepted] D4065: Don't ask if we're getting the file in /tmp

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  Go for it

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4065

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

[Marco Martin]

mart added a comment.


  -1 on this..
  wallpaper packagestructure is indeed very weird (it makes it so that a simple 
jpg is considered as a valid package.. is how the model for thumbnails works, 
which would be a good idea to change a little) , and that's why those warnings

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[kde-dev-scripts/Applications/16.12] /: Add a script to run uncrustify for source code reformatting.

[David Faure]

Git commit e93a28b3eb153695e8edb7ae259243b7b409a29d by David Faure.
Committed on 16/01/2017 at 19:13.
Pushed by dfaure into branch 'Applications/16.12'.

Add a script to run uncrustify for source code reformatting.

This does a better job than astyle-kdelibs, which I now consider deprecated.

CCMAIL: kde-frameworks-devel@kde.org, mon...@kde.org

M  +7-0CMakeLists.txt
A  +86   -0uncrustify-kf5
A  +465  -0uncrustify-kf5.cfg
A  +467  -0uncrustify-qt.cfg

https://commits.kde.org/kde-dev-scripts/e93a28b3eb153695e8edb7ae259243b7b409a29d

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4879e87..4d7b7f4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -62,9 +62,16 @@ install(PROGRAMS
   svngettags
   svnlastlog
   svnrevertlast
+  uncrustify-kf5
   wcgrep
   draw_lib_dependencies
   DESTINATION ${BIN_INSTALL_DIR})
+
+install(FILES
+  uncrustify-kf5.cfg
+  uncrustify-qt.cfg
+  DESTINATION ${DATA_INSTALL_DIR}/uncrustify)
+
 endif (UNIX)
 
 install(PROGRAMS
diff --git a/uncrustify-kf5 b/uncrustify-kf5
new file mode 100755
index 000..1427db7
--- /dev/null
+++ b/uncrustify-kf5
@@ -0,0 +1,86 @@
+#!/bin/sh
+
+# Apply KF5 coding style to all c, cpp and header files in and below the 
current directory
+#
+# The coding style is defined in 
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
+#
+# Requirements:
+# - installed uncrustify >= 0.63
+#  Do not use an older version, it will lead to bad reformatting.
+# - $QT_NORMALIZE_TOOL pointing to qtrepotools/util/normalize/normalize (after 
compiling it)
+#
+# Report bugs in uncrustify at https://github.com/uncrustify/uncrustify/issues
+#
+
+files=`find -type f -name '*.c' -or -name '*.cpp' -or -name '*.cc' -or -name 
'*.h'`
+if [ -z "$files" ]; then
+  # nothing to do
+  exit 0
+fi
+
+if test -z "$QT_NORMALIZE_TOOL"; then
+  echo "Please export 
QT_NORMALIZE_TOOL=/qtrepotools/util/normalize/normalize"
+  exit 1
+fi
+
+# Change this to uncrustify-qt.cfg to reformat Qt code (TODO: command-line 
option?)
+cfgfile=uncrustify-kf5.cfg
+
+cfg=`qtpaths --locate-file GenericDataLocation uncrustify/$cfgfile`
+if test -z "$cfg"; then
+  echo "Config file uncrustify/$cfgfile not found in prefix/share 
(GenericDataLocation). Check that XDG_DATA_DIRS contains the install prefix for 
kde-dev-scripts."
+  exit 1
+fi
+
+uncrustify --no-backup -c "$cfg" $files
+
+# Watch out for things that lead to method implementations being parsed as if 
inside other methods,
+# e.g. due to '{' inside #ifdef and #else and '}' outside.
+grep '^\S* \S*::.*) {$' $files && echo "WARNING: check for wrong '{' placement 
in method definitions, in above grep results"
+
+# Remove old emacs mode-lines
+perl -pi -e '$_ = "" if /c-basic-offset: [1-8]/' $files
+
+# Remove old kate mode-lines
+perl -pi -e '$_ = "" if /kate: .*indent-width/ || /kate:.*tab-width/' $files
+
+# Remove old vim mode-lines
+perl -pi -e '$_ = "" if /\/\/.* vim:/' $files
+# They are often in a two-liner C comment, so we need a bit of perl magic to 
remove these
+perl - $files <;
+   if( \$str =~ m/vim:/ ) {
+ #print STDERR "Removing multi-line vim modeline from \$file\n";
+ \$str =~ s!/\*\**\s*\**\s*vim:[^\n]*\n\s*\*/!!smg;
+ seek F, 0, 0;
+ print F \$str;
+ truncate F, tell(F);
+   }
+   close F;
+  }
+EOF
+
+# Remove consecutive blank lines
+perl - $files <;
+   if (\$str =~ s/\s*\n\s*\n\s*\n\n*/\n\n/smg ) {
+ seek F, 0, 0;
+ print F \$str;
+ truncate F, tell(F);
+   }
+   close F;
+  }
+EOF
+
+# Normalize signals/slots
+$QT_NORMALIZE_TOOL --modify .
+
+# TODO: add command-line option to trigger this
+# It's not wanted when working on a fix
+#git commit -q -a -m "Code reformatted using kde-dev-scripts/astyle-kdelibs.
+#Use git blame -w `git rev-parse --short HEAD` to show authorship as it was 
before this commit."
+
diff --git a/uncrustify-kf5.cfg b/uncrustify-kf5.cfg
new file mode 100644
index 000..b87d65a
--- /dev/null
+++ b/uncrustify-kf5.cfg
@@ -0,0 +1,465 @@
+set FOR foreach
+set FOR forever
+
+align_assign_span=0
+align_assign_thresh=0
+align_enum_equ_span=0
+align_enum_equ_thresh=0
+align_func_params=false
+align_func_proto_gap=0
+align_func_proto_span=0
+align_keep_extra_space=false
+align_keep_tabs=false
+align_left_shift=true
+align_mix_var_proto=false
+align_nl_cont=false
+align_number_left=false
+align_oc_decl_colon=false
+align_oc_msg_colon_first=false
+align_oc_msg_colon_span=0
+align_oc_msg_spec_span=0
+align_on_operator=false
+align_on_tabstop=false
+align_pp_define_gap=0
+align_pp_define_span=0
+align_pp_define_together=false
+align_right_cmt_at_col=0
+align_right_cmt_gap=0
+align_right_cmt_mix=false
+align_right_cmt_span=0
+align_same_func_call_params=false
+align_single_line_brace=false
+align_single_line_brace_gap=0
+align_single_line_func=false
+align_struct_init_span=0
+align_typedef_amp_style=0
+align_typedef_func=0
+align_typedef_gap=0
+align_typedef_span=0
+align_typedef_star_style=0
+align_var_def_amp_style=0
+align_var_def_attribute=false
+al

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 222 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/222/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 08:52:51 +
Build duration: 5 min 34 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5484/8008 
(68%)CONDITIONAL 2977/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 901/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2796 
(73%)CONDITIONAL 1229/2066 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

[Differential] [Commented On] D4188: Suppress warning message "No metadata file in the package..." when using desktop slideshow

[Jonathan Marten]

marten added a comment.


  Agreed that a decision needs to be made, but I'm not an expert on the 
KPackage system and so wasn't sure whether the warning may be useful to package 
developers in some cases - in which case leaving it commented out would make it 
easier to reinstate than removing it entirely.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D4188

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #frameworks, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 170 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/170/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 08:52:19 +
Build duration: 2 min 33 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 66/138 (48%)CLASSES 66/138 (48%)LINE 3465/13771 
(25%)CONDITIONAL 1309/7259 (18%)

By packages
  
autotests
FILES 25/25 (100%)CLASSES 25/25 (100%)LINE 1170/1172 
(100%)CONDITIONAL 592/1156 (51%)
src
FILES 41/113 (36%)CLASSES 41/113 (36%)LINE 2295/12599 
(18%)CONDITIONAL 717/6103 (12%)

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 170 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/170/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 19 Jan 2017 08:52:19 +
Build duration: 2 min 33 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
14 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 66/138 (48%)CLASSES 66/138 (48%)LINE 3465/13771 
(25%)CONDITIONAL 1309/7259 (18%)

By packages
  
autotests
FILES 25/25 (100%)CLASSES 25/25 (100%)LINE 1170/1172 
(100%)CONDITIONAL 592/1156 (51%)
src
FILES 41/113 (36%)CLASSES 41/113 (36%)LINE 2295/12599 
(18%)CONDITIONAL 717/6103 (12%)