D5603: Install Plasma Components 3 so they can be used
davidedmundson updated this revision to Diff 13849. davidedmundson added a comment. Much simpler change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5603?vs=13839=13849 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5603 AFFECTED FILES src/declarativeimports/CMakeLists.txt To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5603: Install Plasma Components 3 so they can be used
davidedmundson added a comment. Did not know about that little feature. That's much tidier. Then the only thing that's wrong is that we don't install the qmldir file, which is what sent me on this wild chase this morning. (interestingly my desktop did have that file, I guess it was installed in an earlier prototype that I had installed, probably the same for you too) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5603 To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D4975: Prevent misdetection of EOF on Linux
Lekensteyn added a comment. (FWIW, I ran a patched kpty 5.32.0-1 version for a while and didn't have the hang issue until I recently upgraded to an unpatched 5.33.0-1. Haven't had a moment so far to dig deeper into the issue though.) REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, ossi, hindenburg Cc: #frameworks
D5605: Allow multiple categories with the same name
mart added a reviewer: whiting. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5605 To: mart, #plasma, leinir, whiting Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5605: Allow multiple categories with the same name
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY the category name was intended as a kind of unique id, this isn't true anymore, so multiple categories can have the same name (even if having a different display_name) this makes content listing of category names with multiple ids work TEST PLAN on store.kde.org the category 399 is going to have the Plasma 5 Plasmoid name, tested with it and works (name got back to the old one now) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5605 AFFECTED FILES src/attica/atticaprovider.cpp To: mart, #plasma, leinir Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5603: Install Plasma Components 3 so they can be used
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:45
>
> -DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components.3)
> +DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/components/3)
components.3 is actually what is searched for by the import system when
importing a versioned import (kirigami is doing this as well)
> qmldir:39
> +
> +BusyIndicator 3.0 3/BusyIndicator.qml
> +Button 3.0 3/Button.qml
the components.3 folder should have its own qmldir instead
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D5603
To: davidedmundson, #plasma, mart
Cc: mart, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
Re: Continuous Integration on Windows
Hello, On vendredi 14 avril 2017 07:54:25 CEST Matthieu Gallien wrote: > Hello, > > On jeudi 13 avril 2017 19:31:37 CEST Kevin Funk wrote: > > On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote: > > > Hello, > > > > > > I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am > > > getting compilation errors in the automatic tests and have an hard time > > > getting it to works nominally. > > > > Paste the errors please, maybe we can fix. > > I have created a differential about the compilation error. > > The fact that I am not getting the extractors to run will need a bit more > time on my side to understand the error. At least, the problem I am facing > is that I seem to not be able to get any extractor to work. I was wrong and in fact the extractors are working on windows. I was mistaken by warnings about QApplication not being built before accessing standard paths. I was also mistaken by my experimental extractors built on top of Qt multimedia module. > > > Is there public servers currently testing KDE Frameworks 5 including > > > KFileMetaData ? > > > > Still no servers which compile KF5 master on a regular basis under > > Windows, > > unfortunately. > > > > > Should I switch to Microsoft compilers ? > > > > Not necessarily, KF5 /should/ compile fine under both MinGW & MSVC. > > OK, thanks for the information. > > > Cheers, > > Kevin > > > > > Thanks in advance for your help > > > > > > Best regards > > > > > > -- > > > Matthieu Gallien
D5417: add an extractor using qtmultimedia
mgallien updated this revision to Diff 13840. mgallien added a comment. fix several issues when testing on Windows with DirectShow Qt backend REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5417?vs=13367=13840 REVISION DETAIL https://phabricator.kde.org/D5417 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt autotests/qtmultimediaextractortest.cpp autotests/qtmultimediaextractortest.h src/extractors/CMakeLists.txt src/extractors/qtmultimediaextractor.cpp src/extractors/qtmultimediaextractor.h To: mgallien Cc: #frameworks
D5603: Install Plasma Components 3 so they can be used
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY PlasmaComponents 3 exists both as a theme for QQC2 but also to be used directly like the current Plasma Components. Currently they install into org.kde.plasma.components.3 which isn't a valid path, also it doesn't include the qmldir, so you can't load it anyway. This patch installs the files to a subdir of org.kde.plasma.components then update the original root qmldir toload the QQC2 version if the version matches. TEST PLAN Actually used them in a Plasmoid REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5603 AFFECTED FILES src/declarativeimports/CMakeLists.txt src/declarativeimports/plasmacomponents/qml/qmldir src/declarativeimports/plasmacomponents3/qmldir To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5587: Improvements
This revision was automatically updated to reflect the committed changes. Closed by commit R304:ceecc1c47568: Improvements (authored by apol). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5587?vs=13797=13832 REVISION DETAIL https://phabricator.kde.org/D5587 AFFECTED FILES src/core/cache.cpp src/core/xmlloader.cpp To: apol, #frameworks, leinir
D5597: Raise default for 'Panel' icons to 48
This revision was automatically updated to reflect the committed changes. Closed by commit R266:3e3eaaa82169: Raise default for 'Panel' icons to 48 (authored by hein). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5597?vs=13824=13826 REVISION DETAIL https://phabricator.kde.org/D5597 AFFECTED FILES icons-dark/index.theme icons/index.theme To: hein, #plasma, mart, broulik Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5597: Raise default for 'Panel' icons to 48
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5597 To: hein, #plasma, mart, broulik Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5597: Raise default for 'Panel' icons to 48
hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This KCM setting is now used again and this makes it match the default used by the Task Manager applet in vertical panels. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D5597 AFFECTED FILES icons-dark/index.theme icons/index.theme To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 405 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/405/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 26 Apr 2017 11:58:32 + Build duration: 10 min CHANGE SET Revision 4f48901b05fd9e543c958561543f19f617c0b177 by hein: (Introduce units.iconSizeHints.* to provide user-configurable icon size) change: edit src/declarativeimports/core/units.h change: edit src/declarativeimports/core/units.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5096/11994 (42%)CONDITIONAL 2786/9064 (31%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1088/1133 (96%)CONDITIONAL 684/1358 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 709/2235 (32%)CONDITIONAL 342/1392 (25%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 (47%)CONDITIONAL 988/2673 (37%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 933/1644 (57%)CONDITIONAL 434/1064 (41%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 565/1846 (31%)CONDITIONAL 310/1433 (22%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1222 (1%)CONDITIONAL 1/994 (0%)
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 405 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/405/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 26 Apr 2017 11:58:32 + Build duration: 10 min CHANGE SET Revision 4f48901b05fd9e543c958561543f19f617c0b177 by hein: (Introduce units.iconSizeHints.* to provide user-configurable icon size) change: edit src/declarativeimports/core/units.h change: edit src/declarativeimports/core/units.cpp JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5096/11994 (42%)CONDITIONAL 2786/9064 (31%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1088/1133 (96%)CONDITIONAL 684/1358 (50%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 709/2235 (32%)CONDITIONAL 342/1392 (25%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 (47%)CONDITIONAL 988/2673 (37%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 933/1644 (57%)CONDITIONAL 434/1064 (41%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 565/1846 (31%)CONDITIONAL 310/1433 (22%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1222 (1%)CONDITIONAL 1/994 (0%)
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 403 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/403/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 26 Apr 2017 11:58:32 + Build duration: 4 min 47 sec CHANGE SET Revision 4f48901b05fd9e543c958561543f19f617c0b177 by hein: (Introduce units.iconSizeHints.* to provide user-configurable icon size) change: edit src/declarativeimports/core/units.h change: edit src/declarativeimports/core/units.cpp JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.plasma-dialogstatetest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 9/9 (100%)FILES 83/121 (69%)CLASSES 83/121 (69%)LINE 5050/11994 (42%)CONDITIONAL 2763/9064 (30%) By packages autotests FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1064/1133 (94%)CONDITIONAL 669/1358 (49%) src.declarativeimports.core FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 709/2235 (32%)CONDITIONAL 342/1392 (25%) src.plasma FILES 15/22 (68%)CLASSES 15/22 (68%)LINE 1672/3556 (47%)CONDITIONAL 988/2673 (37%) src.plasma.packagestructure FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 7/22 (32%) src.plasma.private FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 923/1644 (56%)CONDITIONAL 431/1064 (41%) src.plasma.scripting FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 14/106 (13%) src.plasmaquick FILES 7/13 (54%)CLASSES 7/13 (54%)LINE 553/1846 (30%)CONDITIONAL 305/1433 (21%) src.plasmaquick.private FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 6/22 (27%) src.scriptengines.qml.plasmoid FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 11/1222 (1%)CONDITIONAL 1/994 (0%)
D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints
This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f48901b05fd: Introduce units.iconSizeHints.* to provide user-configurable icon size hints (authored by hein). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5593?vs=13811=13818 REVISION DETAIL https://phabricator.kde.org/D5593 AFFECTED FILES src/declarativeimports/core/units.cpp src/declarativeimports/core/units.h To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints
hein added a dependent revision: D5595: Configurable icon size. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints
hein added a dependent revision: D5594: Configurable icon size. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5593: Introduce units.iconSizeHints.* to provide user-configurable icon size hints
hein created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY In effect this is meant to resurrect the "Panel" icon size setting from the Icons -> Advanced KCM in System Settings, for use as a ceiling on panel icons to avoid them taking up too much space, especially in wide vertical panels. Previously, the actually-unused "Desktop" size hint was added to the iconSizes map. I believe this was in error, as the size hints are semantically different from the size classes. This patch marks the "desktop" iconSizes map entry as deprecated and makes it available under iconSizeHints instead. The soon-to-be-updated https://phabricator.kde.org/D5592 will demonstrate this API in use. CCBUG:378443 REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5593 AFFECTED FILES src/declarativeimports/core/units.cpp src/declarativeimports/core/units.h To: hein, #plasma, mart Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5556: build: Remove KService dependency
This revision was automatically updated to reflect the committed changes. Closed by commit R268:000dac708604: build: Remove KService dependency (authored by palokisa, committed by ltoscano). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5556?vs=13774=13810 REVISION DETAIL https://phabricator.kde.org/D5556 AFFECTED FILES CMakeLists.txt src/runtime/CMakeLists.txt To: palokisa, graesslin, cfeck, apol Cc: ltoscano, bcooksley, #frameworks
D5556: build: Remove KService dependency
ltoscano added a comment. In https://phabricator.kde.org/D5556#104741, @palokisa wrote: > What's happening here? :) Palo, can you please share your email (here, if you don't mind it being public, or to me on IRC (tosky) or to mail email address luigi dot toscano attheserver tiscali dot it ? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: ltoscano, bcooksley, #frameworks
D5573: Don't accept hover events in the DragArea
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. The FV side does rely on onDragMove firing, which is understand it still does regardless, so +1. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D5573 To: davidedmundson, #plasma, hein Cc: hein, aacid, plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D5556: build: Remove KService dependency
bcooksley added a comment. There was a mistake made when committing this which Luigi and Aleix wanted to fix. The patch itself is fine and does not require any changes - one of them should re-land this patch soon. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: bcooksley, #frameworks
D5556: build: Remove KService dependency
palokisa added a comment. What's happening here? :) REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: bcooksley, #frameworks
D5587: Improvements
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5587 To: apol, #frameworks, leinir
D5556: build: Remove KService dependency
bcooksley reopened this revision. bcooksley added a comment. This revision is now accepted and ready to land. Reopening as the commit has been removed via force push per T5958 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D5556 To: palokisa, graesslin, cfeck, apol Cc: bcooksley, #frameworks
