D6246: Don't rely on QQuickWindow delivering QEvent::Ungrab as mouseUngrabEvent (as it no longer does in Qt 5.8+)

2017-06-16 Thread Eike Hein 
hein created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  QQuickWindow::sendEvent in Qt 5.7 and older had the following code
  to deliver QEvent::UngrabMouse by calling QQuickItem::mouseUngrabEvent:
  
  case QEvent::UngrabMouse: {
  
QSet hasFiltered;
if (!d->sendFilteredMouseEvent(item->parentItem(), item, e, 
&hasFiltered)) {
e->accept();
item->mouseUngrabEvent();
}
}
  
  This is gone from Qt 5.8+. While QEvent::Ungrab is still delivered to
  items, QQuickItem::mouseUngrabEvent is only called under constrained
  circumstances elsewhere, e.g. when ending an actual mouse grab held by
  an item and tracked by Qt.
  
  MouseEventListener relied on mouseUngrabEvent being called to implement
  something akin to MouseArea::canceled: Signaling a user it should clean
  up state after a press event, instead of, say, assuming the button is
  still held and waiting around for a release event. While QEvent::Ungrab
  was already being intercepted as well, it was only done for event de-
  duplication, not used for the above.
  
  This changes the code so handleUngrab checks first whether we're
  actually in press state (to make it safe to call repeatedly) and then
  call it from both the generic event handler and mouseUngrabEvent. This
  makes it work again with newer Qts.
  
  We rely on this particularly in the desktop containment, where we use
  EventGenerator from this same lib to deliver QEvent::Ungrab to applets
  when the containment goes into applet move mode on press-and-hold.
  Without MouseEventListener emiting canceled in response, e.g. moving
  a Folder View applet will e.g. put it into rectangle selection mode
  unwanted.
  BUG:380354

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6246

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp

To: hein, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 23 - Failure!

2017-06-16 Thread Ben Cooksley 
On Sat, Jun 17, 2017 at 6:44 AM, Stephen Kelly  wrote:

>
> Hi Ben,
>

Hi Stephen,


>
> Thanks for looking into this!
>
> From reading your email, it seems that the correct path is in
> GPB_PYTHON3_INCLUDE_DIR, but that is not being added as an include
> directory to compile the code.
>

Yep, that's correct.


>
> From reading the ECM code (FindPythonModuleGeneration.cmake) I don't see
> how that could be. Also, I would expect to see some error message in the
> build failure log about not being able to find sip.h, but I don't see that.
> Maybe it's stripped out or abstracted away? Am I missing something?
>

I've stripped the necessary parts of PyQt and SIP out of the image for now
as it was causing issues for things further up the stack.

One build log which shows the issue is:
https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/24/consoleText


>
> Thanks,
>
> Steve.
>
>
Cheers,
Ben


>
> On 06/13/2017 09:49 AM, Ben Cooksley wrote:
>
> I've investigated this failure.
> It's initial cause was an upgrade of SIP, likely from Neon.
>
> However it has revealed a weakness within the Python bindings code.
> The header sip.h can be found at two places:
>
> /usr/include/python3.5dm/sip.h
> /usr/include/python3.5m/sip.h
>
> It would appear that /usr/include/python3.5m/ needs to be added to the
> compiler include search path.
> A check of CMakeCache.txt shows that GPB_PYTHON3_INCLUDE_DIR contains the
> necessary path in this instance.
>
> Stephen, can you please fix this?
>
> For anyone wanting to investigate such failings, a copy of the full build
> workspace for each failed/unstable job can be found at
> https://build-artifacts.kde.org/production/Workspaces/
>
> Thanks,
> Ben
>
> On Tue, Jun 13, 2017 at 8:42 PM,  wrote:
>
>> *BUILD FAILURE*
>> Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%2
>> 0kf5-qt5%20XenialQt5.7/23/
>> Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7
>> Date of build: Tue, 13 Jun 2017 08:40:43 +
>> Build duration: 1 min 24 sec and counting
>> * CONSOLE OUTPUT *
>> [...truncated 384.25 KB...]
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:73:10:
>> warning: 'virtual bool sipKProcess::waitForReadyRead(int)' can be marked
>> override [-Wsuggest-override]
>> bool waitForReadyRead(int);
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:74:10:
>> warning: 'virtual bool sipKProcess::canReadLine() const' can be marked
>> override [-Wsuggest-override]
>> bool canReadLine() const;
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:75:15:
>> warning: 'virtual qint64 sipKProcess::bytesToWrite() const' can be marked
>> override [-Wsuggest-override]
>> ::qint64 bytesToWrite() const;
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:76:15:
>> warning: 'virtual qint64 sipKProcess::bytesAvailable() const' can be marked
>> override [-Wsuggest-override]
>> ::qint64 bytesAvailable() const;
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:77:10:
>> warning: 'virtual bool sipKProcess::reset()' can be marked override
>> [-Wsuggest-override]
>> bool reset();
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:78:10:
>> warning: 'virtual bool sipKProcess::atEnd() const' can be marked override
>> [-Wsuggest-override]
>> bool atEnd() const;
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:79:10:
>> warning: 'virtual bool sipKProcess::seek(qint64)' can be marked override
>> [-Wsuggest-override]
>> bool seek( ::qint64);
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:80:15:
>> warning: 'virtual qint64 sipKProcess::size() const' can be marked override
>> [-Wsuggest-override]
>> ::qint64 size() const;
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:81:15:
>> warning: 'virtual qint64 sipKProcess::pos() const' can be marked override
>> [-Wsuggest-override]
>> ::qint64 pos() const;
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:82:10:
>> warning: 'virtual void sipKProcess::close()' can be marked override
>> [-Wsuggest-override]
>> void close();
>> ^
>> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
>> Xenia

D6233: KKeyServer: fix handling of KeypadModifier.

2017-06-16 Thread Martin Flöser 
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kkeyserver.cpp:160-180
> +{ Qt::Key_Space,  XK_KP_Space },
> +{ Qt::Key_Tab,XK_KP_Tab },
> +{ Qt::Key_Enter,  XK_KP_Enter },
> +{ Qt::Key_Home,   XK_KP_Home },
> +{ Qt::Key_Left,   XK_KP_Left },
> +{ Qt::Key_Up, XK_KP_Up },
> +{ Qt::Key_Right,  XK_KP_Right },

This looks very unrelated to the described change. Maybe an own commit?

> kkeyserver.cpp:765
>  if (g_rgQtToSymX[i].keySymQt == symQt) {
> +if ((keyQt & Qt::KeypadModifier) && 
> !xcb_is_keypad_key(g_rgQtToSymX[i].keySymX))
> +continue;

xcb_is_keypad_key is not part of any xcb component KWindowSystem looks for.

> kkeyserver.cpp:783
> + int keyModQt = 0;
> + if (symXToKeyQt(keySym, keyQt) && modXToQt(modX, &keyModQt)) {
> + *keyQt |= keyModQt;

why are you calling a deprecated method from a new method?

> kkeyserver_x11.h:150
>   */
> -KWINDOWSYSTEM_EXPORT bool symXToKeyQt(uint sym, int *keyQt);
> +KWINDOWSYSTEM_DEPRECATED_EXPORT bool symXToKeyQt(uint sym, int *keyQt);
> +

if it's getting deprecated it must be wrapped in ifdef, shouldn't it?

> kkeyserver_x11.h:159
> + */
> +KWINDOWSYSTEM_EXPORT bool symXModXToKeyQt(uint keySym, uint modX, int 
> *keyQt);
>  

for new code I would find it better to use the proper types of either uint32_t 
or quint32.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D6233

To: dfaure, graesslin
Cc: graesslin, #frameworks

Re: KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 23 - Failure!

2017-06-16 Thread Stephen Kelly 

Hi Ben,

Thanks for looking into this!

>From reading your email, it seems that the correct path is in
GPB_PYTHON3_INCLUDE_DIR, but that is not being added as an include
directory to compile the code.

>From reading the ECM code (FindPythonModuleGeneration.cmake) I don't see
how that could be. Also, I would expect to see some error message in the
build failure log about not being able to find sip.h, but I don't see
that. Maybe it's stripped out or abstracted away? Am I missing something?

Thanks,

Steve.

On 06/13/2017 09:49 AM, Ben Cooksley wrote:
> I've investigated this failure.
> It's initial cause was an upgrade of SIP, likely from Neon.
>
> However it has revealed a weakness within the Python bindings code.
> The header sip.h can be found at two places:
>
> /usr/include/python3.5dm/sip.h
> /usr/include/python3.5m/sip.h
>
> It would appear that /usr/include/python3.5m/ needs to be added to the
> compiler include search path.
> A check of CMakeCache.txt shows that GPB_PYTHON3_INCLUDE_DIR contains
> the necessary path in this instance.
>
> Stephen, can you please fix this?
>
> For anyone wanting to investigate such failings, a copy of the full
> build workspace for each failed/unstable job can be found
> at https://build-artifacts.kde.org/production/Workspaces/
>
> Thanks,
> Ben
>
> On Tue, Jun 13, 2017 at 8:42 PM,  > wrote:
>
>   *BUILD FAILURE*
> Build URL
> 
> https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/23/
> 
> 
>
> Project:  Frameworks kcoreaddons kf5-qt5 XenialQt5.7
> Date of build:Tue, 13 Jun 2017 08:40:43 +
> Build duration:   1 min 24 sec and counting
>
>
> *CONSOLE OUTPUT *
> [...truncated 384.25 KB...]
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:73:10:
> warning: 'virtual bool sipKProcess::waitForReadyRead(int)' can be
> marked override [-Wsuggest-override]
> bool waitForReadyRead(int);
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:74:10:
> warning: 'virtual bool sipKProcess::canReadLine() const' can be
> marked override [-Wsuggest-override]
> bool canReadLine() const;
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:75:15:
> warning: 'virtual qint64 sipKProcess::bytesToWrite() const' can be
> marked override [-Wsuggest-override]
> ::qint64 bytesToWrite() const;
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:76:15:
> warning: 'virtual qint64 sipKProcess::bytesAvailable() const' can
> be marked override [-Wsuggest-override]
> ::qint64 bytesAvailable() const;
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:77:10:
> warning: 'virtual bool sipKProcess::reset()' can be marked
> override [-Wsuggest-override]
> bool reset();
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:78:10:
> warning: 'virtual bool sipKProcess::atEnd() const' can be marked
> override [-Wsuggest-override]
> bool atEnd() const;
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:79:10:
> warning: 'virtual bool sipKProcess::seek(qint64)' can be marked
> override [-Wsuggest-override]
> bool seek( ::qint64);
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:80:15:
> warning: 'virtual qint64 sipKProcess::size() const' can be marked
> override [-Wsuggest-override]
> ::qint64 size() const;
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:81:15:
> warning: 'virtual qint64 sipKProcess::pos() const' can be marked
> override [-Wsuggest-override]
> ::qint64 pos() const;
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAddonsKProcess.cpp:82:10:
> warning: 'virtual void sipKProcess::close()' can be marked
> override [-Wsuggest-override]
> void close();
> ^
> /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5
> 
> XenialQt5.7/build/src/lib/pybuild/PyKF5/KCoreAddons/sipKCoreAdd

D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys

2017-06-16 Thread Martin Flöser 
graesslin added a comment.


  I need to point out that this creates a functional difference to Wayland and 
according to the latest rules of Plasma such changes are no longer allowed 
unless the implementation is done first for Wayland.
  
  Personally I am not really comfortable with such a large change to X11 
nowadays. The code will be pretty much untested till the release and recent 
changes showed me that this is not a good idea. Especially I am no longer able 
to test the code (that's why I sent a mail to frameworks to step down as 
kglobalaccel maintainer, but so far nobody else stepped up).
  
  So personally I am rather inclined to give you a -1 on it as I just think 
it's too dangerous. The kglobalaccel code is not good, but it works mostly. 
Proper fix will be in Wayland.

INLINE COMMENTS

> kglobalaccel_x11.cpp:278-287
> - if ((keyModQt & Qt::SHIFT) && !KKeyServer::isShiftAsModifierAllowed( 
> keyCodeQt ) ) {
> -#ifdef KDEDGLOBALACCEL_TRACE
> - qCDebug(KGLOBALACCELD) << "removing shift modifier";
> -#endif
> -if (keyCodeQt != Qt::Key_Tab) { // KKeySequenceWidget does not map 
> shift+tab to backtab
> -static const int FirstLevelShift = 1;
> -keySymX = xcb_key_symbols_get_keysym(m_keySymbols, keyCodeX, 
> FirstLevelShift);

The shift handling code has shown regressions whenever it was touched. Also on 
Wayland I needed several tries to get it right. I would prefer if it were not 
touched any more.

This is not as simple as it looks. There are besties out there like 
Alt+Shift+Backtab as a global shortcut and a generic implementation breaks 
quickly there. It is quite likely that this change would break Alt+(Shift)+Tab 
in KWin.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D6234

To: dfaure, graesslin
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 25 - Still unstable!

2017-06-16 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/25/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Fri, 16 Jun 2017 18:24:38 +
 Build duration:
4 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)73%
(6039/8239)43%
(10830/25227)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)97%
(2599/2682)49%
(6620/13503)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(146/384)src.lib67%
(2/3)67%
(2/3)56%
(302/536)22%
(192/893)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(195/1086)src.lib.io90%
(9/10)90%
(9/10)58%
(817/1397)29%
(932/3214)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)86%
(646/748)44%
(1035/2326)src.lib.randomness100%
(2/2)100%
(2/2)67%
(66/99)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)46%
(349/764)40%
(794/1981)src.lib.util100%
(10/10)100%
(10/10)81%
(665/816)50%
(814/1616)

build.log
Description: Binary data

D6215: Make sure size is final after showEvent

2017-06-16 Thread Marco Martin 
mart added a comment.


  In https://phabricator.kde.org/D6215#116837, @mart wrote:
  
  > with patch applied on plasma-framework and notifications applet from master 
all seems to still work ok.
  >
  > so, if i understand correctly, to try with notifiaction applet with your 
https://phabricator.kde.org/D6237 on top, and this patch that keeps updating 
the visibility of the main item.
  
  
  doesn't seem to work on wayland :/

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

2017-06-16 Thread Marco Martin 
mart added a comment.


  with patch applied on plasma-framework and notifications applet from master 
all seems to still work ok.
  
  so, if i understand correctly, to try with notifiaction applet with your 
https://phabricator.kde.org/D6237 on top, and this patch that keeps updating 
the visibility of the main item.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

2017-06-16 Thread David Edmundson 
davidedmundson added a comment.


  Relavent follow up to the unanswer question from yesterday:
  
  why does the implicit height change when we show it
  
  It's from some code in NotificationItem.qml
  
ColumnLayout {
id: mainLayout
anchors {
 left: appIconItem.visible || imageItem.visible ? appIconItem.right 
: parent.left
  
  This changes when we show the popup, the width available show the text, that 
changes the implicitHeight of the dialog, which changes the actual height.
  
  I /think/ changing them to check whether the image is loaded rather than 
visible will fix that issue.
  I commented it out and gammaray no longer shows the implicitHeight changing

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

D6215: Make sure size is final after showEvent

2017-06-16 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Ok so in summary there's two changes here:
  
  - updating our window geometry regardless of whether we're visible or not
  
  Makes total sense, there's no bandwidth overhead the platform won't send 
anything if the window isn't mapped; but it means it has the right info for 
when we want it.
  
  - not setting mainItem to invisible when the dialog is hidden.
  
  We can see in gammaray all the contents now think they're visible. I'm quite 
wary of this as it was added for a reason.
  
  The window doesn't render but we do have some code paths that release 
resources, and I'm pretty sure Animations (not Animators) will continue running.
  
  ---
  
  But most crucially with this patch I don't get notifications (running 
unpatched p-w on XCB ) 
  Can you test that combo please.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 24 - Still Failing!

2017-06-16 Thread no-reply 
BUILD FAILURE
 Build URL
https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/24/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Fri, 16 Jun 2017 11:33:58 +
 Build duration:
3 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 219.27 KB...] aboutData.setProgramIconName(programIconName); ^In file included from /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5 XenialQt5.7/autotests/kaboutdatatest.cpp:20:0:/home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5 XenialQt5.7/src/lib/kaboutdata.h:663:40: note: declared here KCOREADDONS_DEPRECATED KAboutData &setProgramIconName(const QString &iconName); // KF6 remove this^[ 75%] Building CXX object autotests/CMakeFiles/multiplugin.dir/multiplugin_automoc.cpp.o[ 75%] Linking CXX shared module alwaysunloadplugin.so[ 75%] Linking CXX shared module jsonplugin.so[ 76%] Building CXX object autotests/CMakeFiles/kaboutdatatest.dir/kaboutdatatest_automoc.cpp.o[ 76%] Linking CXX executable kaboutdatatest[ 77%] Building CXX object autotests/CMakeFiles/kpluginmetadatatest.dir/kpluginmetadatatest_automoc.cpp.o[ 77%] Built target jsonplugin[ 77%] Built target kaboutdatatest[ 77%] Built target alwaysunloadplugin[ 77%] Linking CXX executable kpluginmetadatatest[ 78%] Linking CXX shared module multiplugin.so[ 78%] Building CXX object autotests/CMakeFiles/kdirwatch_inotify_unittest.dir/kdirwatch_inotify_unittest_automoc.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/kformattest.dir/kformattest_automoc.cpp.o[ 79%] Built target kpluginmetadatatest[ 80%] Linking CXX executable kdirwatch_inotify_unittest[ 80%] Built target multiplugin[ 80%] Built target kdirwatch_inotify_unittest[ 80%] Linking CXX executable kformattest[ 80%] Built target kformattestScanning dependencies of target kurlmimedatatest[ 81%] Building CXX object autotests/CMakeFiles/kurlmimedatatest.dir/kurlmimedatatest.cpp.o[ 81%] Building CXX object autotests/CMakeFiles/kurlmimedatatest.dir/kurlmimedatatest_automoc.cpp.o[ 82%] Linking CXX executable kurlmimedatatest[ 82%] Built target kurlmimedatatestScanning dependencies of target kstringhandlertest[ 83%] Building CXX object autotests/CMakeFiles/kstringhandlertest.dir/kstringhandlertest.cpp.oScanning dependencies of target krandomtest[ 84%] Building CXX object autotests/CMakeFiles/krandomtest.dir/krandomtest.cpp.oScanning dependencies of target kdirwatchtest_gui[ 84%] Building CXX object tests/CMakeFiles/kdirwatchtest_gui.dir/kdirwatchtest_gui.cpp.oScanning dependencies of target kprocesstestScanning dependencies of target kpluginloadertest[ 85%] Building CXX object autotests/CMakeFiles/kprocesstest.dir/kprocesstest.cpp.o[ 85%] Building CXX object autotests/CMakeFiles/kpluginloadertest.dir/kpluginloadertest.cpp.o[ 85%] Building CXX object autotests/CMakeFiles/kstringhandlertest.dir/kstringhandlertest_automoc.cpp.oScanning dependencies of target kpluginfactorytestScanning dependencies of target kshelltest[ 86%] Building CXX object autotests/CMakeFiles/kshelltest.dir/kshelltest.cpp.o[ 86%] Building CXX object autotests/CMakeFiles/kpluginfactorytest.dir/kpluginfactorytest.cpp.oScanning dependencies of target kjobtest[ 86%] Building CXX object autotests/CMakeFiles/kjobtest.dir/kjobtest.cpp.o[ 87%] Linking CXX executable kstringhandlertest[ 87%] Built target kstringhandlertest[ 87%] Building CXX object autotests/CMakeFiles/krandomtest.dir/krandomtest_automoc.cpp.o[ 88%] Linking CXX executable krandomtestScanning dependencies of target faceicontest[ 89%] Building CXX object tests/CMakeFiles/faceicontest.dir/faceicontest.cpp.o[ 90%] Building CXX object tests/CMakeFiles/kdirwatchtest_gui.dir/kdirwatchtest_gui_automoc.cpp.o[ 90%] Built target krandomtest[ 91%] Building CXX object autotests/CMakeFiles/kpluginloadertest.dir/kpluginloadertest_automoc.cpp.o[ 91%] Linking CXX executable kpluginloadertest[ 91%] Built target kpluginloadertest[ 92%] Building CXX object autotests/CMakeFiles/kpluginfactorytest.dir/kpluginfactorytest_automoc.cpp.o[ 92%] Linking CXX executable kpluginfactorytest[ 92%] Building CXX object autotests/CMakeFiles/kprocesstest.dir/kprocesstest_automoc.cpp.o[ 93%] Linking CXX executable kprocesstest[ 93%] Built target kpluginfactorytest[ 93%] Linking CXX executable kdirwatchtest_gui[ 93%] Built target kprocesstest[ 94%] Building CXX object autotests/CMakeFiles/kjobtest.dir/kjobtest_automoc.cpp.o[ 94%] Linking CXX executable kjobtest[ 94%] Built target kdirwatchtest_gui[ 94%] Building CXX object autotests/CMakeFiles/kshelltest.dir/kshelltest_automoc.cpp.o[ 95%] Linking CXX executable kshelltest[ 95%] Built target kjobtest[ 95%] Built target kshelltest[ 95%] Building CXX object tests/CMakeFiles/faceicontest.dir/faceicontest_automoc.cpp.o[ 96%] Linking CXX executable faceicontest[ 96%] Built target faceicontestScanning dependencies of target Py2KF5KCoreAddons[ 97

D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys

2017-06-16 Thread David Faure 
dfaure created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This commit requires KF 5.36.
  
  BUG: 183458

TEST PLAN
  the following global shortcuts were successfully tested:
  Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift)

REPOSITORY
  R268 KGlobalAccel

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6234

AFFECTED FILES
  src/runtime/plugins/xcb/kglobalaccel_x11.cpp

To: dfaure, graesslin
Cc: #frameworks

D6226: KKeySequenceWidget: make it possible to record Ctrl+Num+1 as a shortcut.

2017-06-16 Thread David Faure 
dfaure closed this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D6226

To: dfaure, aacid
Cc: apol, #frameworks

D6233: KKeyServer: fix handling of KeypadModifier.

2017-06-16 Thread David Faure 
dfaure created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This required adding a new method symXModXToKeyQt since
  symXToKeyQt (without modifier as input) has no way to find out
  whether to use XK_KP_1 or XK_1. For this reason symXToKeyQt is now
  deprecated.
  
  Includes a unittest for keyQtToSymX, keyQtToModX and symXModXToKeyQt.
  
  CCBUG: 183458

TEST PLAN
  After porting kglobalaccel to KKeyServer::xcbKeyPressEventToQt,
  the following global shortcuts were successfully tested:
  Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift)

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6233

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kkeyserver_x11_unittest.cpp
  src/platforms/xcb/kkeyserver.cpp
  src/platforms/xcb/kkeyserver_x11.h

To: dfaure
Cc: #frameworks