KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 44 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/44/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 05 Aug 2017 02:45:47 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
KDE CI: Frameworks kdesignerplugin kf5-qt5 WindowsQt5.7 - Build # 12 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20WindowsQt5.7/12/ Project: Frameworks kdesignerplugin kf5-qt5 WindowsQt5.7 Date of build: Fri, 04 Aug 2017 21:30:53 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) build.log Description: Binary data
D7142: Fix proxy KCM not loading manual proxies correctly.
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7142 To: dfaure, dmariano, davidedmundson Cc: #frameworks
D7127: ignore spurious resize events to empty sizes
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > on multiscreen systems, the notification dialog gets resized to 0x0 > by someone else (either kwin, notification applet or Qt code) So which is it? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma, davidedmundson Cc: davidedmundson, broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6834: [KNewFileMenu] Enable creating new files in read-only folders
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6834 To: chinmoyr, dfaure Cc: #frameworks
D6831: Make use of kauth helper in methods of file ioslave
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Please resubmit with context.
Also, did you check that unittests still pass? No kauth prompt should occur
:-)
INLINE COMMENTS
> file.cpp:242
> #if defined(ENOTSUP)
> -case ENOTSUP: // from setACL since chmod can't return ENOTSUP
> -error(KIO::ERR_UNSUPPORTED_ACTION, i18n("Setting ACL for %1",
> path));
> -break;
> +case ENOTSUP: // fro setACL since chmod can't return ENOTSUP
> +error(KIO::ERR_UNSUPPORTED_ACTION, i18n("Setting ACL for
> %1", path));
the 'm' in "from" was actually good looking there :)
> file.cpp:296
> +if (!dirCreated)
> +dirCreated = execWithElevatedPrivilege(errno, MKDIR, path);
> +
Picking this random one as an example:
- what happens if the user cancels the root-password prompt? He will then get
another msg box with "cannot create directory?" even though he/she purposefully
canceled the operation? When that happens the slave should use
error(KIO::ERR_USER_CANCELED) instead (which means no error box), but of course
only in that case...
> file.cpp:629
>
> +
> if ((_flags & KIO::Resume)) {
remove new empty line, there's already one
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6831
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
D6829: Add ability to use the new kauth helper in file ioslave
dfaure added inline comments.
INLINE COMMENTS
> file_unix.cpp:659
> +{
> +if (error != EACCES || !isPrivilegeOperationAllowed()) {
> +return false;
with EPERM we should try as root too, no?
(e.g. for unlink, rename, chown...)
REVISION DETAIL
https://phabricator.kde.org/D6829
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
D6830: Make use of kauth helper in copy method of file ioslave
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
The diff has no context in phabricator, which is a problem for this one (e.g.
for the "do we need this here?" questions). Can you upload the update using
`arc diff` for example?
INLINE COMMENTS
> file_unix.cpp:126
> +if (!execWithElevatedPrivilege(errno, DEL, _dest))
> +error(KIO::ERR_CANNOT_DELETE_ORIGINAL, dest);
> +}
Missing "return;" no?
> file_unix.cpp:176
> +if (!execWithElevatedPrivilege(errno, CHOWN, buff_src.st_uid,
> buff_src.st_gid)) {
> +error(KIO::ERR_CANNOT_CHOWN, dest);
> +}
missing return;
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6830
To: chinmoyr, dfaure, #frameworks
Cc: elvisangelaccio, #frameworks
D6706: Fix empty string when change the Proxy SOCKS address
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Urls without schemes shouldn't really happen, so this fix doesn't make me too happy. I debugged this KCM a bit and it seems the issue is the commit that prepends a scheme (like socks://) which interfers with the assumption that after the first ':' comes the port. The KCM works for me with this alternative fix, can you test? https://phabricator.kde.org/D7142 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6706 To: dmariano, dfaure Cc: dfaure, #frameworks
D7142: Fix proxy KCM not loading manual proxies correctly.
dfaure created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY commit https://phabricator.kde.org/R241:4e2a52c67167507b62553ca595bb561b925dc440 prepends a scheme (like socks://), which interfers with the assumption that after the first ':' comes the port. But we can use QUrl parsing to extract the port number, instead. TEST PLAN kcmshell5 proxy, setting manual proxy values, OK, kcmshell5 proxy REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7142 AFFECTED FILES src/kcms/kio/kproxydlg.cpp To: dfaure, dmariano Cc: #frameworks
D7136: Don't use find_file for finding files in our own source dir
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY It's not necessary, and it breaks when cross-compiling, as find_file changes its behavior then. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 AFFECTED FILES src/runtime/kwalletd/CMakeLists.txt To: vkrause, #frameworks
D7118: Add KPeople recipe
vkrause updated this revision to Diff 17727. vkrause added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Fix homepage URL REPOSITORY R868 Yocto: KDE Frameworks Packaging CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7118?vs=17663=17727 BRANCH kpeople REVISION DETAIL https://phabricator.kde.org/D7118 AFFECTED FILES recipes-kf5/tier3/kpeople.inc recipes-kf5/tier3/kpeople_5.36.0.bb To: vkrause, cordlandwehr Cc: #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. BUG: 369646 REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a reviewer: elvisangelaccio. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi updated this revision to Diff 17723. gregormi edited the summary of this revision. gregormi added a comment. - add FSearch and AngrySearch to search tools - Add new grouping "screenrecorder" with Peek and Simples Screen Recorder - Add new grouping "mouse-tools" - Add new grouping "font-tools" - Add new grouping "language-dictionary" REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7130?vs=17710=17723 BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/angrysearch.desktop data/kmoretools-desktopfiles/catfish.desktop data/kmoretools-desktopfiles/com.uploadedlobster.peek.desktop data/kmoretools-desktopfiles/ding.desktop data/kmoretools-desktopfiles/disk.desktop data/kmoretools-desktopfiles/filelight.png data/kmoretools-desktopfiles/filelight.svg data/kmoretools-desktopfiles/fontinst.desktop data/kmoretools-desktopfiles/fontmatrix.desktop data/kmoretools-desktopfiles/fsearch.desktop data/kmoretools-desktopfiles/giggle.desktop data/kmoretools-desktopfiles/git-cola-folder-handler.desktop data/kmoretools-desktopfiles/git-cola.desktop data/kmoretools-desktopfiles/gitg.desktop data/kmoretools-desktopfiles/gnome-search-tool.desktop data/kmoretools-desktopfiles/gparted.desktop data/kmoretools-desktopfiles/gucharmap.desktop data/kmoretools-desktopfiles/htop.desktop data/kmoretools-desktopfiles/kdf.desktop data/kmoretools-desktopfiles/kding.desktop data/kmoretools-desktopfiles/kmousetool.desktop data/kmoretools-desktopfiles/ksystemlog.desktop data/kmoretools-desktopfiles/org.gnome.clocks.desktop data/kmoretools-desktopfiles/org.kde.KCharSelect.desktop data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop data/kmoretools-desktopfiles/org.kde.filelight.desktop data/kmoretools-desktopfiles/org.kde.kdf.desktop data/kmoretools-desktopfiles/org.kde.kfind.desktop data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop data/kmoretools-desktopfiles/org.kde.ksysguard.desktop data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop data/kmoretools-desktopfiles/org.kde.ktimer.desktop data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop data/kmoretools-desktopfiles/org.kde.spectacle.desktop data/kmoretools-desktopfiles/shutter.desktop data/kmoretools-desktopfiles/shutter.svg data/kmoretools-desktopfiles/simplescreenrecorder.desktop data/kmoretools-desktopfiles/xfce4-taskmanager.desktop src/kmoretools/kmoretoolspresets.cpp src/kmoretools/kmoretoolspresets.h tests/kmoretools/kmoretoolstest2.cpp tests/kmoretools/kmoretoolstest_interactive.cpp To: gregormi, ltoscano Cc: ltoscano, #frameworks
D6994: Allow to build KConfig without Qt5Gui
This revision was automatically updated to reflect the committed changes. Closed by commit R237:ba75a6c6a023: Allow to build KConfig without Qt5Gui (authored by vkrause). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6994?vs=17588=17722 REVISION DETAIL https://phabricator.kde.org/D6994 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt src/CMakeLists.txt src/core/CMakeLists.txt src/gui/CMakeLists.txt src/kconf_update/CMakeLists.txt src/kconfig_compiler/CMakeLists.txt To: vkrause, #frameworks, apol, aacid Cc: aacid
D7103: Allow to build KSyntaxHighlighter without Qt5Gui
This revision was automatically updated to reflect the committed changes. Closed by commit R216:703b48665f3d: Allow to build KSyntaxHighlighter without Qt5Gui (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7103?vs=17646=17721 REVISION DETAIL https://phabricator.kde.org/D7103 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt To: vkrause, #frameworks, kfunk Cc: kfunk
D7102: Add cross-compilation support for the highlighting indexer
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e7dcacfe64bf: Add cross-compilation support for the highlighting indexer (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7102?vs=17645=17720 REVISION DETAIL https://phabricator.kde.org/D7102 AFFECTED FILES src/indexer/CMakeLists.txt To: vkrause, #frameworks, kfunk Cc: kfunk
KDE CI: Frameworks kdesignerplugin kf5-qt5 XenialQt5.7 - Build # 8 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20XenialQt5.7/8/
Project:
Frameworks kdesignerplugin kf5-qt5 XenialQt5.7
Date of build:
Fri, 04 Aug 2017 16:23:48 +
Build duration:
2 min 25 sec and counting
CONSOLE OUTPUT
[...truncated 85.69 KB...][Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kdesignerplugin kf5-qt5 XenialQt5.7] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kdesignerplugin --branchGroup kf5-qt5 --platform XenialQt5.7 --usingInstall /home/jenkins/install-prefix/Scanning dependencies of target docs-kgendesignerplugin-kgendesignerplugin-1[ 2%] Generating kgendesignerplugin.1Note: Writing kgendesignerplugin.1[ 2%] Built target docs-kgendesignerplugin-kgendesignerplugin-1Scanning dependencies of target testplugin_automoc[ 4%] Automatic moc for target testplugin[ 4%] Built target testplugin_automocScanning dependencies of target minimalplugin_automoc[ 6%] Automatic moc for target minimalplugin[ 6%] Built target minimalplugin_automocScanning dependencies of target plugintest_automoc[ 9%] Automatic moc for target plugintestGenerating plugintest.moc[ 9%] Built target plugintest_automocScanning dependencies of target minimaltest_automoc[ 11%] Automatic moc for target minimaltestGenerating minimaltest.moc[ 11%] Built target minimaltest_automocScanning dependencies of target plugintest[ 13%] Building CXX object autotests/CMakeFiles/plugintest.dir/plugintest.cpp.o[ 15%] Building CXX object autotests/CMakeFiles/plugintest.dir/plugintest_automoc.cpp.o[ 18%] Linking CXX executable plugintest[ 18%] Built target plugintestScanning dependencies of target kf5widgets_automocScanning dependencies of target kdewebkitwidgets_automoc[ 20%] Automatic moc for target kf5widgets[ 22%] Automatic moc for target kdewebkitwidgetsScanning dependencies of target minimaltest[ 25%] Building CXX object autotests/CMakeFiles/minimaltest.dir/minimaltest_automoc.cpp.o[ 27%] Building CXX object autotests/CMakeFiles/minimaltest.dir/minimaltest.cpp.o[ 27%] Built target kf5widgets_automoc[ 27%] Built target kdewebkitwidgets_automocScanning dependencies of target kgendesignerplugin_automoc[ 29%] Automatic moc for target kgendesignerplugin[ 29%] Built target kgendesignerplugin_automocScanning dependencies of target kgendesignerplugin[ 31%] Building CXX object src/CMakeFiles/kgendesignerplugin.dir/ECMQmLoader-kdesignerplugin5_qt.cpp.o[ 34%] Building CXX object src/CMakeFiles/kgendesignerplugin.dir/kgendesignerplugin.cpp.o[ 36%] Building CXX object src/CMakeFiles/kgendesignerplugin.dir/kgendesignerplugin_automoc.cpp.o[ 38%] Linking CXX executable kgendesignerplugin[ 38%] Built target kgendesignerplugin[ 40%] Linking CXX executable minimaltest[ 40%] Built target minimaltest[ 43%] Generating minimalwidgets.cpp[ 45%] Generating minimalwidgets.mocScanning dependencies of target minimalplugin[ 47%] Building CXX object autotests/CMakeFiles/minimalplugin.dir/minimalwidgets.cpp.o[ 50%] Building CXX object autotests/CMakeFiles/minimalplugin.dir/minimalplugin_automoc.cpp.o[ 52%] Linking CXX shared module minimalplugin.so[ 52%] Built target minimalplugin[ 54%] Generating qrc_testplugin.cpp[ 56%] Generating testpluginwidgets.cpp[ 59%] Generating testpluginwidgets.mocScanning dependencies of target testplugin[ 61%] Building CXX object autotests/CMakeFiles/testplugin.dir/testpluginwidgets.cpp.o[ 63%] Building CXX object autotests/CMakeFiles/testplugin.dir/testplugin_automoc.cpp.o[ 65%] Building CXX object autotests/CMakeFiles/testplugin.dir/qrc_testplugin.cpp.o[ 68%] Linking CXX shared module testplugin.so[ 68%] Built target testplugin[ 70%] Generating qrc_kdewebkitwidgets.cppRCC: Warning: No resources in '/home/jenkins/workspace/Frameworks kdesignerplugin kf5-qt5 XenialQt5.7/src/kdewebkitwidgets.qrc'.[ 72%] Generating kdewebkitwidgets.cpp[ 75%] Generating kdewebkitwidgets.mocScanning dependencies of target kdewebkitwidgets[ 77%] Building CXX object src/CMakeFiles/kdewebkitwidgets.dir/kdewebkitwidgets.cpp.o[ 79%] Building CXX object src/CMakeFiles/kdewebkitwidgets.dir/kdewebkitwidgets_automoc.cpp.o[ 81%] Building CXX object src/CMakeFiles/kdewebkitwidgets.dir/qrc_kdewebkitwidgets.cpp.o[ 84%] Linking CXX shared module kdewebkit5widgets.so[ 84%] Built target kdewebkitwidgets[ 86%] Generating qrc_kdewidgets.cpp[ 88%] Generating kdewidgets.cpp[ 90%] Generating kdewidgets.mocScanning dependencies of target kf5widgets[ 93%] Building CXX object src/CMakeFiles/kf5widgets.dir/kdewidgets.cpp.o/home/jenkins/workspace/Frameworks kdesignerplugin kf5-qt5 XenialQt5.7/build/src/kdewidgets.cpp:37:31: fatal error: kpasswordlineedit.h: No such file or directorycompilation terminated.src/CMakeFiles/kf5widgets.dir/build.make:103: recipe for target 'src/CMakeFiles/kf5widgets.dir/kdewidgets.cpp.o' failedmake[2]: *** [src/CMakeFiles/kf5widgets.dir/kdewidgets.cpp.o] Error 1CMakeFiles/Makefile2:269: recipe
KDE CI: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.7 - Build # 8 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20FreeBSDQt5.7/8/ Project: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 04 Aug 2017 16:23:48 + Build duration: 1 min 6 sec and counting CONSOLE OUTPUT [...truncated 73.89 KB...]Scanning dependencies of target docs-kgendesignerplugin-kgendesignerplugin-1Scanning dependencies of target kdewebkitwidgets_autogenScanning dependencies of target plugintest_autogenScanning dependencies of target kgendesignerplugin_autogenScanning dependencies of target minimaltest_autogen[ 2%] Automatic MOC for target kf5widgets[ 4%] Automatic MOC for target plugintest[ 6%] Generating kgendesignerplugin.1[ 9%] Automatic MOC for target kdewebkitwidgets[ 11%] Automatic MOC for target kgendesignerplugin[ 13%] Automatic MOC for target minimaltestGenerating MOC compilation kf5widgets_autogen/moc_compilation.cppGenerating MOC compilation kdewebkitwidgets_autogen/moc_compilation.cppGenerating MOC compilation kgendesignerplugin_autogen/moc_compilation.cpp[ 13%] Built target kf5widgets_autogen[ 13%] Built target kdewebkitwidgets_autogen[ 13%] Built target kgendesignerplugin_autogenScanning dependencies of target minimalplugin_autogenScanning dependencies of target testplugin_autogen[ 15%] Automatic MOC for target minimalplugin[ 18%] Automatic MOC for target testpluginGenerating MOC compilation testplugin_autogen/moc_compilation.cppGenerating MOC compilation minimalplugin_autogen/moc_compilation.cpp[ 18%] Built target testplugin_autogen[ 18%] Built target minimalplugin_autogenScanning dependencies of target kgendesignerplugin[ 25%] Building CXX object src/CMakeFiles/kgendesignerplugin.dir/kgendesignerplugin_autogen/moc_compilation.cpp.o[ 25%] Building CXX object src/CMakeFiles/kgendesignerplugin.dir/ECMQmLoader-kdesignerplugin5_qt.cpp.o[ 25%] Building CXX object src/CMakeFiles/kgendesignerplugin.dir/kgendesignerplugin.cpp.oGenerating MOC source plugintest_autogen/include/plugintest.mocGenerating MOC compilation plugintest_autogen/moc_compilation.cppGenerating MOC source minimaltest_autogen/include/minimaltest.mocGenerating MOC compilation minimaltest_autogen/moc_compilation.cpp[ 25%] Built target minimaltest_autogen[ 25%] Built target plugintest_autogenScanning dependencies of target plugintestScanning dependencies of target minimaltest[ 27%] Building CXX object autotests/CMakeFiles/plugintest.dir/plugintest_autogen/moc_compilation.cpp.o[ 29%] Building CXX object autotests/CMakeFiles/plugintest.dir/plugintest.cpp.o[ 31%] Building CXX object autotests/CMakeFiles/minimaltest.dir/minimaltest.cpp.o[ 34%] Building CXX object autotests/CMakeFiles/minimaltest.dir/minimaltest_autogen/moc_compilation.cpp.oNote: Writing kgendesignerplugin.1[ 36%] Linking CXX executable kgendesignerplugin[ 36%] Built target docs-kgendesignerplugin-kgendesignerplugin-1[ 36%] Built target kgendesignerplugin[ 38%] Linking CXX executable plugintest[ 43%] Generating minimalwidgets.cpp[ 43%] Generating qrc_kdewebkitwidgets.cpp[ 45%] Generating qrc_kdewidgets.cpp[ 47%] Generating qrc_testplugin.cppRCC: Warning: No resources in '/usr/home/jenkins/workspace/Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.7/src/kdewebkitwidgets.qrc'.[ 50%] Generating kdewebkitwidgets.cpp[ 52%] Generating testpluginwidgets.cpp[ 54%] Generating minimalwidgets.moc[ 59%] Generating kdewebkitwidgets.moc[ 59%] Generating kdewidgets.cpp[ 61%] Generating testpluginwidgets.moc[ 63%] Generating kdewidgets.mocScanning dependencies of target minimalplugin[ 65%] Building CXX object autotests/CMakeFiles/minimalplugin.dir/minimalwidgets.cpp.o[ 68%] Linking CXX executable minimaltestScanning dependencies of target kdewebkitwidgets[ 70%] Building CXX object src/CMakeFiles/kdewebkitwidgets.dir/kdewebkitwidgets.cpp.oScanning dependencies of target testplugin[ 70%] Built target plugintest[ 72%] Building CXX object src/CMakeFiles/kdewebkitwidgets.dir/qrc_kdewebkitwidgets.cpp.o[ 75%] Building CXX object autotests/CMakeFiles/testplugin.dir/testpluginwidgets.cpp.o[ 77%] Building CXX object src/CMakeFiles/kdewebkitwidgets.dir/kdewebkitwidgets_autogen/moc_compilation.cpp.o[ 79%] Building CXX object autotests/CMakeFiles/minimalplugin.dir/minimalplugin_autogen/moc_compilation.cpp.o[ 81%] Building CXX object autotests/CMakeFiles/testplugin.dir/qrc_testplugin.cpp.o[ 84%] Building CXX object autotests/CMakeFiles/testplugin.dir/testplugin_autogen/moc_compilation.cpp.oScanning dependencies of target kf5widgets[ 86%] Building CXX object src/CMakeFiles/kf5widgets.dir/qrc_kdewidgets.cpp.o[ 88%] Building CXX object src/CMakeFiles/kf5widgets.dir/kdewidgets.cpp.o[ 90%] Building CXX object src/CMakeFiles/kf5widgets.dir/kf5widgets_autogen/moc_compilation.cpp.o[ 90%] Built target minimaltest[ 93%] Linking CXX shared module minimalplugin.so[ 95%] Linking CXX shared module testplugin.so[ 97%] Linking CXX shared module kdewebkit5widgets.so[ 97%] Built target
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132409, @ltoscano wrote: > Just update the English messages. > More generally, why do we need copies of the system desktop files (even the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use the existing desktop files if installed? We don't want to duplicate what exists. KMoreTools provides information about applications (gives hints about their existence) that are maybe not installed yet. Back then, the idea was to reuse the translations in the desktop files. Do the duplicate desktop files cause duplicate translation work? Personally, I also find the desktop file handling a bit clumsy, but currently I have no better idea. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
ltoscano added a comment. Just update the English messages. More generally, why do we need copies of the system desktop files (even the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use the existing desktop files if installed? We don't want to duplicate what exists. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7127: ignore spurious resize events to empty sizes
mart updated this revision to Diff 17712. mart added a comment. - fix check REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7127?vs=17704=17712 BRANCH arcpatch-D7127 REVISION DETAIL https://phabricator.kde.org/D7127 AFFECTED FILES src/plasmaquick/dialog.cpp To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132397, @ltoscano wrote: > I think there is more than what you want: the translations of desktop are handled automatically by scripty. Thanks for the hint. I copied the desktop files from the system installation. I know that translations are updated automatically. But what should be done (i.e. remove the translations manually before checkin)? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7127: ignore spurious resize events to empty sizes
mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > broulik wrote in dialog.cpp:1045 > So it will never update its size? Shouldn't it be size == oldSize? ouch, sure, sorry :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7127 To: mart, #plasma Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7130: Update and fix desktopfiles
ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. I think there is more than what you want: the translations of desktop are handled automatically by scripty. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi retitled this revision from "Update and fix desktopfiles" to "KMoreTools: Update and fix desktopfiles". gregormi edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: Update and fix desktopfiles
gregormi created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/catfish.desktop data/kmoretools-desktopfiles/disk.desktop data/kmoretools-desktopfiles/filelight.png data/kmoretools-desktopfiles/filelight.svg data/kmoretools-desktopfiles/giggle.desktop data/kmoretools-desktopfiles/git-cola-folder-handler.desktop data/kmoretools-desktopfiles/git-cola.desktop data/kmoretools-desktopfiles/gitg.desktop data/kmoretools-desktopfiles/gnome-search-tool.desktop data/kmoretools-desktopfiles/gparted.desktop data/kmoretools-desktopfiles/htop.desktop data/kmoretools-desktopfiles/kdf.desktop data/kmoretools-desktopfiles/ksystemlog.desktop data/kmoretools-desktopfiles/org.gnome.clocks.desktop data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop data/kmoretools-desktopfiles/org.kde.filelight.desktop data/kmoretools-desktopfiles/org.kde.kdf.desktop data/kmoretools-desktopfiles/org.kde.kfind.desktop data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop data/kmoretools-desktopfiles/org.kde.ksysguard.desktop data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop data/kmoretools-desktopfiles/org.kde.ktimer.desktop data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop data/kmoretools-desktopfiles/org.kde.spectacle.desktop data/kmoretools-desktopfiles/shutter.desktop data/kmoretools-desktopfiles/shutter.svg data/kmoretools-desktopfiles/xfce4-taskmanager.desktop src/kmoretools/kmoretoolspresets.cpp tests/kmoretools/kmoretoolstest2.cpp tests/kmoretools/kmoretoolstest_interactive.cpp To: gregormi Cc: #frameworks
D6820: Add QValidator to KTimeCombobox
kfunk added inline comments. INLINE COMMENTS > ktimecombobox.cpp:33 > +public: > +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR); > +KTimeValidator(QString timeFormat, QTime min, QTime max, QObject *parent > = Q_NULLPTR); Here and below: `nullptr` can be used directly in KF5 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6820 To: bednar, cfeck Cc: kfunk, cfeck, #frameworks
D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one
matank added a comment. I can confrim that mart's patch ( https://phabricator.kde.org/D7127) solves the issue. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: matank, #plasma, davidedmundson Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D7127: ignore spurious resize events to empty sizes
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:1045
>
> +if (re->size().isEmpty() || re->size() != re->oldSize()) {
> +return;
So it will never update its size? Shouldn't it be size == oldSize?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7127
To: mart, #plasma
Cc: broulik, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6964: Force Plasma style for QQC2 in applets
mart updated this revision to Diff 17706. mart added a comment. remove unrelated changes REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17703=17706 BRANCH arcpatch-D6964 REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED FILES src/plasmaquick/appletquickitem.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/view.cpp To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one
mart added a comment. looking into it, i still think the dialog code is correct. what happens is that someone external resizes the notification window to 0x0 pixels wide right after the componentcomplete event. if as in this patch the dialog is resized explicitly in componentcomplete, that other spurious resize (from 0x0 to 0x0 btw) doesn't happen anymore even tough I am still not sure where that resize event comes from (feeling like blaming either windowmanagement tough is weird as is still unmapped or qt xcb), I think a more correct patch, is https://phabricator.kde.org/D6964 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: matank, #plasma, davidedmundson Cc: mart, plasma-devel, davidedmundson, ltoscano, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
D6964: Force Plasma style for QQC2 in applets
mart updated this revision to Diff 17703. mart added a comment. ignore resizes to empty sizes on multiscreen, it happens that notification windows areresized to 0,0 by somebody else (not dialog code, perhaps kwin, perhaps notification applet this makes the notification main item lose track of its natural geometry causing bug 382340 ignore those events as spurious (and resizing a window to 0x0 doesn't make sense anyways) with this, notifications on multi monitor systems with primary on the right are ok BUG:382340 REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6964?vs=17325=17703 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6964 AFFECTED FILES src/plasmaquick/appletquickitem.cpp src/plasmaquick/dialog.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/view.cpp To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D7085: Fix issue where notifications will show as 1 pixel line
mart added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7085 To: davidedmundson, #plasma Cc: #frameworks
