KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 - Build # 33 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.9/33/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 17 Nov 2017 04:04:57 + Build duration: 2 hr 21 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kmoretoolstest
D8782: add *.email to the extensions
genethomas added a comment. I can not commit. Can you please arrange access for myself? $git push fatal: remote error: service not enabled: /syntax-highlighting REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8782 To: genethomas, vkrause, dhaumann Cc: dhaumann, vkrause, #frameworks
D8811: [knewstuff] Do not leak ImageLoader on error
This revision was automatically updated to reflect the committed changes. Closed by commit R304:ab6a48778bbe: [knewstuff] Do not leak ImageLoader on error (authored by anthonyfieroni). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8811?vs=22408=22501 REVISION DETAIL https://phabricator.kde.org/D8811 AFFECTED FILES src/core/engine.cpp src/core/imageloader.cpp src/core/imageloader_p.h To: anthonyfieroni, leinir, dfaure Cc: broulik, #frameworks, ZrenBot
D8858: Fix testWaylandFullscreenShell.
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Could you please add a message that it is missing? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8173: Use readelf to find project dependencies
apol updated this revision to Diff 22498. apol added a comment. Added "" around a variable that may contain ; REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8173?vs=22496=22498 BRANCH arcpatch-D8173_1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D8173 AFFECTED FILES tests/CMakeLists.txt tests/ECMToolchainAndroidTest/CMakeLists.txt tests/ECMToolchainAndroidTest/main.c tests/ECMToolchainAndroidTest/testlinkfile/CMakeFiles/testtarget.dir/link.txt tests/ECMToolchainAndroidTest/testlinkfile/outputfake.json toolchain/Android.cmake toolchain/specifydependencies.cmake To: apol, #frameworks, #build_system, aacid Cc: mart
D8173: Use readelf to find project dependencies
apol updated this revision to Diff 22496. apol added a comment. Pass LANG=C to readelf so it doesn't appear in catalan (or anything other than C) and pass ECM_ADDITIONAL_FIND_ROOT_PATH to look for dependencies REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8173?vs=21777=22496 BRANCH arcpatch-D8173_1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D8173 AFFECTED FILES tests/CMakeLists.txt tests/ECMToolchainAndroidTest/CMakeLists.txt tests/ECMToolchainAndroidTest/main.c tests/ECMToolchainAndroidTest/testlinkfile/CMakeFiles/testtarget.dir/link.txt tests/ECMToolchainAndroidTest/testlinkfile/outputfake.json toolchain/Android.cmake toolchain/specifydependencies.cmake To: apol, #frameworks, #build_system, aacid Cc: mart
D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40
This revision was automatically updated to reflect the committed changes. Closed by commit R320:75a3723c45e3: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40 (authored by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8847?vs=22466=22495 REVISION DETAIL https://phabricator.kde.org/D8847 AFFECTED FILES CMakeLists.txt thumbnail/thumbnail.cpp To: ngraham, #frameworks, broulik, elvisangelaccio
D8858: Fix testWaylandFullscreenShell.
cgiboudeaux created this revision. cgiboudeaux added a reviewer: graesslin. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This test needs the weston executable. Skip the test if the program wasn't found. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8858 AFFECTED FILES autotests/client/CMakeLists.txt To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 60 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/60/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 22:28:36 + Build duration: 6 min 7 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeign Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (4/4)97% (205/211)97% (205/211)89% (21167/23769)54% (10323/19255)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client100% (34/34)100% (34/34)99% (9801/9865)50% (6493/12923)autotests.server100% (5/5)100% (5/5)99% (356/359)49% (211/428)src.client95% (63/66)95% (63/66)80% (5001/6255)63% (1717/2743)src.server97% (103/106)97% (103/106)82% (6009/7290)60% (1902/3161)
KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 59 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/59/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 22:28:36 + Build duration: 6 min 33 sec and counting JUnit Tests Name: (root) Failed: 14 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandFullscreenShellFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeign
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
rkflx added a comment. IMHO the problem is not so much in the single text field, but how/where the results are presented. (Sorry I haven't got around to open the task yet. I did not forget, but Okular was more important last weekend…) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
ngraham added a comment. If the ability to add a custom path is important, maybe we should put that under "Terminal options". I don't think we're ever going to figure out a functional UI for that single text field to work equally well for searching and entering a path with history. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
D8332: Added baloo urls into places model
ngraham added a comment. @ervin and @dvratil, any remaining concerns? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
D8348: Add a section for removable devices
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
D8332: Added baloo urls into places model
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
D8434: Created 'remote' section
renatoo added a dependent revision: D8855: Use Kio::KPlacesModel as source model for PlacesItemModel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8434 To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
KDE CI: Frameworks kwayland kf5-qt5 XenialQt5.7 - Build # 59 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20XenialQt5.7/59/ Project: Frameworks kwayland kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 19:23:25 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 34 test(s), Skipped: 1 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testWindowmanagementFailed: TestSuite.kwayland-testXdgForeign Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (4/4)96% (201/210)96% (201/210)86% (20409/23649)53% (10049/19129)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.client100% (33/33)100% (33/33)99% (9666/9747)50% (6419/12799)autotests.server100% (5/5)100% (5/5)99% (356/359)49% (211/428)src.client94% (62/66)94% (62/66)76% (4722/6253)58% (1599/2741)src.server95% (101/106)95% (101/106)78% (5665/7290)58% (1820/3161)
KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 58 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/58/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 19:23:25 + Build duration: 8 min 52 sec and counting JUnit Tests Name: (root) Failed: 15 test(s), Passed: 19 test(s), Skipped: 1 test(s), Total: 35 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandFullscreenShellFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testXdgForeignFailed: TestSuite.kwayland-testXdgShellV5
D8396: Add support for zwp_idle_inhibit_manager_v1
This revision was automatically updated to reflect the committed changes. Closed by commit R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1 (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8396?vs=21046=22482#toc REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8396?vs=21046=22482 REVISION DETAIL https://phabricator.kde.org/D8396 AFFECTED FILES autotests/client/test_wayland_registry.cpp autotests/client/test_wayland_surface.cpp src/client/CMakeLists.txt src/client/idleinhibit.cpp src/client/idleinhibit.h src/client/protocols/idle-inhibit-unstable-v1.xml src/client/registry.cpp src/client/registry.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/idleinhibit_interface.cpp src/server/idleinhibit_interface.h src/server/idleinhibit_interface_p.h src/server/idleinhibit_interface_v1.cpp src/server/surface_interface.cpp src/server/surface_interface.h src/server/surface_interface_p.h src/tools/mapping.txt To: graesslin, #frameworks, #kwin, #plasma_on_wayland, davidedmundson Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8837: Fix testtrash with qtbase 5.10 beta 4
bcooksley added a comment. The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 58 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/58/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 16 Nov 2017 15:20:59 + Build duration: 2 hr 29 min and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.coronatestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest
D8851: Set enable_blur_behind hint on demand.
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Creating a window handle is relatively slow. We don't want it in the constructor if we don't need it. Replaces https://phabricator.kde.org/D8845 TEST PLAN Opened on X and Wayland. Looked the same as before. (which to me isn't very blurry, but a regular grey?) REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8851 AFFECTED FILES src/ktooltipwidget.cpp To: davidedmundson Cc: #frameworks
D8848: do not install development tool to aggregate desktop files
gregormi accepted this revision. gregormi added a comment. This revision is now accepted and ready to land. Approval from my side. Thanks. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8848 To: sitter, #frameworks, whiting, gregormi
D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40
elvisangelaccio accepted this revision as: elvisangelaccio. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D8847 To: ngraham, #frameworks, broulik, elvisangelaccio
D8848: do not install development tool to aggregate desktop files
sitter created this revision. sitter added reviewers: Frameworks, whiting, gregormi. Restricted Application added a project: Frameworks. REVISION SUMMARY it's not useful in production REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8848 AFFECTED FILES data/CMakeLists.txt To: sitter, #frameworks, whiting, gregormi
KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 139 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/139/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 15:20:59 + Build duration: 9 min 1 sec and counting JUnit Tests Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report86% (6/7)62% (57/92)62% (57/92)38% (3510/9230)26% (1862/7152)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (22/22)100% (22/22)76% (605/795)38% (390/1028)src.declarativeimports.core57% (4/7)57% (4/7)28% (251/883)14% (87/612)src.plasma62% (13/21)62% (13/21)40% (1426/3581)29% (775/2701)src.plasma.private46% (11/24)46% (11/24)39% (649/1649)28% (302/1080)src.plasma.scripting0% (0/3)0% (0/3)0% (0/190)0% (0/126)src.plasmaquick50% (6/12)50% (6/12)27% (548/2019)19% (302/1583)src.plasmaquick.private33% (1/3)33% (1/3)27% (31/113)27% (6/22)
KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 143 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/143/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 15:20:59 + Build duration: 7 min 0 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest
D8847: Depend on KIO::PreviewJob::defaultPlugins() and KF 5.40
ngraham created this revision. ngraham added reviewers: Frameworks, broulik, elvisangelaccio. REVISION SUMMARY master now has KF 5.40, so require that and always use KIO::PreviewJob::defaultPlugins(), which lets us get rid of some unnecessary code TEST PLAN Tested in KDE Neon. Compiles and deploys fine. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D8847 AFFECTED FILES CMakeLists.txt thumbnail/thumbnail.cpp To: ngraham, #frameworks, broulik, elvisangelaccio
D8809: Reduce spurious signal emissions
This revision was automatically updated to reflect the committed changes. Closed by commit R242:11c9206bf68f: Reduce spurious signal emissions (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8809?vs=22304=22465 REVISION DETAIL https://phabricator.kde.org/D8809 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp src/declarativeimports/core/framesvgitem.h src/plasma/framesvg.cpp To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvgitem.cpp:295 > If we always have 4 and can initialised them to 0 qreal[4] with a c style > array would be better. Would it? it's harder to compare then as you can't do a simple `!=` REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8522: keyboard navigation in and out QML kcms
This revision was automatically updated to reflect the committed changes. Closed by commit R295:9ebf898572ca: keyboard navigation in and out QML kcms (authored by mart). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=22463=22464 REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED FILES src/kcmoduleqml.cpp src/kcmoduleqml_p.h To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8522: keyboard navigation in and out QML kcms
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8522: keyboard navigation in and out QML kcms
mart marked 2 inline comments as done. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8522: keyboard navigation in and out QML kcms
mart updated this revision to Diff 22463. mart added a comment. - guard null REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8522?vs=21440=22463 BRANCH phab/keynav REVISION DETAIL https://phabricator.kde.org/D8522 AFFECTED FILES src/kcmoduleqml.cpp src/kcmoduleqml_p.h To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > framesvgitem.cpp:295 > + > +const QVector m_oldMargins; > +FrameSvgItemMargins *const m_margins; If we always have 4 and can initialised them to 0 qreal[4] with a c style array would be better. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8728: Install mimetype definitions for kcfg/kcfgc/ui.rc/knotify & qrc files
kossebau added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8728 To: kossebau, #frameworks, dfaure Cc: ngraham
D8811: [knewstuff] Do not leak ImageLoader on error
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8811 To: anthonyfieroni, leinir, dfaure Cc: broulik, #frameworks, ZrenBot
D8348: Add a section for removable devices
renatoo updated this revision to Diff 22453. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22393=22453 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwolff Cc: mwolff, abetts, mlaurent, anthonyfieroni, ngraham, #frameworks
D8332: Added baloo urls into places model
renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
D8434: Created 'remote' section
renatoo updated this revision to Diff 22454. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22394=22454 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
D8332: Added baloo urls into places model
renatoo updated this revision to Diff 22451. renatoo added a comment. Make 'isFileIndexingEnabled' a static function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=22328=22451 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES autotests/CMakeLists.txt autotests/kfileplacesmodeltest.cpp autotests/kfileplacesviewtest.cpp src/filewidgets/kfileplacesmodel.cpp src/filewidgets/kfileplacesview.cpp To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 140 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/140/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 12:56:08 + Build duration: 10 min and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (22/22)80% (278/346)80% (278/346)57% (30052/52401)42% (16622/39388)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (67/67)100% (67/67)96% (8078/8399)51% (4510/8824)autotests.http100% (9/9)100% (9/9)100% (543/544)60% (200/336)autotests.kcookiejar100% (1/1)100% (1/1)90% (179/198)67% (60/90)src.core85% (99/117)85% (99/117)57% (8166/14209)49% (4577/9291)src.core.kssl100% (1/1)100% (1/1)38% (35/93)50% (3/6)src.filewidgets73% (27/37)73% (27/37)46% (3569/7729)30% (1329/4476)src.gui100% (2/2)100% (2/2)95% (104/110)75% (54/72)src.ioslaves.file100% (2/2)100% (2/2)52% (441/849)43% (322/749)src.ioslaves.http100% (8/8)100% (8/8)47% (1770/3782)38% (1326/3462)src.ioslaves.http.kcookiejar100% (2/2)100% (2/2)80% (622/782)72% (608/839)src.ioslaves.remote100% (2/2)100% (2/2)27% (70/258)8% (16/200)src.ioslaves.trash80% (8/10)80% (8/10)59% (694/1173)46% (395/851)src.ioslaves.trash.tests100% (2/2)100% (2/2)90% (707/785)48% (461/970)src.kioslave100% (1/1)100% (1/1)52% (14/27)50% (5/10)src.kntlm100% (2/2)100% (2/2)97% (373/385)80% (111/138)src.kpasswdserver100% (2/2)100% (2/2)63% (377/594)48% (280/580)src.kpasswdserver.autotests100% (1/1)100% (1/1)99% (283/286)56%
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 141 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/141/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 12:56:08 + Build duration: 6 min 58 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiowidgets-kdirmodeltest
D8841: Fix build on FreeBSD
This revision was automatically updated to reflect the committed changes. Closed by commit R241:a208dc70c9a5: Fix build on FreeBSD (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8841?vs=22441=22446 REVISION DETAIL https://phabricator.kde.org/D8841 AFFECTED FILES src/core/listjob.cpp src/core/mkpathjob.cpp To: elvisangelaccio, adridg, dfaure Cc: #frameworks
KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9 - Build # 13 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.9/13/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 16 Nov 2017 12:07:38 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.kbookmarktest
D8825: do not show edit bookmarks action if keditbookmarks is not installed
sitter updated this revision to Diff 22443. sitter added a comment. rebased REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8825?vs=22379=22443 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8825 AFFECTED FILES src/kbookmarkmanager.cpp src/kbookmarkmenu.cpp src/kbookmarkmenu_p.h To: sitter, #frameworks Cc: apol
D8824: port from deprecated KAuthorized::authorizeKAction to authorizeAction
This revision was automatically updated to reflect the committed changes. Closed by commit R294:378808a575d7: port from deprecated KAuthorized::authorizeKAction to authorizeAction (authored by sitter). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8824?vs=22378=22442 REVISION DETAIL https://phabricator.kde.org/D8824 AFFECTED FILES src/kbookmarkmenu.cpp To: sitter, #frameworks, apol
D8841: Fix build on FreeBSD
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Weird, I wonder what's the relation with FreeBSD :) Compiler, I guess... REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8841 To: elvisangelaccio, adridg, dfaure Cc: #frameworks
D8841: Fix build on FreeBSD
elvisangelaccio created this revision. elvisangelaccio added reviewers: adridg, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I broke the build on FreeBSD, this patch should fix it. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8841 AFFECTED FILES src/core/listjob.cpp src/core/mkpathjob.cpp To: elvisangelaccio, adridg, dfaure Cc: #frameworks
KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 139 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/139/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Thu, 16 Nov 2017 11:14:33 + Build duration: 5 min 59 sec and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (22/22)80% (278/346)80% (278/346)57% (30077/52401)42% (16622/39388)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (67/67)100% (67/67)96% (8078/8399)51% (4503/8824)autotests.http100% (9/9)100% (9/9)100% (543/544)60% (200/336)autotests.kcookiejar100% (1/1)100% (1/1)90% (179/198)67% (60/90)src.core85% (99/117)85% (99/117)58% (8187/14209)49% (4580/9291)src.core.kssl100% (1/1)100% (1/1)38% (35/93)50% (3/6)src.filewidgets73% (27/37)73% (27/37)46% (3569/7729)30% (1329/4476)src.gui100% (2/2)100% (2/2)95% (104/110)75% (54/72)src.ioslaves.file100% (2/2)100% (2/2)51% (435/849)42% (317/749)src.ioslaves.http100% (8/8)100% (8/8)47% (1770/3782)38% (1326/3462)src.ioslaves.http.kcookiejar100% (2/2)100% (2/2)80% (622/782)72% (608/839)src.ioslaves.remote100% (2/2)100% (2/2)27% (70/258)8% (16/200)src.ioslaves.trash80% (8/10)80% (8/10)60% (704/1173)47% (404/851)src.ioslaves.trash.tests100% (2/2)100% (2/2)90% (707/785)48% (461/970)src.kioslave100% (1/1)100% (1/1)52% (14/27)50% (5/10)src.kntlm100% (2/2)100% (2/2)97% (373/385)80% (111/138)src.kpasswdserver100% (2/2)100% (2/2)63% (377/594)48% (280/580)src.kpasswdserver.autotests100% (1/1)100% (1/1)99% (283/286)56%
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 140 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/140/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 16 Nov 2017 11:14:33 +
Build duration:
4 min 55 sec and counting
CONSOLE OUTPUT
[...truncated 299.31 KB...]/usr/local/include/qt5/QtCore/qstring.h:1527:20: note: candidate function not viable: no known conversion from 'QLatin1Char' to 'const QStringRef' for 2nd argumentQ_CORE_EXPORT bool operator==(const QString , const QStringRef ) Q_DECL_NOTHROW; ^/usr/local/include/qt5/QtCore/qvariant.h:567:13: note: candidate function not viable: no known conversion from 'QLatin1Char' to 'const QVariantComparisonHelper' for 2nd argumentinline bool operator==(const QVariant , const QVariantComparisonHelper )^/usr/local/include/qt5/QtCore/qbytearray.h:607:13: note: candidate function not viable: no known conversion from 'const QString' to 'const QByteArray' for 1st argumentinline bool operator==(const QByteArray , const QByteArray ) Q_DECL_NOTHROW^/usr/local/include/qt5/QtCore/qbytearray.h:609:13: note: candidate function not viable: no known conversion from 'const QString' to 'const QByteArray' for 1st argumentinline bool operator==(const QByteArray , const char *a2) Q_DECL_NOTHROW^/usr/local/include/qt5/QtCore/qbytearray.h:611:13: note: candidate function not viable: no known conversion from 'const QString' to 'const char *' for 1st argumentinline bool operator==(const char *a1, const QByteArray ) Q_DECL_NOTHROW^/usr/local/include/qt5/QtCore/qstring.h:1135:13: note: candidate function not viable: no known conversion from 'const QString' to 'QString::Null' for 1st argumentinline bool operator==(QString::Null, QString::Null) { return true; }^/usr/local/include/qt5/QtCore/qstring.h:1136:13: note: candidate function not viable: no known conversion from 'const QString' to 'QString::Null' for 1st argumentinline bool operator==(QString::Null, const QString ) { return s.isNull(); }^/usr/local/include/qt5/QtCore/qstring.h:1142:13: note: candidate function not viable: no known conversion from 'const QString' to 'QLatin1String' for 1st argumentinline bool operator==(QLatin1String s1, QLatin1String s2) Q_DECL_NOTHROW^/usr/local/include/qt5/QtCore/qstring.h:1186:32: note: candidate function not viable: no known conversion from 'const QString' to 'const char *' for 1st argumentinline QT_ASCII_CAST_WARN bool operator==(const char *s1, const QString ) ^/usr/local/include/qt5/QtCore/qstring.h:1199:32: note: candidate function not viable: no known conversion from 'const QString' to 'const char *' for 1st argumentinline QT_ASCII_CAST_WARN bool operator==(const char *s1, QLatin1String s2) ^/usr/local/include/qt5/QtCore/qstring.h:1524:20: note: candidate function not viable: no known conversion from 'const QString' to 'const QStringRef' for 1st argumentQ_CORE_EXPORT bool operator==(const QStringRef , const QStringRef ) Q_DECL_NOTHROW; ^/usr/local/include/qt5/QtCore/qstring.h:1530:13: note: candidate function not viable: no known conversion from 'const QString' to 'const QStringRef' for 1st argumentinline bool operator==(const QStringRef , const QString ) Q_DECL_NOTHROW^/usr/local/include/qt5/QtCore/qstring.h:1534:20: note: candidate function not viable: no known conversion from 'const QString' to 'QLatin1String' for 1st argumentQ_CORE_EXPORT bool operator==(QLatin1String s1, const QStringRef ) Q_DECL_NOTHROW; ^/usr/local/include/qt5/QtCore/qstring.h:1537:13: note: candidate function not viable: no known conversion from 'const QString' to 'const QStringRef' for 1st argumentinline bool operator==(const QStringRef , QLatin1String s2) Q_DECL_NOTHROW^/usr/local/include/qt5/QtCore/qstring.h:1564:32: note: candidate function not viable: no known conversion from 'const QString' to 'const char *' for 1st argumentinline QT_ASCII_CAST_WARN bool operator==(const char *s1, const QStringRef ) ^/usr/local/include/qt5/QtCore/qhash.h:139:13: note: candidate function not viable: no known conversion from 'const QString' to 'const QHashDummyValue' for 1st argumentinline bool operator==(const QHashDummyValue & /* v1 */, const QHashDummyValue & /* v2 */)^/usr/local/include/qt5/QtCore/qpair.h:110:41: note: candidate template ignored: could not match 'QPair' against 'const QString'Q_DECL_CONSTEXPR Q_INLINE_TEMPLATE bool operator==(const QPair , const QPair )^/usr/local/include/qt5/QtCore/qscopedpointer.h:180:13: note: candidate template ignored: could not match 'QScopedPointer' against 'const QString'inline bool operator==(const QScopedPointer ,
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
This revision was automatically updated to reflect the committed changes. Closed by commit R241:2353119aae8f: Fix KIO::mkpath with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22433=22436 REVISION DETAIL https://phabricator.kde.org/D8836 AFFECTED FILES src/core/mkpathjob.cpp To: elvisangelaccio, #frameworks, dfaure, thiago
D8837: Fix testtrash with qtbase 5.10 beta 4
This revision was automatically updated to reflect the committed changes. Closed by commit R241:05938a167dd4: Fix testtrash with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8837?vs=22431=22437 REVISION DETAIL https://phabricator.kde.org/D8837 AFFECTED FILES src/core/listjob.cpp To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8522: keyboard navigation in and out QML kcms
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kcmoduleqml.cpp:154 > can this be null? Quick glance at `QQuickItemPrivate::nextPrevItemInTabFocusChain` shows it cannot. In doubt it returns `this`. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks, davidedmundson Cc: broulik, davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8522: keyboard navigation in and out QML kcms
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcmoduleqml.cpp:143
> +{
> +//FIXME: those are all workarounds around the QQuickWidget brokeness
> +if (watched == d->quickWidget && event->type() == QEvent::KeyPress) {
This needs a link to an upstream bug report.
> kcmoduleqml.cpp:148
> +
> +QQuickItem *currentItem = d->quickWindow->activeFocusItem();
> +if (currentItem->scopedFocusItem()) {
this can be null
> kcmoduleqml.cpp:154
> +if (ke->key() == Qt::Key_Tab) {
> +QQuickItem *nextItem = currentItem->nextItemInFocusChain(true);
> +//when it arrives at the place holder item, go out of the qqw and
can this be null?
REPOSITORY
R295 KCMUtils
REVISION DETAIL
https://phabricator.kde.org/D8522
To: mart, #plasma, #frameworks, davidedmundson
Cc: davidedmundson, ngraham, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
elvisangelaccio edited the summary of this revision. elvisangelaccio edited the test plan for this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
elvisangelaccio marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
elvisangelaccio updated this revision to Diff 22433. elvisangelaccio added a comment. - Use local variables REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22432=22433 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 AFFECTED FILES src/core/mkpathjob.cpp To: elvisangelaccio, #frameworks, dfaure, thiago
D8837: Fix testtrash with qtbase 5.10 beta 4
cgiboudeaux added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? https://bugs.kde.org/386420 ? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
dfaure added inline comments.
INLINE COMMENTS
> mkpathjob.cpp:46
> for (; i < basePathComponents.count() && i <
> m_pathComponents.count(); ++i) {
> if (m_pathComponents.at(i) == basePathComponents.at(i)) {
> +if (m_url.path() == QLatin1Char('/')) {
I think it's time to put m_pathComponents.at(i) into a local variable ;-)
> mkpathjob.cpp:65
> +QString testDir;
> +if (m_url.toLocalFile() == QLatin1Char('/')) {
> +testDir = m_url.toLocalFile() + m_pathComponents.at(i);
same here with m_url.toLocalFile()
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
To: elvisangelaccio, #frameworks, dfaure, thiago
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
elvisangelaccio updated this revision to Diff 22432. elvisangelaccio added a comment. - Fix also mkpathjobtest and fileundomanagertest REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8836?vs=22430=22432 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 AFFECTED FILES src/core/mkpathjob.cpp To: elvisangelaccio, #frameworks, dfaure, thiago
D8837: Fix testtrash with qtbase 5.10 beta 4
elvisangelaccio added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? I have two other failing tests in kio, which I'm fixing now. I guess this change will probably break something in some applications, but that's hard to tell. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
bcooksley added a comment. Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
dfaure added a comment. More seriously, this could be a reason for adding QUrl::addPath(), like we had in KUrl. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
dfaure added a comment. Maybe we need a KUrl class :-) Just kidding. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, thiago. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Same fix as in https://phabricator.kde.org/D8836, this time for testtrash. TEST PLAN Run testtrash. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 AFFECTED FILES src/core/listjob.cpp To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Urgh. That QUrl change doesn't make things easy for this type of code indeed. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
dfaure added a reviewer: thiago. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8836 To: elvisangelaccio, #frameworks, dfaure, thiago
D8522: keyboard navigation in and out QML kcms
mart added a comment. ping REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D8522 To: mart, #plasma, #frameworks Cc: ngraham, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8836: Fix KIO::mkpath with qtbase 5.10 beta 4
elvisangelaccio created this revision.
elvisangelaccio added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The latest Qt 5.10 beta includes [1] which breaks KIO all over the
place, since `url.setPath("//foo")` will now result in an invalid (empty)
QUrl.
This patch fixes the KIO::mkpath() case.
[1]:
http://code.qt.io/cgit/qt/qtbase.git/commit/?id=f62768d046528636789f901ac79e2cfa1843a7b7
TEST PLAN
I can now create folders from dolphin and plasma.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8836
AFFECTED FILES
src/core/mkpathjob.cpp
To: elvisangelaccio, #frameworks, dfaure
