D10152: Match also spdx keys LGPL-2.1 & LGPL-2.1+

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Can you please also fix the stupid off by one in the autotest which is why we 
didn't see this.
  
  for(int i = 1; i < KAboutLicense::LGPL_V2_1 ; i++) { /*current highest enum 
value*/
  
  should be
  
  <=

REPOSITORY
  R244 KCoreAddons

BRANCH
  fixlgpl21spdx

REVISION DETAIL
  https://phabricator.kde.org/D10152

To: kossebau, davidedmundson, apol
Cc: #frameworks, michaelh

D10152: Match also spdx keys LGPL-2.1 & LGPL-2.1+

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added reviewers: davidedmundson, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Fixup for 
https://phabricator.kde.org/R244:0d417760a53fbb605be414151ee81cf4b1fce3bf
  
  Solves e.g. missing license key in appdata files generated from
  dekstop or json data with those strings.

REPOSITORY
  R244 KCoreAddons

BRANCH
  fixlgpl21spdx

REVISION DETAIL
  https://phabricator.kde.org/D10152

AFFECTED FILES
  src/lib/kaboutdata.cpp

To: kossebau, davidedmundson, apol
Cc: #frameworks, michaelh

D10145: Improve line height

[René J . V . Bertin]

rjvbb added a comment.


  I can confirm that the patch appears to have no (side)effect whatsoever when 
using the Freetype fontengine (available also on Mac with 
`-cocoa:fontengine=freetype`!)
  
  The resulting lineheight looks fine when using the standard Mac CoreText 
fontengine, and I cannot get the white lines in multi-line selected text. I do 
notice something. Apparently unrelated (also happens without the patch, but 
since we're talking about white lines...) :
  
  F5678471: vertical_white_lines.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

To: cullmann, #ktexteditor
Cc: dhaumann, rjvbb, anthonyfieroni, ngraham, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars

D10145: Improve line height

[Dominik Haumann]

dhaumann added a comment.


  Testing under Linux, I cannot see any visual difference when selecting the 
same font in KWrite with and without patch. I guess this is mostly a good sign.
  From my side this is a "+1", but a bit more testing also by @rjvbb is 
certainly appreciated, therefore not yet giving a Ship-It :-)
  
  Next tagging date is 3rd of Febuary (next Saturday). Either you commit this 
now so we have one week of testing, or you commit right after that date.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

To: cullmann, #ktexteditor
Cc: dhaumann, rjvbb, anthonyfieroni, ngraham, #frameworks, michaelh, 
kevinapavew, demsking, cullmann, sars

D9594: Make kdoctools dependency optional

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R298:a78f3c63e9ab: Make kdoctools dependency optional 
(authored by vkrause).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9594?vs=24555=26086

REVISION DETAIL
  https://phabricator.kde.org/D9594

AFFECTED FILES
  CMakeLists.txt

To: vkrause, #frameworks, bshah
Cc: michaelh

D9589: Unexport kjscmd

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R315:576d0eec01ef: Unexport kjscmd (authored by vkrause).

REPOSITORY
  R315 KJsEmbed

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9589?vs=24545=26085

REVISION DETAIL
  https://phabricator.kde.org/D9589

AFFECTED FILES
  src/kjscmd/CMakeLists.txt

To: vkrause, #frameworks, apol
Cc: bshah, michaelh

D9588: Make kdoctools dependency optional

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R315:6d334380a2c3: Make kdoctools dependency optional 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9588?vs=24544=26084#toc

REPOSITORY
  R315 KJsEmbed

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9588?vs=24544=26084

REVISION DETAIL
  https://phabricator.kde.org/D9588

AFFECTED FILES
  CMakeLists.txt

To: vkrause, #frameworks, bshah
Cc: michaelh

KDE CI: Frameworks kholidays kf5-qt5 WindowsMSVCQt5.9 - Build # 4 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20WindowsMSVCQt5.9/4/
 Project:
Frameworks kholidays kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sat, 27 Jan 2018 19:11:01 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks kholidays kf5-qt5 SUSEQt5.7 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.7/3/
 Project:
Frameworks kholidays kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 27 Jan 2018 19:11:01 +
 Build duration:
5 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(19/22)86%
(19/22)71%
(1533/2162)59%
(922/1560)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(9/9)100%
(9/9)99%
(328/330)60%
(124/206)src100%
(7/7)100%
(7/7)79%
(590/745)72%
(488/675)src.declarative0%
(0/3)0%
(0/3)0%
(0/30)0%
(0/8)src.parsers100%
(2/2)100%
(2/2)45%
(318/705)33%
(134/406)src.parsers.plan2100%
(1/1)100%
(1/1)84%
(297/352)66%
(176/265)

KDE CI: Frameworks kholidays kf5-qt5 SUSEQt5.10 - Build # 3 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20SUSEQt5.10/3/
 Project:
Frameworks kholidays kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 27 Jan 2018 19:11:01 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)86%
(19/22)86%
(19/22)71%
(1533/2162)59%
(922/1560)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(9/9)100%
(9/9)99%
(328/330)60%
(124/206)src100%
(7/7)100%
(7/7)79%
(590/745)72%
(488/675)src.declarative0%
(0/3)0%
(0/3)0%
(0/30)0%
(0/8)src.parsers100%
(2/2)100%
(2/2)45%
(318/705)33%
(134/406)src.parsers.plan2100%
(1/1)100%
(1/1)84%
(297/352)66%
(176/265)

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in filemetadataprovider.cpp:323
> I don't think so, because `IndexedDataRetriever::start()` does not block.

In that case it might be safer to do

 IndexedDataRetriever *ret = new IndexedDataRetriever(filePath, this);
​connect(ret, SIGNAL(finished(KJob*)), this, 
SLOT(slotLoadingFinished(KJob*)));   
 
  insertBasicData();
​insertEditableData();
​emit dataAvailable();
  
  ​ret->start();

Because once loadingFinished() is signalled it's over. dataAvailable(); won't 
get processed anymore.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh edited the summary of this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh marked 4 inline comments as done.
michaelh added inline comments.

INLINE COMMENTS

> filemetadataprovider.cpp:141
>  }
> -else {
> -//
> -// Only report the stuff that is common to all the files
> -//
> -QSet allProperties;
> -QList propertyList;
> -foreach (const QVariantMap& fileData, files) {
> -propertyList << fileData;
> -allProperties.unite(fileData.uniqueKeys().toSet());
> -}
> -
> -// Special handling for certain properties
> -totalPropertyAndInsert("duration", propertyList, allProperties);
> -totalPropertyAndInsert("characterCount", propertyList, 
> allProperties);
> -totalPropertyAndInsert("wordCount", propertyList, allProperties);
> -totalPropertyAndInsert("lineCount", propertyList, allProperties);
> -
> -foreach (const QString& propUri, allProperties) {
> -foreach (const QVariantMap& map, propertyList) {
> -QVariantMap::const_iterator it = map.find( propUri );
> -if( it == map.constEnd() ) {
> -m_data.remove( propUri );
> -break;
> -}
> -else {
> -QVariantMap::iterator dit = m_data.find( it.key() );
> -if( dit == m_data.end() ) {
> -m_data.insert( propUri, it.value() );
> -}
> -else {
> -QVariant finalValue = intersect( it.value(), 
> dit.value() );
> -if( finalValue.isValid() )
> -m_data[propUri] = finalValue;
> -else {
> -m_data.remove( propUri );
> -break;
> -}
> -}
> -}
> -}
> -}
> +
> +if (files.size() > 1) {

We can leave early here, I think. 
Without a file

  149  insertEditableData() 

does not make much sense.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh updated this revision to Diff 26079.
michaelh added a comment.


  Leave early w/o files
  Fix comments
  Rename setFilesItems to setFileItems
  Apply coding style

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10105?vs=26068=26079

BRANCH
  requestfinished (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10105

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10141: Restore Persistence=session for the file ioslave kauth helper

[Fabian Vogt]

fvogt added a comment.


  There is one issue I have with this. While this is close to the `sudo`-mode 
of temporary authorization grants, it doesn't work that way as the whole 
session has full access via file.so.
  
  It would be great if this could work with just the application which 
initially requested the privilege.
  With this, the whole session has full root-level access to literally 
everything on the system.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10141

To: elvisangelaccio, lbeltrame, dfaure, davidedmundson, fvogt, chinmoyr
Cc: #frameworks, michaelh

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1, looks good to me.

INLINE COMMENTS

> michaelh wrote in filemetadataprovider.cpp:323
> Is it guaranteed, that this is emitted before IndexedDataRetriever job is 
> finished?

I don't think so, because `IndexedDataRetriever::start()` does not block.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D10145: Improve line height

[René J . V . Bertin]

rjvbb added a comment.


  OK, testing. I'll let you know if I notice anything off.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

To: cullmann, #ktexteditor
Cc: rjvbb, anthonyfieroni, ngraham, #frameworks, michaelh, kevinapavew, 
demsking, cullmann, sars, dhaumann

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio edited the summary of this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> filemetadataprovider.cpp:140
> +} else {
>  m_data = files.first();
> +insertSingleFileBasicData();

This will crash if `files` is empty, I think?

> filemetadataprovider.cpp:195
> +allDirectories &= item.isDir();
> +if (!allDirectories) break;
> +}

Missing braces here

> filemetadataprovider.cpp:299-303
>  // There are 4 code paths -
>  // Single File -
>  //   * Not Indexed
>  //   * Indexed
>  //

Please fix this comment, now we don't have 4 code paths inside this function.

> filemetadataprovider.h:125
> +void setFileItem();
> +void setFilesItems();
> +

Please call it `setFileItems()`, "fileitem" is kinda used as a single word 
(e.g. see `m_fileItems`).

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh marked an inline comment as done.
michaelh added inline comments.

INLINE COMMENTS

> filemetadataprovider.cpp:323
> +emit dataAvailable();
>  
>  } else {

Is it guaranteed, that this is emitted before IndexedDataRetriever job is 
finished?

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D9587: Make kdoctools dependency optional

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R314:016aa871a084: Make kdoctools dependency optional 
(authored by vkrause).

REPOSITORY
  R314 KJs

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9587?vs=24543=26072

REVISION DETAIL
  https://phabricator.kde.org/D9587

AFFECTED FILES
  CMakeLists.txt

To: vkrause, #frameworks, bshah
Cc: michaelh

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Michael Heidelbach]

michaelh updated this revision to Diff 26071.
michaelh added a comment.


  Update signal descriptions

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10113?vs=25962=26071

BRANCH
  dataavail

REVISION DETAIL
  https://phabricator.kde.org/D10113

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h
  src/filemetadatawidget.cpp
  src/filemetadatawidget.h

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[Nathaniel Graham]

ngraham added a comment.


  Thanks René. Regarding those questions, what would your preferences be?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10145: Improve line height

[Christoph Cullmann]

cullmann added a comment.


  Either this patch can improve that or make it worse ;=)
  I tried out some .desktop file with different translations inside that have 
"complex" glyphs and I think it works better now.
  If you have time to test that, it would be great.
  
  Btw., that you sometimes get strange artifacts between lines is a Qt issue, 
happens with QtCreator, too, see my bug 
https://bugreports.qt.io/browse/QTBUG-66036

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

To: cullmann, #ktexteditor
Cc: anthonyfieroni, ngraham, #frameworks, michaelh, kevinapavew, demsking, 
cullmann, sars, dhaumann

D10145: Improve line height

[Anthony Fieroni]

anthonyfieroni added a comment.


  Is this has same impact in rtl language or some kind of hieroglyphs, it's 
painted a bit up or down cutted.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

To: cullmann, #ktexteditor
Cc: anthonyfieroni, ngraham, #frameworks, michaelh, kevinapavew, demsking, 
cullmann, sars, dhaumann

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh updated this revision to Diff 26068.
michaelh added a comment.


  Correct merging errors

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10105?vs=26058=26068

BRANCH
  requestfinished (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10105

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10135: Put built-in holiday definitions into qrc

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R175:730063cb9dc1: Put built-in holiday definitions into qrc 
(authored by vkrause).

REPOSITORY
  R175 PIM: KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10135?vs=26034=26069

REVISION DETAIL
  https://phabricator.kde.org/D10135

AFFECTED FILES
  CMakeLists.txt
  holidays/CMakeLists.txt
  holidays/holidays.qrc
  src/CMakeLists.txt
  src/holidayregion.cpp

To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D10145: Improve line height

[Christoph Cullmann]

cullmann created this revision.
cullmann added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
cullmann requested review of this revision.

REVISION SUMMARY
  I played a bit more with KTextEditor on macOS.
  It seems we are too restrictive what we use as line height.
  The attached patch increases the height by the leading, both in the 
computation in the renderer for line height + layouting.
  
  I still get some artifacts like in https://bugs.kde.org/show_bug.cgi?id=379727
  
  But I think that is more likely some rendering mis-shape in Qt itself, as you 
get even artifacts vertically inside a line during the drawing...

TEST PLAN
  For me, less overlapping of lines occur in different zoom variants.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D10145

AFFECTED FILES
  src/render/katerenderer.cpp

To: cullmann, #ktexteditor
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh planned changes to this revision.
michaelh added a comment.


  There are merging errors

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D9589: Unexport kjscmd

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R315 KJsEmbed

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9589

To: vkrause, #frameworks, apol
Cc: bshah, michaelh

D10135: Put built-in holiday definitions into qrc

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> mlaurent wrote in CMakeLists.txt:8
> Just curious it's not default in ECM ? I never used it.

Yep, I was expecting this to be the default too, but it didn't work without 
explicitly enabling it.

REPOSITORY
  R175 PIM: KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10135

To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D9589: Unexport kjscmd

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> vkrause wrote in CMakeLists.txt:6
> That suggests it shouldn't even be installed in the first place? Would fix 
> the cross-compilation issue too.

I am not sure tbh, question is what it does and what does it mean by developer 
tool?

- KJSEmbed framework developer?
- 3rd-party developer?

If it's 3rd party, it should be installed IMO, but well who knows.. I am not 
even sure I understand what this tool does..

REPOSITORY
  R315 KJsEmbed

REVISION DETAIL
  https://phabricator.kde.org/D9589

To: vkrause, #frameworks
Cc: bshah, michaelh

D10135: Put built-in holiday definitions into qrc

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> CMakeLists.txt:8
>  set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
> +set(CMAKE_AUTORCC ON)
>  

Just curious it's not default in ECM ? I never used it.

REPOSITORY
  R175 PIM: KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10135

To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh updated this revision to Diff 26058.
michaelh added a comment.


  Separate coding-style refactor into extra commit

REPOSITORY
  R824 Baloo Widgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10105?vs=25960=26058

BRANCH
  requestfinished (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10105

AFFECTED FILES
  src/filemetadataprovider.cpp
  src/filemetadataprovider.h

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D9589: Unexport kjscmd

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> bshah wrote in CMakeLists.txt:6
> :-P

That suggests it shouldn't even be installed in the first place? Would fix the 
cross-compilation issue too.

REPOSITORY
  R315 KJsEmbed

REVISION DETAIL
  https://phabricator.kde.org/D9589

To: vkrause, #frameworks
Cc: bshah, michaelh

D9587: Make kdoctools dependency optional

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R314 KJs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9587

To: vkrause, #frameworks, bshah
Cc: michaelh

D9588: Make kdoctools dependency optional

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R315 KJsEmbed

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9588

To: vkrause, #frameworks, bshah
Cc: michaelh

D9594: Make kdoctools dependency optional

[Bhushan Shah]

bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9594

To: vkrause, #frameworks, bshah
Cc: michaelh

D9589: Unexport kjscmd

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> CMakeLists.txt:6
>  
>  # This is a developer tool, not intended for normal user installs
>  add_executable(kjscmd5 ${kjscmd_SRCS})

:-P

REPOSITORY
  R315 KJsEmbed

REVISION DETAIL
  https://phabricator.kde.org/D9589

To: vkrause, #frameworks
Cc: bshah, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Michael Heidelbach]

michaelh added a dependency: D10143: baloo-widgets: Apply coding style to 
filemetadataprovider .

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REVISION SUMMARY
  This addresses the following situation:
  
  1. Start drag on a QtWayland based window
  2. Press escape
  3. Release mouse
  
  -> this results in a crash. The main reason for this is that QtWayland
  destroys the DataSource in step 2 and KWayland did not expect this at
  all. The drag and drop operation continued and results in step 3 in the
  drag target to request data from the no longer existing DataSource.
  
  This change addresses the root of the problem by cancelling the drag
  operation when the DataSource gets destroyed.
  
  BUG: 389221
  FIXED-IN: 5.43

TEST PLAN
  New test case exposing the problem and manual testing with
  kwin_wayland and dolphin (based on bug report)

REPOSITORY
  R127 KWayland

BRANCH
  cancel-drag-on-datasource-destroy

REVISION DETAIL
  https://phabricator.kde.org/D10142

AFFECTED FILES
  autotests/client/test_drag_drop.cpp
  src/server/datadevice_interface.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #frameworks, #kwin, #plasma
Cc: plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10141: Restore Persistence=session for the file ioslave kauth helper

[Elvis Angelaccio]

elvisangelaccio created this revision.
elvisangelaccio added reviewers: lbeltrame, dfaure, davidedmundson, fvogt, 
chinmoyr.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  It was reverted by 
https://phabricator.kde.org/R241:029da62886e0571dfbe54cc4433af8ae8ac3433d + 
https://phabricator.kde.org/R241:45fbe9d1cd7e3d92ee5b83ea6d2f5e957b3372c3, but 
this cannot be
  the solution for the security issues discussed in [1].
  
  Without the persistence attribute the whole feature becomes unusable
  (i.e. one password prompt for every file operation).
  
  For the record, the kauth support has been disabled altogether since
  then (see 
https://phabricator.kde.org/R241:5a1ea84476e63a97313d2201fc3d1f7033ea56af).
  
  This patch restores the previous state to avoid the half-reverted
  situation we are currently in.
  We still keeps the feature disabled for now until we address the security
  issues mentioned in the mailing list.
  
  [1]: 
https://mail.kde.org/pipermail/kde-frameworks-devel/2018-January/055307.html

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10141

AFFECTED FILES
  src/ioslaves/file/kauth/file.actions

To: elvisangelaccio, lbeltrame, dfaure, davidedmundson, fvogt, chinmoyr
Cc: #frameworks, michaelh

D9589: Unexport kjscmd

[Volker Krause]

vkrause added a comment.


  ping

REPOSITORY
  R315 KJsEmbed

REVISION DETAIL
  https://phabricator.kde.org/D9589

To: vkrause, #frameworks
Cc: michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Fabian Vogt]

fvogt resigned from this revision.
fvogt added a comment.


  Works for me. I'll leave the final review to someone else (@dfaure?).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate updated this revision to Diff 26047.
jtamate added a comment.


  - Faster simplejob start
  
  Finally the C++11 lambda syntax worked.
  Now it only uses 0.3% of cpu according to callgrind.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10124?vs=26011=26047

BRANCH
  simplejob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10124

AFFECTED FILES
  src/core/simplejob.cpp

To: jtamate, #frameworks
Cc: broulik, ngraham, anthonyfieroni, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26045.
chinmoyr added a comment.


  Fix typo. (int->bool in file_p.h line 59)

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=26044=26045

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26044.
chinmoyr added a comment.


  1. Added +1 to SocketAddress::length for null byte.
  2. Modified PrivilegeOperationReturnValue to use with switch-case and if-else 
construct.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=26028=26044

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D10105: baloo-widgets: Refactor filemetadataprovider for better readability

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'd split this into 2 patches: one for the code style changes, and another 
one for the actual code refactoring.
  This way if the refactoring breaks something, it will be easier to figure out 
where the problem is.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10105

To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks

D10136: AppArmor: new keywords, improvements & fixes

[Nibaldo González]

nibags added a subscriber: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10136

To: nibags, #framework_syntax_highlighting
Cc: #framework_syntax_highlighting, #frameworks, michaelh, genethomas, 
cullmann, vkrause, dhaumann

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[René J . V . Bertin]

rjvbb added a comment.


  >   Thanks for the info! So if/hen this goes in, what are the next steps?
  
  I'd say
  
  - decide whether this is an issue you want to solve only for plasma 
environments, or for all platforms where KF5 applications are supported.
  - draw up the conditions under which a stylename has to be set and whether to 
rely on Qt to do this in those cases.
  - how to avoid the effects of Qt setting a stylename in the conditions where 
this is not a necessity, how to get rid of it reliably etc.
  
  Optionally, when those things have become clear and have a well-tested 
implementation, try to work with the Qt team to merge any appropriate parts 
into Qt. From what I've seen in the exchanges with them it would be of no use 
to do this any earlier. Their stance seems to be "just don't rely on being able 
to setBold(true)" or any similar attribute change.
  
  Not that I see how that could be possible, but the observation I posted in my 
previous comment may indicate that there might be a central location after all 
where we could get rid of a stylename (in addition to KFontRequester).

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D10136: AppArmor: new keywords, improvements & fixes

[Nibaldo González]

nibags added a reviewer: Framework: Syntax Highlighting.
nibags added a project: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10136

To: nibags, #framework_syntax_highlighting
Cc: #frameworks, michaelh, genethomas, cullmann, vkrause, dhaumann

D10136: AppArmor: new keywords, improvements & fixes

[Nibaldo González]

nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
nibags requested review of this revision.

REVISION SUMMARY
  Update the syntax highlighting of AppArmor, after the release of AppArmor 
2.12.0. In summary, in this update new keywords are added and the code is 
revised and improved.
  
  Changes:
  
  - Added missing keywords in flags and network and mount rules. Keywords 
'read' and 'write' are placed in the 'base_accesses' list.
  - Added keywords for default abstractions & variables, included in the 
provided AppArmor policy. The purpose of these is to provide autocomplete 
suggestions when writing Include rules and variables.
  - Fixes: Comments not allowed within rules and in variable assignment lines. 
The keywords are sensitive. 'Owner' qualifier is not associated with the file 
rule.
  - General improvements in the highlighting of Include rules, variables, 
rlimit rules, file permissions and globbing. The code of the profile names, the 
transition rules and the end of rules context is simplified.
  
  Regards!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  apparmor-v4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10136

AFFECTED FILES
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/input/usr.bin.apparmor-profile-test
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml

To: nibags
Cc: #frameworks, michaelh

D10113: baloo-widgets: Emit metaDataRequestFinished once per request

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> filemetadataprovider.h:114
>  void loadingFinished();
> +void dataAvailable();
>  

Could you add API documentation there what this signal indicates and when to 
use it? Typically, if you find code that is documented it is good practice to 
do the same :-)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D10113

To: michaelh, elvisangelaccio, smithjd, vhanda, ngraham, #dolphin, #frameworks
Cc: dhaumann

Re: KHolidays as Framework (redux)

[Volker Krause]

On Tuesday, 23 January 2018 18:36:10 CET Dominik Haumann wrote:
> Another question: there are holiday files in the git repo. Are these files
> compiled in as resource or loaded via filesystem?
> 
> If these files are not added as resource, this probably breaks on Windows
> and OSX.

Good point, addressed in https://phabricator.kde.org/D10135 .

Thanks,
Volker

> Am 20.01.2018 17:37 schrieb "Dominik Haumann" :
> 
> Am 20.01.2018 17:22 schrieb "Volker Krause" :
> 
> Thanks, should be fixed now.
> 
> 
> Certainly better, although code examples and the like still would make a
> significant difference ;)
> 
> Cheers
> Dominik
> 
> On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote:
> > Hi,
> > 
> > CC: only kdepim, kde-frameworks-devel
> > 
> > I have some general comments about the API documentation. Looking at
> > https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html
> > the list mostly (only?) contains classes that are internal. Looking at
> > https://github.com/KDE/kholidays/blob/master/src/holiday.h
> > we can see documentation exists also for important classes, but the docs
> > are not listed because the class documentation is missing.
> > 
> > This is not a showstopper, but without accessible API, the visibility of
> > this framework is much reduced. It would be nice, if the API documentation
> > is complete, so here is still some room for improvement ;)
> > 
> > Best regards
> > Dominik
> > 
> > 
> > 
> > Am 20.01.2018 11:39 schrieb "Volker Krause" :
> > 
> > On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> > > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > > > Hi,
> > > > > > > 
> > > > > > > It's xmas holidays, so it must be time to poke a stick at
> > 
> > KHolidays
> > 
> > > > > > > again
> > > > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > > > outstanding
> > > > > > > porting issues with KHolidays and it is ready for review to be
> > > > > > > included
> > > > > > > as
> > > > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > > > step?
> > > > > > 
> > > > > > Please make sure it passes all of the items in this checklist
> > > > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > > > 
> > > > > AFAICS this is followed, apart from using the KF5 version number and
> > > > > actually being marked as a framework, which I guess is pending
> > 
> > framework
> > 
> > > > > approval.
> > > > 
> > > > This got lost somehow, any objection to executing the move to
> 
> frameworks
> 
> > > > for 5.43, say end of this week?
> > > 
> > > Go ahead.
> > 
> > The necessary metainfo and CMake changes are pushed, the sysadmin ticket
> 
> for
> 
> > the repo metadata change is T7791.
> > 
> > Summary: KHolidays will not be part of the 18.x KDE Application releases
> > anymore, but instead become part of the KDE Frameworks releases with
> 
> version
> 
> > 5.43. There are no ABI or name changes, just the .so version increases
> 
> from
> 
> > 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully
> 
> be
> 
> > hardly noticeable.
> > Side benefit: plasma-workspace no longer depends on a library from KDE
> > Application releases.
> > 
> > Regards,
> > Volker



signature.asc
Description: This is a digitally signed message part.

D10135: Put built-in holiday definitions into qrc

[Volker Krause]

vkrause created this revision.
vkrause added reviewers: Frameworks, KDE PIM.
Restricted Application added a project: KDE PIM.
vkrause requested review of this revision.

REVISION SUMMARY
  The file system is still searched in the same place as before, which can
  be easier to use than qrc while working on those files. Having the data
  compiled in simplifies deployment though, particularly on systems without
  a standard XDG install layout.

REPOSITORY
  R175 PIM: KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10135

AFFECTED FILES
  CMakeLists.txt
  holidays/CMakeLists.txt
  holidays/holidays.qrc
  src/CMakeLists.txt
  src/holidayregion.cpp

To: vkrause, #frameworks, #kde_pim
Cc: dvasin, winterz, vkrause, mlaurent, knauss, dvratil

D9966: [KIO] Fix issues with sharing of file descriptor

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  Almost done!
  
  I just noticed some small issues with reading errno after calling 
`execWithElevatedPrivileges(...)` (I only left a single comment, the other 
places are basically identical)

INLINE COMMENTS

> file.cpp:239
>  if (!err.wasCanceled()) {
>  switch (errno) {
>  case EPERM:

`errno` might not be the expected value anymore.

> chinmoyr wrote in sharefd_p.h:66
> I think this is not needed. It's already there in FdReceiver.

Fair enough.

> chinmoyr wrote in sharefd_p.h:47
> @fvogt Is +1 for null byte required here?

Not on most platforms, but `man unix` says for portability:

  offsetof(struct sockaddr_un, sun_path)+strlen(addr.sun_path)+1```.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the info! So if/hen this goes in, what are the next steps?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[René J . V . Bertin]

rjvbb added a comment.


  A diagonally related anecdote that shows this location is a more central 
point in the font selection process than I thought first:
  
  Applications like Qt's Assistant that call for Helvetica often end up using a 
font that looks pixelated - because it's actually an embedded bitmap version. I 
only saw that under X11 and always wrote that off to a missing font though the 
fact that scaling up the text solved the issue appeared strange.
  Then I noticed it too on Mac during my comparisons of the CoreText and 
Freetype font engines.
  
  One solution to this particular issue (itself unrelated to style names) is to 
use the ForceOutline style strategy when the Freetype engine is used. I 
implemented that in my Mac version of the platform integration plugin, right 
next to where this patch applies. That was mostly to be exhaustive (there is no 
way to set this as a global strategy applying to all current and future fonts). 
I was surprised to see that it apparently applies to the result of all font 
lookups.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

[René J . V . Bertin]

rjvbb added a comment.


  >   Is this change purely a conversation of what developers use in code to 
call up fonts in their applications?
  
  I think so.
  
  >   Or does this also include a discussion where regular users have 
interfaces that allow changes to font naming? Let's say, something like System 
Settings that would allow users to change the naming for system fonts?
  
  That already exists as you must have noticed: the Fonts settings panel.
  
  This suggested change removes one source of stylenames being set on fonts 
beyond the user's control. In the original/current code, the table with the 
default fonts (those used before the user makes any customisations) contains 
stylenames. Later on in the code those are set on the fonts being looked up.
  The modified version still does that, but only if looked-up font already has 
a stylename set.
  
  Concretely this means a better guarantee that the trick of removing the 
stylename part from the font descriptions in settings (rc) files will actually 
work.
  
  The modification should be transparent to anyone who does NOT remove 
stylenames and is thus the least invasive change. I still think the platform 
theme plugin should never have started calling setStyleName in the first place, 
and certainly not for default fonts that are perfectly described by the PANOSE 
system and thus don't need a stylename.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D9070

To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck, dfaure
Cc: abetts, anthonyfieroni, ngraham, cfeck, fvogt, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr marked an inline comment as done.
chinmoyr added inline comments.

INLINE COMMENTS

> fvogt wrote in sharefd_p.h:66
> If that is the case you can do something like:
> 
>   #if !defined(__linux__) && !defined(__FreeBSD__)
>   #error No secure implementation available
>   #endif

I think this is not needed. It's already there in FdReceiver.

> sharefd_p.h:47
>  {
> -return sizeof addr;
> +return offsetof(struct sockaddr_un, sun_path) + 
> strlen(addr.sun_path);
>  }

@fvogt Is +1 for null byte required here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9966

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

D9966: [KIO] Fix issues with sharing of file descriptor

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 26028.
chinmoyr added a comment.


  Changed parameters of
   execWithElevatedPrivileges(), tryChangeAttr() : now they accept action type, 
list of arguments and error code.
   tryOpen(): accepts error code as an additional parameter.
  
  @dfaure please have a look at it.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9966?vs=25941=26028

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9966

AFFECTED FILES
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, thiago, fvogt
Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.7 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.7/29/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.7
 Date of build:
Sat, 27 Jan 2018 08:14:09 +
 Build duration:
7 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/28/
 Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 27 Jan 2018 08:14:09 +
 Build duration:
6 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)

D9989: baloo-tools: Make all output messages translatable

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:125029d79153: baloo-tools: Make all output messages 
translatable (authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9989?vs=25687=26027

REVISION DETAIL
  https://phabricator.kde.org/D9989

AFFECTED FILES
  src/tools/balooctl/monitorcommand.cpp
  src/tools/baloosearch/main.cpp
  src/tools/balooshow/main.cpp

To: michaelh, smithjd, #frameworks, vhanda, lueck, lbeltrame
Cc: ngraham

D9989: baloo-tools: Make all output messages translatable

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  translate-all (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck, lbeltrame
Cc: ngraham