D10857: Change qSort to std::sort in simplifiedUrlList

[Jaime Torres Amate]

jtamate added a comment.


  In D10857#214607 , @dfaure wrote:
  
  > I'm not opposed to the idea, but measuring CPU usage is a rather misleading 
indicator. What if it takes 10 times longer, because it's progressing much more 
slowly? ;)
  >
  > Please at least measure with QElapsedTimer around the sorting (not to be 
committed, just to gather numbers about the actual performance of this from a 
user's point of view).
  >  I'm interested in the result ;)
  
  
  The results are strange. All the results are measured sorting 50.000 small 
files:
  
  Both Qt are the same version from opensuse.
  
  In an i5, why the difference is so big? recent cpu bugs?
  qSort in i3 
  274764, 276060 (with 3 directories), 365878, 424506  (without directories)
  std::sort in i3
  940, 995 (with 3 directories), 2472, 2539 (without directories)
  
  In AMD the results are closer, qSort wins
  qSort in AMD
  658, 726, 695, 683, 676, 666, 649, 684, 666 (without directories)
  std:sort in AMD
  843, 839, 878, 896,  925 (without directories)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

To: jtamate, #frameworks, dfaure
Cc: markg, apol, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Dmitri Ovodok]

dmitrio abandoned this revision.
dmitrio added a comment.


  In D10663#213898 , @dfaure wrote:
  
  > I don't see any provision for the case I mentioned, where the destination 
file already exists, and should therefore NOT be deleted?
  
  
  In fact, this is exactly the case that I tried to deal with here. In this 
proposal the destination file gets deleted only if some data has been written 
into it, so all the previous data are already lost regardless of our cleanup.
  
  What is not handled here is the case of moving to another partition, where 
subjob may launch original file deletion just after successful file copying and 
before emitting result, which may lead to cleanup being done when the original 
file can potentially be deleted. I also expect some trouble with job pause 
feature when user may pause this job, eventually start copying the same file 
with another tool (be it something like `cp` or another instance of CopyJob), 
and then abort this job. For this case we should probably add something like a 
check on whether size of the destination file has changed since our 
last change of that file. So it seems that to work properly this feature needs 
some more complex solution including, probably, some separate job class dealing 
with cleanup and all the necessary safety checks. For now, I can only apologize 
for underestimating the problem and rolling out such a raw solution for it.
  
  I am probably better to close it, if I am able to come up with better 
solution I will reopen this request (if it is possible) or open a new one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: ngraham, anthonyfieroni, meven, #frameworks, michaelh

D10870: [PackageUrlInterceptor] Don't rewrite "inline"

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10870

To: broulik, #plasma, hein
Cc: #frameworks, michaelh

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10863

To: broulik, #frameworks, #plasma, hein, aleksejshilin
Cc: michaelh

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.7 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.7/17/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 26 Feb 2018 22:02:06 +
 Build duration:
1 min 58 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report40%
(2/5)47%
(41/87)47%
(41/87)40%
(4061/10095)34%
(2387/7124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(11/11)100%
(11/11)99%
(1351/1362)49%
(659/1334)src52%
(30/58)52%
(30/58)35%
(2710/7809)31%
(1728/5655)src.ksendbugmail0%
(0/4)0%
(0/4)0%
(0/275)0%
(0/67)tests0%
(0/12)0%
(0/12)0%
(0/589)0%
(0/46)tests.krichtexteditor0%
(0/2)0%
(0/2)0%
(0/60)0%
(0/22)

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich planned changes to this revision.
astippich added a comment.


  In D10803#213783 , @michaelh wrote:
  
  > In D10803#213767 , @astippich 
wrote:
  >
  > > I don't know dolphin works, but given how KFileMetadata is designed, the 
new tags should be ignored until explicit support is added in dolphin.
  >
  >
  > Please try that. For unknown types baloo-widgets (responsible for 
infopanel/tooltips) falls back to `value.toString()`, no idea what will happen 
when you feed it with binary data. The cover properties return binary data, 
right?
  
  
  The cover is binary data, right. And I think I was wrong. While I don't fully 
understand yet how baloo-widgets work, from what I've read all available 
properties are automatically queried. The binary data would then be converted 
to a string as you said. So adding the cover this way may not be a good 
solution. A different interface should be created for image/binary data.
  I think I will split this into two diffs and do the cover images separately.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: dfaure, michaelh, ngraham, #frameworks

D10803: handle more tags in taglibextractor

[Matthieu Gallien]

mgallien added a comment.


  I have created T8079  to work on baloo 
database update when extractors are modified and returned different data.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: dfaure, michaelh, ngraham, #frameworks

D10694: epubextractor: Handle multiple subjects better

[Matthieu Gallien]

mgallien added a comment.


  I have created T8079  to work on baloo 
database update when extractors are modified and returned different data.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, spoorun, navarromorales, isidorov, 
nicolasfella, firef, andrebarros, alexeymin, emmanuelp

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 146 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/146/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 26 Feb 2018 19:23:10 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31550/59605)38%
(18526/48940)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5231/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8353/14342)50%
(4876/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7872)33%
(1643/4946)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(512/974)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 148 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/148/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Feb 2018 19:23:10 +
 Build duration:
8 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(296/444)67%
(296/444)53%
(31527/59605)38%
(18501/48864)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5232/10797)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8331/14341)50%
(4859/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(31/39)79%
(31/39)49%
(3896/7872)33%
(1643/4946)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 128 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/128/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Feb 2018 19:23:10 +
 Build duration:
7 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D10537: Convert from old connect syntax to new one

[Jaime Torres Amate]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ec296c0ff511: Convert from old connect syntax to new one 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10537?vs=28102=28136

REVISION DETAIL
  https://phabricator.kde.org/D10537

AFFECTED FILES
  src/core/listjob.cpp
  src/core/listjob.h

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D10826: Introduce DocumentId class

[Sune Vuorela]

svuorela added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in documentid.h:51-52
> Make a d poniter in exported class.

it depends on why it is exported. If it is exported just for unit test (and the 
header file not installed), then we don't need to have the mental and code wise 
overhead of a d-pointer.

If we know that it will never ever need to grow, we also don't need the 
overhead of a d-pointer. 
So it is a big "it depends", which I was also kind of trying to ask into 
earlier.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: anthonyfieroni, svuorela, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D10857: Change qSort to std::sort in simplifiedUrlList

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  I'm not opposed to the idea, but measuring CPU usage is a rather misleading 
indicator. What if it takes 10 times longer, because it's progressing much more 
slowly? ;)
  
  Please at least measure with QElapsedTimer around the sorting (not to be 
committed, just to gather numbers about the actual performance of this from a 
user's point of view).
  I'm interested in the result ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

To: jtamate, #frameworks, dfaure
Cc: markg, apol, michaelh

KDE CI: Frameworks kxmlgui kf5-qt5 SUSEQt5.7 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20SUSEQt5.7/16/
 Project:
Frameworks kxmlgui kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 26 Feb 2018 18:38:20 +
 Build duration:
2 min 58 sec and counting
   CONSOLE OUTPUT
  [...truncated 88.94 KB...]-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * KF5Attica (required version >= 5.43.0), A Qt library that implements the Open Collaboration Services API,Support for Get Hot New Stuff in KXMLGUI-- The following REQUIRED packages have been found: * ECM (required version >= 5.43.0), Extra CMake Modules.,  * Qt5Gui (required version >= 5.7.1) * Qt5Widgets * Qt5DBus * Qt5Network * Qt5PrintSupport * KF5CoreAddons (required version >= 5.43.0) * KF5ItemViews (required version >= 5.43.0) * KF5Config (required version >= 5.43.0) * KF5ConfigWidgets (required version >= 5.43.0) * Gettext * PythonInterp * KF5I18n (required version >= 5.43.0) * KF5IconThemes (required version >= 5.43.0) * KF5TextWidgets (required version >= 5.43.0) * KF5WidgetsAddons (required version >= 5.43.0) * KF5WindowSystem (required version >= 5.43.0) * KF5GlobalAccel (required version >= 5.43.0) * Qt5Xml * Qt5Test * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring doneCMake Warning (dev) in src/CMakeLists.txt:  Policy CMP0071 is not set: Let AUTOMOC and AUTOUIC process GENERATED files.  Run "cmake --help-policy CMP0071" for policy details.  Use the cmake_policy  command to set the policy and suppress this warning.  For compatibility, CMake is excluding the GENERATED source file(s):"/home/jenkins/workspace/Frameworks kxmlgui kf5-qt5 SUSEQt5.7/build/src/qrc_kxmlgui.cpp"  from processing by AUTOMOC.  If any of the files should be processed, set  CMP0071 to NEW.  If any of the files should not be processed, explicitly  exclude them by setting the source file property SKIP_AUTOMOC:set_property(SOURCE file.h PROPERTY SKIP_AUTOMOC ON)This warning is for project developers.  Use -Wno-dev to suppress it.CMake Error at src/CMakeLists.txt:73 (add_library):  Target "KF5XmlGui" links to target "Qt5::CorePrivate" but the target was  not found.  Perhaps a find_package() call is missing for an IMPORTED  target, or an ALIAS target is missing?CMake Error at src/CMakeLists.txt:73 (add_library):  Target "KF5XmlGui" links to target "Qt5::CorePrivate" but the target was  not found.  Perhaps a find_package() call is missing for an IMPORTED  target, or an ALIAS target is missing?-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kxmlgui kf5-qt5 SUSEQt5.7/build[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kxmlgui kf5-qt5 SUSEQt5.7] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10757: Reset QLocale internals when we have a custom app language

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:8361ddef0867: Reset QLocale internals when we have a 
custom app language (authored by aacid).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10757?vs=28076=28132

REVISION DETAIL
  https://phabricator.kde.org/D10757

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  autotests/kxmlgui_unittest.h
  src/CMakeLists.txt
  src/kswitchlanguagedialog_p.cpp
  src/kswitchlanguagedialog_p.h

To: aacid, apol, ilic
Cc: lueck, #frameworks, michaelh

D10873: Initialize value

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:75f86f6e54f7: Initialize value (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10873?vs=28127=28130#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10873?vs=28127=28130

REVISION DETAIL
  https://phabricator.kde.org/D10873

AFFECTED FILES
  src/utils/kateconfig.cpp

To: apol, cullmann
Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, demsking, sars, 
dhaumann

D10873: Initialize value

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Default is 1, in readConfig, given that should overwrite it, leave it 0 or 
change it to 1 if you like.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10873

To: apol, cullmann
Cc: cullmann, #frameworks, michaelh, kevinapavew, ngraham, demsking, sars, 
dhaumann

D10716: handle wrong password when using sudo which asks for another password

[Harald Sitter]

sitter added a comment.


  In D10716#212174 , @jriddell wrote:
  
  > I fear that creating a stub replacement wouldn't be necessarily a reliable 
recreation.
  
  
  I am not sure what you mean. If you create a stub from what you observe right 
now then that is a reliable recreation of how sudo 1.89 / su 4.2 behave, is it 
not?

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter
Cc: #frameworks, michaelh

D10873: Initialize value

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  At the moment it wasn't. I'm not sure what the right value is for starters,
  pointers would be welcome

TEST PLAN
  #kate , #frameworks 


REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10873

AFFECTED FILES
  src/utils/kateconfig.cpp

To: apol
Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, 
dhaumann

D10856: Make tests compile, except one

[Michael Heidelbach]

michaelh planned changes to this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10856

To: michaelh, adridg, #baloo, #frameworks
Cc: michaelh

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh planned changes to this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10857: Change qSort to std::sort in simplifiedUrlList

[Mark Gaiser]

markg added a comment.


  +1, also for what @apol said.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

To: jtamate, #frameworks, dfaure
Cc: markg, apol, michaelh

D10537: Convert from old connect syntax to new one

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10537

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D10719: Highlighting for OpenSCAD

[Julian Stirling]

julianstirling added a comment.


  `git format-patch HEAD^^` creates two separate patch files...

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10870: [PackageUrlInterceptor] Don't rewrite "inline"

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  When omitting the third "location" argument of `Qt.createQmlObject` it will 
instead use "inline" [1] as path and will run through the entire URL 
interceptor even logic.
  
  [1] 
https://code.qt.io/cgit/qt/qtdeclarative.git/tree/src/qml/qml/v8/qqmlbuiltinfunctions.cpp#n1134

TEST PLAN
  Task Manager no longer enters the complicated "I dont know what this is" 
guessing code path of the url interceptor

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10870

AFFECTED FILES
  src/plasmaquick/packageurlinterceptor.cpp

To: broulik, #plasma
Cc: #frameworks, michaelh

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, Plasma, hein, aleksejshilin.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  This ensures the application stored in recent documents matches the 
application's service.

TEST PLAN
  Task Manager cuts off the org.kde part so this needs to be adjusted there but 
imho this patch still makes sense

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10863

AFFECTED FILES
  src/core/krecentdocument.cpp

To: broulik, #frameworks, #plasma, hein, aleksejshilin
Cc: michaelh

D10719: Highlighting for OpenSCAD

[Nathaniel Graham]

ngraham added a comment.


  Yeah, all commits need to be in a single patch here.Try doing `git 
format-patch HEAD^^`, which will include the last two commits.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10719: Highlighting for OpenSCAD

[Julian Stirling]

julianstirling added a comment.


  Oh, I was following the guide here 
https://community.kde.org/Infrastructure/Github_Mirror
  So everything I uploaded was a git format-patch, which makes a patch file for 
each commit I made. I shall look into arc when I get a chance.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10719

To: julianstirling, dhaumann
Cc: dhaumann, ngraham, #frameworks, michaelh

D10860: Do not allow to configure separator actions via context menu

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:67c59d7bb56e: Do not allow to configure separator actions 
via context menu (authored by mwolff).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10860?vs=28108=28110#toc

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10860?vs=28108=28110

REVISION DETAIL
  https://phabricator.kde.org/D10860

AFFECTED FILES
  src/kmenumenuhandler_p.cpp

To: mwolff, dfaure, broulik
Cc: broulik, #frameworks, michaelh

D10860: Do not allow to configure separator actions via context menu

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10860

To: mwolff, dfaure, broulik
Cc: broulik, #frameworks, michaelh

D10860: Do not allow to configure separator actions via context menu

[Milian Wolff]

mwolff updated this revision to Diff 28108.
mwolff added a comment.


  rebase

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10860?vs=28106=28108

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10860

AFFECTED FILES
  src/kmenumenuhandler_p.cpp

To: mwolff, dfaure
Cc: broulik, #frameworks, michaelh

D9675: Don't show context menu menu if right-clicking outside

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R263:5381b8b4b76c: Dont show context menu menu if 
right-clicking outside (authored by broulik).

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9675?vs=24760=28107

REVISION DETAIL
  https://phabricator.kde.org/D9675

AFFECTED FILES
  src/kmenumenuhandler_p.cpp

To: broulik, #frameworks, dfaure, mwolff
Cc: elvisangelaccio, wbauer, michaelh

D10860: Do not allow to configure separator actions via context menu

[Kai Uwe Broulik]

broulik added a comment.


  +1, note that action can be null

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D10860

To: mwolff, dfaure
Cc: broulik, #frameworks, michaelh

D9675: Don't show context menu menu if right-clicking outside

[Milian Wolff]

mwolff accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D9675

To: broulik, #frameworks, dfaure, mwolff
Cc: elvisangelaccio, wbauer, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/77/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 26 Feb 2018 13:47:04 +
 Build duration:
7 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3557/13336)19%
(1977/10555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2012)17%
(306/1761)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

D10860: Do not allow to configure separator actions via context menu

[Milian Wolff]

mwolff created this revision.
mwolff added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
mwolff requested review of this revision.

REVISION SUMMARY
  It's not useful to add shortcuts for separators, nor to add them
  to the toolbar. This patch prevents the confusing user interaction.
  Note that the menu will instead be hidden, just like when you'd
  left-click on a separator. But I guess this strange behavior should
  be changed in Qt upstream instead (to keep the menu open).

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10860

AFFECTED FILES
  src/kmenumenuhandler_p.cpp

To: mwolff, dfaure
Cc: #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/74/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Feb 2018 13:47:04 +
 Build duration:
5 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13341)19%
(1979/10555)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2012)17%
(306/1761)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 50 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/50/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Feb 2018 13:47:04 +
 Build duration:
1 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 18.21 KB...] > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision dbf563df2979361e9b97088e757f95315296ea19 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f dbf563df2979361e9b97088e757f95315296ea19Commit message: "Move Elisa from KDE Review to Extragear - Multimedia as requested. Ref T8080"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision aadde05ae63bb72c621067a187e7b9c08f4f74e2 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f aadde05ae63bb72c621067a187e7b9c08f4f74e2Commit message: "Update path to Kamoso"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project plasma-framework --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.9 --installTo /usr/home/jenkins/install-prefix/Retrieving: Frameworks-extra-cmake-modules-kf5-qt5Retrieving: Frameworks-karchive-kf5-qt5Retrieving: Frameworks-ki18n-kf5-qt5Retrieving: Frameworks-kcoreaddons-kf5-qt5Retrieving: Frameworks-kwindowsystem-kf5-qt5Retrieving: Frameworks-kconfig-kf5-qt5Retrieving: Frameworks-kcrash-kf5-qt5Retrieving: Frameworks-kdbusaddons-kf5-qt5Retrieving: Frameworks-kdoctools-kf5-qt5Retrieving: Frameworks-kauth-kf5-qt5Retrieving: Frameworks-kcodecs-kf5-qt5Retrieving: Frameworks-kguiaddons-kf5-qt5Retrieving: Frameworks-kwidgetsaddons-kf5-qt5Retrieving: Frameworks-kconfigwidgets-kf5-qt5Retrieving: Frameworks-kitemviews-kf5-qt5Retrieving: Frameworks-kcompletion-kf5-qt5Retrieving: Frameworks-kiconthemes-kf5-qt5Retrieving: Frameworks-kservice-kf5-qt5Retrieving: Frameworks-sonnet-kf5-qt5Retrieving: Frameworks-attica-kf5-qt5Retrieving: Frameworks-kglobalaccel-kf5-qt5Retrieving: Frameworks-ktextwidgets-kf5-qt5Retrieving: Frameworks-breeze-icons-kf5-qt5Retrieving: Frameworks-phonon-kf5-qt5Retrieving: Frameworks-knotifications-kf5-qt5Retrieving: Frameworks-kxmlgui-kf5-qt5Retrieving: Frameworks-solid-kf5-qt5Retrieving: Frameworks-kjobwidgets-kf5-qt5Retrieving: Frameworks-kbookmarks-kf5-qt5Retrieving: Frameworks-kwallet-kf5-qt5Retrieving: Frameworks-kio-kf5-qt5Retrieving: Frameworks-kparts-kf5-qt5Retrieving: Frameworks-syntax-highlighting-kf5-qt5Retrieving: Frameworks-kpackage-kf5-qt5Retrieving: Frameworks-kactivities-kf5-qt5Retrieving: Frameworks-kdnssd-kf5-qt5Retrieving: Frameworks-kdeclarative-kf5-qt5Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 70, in filename, metadata = packageArchive.retrievePackage( package )  File "/usr/home/jenkins/workspace/Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9/ci-tooling/helpers/helperslib/Packages.py", line 115, in retrievePackagelatestContent.write( response.read() )  File "/usr/local/lib/python3.5/http/client.py", line 461, in reads = self._safe_read(self.length)  File "/usr/local/lib/python3.5/http/client.py", line 607, in _safe_readchunk = self.fp.read(min(amt, MAXAMOUNT))  File "/usr/local/lib/python3.5/socket.py", line 576, in readintoreturn self._sock.recv_into(b)  File "/usr/local/lib/python3.5/ssl.py", line 937, in recv_intoreturn self.read(nbytes, buffer)  File 

D10857: Change qSort to std::sort in simplifiedUrlList

[Aleix Pol Gonzalez]

apol added a comment.


  +1
  If there's 11, we better change them all at once?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

To: jtamate, #frameworks, dfaure
Cc: apol, michaelh

D10537: Convert from old connect syntax to new one

[Jaime Torres Amate]

jtamate updated this revision to Diff 28102.
jtamate added a comment.


  Fixed David comments.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10537?vs=27238=28102

REVISION DETAIL
  https://phabricator.kde.org/D10537

AFFECTED FILES
  src/core/listjob.cpp
  src/core/listjob.h

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D10857: Change qSort to std::sort in simplifiedUrlList

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.

REVISION SUMMARY
  qSort is depecreated in Qt5.
  But qSort is also quite slow compared to std::sort.
  
  There are 11 more uses of qSort in kio.

TEST PLAN
  Select 50.000 small files and press Shift-Supr.
  With qSort 11% of cpu
  F5730673: qSortOneTime.png 
  
  Select 50.000 small files and press Shift-Supr, cancel and press Shift-Supr 
again.
  With std::sort 3.3% of cpu
  F5730676: stdSortTwoTimes.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10857

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh

D10848: Templates: consistent naming, fix translation catalog names & more

[Friedrich W . H . Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> apol wrote in metadata.desktop:88
> I'm not sure, if a 3rd party makes a plasmoid they would call it otherwise. 
> Are we assuming these templates are only for KDE?

Ideally the kapptemplate system would have support for an organization domain 
parameter which then could be used here (on my notes for some kapptemplatev2).

For now this brush-over is proposed with KDE community contributors in mind, to 
help them getting applets properly prepared e.g. with integration into KDE 
translations right from the begin.

Any 3rd-party which wants to keep their plasmoid 3rd-party would need to adapt 
the org namespace as desired, which I would expect them to do anyway if they 
are proud of their org.

> apol wrote in %{APPNAMELC}plugin.cpp:33
> Isn't his a rather clunky dependency there? I like templates as easy and 
> plain as possible...

Yes, not completly sure about this one.
But having seen people not getting translation setup correctly, it felt better 
to add the include and ki18n linking from the start, as removing those lines is 
easier then adding them correctly.
So I would make an exception here for ki18n. But maintainers call, just 
proposing.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10848

To: kossebau, mart
Cc: apol, #frameworks, michaelh

D10856: Make tests compile, except one

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> iohandlertest.cpp:32
> +//FIXME: Does not link with DocId in ../iohandler.h. Why?
>  #include "../iohandler.h"
> +

Error is:

  [ 34%] Linking CXX executable ../../../../bin/extractorIOTest
  CMakeFiles/extractorIOTest.dir/iohandlertest.cpp.o: In function 
`Baloo::IOHandlerTest::testInput()':
  
~/src/frameworks/baloo-flex/src/file/extractor/autotests/iohandlertest.cpp:72: 
undefined reference to `Baloo::DocumentId::~DocumentId()'
  CMakeFiles/extractorIOTest.dir/iohandlertest.cpp.o: In function `bool 
QTest::qCompare(Baloo::DocumentId 
const&, unsigned long long const&, char const*, char const*, char const*, int)':
  /usr/include/qt5/QtTest/qtestcase.h:397: undefined reference to 
`Baloo::DocumentId::operator unsigned long long() const'
  CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o: In function 
`Baloo::IOHandler::nextId()':
  ~/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:47: undefined 
reference to `Baloo::DocumentId::DocumentId(unsigned long long)'
  ~/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:50: undefined 
reference to `Baloo::DocumentId::operator unsigned long long() const'
  collect2: error: ld returned 1 exit status

fileextractor is special. It is a daemon and not part of the lib.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10856

To: michaelh, adridg, #baloo, #frameworks
Cc: michaelh

D10851: autotests: Introduce alias DocId

[Michael Heidelbach]

michaelh added a comment.


  This will be abandoned in favor of D10856 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10851

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10856: Make tests compile, except one

[Michael Heidelbach]

michaelh added a dependency: D10829: Use DocumentId class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10856

To: michaelh, adridg, #baloo, #frameworks
Cc: michaelh

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh added a dependent revision: D10856: Make tests compile, except one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10856: Make tests compile, except one

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: adridg, Baloo, Frameworks.
Restricted Application added a project: Frameworks.
michaelh requested review of this revision.

TEST PLAN
  make test

REPOSITORY
  R293 Baloo

BRANCH
  use-class-tests-compile (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10856

AFFECTED FILES
  autotests/benchmarks/CMakeLists.txt
  autotests/integration/CMakeLists.txt
  autotests/integration/dbstate.h
  autotests/integration/querytest.cpp
  autotests/integration/writetransactiontest.cpp
  autotests/unit/codecs/CMakeLists.txt
  autotests/unit/codecs/postingcodectest.cpp
  autotests/unit/engine/andpostingiteratortest.cpp
  autotests/unit/engine/documentiddbtest.cpp
  autotests/unit/engine/idtreedbtest.cpp
  autotests/unit/engine/mtimedbtest.cpp
  autotests/unit/engine/orpostingiteratortest.cpp
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/iohandler.h

To: michaelh, adridg, #baloo, #frameworks
Cc: michaelh

D10848: Templates: consistent naming, fix translation catalog names & more

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> metadata.desktop:88
>  X-KDE-PluginInfo-Email=%{EMAIL}
> -X-KDE-PluginInfo-Name=%{APPNAMELC}
> +X-KDE-PluginInfo-Name=org.kde.plasma.%{APPNAMELC}
>  X-KDE-PluginInfo-Version=1.0

I'm not sure, if a 3rd party makes a plasmoid they would call it otherwise. Are 
we assuming these templates are only for KDE?

> %{APPNAMELC}plugin.cpp:33
>  QJSValue helloWorld = scriptEngine->newObject();
> -helloWorld.setProperty("text", QStringLiteral("Hello world!"));
> +helloWorld.setProperty("text", i18n("Hello world!"));
>  return helloWorld;

Isn't his a rather clunky dependency there? I like templates as easy and plain 
as possible...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10848

To: kossebau, mart
Cc: apol, #frameworks, michaelh

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Ivan Čukić]

ivan added a comment.


  The fix needs to be a bit more complex. We can not really rely on the user to 
fix the database.
  
  The current plan is to have kamd backup the important parts of the database 
from time to time, and to recreate the database when needed.
  
  I'll see whether I can roll out a crash=>fail-with-a-message patch for the 
LTS.
  
  The current implementation relied on my (wrong) assumption that sqlite is 
very stable and that it can not go berserk and corrupt the database. :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein, ivan
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10537: Convert from old connect syntax to new one

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> listjob.cpp:140
> +QObject::connect(job, ::entries, q,
> +[this](KIO::Job *job,const KIO::UDSEntryList ) 
> {gotEntries(job, list);} );
> +QObject::connect(job, ::subError, q,

missing space after comma
[it wasn't there in SIGNAL/SLOT for string normalization purposes, but here 
it's a lambda function, not a string anymore]

> listjob.cpp:142
> +QObject::connect(job, ::subError, q,
> +[this](KIO::ListJob *job,KIO::ListJob *ljob) 
> {slotSubError(job, ljob);} );
> +

space after ','

> listjob.cpp:288
> +QObject::connect(slave, ::listEntries, q,
> +[this](KIO::UDSEntryList list){ slotListEntries(list);} );
> +

const KIO::UDSEntryList &

> listjob.cpp:294
> +QObject::connect(slave, ::redirection, q,
> +[this](QUrl url){ slotRedirection(url);} );
>  

const QUrl &

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10537

To: jtamate, #frameworks, dfaure
Cc: broulik, michaelh

D10235: [server] Add support for the frame semantics of Pointer version 5

[Ben Cooksley]

bcooksley edited projects, added Plasma; removed Plasma on Wayland.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.

REPOSITORY
  R127 KWayland

BRANCH
  server-pointer-frame-semantics

REVISION DETAIL
  https://phabricator.kde.org/D10235

To: graesslin, #kwin, #plasma, #frameworks, romangg
Cc: romangg, plasma-devel, schernikov, michaelh, ZrenBot, alexeymin, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D10826: Introduce DocumentId class

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> documentid.h:51-52
> +private:
> +DeviceId m_device;
> +Inode m_inode;
> +};

Make a d poniter in exported class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: anthonyfieroni, svuorela, ashaposhnikov, michaelh, spoorun, nicolasfella, 
alexeymin

D10826: Introduce DocumentId class

[Michael Heidelbach]

michaelh added a comment.


  I have made two errors:
  
  1. Forgot to submit the adapted tests
  2. An error in reasoning: I have based this and D10829 
 on a branch with the adapted tests  . As 
long as the changes are expected to be transparent it is much better to use the 
original tests. (This will also postpone the linker problems a little)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: svuorela, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10851: autotests: Introduce alias DocId

[Michael Heidelbach]

michaelh retitled this revision from "autotests: Introduce aliases DocId, 
DeviceId and Inode" to "autotests: Introduce alias DocId".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10851

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh added a dependent revision: D10851: autotests: Introduce alias DocId.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: ngraham, alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10851: autotests: Introduce alias DocId

[Michael Heidelbach]

michaelh added a dependency: D10825: Introduce aliases DocId, DeviceId and 
Inode.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10851

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D10851: autotests: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh added reviewers: adridg, Baloo, Frameworks.
michaelh added a project: Baloo.
michaelh removed a subscriber: Frameworks.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10851

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin