D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  ref_upd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12892

To: maximilianocuria, #frameworks, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12896: Add Telegram plugin

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> nicolasfella wrote in telegramplugin.cpp:61
> How would I do that?

https://api.kde.org/frameworks/kio/html/classKIO_1_1DesktopExecParser.html
https://cgit.kde.org/discover.git/tree/libdiscover/backends/PackageKitBackend/runservice/main.cpp?h=Plasma/5.12

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12787: Ignore more types of source files

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:7529727e4624: Ignore more types of source files (authored 
by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12787?vs=34155=34241

REVISION DETAIL
  https://phabricator.kde.org/D12787

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham, michaelh, bruns
Cc: broulik, cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

[Nathaniel Graham]

ngraham added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  So what's our path forward? I'd prefer to land this as-is since it does 
indeed fix the bug for now, and then we can have a larger discussion regarding 
what to do about the fact that `KWidgetsAddons` can't access all the colors 
from the active scheme, which is an issue for multiple things, not just this 
thing here.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12756

To: ngraham, #frameworks, cfeck
Cc: kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12647: Move the inline preview button into the menu

[Nathaniel Graham]

ngraham added a comment.


  Friendly ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12647

To: ngraham, #frameworks, rkflx
Cc: kde-frameworks-devel, anemeth, michaelh, ngraham, bruns

D12233: Avoid manipulation of lists with quadratic complexity

[Nathaniel Graham]

ngraham added a comment.


  You could commandeer it and finish it yourself I guess. :-(
  
  I'll see if I can contact Michael.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, 
astippich, spoorun

D12848: Set fix steps for icon sizes

[Nathaniel Graham]

ngraham added a comment.


  In D12848#262776 , @rkflx wrote:
  
  > I'm confused: First you propose a common widget, and then you say Gwenview 
needs arbitrary zoom levels?
  
  
  A common widget could easily support both steps and continuous zooming
  
  But the more I think about it, the more I'm starting to agree with you that 
continuous zooming is fine as long as we have buttons that implement a sort of 
step mode for people who want that. If I think about the reasons why //I'd// 
want step mode, it's to be able to set the icons to a known, integer value 
size, mostly because of OCD tendencies. :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: elvisangelaccio, broulik, rkflx, ngraham, kde-frameworks-devel, michaelh, 
bruns

D12895: WIP: Add KFileItemActionsPlugin

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> purposefileitemaction.desktop:1-8
> +[Desktop Entry]
> +Type=Service
> +Name=Share file
> +X-KDE-Library=purposefileitemaction
> +X-KDE-Submenu=Share
> +Icon=document-share
> +ServiceTypes=KFileItemAction/Plugin

Why not just starting with JSON metadata? (since this is a new plugin)

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

To: broulik, #plasma, #vdg, apol
Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

[Elvis Angelaccio]

elvisangelaccio added a comment.


  I'd also prefer adding continuous zooming in Dolphin rather than removing it 
here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: elvisangelaccio, broulik, rkflx, ngraham, kde-frameworks-devel, michaelh, 
bruns

D12858: [KCharSelect] Fix table cell width

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1, tested with Qt 5.11 RC1.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12858

To: cfeck, #frameworks
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D12578: fix some issues reported by clazy

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> searchstore.cpp:163
>  if (term.operation() == Term::And || term.operation() == Term::Or) {
>  QList subTerms = term.subTerms();
>  QVector vec;

`const QList subterms = ...`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12578

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Luigi Toscano]

ltoscano added a comment.


  Looks fine by me, let's see if there are other comments.

INLINE COMMENTS

> KF5I18NMacros.cmake.in:138-139
>  
> -file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname})
> -install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION 
> ${destname})
> +file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname})
> +install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${dirname} DESTINATION 
> ${destname})
> +endif()

I guess that those two lines are the critical parts (the call to file), but 
probably it's not bad to avoid processing other instructions too.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Luigi Toscano]

ltoscano added a reviewer: ilic.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12578: fix some issues reported by clazy

[Matthieu Gallien]

mgallien updated this revision to Diff 34223.
mgallien added a comment.


  fix some issues

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12578?vs=33247=34223

BRANCH
  arcpatch-D12578

REVISION DETAIL
  https://phabricator.kde.org/D12578

AFFECTED FILES
  autotests/unit/file/pendingfilequeuetest.cpp
  src/engine/transaction.cpp
  src/file/fileindexerconfig.cpp
  src/file/fileindexscheduler.cpp
  src/file/firstrunindexer.cpp
  src/file/indexcleaner.cpp
  src/file/modifiedfileindexer.cpp
  src/file/newfileindexer.cpp
  src/file/xattrindexer.cpp
  src/kioslaves/kded/baloosearchmodule.cpp
  src/lib/query.cpp
  src/lib/searchstore.cpp
  src/lib/taglistjob.cpp
  src/lib/term.cpp

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
heikobecker requested review of this revision.

REVISION SUMMARY
  I saw this happen with kdecoration from git since
  64d9f92f6a8708814f414dda0bb0d0e91c27235f 
. 
The directory passed in
  its ki18n_install call doesn't exist, resulting in an empty
  directory (LOCALE_INSTALL_DIR) getting installed, which at least
  some packaging systems don't like.

TEST PLAN
  Tested with kdecoration from git and tarballs where podir
  exists

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12905

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: heikobecker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12388: Output device color curves correction

[Martin Flöser]

graesslin added inline comments.
Restricted Application added a subscriber: kde-frameworks-devel.

INLINE COMMENTS

> outputchangeset.cpp:91
>  }
> +
>  bool OutputChangeSet::positionChanged() const

nitpick: added unrelated new line

> outputdevice_interface.cpp:427
> +
> +org_kde_kwin_outputdevice_send_colorcurves(data.resource, , 
> , );
> +

you need to do a version check and only send to clients which have the required 
version. A FOO_SINCE macro should be defined by the generated wayland header.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12388

To: romangg, #frameworks, davidedmundson, graesslin
Cc: kde-frameworks-devel, graesslin, davidedmundson, zzag, cfeck, michaelh, 
ngraham, bruns

Re: kfilemetadata compile failure

[Albert Astals Cid]

El dimarts, 15 de maig de 2018, a les 9:09:23 CEST, David Faure va escriure:
> On mardi 15 mai 2018 01:14:12 CEST Albert Astals Cid wrote:
> > El dilluns, 14 de maig de 2018, a les 22:33:12 CEST, Matthieu Gallien va
> > 
> > escriure:
> > > I was meaning to have a fix on top of v5.46.0 that may be released as a
> > > v5.46.1 if needed.
> > 
> > Ah, that's up to David if he thinks it makes sense to have such a release
> > or not. Worst case scenario you can always email kde-distro-packagers and
> > tell them what the patch is in case they need to compile with old
> > verisons.
> Well, it's up to the packagers to tell me if many of them are affected by
> the kfilemetadata compile failure with ffmpeg < 3.1.

Jonathan already complained, does that count?

Cheers,
  Albert

> If so, I can make a kfilemetadata v.5.46.1, but otherwise I would be just
> creating unnecessary work for them.

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> apol wrote in telegramplugin.cpp:61
> Instead of finding the program, we could execute using 
> `org.telegram.desktop.desktop`, it would allow it to work even if it's 
> installed from appimage/flatpak.
> 
> I'm not sure how this would work without bumping the tier.

How would I do that?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella marked 2 inline comments as done.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella updated this revision to Diff 34213.
nicolasfella added a comment.


  - Use url.toLocalfile()

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12896?vs=34200=34213

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12896

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/telegram/CMakeLists.txt
  src/plugins/telegram/Messages.sh
  src/plugins/telegram/debug.h
  src/plugins/telegram/telegramplugin.cpp
  src/plugins/telegram/telegramplugin.json

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> telegramplugin.cpp:53
> +foreach(const QJsonValue& val, array) {
> +ret += toPath(val.toString());
> +}

toUrl().toLocalFile().

Also I would Check if(url.isLocalFile()).

> telegramplugin.cpp:61
> +QProcess* process = new QProcess(this);
> +process->setProgram(QStringLiteral("telegram-desktop"));
> +QJsonArray urlsJson = 
> data().value(QStringLiteral("urls")).toArray();

Instead of finding the program, we could execute using 
`org.telegram.desktop.desktop`, it would allow it to work even if it's 
installed from appimage/flatpak.

I'm not sure how this would work without bumping the tier.

> telegramplugin.cpp:63
> +QJsonArray urlsJson = 
> data().value(QStringLiteral("urls")).toArray();
> +qCDebug(PLUGIN_TELEGRAM()) << "Foo" << urlsJson;
> +process->setArguments(QStringList(QStringLiteral("-sendpath")) 
> << arrayToList(urlsJson));

Fix or remove debug message.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

[Matthieu Gallien]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:3415015e3d45: check that ffmpeg is at least version 3.1 
that introduce the API we require (authored by mgallien).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12886?vs=34174=34208

REVISION DETAIL
  https://phabricator.kde.org/D12886

AFFECTED FILES
  CMakeLists.txt

To: mgallien, dfaure, michaelh, jriddell, bruns
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12896: Add Telegram plugin

[Nathaniel Graham]

ngraham added a comment.


  If it's 99% identical except for the name and command, would it make more 
sense to create a generic "send to app/service" plugin that you can feed 
different executables into? Then we could even expose that configuration in the 
UI somewhere to allow people to easily define their own!

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12896

To: nicolasfella, apol
Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12898: Add missing header

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Frameworks, mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  xdgforeign defines exported classes, and is included by the installed
  xdgforeign_v2.h.

REPOSITORY
  R127 KWayland

BRANCH
  missing_header (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12898

AFFECTED FILES
  src/client/CMakeLists.txt

To: maximilianocuria, #frameworks, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Kate, Frameworks.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Most of the time was spent allocating space for the hashdata.
  The perf numbers speak by themself: 
  from 42.3% (cycles inc.) F5849664: kwrite_reserver_perf_dwarf_before.png 

  to 16.1% (cycles inc.) F5849665: kwrite_reserver_perf_dwarf_after.png 


TEST PLAN
  repeat {
  
Paste, go to beginning of file
  
  } 5 times
  Undo 5 times

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12897

AFFECTED FILES
  src/buffer/katetextblock.cpp

To: jtamate, #kate, #frameworks
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D12734: Scale up folder icon before creating preview overlays

[Peter Mühlenpfordt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:bafc90d730f2: Scale up folder icon before creating 
preview overlays (authored by muhlenpfordt).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12734?vs=33822=34202

REVISION DETAIL
  https://phabricator.kde.org/D12734

AFFECTED FILES
  thumbnail/thumbnail.cpp

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 15 May 2018 14:40:33 +
 Build duration:
6 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 14 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testIdleFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/44/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 15 May 2018 14:40:33 +
 Build duration:
5 min 51 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24046/28683)52%
(11757/22674)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11194/11476)49%
(7684/15553)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5673/6728)65%
(1779/2748)src.server97%
(111/115)97%
(111/115)86%
(6820/7956)64%
(2074/3248)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/15/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 15 May 2018 14:40:33 +
 Build duration:
5 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)83%
(23878/28680)51%
(11633/22674)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)96%
(11060/11476)49%
(7583/15553)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5664/6727)65%
(1775/2748)src.server97%
(111/115)97%
(111/115)85%
(6795/7954)63%
(2055/3248)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1255)0%
(0/317)

D12235: Add XDG Output Protocol

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4705c38ff12b: Add XDG Output Protocol (authored by 
davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12235?vs=34190=34201

REVISION DETAIL
  https://phabricator.kde.org/D12235

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_output.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-output-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h
  src/tools/mapping.txt

To: davidedmundson, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12896: Add Telegram plugin

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Add a "Share via Telegram plugin". It's a copy of the KDE Connect plugin with 
name/command substituted. Telegram expects the path without file:// prefix so 
it is removed when found.

TEST PLAN
  Share from Okular works.
  Share from Spectacle does not work since Spectacle does not give an URL but 
the image data.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12896

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/telegram/CMakeLists.txt
  src/plugins/telegram/Messages.sh
  src/plugins/telegram/debug.h
  src/plugins/telegram/telegramplugin.cpp
  src/plugins/telegram/telegramplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D12047: Avoid crash when reading corrupt data from document terms db

[Stefan Brüns]

bruns added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Kind request to review ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12047

To: bruns, #baloo, michaelh, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12578: fix some issues reported by clazy

[Matthieu Gallien]

mgallien added a comment.


  In D12578#262831 , @bruns wrote:
  
  > @mgallien - I think this is trivial to fix up - can you do, so we have one 
less request open?
  
  
  I will do but as I had started working on that as a low priority task, I have 
not yet been able to correctly fix the issues.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12578

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12895: WIP: Add KFileItemActionsPlugin

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

To: broulik, #plasma, #vdg, apol
Cc: abetts, ngraham, kde-frameworks-devel, michaelh, bruns

D12233: Avoid manipulation of lists with quadratic complexity

[Stefan Brüns]

bruns added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Apparently @michaelh is MIA - how do we proceed here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12233

To: michaelh, #baloo, bruns
Cc: kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, #frameworks

D12578: fix some issues reported by clazy

[Stefan Brüns]

bruns added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  @mgallien - I think this is trivial to fix up - can you do, so we have one 
less request open?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12578

To: mgallien, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12787: Ignore more types of source files

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Not tested by me, by looks good in general.

REPOSITORY
  R293 Baloo

BRANCH
  more-excluded-source-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham, michaelh, bruns
Cc: broulik, cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.


  +1

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12886

To: mgallien, dfaure, michaelh, jriddell, bruns
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

D12895: WIP: Add KFileItemActionsPlugin

[Nathaniel Graham]

ngraham added a comment.


  Fantastic! I've wanted this for so long!
  
  That "send as email attachment" item you have in your Dolphin context menu... 
is that a separate service item provided by KMail that will become obsolete 
with this new share menu? Seems kinda redundant to have them both...

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

To: broulik, #plasma, #vdg, apol
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12895: WIP: Add KFileItemActionsPlugin

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to share files from Dolphin's file context menu and notification 
thumbnails.

TEST PLAN
  Menu shows different actions depending on file type, e.g. imgur is only 
offered for images
  
  TODO: When I click Imgur, the progress dialog shows up but the finished 
handler is never invoked :(
  F5849461: Screenshot_20180515_153434.png 


REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D12895

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/fileitemactionplugin/CMakeLists.txt
  src/fileitemactionplugin/purposefileitemaction.desktop
  src/fileitemactionplugin/sharefileitemaction.cpp
  src/fileitemactionplugin/sharefileitemaction.h

To: broulik, #plasma, #vdg, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12734: Scale up folder icon before creating preview overlays

[Henrik Fehlauer]

rkflx added a comment.


  In D12734#262368 , @muhlenpfordt 
wrote:
  
  > Ok to commit?
  
  
  Sure, go ahead 

REPOSITORY
  R320 KIO Extras

BRANCH
  scale-up-folder-icon (branched from Applications/18.04)

REVISION DETAIL
  https://phabricator.kde.org/D12734

To: muhlenpfordt, #frameworks, rkflx
Cc: ngraham, rkflx

D12848: Set fix steps for icon sizes

[Henrik Fehlauer]

rkflx added a comment.


  > In the open/save dialog use the same fixed icon sizes for the zoom slider 
as Dolphin.
  
  So we could also change Dolphin to support continuous zoom instead? As the 
summary is quite sparse, I'm not sure what the patch is about: Is it about 
consistency, or is there a fundamental reason why fixed sizes are better for 
users?
  
  Note that we allow arbitrary window sizes, sidebar sizes and so on. Targeting 
a specific icon size can still easily be done by clicking on the button, or by 
dragging the slider while observing the tooltip showing the pixel size.
  
  Personally I prefer smooth zooming (which Dolphin is doing, too) instead of 
having big jumps between steps. Nevertheless, if you can find more +1's and 
better reasons for the change itself, I'm not going to block this patch. 
However, "nobody complained for Dolphin" is not good enough of a reason.
  
  Could you research why for Dolphin there are discrete sizes? Maybe this stems 
from pre-SVG times, where only certain pixel sizes had sharp rendering of 
icons. If this is the case, with today's SVGs we could easily support all 
in-between sizes without much loss of rendering quality.
  
  In D12848#262303 , @ngraham wrote:
  
  > IMHO what we really need is a standard size slider widget so that each app 
doesn't need to reinvent the wheel. Right now Gwenview, Dolphin, and the file 
dialogs each implement their own, and they're all subtly (or very) different 
from each other.
  >
  > That said, I find myself agreeing with Kai and Alex here. Arbitrary zoom 
levels aren't really needed in the file dialog like they are in Gwenview. 
Dolphin's slider has discrete sizes and I don't think it causes problems there.
  
  
  I'm confused: First you propose a common widget, and then you say Gwenview 
needs arbitrary zoom levels?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: broulik, rkflx, ngraham, kde-frameworks-devel, michaelh, bruns

D12235: Add XDG Output Protocol

[Roman Gilg]

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12235

To: davidedmundson, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12235: Add XDG Output Protocol

[David Edmundson]

davidedmundson updated this revision to Diff 34190.
davidedmundson added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Add check for if values haven't really changed
  Renamed a var
  A few more comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12235?vs=33341=34190

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12235

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_output.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-output-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h
  src/tools/mapping.txt

To: davidedmundson, romangg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

[Maximiliano Curia]

maximilianocuria created this revision.
maximilianocuria added reviewers: Frameworks, mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
maximilianocuria requested review of this revision.

REVISION SUMMARY
  Since "Use override" (3985f2a0 
) 
kconfig_compiler.cpp
  generates usrSave with override instead of Q_DECL_OVERRIDE. This causes
  the KConfigCompiler_Test to fail [1], as the reference file of the test
  was not updated.
  
  [1]: https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/32/

REPOSITORY
  R237 KConfig

BRANCH
  ref_upd (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12892

AFFECTED FILES
  autotests/kconfig_compiler/test_signal.h.ref

To: maximilianocuria, #frameworks, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12886: check that ffmpeg is at least version 3.1 that introduce the API we require

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Even old OpenSuSE Leap 42.3 has ffmpeg 3.3.4, so this seems fine ;-)

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12886

To: mgallien, dfaure, michaelh, jriddell
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

Re: kfilemetadata compile failure

[David Faure]

On mardi 15 mai 2018 01:14:12 CEST Albert Astals Cid wrote:
> El dilluns, 14 de maig de 2018, a les 22:33:12 CEST, Matthieu Gallien va
> 
> escriure:
> > I was meaning to have a fix on top of v5.46.0 that may be released as a
> > v5.46.1 if needed.
> 
> Ah, that's up to David if he thinks it makes sense to have such a release or
> not. Worst case scenario you can always email kde-distro-packagers and tell
> them what the patch is in case they need to compile with old verisons.

Well, it's up to the packagers to tell me if many of them are affected by the 
kfilemetadata compile failure with ffmpeg < 3.1.
If so, I can make a kfilemetadata v.5.46.1, but otherwise I would be just 
creating unnecessary work for them.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10 - Build # 15 - Failure!

[CI System]

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38):
${JELLY_SCRIPT,template="html_gmail"}
 ^

java.io.IOException: remote file operation failed: C:\CI\workspace\Frameworks knotifications kf5-qt5 WindowsMSVCQt5.10\html_gmail.jelly at hudson.remoting.Channel@2023dda0:JNLP4-connect connection from artonis.kde.org/195.201.167.115:62610: hudson.remoting.ChannelClosedException: Channel "unknown": Remote call on JNLP4-connect connection from artonis.kde.org/195.201.167.115:62610 failed. The channel is closing down or has closed down