D12295: Supporting nested brackets for Kate autobrackets

[Nathaniel Graham]

ngraham added reviewers: Kate, cullmann, dhaumann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12295

To: sraizada, #ktexteditor, #kate, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D12295: Supporting nested brackets for Kate autobrackets

[Subramaniyam Raizada]

sraizada updated this revision to Diff 34333.
sraizada added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel, 
kwrite-devel; removed: Frameworks.


  Improved patch, closing brackets get eaten properly in all cases I tested.
  
  The only issue I found is that matching bracket highlighting can be off when 
entering 'incorrect' sequences of braces. Such as in this example, where the ) 
in the middle causes the second-to-last parenthesis to be matched with the 
first one.
  F5852484: highlighting.png 
  
  The bracket-eating behaviour with such incorrect sequences is to simple 
ignore the incorrect ) in the middle - all four of the }})) at the end will get 
eaten. Out of the three other text editors I tested (IntelliJ, Sublime Text, 
and 'micro'), Sublime and micro also behave this way.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12295?vs=32417=34333

REVISION DETAIL
  https://phabricator.kde.org/D12295

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: sraizada, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, kevinapavew, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann, #frameworks

D12932: handle string lists as input

[Stefan Brüns]

bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.


  Output looks sane for me.

REPOSITORY
  R293 Baloo

BRANCH
  string_lists

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12932: handle string lists as input

[Alexander Stippich]

astippich added a comment.


  with D11365  applied (e.g. multiple 
entries are string lists) and using a file with multiple artists
  
  balooshow -x testmultiple.opus
  
  Bitrate: 67000
  Channels: 1
  Duration: 1
  Genre: Genre
  Sample Rate: 48000
  Track Number: 1
  Release Year: 2015
  Comment: Comment
  Artist: artist2, artist1
  Album: Album
  Album Artist: Album Artist
  Composer: Composer
  Lyricist: Lyricist
  Title: Title
  Disc Number: 1

Internal Info
Terms: Maudio Mogg Mopus Mx T2 Taudio X1-67000 X10-album X11-album 
X11-artist X12-composer X13-lyricist X15-title X2-1 X3-1 X4-genre X5-48000 X6-1 
X62-1 X7-2015 X8-comment album artist title 
File Name Terms: Fopus Ftestmultiple opus testmultiple 
XAttr Terms: 
albumArtist: album artist
comment: comment
discNumber: 1
title: title
composer: composer
lyricist: lyricist
channels: 1
duration: 1
bitRate: 67000
trackNumber: 1
releaseYear: 2015
genre: genre
sampleRate: 48000
album: album
  
  after
  
  Bitrate: 67000
  Channels: 1
  Duration: 1
  Genre: Genre
  Sample Rate: 48000
  Track Number: 1
  Release Year: 2015
  Comment: Comment
  Artist: artist2, artist1
  Album: Album
  Album Artist: Album Artist
  Composer: Composer
  Lyricist: Lyricist
  Title: Title
  Disc Number: 1

Internal Info
Terms: Maudio Mogg Mopus Mx T2 Taudio X1-67000 X10-album X11-album 
X11-artist X12-composer X13-lyricist X15-title X2-1 X3-1 X4-genre X5-48000 X6-1 
X62-1 X7-2015 X8-comment X9-artist1 X9-artist2 album artist artist1 artist2 
title 
File Name Terms: Fopus Ftestmultiple opus testmultiple 
XAttr Terms: 
lyricist: lyricist
title: title
discNumber: 1
comment: comment
artist: artist1 artist2
album: album
albumArtist: album artist
genre: genre
sampleRate: 48000
trackNumber: 1
releaseYear: 2015
bitRate: 67000
channels: 1
duration: 1
composer: composer

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12932: handle string lists as input

[Stefan Brüns]

bruns added a comment.


  Can you do a manual test on an appropriate file, and add the output (before 
and after) for `balooshow -x `?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12932: handle string lists as input

[Stefan Brüns]

bruns added a comment.


  looks good, although untested

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D11365: also test for value types in taglibextractortest and fix errors

[Stefan Brüns]

bruns added inline comments.
Restricted Application added a subscriber: kde-frameworks-devel.

INLINE COMMENTS

> mgallien wrote in taglibextractor.cpp:389
> Are you sure we need this cast ? I do not think we will ever need to have 
> negative track numbers added. The original type is unsigned int and should 
> exactly convey the fact that we do not expect negative numbers.

For CDs, there are hidden tracks, IIRC these have negative numbers.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D11365

To: astippich, #frameworks, #baloo, mgallien, michaelh
Cc: kde-frameworks-devel, bruns, michaelh, #frameworks, ashaposhnikov, 
astippich, spoorun, ngraham

D12932: handle string lists as input

[Alexander Stippich]

astippich updated this revision to Diff 34323.
astippich added a comment.


  - fix mistakes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12932?vs=34318=34323

BRANCH
  string_lists

REVISION DETAIL
  https://phabricator.kde.org/D12932

AFFECTED FILES
  src/file/extractor/result.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12932: handle string lists as input

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> result.cpp:90
> +bool shouldBeIndexed = 
> KFileMetaData::PropertyInfo(property).shouldBeIndexed();
> +for (const auto& val : value.toStringList())
> +{

`const auto list = value.toStringList();`, to avoid detach.

> result.cpp:93
> +if (val.isEmpty())
> +return;
> +m_termGen.indexText(val, prefix);

`continue;`, you don't want to drop the remaining list entries

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12932: handle string lists as input

[Alexander Stippich]

astippich marked 4 inline comments as done.
astippich added a comment.


  Thanks, and sorry, copied and pasted too quickly without thinking this through

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12932: handle string lists as input

[Alexander Stippich]

astippich updated this revision to Diff 34318.
astippich added a comment.


  - incorporate feedback

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12932?vs=34314=34318

BRANCH
  string_lists

REVISION DETAIL
  https://phabricator.kde.org/D12932

AFFECTED FILES
  src/file/extractor/result.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12932: handle string lists as input

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> result.cpp:90
> +const QStringList val = value.toStringList();
> +if (val.isEmpty())
> +return;

this check is not strictly necessary - if the list is empty, you iterate zero 
times in the loop. But see below [1]

> result.cpp:92
> +return;
> +KFileMetaData::PropertyInfo pi(property);
> +for (int i = 0; i < val.size(); ++i)

`bool shouldBeIndexed = KFMD:PropertyInfo(property).shouldBeIndexed(); `

avoids the check on each iteration

> result.cpp:93
> +KFileMetaData::PropertyInfo pi(property);
> +for (int i = 0; i < val.size(); ++i)
> +{

range-based-for loop, please:
`for (const auto& val : values) { ... }`

> result.cpp:94
> +for (int i = 0; i < val.size(); ++i)
> +{
> +m_termGen.indexText(val.at(i), prefix);

[1] ... here you miss the check on val.at(i).empty() - the list can contain 
empty strings.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added a comment.


  Any opinions from #frameworks  
folks?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12932: handle string lists as input

[Alexander Stippich]

astippich added a comment.


  Unfortunately I couldn't find tests that execute this code path. Do we have 
test for this somewhere?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12932

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12932: handle string lists as input

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  handles string lists as inputs for baloo by inserting each string in the list 
separately

REPOSITORY
  R293 Baloo

BRANCH
  string_lists

REVISION DETAIL
  https://phabricator.kde.org/D12932

AFFECTED FILES
  src/file/extractor/result.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham marked 2 inline comments as done.
ngraham added inline comments.

INLINE COMMENTS

> rkflx wrote in kdiroperator.cpp:1888
> I think it is a misconception that toolbar icons represent state. I don't 
> know of any toolbar in our software where this is the case, so why should 
> users suddenly expect that what's on the icon represents exactly what is 
> happening, e.g. A-Z ascending? It is merely an example of what type of 
> actions they can expect when clicking on the button.
> 
> Icons are a symbolic representation of general concept, not a literal display 
> of a specific state.
> 
> ---
> 
> Anyway, if you want block everything on that, that's what we'll do.

Seems like the new icon may be a long time in coming, and after giving it more 
thought, I've come around to your position (an increasingly common occurrence! 
:) ).

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham updated this revision to Diff 34313.
ngraham added a comment.


  `view-sort-ascending` it is, for now

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12337?vs=34312=34313

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

[Nathaniel Graham]

ngraham updated this revision to Diff 34312.
ngraham added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  Merge master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12337?vs=33498=34312

BRANCH
  arcpatch-D12337

REVISION DETAIL
  https://phabricator.kde.org/D12337

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kfilewidget.cpp

To: ngraham, #frameworks, #dolphin, #vdg, rkflx
Cc: kde-frameworks-devel, andreaska, markg, broulik, anemeth, michaelh, 
ngraham, bruns

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

[Fabian Kosmale]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:49f871844632: Check if group  LastGroup, as 
KIconEffect doesnt handle UserGroup anyway (authored by fabiank).
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12002?vs=31533=34305

REVISION DETAIL
  https://phabricator.kde.org/D12002

AFFECTED FILES
  src/kiconloader.cpp

To: fabiank, mart, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

D12820: Add KWayland virtual desktop protocol

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> org_kde_plasma_virtual_desktop.xml:4
> +  

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/17/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 16 May 2018 11:47:03 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 16 May 2018 12:00:54 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D9653: [FStab Handling] Clean up process running by using lambdas

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:967dc53dc9a5: [FStab Handling] Clean up process running 
by using lambdas (authored by broulik).
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9653?vs=24707=34290

REVISION DETAIL
  https://phabricator.kde.org/D9653

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h
  src/solid/devices/backends/fstab/fstabstorageaccess.cpp
  src/solid/devices/backends/fstab/fstabstorageaccess.h

To: broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 111 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/111/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 16 May 2018 11:47:03 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31790/60030)38%
(18749/49372)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8702/9259)48%
(5404/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8448/14499)50%
(4913/9808)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3900/7917)33%
(1638/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1333)55%
(648/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 159 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/159/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 16 May 2018 12:00:54 +
 Build duration:
4 min 49 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3559/13468)19%
(1978/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/470)0%
(0/263)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2246)7%
(102/1496)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3532)28%
(827/2965)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1621)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(555/2020)17%
(306/1781)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1179)0%
(0/1058)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
 

D12876: [Dialog] Handle dialog being minimized gracefully

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:11f4e5b392ac: [Dialog] Handle dialog being minimized 
gracefully (authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12876?vs=34147=34289

REVISION DETAIL
  https://phabricator.kde.org/D12876

AFFECTED FILES
  src/plasmaquick/dialog.cpp

To: broulik, #plasma, mart
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 262 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/262/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 16 May 2018 11:47:03 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31751/60029)38%
(18732/49376)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8704/9259)48%
(5405/11151)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8401/14498)50%
(4899/9804)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3900/7917)33%
(1638/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(521/1008)42%
(417/1004)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

D12876: [Dialog] Handle dialog being minimized gracefully

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12876

To: broulik, #plasma, mart
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D7534: [KUrlNavigator] Emit tabRequested when path in path selector menu is middle-clicked

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fc6b85b832c7: [KUrlNavigator] Emit tabRequested when path 
in path selector menu is middle… (authored by broulik).
Restricted Application removed a subscriber: Frameworks.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7534?vs=33076=34288

REVISION DETAIL
  https://phabricator.kde.org/D7534

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigatorpathselectoreventfilter.cpp
  src/filewidgets/kurlnavigatorpathselectoreventfilter_p.h

To: broulik, kde-frameworks-devel, dfaure
Cc: michaelh, ngraham, bruns, #frameworks

D12876: [Dialog] Handle dialog being minimized gracefully

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in dialog.cpp:1371
> We don't know the previous state of the window with `windowState` (singular, 
> pre-5.10 API) so we cannot restore a full screen or maximized state. Not sure 
> if that is a usecase, though. Anyway, this new API lets us just unset a 
> particular state.

if the window was hidden anyways, aren't their states lost?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D12876

To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D12820: Add KWayland virtual desktop protocol

[Roman Gilg]

romangg added a comment.


  In D12820#263516 , @mart wrote:
  
  > but then... how to manage collisions? allowing to set the same row/column 
to different desktops and make kwin responsibility of this not happening?
  
  
  For a layout change the compositor would give KWayland a complete matrix of 
all virtual desktops indicating their new positions. So KWin would need to make 
sure that:
  
  - every cell in the matrix only has one VD object referenced (this is per 
definition if the matrix is `QVector>` ),
  - the matrix contains all available VDs.
  
  The compositor would calculate the new matrix internally (it knows about all 
available VDs and their current positions through KWayland) and then call:
  
  1. `PlasmaVirtualDesktopManagementInterface::layout(QVector> matrix)` containing all VDs,
  2. `sendDone()`.
  
  On the other side when the compositor wants to create a new VD, it would call:
  
  1. `PlasmaVirtualDesktopManagementInterface::createDesktop()`,
  2. `PlasmaVirtualDesktopManagementInterface::layout(QVector> matrix)` containing all VDs including the new one,
  3. `sendDone()`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12919: [Plotter] Don't render if m_node is null

[Kai Uwe Broulik]

broulik added a comment.


  > Do you know if that bug reporter had 
2617a2ab9d472a78559f11ee8d430d951e3335f2 
 
applied?
  
  Given it said Frameworks 5.46 I would assume so

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12919

To: broulik, #plasma, bshah
Cc: davidedmundson, bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart added a comment.


  so:
  
  - the manager just having a maximum_rows event, which tells that's the 
boundary of rows the kayout should have
  
  or... not even that (then the setting of maximum row/columns becomes 
completely kwin internal)
  
  - the location managed completely internally by the virtual desktop so they 
can have any layout, with holes anywhere
  - this simplifies a lot the code protocol-wise (in fact pretty much revertin 
the last commit in the branch)
  
  but then... how to manage collisions? allowing to set the same row/column to 
different desktops and make kwin responsibility of this not happening?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/32/
 Project:
Frameworks krunner kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 16 May 2018 09:22:17 +
 Build duration:
2 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.dbusrunnertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)57%
(12/21)57%
(12/21)29%
(447/1516)22%
(205/928)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests60%
(3/5)60%
(3/5)54%
(79/146)31%
(34/108)src90%
(9/10)90%
(9/10)31%
(368/1192)24%
(171/714)src.declarative0%
(0/4)0%
(0/4)0%
(0/135)0%
(0/102)tests0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/4)

D12924: Process DBus replies in the ::match thread

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R308:56382f8d9a80: Process DBus replies in the ::match thread 
(authored by davidedmundson).

REPOSITORY
  R308 KRunner

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12924?vs=34270=34273

REVISION DETAIL
  https://phabricator.kde.org/D12924

AFFECTED FILES
  src/dbusrunner.cpp

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12924: Process DBus replies in the ::match thread

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12924

To: davidedmundson, #plasma, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12924: Process DBus replies in the ::match thread

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  6114612970bcf757d9e06a623d6220257ce57b5f 
 
turned the DBus requests into
  using QDBusPendingCallWatcher but blocking so that it's still handled
  within the ::match() method. However, it accidentally processed replies
  in the main thread, rather than in the match thread which wasn't the
  intention.
  
  Result is occasional threading related crashes.
  
  BUG: 394272

TEST PLAN
  Still had results from baloo (one of our DBus runners)
  It didn't crash (but it never crashed for me before either)
  ‎
  One tester replied:
  [10:00] ‎<‎sunnyflunk‎>‎ d_ed: looks good, tried 30 times with patch and no 
crash, then turned off the patch and crashed 4th time

REPOSITORY
  R308 KRunner

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12924

AFFECTED FILES
  src/dbusrunner.cpp

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12919: [Plotter] Don't render if m_node is null

[David Edmundson]

davidedmundson added a comment.


  Have you seen 2617a2ab9d472a78559f11ee8d430d951e3335f2 

  
  The point we set m_node to null we disconnect the connection that calls 
render.
  
  Do you know if that bug reporter had 2617a2ab9d472a78559f11ee8d430d951e3335f2 
 
applied?
  
  but given we check m_window, checking m_node does makes sense for the same 
reasons

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12919

To: broulik, #plasma, bshah
Cc: davidedmundson, bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik added a comment.
Restricted Application removed a subscriber: Frameworks.


  Any suggestion how to fix the overload problem?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, ragreen, Pitel, michaelh, ZrenBot, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, #frameworks

D12919: [Plotter] Don't render if m_node is null

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  Sounds good to me.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12919

To: broulik, #plasma, bshah
Cc: bshah, kde-frameworks-devel, michaelh, ngraham, bruns

D12919: [Plotter] Don't render if m_node is null

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `m_node` is deleted when window changes, we would access it inconditionally 
in `render`
  
  BUG: 394283

TEST PLAN
  Compiles.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D12919

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/37/
 Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 16 May 2018 06:39:51 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 36 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(79/87)91%
(79/87)78%
(6720/8570)56%
(4149/7431)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(23/23)100%
(23/23)99%
(1907/1917)51%
(1276/2492)autotests.kconfig_compiler96%
(25/26)96%
(25/26)92%
(281/305)47%
(118/252)src.core88%
(21/24)88%
(21/24)68%
(2307/3386)54%
(1303/2418)src.gui78%
(7/9)78%
(7/9)61%
(440/716)50%
(164/325)src.kconf_update100%
(2/2)100%
(2/2)72%
(421/588)56%
(285/508)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1364/1579)78%
(1003/1290)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/79)0%
(0/146)

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/7/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.10
 Date of build:
Wed, 16 May 2018 06:39:51 +
 Build duration:
1 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 33 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcore-kconfigtestFailed: TestSuite.kconfigcore-test_kconf_update

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 19 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/19/
 Project:
Frameworks kconfig kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 16 May 2018 06:39:51 +
 Build duration:
1 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 36 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(79/87)91%
(79/87)78%
(6722/8572)56%
(4152/7433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(23/23)100%
(23/23)99%
(1907/1917)51%
(1276/2492)autotests.kconfig_compiler96%
(25/26)96%
(25/26)92%
(281/305)47%
(118/252)src.core88%
(21/24)88%
(21/24)68%
(2309/3388)54%
(1306/2420)src.gui78%
(7/9)78%
(7/9)61%
(440/716)50%
(164/325)src.kconf_update100%
(2/2)100%
(2/2)72%
(421/588)56%
(285/508)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1364/1579)78%
(1003/1290)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/79)0%
(0/146)

D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file

[Maximiliano Curia]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:c1fa17e99ad9: KConfigCompiler_Test: Update 
test_signal.h.ref to follow the generated file (authored by maximilianocuria).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12892?vs=34185=34258

REVISION DETAIL
  https://phabricator.kde.org/D12892

AFFECTED FILES
  autotests/kconfig_compiler/test_signal.h.ref

To: maximilianocuria, #frameworks, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns