KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/62/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 08 Jun 2018 03:51:22 +
 Build duration:
2 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)21%
(458/2194)20%
(265/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)56%
(106/188)src100%
(8/8)100%
(8/8)69%
(226/326)48%
(123/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 38 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/38/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 08 Jun 2018 03:51:22 +
 Build duration:
1 min 43 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report24%
(5/21)30%
(17/57)30%
(17/57)22%
(481/2194)23%
(294/1301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(4/4)100%
(4/4)93%
(144/155)59%
(111/188)src100%
(8/8)100%
(8/8)76%
(249/326)57%
(147/256)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/142)0%
(0/94)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/57)0%
(0/32)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/188)0%
(0/78)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/16)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/81)0%
(0/40)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/56)0%
(0/36)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/90)src.plugins.phabricator.quick0%
(0/6)0%
(0/6)0%
(0/86)0%
(0/59)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/242)0%
(0/80)src.plugins.reviewboard.quick0%
(0/8)0%
(0/8)0%
(0/159)0%
(0/100)src.plugins.saveas100%
(1/1)100%
(1/1)58%
(31/53)63%
(30/48)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/32)src.plugins.youtube0%
(0/5)0%
(0/5)0%
(0/122)0%
(0/44)src.quick100%
(2/2)100%
(2/2)100%
(9/9)100%
  

D13425: Quit the file indexer when closing.

[James Smith]

smithjd added a dependency: D13424: On config change halt the file indexer and 
run a file changed check when the file watches are updated..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

[James Smith]

smithjd added a dependent revision: D13425: Quit the file indexer when closing..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13424

To: smithjd, mgallien, bruns
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13425: Quit the file indexer when closing.

[James Smith]

smithjd added a dependency: D13216: Overhaul the file index scheduler..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13425

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a dependent revision: D13425: Quit the file indexer when closing..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13425: Quit the file indexer when closing.

[James Smith]

smithjd created this revision.
smithjd added reviewers: bruns, mgallien.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
smithjd requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master-scheduler-haltonquit (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13425

AFFECTED FILES
  src/file/mainhub.cpp

To: smithjd, bruns, mgallien
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

[James Smith]

smithjd updated this revision to Diff 35812.
smithjd added a comment.


  Separate out the content indexer halt on quit.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13424?vs=35811=35812

BRANCH
  master-scheduler-updateConfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13424

AFFECTED FILES
  src/file/mainhub.cpp

To: smithjd, mgallien, bruns
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

[James Smith]

smithjd retitled this revision from "On config change, halt the file indexer 
and run a file changed check when the file watches are updated." to "On config 
change halt the file indexer and run a file changed check when the file watches 
are updated.".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13424

To: smithjd, mgallien, bruns
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

[James Smith]

smithjd added reviewers: mgallien, bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13424

To: smithjd, mgallien, bruns
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a dependent revision: D13424: On config change, halt the file 
indexer and run a file changed check when the file watches are updated..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

[James Smith]

smithjd added a dependency: D13216: Overhaul the file index scheduler..

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13424

To: smithjd
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

[James Smith]

smithjd created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
smithjd requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  mastger-scheduler-updateConfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13424

AFFECTED FILES
  src/file/mainhub.cpp

To: smithjd
Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd updated this revision to Diff 35810.
smithjd added a comment.


  - Re-write the the file index scheduler.
  - Update the balooctl tool with the changed suspend/resume behaviour.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13216?vs=35730=35810

BRANCH
  master-scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13216

AFFECTED FILES
  src/file/fileindexscheduler.cpp
  src/file/fileindexscheduler.h
  src/tools/balooctl/main.cpp

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag added a comment.


  In D13384#275246 , @zzag wrote:
  
  > Add comments describing CFG.
  
  
  As it turns out, that's not necessary. The code is pretty much 
"self-explanatory".
  
  Anyway, I'd like to proceed with code review.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag updated this revision to Diff 35806.
zzag added a comment.


  Rename `shouldUpdateSizes` back to `shouldUpdate`
  
  That's for a possible future diff: the mask frame should be updated
  if maskFrame->imagePath != frame->imagePath. That's an unrelated
  change because this diff tries to address the problem of corrupting
  already shared mask frames.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13384?vs=35749=35806

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13216: Overhaul the file index scheduler.

[Nathaniel Graham]

ngraham added a comment.


  For future reference, the preferred method to implement a multi-commit patch 
chain is with multiple Phabricator revisions. See 
https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  In D13216#275582 , @bruns wrote:
  
  > In D13216#275581 , @smithjd 
wrote:
  >
  > > According to the arc documentation, a --merge commit should land the 
commits separately.
  >
  >
  > Still, **I** can not see the individual commits.
  
  
  That appears to be a Phabricator limitation.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  In D13216#275581 , @smithjd wrote:
  
  > According to the arc documentation, a --merge commit should land the 
commits separately.
  
  
  Still, **I** can not see the individual commits.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  According to the arc documentation, a --merge commit should land the commits 
separately.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  In D13216#275546 , @smithjd wrote:
  
  > In D13216#275538 , @bruns wrote:
  >
  > > @smithjd You have probaly become another victim of phabricator/arc.  Your 
commits have been squashed by arc ...
  > >  If you wan't your commits to stay separated, you have to do a `git 
checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next 
commit, `arc diff HEAD^1`, and so on.
  >
  >
  > Commits are squashed on arc land anyway, but the branch can be manually 
pushed keeping the separate patches. If you mean separated into different 
reviews, I don't think it's unclear why there are small changes to code related 
to the scheduler, or why it might be advantageous to separate these into 
different reviews.
  >
  > Is there any practical reason why a simple arc land wouldn't suffice here?
  
  
  Because pushing independent stuff in a single commit just sucks for the 
reviewer, and it sucks if you want to understand the git history later.
  
  You are changing 5 different things in your patches. I can not see which 
changed source line relates to which change.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[James Smith]

smithjd added a comment.


  In D13216#275538 , @bruns wrote:
  
  > @smithjd You have probaly become another victim of phabricator/arc.  Your 
commits have been squashed by arc ...
  >  If you wan't your commits to stay separated, you have to do a `git 
checkout` of the first commit, do a `arc diff HEAD^1`, checkout the next 
commit, `arc diff HEAD^1`, and so on.
  
  
  Commits are squashed on arc land anyway, but the branch can be manually 
pushed keeping the separate patches. If you mean separated into different 
reviews, I don't think it's unclear why there are small changes to code related 
to the scheduler, or why it might be advantageous to separate these into 
different reviews.
  
  Is there any practical reason why a simple arc land wouldn't suffice here?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D13216: Overhaul the file index scheduler.

[Stefan Brüns]

bruns added a comment.


  @smithjd You have probaly become another victim of phabricator/arc.  Your 
commits have been squashed by arc ...
  If you wan't your commits to stay separated, you have to do a `git checkout` 
of the first commit, do a `arc diff HEAD^1`, checkout the next commit, `arc 
diff HEAD^1`, and so on.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13216

To: smithjd, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

This revision was automatically updated to reflect the committed changes.
heikobecker marked an inline comment as done.
Closed by commit R249:918e304f057b: KF5I18NMacros: Dont install an empty 
dir when no po files exist (authored by heikobecker).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12905?vs=34222=35777

REVISION DETAIL
  https://phabricator.kde.org/D12905

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: heikobecker, ilic, ltoscano
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D13302: check for needed version of libavcode, libavformat and libavutil

[Matthieu Gallien]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:461f8ec81b81: check for needed version of libavcode, 
libavformat and libavutil (authored by mgallien).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13302?vs=35712=35776

REVISION DETAIL
  https://phabricator.kde.org/D13302

AFFECTED FILES
  CMakeLists.txt
  cmake/FindFFmpeg.cmake
  src/config-kfilemetadata.h.in
  src/extractors/CMakeLists.txt
  src/extractors/ffmpegextractor.cpp

To: mgallien, romangg, adridg, jriddell
Cc: jriddell, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  -1, this change would break the autotests.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D13406

To: habacker, ilic
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Roman Gilg]

romangg added a comment.


  How is a change of neighbors supposed to work for clients already bound to 
the proxy objects? For example consider virtual desktop grid:
  
D1 D2
D3 D4
  
  Compositor removes `D3` and let `D4` flow back to the left:
  
D1 D2
D4
  
  `desktop_removed` event is sent and for `D1` and `D2` bottom neighbor 
changes, for `D4` left and top neighbor change. To have a consistent state on 
the client at all time, one would need to tell the client when it has fully 
received all these information coming from multiple interfaces. Maybe it is 
enough to send the `done` event of the management interface not after itself 
has finished all events, but also every desktop interface has sent it. Not sure 
if this is fine protocol hygiene though. If it is we need to add it to the 
descriptions of the interfaces.

INLINE COMMENTS

> plasma-virtual-desktop.xml:25
> +
> + interface="org_kde_plasma_virtual_desktop"/>
> +

This arg name should be `id` (judging from other example protocols). Find a 
different arg name for the second argument, for example `desktop_id` or just 
`desktop`. Together:

  
  

> mart wrote in plasma-window-management.xml:273
> tough is a thing the client asks for which may or may not be granted.. just 
> enter_virtual_desktop looks like it's already decided?

It's a request, so it's intrinsic that it's not yet decided. You can say in the 
description, that the server might ignore this request, otherwise it sends the 
virtual_desktop_entered event.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D12513: CVE-2018-10361: privilege escalation

[Christoph Cullmann]

cullmann added a comment.


  I followed the "I think it was agreed this is an improvement, so i'm going to 
suggest we commit it." comment from above.
  In any case, it is an improvement to the old situation.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: acooligan, kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, 
fvogt, cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D12513: CVE-2018-10361: privilege escalation

[Christoph Cullmann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c81af5aa1d4f: CVE-2018-10361: privilege escalation 
(authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12513?vs=33057=35772

REVISION DETAIL
  https://phabricator.kde.org/D12513

AFFECTED FILES
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer_p.h

To: cullmann, dfaure
Cc: acooligan, kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, 
fvogt, cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D12513: CVE-2018-10361: privilege escalation

[Christoph Cullmann]

cullmann added a comment.


  I can push that change, if OK.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: acooligan, kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, 
fvogt, cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D12513: CVE-2018-10361: privilege escalation

[Andrew Cooligan]

acooligan added a comment.


  In D12513#269889 , @aacid wrote:
  
  > Also not sure if useful but since kio is getting support for writting to 
"root owned" files we should investigate if maybe we can just simply drop this 
code altogether?
  
  
  As KIO has its own similar issues and it's not ready yet, can you merge this 
one? More than a month passed since vulnerabilities were reported, fix posted 
here and we're still in limbo.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D12513

To: cullmann, dfaure
Cc: acooligan, kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, 
fvogt, cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

[Ralf Habacker]

habacker added a reviewer: ilic.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D13406

To: habacker, ilic
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12696: Use the new uds implementation

[Martin Kostolný]

martinkostolny added a comment.


  Thanks for guidance regarding getting additional debug info. I'll try to get 
it soon :).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh, ngraham

D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR

[Ralf Habacker]

habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

REVISION SUMMARY
  On runtime KF5I18n_DIR points to the same path as CMAKE_CURRENT_LIST_DIR,
  but adds an additional hidden and obsolate level of indirection.

TEST PLAN
  compiled and tested with client package

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13406

AFFECTED FILES
  cmake/KF5I18NMacros.cmake.in

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Luigi Toscano]

ltoscano accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic, ltoscano
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D12905: KF5I18NMacros: Don't install an empty dir when no po files exist

[Heiko Becker]

heikobecker marked an inline comment as done.
heikobecker added a comment.


  Considering the feedback I'll probably merge this in a few days if no 
objections turn up in the meantime.

INLINE COMMENTS

> ltoscano wrote in KF5I18NMacros.cmake.in:138-139
> I guess that those two lines are the critical parts (the call to file), but 
> probably it's not bad to avoid processing other instructions too.

Yes. And that was my thought as well and reason to move the rest inside the if

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D12905

To: heikobecker, ilic
Cc: apol, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D13403: Android: Make it possible to override a target's APK directory

[Aleix Pol Gonzalez]

apol added a dependent revision: D13404: Make it possible to build Marble with 
KDE Android tooling.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13403

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13403: Android: Make it possible to override a target's APK directory

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Some projects such as marble do some operations with the APK directory
  before building. This allows us the project to copy the apk directory
  over to the build directory and do whatever it pleases.

TEST PLAN
  Built Marble

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13403

AFFECTED FILES
  toolchain/Android.cmake
  toolchain/ECMAndroidDeployQt.cmake
  toolchain/deployment-file.json.in

To: apol, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13033: Expose getter method for KConfig::addConfigSources

[David Edmundson]

davidedmundson added a dependent revision: D13034: Add mechanism to notify 
other clients of config changes over DBus.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D13033

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13034: Add mechanism to notify other clients of config changes over DBus

[David Edmundson]

davidedmundson added dependencies: D13033: Expose getter method for 
KConfig::addConfigSources, D13032: Fix cleanup of kconfigtest kdeglobals.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13034

To: davidedmundson, broulik
Cc: broulik, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13032: Fix cleanup of kconfigtest kdeglobals

[David Edmundson]

davidedmundson added a dependent revision: D13034: Add mechanism to notify 
other clients of config changes over DBus.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D13032

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag planned changes to this revision.
zzag added a comment.


  Add comments describing CFG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag updated this revision to Diff 35749.
zzag added a comment.


  Update sizes only if enabled borders or frame size have been changed

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13384?vs=35705=35749

BRANCH
  dont-wreck-shared-mask-frames

REVISION DETAIL
  https://phabricator.kde.org/D13384

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13402: FrameSvg: Simplify updateSizes

[Vlad Zagorodniy]

zzag created this revision.
zzag added reviewers: Plasma, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
if (hintXXXMargin > -1) {
// ...
} else {
// ...
}
  
  are redundant because fixedXXXMargin already hold correct margin values.

TEST PLAN
  Manually

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  framesvg-simplify-updatesizes

REVISION DETAIL
  https://phabricator.kde.org/D13402

AFFECTED FILES
  src/plasma/framesvg.cpp

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12696: Use the new uds implementation

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> martinkostolny wrote in udsentry.cpp:106
> sftp slave crashes here when entering directory with links

Any chance you can attach a debugger (or load the core file with gdb) and 
provide the values of 'udsField' and 'value'?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh, ngraham

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag added a comment.


  In D13384#275224 , @zzag wrote:
  
  > Corner case: what if only need to update cachedBackground(i.e. 
enabledBorders and frameSize are okay)?
  
  
  Delete `shouldUpdate` and wrap if (refcount() == 1) {} into another if 
statement, e.g.
  
if (maskFrame->enabledBorders != frame->enabledBorders || 
maskFrame->frameSize != frameSize(frame)) {
if (maskFrame->refcount() == 1) {
// ...
} else {
// ...
}
updateSizes(maskFrame);
}

if (maskFrame->cachedBackground.isNull()) {
generateBackground(maskFrame);
}

return maskFrame->cachedBackground;
  
  ?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13384: FrameSvg: Do not wreck shared mask frames

[Vlad Zagorodniy]

zzag added a comment.


  Corner case: what if only need to update cachedBackground(i.e. enabledBorders 
and frameSize are okay)?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D13384

To: zzag, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13302: check for needed version of libavcode, libavformat and libavutil

[Jonathan Riddell]

jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  latest patch works well in neon

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13302

To: mgallien, romangg, adridg, jriddell
Cc: jriddell, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 47 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/47/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 07 Jun 2018 07:24:37 +
 Build duration:
7 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D12696: Use the new uds implementation

[Jaime Torres Amate]

jtamate added a comment.


  In D12696#275105 , @martinkostolny 
wrote:
  
  > Hi! Probably after this commit sftp slave crashes when showing a directory 
with links. Please see my code comment. Can you also reproduce or is it on my 
side only?
  
  
  I'm sorry, I can't reproduce it with dolphin. (symbolic links and hard links 
and sftp://127.0.0.1).
  Could you get a backtrace with more information, at least who is calling 
udsentry.cpp, line 107? Probably you can get it running the program inside gdb 
or under valgrind. Or you should compile the program and dependencies with 
-DCMAKE_BUILD_TYPE=RelWithDebInfo

INLINE COMMENTS

> bruns wrote in kfileitem.cpp:198
> Ignore this one ..

In fact, I've tried creating a method to delete in one pass some selected 
values and then insert again, but it was 10 milliseconds slower than calling 
replace directly.

> dfaure wrote in udsentry.h:319
> heh, nice syntax ;-)

This syntax must be kept in the case of the QDebug << operator, otherwise 
clang++ doesn't compile.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh, ngraham

D13398: [KFileItem] Check most local URL for whether it's shared

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a44fa03029c8: [KFileItem] Check most local URL for 
whether its shared (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13398?vs=35734=35736

REVISION DETAIL
  https://phabricator.kde.org/D13398

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, gregormi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  Thank you Brauch for committing it on my behalf.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e6f87dd57008: Fix caret width (authored by shubham, 
committed by brauch).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13365?vs=35683=35735

REVISION DETAIL
  https://phabricator.kde.org/D13365

AFFECTED FILES
  src/render/katerenderer.cpp

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#275130 , @brauch wrote:
  
  > I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept 
commits with only one name fragment. Something equivalent to the western 
first/last name pair is required.
  
  
  Brauch officially my Full name is "Shubham", but if KDEs commit hooks dont 
accept it and you insist ,then my name is "Shubham Jangra"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13398: [KFileItem] Check most local URL for whether it's shared

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13398

To: broulik, gregormi, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept 
commits with only one name fragment. Something equivalent to the western 
first/last name pair is required.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D12696: Use the new uds implementation

[Martin Kostolný]

martinkostolny added a comment.


  Hi! Probably after this commit sftp slave crashes when showing a directory 
with links. Please see my code comment. Can you also reproduce or is it on my 
side only?
  
  Here is a crash log:
  
log_kio_sftp: readdir:  "/mnt/ext/files" , details:  "2"
ASSERT: "std::find_if(storage.cbegin(), storage.cend(), [udsField](const 
Field ) {return entry.m_index == udsField;}) == storage.cend()" in file 
/home/kotelnik/kde/src/frameworks/kio/src/core/udsentry.cpp, line 107
kioslave: ### CRASH ## protocol = kio_sftp pid = 20126 signal = 6
/home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(+0x9d42d)[0x7fa660a1042d]
/usr/lib/libc.so.6(+0x368f0)[0x7fa6689888f0]
/usr/lib/libc.so.6(gsignal+0x10b)[0x7fa66898886b]
/usr/lib/libc.so.6(abort+0x129)[0x7fa66897340e]
/usr/lib/libQt5Core.so.5(+0x8033c)[0x7fa6696c433c]
/usr/lib/libQt5Core.so.5(_Z11qt_assert_xPKcS0_S0_i+0x0)[0x7fa6696c3768]
/home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(+0x1033bb)[0x7fa660a763bb]

/home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(_ZN3KIO8UDSEntry6insertEjx+0x33)[0x7fa660a78403]

/home/kotelnik/kde/usr/lib64/plugins/kf5/kio/sftp.so(+0x12371)[0x7fa657ee4371]

/home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(_ZN3KIO9SlaveBase8dispatchEiRK10QByteArray+0x86f)[0x7fa660a12961]

/home/kotelnik/kde/usr/lib64/libKF5KIOCore.so.5(_ZN3KIO9SlaveBase12dispatchLoopEv+0x2a0)[0x7fa660a0e2aa]

/home/kotelnik/kde/usr/lib64/plugins/kf5/kio/sftp.so(kdemain+0x264)[0x7fa657ed88ca]

INLINE COMMENTS

> udsentry.cpp:106
> +Q_ASSERT(udsField & KIO::UDSEntry::UDS_NUMBER);
> +Q_ASSERT(std::find_if(storage.cbegin(), storage.cend(),
> +[udsField](const Field ) {return 
> entry.m_index == udsField;}) == storage.cend());

sftp slave crashes here when entering directory with links

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12696

To: jtamate, dfaure, #frameworks
Cc: martinkostolny, kde-frameworks-devel, bruns, michaelh, ngraham