D14890: Remove QSaveFile in favor of plain old file saving

[Christoph Cullmann]

cullmann updated this revision to Diff 39956.
cullmann added a comment.


  - better error handling, take a look at the file error string

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14890?vs=39921=39956

BRANCH
  nosavefile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14890

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/document/katedocument.cpp
  src/export/exporter.cpp

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Propagating the error is good in any case.
  Will later adapt my patch to use it, like you proposed.
  Still, my crash does happen independent of this I assume.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14913

To: dfaure, cullmann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14308: [Exe Thumbnailer] Improve icon selection algorithm

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> icoutils_common.cpp:99
> +// QtIcoHandler converts all images to 32-bit depth
> +// but they store the actual depth of the icon extracted in custom 
> text:
> +// qtbase/src/plugins/imageformats/ico/qicohandler.cpp:455

grammatical nitpick:

> // QtIcoHandler converts all images to 32 bit depth**,**
>  // but **it stores** the actual depth of the icon extracted in custom text:

i.e. missing `,` in the first line,  and third person

otherwise it's good to go

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D14308

To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns
Cc: bruns

D14915: Bindings: Check if bindings can be generated for a specific python version

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The generated C++ sources include , so it must be available.

TEST PLAN
  install python2-devel and python3-devel
  install one of python{x}-sip-devel
  
  bindings should be generated for the matching pythong version

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  python3_support

REVISION DETAIL
  https://phabricator.kde.org/D14915

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14890: Remove QSaveFile in favor of plain old file saving

[David Faure]

dfaure added a comment.


  Fix for KCompressionDevice + addendum to this patch posted on 
https://bugs.kde.org/show_bug.cgi?id=397545

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14890

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14914: Bindings: Use python version matching the found clang python module

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  In case both python 2.7 and 3 are installed, but clang python bindings
  are only installed for python 3, there will be no error message but
  the self check will fail.
  
  Check for clang bindings for both python2 and python3 (if installed),
  and use the first one found to generate the sip bindings files.
  
  Note, it is possible to e.g. use python2 to generate the sip binding
  files (requires clang bindings), but generate bindings for python
  2, 3, or both (requires matching python-devel and python-sip-devel
  packages).

TEST PLAN
  install python3-clang bindings
  install python2-clang bindings
  or one of the above
  
  the matching python version is used to run sip_generator.py

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14914

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14913: KCompressionDevice: propagate errors from QIODevice::close()BUG: 397545

[David Faure]

dfaure created this revision.
dfaure added a reviewer: cullmann.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  QFile::close() doesn't return a value, but sets an error string instead,
  we need to check for that and set it in KCompressionDevice so apps can check 
for that in turn.

TEST PLAN
  Saving into /tmp/mnt/test.gz with kate, with the setup described in
  https://phabricator.kde.org/D14890

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14913

AFFECTED FILES
  src/kcompressiondevice.cpp

To: dfaure, cullmann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14912: Bindings: Make generator forward compatible with Python 3

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  iteritems is no longer an available method for dict in Python 3. itemviews
  from future.utils allows to use the same code for Python 2.7 and 3.

TEST PLAN
  Run python3 sip_generator.py ...
  Run python2 sip_generator.py ...
  Both generate the same code

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14912

AFFECTED FILES
  find-modules/rules_engine.py

To: bruns, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14909: Bindings: Check for libclang without version suffix also

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:4b59c7708362: Bindings: Check for libclang without 
version suffix also (authored by bruns).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14909?vs=39944=39948

REVISION DETAIL
  https://phabricator.kde.org/D14909

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14909: Bindings: Check for libclang without version suffix also

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  find_libclang

REVISION DETAIL
  https://phabricator.kde.org/D14909

To: bruns, #frameworks, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 132 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/132/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 21:41:16 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32789/47899)51%
(15842/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4407/4702)49%
(1698/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
(374/1252)28%

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/131/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 21:27:36 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.inlinenote_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32770/47895)51%
(15835/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4399/4699)49%
(1696/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 130 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/130/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 19:15:56 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.inlinenote_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32770/47897)51%
(15834/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4399/4699)49%
(1696/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1558/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Martin Flöser]

graesslin added a comment.


  Sorry for strange upload, arc decided to no longer like me.
  
  I created the patch on Jun 30, 2017. Unfortunately the issue was embargo on 
freedesktop.org with the idea of a coordinated release. Today the patch for 
weston landed so I consider the embargo as lifted. I had send the patch already 
to secur...@kde.org last year. Relevant freedesktop org bug is: 
https://bugs.freedesktop.org/show_bug.cgi?id=101595 - it might be that it's 
still private, if that's the case, please leave a note and I'll try to add to 
cc.
  
  Personal note: we are expecting our child any day now. So I cannot guarantee 
that I will have time to follow up or to push it. If you see inactivity: feel 
free to take over the patch and push it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

To: graesslin, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Frameworks, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  To better isolate the clients from each other eachh KeyboardInterface
  creates it's own dedicated temporary file and sends the fd for this
  temporary file to the client. This means the memory for the keymap is no
  longer shared between all clients, every client has an own copy.
  
  To support this the existing API to set the keymap is deprecated and
  replaced by a new method setKeymapData which takes the content of the
  keymap as a byte array. The now deprecated method which takes a file
  descriptor is changed to use the new setKeymapData method. For that it
  reads the content of the file.
  
  The implementation in KeyboardInterface to create the file descriptor is
  based on the implementation of KWin. As I implemented the change in KWin
  (see 3b4c508ee36ac74c37e77fcaa14d106397ad2994 
) it 
is not a problem from
  GPL vs LGPL perspective.
  
  The change includes test cases to verify that the content of the keymap
  is properly passed to the client and that the memory is no longer shared.
  
  BUG: 381674

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D14910

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/server/keyboard_interface.cpp
  src/server/keyboard_interface.h
  src/server/keyboard_interface_p.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h

To: graesslin, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14909: Bindings: Check for libclang without version suffix also

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The canonical name is libclang.so, which seems to be available on all
  distributions (RH, SUSE, Ubuntu, Debian, ...) while the symlinks with
  version suffix (e.g. libclang-6.0) are specific to Debian and derivatives.
  Keep the current checks, but fallback to the unversioned library name.

TEST PLAN
  on openSUSE TW/Leap:
  run cmake
  -> libclang is found

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  find_libclang

REVISION DETAIL
  https://phabricator.kde.org/D14909

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 86 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/86/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 17 Aug 2018 18:52:45 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32788/47901)51%
(15840/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4406/4701)49%
(1698/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1774/3109)43%
(1162/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
(374/1252)28%
   

D14908: Bindings: Add support for scoped enums

[Stefan Brüns]

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Keep the enum intact by emitting the class keyword in case the enum is
  scoped.
  Use the complete enum scope for parameter values, the enclosing scope is
  only correct to use for unscoped enums.
  
  BUG: 397154

TEST PLAN
  build kcoreaddons

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  scoped_enum

REVISION DETAIL
  https://phabricator.kde.org/D14908

AFFECTED FILES
  find-modules/sip_generator.py

To: bruns, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/129/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 18:52:45 +
 Build duration:
5 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.inlinenote_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32770/47897)51%
(15834/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4399/4699)49%
(1696/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
  

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 85 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/85/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 17 Aug 2018 16:35:04 +
 Build duration:
8 min 13 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.inlinenote_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32708/47897)51%
(15800/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)93%
(4359/4698)48%
(1671/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
 

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 128 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/128/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 16:35:04 +
 Build duration:
8 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 67 test(s)Failed: TestSuite.inlinenote_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(252/287)88%
(252/287)68%
(32708/47895)51%
(15799/30944)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)93%
(4358/4697)48%
(1671/3454)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(220/243)64%
(147/228)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(951/1242)67%
(624/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
  

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Stefan Brüns]

bruns added a comment.


  In D7423#310509 , @fvogt wrote:
  
  > On neon it won't work as the kernel everything is built against (so the 
minimum API/ABI) is too old. You'll either have to hack around that by messing 
with include paths or use something more recent.
  >
  > statx does not have a glibc wrapper, which means there is no `statx(...)` 
function. So HAVE_STATX is rightfully false.
  
  
  filesystemengine_unix.cpp`.
  
  This is no longer true with glibc 2.28, released two weeks ago. The interface 
is defined here:
  
  
https://sourceware.org/git/?p=glibc.git;a=blob;f=io/bits/statx.h;h=e31254e3617bb17b1d4ba1dc5365529e376e257d;hb=HEAD
  
  So, first question which arises is, should we make it depend on glibc 2.28? 
There is no kernel dependency,
  as glibc fills out the statx struct using other syscalls if statx is not 
available (of course, no birthtime then).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin, fvogt
Cc: fvogt, kde-frameworks-devel, bruns, meven, ltoscano, #frameworks, michaelh, 
ngraham

D14449: Modify device usage information

[Shubham]

shubham abandoned this revision.
shubham added a comment.


  Actually should be implemented using form layout

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14449

To: shubham, ngraham, #frameworks, rkflx
Cc: pino, rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 202 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/202/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 13:48:03 +
 Build duration:
3 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13108)19%
(1820/9436)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(299/2213)7%
(96/1434)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(300/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D14531: [Icon Item] Use ItemEnabledHasChanged

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e143f7d457f6: [Icon Item] Use ItemEnabledHasChanged 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14531?vs=38891=39923

REVISION DETAIL
  https://phabricator.kde.org/D14531

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14819: Get rid of deprecated QWeakPointer usage

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14819

To: broulik, #plasma, mart, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14531: [Icon Item] Use ItemEnabledHasChanged

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14531

To: broulik, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14890: Remove QSaveFile in favor of plain old file saving

[Christoph Cullmann]

cullmann updated this revision to Diff 39921.
cullmann added a comment.


  skip filter dev hanlding in the common case of no compression
  compress in memory to the buffer for the kauth case
  
  this actually leads now to the wanted error message for uncompressed files
  in disk full situations without any segfault
  
  for the special case of compressed files I opened bug 397545
  
  - Merge branch 'master' into nosavefile

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14890?vs=39903=39921

BRANCH
  nosavefile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14890

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/document/katedocument.cpp
  src/export/exporter.cpp

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/84/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 17 Aug 2018 12:38:58 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(250/285)88%
(250/285)68%
(32593/47791)51%
(15766/30856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(36/36)100%
(36/36)94%
(4303/4596)49%
(1653/3370)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(13/14)93%
(13/14)90%
(219/242)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)75%
(930/1242)66%
(616/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
(374/1252)28%
   

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 127 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/127/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 12:38:58 +
 Build duration:
5 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(250/285)88%
(250/285)68%
(32593/47789)51%
(15766/30856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(36/36)100%
(36/36)94%
(4302/4595)49%
(1653/3370)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)91%
(1689/1866)76%
(1276/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1861/3155)47%
(1559/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(13/14)93%
(13/14)90%
(219/242)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)75%
(930/1242)66%
(616/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
(6/7)30%
(374/1252)28%
   

D14779: Fix 'kformattest fails with installed kcoreaddons language package'

[Ralf Habacker]

habacker added a comment.


  In D14779#310116 , @aacid wrote:
  
  > Did you have that problem when you made ecm not create a translator?
  
  
  no,  therefore I created D14778 
  
  > 
  > 
  >> What is the drawback to not load any translation in the ECM qm file loader 
with using QLocale::C as default locale ?
  > 
  > I've seen some systems that default to C locale,
  
  Can you give a pointer to that system ?
  
  > and I would prefer them to still have the english translation working.
  
  but then there need to be a different way to disable translation for this 
test because this
  
  >   QCOMPARE(format.formatSpelloutDuration(361), QStringLiteral("1 
hour(s)"));
  
  and similar lines are not designed to use any translation.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14779

To: habacker, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D14897: InlineNote: Pimpl inline note data without allocs

[Sven Brauch]

brauch added a comment.


  Sorry, never mind -- that code I removed yesterday.  All should be fine.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14897

To: dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Dominik Haumann]

dhaumann added a comment.


  Can you annotate the code here that you think is wrong?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14897

To: dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 126 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/126/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 11:06:32 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateview_testFailed: TestSuite.messagetestFailed: TestSuite.movingrange_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(247/285)87%
(247/285)66%
(31734/47753)50%
(15352/30856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src92%
(33/36)92%
(33/36)83%
(3803/4579)44%
(1482/3370)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1684/1866)75%
(1262/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)57%
(1810/3154)46%
(1506/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(13/14)93%
(13/14)87%
(211/242)64%
(145/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)75%
(930/1242)66%
(616/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
  

D14899: [KUrlComboBox] Fix KIcon porting error

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:64ba67d0acc4: [KUrlComboBox] Fix KIcon porting error 
(authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14899?vs=39913=39914

REVISION DETAIL
  https://phabricator.kde.org/D14899

AFFECTED FILES
  src/widgets/kurlcombobox.cpp

To: broulik, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 83 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/83/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 17 Aug 2018 11:06:32 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateview_testFailed: TestSuite.messagetestFailed: TestSuite.movingrange_test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)87%
(247/285)87%
(247/285)66%
(31728/47754)50%
(15350/30856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src92%
(33/36)92%
(33/36)83%
(3804/4580)44%
(1482/3370)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5482/5523)58%
(995/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1684/1866)75%
(1262/1672)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)57%
(1810/3154)46%
(1506/3307)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(13/14)93%
(13/14)87%
(211/242)64%
(145/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(169/414)38%
(99/263)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/294)src.render100%
(7/7)100%
(7/7)75%
(930/1242)66%
(616/938)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(734/1072)58%
(267/463)src.search100%
(6/6)100%
(6/6)74%
(1109/1499)64%
(582/914)src.spellcheck86%
(6/7)86%
 

D14899: [KUrlComboBox] Fix KIcon porting error

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Whoops

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14899

To: broulik, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14899: [KUrlComboBox] Fix KIcon porting error

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14899

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14897: InlineNote: Pimpl inline note data without allocs

[Sven Brauch]

brauch added a comment.


  Looks ok to me, except one thing: the operator== is used to compare a note 
from the list to the "currently active" note in the view. If this compares also 
the "under mouse" state, this code might be broken now ...?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14897

To: dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Dominik Haumann]

dhaumann updated this revision to Diff 39911.
dhaumann added a comment.


  - Rename InlineNote::hasFocus() to underMouse()

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14897?vs=39910=39911

BRANCH
  inline-note-data (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14897

AFFECTED FILES
  src/include/ktexteditor/inlinenote.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/inlinenotedata.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:4e279cd72493: InlineNote: Pimpl inline note data without 
allocs (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14897?vs=39911=39912

REVISION DETAIL
  https://phabricator.kde.org/D14897

AFFECTED FILES
  src/include/ktexteditor/inlinenote.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/inlinenotedata.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Dominik Haumann]

dhaumann updated this revision to Diff 39910.
dhaumann added a comment.


  - Remove default constructor, not implemented anyways

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14897?vs=39909=39910

BRANCH
  inline-note-data (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14897

AFFECTED FILES
  src/include/ktexteditor/inlinenote.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/inlinenotedata.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Christoph Cullmann]

cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  inline-note-data (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14897

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Dominik Haumann]

dhaumann updated this revision to Diff 39909.
dhaumann added a comment.


  - Cleanup InlineNote interface

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14897?vs=39907=39909

BRANCH
  inline-note-data (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14897

AFFECTED FILES
  src/include/ktexteditor/inlinenote.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/inlinenotedata.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think that is ok, but one should remove column(), isValid() and == (which 
is no equal anyways ATM).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14897

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14897: InlineNote: Pimpl inline note data without allocs

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  Hide more implementation details and make InlineNote more extensible.

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  inline-note-data (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14897

AFFECTED FILES
  src/include/ktexteditor/inlinenote.h
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/ktexteditor.cpp
  src/view/inlinenotedata.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14890: Remove QSaveFile in favor of plain old file saving

[Christoph Cullmann]

cullmann added a comment.


  I think the integration must wait until we resolve the KArchive issue.
  I have taken a short look but seen no "trivial" fix, opened a new bug for 
that, https://bugs.kde.org/show_bug.cgi?id=397545

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14890

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14529: Android: Make sure Qm translations get loaded

[Sune Vuorela]

svuorela added a comment.


  In D14529#302624 , @aacid wrote:
  
  > Ok, second option, we are actually installing these files ourselves, right?
  
  
  It is where androiddeployqt puts things (I guess to avoid conflict with 
javastuff)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D14529

To: apol, #frameworks
Cc: svuorela, aacid, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 200 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/200/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 17 Aug 2018 09:52:02 +
 Build duration:
3 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13107)19%
(1821/9434)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(299/2212)7%
(96/1432)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3491)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(663/1542)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1976)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D14890: Remove QSaveFile in favor of plain old file saving

[Christoph Cullmann]

cullmann requested review of this revision.
cullmann added a comment.


  There is one tiny problem with that change:
  
  The compression filter device crashs sometimes, if you have bad luck, e.g. 
tried like David did show above with a small tmp mount:
  
  ASSERT: "d->avail_out > 0" in file 
/home/cullmann/kde/src/frameworks/karchive/src/knonefilter.cpp, line 128
  
  Thread 1 "kwrite" received signal SIGABRT, Aborted.
  0x7156708b in raise () from /lib64/libc.so.6
  (gdb) bt
  #0  0x7156708b in raise () from /lib64/libc.so.6
  #1  0x715504e9 in abort () from /lib64/libc.so.6
  #2  0x722b022b in QMessageLogger::fatal(char const*, ...) const () 
from /usr/lib64/libQt5Core.so.5
  #3  0x722af7d9 in qt_assert(char const*, char const*, int) () from 
/usr/lib64/libQt5Core.so.5
  #4  0x704b44fb in KNoneFilter::copyData (this=0x7fffdc0278f0) at 
/home/cullmann/kde/src/frameworks/karchive/src/knonefilter.cpp:128
  #5  0x704b44c6 in KNoneFilter::compress (this=0x7fffdc0278f0, 
finish=true) at 
/home/cullmann/kde/src/frameworks/karchive/src/knonefilter.cpp:123
  #6  0x704b277e in KCompressionDevice::writeData (this=0x7fffc220, 
data=0x0, len=0)
  
at /home/cullmann/kde/src/frameworks/karchive/src/kcompressiondevice.cpp:343
  
  #7  0x723d in QIODevice::write(char const*, long long) () from 
/usr/lib64/libQt5Core.so.5
  #8  0x704b1f1d in KCompressionDevice::close (this=0x7fffc220) at 
/home/cullmann/kde/src/frameworks/karchive/src/kcompressiondevice.cpp:165
  #9  0x777ee7fd in Kate::TextBuffer::save (this=0x72a930, filename=...)
  
at 
/home/cullmann/kde/src/frameworks/ktexteditor/src/buffer/katetextbuffer.cpp:858

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14890

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14890: Remove QSaveFile in favor of plain old file saving

[Christoph Cullmann]

cullmann updated this revision to Diff 39903.
cullmann added a comment.


  - improve the error message, add vim like hint that one might loose data
  - Merge branch 'master' into nosavefile

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14890?vs=39884=39903

BRANCH
  nosavefile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14890

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/document/katedocument.cpp
  src/export/exporter.cpp

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D14894: [RFC] Fix block mode for multi-cursor branch

[Sven Brauch]

brauch added a comment.


  Thanks for the patch, the approach looks reasonable at a first glance. You 
might want to unite the up/down functions ...
  It is too much of a WiP to merge it like this, though.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14894

To: lepagevalleeemmanuel, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14896: Fix bzip main page

[Luigi Toscano]

ltoscano closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D14896

To: ltoscano, svuorela
Cc: svuorela, kde-frameworks-devel, michaelh, ngraham, bruns

D14896: Fix bzip main page

[Sune Vuorela]

svuorela accepted this revision.
svuorela added a comment.
This revision is now accepted and ready to land.


  yesplease.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14896

To: ltoscano, svuorela
Cc: svuorela, kde-frameworks-devel, michaelh, ngraham, bruns

D14896: Fix bzip main page

[Luigi Toscano]

ltoscano created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ltoscano requested review of this revision.

REVISION SUMMARY
  The known domain is lost:
  https://lwn.net/Articles/762264/
  https://lwn.net/Articles/762340/

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14896

AFFECTED FILES
  CMakeLists.txt

To: ltoscano
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14890: Remove QSaveFile in favor of plain old file saving

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  nosavefile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14890

To: cullmann, dhaumann, dfaure
Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  On neon it won't work as the kernel everything is built against (so the 
minimum API/ABI) is too old. You'll either have to hack around that by messing 
with include paths or use something more recent.
  
  statx does not have a glibc wrapper, which means there is no `statx(...)` 
function. So HAVE_STATX is rightfully false.
  
  What Qt does is different: If `SYS_statx` is defined, it determines during 
runtime whether the kernel supports it. `QT_STATBUF` is in any case a `struct 
stat`/`stat64`, so if your code calls statx, it'll corrupt memory.
  The only reason your code even compiled is that stx_btime is not a macro, so 
that code wasn't compiled in.
  
  There is a bigger design issue with this approach even: There are either 
"stx_" members or "st_" members available. So every access to "buff" needs to 
be guarded by both an #if HAVE_STATX and an if(statx_available).
  
  You also need to note that the kernel syscall interface is different from 
glibc wrappers/posix functions: There is no errno, the error is directly in the 
return value.
  So `stat(...) == -1` is not equal to `syscall(SYS_statx, ...) == -1`. The 
latter is equivalent to `stat(...) == -1 && errno == EPERM` (EPERM is 1).
  
  I suggest rewriting this to make use of a wrapper function instead of macros, 
like Qt does. You can find that in `src/corelib/io/qfilesystemengine_unix.cpp`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin, fvogt
Cc: fvogt, kde-frameworks-devel, bruns, meven, ltoscano, #frameworks, michaelh, 
ngraham