D16579: Musepack disk number field name is DISC.

2018-10-31 Thread James Smith 
smithjd added a comment.


  Useful tag mapping information:
  
  https://wiki.hydrogenaud.io/index.php?title=Tag_Mapping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16579

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16579: Musepack disk number field name is DISC.

2018-10-31 Thread James Smith 
smithjd created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
smithjd requested review of this revision.

REVISION SUMMARY
  Fix the Musepack disk field.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master-musepackFixes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16579

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: smithjd
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 file system(4 GB)

2018-10-31 Thread Shubham 
shubham added a comment.


  Can I get a review?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, elvisangelaccio, #frameworks
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 44605.
ngraham added a comment.


  Incorporate more feedback from review comments (thanks @davidc and @valorie!)

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16395?vs=44564=44605

BRANCH
  update-about-kde-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16395

AFFECTED FILES
  src/kaboutkdedialog_p.cpp

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16554: move supported mimetypes to static string list

2018-10-31 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> epubextractor.cpp:38
> +const QStringList EPubExtractor::mMimetypes =
>  {
> +QStringLiteral("application/epub+zip"),

Opening braces should go on the same line for everything but functions ...

> epubextractor.cpp:48
>  namespace
>  {
>  QString fetchMetadata(struct epub* e, const epub_metadata& type)

you can put the static mimetypes variable here in the anonymous namespace

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16554

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 133 - Fixed!

2018-10-31 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/133/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 01 Nov 2018 01:34:49 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(12/24)67%
(114/170)67%
(114/170)60%
(5490/9196)41%
(2073/5014)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)95%
(239/252)67%
(63/94)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(719/719)55%
(190/348)autotests.unit.file100%
(11/11)100%
(11/11)98%
(862/883)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(405/416)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/145)73%
(35/48)src.engine95%
(35/37)95%
(35/37)80%
(1716/2136)59%
(668/1139)src.file63%
(24/38)63%
(24/38)51%
(843/1647)42%
(433/1042)src.file.extractor14%
(1/7)14%
(1/7)9%
(18/196)7%
(5/76)src.file.extractor.autotests100%
(1/1)100%
(1/1)100%
(21/21)75%
(6/8)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/233)0%
(0/191)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)48%
(464/958)43%
(255/599)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/70)0%

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:1b242697d27d: [KFileMetaData] Add helper for XML encoded 
Dublin Core metadata (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16488?vs=44373=44603

REVISION DETAIL
  https://phabricator.kde.org/D16488

AFFECTED FILES
  src/extractors/dublincoreextractor.cpp
  src/extractors/dublincoreextractor.h

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16490: [KFileMetaData] Add unittest for XML extractor

2018-10-31 Thread Stefan Brüns 
bruns marked an inline comment as done.
bruns added a comment.


  In D16490#351662 , @astippich 
wrote:
  
  > Only one minor thing: please also check that the mimetype is in the list of 
supported mimetypes
  
  
  This can actually happen and is completely valid, due to mimetype inheritance.
  
  So the check would be `for supported in supportedMimetypes { if 
QMimeType(input->mimeType()).inherits(supported) return true; }; return false`. 
But this is already done from the calling code ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16563: Remove unused variables

2018-10-31 Thread Stefan Brüns 
bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> transaction.cpp:519
>  out << "\tFileNameTermsDB: ";
>  for (const QByteArray& term : terms) {
>  out << term << " ";

should be `fileNameTerms` here

> transaction.cpp:525
>  out << "\tXAttrTermsDB: ";
>  for (const QByteArray& term : terms) {
>  out << term << " ";

likewise

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16563

To: aacid, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16575: Remove unused variables

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16575

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/dataengineconsumer.cpp
  src/plasma/pluginloader.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16574: Remove unused variable

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16574

AFFECTED FILES
  src/settings/vpnsetting.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16573: Remove unused variables

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16573

AFFECTED FILES
  src/kaboutapplicationpersonmodel_p.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Alexander Stippich 
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  xml_extractor

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16572: don't assign variable to itself

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16572

AFFECTED FILES
  src/platforms/xcb/kwindoweffects.cpp

To: aacid
Cc: kde-frameworks-devel, mart, michaelh, ngraham, bruns

D16571: Remove unused variable

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16571

AFFECTED FILES
  src/runtime/kwalletd/backend/backendpersisthandler.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16570: Remove unused variables

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aacid requested review of this revision.

REVISION SUMMARY
  commentLineMark is commented since the code that uses it is also
  commented a bit below

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16570

AFFECTED FILES
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp

To: aacid
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D16569: Remove unused variable

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16569

AFFECTED FILES
  src/core/engine.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16568: Remove unused variables

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16568

AFFECTED FILES
  src/core/job_error.cpp
  src/filewidgets/kfilewidget.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16567: Remove unused variable

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16567

AFFECTED FILES
  src/extractors/office2007extractor.cpp

To: aacid
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16565: Remove unused variable

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16565

AFFECTED FILES
  src/kconfig_compiler/kconfig_compiler.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16560: create a separate test file for embedded images test

2018-10-31 Thread Alexander Stippich 
astippich added a dependent revision: D16564: cleanup the test for embedded 
image extraction.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16560

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16564: cleanup the test for embedded image extraction

2018-10-31 Thread Alexander Stippich 
astippich added a dependency: D16560: create a separate test file for embedded 
images test.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16564

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16563: Remove unused variables

2018-10-31 Thread Nathaniel Graham 
ngraham added reviewers: Baloo, bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16563

To: aacid, #baloo, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16564: cleanup the test for embedded image extraction

2018-10-31 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: Frameworks, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  cleanup the test by converting to a data-driven one

REPOSITORY
  R286 KFileMetaData

BRANCH
  embedded_test

REVISION DETAIL
  https://phabricator.kde.org/D16564

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/embeddedimagedatatest.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16563: Remove unused variables

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  As far as i can see the declaration of the variables and calling get "does 
nothing", so we can remove them without causing any side effect

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16563

AFFECTED FILES
  src/engine/transaction.cpp

To: aacid
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16562: Reuse resultMap instead of converting to map two times more

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16562

AFFECTED FILES
  src/plugins/reviewboard/reviewboardjobs.cpp

To: aacid
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D16561: Remove unused variable

2018-10-31 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16561

AFFECTED FILES
  src/plugins/reviewboard/quick/rbreviewslistmodel.cpp

To: aacid
Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D15829: make units and prefixes of formatValue translatable

2018-10-31 Thread Alexander Stippich 
astippich added a comment.


  ping

REPOSITORY
  R244 KCoreAddons

BRANCH
  translate_units

REVISION DETAIL
  https://phabricator.kde.org/D15829

To: astippich, bruns, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16486: implement support for reading ID3 tags from aiff and wav files

2018-10-31 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:19f0237fdc98: implement support for reading ID3 tags from 
aiff and wav files (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16486?vs=44369=44583

REVISION DETAIL
  https://phabricator.kde.org/D16486

AFFECTED FILES
  autotests/samplefiles/test.aif
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.wav
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16560: create a separate test file for embedded images test

2018-10-31 Thread Alexander Stippich 
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  if the test.jpg file is altered, e.g. additional
  metadata is added, the embedded images test fails.
  create a separate cover test file from the existing one
  for this test.

REPOSITORY
  R286 KFileMetaData

BRANCH
  cover_jpg

REVISION DETAIL
  https://phabricator.kde.org/D16560

AFFECTED FILES
  autotests/embeddedimagedatatest.cpp
  autotests/samplefiles/cover.jpg

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16490: [KFileMetaData] Add unittest for XML extractor

2018-10-31 Thread Alexander Stippich 
astippich added a comment.


  Only one minor thing: please also check that the mimetype is in the list of 
supported mimetypes

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16490

To: bruns, #frameworks, astippich
Cc: lbeltrame, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16489: [KFileMetaData] Add extractor for generic XML and SVG

2018-10-31 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> xmlextractor.cpp:24
> +
> +#include 
> +#include 

seems unused

> xmlextractor.cpp:27
> +#include 
> +#include 
> +

same

> xmlextractor.cpp:71
> +
> +return list;
> +}

Can we agree on using a static qstringlist if the mimetypes are fixed? I 
prepared a patch to convert all other extractors to this scheme when applicable 
in D16554 

Also, using an initializer list is faster, see 
https://www.angrycane.com.br/en/2018/06/19/speeding-up-cornercases/

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16489

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Stefan Brüns 
bruns added a subscriber: FreeBSD.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: #freebsd, bruns, apol, kde-frameworks-devel, michaelh, ngraham

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Stefan Brüns 
bruns added a comment.


  In D16488#351584 , @astippich 
wrote:
  
  > I guess you plan to convert the existing extractors to use this?
  
  
  Yes, thats the plan
  
  > The only concern I might have that now two iterations over the node are 
required when this is used in e.g. odfextractor, isn't it?
  
  The QDomDocument can be reused, so parsing is only done once. Iteration needs 
to be done twice, but this is only a minor issue as the metadata documents are 
**really** small (~10 nodes, 1kByte). For the office2007extractor it actually 
is a win, as it currently iterates the tree once per property.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16554: move supported mimetypes to static string list

2018-10-31 Thread Alexander Stippich 
astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Do not create the list of supported mime types on demand
  and use a static stringlist instead.
  Order alphabetically where required

REPOSITORY
  R286 KFileMetaData

BRANCH
  mimetype_lists

REVISION DETAIL
  https://phabricator.kde.org/D16554

AFFECTED FILES
  src/extractors/epubextractor.cpp
  src/extractors/epubextractor.h
  src/extractors/exiv2extractor.cpp
  src/extractors/exiv2extractor.h
  src/extractors/ffmpegextractor.cpp
  src/extractors/ffmpegextractor.h
  src/extractors/odfextractor.cpp
  src/extractors/odfextractor.h
  src/extractors/office2007extractor.cpp
  src/extractors/office2007extractor.h
  src/extractors/plaintextextractor.cpp
  src/extractors/plaintextextractor.h
  src/extractors/poextractor.cpp
  src/extractors/poextractor.h
  src/extractors/popplerextractor.cpp
  src/extractors/popplerextractor.h
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/writers/taglibwriter.cpp
  src/writers/taglibwriter.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16488: [KFileMetaData] Add helper for XML encoded Dublin Core metadata

2018-10-31 Thread Alexander Stippich 
astippich added a comment.


  I guess you plan to convert the existing extractors to use this?
  The only concern I might have that now two iterations over the node are 
required when this is used in e.g. odfextractor, isn't it?
  Btw, I don't think it's necessary to prepend KFileMetaData in the diff title, 
since the repository is only for KFileMetaData anyway.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16488

To: bruns, #frameworks, astippich
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16395: Update the "About KDE" text

2018-10-31 Thread Valorie Zimmerman 
valorie added a comment.


  My only suggestion: KDE creates the efficient, powerful Plasma desktop 
environment, hundreds of high-quality applications and the many software 
libraries that support them.
  
  Past tense makes the present version seem static.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread David C 
davidc added a comment.


  Thanks for the update, and for tightening some of the language. The only nag 
I have is with the last sentence in the first paragraph.
  
  Seeing Plasma described as "friendly" seems a bit like fluff and is an 
awkward choice of words for a user interface. I know you were probably going 
for "user-friendly" and that it would be a bit cumbersome when added to the 
sentence, but I think it might be best just to strike "friendly and powerful" 
entirely, since the sentence runs on a bit as it is.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Damjan Georgievski 
damjang added a comment.


  is it ok if the waiting on the legacy kwallet4 is made synchronous? wiring 
all those signals will make my head explode :)
  
  wait 5 sec, otherwise give up on the migration?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks! Regardless, I'll only land this after the Frameworks string freeze is 
lifted (i.e. once 5.52 is tagged).

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Isadora D. 
skadinna accepted this revision as:  KDE Promo.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 44564.
ngraham added a comment.


  Use https URLs

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16395?vs=44563=44564

BRANCH
  update-about-kde-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16395

AFFECTED FILES
  src/kaboutkdedialog_p.cpp

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 44563.
ngraham added a comment.


  Promo team tweaks

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16395?vs=44562=44563

BRANCH
  update-about-kde-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16395

AFFECTED FILES
  src/kaboutkdedialog_p.cpp

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham updated this revision to Diff 44562.
ngraham added a comment.


  Consistently capitalize "Free Software"

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16395?vs=44192=44562

BRANCH
  update-about-kde-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16395

AFFECTED FILES
  src/kaboutkdedialog_p.cpp

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16395: Update the "About KDE" text

2018-10-31 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: xyquadrat, rizzitello, ltoscano, aspotashev, abetts, kde-frameworks-devel, 
michaelh, ngraham, bruns

D16137: Add an option to KConfigDialog to fit page contents horizontally

2018-10-31 Thread Tim __ 
kadabash added a comment.


  While adapting the settings window in Cantor to this proposed change I have 
discovered that it influences the `sizeHint()` of other (non-modified) pages in 
the same window. This leads to a worse layout than before.
  
  As I cannot currently find the source of that behaviour, this change should 
probably not be considered for merging.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D16137

To: kadabash
Cc: ngraham, svuorela, aacid, kde-frameworks-devel, michaelh, bruns

D16529: make libssh module default to the "new" libssh config by default

2018-10-31 Thread Harald Sitter 
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:0e129b10ae30: make libssh module default to the 
new libssh config by default (authored by sitter).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16529?vs=44496=44531

REVISION DETAIL
  https://phabricator.kde.org/D16529

AFFECTED FILES
  CMakeLists.txt
  cmake/Findlibssh.cmake

To: sitter, broulik, asn
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D16305: Add a QIconEnginePlugin to allow QIcon deserialization

2018-10-31 Thread Luca Beltrame 
lbeltrame added a comment.


  +1.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D16305

To: fvogt, #frameworks
Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns