D17317: match and tc setting

[Jan Grulich]

jgrulich added a comment.


  Can you please rebase your changes on top of the current master? I did some 
changes there and the patch is not applicable.

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 360 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/360/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 04 Dec 2018 06:22:05 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32023/60117)37%
(16525/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4283/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8392/14338)51%
(4683/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3910/7971)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 511 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/511/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 04 Dec 2018 06:22:05 +
 Build duration:
5 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31938/60116)37%
(16488/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4285/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8324/14337)50%
(4660/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3908/7971)34%
(1603/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1305/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
  

D17285: Add plugin type for sharing URLs

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:74e0e9852637: Add plugin type for sharing URLs (authored 
by nicolasfella).

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17285?vs=46635&id=46821

REVISION DETAIL
  https://phabricator.kde.org/D17285

AFFECTED FILES
  src/plugins/ShareUrlPluginType.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/standard-plugin-types.qrc

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  shareUrl

REVISION DETAIL
  https://phabricator.kde.org/D17285

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kdeconnectsmsplugin.cpp:51
> +QString title = data().value(QStringLiteral("title")).toString();
> +QString message = QStringLiteral("%1 - 
> %2").arg(title).arg(arrayToList(urlsJson).join(QLatin1Char(' ')));
> +

i18n? Thinking of RTL languages.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17305

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not sure it makes a lot of sense to have the application include the 
title, isn't it better that the user writes it down on a config page or just 
the e-mail client?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17287

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

[Elvis Angelaccio]

On 03/12/18 09:46, Ben Cooksley wrote:
> Hi all,

Hi Ben

> 
> I've been informed by the PIM developers that they would like to bump
> the dependency of the Qt version they use, from Qt 5.9 which it's on
> currently, to Qt 5.10.
> 
> As a consequence, due to many KDE projects using PIM libraries, their
> dependency on Qt will also be effectively bumped. To minimize the
> maintenance cost of this bump for the CI system, I would like to bump
> everyone up from Qt 5.9 to a newer version of Qt (otherwise we'll end
> up chasing down build failures for a long time)

It's not clear if you are suggesting to bump the minimum required Qt
version in each CMakeLists.txt file, or if you are just going to bump
the Qt version used by the CI server.

Could you please clarify? Thanks!

> 
> As most distributions have moved on from 5.10, and use Qt 5.11 now
> (and will in many cases soon move to Qt 5.12), i'd like to suggest
> that instead of going to Qt 5.10, we move straight to 5.11.
> 
> Because Frameworks has a two versions prior support policy, it'll
> remain on 5.9 for now until it's ready to move up to 5.10 (assuming
> 5.12 is a usable Qt version)
> 
> If nobody has any objections, i'll proceed with this change in around
> 3 days time.
> 
> Cheers,
> Ben
>

Cheers,
Elvis

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

[Stefan Brüns]

bruns updated this revision to Diff 46820.
bruns added a comment.


  add missing iterator increment

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17338?vs=46810&id=46820

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:eacc7ac92ab0: Add "image/svg" as Type::Image to 
the BasicIndexingJob (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17337?vs=46808&id=46819

REVISION DETAIL
  https://phabricator.kde.org/D17337

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17332: Minor optimization and cleanup for PositionCodec

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c9281ac74e45: Minor optimization and cleanup for 
PositionCodec (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17332?vs=46791&id=46818

REVISION DETAIL
  https://phabricator.kde.org/D17332

AFFECTED FILES
  src/codecs/coding.cpp
  src/codecs/coding.h

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17310: Improve Kile icon with LaTeX font

[Noah Davis]

ndavis added a comment.


  What if instead of using 'a' as a variable in the equation, we used 'k'?

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Francis Herne]

flherne added a comment.


  Please no.
  
  `File -> Save` is one of the most universal menu entries, found in nearly 
every program that *has* a set of menus. Print is nearly as common.
  
  This breaks a user assumption that's been ingrained across virtually all GUI 
software for decades, and makes common operations more cumbersome (although I 
assume many users prefer the shortcuts), for the sake of a few lines in the 
menu.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D17309: Add flashlight action icons

[TrickyRicky]

trickyricky26 added a comment.


  Ok, will do when I have some time :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

[Nathaniel Graham]

ngraham added a comment.


  I also like the horizontal one better.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

[Noah Davis]

ndavis added a comment.


  In D17309#370774 , @trickyricky26 
wrote:
  
  > Do you think this style is better (16px versions shown):
  >  F6453093: Alternate Style.png 
  
  
  I think so. It's more obvious that it's a flashlight.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah, great! Makes sense then, sorry for being dense. :)

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Dominik Haumann]

dhaumann added a comment.


  Hm, is this really a good idea? Right now, the File menu is rather flat, 
which is a good thing imo. Do we really want to move Save operations into a 
"Save Variants" sub menu?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Stefan Brüns]

bruns added a comment.


  In D17337#370955 , @ngraham wrote:
  
  > In D17337#370936 , @bruns wrote:
  >
  > > In D17337#370934 , @ngraham 
wrote:
  > >
  > > > > text spans (i.e. content) in SVG.
  > > >
  > > > Is indexing any of this actually useful? I worry that it would be just 
noise in >99% of cases.
  > >
  > >
  > > Why should this be noise? Can you clarify?
  >
  >
  > This text in an SVG file is an implementation detail, not user content like 
the metadata in a JPEG. For example, here's the textual content of a random 
Breeze icon:
  >
  > https://cgit.kde.org/breeze-icons.git/tree/icons/devices/64/computer.svg
  
  
  No, thats the **raw** data, not text spans, e.g. `Some Text`.
  
  See e.g. https://suchanek.name/programs/powerline/intro/3.svg
  
  The content is e.g. "LaTex with PowerLine"

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Nathaniel Graham]

ngraham added a comment.


  In D17337#370936 , @bruns wrote:
  
  > In D17337#370934 , @ngraham 
wrote:
  >
  > > > text spans (i.e. content) in SVG.
  > >
  > > Is indexing any of this actually useful? I worry that it would be just 
noise in >99% of cases.
  >
  >
  > Why should this be noise? Can you clarify?
  
  
  This text in an SVG file is an implementation detail, not user content like 
the metadata in a JPEG. For example, here's the textual content of a random 
Breeze icon:
  
  https://cgit.kde.org/breeze-icons.git/tree/icons/devices/64/computer.svg
  
  For example would it make sense to find SVG files when searching for "layer" 
or "matrix" or "connector"?
  
  If we have a way to index only the genuine metadata (author, keywords, etc) 
but omit the text that comprises the icon's internal representation, that would 
work. Otherwise I think this would just add a lot of useless data to the DB.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Stefan Brüns]

bruns added a comment.


  In D17337#370934 , @ngraham wrote:
  
  > > text spans (i.e. content) in SVG.
  >
  > Is indexing any of this actually useful? I worry that it would be just 
noise in >99% of cases.
  
  
  Why should this be noise? Can you clarify?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Nathaniel Graham]

ngraham added a comment.


  In D17337#370929 , @bruns wrote:
  
  > 1. This is just the document type, so it would be even useful for filename 
only searches
  
  
  Cool, that seems fine.
  
  > text spans (i.e. content) in SVG.
  
  Is indexing any of this actually useful? I worry that it would be just noise 
in >99% of cases.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Stefan Brüns]

bruns added a comment.


  In D17337#370926 , @ngraham wrote:
  
  > Is indexing the contents of SVG images actually desirable? The fact that 
these files are internally represented by text rather than binary data is an 
implementation detail, and their contents are generally not useful since 
they're not intended to be human-readable.
  
  
  Twice wrong ;-):
  
  1. This is just the document type, so it would be even useful for filename 
only searches
  2. The xmlextractor I have added recently to KFileMetaData handles Dublin 
Core metadata (e.g. Author, Keywords, ...) and text spans (i.e. content) in SVG.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Nathaniel Graham]

ngraham added a comment.


  Is indexing the contents of SVG images actually desirable? The fact that 
these files are internally represented by text rather than binary data is an 
implementation detail, and their contents are generally not useful since 
they're not intended to be human-readable.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17337

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17332: Minor optimization and cleanup for PositionCodec

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17332

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 167 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/167/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 03 Dec 2018 18:47:30 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 38 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5647/9421)43%
(2212/5196)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)98%
(865/886)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/145)73%
(35/48)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(846/1669)41%
(434/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/270)0%
(0/221)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/940)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/71)0%
(0/28)src.tools.balooctl0%
(0/7)0%
(0/7)0%
(0/630)0%
  

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

[Stefan Brüns]

bruns updated this revision to Diff 46810.
bruns added a comment.


  add missing closing parentheses

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17338?vs=46809&id=46810

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 201 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/201/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Dec 2018 18:47:30 +
 Build duration:
3 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 38 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5647/9421)43%
(2212/5196)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(40/40)100%
(14/14)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(38/38)61%
(11/18)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)98%
(865/886)55%
(285/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)86%
(125/145)73%
(35/48)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(846/1669)41%
(434/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/270)0%
(0/221)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/940)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
(0/3)0%
(0/3)0%
(0/71)0%
(0/28)src.tools.balooctl0%
(0/7)0%
(0/7)0%
(0/630)0%
  

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Removes the KFileMetadata include dependency in the header.
  
  While at it, remove the temporary QList, just iterate
  through the hash.
  
  Depends on D17324 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

[Stefan Brüns]

bruns added a dependent revision: D17338: Move typesForMimeType helper from 
BasicIndexingJob to anonymous namespace.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17324

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 84 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/84/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Mon, 03 Dec 2018 18:47:30 +
 Build duration:
1 min 49 sec and counting

D17337: Add "image/svg" as Type::Image to the BasicIndexingJob

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17337

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17315: Avoid potential nullptr access for Document, use reference instead

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4fa98ca84fb3: Avoid potential nullptr access for 
Document, use reference instead (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17315?vs=46755&id=46807

REVISION DETAIL
  https://phabricator.kde.org/D17315

AFFECTED FILES
  autotests/integration/querytest.cpp
  autotests/unit/engine/termgeneratortest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17300: add result to baloo namespace

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17300

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17315: Avoid potential nullptr access for Document, use reference instead

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17315

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  In D16643#370642 , @bruns wrote:
  
  > This should not be accepted as is, it breaks the temporaryInhibition case 
when a DropArea is child of another
  
  
  Ok, could you write a simple QML file to show that case?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16954: Add find module for Google's libphonenumber

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

[Volker Krause]

vkrause updated this revision to Diff 46805.
vkrause added a comment.


  Address review comments.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16954?vs=45643&id=46805

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16954

AFFECTED FILES
  find-modules/FindPhoneNumber.cmake

To: vkrause, #build_system, #frameworks
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

[Nathaniel Graham]

ngraham added a comment.


  No competence here, sorry. Perhaps @bruns or a #plasma 
 person can help.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17310: Improve Kile icon with LaTeX font

[Nathaniel Graham]

ngraham added a comment.


  Yeah, a stylized "K" on its own might work.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17310: Improve Kile icon with LaTeX font

[Michel Ludwig]

mludwig added a comment.


  In D17310#370758 , @ngraham wrote:
  
  > I would not recommend embedding the app name into the icon itself. The text 
isn't localizable, the icon would become really cramped, and in any event it 
would look weird since no other app does this.
  >
  > For those reasons, our HIG specifically recommends against this: 
https://hig.kde.org/style/icon.html?highlight=icons#general-guidelines
  
  
  Well, it's not really arbitrary text, but the name of the application, so I 
it wouldn't be localized much. Besides, Kile's official icons have contained 
the character "K" or the string "Kile" for over 15 years.
  
  F6453199: kile_big.png  F6453202: 
favicon.ico 
  
  Off the top of my head, another example of such an icon design is the one of 
Evince , which contains a stylized letter 
'e' - I know it's from the competition ;)
  
  Or to some extent, the icon of kcharselect, which I really like.
  
  The biggest issue that I have with the square root icon is that it doesn't 
symbolize enough that it's the icon of an application. To me, it just looks 
like the application of a file type. Some dynamic element is missing, like a 
pencil, for example, to indicate that it's an application for editing such 
files.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17300: add result to baloo namespace

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  Actually, this class **is** different - it is not part of the libraries, but 
statically linked into the extractor process

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17300

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17309: Add flashlight action icons

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17309: Add flashlight action icons

[TrickyRicky]

trickyricky26 added a comment.


  Do you think this style is better (16px versions shown):
  F6453093: Alternate Style.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17334: Export enum into qobject for easier debugging

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17334

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/errorcode.h

To: apol, #frameworks, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

[Nathaniel Graham]

ngraham added a comment.


  I would not recommend embedding the app name into the icon itself. The text 
isn't localizable, the icon would become really cramped, and in any event it 
would look weird since no other app does this.
  
  For those reasons, our HIG specifically recommends against this: 
https://hig.kde.org/style/icon.html?highlight=icons#general-guidelines

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46792.
pranavgade marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46789&id=46792

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17325: Fix leak in kemoticons

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kemoticonstheme.cpp:57
>  d = new KEmoticonsThemeData;
> -d->provider = p;
> +d->provider.reset(p);
>  }

I've rethink it, this line can be a problem if pointer is not owned by us. Did 
you know consumer of the KEmoticonsTheme?

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D17325

To: kfunk
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

[TrickyRicky]

trickyricky26 added a comment.


  Thats rather difficult. Adding it to the proposed design looks quite cramped: 
  F6452990: kile-alternative.svg.png 
  
  The only good way to fit "Kile" into that shape is vertical, which looks 
weird and is not very legible:
  F6452992: kile-alternative2.svg.png 
  
  A more elegant way would be just the letter K:
  F6452998: kile-alternative3.svg.png 
  But I think at that point the meaning is less obvious than the root sign imo

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17317: match and tc setting

[Jan Grulich]

jgrulich added a comment.


  And you submitted only changes on top of your changes.

INLINE COMMENTS

> tcsettingtest.cpp:92
> +// Here the maps should have same keys so compare 
> QVariantMaps as we do now
> +QCOMPARE(listMap, listMap1);
> +++comparedMaps;

I liked your original solution better, I mean the way you compared if you are 
going to compare correct maps. Anyway, this still doesn't compare the maps 
properly, you have to go value by value.

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17331: Extend PositionCodec unit tests, better code coverage

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The test never tested position increments larger than 1, as the positions
  where divided by the docId. Multibyte (i.e. value >= 128) position
  steps where completely omitted.
  
  Use identical datasets in the functional tests and in the benchmarks.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17331

AFFECTED FILES
  autotests/benchmarks/positioncodecbenchmark.cpp
  autotests/unit/codecs/positioncodectest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17332: Minor optimization and cleanup for PositionCodec

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Both getVarint32Ptr and getVarint32PtrFallback return nullptr when
  p >= limit. Avoid the call to getVarint32PtrFallback and immediately
  return from getVarint32.
  
  As it is safe to call getVarint32 with p >= limit, skip the extra check in
  each getDifferentialVarInt32 loop iteration, speeds up decoding results
  for the 3 benchmark cases by ~10%.
  
  Remove unnecessary reinterpret_cast(p), p is a char*.

TEST PLAN
  positioncodecbenchmark
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17332

AFFECTED FILES
  src/codecs/coding.cpp
  src/codecs/coding.h

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46789.
pranavgade marked 4 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46786&id=46789

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17325: Fix leak in kemoticons

[Kevin Funk]

kfunk updated this revision to Diff 46787.
kfunk added a comment.


  Use QSharedPointer

REPOSITORY
  R301 KEmoticons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17325?vs=46765&id=46787

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17325

AFFECTED FILES
  src/core/kemoticonstheme.cpp

To: kfunk
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

[René J . V . Bertin]

Hi,

Can't you just configure the CI to use Qt 5.10? I think it's not good to 
hardcode an "overzealous" (for lack of a better word) Qt version in projects 
that don't require them AND I think that one should support the current LTS 
release in as many projects as possible as a general rule of principle.

There's a reason why those LTS releases exist and that should probably be taken 
into consideration ESPECIALLY for the KF5 Frameworks (remember why kdelibs4 was 
split up)!

People working only on Linux may not realise it but even Qt 5.9 already dropped 
support for Mac OS versions that are still widely used.

IMHO, projects that use PIM libraries can decide for themselves how they want 
to deal with a Qt minimum version bump in those dependencies, while 
distribution maintainers *could* decide to keep those (and only those) 
dependencies on an earlier version in order to keep supporting whatever oldest 
Qt requirement they have (5.9 for my MacPorts packaging). Also, don't of those 
projects have only optional dependencies on PIM libraries?

I tend to see a CI as something that tests software on one or a handful of the 
most common configurations. Anyone not using such a configuration is either on 
their own or acting as a kind of additional CI.

Bumping the minimum Qt version across the line would decrease the burden on the 
CI, but probably increase the burden on distributions, or force them to stop 
following upgrades earlier than justified.

Also:
> (otherwise we'll end up chasing down build failures for a long time)

How so? If you want to install project B that requires Qt 5.9+ but also uses 
PIM library A which requires Qt 5.1x you're going to need to install something 
newer than Qt 5.9 . What kind of build failures we cannot already get ("B 
requires PIM library A which is not installed") are you expecting?
There could be errors from *other* projects not depending on PIM libraries, but 
if they intend to support an "older" Qt version that implies rather explicitly 
that they also intend to address build failures, no?


R.

Re: Transitioning CI builds of all non-Frameworks from Qt 5.9

[Ben Cooksley]

On Mon, Dec 3, 2018 at 10:31 PM René J.V. Bertin  wrote:
>
> Hi,
>
> Can't you just configure the CI to use Qt 5.10? I think it's not good to 
> hardcode an "overzealous" (for lack of a better word) Qt version in projects 
> that don't require them AND I think that one should support the current LTS 
> release in as many projects as possible as a general rule of principle.

Not really, because it won't be long before 5.10 is no longer any of
the current mainstream distributions.

>
> There's a reason why those LTS releases exist and that should probably be 
> taken into consideration ESPECIALLY for the KF5 Frameworks (remember why 
> kdelibs4 was split up)!

As mentioned in my mail, this applies to everything but Frameworks.
It doesn't affect Frameworks - which will continue on Qt 5.9 at this stage.

>
> People working only on Linux may not realise it but even Qt 5.9 already 
> dropped support for Mac OS versions that are still widely used.
>
> IMHO, projects that use PIM libraries can decide for themselves how they want 
> to deal with a Qt minimum version bump in those dependencies, while 
> distribution maintainers *could* decide to keep those (and only those) 
> dependencies on an earlier version in order to keep supporting whatever 
> oldest Qt requirement they have (5.9 for my MacPorts packaging). Also, don't 
> of those projects have only optional dependencies on PIM libraries?

For some it's mandatory.

>
> I tend to see a CI as something that tests software on one or a handful of 
> the most common configurations. Anyone not using such a configuration is 
> either on their own or acting as a kind of additional CI.
>
> Bumping the minimum Qt version across the line would decrease the burden on 
> the CI, but probably increase the burden on distributions, or force them to 
> stop following upgrades earlier than justified.
>
> Also:
> > (otherwise we'll end up chasing down build failures for a long time)
>
> How so? If you want to install project B that requires Qt 5.9+ but also uses 
> PIM library A which requires Qt 5.1x you're going to need to install 
> something newer than Qt 5.9 . What kind of build failures we cannot already 
> get ("B requires PIM library A which is not installed") are you expecting?

The CI system has no way of knowing what a project says it requires.
It relies on it's own configuration files to dictate what jobs are
generated, and those jobs in turn determine what platform they're run
on.

What i'm referring to here is the manual process of having to go and
exclude various projects which do use PIM libraries (the CI system
doesn't have a concept of optional, it's either needed or not present
at all). The only way to do this will be by hunting through the
dependency graph, which is easier said than done (because Application
A uses library B which uses library C which in turn uses PIM library
D)

Individual project failures might not seem too bad, apart from the
fact it's me (or one of the handful of people familiar with the CI
system configuration) who will have to update the configuration for
many projects (which will result in either lots of Sysadmin tickets,
or a ton of various people spending time hunting these issues down).

Note that in order for the CI system to operate properly the
"Dependency Build" jobs need to be able to run successfully (otherwise
you'll have missing dependencies when you go to run a build). In most
cases it won't be jobs themselves that fail, it'll be the Dependency
Build jobs - and because these jobs start from scratch (ECM, then up
through Frameworks and so on until every project's dependencies have
been built) it's extremely expensive to keep running these jobs as
they occupy builders for quite a bit of time.

> There could be errors from *other* projects not depending on PIM libraries, 
> but if they intend to support an "older" Qt version that implies rather 
> explicitly that they also intend to address build failures, no?
>

We see those on a semi-regular basis - as those who have seen QtTest
casting issues will be well aware.

>
> R.

Cheers,
Ben

D17317: match and tc setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> tcsettingtest.cpp:92
> +if (comparedvals == map.size()) {
> +comparedMaps++;
> +}

You still don't compare the values.

> jgrulich wrote in setting.cpp:33
> Same here, should be NM 1.14.0.

NM 1.14.0 is needed for NM_SETTING_MATCH_SETTING_NAME

> jgrulich wrote in tcsetting.cpp:118
> Indent.

Still applies.

> jgrulich wrote in tcsetting.cpp:122
> const QVariantMap &tfilter

Still applies.

> tcsetting.h:27
> +
> +#include 
> +#include 

No need to include QString and QStringList

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46786.
pranavgade marked 3 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46785&id=46786

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46785.
pranavgade marked 5 inline comments as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46761&id=46785

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

[Thomas Surrel]

thsurrel added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in kurlnavigatorbutton.cpp:414
> Or we could use mimetype detection like we do in 
> `KUrlNavigator::Private::isCompressedPath()`.

What would be the clean way to expose this function ? I wouldn't like to 
duplicate the code.
And btw, the "if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme() 
== QLatin1String("zip")))" condition was taken from 
KUrlNavigator::setLocationUrl, so there must be a bugfix to be made there as 
well with the 'krarc' case gregormi reports.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17270

To: thsurrel, #frameworks
Cc: elvisangelaccio, gregormi, kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> matchsettingtest.cpp:29
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MATCH_INTERFACE_NAME"interface-name"

NM 1.14.0, which is not released yet.

> jgrulich wrote in tcsettingtest.cpp:74
> Something like:
> 
>   NMVariantMapList list = it.value();
>   NMVariantMapList list1 = map1.value(it.key());
>   QCOMPARE(list.count(), list1.count());
>   
>   int comparedMaps = 0;
>   NMVariantMapList::const_iterator listIt = list.constBegin();
>   while (listIt != list.constEnd() {
>   NMVariantMapList::const_iterator list1It = list1.constBegin();
>   while (list1it != list1.constEnd()) {
>QVariantMap listMap = listIt.value();
>QVariantMap1 listMap1 = list1It.value();
>// Test if keys do match, because the list can be in different 
> order
>QStringList listMapKeys = listMap.keys();
>QStringList listMapKeys1 = listMap1.keys();
>listMapKeys.sort();
>listMapKeys1.sort();
>if (listMapKeys.join(QChar(' ')) ==  listMapKeys1.join(QChar(' 
> '))) {
>  // Here the maps should have same keys so compare 
> QVariantMaps as we do now
>  .
>  ++comparedMaps;
>}
>++list1it;  
>}
>++listIt;
>   }
>   
>   // Test if we compared all maps, if not, then probably they didn't match
>   QCOMPARE(comparedMaps, list.count();

It should be:

  // Will fail if set some default values, because they are skipped in toMap() 
method
  QVariantMap::const_iterator it = map.constBegin();
  while (it != map.constEnd()) {
  NMVariantMapList list = it.value().value();
  NMVariantMapList list1 = map1.value(it.key()).value();
  QCOMPARE(list.count(), list1.count());
  
  int comparedMaps = 0;
  NMVariantMapList::const_iterator listIt = list.constBegin();
  while (listIt != list.constEnd()) {
  NMVariantMapList::const_iterator list1It = list1.constBegin();
  while (list1It != list1.constEnd()) {
  QVariantMap listMap = *listIt;
  QVariantMap listMap1 = *list1It;
  // Test if keys do match, because the list can be in different 
order
  QStringList listMapKeys = listMap.keys();
  QStringList listMapKeys1 = listMap1.keys();
  listMapKeys.sort();
  listMapKeys1.sort();
  if (listMapKeys.join(QChar(' ')) ==  listMapKeys1.join(QChar(' 
'))) {
  // Here the maps should have same keys so compare 
QVariantMaps as we do now
  .
  ++comparedMaps;
  }
  ++list1It;
  }
  ++listIt;
  }
  ++it;
  }

You just need to add missing comparison of variant maps, which should be 
trivial.

> matchsetting.cpp:26
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MATCH_SETTING_NAME  "match"

This is actually in master only, which means upcoming NM 1.14.0.

> setting.cpp:33
> +#endif
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MATCH_SETTING_NAME  "match"

Same here, should be NM 1.14.0.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 359 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/359/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 03 Dec 2018 12:03:44 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32057/60120)38%
(16536/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4288/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8425/14340)51%
(4692/9263)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3915/7972)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1036)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 510 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/510/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Dec 2018 12:03:44 +
 Build duration:
8 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31934/60116)37%
(16476/44086)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4275/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8324/14337)50%
(4659/9259)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3909/7971)34%
(1604/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%
   

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:518a7496c5c5: Warn user before copy/move job if the file 
size exceeds the maximum possible… (authored by shubham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16249?vs=46490&id=46783#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16249?vs=46490&id=46783

REVISION DETAIL
  https://phabricator.kde.org/D16249

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/global.h
  src/core/job_error.cpp

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, 
kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 200 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/200/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Dec 2018 11:55:42 +
 Build duration:
5 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 209.71 KB...]Scanning dependencies of target writetransactiontest_autogen[ 26%] Automatic MOC for target writetransactiontest[ 26%] Built target writetransactiontest_autogenScanning dependencies of target querytest_autogen[ 27%] Automatic MOC for target querytest[ 27%] Built target querytest_autogenScanning dependencies of target documentdatadbtest[ 27%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest.cpp.o[ 27%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/singledbtest.cpp.o[ 28%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest_autogen/mocs_compilation.cpp.o[ 28%] Linking CXX executable ../../../bin/documentdatadbtest[ 28%] Built target documentdatadbtestScanning dependencies of target documenttimedbtest[ 28%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest.cpp.o[ 28%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/singledbtest.cpp.o[ 29%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest_autogen/mocs_compilation.cpp.o[ 29%] Linking CXX executable ../../../bin/documenttimedbtest[ 29%] Built target documenttimedbtestScanning dependencies of target documentiddbtest[ 30%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest.cpp.o[ 30%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/singledbtest.cpp.o[ 30%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest_autogen/mocs_compilation.cpp.o[ 30%] Linking CXX executable ../../../bin/documentiddbtest[ 30%] Built target documentiddbtestScanning dependencies of target phraseanditeratortest[ 30%] Building CXX object autotests/unit/engine/CMakeFiles/phraseanditeratortest.dir/phraseanditeratortest.cpp.o[ 31%] Building CXX object autotests/unit/engine/CMakeFiles/phraseanditeratortest.dir/singledbtest.cpp.o[ 31%] Building CXX object autotests/unit/engine/CMakeFiles/phraseanditeratortest.dir/phraseanditeratortest_autogen/mocs_compilation.cpp.o[ 31%] Linking CXX executable ../../../bin/phraseanditeratortest[ 31%] Built target phraseanditeratortestScanning dependencies of target documentdbtest[ 31%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest.cpp.o[ 32%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/singledbtest.cpp.o[ 32%] Building CXX object autotests/unit/engine/CMakeFiles/documentdbtest.dir/documentdbtest_autogen/mocs_compilation.cpp.o[ 32%] Linking CXX executable ../../../bin/documentdbtest[ 32%] Built target documentdbtestScanning dependencies of target queryparsertest[ 32%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest.cpp.o[ 33%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o[ 33%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest_autogen/mocs_compilation.cpp.o[ 33%] Linking CXX executable ../../../bin/queryparsertest[ 33%] Built target queryparsertestScanning dependencies of target documenturldbtest[ 33%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/documenturldbtest.cpp.o[ 34%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/singledbtest.cpp.o[ 34%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/documenturldbtest_autogen/mocs_compilation.cpp.o[ 34%] Linking CXX executable ../../../bin/documenturldbtest[ 34%] Built target documenturldbtestScanning dependencies of target positiondbtest[ 34%] Building CXX object autotests/unit/engine/CMakeFiles/positiondbtest.dir/positiondbtest.cpp.o[ 34%] Building CXX object autotests/unit/engine/CMakeFiles/positiondbtest.dir/singledbtest.cpp.o[ 34%] Building CXX object autotests/unit/engine/CMakeFiles/positiondbtest.dir/positiondbtest_autogen/mocs_compilation.cpp.o[ 35%] Linking CXX executable ../../../bin/positiondbtest[ 35%] Built target positiondbtestScanning dependencies of target idfilenamedbtest[ 35%] Building CXX object autotests/unit/engine/CMakeFiles/idfilenamedbtest.dir/idfilenamedbtest.cpp.o[ 35%] Building CXX object autotests/unit/engine/CMakeFiles/idfilenamedbtest.dir/singledbtest.cpp.o[ 35%] Building CXX object autotests/unit/engine/CMakeFiles/idfilenamedbtest.dir/idfilenamedbtest_autogen/mocs_compilation.cpp.o[ 36%] Linking CXX executable ../../../bin/idfilenamedbtest[ 36%] Built target idfilenamedbtestScanning dependencies of target idtreedbtest[ 36%] Building CXX object autotests/unit/engine/CMakeFiles/id

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.11 - Build # 83 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.11/83/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Mon, 03 Dec 2018 11:55:43 +
 Build duration:
3 min 16 sec and counting
   CONSOLE OUTPUT
  [...truncated 237.61 KB...][ 49%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest.cpp.o[ 50%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/singledbtest.cpp.o[ 50%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filewatch.cpp.o[ 51%] Building CXX object autotests/unit/engine/CMakeFiles/transactiontest.dir/transactiontest_autogen/mocs_compilation.cpp.o[ 51%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest_autogen/mocs_compilation.cpp.o[ 52%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/singledbtest.cpp.o/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/filewatch.cpp:39:79: warning: unused parameter 'dbusInterface' [-Wunused-parameter]FileWatch::FileWatch(Database* db, FileIndexerConfig* config, Baloo::MainHub *dbusInterface, QObject* parent)  ^1 warning generated.[ 52%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/pendingfilequeue.cpp.o[ 52%] Linking CXX executable ../../../bin/transactiontest[ 52%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest_autogen/mocs_compilation.cpp.o[ 52%] Built target transactiontest[ 52%] Linking CXX executable ../../../bin/queryparsertestScanning dependencies of target documentiddbtest[ 52%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest.cpp.o[ 52%] Built target queryparsertest[ 53%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/metadatamover.cpp.oScanning dependencies of target documenttimedbtest[ 54%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest.cpp.o[ 54%] Linking CXX executable ../../../bin/mtimedbtest[ 55%] Built target mtimedbtest[ 55%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/singledbtest.cpp.oScanning dependencies of target documentdatadbtest[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest.cpp.o[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/singledbtest.cpp.o[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documentiddbtest.dir/documentiddbtest_autogen/mocs_compilation.cpp.o[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/singledbtest.cpp.o[ 56%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/pendingfile.cpp.o[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documenttimedbtest.dir/documenttimedbtest_autogen/mocs_compilation.cpp.o[ 56%] Linking CXX executable ../../../bin/documentiddbtest[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documentdatadbtest.dir/documentdatadbtest_autogen/mocs_compilation.cpp.o[ 56%] Built target documentiddbtest[ 56%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/kinotify.cpp.o[ 56%] Linking CXX executable ../../../bin/documenttimedbtestScanning dependencies of target documenturldbtest[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/documenturldbtest.cpp.o[ 56%] Built target documenttimedbtestScanning dependencies of target idtreedbtest[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/idtreedbtest.dir/idtreedbtest.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/kinotify.cpp:35:/usr/local/include/sys/inotify.h:40:10: warning: flexible array members are a C99 feature [-Wc99-extensions]char name[]; /* Name.  */ ^[ 56%] Linking CXX executable ../../../bin/documentdatadbtest/usr/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 FreeBSDQt5.11/src/file/kinotify.cpp:328:45: warning: cast from 'char *' to 'struct inotify_event *' increases required alignment from 1 to 4 [-Wcast-align]const struct inotify_event* event = (struct inotify_event*)&buffer[i];^[ 56%] Built target documentdatadbtest[ 56%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/baloodebug.cpp.o2 warnings generated.[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/singledbtest.cpp.o[ 57%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/baloowatcherapplication_interface.cpp.o[ 57%] Building CXX object autotests/unit/engine/CMakeFiles/idtreedbtest.dir/singledbtest.cpp.o[ 57%] Building CXX object autotests/unit/engine/CMakeFiles/idtreedbtest.dir/idtreedbtest_autogen/mocs_compilation.cpp.o[ 58%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldb

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.9 - Build # 166 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.9/166/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 03 Dec 2018 11:55:43 +
 Build duration:
1 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 259.23 KB...][ 52%] Linking CXX executable ../../../bin/phraseanditeratortest[ 52%] Built target documentiddbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/singledbtest.cpp.o[ 53%] Built target documenttimedbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/documenturldbtest.dir/documenturldbtest_autogen/mocs_compilation.cpp.o[ 53%] Built target phraseanditeratortestScanning dependencies of target positiondbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/positiondbtest.dir/positiondbtest.cpp.o[ 53%] Linking CXX executable ../../../bin/documentdbtest[ 53%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/__/dbus/maininterface.cpp.o[ 53%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/baloodebug.cpp.o[ 53%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/unindexedfileiterator.cpp.o[ 53%] Built target documentdbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/queryparsertest.dir/queryparsertest_autogen/mocs_compilation.cpp.o[ 53%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/migrator.cpp.oScanning dependencies of target idfilenamedbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/idfilenamedbtest.dir/idfilenamedbtest.cpp.oScanning dependencies of target idtreedbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/idtreedbtest.dir/idtreedbtest.cpp.o[ 53%] Linking CXX executable ../../../bin/documenturldbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/positiondbtest.dir/singledbtest.cpp.o[ 53%] Built target documenturldbtest[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/positiondbtest.dir/positiondbtest_autogen/mocs_compilation.cpp.o[ 53%] Building CXX object autotests/unit/engine/CMakeFiles/idfilenamedbtest.dir/singledbtest.cpp.oScanning dependencies of target mtimedbtest[ 53%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/fileinfo.cpp.o[ 54%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest.cpp.o[ 54%] Linking CXX executable ../../../bin/queryparsertest[ 54%] Building CXX object src/lib/CMakeFiles/KF5Baloo.dir/KF5Baloo_autogen/mocs_compilation.cpp.o[ 55%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/filewatch.cpp.o[ 55%] Built target queryparsertest[ 55%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/pendingfilequeue.cpp.o[ 55%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/metadatamover.cpp.o[ 55%] Building CXX object autotests/unit/engine/CMakeFiles/idtreedbtest.dir/singledbtest.cpp.o[ 56%] Building CXX object autotests/unit/engine/CMakeFiles/idtreedbtest.dir/idtreedbtest_autogen/mocs_compilation.cpp.o[ 57%] Linking CXX executable ../../../bin/positiondbtest[ 57%] Building CXX object autotests/unit/engine/CMakeFiles/idfilenamedbtest.dir/idfilenamedbtest_autogen/mocs_compilation.cpp.o/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/filewatch.cpp: In constructor ���Baloo::FileWatch::FileWatch(Baloo::Database*, Baloo::FileIndexerConfig*, Baloo::MainHub*, QObject*)���:/home/jenkins/workspace/Frameworks/baloo/kf5-qt5 SUSEQt5.9/src/file/filewatch.cpp:39:79: warning: unused parameter ���dbusInterface��� [-Wunused-parameter] FileWatch::FileWatch(Database* db, FileIndexerConfig* config, Baloo::MainHub *dbusInterface, QObject* parent)   ^[ 57%] Built target positiondbtest[ 57%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/pendingfile.cpp.o[ 57%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/singledbtest.cpp.o[ 58%] Linking CXX shared library ../../bin/libKF5Baloo.so[ 58%] Building CXX object autotests/unit/engine/CMakeFiles/mtimedbtest.dir/mtimedbtest_autogen/mocs_compilation.cpp.o[ 59%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/kinotify.cpp.oScanning dependencies of target termgeneratortest[ 59%] Building CXX object autotests/unit/engine/CMakeFiles/termgeneratortest.dir/termgeneratortest.cpp.o[ 59%] Built target KF5Baloo[ 59%] Linking CXX executable ../../../bin/idtreedbtestScanning dependencies of target andpostingiteratortest[ 59%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/andpostingiteratortest.cpp.o[ 59%] Built target idtreedbtest[ 59%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/singledbtest.cpp.o[ 60%] Linking CXX executable ../../../bin/idfilenamedbtest[ 60%] Building CXX object src/file/CMakeFiles/baloofilecommon.dir/baloodebug.cpp.o[ 61%] Building CXX object autotests/unit/engine/CMakeFiles/andpostingiteratortest.dir/andpostingi

D17284: RFC: Add unit test for splitting of numbers in TermGenerator

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:1b8904a2f2d7: RFC: Add unit test for splitting of numbers 
in TermGenerator (authored by bruns).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17284?vs=46631&id=46781#toc

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17284?vs=46631&id=46781

REVISION DETAIL
  https://phabricator.kde.org/D17284

AFFECTED FILES
  autotests/unit/engine/termgeneratortest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17015: Fix the Qt doc creation with Qt 5.12.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D17015#363060 , @kossebau wrote:
  
  > Good to see you caring for ECM documentation not getting broken with Qt 
5.12 :)
  >
  > Any idea how we could perhaps deduplicate the  FindQHelpGenerator.cmake 
with the one from find-modules (which is a helper for runtime with the 
ECMAddQch macro)? No instant idea yet, perhaps also better to have dedicated 
variants for each purppse? Needs me another round of thinking.
  
  
  FindQHelpGenerator.cmake can be deprecated and replaced by a FindXXX.cmake 
(name to define) module that looks for qhelpgenerator or qcollectiongenerator. 
IMO not worth the effort, FindQHelpGenerator.cmake will be removed in KF6

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

[Christophe Giboudeaux]

cgiboudeaux marked an inline comment as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17015: Fix the Qt doc creation with Qt 5.12.

[Christophe Giboudeaux]

cgiboudeaux updated this revision to Diff 46780.
cgiboudeaux added a comment.


  Add the reason for looking for the executable

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17015?vs=45806&id=46780

BRANCH
  arcpatch-D17015

REVISION DETAIL
  https://phabricator.kde.org/D17015

AFFECTED FILES
  cmake/FindQHelpGenerator.cmake
  docs/CMakeLists.txt
  modules/ECMQueryQmake.cmake

To: cgiboudeaux, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17301: add documentation to result class

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> result.h:58
> +/**
> + * Overriden function from KFileMetaData::ExtractionResult.
> + */

Qt uses "Reimplemented from KFileMetaData::ExtractionResult::addtype()`, see 
e.g. http://doc.qt.io/qt-5/qfile.html#fileName

Overriden has a typo, "Overridden"

But I think you should remove the (docstring) comment, it should automatically 
pick up the description from the interface class.

> result.h:90
> +/**
> + * Contains the collection of words of the metadata
> + */

Nitpick - missing full stop, also below.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16643: Correct the accept flag of the event object on DragMove

[Stefan Brüns]

bruns added a comment.


  This should not be accepted as is, it breaks the temporaryInhibition case 
when a DropArea is child of another

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  I don't know what to do next, can you help me @ngraham ?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/78/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 03 Dec 2018 10:39:57 +
 Build duration:
4 min 58 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5CoreAddons_compat_report.html
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8463)43%
(10112/23354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5763/11827)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(121/321)src.lib67%
(2/3)67%
(2/3)60%
(353/591)26%
(243/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2301)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(827/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 133 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/133/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Dec 2018 10:39:57 +
 Build duration:
4 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6345/8463)43%
(10112/23358)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(828/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16643: Correct the accept flag of the event object on DragMove

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Marco Martin]

mart requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, davidedmundson
Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 509 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/509/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Dec 2018 09:27:37 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(31962/60101)37%
(16506/44080)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4283/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8335/14322)50%
(4666/9253)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3910/7971)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

D17310: Improve Kile icon with LaTeX font

[Michel Ludwig]

mludwig added a comment.


  Hey, thanks for working on this.
  
  I don't mind the change in font style.
  
  However, do you think it's possible to add "Kile" somewhere onto the icon as 
well, preferably quite largely. With this icon, I always find it hard to locate 
Kile in the task manager.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: mludwig, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 358 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/358/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 03 Dec 2018 09:27:37 +
 Build duration:
9 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(263/398)66%
(263/398)54%
(3/60118)38%
(16627/44080)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9098/9538)48%
(4288/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8388/14323)51%
(4686/9257)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3910/7971)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(531/1036)37%
(318/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4288)35%
(1305/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(625/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)50%

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Björn Feber]

GB_2 added a comment.


  Ok.
  Email: febe...@gmail.com

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio
Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, 
skadinna, aaronhoneycutt, mbohlender

D17195: Avoid constantly increasing Qt event queue in KIO slaves

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5297704106e8: Avoid constantly increasing Qt event queue 
in KIO slaves (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17195?vs=46332&id=46773

REVISION DETAIL
  https://phabricator.kde.org/D17195

AFFECTED FILES
  src/core/connection.cpp
  src/core/connection_p.h
  src/core/slavebase.cpp

To: davidedmundson, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17260: Port some core Q_PRIVATE_SLOTS to new connect syntax

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:77efdfdaa4f0: Port some core Q_PRIVATE_SLOTS to new 
connect syntax (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17260?vs=46570&id=46774

REVISION DETAIL
  https://phabricator.kde.org/D17260

AFFECTED FILES
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h
  src/core/job.cpp
  src/core/job_base.h

To: davidedmundson, apol
Cc: apol, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

Transitioning CI builds of all non-Frameworks from Qt 5.9

[Ben Cooksley]

Hi all,

I've been informed by the PIM developers that they would like to bump
the dependency of the Qt version they use, from Qt 5.9 which it's on
currently, to Qt 5.10.

As a consequence, due to many KDE projects using PIM libraries, their
dependency on Qt will also be effectively bumped. To minimize the
maintenance cost of this bump for the CI system, I would like to bump
everyone up from Qt 5.9 to a newer version of Qt (otherwise we'll end
up chasing down build failures for a long time)

As most distributions have moved on from 5.10, and use Qt 5.11 now
(and will in many cases soon move to Qt 5.12), i'd like to suggest
that instead of going to Qt 5.10, we move straight to 5.11.

Because Frameworks has a two versions prior support policy, it'll
remain on 5.9 for now until it's ready to move up to 5.10 (assuming
5.12 is a usable Qt version)

If nobody has any objections, i'll proceed with this change in around
3 days time.

Cheers,
Ben

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Ben Cooksley]

bcooksley added a comment.


  Phabricator has a strong privacy model, meaning your email address is not 
accessible to anyone except you, so you'll need to post it here in this review 
so it can be committed to our repositories.
  Sorry for any confusion around this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio
Cc: bcooksley, elvisangelaccio, ngraham, kde-frameworks-devel, alexde, 
IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, 
skadinna, aaronhoneycutt, mbohlender

D17325: Fix leak in kemoticons

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kemoticonstheme.cpp:32
>  ~KEmoticonsThemeData();
>  KEmoticonsProvider *provider = nullptr;
>  };

Make it shared pointer, KEmoticonsTheme::KEmoticonsTheme(const KEmoticonsTheme 
&ket) initialize provider with raw other pointer, deletion will cause a 
segfault in use after.

> kemoticonstheme.cpp:41
>  {
> -// delete provider;
> +delete provider;
>  }

Remove that line.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D17325

To: kfunk
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns