D17816: Initial support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 48384.
cochise added a comment.


  As using qDebug supressed the error, I changed to qCWarning and managed to 
track the memory corruption. On my system, after getting the list of keys on 
source file, the local variable holding this file path gets corrupted. I'm 
using a code almost identical to official example [1], and enlarging the 
buffer, or allocating it on the heap didn't resoled the issue.
  A hackish workaround is to not store the file path after conversion (`const 
char*`), and using `QUrl.path().toLocal8Bit().data();` in all nine calls.
  I'm not happy with this solution, but I think I reached my limit here. 
Commiting this hackish version for review, and going to make some tests.
  
  1 - http://man7.org/linux/man-pages/man2/listxattr.2.html

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=48380=48384

BRANCH
  xattr-copy-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  src/core/config-kiocore.h.cmake
  src/core/copyjob.cpp
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure
Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17817: Build without D-Bus on Android

[Ben Cooksley]

bcooksley added a comment.


  Android CI builds are only enabled for the following repositories:
  
- "frameworks/extra-cmake-modules"
- "frameworks/karchive"
- "frameworks/attica"
- "frameworks/breeze-icons"
- "frameworks/kcodecs"
- "frameworks/kconfig"
- "frameworks/kcoreaddons"
- "frameworks/kguiaddons"
- "frameworks/kconfig"
- "frameworks/ki18n"
- "frameworks/kirigami"
- "frameworks/kwidgetsaddons"
- "frameworks/threadweaver"
- "frameworks/kpackage"
- "frameworks/kunitconversion"
- "frameworks/kimageformats"
- "frameworks/kjobwidgets"
- "frameworks/kcompletion"
- "frameworks/prison"
  
  Many of these were added in a660dffb 
 and 
2e5740a7 
 
back in 2017.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17817

To: vkrause
Cc: bcooksley, apol, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17851: Add Android notification backend

[Aleix Pol Gonzalez]

apol added a comment.


  This looks really cool! I'd say let's get this in and we can iterate from 
here if needed.
  
  Maybe it would be useful to have builds of a test application?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17851

To: vkrause
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D17856: Fix a regression introduced in 6a1852

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

BRANCH
  fixutf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17856

To: vandenoever, dfaure, arichardson, apol, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17855: Don't rely on the Plasma workspace integration on Android

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17855

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17817: Build without D-Bus on Android

[Aleix Pol Gonzalez]

apol added a comment.


  In D17817#383403 , @vkrause wrote:
  
  > In D17817#383354 , @dhaumann 
wrote:
  >
  > > +1, although it will likely break quickly since this branch is not tested 
via CI. Then again, this is also vslid for e.g. the KSyntaxHighlighting 
branches that were added for standalone deployment.
  >
  >
  > At least the binary factory build for KDE Itinerary should be testing this 
configuration. And AFAIK there are also some KF5 Android builds on the CI.
  
  
  There should be CI, but I don't see knotifications:
  https://build.kde.org/search/?q=android
  
  CD will definitely be building it.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17817

To: vkrause
Cc: apol, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Initial support for xattrs on kio copy/move

[Cochise César]

cochise updated this revision to Diff 48380.
cochise added a comment.


  Refactored to a function, works on all use cases. Data corruption remains
  
  Summary: Found the place to put the call for files and directories on
  copyjob.cpp.
  Reverted almost all changes in file_unix, except a fix for *BSD headers.
  Cureently, manual tests works on copy, move, and copy/move with renames.
  I think the results and design are aceptavle so far.
  
  If the qDebug calls are disabled, xattr_src (path from source file) gets
  corrupted on my system. I suspect there is someting nasty happening when
  glibc writes on the buffers (val and key). Will do some debugging now,
  and then write some unit tests.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17816?vs=48255=48380

BRANCH
  xattr-copy-support (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17816

AFFECTED FILES
  src/core/config-kiocore.h.cmake
  src/core/copyjob.cpp
  src/ioslaves/file/file_unix.cpp

To: cochise, dfaure
Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner added a comment.


  See: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230603

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17863

To: tcberner, #freebsd, dfaure, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17863: Add ecm_check_linker_flags function

[Tobias C. Berner]

tcberner created this revision.
tcberner added reviewers: FreeBSD, dfaure, apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
tcberner requested review of this revision.

REVISION SUMMARY
kstars appends '-Wl,-z,nodump' to the linker flags, which is not supported 
by lld>=7 (previous versions just discareded unkonwn flags).

Add an ecm module to check whether a linker flag is supported.

Usage:
``` 
  include(ECMCheckLinkerFlags)
  [...]
  # Check for nodump support
  SET(NODUMP_FLAGS "-Wl,-z,nodump")
  ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
  if (NODUMP_SUPPORTED)
  SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
  endif ()
 ```

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17863

AFFECTED FILES
  modules/ECMCheckLinkerFlags.cmake

To: tcberner, #freebsd, dfaure, apol
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17730: [WIP] Review KateStatusBar

[Christoph Cullmann]

cullmann added a comment.


  Ok, thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17730: [WIP] Review KateStatusBar

[loh tar]

loh.tar updated this revision to Diff 48374.
loh.tar set the repository for this revision to R39 KTextEditor.
loh.tar added a comment.


  - Fix remaining signal/slot, Thanks for the hint! :-)
  
  > Beside that, I tried the patch, the status bar looks nice ;=)
  
  :-)
  
  > I would have no issues to merge this as is (perhaps after you .. have 
additional stuff like "configurable: show XXX" in an extra patch.
  
  Not sure how quickly I look at these config stuff, but I will. And I will 
remove the WIP tag when I think I'm done here. Maybe I find something more to 
tweak

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48334=48374

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17851: Add Android notification backend

[Nicolas Fella]

nicolasfella added a comment.


  By using AndroidX (formerly known as the support library) we could enable it 
for Android version older than 23 (which is about 29% of all active devices). 
That would require adding the appropriate jar to the build.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D17851

To: vkrause
Cc: nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

[Nathaniel Graham]

ngraham added a comment.


  Found one more issue: By creating a new version of `preferences-system` that 
looks different from the existing version, System Settings gets the wrong icon:
  
  F6515130: Screenshot_20181229_124318.png 

  
  F6515133: Screenshot_20181229_124509.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: rooty, sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katepart5ui.rc:2
>  
>  
>  

Increase version

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, 
kde-frameworks-devel, hase, michaelh, bruns, demsking, sars

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[Christoph Cullmann]

cullmann added a comment.


  For me, too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, bruns, demsking, sars

D17459: SearchBar: Add Cancel button to stop long running tasks

[Christoph Cullmann]

cullmann added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in katesearchbar.h:221-227
> You cannot add new members as well, they change object size. Since this class 
> not use pimpl idiom it will be harder to change anything in header except to 
> add new non-virtual functions.

This is a purely internal class.
It is only exported for the unit tests, no header files are installed, 
therefore any change of the layout is ok ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17459

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel, 
kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, 
sars, dhaumann

D17730: [WIP] Review KateStatusBar

[Christoph Cullmann]

cullmann added a comment.


  Beside that, I tried the patch, the status bar looks nice ;=)
  
  Your idea to replace the labels with buttons is a good one.
  
  I would have no issues to merge this as is (perhaps after you cleanup the 2 
connects and have additional stuff like "configurable: show XXX" in an extra 
patch.

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17730: [WIP] Review KateStatusBar

[Christoph Cullmann]

cullmann added a comment.


  connect(m_view->doc(), ::DocumentPrivate::modifiedOnDisk, this, 
::modifiedChanged);
  connect(m_view->doc(), ::DocumentPrivate::configChanged, this, 
::documentConfigChanged);
  
  should do the trick, as doc() has the right internal type

REVISION DETAIL
  https://phabricator.kde.org/D17730

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/17/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sat, 29 Dec 2018 19:13:33 +
 Build duration:
6 min 3 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32969/48251)51%
(15857/31000)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1213/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/735)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1563/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c287d3858fd7: ViewConfig: Add Dynamic Wrap At Static 
Marker option (authored by loh.tar, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17661?vs=47787=48368

REVISION DETAIL
  https://phabricator.kde.org/D17661

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I played with it, it seems to work reasonable well.
  Lets give this patch a try ;=)
  Its optional, if people get issues, we can try to fix them later. (I have 
seen no ones myself)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17661

To: loh.tar, #ktexteditor, #vdg, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at aned of file

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...when 'Allow scrolling past the end of the document' is set
  
  BUG: 399014

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17857

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17015: Fix the Qt doc creation with Qt 5.12.

[Thiago Macieira]

thiago added a comment.


  qhelpgenerator is coming back in 5.12.1. You may simply tell people to skip 
the .0 release and upgrade.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D17015

To: cgiboudeaux, kossebau
Cc: thiago, tcberner, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/14/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sat, 29 Dec 2018 18:23:43 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/101/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 29 Dec 2018 18:23:43 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

D17692: Add a proper python-bytecode icon, use consistent color in python icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:6baded2e1df4: Add a proper python-bytecode icon, use 
consistent color in python icons (authored by trickyricky26, committed by 
ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17692?vs=48361=48365

REVISION DETAIL
  https://phabricator.kde.org/D17692

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-python-bytecode.svg
  icons-dark/mimetypes/16/text-x-python.svg
  icons-dark/mimetypes/22/application-x-python-bytecode.svg
  icons-dark/mimetypes/22/text-x-python.svg
  icons-dark/mimetypes/32/application-x-python-bytecode.svg
  icons-dark/mimetypes/32/text-x-python.svg
  icons-dark/mimetypes/64/application-x-python-bytecode.svg
  icons-dark/mimetypes/64/text-x-python.svg
  icons/mimetypes/16/application-x-python-bytecode.svg
  icons/mimetypes/16/text-x-python.svg
  icons/mimetypes/22/application-x-python-bytecode.svg
  icons/mimetypes/22/text-x-python.svg
  icons/mimetypes/32/application-x-python-bytecode.svg
  icons/mimetypes/32/text-x-python.svg
  icons/mimetypes/64/application-x-python-bytecode.svg
  icons/mimetypes/64/text-x-python.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17692: Add a proper python-bytecode icon, use consistent color in python icons

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks perfect!

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17692

REVISION DETAIL
  https://phabricator.kde.org/D17692

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17856: Fix a regression introduced in 6a1852

[Jos van den Oever]

vandenoever added reviewers: dfaure, arichardson, apol, aacid, ngraham.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17856

To: vandenoever, dfaure, arichardson, apol, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever added a comment.


  Sure. It's here https://phabricator.kde.org/D17856

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns

D17856: Fix a regression introduced in 6a1852

[Jos van den Oever]

vandenoever created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vandenoever requested review of this revision.

REVISION SUMMARY
  Bytes from 'Strings' of type GroupString and KeyString should not be
  escaped because they are valid UTF-8. Only instances of ValueString
  should be escaped.
  
  This fixes the failing test KConfigTest::testEncoding

TEST PLAN
  Ran `ninja test` and found no errors.

REPOSITORY
  R237 KConfig

BRANCH
  fixutf8 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17856

AFFECTED FILES
  src/core/kconfigini.cpp

To: vandenoever
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

[Nathaniel Graham]

ngraham added a comment.


  Can you submit that patch using Phabricator?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever added a comment.


  Here is a patch that solves the problem:
  
diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp
index 39e5936..b674973 100644
--- a/src/core/kconfigini.cpp
+++ b/src/core/kconfigini.cpp
@@ -673,7 +673,12 @@ QByteArray KConfigIniBackend::stringToPrintable(const 
QByteArray , Strin
 switch (s[i]) {
 default:
 // The \n, \t, \r cases (all < 32) are handled below; we can 
ignore them here
-if (((unsigned char)s[i]) < 32 || ((unsigned char)s[i]) >= 
127) {
+if (((unsigned char)s[i]) < 32) {
+goto doEscape;
+}
+// GroupString and KeyString should be valid UTF-8, but 
ValueString
+// can be a bytearray with non-UTF-8 bytes that should be 
escaped.
+if (type == ValueString && ((unsigned char)s[i]) >= 127) {
 goto doEscape;
 }
 *data++ = s[i];

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17692: Add a proper python-bytecode icon, use consistent color in python icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 48361.
trickyricky26 added a comment.


  Rebase on master to work around Pahbricator bug with symlinks.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17692?vs=48358=48361

BRANCH
  arcpatch-D17692

REVISION DETAIL
  https://phabricator.kde.org/D17692

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-python-bytecode.svg
  icons-dark/mimetypes/16/text-x-python.svg
  icons-dark/mimetypes/22/application-x-python-bytecode.svg
  icons-dark/mimetypes/22/text-x-python.svg
  icons-dark/mimetypes/32/application-x-python-bytecode.svg
  icons-dark/mimetypes/32/text-x-python.svg
  icons-dark/mimetypes/64/application-x-python-bytecode.svg
  icons-dark/mimetypes/64/text-x-python.svg
  icons/mimetypes/16/application-x-python-bytecode.svg
  icons/mimetypes/16/text-x-python.svg
  icons/mimetypes/22/application-x-python-bytecode.svg
  icons/mimetypes/22/text-x-python.svg
  icons/mimetypes/32/application-x-python-bytecode.svg
  icons/mimetypes/32/text-x-python.svg
  icons/mimetypes/64/application-x-python-bytecode.svg
  icons/mimetypes/64/text-x-python.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/16/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sat, 29 Dec 2018 16:36:27 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32955/48231)51%
(15850/30984)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1213/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1564/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(628/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
 

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.11/13/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sat, 29 Dec 2018 16:41:47 +
 Build duration:
4 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 100 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/100/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 29 Dec 2018 16:41:47 +
 Build duration:
2 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/15/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sat, 29 Dec 2018 16:29:07 +
 Build duration:
6 min 1 sec and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32956/48231)51%
(15850/30982)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1564/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%

D17651: Escape bytes that are larger than or equal to 127 in config files

[Jos van den Oever]

vandenoever added a comment.


  Found it. This is the failing test.
  
FAIL!  : KConfigTest::testEncoding() Compared values are not the same
   Actual   (lines.first()): "[UTF-8:\\xc3\\xb6l]\n"
   Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"
   Loc: [/home/jenkins/workspace/Frameworks/kconfig/kf5-qt5 
SUSEQt5.11/autotests/kconfigtest.cpp(463)]
  
  The test writes a config file with this group header:
  
  [UTF-8:öl]
  
  The above patch breaks that. Instead it outpus the escaped bytes:
  
  [UTF-8:\xc3\xb6]
  
  I'm working on a fix now.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D17651

To: vandenoever, dfaure, arichardson, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17692: Add a proper python-bytecode icon, use consistent color in python icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17692

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17692: Add a proper python-bytecode icon, use consistent color in python icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 48358.
trickyricky26 added a comment.


  Use custom shapes for the "0" and "1" in all sizes except `64px`, use a 
consistent 45° angled line in the "0".

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17692?vs=47856=48358

BRANCH
  arcpatch-D17692

REVISION DETAIL
  https://phabricator.kde.org/D17692

AFFECTED FILES
  icons-dark/mimetypes/16/application-x-python-bytecode.svg
  icons-dark/mimetypes/16/text-x-python.svg
  icons-dark/mimetypes/22/application-x-python-bytecode.svg
  icons-dark/mimetypes/22/text-x-python.svg
  icons-dark/mimetypes/32/application-x-python-bytecode.svg
  icons-dark/mimetypes/32/text-x-python.svg
  icons-dark/mimetypes/64/application-x-python-bytecode.svg
  icons-dark/mimetypes/64/text-x-python.svg
  icons/mimetypes/16/application-x-python-bytecode.svg
  icons/mimetypes/16/text-x-python.svg
  icons/mimetypes/22/application-x-python-bytecode.svg
  icons/mimetypes/22/text-x-python.svg
  icons/mimetypes/32/application-x-python-bytecode.svg
  icons/mimetypes/32/text-x-python.svg
  icons/mimetypes/64/application-x-python-bytecode.svg
  icons/mimetypes/64/text-x-python.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/14/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Sat, 29 Dec 2018 15:38:12 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(254/289)88%
(254/289)68%
(32956/48233)51%
(15851/30982)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(37/37)100%
(37/37)94%
(4431/4730)49%
(1696/3450)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5483/5523)58%
(996/1712)src.buffer88%
(15/17)88%
(15/17)90%
(1697/1881)76%
(1214/1596)src.completion100%
(11/11)100%
(11/11)57%
(1772/3109)43%
(1160/2717)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/732)0%
(0/176)src.document100%
(4/4)100%
(4/4)59%
(1869/3151)47%
(1564/3305)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(221/244)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(953/1244)67%
(627/942)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(6/6)100%
 

D17630: Don't re-mark words added/ignored to the dictionary as misspelled

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:332935735994: Dont re-mark words added/ignored to 
the dictionary as misspelled (authored by ahmadsamir, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17630?vs=47684=48357

REVISION DETAIL
  https://phabricator.kde.org/D17630

AFFECTED FILES
  src/spellcheck/ontheflycheck.cpp
  src/spellcheck/ontheflycheck.h
  src/spellcheck/spellcheck.cpp
  src/spellcheck/spellcheck.h

To: ahmadsamir, cullmann, davidedmundson
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17855: Don't rely on the Plasma workspace integration on Android

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Instead, add a config file for the default notification types here.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17855

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/android_defaults.notifyrc
  src/knotification.cpp
  src/knotifications.qrc

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:511a9ba9edc3: Add method to BackgroundChecker to add word 
to session (authored by ahmadsamir, committed by cullmann).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17629?vs=48336=48354

REVISION DETAIL
  https://phabricator.kde.org/D17629

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17854: Search for notfication event configuration in qrc resources

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Simplifies deployment, and is particularly needed on
  Android, which has no concept of shared data or configuration
  files.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17854

AFFECTED FILES
  src/knotifyconfig.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17623: Add YaST and new preference icons

[Root]

rooty added a comment.


  +1 for the icons, really nice icons

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17623

To: ndavis, #vdg, cfeck, broulik, elvisangelaccio, ngraham
Cc: rooty, sitter, fvogt, hellcp, ngraham, kde-frameworks-devel, michaelh, bruns

D17828: Don't check twice if the icon exists from ::availableSizes

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:bc916a6be818: Dont check twice if the icon exists 
from ::availableSizes (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17828?vs=48273=48346#toc

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17828?vs=48273=48346

REVISION DETAIL
  https://phabricator.kde.org/D17828

AFFECTED FILES
  src/kiconengine.cpp

To: apol, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  BUG: 402594

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17852

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D17629: Add method to BackgroundChecker to add word to session

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R246 Sonnet

BRANCH
  addWordToSession (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17629

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17816: Initial support for xattrs on kio copy/move

[Cochise César]

cochise added a comment.


  In D17816#383421 , @davidedmundson 
wrote:
  
  > Why do we need the code in both CopyJob and File_unix?
  
  
  The code was initially put in file_unix, but testing I found it won't applies 
to directories, so I put on CopyJob, and found that it not applies to dirs 
renamed because of name conflicts.
  I plan to find the call points to tackle all the use cases and then refactor 
into a function, to avoid code duplication.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17851: Add Android notification backend

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  There are probably still many features that aren't properly mapped to
  Android, but at least the basics work:
  
  - text, title and icon
  - actions
  - dismissing the notification is propagated
  - taping the notification opens the corresponding app
  
  This is also the first time we have Java code for Android in a KF5
  framework, I tried to follow what Qt does for this.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17851

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/KF5Notifications-android-dependencies.xml
  src/knotificationmanager.cpp
  src/notifybyandroid.cpp
  src/notifybyandroid.h
  src/org/kde/knotifications/KNotification.java
  src/org/kde/knotifications/NotifyByAndroid.java

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17629: Add method to BackgroundChecker to add word to session

[Ahmad Samir]

ahmadsamir updated this revision to Diff 48336.
ahmadsamir added a comment.


  Add doxygen doc for the new method including @since

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17629?vs=48218=48336

BRANCH
  addWordToSession (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17629

AFFECTED FILES
  src/core/backgroundchecker.cpp
  src/core/backgroundchecker.h

To: ahmadsamir, davidedmundson, cullmann, sandsmark
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17730: [WIP] Review KateStatusBar

[loh tar]

loh.tar updated this revision to Diff 48334.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - Change to new signal/slot style (Idea how to fix the two missing ones?)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17730?vs=48285=48334

REVISION DETAIL
  https://phabricator.kde.org/D17730

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor
Cc: zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D17816: Initial support for xattrs on kio copy/move

[David Edmundson]

davidedmundson added a comment.


  Why do we need the code in both CopyJob and File_unix?

INLINE COMMENTS

> file_unix.cpp:425
> +#elif defined(Q_OS_MAC)
> +ssize_t vallen = listxattr(_src.data(), key, NULL, 0, 0, 0);
> +#elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD)

you need to check vallen for error returns.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns

D17816: Initial support for xattrs on kio copy/move

[David Edmundson]

davidedmundson added a comment.


  Relevant autotests need adding

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure
Cc: davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, 
kde-frameworks-devel, michaelh, bruns