D18148: Use HTTPS, if available, in links visible to users

[Grzegorz Szymaszek]

gszymaszek retitled this revision from "Use HTTPS, if available, in links 
visible by users" to "Use HTTPS, if available, in links visible to users".
gszymaszek added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18148: Use HTTPS, if available, in links visible by users

[Grzegorz Szymaszek]

gszymaszek created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
gszymaszek requested review of this revision.

REPOSITORY
  R39 KTextEditor

BRANCH
  https-in-end-user-links (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18148

AFFECTED FILES
  src/document/katedocument.cpp
  src/utils/kateglobal.cpp

To: gszymaszek
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 49133.
jgrulich added a comment.


  Drop keyboard support from this review

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49087=49133

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich retitled this revision from "FakeInput: add support for pointer move 
with absolute coordinates and keyboard key press and release" to "FakeInput: 
add support for pointer move with absolute coordinates".
jgrulich edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18137: delete copy constructor and assignment operator of some public classes

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  The KSharedDataCache change is definitely correct. I've not done much with 
the kdelibs migrator but I agree with the logic and the implementation. Have 
you tried building some of the other frameworks or Plasma after implementing 
this patch? That's the only real risk I can think of.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18137

To: aacid, mpyne
Cc: mpyne, kde-frameworks-devel, michaelh, ngraham, bruns

Bugzilla Server Move

[Ben Cooksley]

Hi all,

We've just completed the migration of Bugzilla from a previous system
to a newer system. While this hasn't changed Bugzilla itself much, it
did involve an update from Ubuntu 14.04 to Ubuntu 18.04.

>From our testing everything appears to be operating correctly.

Should anyone see anything unusual or broken, please let Sysadmin know.

Thanks,
Ben

D10621: Highlighting Indexer: list of suggestions

[jonathan poelen]

jpoelen added a comment.


  I agree that some rules are excessive or even false, but the last time I 
watched (it was several months ago now), some regexes suggested to be 
DetectString seemed to have writing errors (mainly `\\` count as 2 characters 
in xml) and some more or less useful propositions. If there has been no change 
at this level, it should still be checked.
  
  Actually, I came to the conclusion that the parser himself could make some 
changes on the fly. For example, DetectChar/Detect2Chars are specializations of 
DetectString and the concatenation of regexes could be automatic, which would 
make most checks obsolete. There would be only suggestions to turn a Regex into 
something else, but it is much easier using an AST rather than a very slobbery 
regexes.
  
  Finally, this commit will never make a complete list without false positives, 
especially since code reviews filter out such errors. We can abandon it.
  
  PS: this commit uses `attrToBool` as for the parser (if it has not changed) 
and adds 2 missing `return false`. I do not have time to take care of it at the 
moment.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D10621

To: jpoelen, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, vkrause, 
#framework_syntax_highlighting, dhaumann, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, sars

D18138: KRatingPainter: Delete copy constructor and assignment operator

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:1449db57aa67: KRatingPainter: Delete copy constructor and 
assignment operator (authored by aacid).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18138?vs=49112=49127

REVISION DETAIL
  https://phabricator.kde.org/D18138

AFFECTED FILES
  src/kratingpainter.h

To: aacid, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

[Aleix Pol Gonzalez]

apol added a comment.


  In D18134#390150 , @vkrause wrote:
  
  > As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore 
agree with Albert's reasoning for this change (and same for D18135 
).
  
  
  that's what I thought when I saw the other patch.

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D18134

To: aacid
Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Dominik Haumann]

dhaumann added a comment.


  I don't think you'd have to import .desktop files. But you would need some 
lookup table of course to map the names.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, 
michaelh, ngraham, bruns

D18138: KRatingPainter: Delete copy constructor and assignment operator

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Right.
  
  If someone would copy the object using the default implementations, they 
would only get two instances pointing to the same Private.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18138

To: aacid, cfeck
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 09 Jan 2019 21:38:32 +
 Build duration:
1 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D18138: KRatingPainter: Delete copy constructor and assignment operator

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If someone was using them, it'd crash since it was raw-copying the d pointer
  so you would end up with a double delete.
  
  This is SIC, but IMHO it's fine, whoever gets a compiler failure has a bug to 
fix

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18138

AFFECTED FILES
  src/kratingpainter.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/4/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 09 Jan 2019 21:00:47 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.11/11/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 09 Jan 2019 21:00:46 +
 Build duration:
4 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8464)43%
(10132/23396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(966/2287)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(740/916)52%
(854/1637)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D18137: delete copy constructor and assignment operator of some public classes

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If someone was using them, it'd crash since it was raw-copying the d pointer
  so you would end up with a double delete.
  
  This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to 
fix

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18137

AFFECTED FILES
  src/lib/caching/kshareddatacache.h
  src/lib/util/kdelibs4configmigrator.h
  src/lib/util/kdelibs4migration.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/6/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 09 Jan 2019 21:00:47 +
 Build duration:
2 min 36 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D18134: KEncodingProber: Delete copy constructor and assignment operator

[Volker Krause]

vkrause added a comment.


  As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree 
with Albert's reasoning for this change (and same for D18135 
).

REPOSITORY
  R270 KCodecs

REVISION DETAIL
  https://phabricator.kde.org/D18134

To: aacid
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18136: kconfig_compiler: delete the assignment operator and copy constructor

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  of the generated class that has a pointer and raw copy would be bad.
  
  Those generated classes are internal and nobody would probably have this, but 
being safe never hurts

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18136

AFFECTED FILES
  src/kconfig_compiler/kconfig_compiler.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.12/5/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 09 Jan 2019 20:45:56 +
 Build duration:
7 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kconfigcore_kconfigtestFailed: projectroot.autotests.kconfigcore_test_kconf_updateName: projectroot.autotests Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s)

D10446: Add KLanguageName

[Volker Krause]

vkrause added a comment.


  In D10446#390025 , @aacid wrote:
  
  > In D10446#389972 , @dhaumann 
wrote:
  >
  > > Btw, wouldn't this be a good candidate to upstream to Qt itself?
  >
  >
  > You'd have to import all our .desktop files containing all the translations 
of all languages to all langauges. Impossible copyright wise
  
  
  Getting slightly off-topic here, but CLDR has those translations too, in case 
someone really would want to add this feature to Qt. That's where most other 
data inside QLocale is coming from too.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: vkrause, dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, 
michaelh, ngraham, bruns

D18135: KEmailSettings: Delete copy constructor and assignment operator

[Albert Astals Cid]

aacid updated this revision to Diff 49107.
aacid added a comment.


  typo

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18135?vs=49106=49107

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18135

AFFECTED FILES
  src/core/kemailsettings.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18135: KEmailSettings: Delete copy constructor and assignment operator

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If someone was using them, it'd crash since it was raw-copying the d pointer
  so you would end up with a double delete.
  
  This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to 
fix

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18135

AFFECTED FILES
  CMakeLists.txt
  src/core/kemailsettings.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If someone was using them, it'd crash since it was raw-copying the d pointer
  so you would end up with a double delete.
  
  This is BIC, but IMHO it's fine, whoever gets a compiler failure has a bug to 
fix

REPOSITORY
  R270 KCodecs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18134

AFFECTED FILES
  src/kencodingprober.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

[loh tar]

loh.tar updated this revision to Diff 49099.
loh.tar added a comment.


  - Add missing signals to watch dict changes
  - Ensure button is set on first show
  
  Looks fixed, give it a try.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18125?vs=49078=49099

REVISION DETAIL
  https://phabricator.kde.org/D18125

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 3 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/3/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 09 Jan 2019 18:52:16 +
 Build duration:
6 min 44 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.11 - Build # 7 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.11/7/
 Project:
kf5-qt5 SUSEQt5.11
 Date of build:
Wed, 09 Jan 2019 18:52:16 +
 Build duration:
6 min 26 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Package_compat_report.htmllogs/KF5Package/5.54.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1609/2210)51%
(1128/)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/526)30%
(177/594)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/4/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 09 Jan 2019 18:52:16 +
 Build duration:
45 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.testfallbackpackage_appstreamFailed: projectroot.autotests.testpackage_appstreamFailed: projectroot.autotests.testpackage_nodisplay_appstream

D18081: Make translations work

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D18081

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Albert Astals Cid]

aacid added a comment.


  In D10446#389972 , @dhaumann wrote:
  
  > Btw, wouldn't this be a good candidate to upstream to Qt itself?
  
  
  You'd have to import all our .desktop files containing all the translations 
of all languages to all langauges. Impossible copyright wise

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, michaelh, 
ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49091.
jriddell added a comment.


  - add a stub sudo for testing

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=27859=49091

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17617: Display error instead of silently failing when asked to create folder that already exists

[Shubham]

shubham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17617

To: ngraham, #dolphin, elvisangelaccio, dfaure
Cc: anthonyfieroni, dfaure, emateli, elvisangelaccio, Codezela, 
kde-frameworks-devel, michaelh, ngraham, bruns

D17691: Add rows info to the plasma virtual desktop protocol

[Eike Hein]

hein added a comment.


  As per this , progress on this is 
currently blocking wrapping up Wayland virtual desktops support for 5.15.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D17691

To: mart, #plasma, #kwin
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Martin Flöser]

graesslin added a comment.


  I'm the author of this interface and I consider it nowadays as a mistake to 
have added it. If I would restart I would do the whole thing differently: input 
events need to be injected through a kernel module in a dedicated input device. 
It would need a user space component which processes can talk to and that would 
need to be secured though e.g. polkit. Thus we could properly authenticate. 
This protocol does not support it and KWin does not even try to authenticate. 
Overall from security perspective this is a mess.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Martin Flöser]

graesslin added a comment.


  I don't want to have key press/release in it. It has a reason that I didn't 
add key press/release from the start. The problem is the mismatch of key events 
and keysyms. Especially the kdeconnect use case for which this interface was 
developed has this problem. Android composes text, not key codes. Thus it would 
not be possible to inject key events.
  
  Also from a security perspective I'm strictly against adding fake key events. 
That's one of the largest security problems on X11. I rather have no remote 
support than a gaping security hole.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18125: KateStatusBar: Add dictionary button

[loh tar]

loh.tar added a comment.


  > Isn't en_US too cryptic?
  
  Well, yes.
  
  > I suggest to use the just added KLanguageName (see D10446 
). With this, you can get a nice name like 
"English (USA)". Alternatively, you may use 
QLocale("en_US").nativeLanguageName(), but I did not test this, so it may be 
incorrect code.
  
  I have not chose that name to keep it short as possible. I think your suggest 
is used by Sonnet and you see it in the menu. 
  For me is that sufficient. All you need in the bar is a hint that the dict is 
somehow set/changed, or not. For details, click the button.
  How about to cut it even more, just "en" or "US"? Ideas to the flag 
suggestion?
  
  > - What if you have multiple views of the same document, does it still show 
the correct language, even if the language is changed in one view?
  > - What if you have multiple mainwindows (View > New Window), since then you 
have multiple StatusBars. Will that still all correctly work?
  
  Quick tested, behave a little strange. 
  Shows sometimes a dummy text, e.g. after a fresh "New Window", or when you 
have two views and you change in one view the document the first time to the 
new created test file.
  
  Als long as only one dict is in use is no update done. Move you to some text 
with a different dict the button is updated. Changing the dict (on the first 
Window) updates the button too.
  
  Ideas? Which signals are to catch?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D10446: Add KLanguageName

[Dominik Haumann]

dhaumann added a comment.


  Btw, wouldn't this be a good candidate to upstream to Qt itself?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: dhaumann, hein, kde-frameworks-devel, sitter, markg, apol, michaelh, 
ngraham, bruns

D18125: KateStatusBar: Add dictionary button

[Dominik Haumann]

dhaumann added a comment.


  Isn't en_US too cryptic? I suggest to use the just added KLanguageName (see 
D10446 ). With this, you can get a nice 
name like "English (USA)". Alternatively, you may use 
QLocale("en_US").nativeLanguageName(), but I did not test this, so it may be 
incorrect code.
  
  Besides that, some other questions:
  
  - What if you have multiple views of the same document, does it still show 
the correct language, even if the language is changed in one view?
  - What if you have multiple mainwindows (View > New Window), since then you 
have multiple StatusBars. Will that still all correctly work?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich updated this revision to Diff 49087.
jgrulich added a comment.


  Fix documentation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49082=49087

BRANCH
  fake-input-keyboard-key

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich added a comment.


  I didn't intent to push this together, but when creating a branch from master 
which already had first round of changes caused my second part of changes to be 
pushed here. I hope you don't mind that. I'm doing this in a hurry hoping to 
get exception from David Faure to include this with KDE Frameworks 5.54. I 
thought the tagging is this saturday and tarballs are made after that, but I 
was wrong. I would really like to push the remote desktop support into Plasma 
5.15, I have almost complete support in xdg-desktop-portal-kde and krfb.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates and keyboard key press and release

[Jan Grulich]

jgrulich retitled this revision from "FakeInput: add support for pointer move 
with absolute coordinates" to "FakeInput: add support for pointer move with 
absolute coordinates and keyboard key press and release".
jgrulich edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49082.
jgrulich added a comment.


  Add support for keyboard key press and release

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49081=49082

BRANCH
  fake-input-keyboard-key

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Marco Martin]

mart accepted this revision.
mart added a comment.


  bah, seems very tricky to make it work properly across distributions.
  
  to me, it speaks mostly as a failure for us to control the look of our 
product, due to broken fonts in distros and qt font rendering still buggy, 
issue that unfortunately the vertical platforms like Windows don't have.
  the intention was to have heading with the same stroke width as the rest of 
the text, or slightly more still (which works on noto at least for level 1, 
apparently not on other styles)
  
  so i'm ok to remove the light font here, but clearly as a failure to make it 
work properly due to the state of the lower stack
  
  to me, it *is* still a clear visual regression, but is ok to go as "the least 
broken" option for now to not touch weigth.
  with a clear intent to monitor the situation.
  
  I wonder if it shouldn't be something in the future eventually part of the 
theme, I see things like menu font and toolbar font in fonts kcm as something 
completely obsolete, while those settings should be more about conventional 
typography (like normal font, heading font etc)

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks, mart
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D18125: KateStatusBar: Add dictionary button

[loh tar]

loh.tar added a comment.


  The shown dictionary is sometimes "wrong"
  
  - Mark a word by double-click and choose a dictionary different from the 
default for that word
  - Click/move into the word -> The shown dictionary fit
  - Double-Click that word again -> The shown dictionary is the default one
  
  Due to the way how the dictionary is reported is it correct. It's always 
right from the cursor position and when the word will selected is the cursor at 
the end of the word. (To talk about it, helps! Add a check for selection and 
ask right from cursor in cursorPositionChanged() may fix that)
  
  The language/dictionary code is sometimes a little long, e.g. 
"en_US-wo_accents".
  
  - How about to cut all and only keep "en_US"? But I have no idea how such 
codes may look. Always like "xx_YY" or may that differ?
  - How about to show a flag/ensign instead of the code? Is there some stuff in 
KDE which may helpful?
  - Sure, then we have a less precise info there, but will someone use 
different variants of the same language at a time?
  
  Currently is a "special" dictionary not added to the menu. Mainly because it 
fit not into the "Preferred" section (and secondarily the needed member 
variable does right now not exist). To have more than one group need some 
effort to handle. To rename the group may a way, but how?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18125

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D18125: KateStatusBar: Add dictionary button

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ...to indicate the current dictionary and for the handy access to the
  spell check menu, which is enhanced to offer the user preferred
  dictionaries

TEST PLAN
  From shot to shot is only the cursor moved. The dictionaries was set 
previously.
  F6537575: pic.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18125

AFFECTED FILES
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kconfigwidgets » kf5-qt5 WindowsMSVCQt5.11 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kconfigwidgets/job/kf5-qt5%20WindowsMSVCQt5.11/24/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 09 Jan 2019 15:16:18 +
 Build duration:
3 min 40 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.klanguagenametest

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49081.
jgrulich added a comment.


  Bump fake interface version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49071=49081

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:91077def022a: Add KLanguageName (authored by aacid, 
committed by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10446?vs=48854=49079#toc

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10446?vs=48854=49079

REVISION DETAIL
  https://phabricator.kde.org/D10446

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kf5_entry_data.cmake/locale/ca/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/de/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/en_US/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/es/.keep
  autotests/kf5_entry_data.cmake/locale/fr/kf5_entry.cmake
  autotests/kf5_entry_data.cmake/locale/pt/kf5_entry.cmake
  autotests/klanguagenametest.cpp
  src/CMakeLists.txt
  src/klanguagename.cpp
  src/klanguagename.h

To: aacid, apol
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D10446: Add KLanguageName

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> aacid wrote in klanguagenametest.cpp:80
> Do you think it makes sense adding this?
> 
>   void testNoString()
>   {
>   // Qt doesn't have za support so no string at all
>   QCOMPARE(KLanguageName::nameForCode("za"), QString());
>   }

 I'll add it

> aacid wrote in klanguagename.h:34
> Needs to be 5.55 i think

Going to update

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D10446

REVISION DETAIL
  https://phabricator.kde.org/D10446

To: aacid, apol
Cc: hein, kde-frameworks-devel, sitter, markg, apol, michaelh, ngraham, bruns

D18046: [kitemviews] Change the search in Desktop Behavior/Activities to more in line with other search labels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Much better, thanks!

REPOSITORY
  R276 KItemViews

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18046

To: rooty, #vdg, #plasma, kde-frameworks-devel, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49071.
jgrulich added a comment.


  Coding style

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49070=49071

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added inline comments.

INLINE COMMENTS

> fakeinput.cpp:106
> +Q_ASSERT(d->manager.isValid());
> +if (wl_proxy_get_version(d->manager) < 
> ORG_KDE_KWIN_FAKE_INPUT_POINTER_MOTION_ABSOLUTE_SINCE_VERSION)
> +return;

Use curly braces even when the body of a conditional statement contains only 
one line.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49070.
jgrulich added a comment.


  Fix review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49069=49070

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fake-input.xml:86
>
> +  
> +  

since="3"

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49069.
jgrulich added a comment.


  Adress review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49066=49069

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> fakeinput.cpp:106
> +Q_ASSERT(d->manager.isValid());
> +org_kde_kwin_fake_input_pointer_motion_absolute(d->manager, 
> wl_fixed_from_double(pos.x()), wl_fixed_from_double(pos.y()));
> +}

if (wl_proxy_get_version(d->manager) < 
ORG_KDE_SOMETHING_SOMETHING_FAKE_INPUT_VERSION) {
 return;
}

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added a comment.


  Please wait for @davidedmundson and @graesslin. :-)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin, zzag
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49066.
jgrulich added a comment.


  Add information when new methods were introduced and bump version of 
FakeInput in registry

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49064=49066

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/client/registry.cpp
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> fakeinput_interface.cpp:164
> +
> +
>  void FakeInputInterface::Private::axisCallback(wl_client *client, 
> wl_resource *resource, uint32_t axis, wl_fixed_t value)

Please delete one extra empty line.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Vlad Zagorodniy]

zzag added a comment.


  maxVersion in src/client/registry.cpp should be updated as well.

INLINE COMMENTS

> fakeinput.h:138
> + * Request an absolute pointer motion to @p pos position.
> + **/
> +void requestPointerMoveAbsolute(const QPointF );

Missing `@since`.

> fakeinput_interface.h:118
> + * Request an absolute pointer motion to @p pos.
> + **/
> +void pointerMotionAbsoluteRequested(const QPointF );

Missing `@since`.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18114

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Filip Fila]

filipf added a comment.


  In D17906#389751 , @fabianr wrote:
  
  > You are not using the default font, are you?
  
  
  
  
  In D17906#389713 , @mart wrote:
  
  > uuh, that's the wrong color.. that's seriously weird?
  >  that's on same version how i get notifications on a dark color scheme
  >  F6537172: Screenshot_20190109_104727.png 

  
  
  This the "//Qt will use whichever light font style is present//" problem.
  
  F6537311: image.png 
  
  It says "Light", but is actually "Hairline". On both of my machines the font 
got installed this way.
  
  As I said, light titlebars don't work great with Noto now either, but can 
even fall apart more with other fonts.
  
  - Roboto has a really thin "Light" variant:
  
  F6537317: image.png 
  
  - DejaVu Sans only has an "ExtraLight" variant:
  
  F6537320: image.png 

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Fabian Riethmayer]

fabianr added a comment.


  In D17906#388294 , @filipf wrote:
  
  > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same 
problem.
  >
  > F6531867: image.png 
  >
  > F6531893: image.png 
  >
  > For me this represented a massive regression, and there's bound to be more 
people in a similar situation. We can't have this happening.
  
  
  You are not using the default font, are you?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Fabian Riethmayer]

fabianr added a comment.


  The HIG states: "When the visual design calls for an area of exceptional 
focus, a larger typeface size may be used. In this case use a Light typeface 
weight to keep the stroke width similar to other styles throughout the 
interface"
  
  I think, if you want to have something like F6531451: 
Screenshot_20190107_145258.png  you 
should use your own special sized label. And if you want to add so much focus 
on a text, it can be unique in its font size.
  
  To me it seams the predefined Header[1-4] are mainly to be used for regular 
content and chrome?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D18089: KLauncher: handle processes exiting without error

[Ahmad Samir]

ahmadsamir added a comment.


  I don't have commit access, so please commit the diff.
  
  Thanks.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in klauncher.cpp:340
> To make this less scary (since it's not an error) I would suggest
> 
>   << "exited without error, request done. status=" <<

Good point. Done.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

[Ahmad Samir]

ahmadsamir marked 2 inline comments as done.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D18089

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18089: KLauncher: handle processes exiting without error

[Ahmad Samir]

ahmadsamir updated this revision to Diff 49063.
ahmadsamir retitled this revision from "KLauncher: handle process dying with 
exitStatus 0" to "KLauncher: handle processes exiting without error".
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Make commit and debug messages less scary, i.e. exit instead of die

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18089?vs=48948=49063

BRANCH
  klauncher-kateSessionManager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18089

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18114: FakeInput: add support for pointer move with absolute coordinates

[Jan Grulich]

jgrulich updated this revision to Diff 49064.
jgrulich added a comment.


  Revert unwanted changes in CMakeLists

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18114?vs=49046=49064

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18114

AFFECTED FILES
  autotests/client/test_fake_input.cpp
  src/client/fakeinput.cpp
  src/client/fakeinput.h
  src/client/protocols/fake-input.xml
  src/server/fakeinput_interface.cpp
  src/server/fakeinput_interface.h

To: jgrulich, davidedmundson, graesslin
Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Marco Martin]

mart added a comment.


  In D17906#388803 , @ngraham wrote:
  
  > F6531451: Screenshot_20190107_145258.png 

  >  In this one, the fact that it's a header is connoted by its much larger 
font size and wider character width and spacing. It feels "bigger" in every way 
than the text beneath it. It looks good.
  >
  > F6531453: Screenshot_20190107_145312.png 

  >
  > This photo is quite different. Here the header text is no larger or barely 
larger than the text beneath it, and its line weight is lighter. Also, it's 
very visually disconnected from the thing it's a header for, since it's stuck 
up in the top-right corner of a visually superfluous stock photo. Nothing about 
the header text tells my eye "I'm a header!"
  
  
  it's exactly 180% the notmal font. It was bigger, I was told to shrink it

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Marco Martin]

mart added a comment.


  In D17906#388294 , @filipf wrote:
  
  > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same 
problem.
  >
  > F6531867: image.png 
  >
  > F6531893: image.png 
  >
  > For me this represented a massive regression, and there's bound to be more 
people in a similar situation. We can't have this happening.
  
  
  uuh, that's the wrong color.. that's seriously weird?
  that's on same version how i get notifications on a dark color scheme
  
  F6537172: Screenshot_20190109_104727.png 


REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel, 
dkardarakos, apol, davidedmundson, hein

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  But wait, can we completely remove `m_oldDragMovePos` ?
  If the event is accepted in the case `event->pos() == m_oldDragMovePos`, then 
why don't we generate the move event?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  @broulik
  I've updated the patch, can you review it ?
  
  In D16643#378823 , @broulik wrote:
  
  > Only if that potential issue with inhibition has been addressed

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: bruns, dkorth, ngraham, kde-frameworks-devel, michaelh