D18762: Add support for portals in KRun

[Denis Karpovskii]

GeeXT updated this revision to Diff 51017.
GeeXT added a comment.


  The result should be negated

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18762?vs=50972=51017

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

AFFECTED FILES
  src/widgets/krun.cpp

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18762: Add support for portals in KRun

[Jan Grulich]

jgrulich added a comment.


  Looks good from the portal point of view, but I would rather wait for someone 
who knows KRun internally to approve this review.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18778: [KRun] Fall back to reading text/html in mimeapps.list if others aren't there

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  If System Settings > Applications > Default Applications > Web Browser is 
using the setting "In an application based on the contents of the URL", then 
lookup can fail and pass the URL to the wrong app when no default app is set in 
`kdeglobals` and `mimeapps.list` has no `x-scheme-handler/https` or 
`x-scheme-handler/http` entries, but does have an entry for `text/html`.
  
  This patch makes KRun additionally fall back to reading from `text/html` in 
`mimeapps.list` if it's present.

TEST PLAN
  Can now open URLs when using "In an application based on the contents of the 
URL when `mimeapps.list` only has an entry for `text/html`.

REPOSITORY
  R241 KIO

BRANCH
  more-mimeapps-fallbacks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18778

AFFECTED FILES
  src/widgets/krun.cpp

To: ngraham, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18776: Make sure only directories are added to the inotify watcher

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Maybe add a comment above this line explaining the reasoning that you put in 
the patch's summary section.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18776

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18776: Make sure only directories are added to the inotify watcher

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Although watchFolder is only called for directories, there is a small
  time frame where the just added directory has been deleted and a file
  with the same path has been created. This race condition can be avoided
  by adding the KInotify::FlagOnlyDir filter flag.
  
  This has been documented also in e.g. https://lwn.net/Articles/605128/.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18776

AFFECTED FILES
  src/file/filewatch.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18772: Mark KCodecs::uuencode does nothing

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R270 KCodecs

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18772

AFFECTED FILES
  CMakeLists.txt
  src/kcodecs.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:229
> but in case file.tag() returns an ApeTag, the dynamic_cast will return a 
> nullptr. This is a dynamic_cast, not a static_cast.

It always returns a nullptr

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18604: Implement support for writing rating information for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:229
> No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not 
> possible.

but in case file.tag() returns an ApeTag, the dynamic_cast will return a 
nullptr. This is a dynamic_cast, not a static_cast.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18770: [KStatusNotifierItem] use fallback sizes when none is available

[Pino Toscano]

pino created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pino requested review of this revision.

REVISION SUMMARY
  When converting a QIcon to a vector of images to D-Bus, the list of
  available sizes is used to extract the pixmaps of the icon.  In case
  the engine of the icon advertizes no sizes, then no pixmaps are sent:
  this is the case of the SVG icon engine shipped with QtSvg, so creating
  a QIcon from an SVG file means nothing is sent for it.
  
  As solution, use a list of few well-known sizes in case no size is
  available: this way there is the possibility to have some pixmaps for
  that icon.

TEST PLAN
  - create a KStatusNotifierItem
  - create a QIcon from a SVG file
  - set that QIcon as pixmap for the KStatusNotifierItem, e.g. using 
setIconByPixmap
  
  Without this change, no icon is shown in the Plasma tray.

REPOSITORY
  R289 KNotifications

BRANCH
  ksni-fallback-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18770

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: pino
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17245: Add string formatting function to property info

[Alexander Stippich]

astippich added a comment.


  Can someone please give this a yes or a no?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D18738: Add ebook thumbnailer

[Elvis Angelaccio]

elvisangelaccio added a comment.


  LGTM

INLINE COMMENTS

> CMakeLists.txt:265
> +
> +install(TARGETS ebookthumbnail DESTINATION ${PLUGIN_INSTALL_DIR})
> +

`PLUGIN_INSTALL_DIR` is deprecated, new code should use `KDE_INSTALL_PLUGINDIR`

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16643: Correct the accept flag of the event object on DragMove

[Ben Cooksley]

bcooksley added a comment.


  Your name has now been updated.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, 
michaelh

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:6258f33fce3a: [GridViewKCM] improve contrast and 
legibility for delegates inline hover… (authored by ngraham).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50990=50991

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50990.
ngraham added a comment.


  Reverse the order of clicking and triggering, since it looks a bit nicer this 
way

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50982=50990

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Kai Uwe Broulik]

broulik added a comment.


  +1 I think this is a fine tradeoff between aesthetics and usability

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ba3341c83b18: Fix ENABLE_CLAZY option with clazy = 
1.5 (authored by elvisangelaccio).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18680?vs=50790=50989

REVISION DETAIL
  https://phabricator.kde.org/D18680

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2, ndavis
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Very nice!

REPOSITORY
  R296 KDeclarative

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik, GB_2
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18768: Extend Open Document thumbnailer to Office Open XML

[Andrew Crouthamel]

acrouthamel added a comment.


  Thanks for expanding the thumbnailer lately, awesome work with this and the 
eBook one. :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18768

To: broulik, #plasma, #vdg, #frameworks
Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50982.
ngraham added a comment.


  Use theme-following version for various reasons

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50976=50982

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18768: Extend Open Document thumbnailer to Office Open XML

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This tries to extract the `docProps/thumbnail.*` from `.docx`, `.xlsx`, 
`.pptx` as well as their templates.

TEST PLAN
  I found that a few of my newer `.docx` most `.pptx` actually contain a 
`docProps/thumbnail.jpeg` file we can extract. The samples I have are quite 
small, so please give it a try if you deal with those file types. Internet 
suggests it can also be `thumbnail.jpg` and `thmbnail.emf` (if Qt can even read 
that..) so the path isn't hardcoded for those.
  
  The thumbnailer library name is kept to avoid changes when user updates and 
both do have "open" in the name :) I just dropped the Open Document Files suffix

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18768

AFFECTED FILES
  thumbnail/opendocumentcreator.cpp
  thumbnail/opendocumentthumbnail.desktop

To: broulik, #plasma, #vdg, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Actually there is a real issue here. Disabled button icons are much less 
legible with the dark version. The enabled version of the delete button is less 
legible too (red-on-black vs red-on-gray) I think we need to go with the 
version that 100% follows the color scheme instead of always being dark.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  In D16643#406076 , @bcooksley 
wrote:
  
  > Please update your name on Identity, then i'll sync it from there.
  
  
  Done.
  Thank you!

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, 
michaelh

D16643: Correct the accept flag of the event object on DragMove

[Ben Cooksley]

bcooksley added a comment.


  Please update your name on Identity, then i'll sync it from there.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, 
michaelh

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Now that I think about it, Elisa also has a variant of this UI that would be 
much better if it adopted this visual style, and i think that one would look 
good with dark buttons too.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  Nice, my first patch finally has been accepted.
  Thanks everyone!
  
  Btw, can you @bcooksley help me to change my name in my profile? Tranter Madi

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, 
michaelh

D16643: Correct the accept flag of the event object on DragMove

[Nathaniel Graham]

ngraham added a comment.


  Never mind, missed that this was for a Frameworks repo.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Fabian Vogt]

fvogt closed this revision.
fvogt added a comment.


  Landed (phab didn't notice): 
https://cgit.kde.org/kdeclarative.git/commit/?id=856672f370fb32c7a3c3d1a13d873fb8b767d0e8

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Ben Cooksley]

bcooksley added a comment.


  Phabricator can take up to 30 minutes to become aware of commits depending on 
how active a repository normally is.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: bcooksley, fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, 
michaelh

D16643: Correct the accept flag of the event object on DragMove

[Nathaniel Graham]

ngraham added a comment.


  Hmm, should this go to the 5.15 branch too?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18604: Implement support for writing rating information for taglib writer

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:229
> Is this the same as
> 
>   auto id3Tags = dynamic_cast(file.tag());
>   if (id3Tags) { ... }
> 
> ?

No. Mp3 supports ID3v1, ID3v2 or Ape tags, so simply casting to ID3v2 is not 
possible.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16643: Correct the accept flag of the event object on DragMove

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.


  @trmdi: Do you have push access? If not, which name  should be used for 
the commit?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi added a comment.


  In D16643#406051 , @fvogt wrote:
  
  > @trmdi: Do you have push access? If not, which name  should be used 
for the commit?
  
  
  No, I don't.
  tr...@yandex.com / Tranter Madi

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns, fvogt
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:70
> When you make this
> `void writeGenericProperties(Taglib::File *file, const PropertyMap 
> )`, you can do `file->properties(); {/* merge */}; 
> file->setProperties(...);` here, saving most of the duplicate code below.
> 
> dito for the specializations in D18604 , 
> just pass in `Taglib::File*`, and call `auto tags = 
> dynamic_cast(file->tag());` there.

That will then require to load and write the property map twice when properties 
only specific to some tagging formats need to be written, see e.g. Ape and 
Vorbis tags in D18604 . I would like to 
avoid this.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#406032 , @ngraham wrote:
  
  > Or we could just use frikkin' light buttons. :)
  
  
  I think dark buttons just draw too much attention and doesn't really fit. 
When using the colorscheme the contrast of the button icons should still be 
good, since there is a solid background.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D16643: Correct the accept flag of the event object on DragMove

[trmdi]

trmdi updated this revision to Diff 50979.

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16643?vs=47815=50979

REVISION DETAIL
  https://phabricator.kde.org/D16643

AFFECTED FILES
  src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in resulttest.cpp:63
> This looks wrong to me ...
> How many items do you get when you append "keyword3" first and ["keyword1", 
> "keyword2"] next?

It's the same. The properties will get merged regardless of their form if the 
QVariantMap already contains an item with the same key, see 
https://phabricator.kde.org/source/baloo/browse/master/src/file/extractor/result.cpp$52
 so this works as currently intended.
Right now, we rely on this behavior because KFileMetaData (incorrectly) outputs 
multiple properties with the same key instead of a single property made of a 
QStringList. I wrote the test to prepare the switch to string lists at some 
point.
My favorite solution is to remove this merging, once KFileMetaData outputs 
string lists when necessary. This requires a custom function for the conversion 
of the output JSON to a PropertyMap, see 
https://phabricator.kde.org/source/baloo/browse/master/src/lib/file.cpp$118
QJsonDocument::toVariantMap currently does not handle duplicated keys. IIRC 
JSON with duplicated keys is strictly not compliant, but since it is only 
internal, this is okay IMHO.
The own conversion function  will save us an extra for loop, and makes sure 
that the same PropertyMap is generated when either querying via Baloo 
(file.load()) or directly via KFileMetaData's SimpleExtractionResult.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Or we could just use frikkin' light buttons. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Well, this view is used in a lot of different places, so it's not like only 
one thing does it this way now.
  
  But we could do it in Gwenview too, which has the same basic UI but uses 
light buttons. Also maybe we could think about adjusting Dolphin's selection 
marker UI to match it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  Well, I really don't like that this is the only thing that has dark buttons. 
It is inconsistent and just looks out of place. We should probably do some more 
discussion elsewhere if we want do this in other places too.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  The buttons are dynamic and are chosen by the individual KCM; what you 
propose would be out of scope even if it were possible.
  
  I think we're going to stay with this basic design.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Hazem Salem]

Codezela added a comment.


  another option we put the delete button only
  and align it to the corner of the thumbnail
  make it circle button
  and ditch the other one
  no need for it here
  what do u think

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18762: Add support for portals in KRun

[Nathaniel Graham]

ngraham added reviewers: apol, dfaure, Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18762

To: GeeXT, jgrulich, apol, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  In D18649#406019 , @Codezela wrote:
  
  > how about make it global under
  >  beside add image button aligned left
  >  tow buttons disablef by default
  
  
  No, that was the old design we moved away from. The new thing is inline 
buttons.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Hazem Salem]

Codezela added a comment.


  how about make it global under
  beside add image button aligned left
  tow buttons disablef by default

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: Codezela, bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18487: Reparse background contrast settings when colors changed

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> mart wrote in theme_p.cpp:754
> but it wouldn't be guaranteed to be the same of the value stored in the 
> config file no?

If the theme does not supply background contrast values, they are 
auto-determined from the background color (dark or light), or what do you mean?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham added a comment.


  Yeah, the dark version has grown on me too. I'm going to go with that for 
now. The diff is smaller too.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham updated this revision to Diff 50976.
ngraham added a comment.


  Go with the dark version

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18649?vs=50879=50976

BRANCH
  improve-grid-view-kcm-inline-hover-button-contrast (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18649

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

Re: [sysadmin/ci-tooling] build-specs/Plasma: Disable execution of tests for plasma-integration.

[Ben Cooksley]

On Mon, Feb 4, 2019 at 6:35 AM David Faure  wrote:
>
> On vendredi 1 février 2019 10:32:19 CET Ben Cooksley wrote:
> > On Fri, Feb 1, 2019 at 9:15 PM David Faure  wrote:
> > > I'll try to get around to debugging this, but I'm surprised by one thing:
> > > doesn't the same issue happen in KIO's own tests? It also has several
> > > tests
> > > that make use of KIO slaves directly, skipping KLauncher.
> >
> > Indeed, I found it surprising as well.
> >
> > Only thing I can think of is that the tests in KIO tell the slaves to
> > exit before it finishes itself and exits - while the tests in
> > plasma-integration don't do this.
>
> There's no API in KIO for telling slaves to exit; they are supposed to just 
> do that by themselves, after being idle for a while.
>
> > > Ironically, the reason we skip klauncher is exactly to avoid this problem
> > > in the first place (kdeinit and klauncher would keep running after the
> > > test ended).
> >
> > The CI tooling should eliminate the need to do this for the most part
> > as long as you don't try to launch them yourself, as it will launch
> > kdeinit as part of the environment setup process :)
> > https://invent.kde.org/sysadmin/ci-tooling/blob/master/helpers/run-tests.py#
>
> Well, let's try without KDE_FORK_SLAVES then?
>
> I just pushed that in 
> https://commits.kde.org/plasma-integration/a94bbdaadff282a26dece12172234b8bec1a29c9
> also merged to master.
>
> Can you re-enable CI and let me know if it works better - or worse? ;-)

This has now been done. We'll need to wait a bit for several runs of
plasma-integration to take place, but so far it seems to be working
properly.
Thanks for sorting that out.

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

Cheers,
Ben

D16643: Correct the accept flag of the event object on DragMove

[Stefan Brüns]

bruns added a comment.


  In D16643#405814 , @fvogt wrote:
  
  > @trmdi: Can you do the small change @bruns suggested? ^ Then it can be 
landed and everyone's happy :-)
  
  
  

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Stefan Brüns]

bruns added a comment.


  The inline version looks a little bit more polished, while the other one 
looks literally "just put on top". The "button" version though somewhat 
resembles the "selection" buttons/emblems in dolphin.
  
  There is a very tiny issue with the button version, although the buttons do 
not overlap, they do touch the text, at least for any full height characters 
("l,i,t,k, ...").

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: bruns, rizzitello, ndavis, andreask, filipf, abetts, GB_2, 
kde-frameworks-devel, michaelh, ngraham

D18763: [client] Fix typos

[Vlad Zagorodniy]

zzag abandoned this revision.
zzag added a comment.


  Well ok.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18763

To: zzag, #kwin
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18763: [client] Fix typos

[Aleix Pol Gonzalez]

apol added a comment.


  These are not typos.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18763

To: zzag, #kwin
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> bruns wrote in kinotify.cpp:429
> This is broken now, as you fail to emit created for any child.

Ignore, looked at the wrong line ...

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kinotify.cpp:429
> +if (!it.next().isEmpty()) {
> +d->addWatch(it.filePath());
> +}

This is broken now, as you fail to emit created for any child.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18762: Add support for portals in KRun

[Denis Karpovskii]

GeeXT updated this revision to Diff 50972.
GeeXT added a comment.


  Restored the accidentally deleted empty line...

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18762?vs=50968=50972

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

AFFECTED FILES
  src/widgets/krun.cpp

To: GeeXT, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added a comment.


  Addendum:
  I have just checked, 
https://phabricator.kde.org/source/baloo/browse/master/src/file/filewatch.cpp$144
  
  filewatch relies on the code here to emit created events for all children, so 
we need the traversal code not only for "moved", but also for "created", as 
otherwise we may miss some "created" events.
  
  Duplicate "created" events is completely fine, these are merged in the 
"PendingFileQueue".
  
  So I would like you to do the following:
  
  - take the newly added code and create a function from it, e.g. 
`handleCreateRecursive(event, path)`
  - move the `Q_EMIT created(...)` to the beginning of the function
  - call this function for the "EventMoveTo && noCookie)" case
  - call this function also for "EventCreated"
  
  Probably also add a comment to the function why the manual traversal is 
needed:
  
// Files/directories inside the new directory may be created before the 
watch
// is installed. Ensure created events for all children are issued at least 
once

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 05 Feb 2019 17:02:37 +
 Build duration:
7 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18763: [client] Fix typos

[Vlad Zagorodniy]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REPOSITORY
  R127 KWayland

BRANCH
  fix-typos

REVISION DETAIL
  https://phabricator.kde.org/D18763

AFFECTED FILES
  src/client/datadevicemanager.h

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18761: Add icon name to service providers in .desktop file

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8657a239a28d: Add icon name to service providers in 
.desktop file (authored by shubham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18761?vs=50953=50969

REVISION DETAIL
  https://phabricator.kde.org/D18761

AFFECTED FILES
  src/urifilters/ikws/searchproviders/google.desktop
  src/urifilters/ikws/searchproviders/wikipedia.desktop
  src/urifilters/ikws/searchproviders/yahoo.desktop
  src/urifilters/ikws/searchproviders/youtube.desktop

To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18762: Add support for portals in KRun

[Denis Karpovskii]

GeeXT created this revision.
GeeXT added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GeeXT requested review of this revision.

REVISION SUMMARY
  Currently KRun in Flatpak/Snap doesn't support portals so it can't launch an 
application
  for a given url (because it can't break through sandbox). This patch allows 
KRun to use
  portals to pass the url through sandbox. QDesktopServices::openUrl handles 
that case and sends
  appropriate DBus calls to portals, so URIs will be proccessed accordingly by 
host system.
  
  FEATURE: 399380

TEST PLAN
  I couldn't build KIO from master in current flatpak KDE runtime (even without 
the patch), so here are commands to test the patch on top
  of KIO 5.54.1:
  
  1. Install org.kde.Sdk 5.12 from flathub
  2. Install org.kde.konversation from KDE Nightly flatpak repo 
(https://community.kde.org/Guidelines_and_HOWTOs/Flatpak)
  3. Apply the patch to KIO 5.54.1
  4. run 'flatpak run --filesystem=host --command=sh --devel org.kde.Sdk//5.12' 
to enter SDK
  5. build KIO
  6. exit SDK (exit or Ctrl+D)
  7. run flatpak shell with Konversation 'flatpak run --filesystem=host 
--command=sh org.kde.konversation'
  8. run LD_PRELOAD="path/to/libKF5KIOCore.so path/top/libKF5KIOWidgets.so 
path/to/libKF5KIOFileWidgets.so" /app/bin/konversation
  
  to run it with just compiled KIO (the compiled libraries are located in bin 
directory inside your build directory)
  Now link clicks should pass sandbox and do the appropriate actions (open 
browser for http links, email application for mailto links,
  file manager for file://...)

REPOSITORY
  R241 KIO

BRANCH
  flatpak_open_url (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18762

AFFECTED FILES
  src/widgets/krun.cpp

To: GeeXT, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko updated this revision to Diff 50967.
poboiko added a comment.


  Cosmetics

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18698?vs=50932=50967

BRANCH
  add-watch-moved (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18698

AFFECTED FILES
  autotests/unit/file/kinotifytest.cpp
  src/file/kinotify.cpp

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18761: Add icon name to service providers in .desktop file

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  icon

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added inline comments.

INLINE COMMENTS

> octave.xml:2745
> + String="end_try_catch" endRegion="Try" />
>  
> + endRegion="block" />

Could one word (`end`) be in several region?
Because, in Octave, you could end `if` statement by `endif` or just `end`.
In this variant, this syntax supported, but correct implementation also allow 
wrong Octave sytnax, like ending `while` via `endfor` (because we are using one 
region for them in code above).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko marked an inline comment as done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko updated this revision to Diff 50963.
sirgienko added a comment.


  Add requested changes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18734?vs=50877=50963

BRANCH
  octave

REVISION DETAIL
  https://phabricator.kde.org/D18734

AFFECTED FILES
  data/syntax/octave.xml

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D18487: Reparse background contrast settings when colors changed

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> broulik wrote in theme_p.cpp:754
> An alternative approach would be to store those values and then do the 
> default fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) < 
> 127` stuff on the fly on demand.
> It's runtime cpu cycles vs parsing a config file once on color change (with 
> some awful copy paste)

but it wouldn't be guaranteed to be the same of the value stored in the config 
file no?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18487

To: broulik, #plasma
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns

D18734: Update octave.xml to Octave 4.2.0

[Nikita Sirgienko]

sirgienko added a comment.


  @dhaumann, look on the `eps` (this word contained in command list) on this 
image. The word have wrong highlighting.
  F6589241: изображение.png 
  I am testing my `octave.xml` file on v5.49.0 (current master need ecm 5.55 
and I haven't it). Is it bug and I should create bug report, or it is already 
fixed?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18734

To: sirgienko, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, hase, michaelh, 
genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/6/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 05 Feb 2019 16:00:17 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3602/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added a comment.


  In D18698#405504 , @poboiko wrote:
  
  > > I am not sure if I understood your description correctly, but I am quite 
sure this race condition does not exist - the files/folders inside the moved 
folder are not created/moved one by one, but the containing folder ist just 
"renamed" - it is unlinked from the old parent and linked into the new one, 
atomically.
  >
  > Sure. That concern corresponded only to the second note - if moving from 
another device, system has to do actual copy/move.
  
  
  But when "moving" across devices, we should get regular "created" events for 
each directory and file, as copying/moving across devices is done one by one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Stefan Brüns]

bruns added a comment.


  In D18698#405636 , @poboiko wrote:
  
  > Added code to work with first entry that pops from FilteredDirIterator 
(that is the directory itself)
  >  Test still works; but we should emit `created()` signal for it as well.
  
  
  Thats the reason I moved the `Q_EMIT created(...)` out of the `if(mask & 
IN_ISDIR)` branch.
  
  Thinking about it, it should be before the branch, otherwise baloo may 
receive "created" events for the children before getting a "created" for the 
parent.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/14/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 05 Feb 2019 16:00:17 +
 Build duration:
3 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.55.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3604/13324)18%
(1814/9842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/18/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 05 Feb 2019 16:00:16 +
 Build duration:
2 min 5 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dda4edcc6eb0: [breeze desktop theme/dialogs] Add rounded 
corners to dialogs (authored by rooty).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18545?vs=50310=50961

REVISION DETAIL
  https://phabricator.kde.org/D18545

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svgz
  src/desktoptheme/breeze/translucent/dialogs/background.svgz

To: rooty, #vdg, ngraham
Cc: zzag, davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18738: Add ebook thumbnailer

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  VDG,approved, still needs a proper code review.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

[Krešimir Čohar]

rooty added a comment.


  Okay seeing as I'm seeing this corner problem with my icons as well, 
  F6589150: image.png  vs F6589155: 
image.png 
  I think it's safe to land this. Also it's way past Saturday so :D

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18545

To: rooty, #vdg, ngraham
Cc: zzag, davidedmundson, Codezela, filipf, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15910: Implement wl_surface::damage_buffer

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  damageBuffer

REVISION DETAIL
  https://phabricator.kde.org/D15910

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D18738: Add ebook thumbnailer

[Nathaniel Graham]

ngraham added a comment.


  Quite lovely. With the latest changes, this now generates thumbnails for all 
my my ePubs that have a cover page defined.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18738

To: broulik, #plasma, #vdg
Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D15910: Implement wl_surface::damage_buffer

[Vlad Zagorodniy]

zzag added a comment.


  Is it good now?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15910

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16643: Correct the accept flag of the event object on DragMove

[Fabian Vogt]

fvogt added a comment.


  @trmdi: Can you do the small change @bruns suggested? ^ Then it can be landed 
and everyone's happy :-)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D16643: Correct the accept flag of the event object on DragMove

[Stefan Brüns]

bruns added a comment.


  In D16643#405468 , @fvogt wrote:
  
  > > The second change fvogt mentioned is IMHO handled quite strangely here - 
!m_enabled || m_temporaryInhibition is the inverse of !m_enabled || 
m_temporaryInhibition, so doing a event->ignore() === event->setAccepted(false) 
prior to the first return statement would cover the ignored case, and allows 
the event to bubble up.
  >
  > Sure, but AFAICT that's just a matter of taste whether to `ignore(); 
if(!something) return; do stuff; accept();` or `accept(something); 
if(!something) return; do stuff;`.
  
  
  Its about the duplicate evaluation of ` !m_enabled || m_temporaryInhibition`. 
Expecially as it is not easy to spot both conditions are exactly the same.
  
  compare
  
event->setAccepted(m_enabled && !m_temporaryInhibition);
if (!m_enabled || m_temporaryInhibition) {
return;
}
  
  with
  
if (!m_enabled || m_temporaryInhibition) {
event->ignore();
return;
}
event->accept();

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D16643

To: trmdi, mart, broulik, #plasma, hein, bruns
Cc: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

[Björn Feber]

GB_2 added a comment.


  In D18649#405368 , @ngraham wrote:
  
  > One thing I will not do in this patch is synthesize a fake button that has 
different behaviors from the standard button. If there's a problem with our 
buttons we need to fix it everywhere, not work around it here (and elsewhere).
  >
  > Here are our two options:
  >
  > F6588077: Inline dark buttons.gif 
  >
  > F6588078: Slightly escaping light buttons.gif 

  >
  > Maybe we should just take a vote.
  
  
  I like version 2 best, I think the contrast is good enough.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: rizzitello, ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, 
michaelh, ngraham, bruns

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular, #frameworks
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham added a comment.


  In the rest of service providers, very few have any icon specified, and most 
don't have.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18730: Use breeze icons for search providers

[Shubham]

shubham abandoned this revision.
shubham added a comment.


  Abandoned in favour of D18761 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham added reviewers: VDG, Okular.
shubham added projects: Okular, VDG.
shubham added a subscriber: Okular.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18761

To: shubham, broulik, ngraham, #vdg, #okular
Cc: #okular, kde-frameworks-devel, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, rooty, trickyricky26, michaelh, crozbo, ndavis, 
tfella, firef, ngraham, bruns, skadinna, darcyshen, aaronhoneycutt, aacid, 
mbohlender

D18761: Add icon name to service providers in .desktop file

[Shubham]

shubham created this revision.
shubham added reviewers: broulik, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  Earlier all entries had same icon ie. "text-html"
  See also D18755 

TEST PLAN
  1. Open any document
  2. Choose Selection and select some area of the document
  3. Context menu appears. Go on search for ...
  4. New icons

REPOSITORY
  R241 KIO

BRANCH
  icon

REVISION DETAIL
  https://phabricator.kde.org/D18761

AFFECTED FILES
  src/urifilters/ikws/searchproviders/google.desktop
  src/urifilters/ikws/searchproviders/wikipedia.desktop
  src/urifilters/ikws/searchproviders/yahoo.desktop
  src/urifilters/ikws/searchproviders/youtube.desktop

To: shubham, broulik, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18163: Set the color scheme to Printing for Print Preview

[Dominik Haumann]

dhaumann edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18163: Set the color scheme to Printing for Print Preview

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:28e59740d070: Set the color scheme to Printing for Print 
Preview (authored by ahmadsamir, committed by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18163?vs=50588=50945

REVISION DETAIL
  https://phabricator.kde.org/D18163

AFFECTED FILES
  src/printing/kateprinter.cpp

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18116: Add TODO KF6 note

[Dominik Haumann]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:574b08d08111: Add TODO KF6 note (authored by dhaumann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18116?vs=50875=50946

REVISION DETAIL
  https://phabricator.kde.org/D18116

AFFECTED FILES
  src/include/ktexteditor/document.h

To: loh.tar, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 05 Feb 2019 12:01:59 +
 Build duration:
7 min 32 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18755: Read IKWS search provider icon from desktop file

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e1c386f04303: Read IKWS search provider icon from desktop 
file (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18755?vs=50934=50938

REVISION DETAIL
  https://phabricator.kde.org/D18755

AFFECTED FILES
  src/urifilters/ikws/searchprovider.cpp
  src/urifilters/ikws/searchprovider.h

To: broulik, #frameworks, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18755: Read IKWS search provider icon from desktop file

[Shubham]

shubham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18755

To: broulik, #frameworks, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18755: Read IKWS search provider icon from desktop file

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, shubham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to give them more meaningful icons rather than the one derived from 
URL (usually generic web icon).
  This is probably from when Konqueror was still widely used and a favicon was 
likely present.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18755

AFFECTED FILES
  src/urifilters/ikws/searchprovider.cpp
  src/urifilters/ikws/searchprovider.h

To: broulik, #frameworks, shubham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18730: Use breeze icons for search providers

[Kai Uwe Broulik]

broulik added a comment.


  Check out D18730 
  
  Then you can put `Icon=foo` in the respective search provider desktop file

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18730: Use breeze icons for search providers

[Shubham]

shubham added a comment.


  @broulik Adding icons to the .desktop files does not work, I tried.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18730

To: shubham, ngraham, #vdg, #frameworks, cfeck
Cc: broulik, #vdg, okular-devel, Pixel_Lime, jraleigh, squeakypancakes, alexde, 
IohannesPetros, GB_2, rooty, trickyricky26, crozbo, ndavis, tfella, firef, 
ngraham, skadinna, darcyshen, aaronhoneycutt, aacid, mbohlender

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko marked an inline comment as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18698

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams

D18698: [baloo/KInotify] Notify if folder was moved from unwatched place

[Igor Poboiko]

poboiko updated this revision to Diff 50932.
poboiko added a comment.


  Added code to work with first entry that pops from FilteredDirIterator (that 
is the directory itself)
  Test still works; but we should emit `created()` signal for it as well.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18698?vs=50832=50932

BRANCH
  add-watch-moved (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18698

AFFECTED FILES
  autotests/unit/file/kinotifytest.cpp
  src/file/kinotify.cpp

To: poboiko, #baloo, #frameworks, ngraham, bruns
Cc: bruns, ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, abrahams