D18895: AsciiDoc: Add folding for sections

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I think this change is ok. Although, adding many RegExprs is slow compared to 
other rules.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18895

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18864: FlatBuffers schema syntax highlighting

[Dominik Haumann]

dhaumann accepted this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

To: harald, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, 
ngraham, bruns, demsking, sars

D18864: FlatBuffers schema syntax highlighting

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  I think that is ok ;=)
  Thanks for the contribution, and nice to read from you Harald, too ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

To: harald, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, 
ngraham, bruns, demsking, sars

D18915: Fix batchrename changing extension to lower case

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> abalaji wrote in batchrenamejob.cpp:64
> I wonder if just getting rid of `.toLower()` fixes this bug

I agree with @abalaji here. Modifying the code around this line should fix the 
bug and also address my previous comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Ambareesh Balaji]

abalaji added a comment.


  Added a couple inline comments for you to address. Also, please use four 
spaces instead of tabs, and keep the spacing consistent (spaces around `+`, 
space between `if ()` and the `{). I have yet to run and test this, but if you 
check the comment on the left side of the diff, I wonder if just removing that 
`.toLower()` is enough.

INLINE COMMENTS

> batchrenamejob.cpp:62
>  QSet extensions;
> -QMimeDatabase db;
> + const QString dot = QString::fromStdString(".");
>  foreach (const QUrl , m_srcList) {

You can just `QString dot = "."`, but you should use a single character instead 
of a string, since it's just a single character

> batchrenamejob.cpp:64
>  foreach (const QUrl , m_srcList) {
> -const QString extension = 
> db.suffixForFileName(url.toDisplayString().toLower());
>  if (extensions.contains(extension)) {

I wonder if just getting rid of `.toLower()` fixes this bug

> batchrenamejob.cpp:68
> + //If the oldFileName contains a '.' then its extension is all to 
> the right of the last dot
> + if (urlStr.contains(dot)){
> + extension = urlStr.mid(urlStr.lastIndexOf(dot)+1);

Rather than using `contains` here, you can just use `lastIndexOf`, check if 
it's not `-1`, and go from there. Just simply `urlStr.lastIndexOf('.')`.

> batchrenamejob.cpp:179
> +
> + const QString dot = QString::fromStdString(".");
> + const QString oldFileName = oldUrl.fileName();

Same as above

> batchrenamejob.cpp:184
> + //If the oldFileName contains a '.' then its extension is all to the 
> right of the last dot
> + if (oldFileName.contains(dot)){
> + extension = oldFileName.mid(oldFileName.lastIndexOf(dot)+1);

Same as above

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 51383.
chinmoyr marked 4 inline comments as done.
chinmoyr added a comment.


  Fixed all issues.
  Added test case for suspend.
  
  > so the user knows that there data is gone
  
  *their

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18904?vs=51332=51383

BRANCH
  arcpatch-D10663

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @cfoster Thanks for the patch :)
  
  There's one more mass-rename related bug here:
  
  1. Create two files; one with a known extension (.cpp) and the other with a 
random extension (.xyz, anything not in mime db)
  2. Rename both.
  3. The extension (.xyz) is removed from second file.
  
  It is possible to add code for preserving the unknown extension in this patch 
itself. If not you can always create a new diff :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @ngraham The destination file is corrupted as soon as the user clicks 
overwrite. This patch deletes that file. Is that file supposed to be preserved 
(to prevent user panic)? My suggestion is to append ".part" or some similar 
extension when an overwrite starts, so the user knows that there data is gone.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added reviewers: Dolphin, Frameworks, abalaji.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a comment.


  To create a dump by hand this isn't that easy. see 
sysadmins/ci-tooling/helpers/create-abi-dump.py.
  
  > I was unsuccesful using abi-dumper
  
  So far I understood abi-dumper is something different - I use 
abi-complience-checker to create those dumps.
  
  As you need some more environment for this script, I ended up using 
docker-composer and a script to test this locally.
  
  F6606201: docker-compose.yml 
  
  F6606202: ci-build.sh 

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/19/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Feb 2019 23:27:55 +
 Build duration:
9 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3248/3967)48%
(4785/10033)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(898/917)49%
(1977/4013)src76%
(19/25)76%
(19/25)80%
(1116/1401)45%
(479/1075)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 23:27:55 +
 Build duration:
4 min 2 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3248/3967)48%
(4785/10033)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(898/917)49%
(1977/4013)src76%
(19/25)76%
(19/25)80%
(1116/1401)45%
(479/1075)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 23:25:30 +
 Build duration:
4 min 49 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 32 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)67%
(112/168)67%
(112/168)60%
(5683/9486)43%
(2221/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file100%
(11/11)100%
(11/11)95%
(843/886)52%
(271/522)autotests.unit.lib100%
(6/6)100%
(6/6)97%
(403/414)59%
(108/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1741/2146)60%
(690/1151)src.file63%
(24/38)63%
(24/38)51%
(849/1674)42%
(437/1052)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%
(0/20)src.qml.experimental0%
 

D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c6fd08d4c3c9: Optimize Baloo::File copy assign operator, 
fix Baloo::File::load(url) (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18877?vs=51260=51374

REVISION DETAIL
  https://phabricator.kde.org/D18877

AFFECTED FILES
  src/lib/file.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18900: Avoid side effects due to stale errno value

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:7cce4c7f7b47: Avoid side effects due to stale errno value 
(authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18900?vs=51320=51373

REVISION DETAIL
  https://phabricator.kde.org/D18900

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  src/xattr_p.h

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfoster requested review of this revision.

REVISION SUMMARY
  Files renamed with Dolphins batch rename would have their file
  extensions always converted to lower case.
  
  New method of getting the file extension may not work with a right
  to left language such as Arabic
  
  Resolves: #402388

TEST PLAN
  1. Open Dolphin
  2. Create files "foo.TXT" and "bar.TXT"
  3. Batch rename (F2) to name "x"
  4. Check files are now named "x1.TXT" and "x2.TXT"

REPOSITORY
  R241 KIO

BRANCH
  FileExtensionCase (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: cgiboudeaux.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Also place "Since" next to both argument and argument description.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  fixsincelocationfordescription

REVISION DETAIL
  https://phabricator.kde.org/D18913

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: kossebau, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 22:17:10 +
 Build duration:
5 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3245/3962)48%
(4775/10009)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(893/912)49%
(1966/3991)src76%
(19/25)76%
(19/25)80%
(1118/1401)45%
(480/1073)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/18/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Feb 2019 22:17:10 +
 Build duration:
2 min 19 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3245/3962)48%
(4775/10009)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(893/912)49%
(1966/3991)src76%
(19/25)76%
(19/25)80%
(1118/1401)45%
(480/1073)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/17/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Feb 2019 21:47:48 +
 Build duration:
8 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3245/3962)48%
(4773/10005)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(893/912)49%
(1964/3987)src76%
(19/25)76%
(19/25)80%
(1118/1401)45%
(480/1073)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 21:47:48 +
 Build duration:
4 min 29 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3245/3962)48%
(4773/10005)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(893/912)49%
(1964/3987)src76%
(19/25)76%
(19/25)80%
(1118/1401)45%
(480/1073)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18910: Use Kformat for bit and sample rate

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:e1fa79b30da2: Use Kformat for bit and sample rate 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18910?vs=51346=51367

REVISION DETAIL
  https://phabricator.kde.org/D18910

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 11 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/11/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 21:26:53 +
 Build duration:
5 min 36 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3238/3954)48%
(4758/9975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(891/910)49%
(1950/3959)src76%
(19/25)76%
(19/25)80%
(1113/1395)45%
(479/1071)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 88 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/88/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 10 Feb 2019 21:26:53 +
 Build duration:
3 min 35 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.externalextractortestFailed: projectroot.autotests.externalwritertestFailed: projectroot.autotests.propertyinfotest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 16 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/16/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Feb 2019 21:26:53 +
 Build duration:
2 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3238/3954)48%
(4758/9975)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(891/910)49%
(1950/3959)src76%
(19/25)76%
(19/25)80%
(1113/1395)45%
(479/1071)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/17/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Feb 2019 21:26:53 +
 Build duration:
1 min 50 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)

D18910: Use Kformat for bit and sample rate

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ah yes.

REPOSITORY
  R286 KFileMetaData

BRANCH
  format_samplerate

REVISION DETAIL
  https://phabricator.kde.org/D18910

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18911: Add units to framerate and gps data

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a14030bf7182: Add units to framerate and gps data 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18911?vs=51353=51359

REVISION DETAIL
  https://phabricator.kde.org/D18911

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18910: Use Kformat for bit and sample rate

[Alexander Stippich]

astippich added a comment.


  The unit will be corrected (it is _bit_rate) and three significant digits 
will always be shown:
  123 400 will be displayed as 123 kbit/s
  1 234 000 will be displayed as 1.23 Mbit/s
  12 345 000 will be displayed as 12.3 Mbit/s

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18910

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18901: Add device icons for drones

[Krešimir Čohar]

rooty accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  drone-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein, ngraham, rooty
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18911: Add units to framerate and gps data

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  format_units

REVISION DETAIL
  https://phabricator.kde.org/D18911

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18901: Add device icons for drones

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ooh, that is much nicer.

REPOSITORY
  R266 Breeze Icons

BRANCH
  drone-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein, ngraham
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18910: Use Kformat for bit and sample rate

[Nathaniel Graham]

ngraham added a comment.


  No, I just want to get a sense of what the user-facing changes will be. :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18910

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18911: Add units to framerate and gps data

[Alexander Stippich]

astippich updated this revision to Diff 51353.
astippich added a comment.


  - remove unrelated new lines

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18911?vs=51352=51353

BRANCH
  format_units

REVISION DETAIL
  https://phabricator.kde.org/D18911

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18911: Add units to framerate and gps data

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Add units to some of the properties
  of kfilemetadata. This will mostly
  be useful for baloo-widgets once
  they are ported.

REPOSITORY
  R286 KFileMetaData

BRANCH
  format_units

REVISION DETAIL
  https://phabricator.kde.org/D18911

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 updated this revision to Diff 51351.
trickyricky26 added a comment.


  - Use a circular design for the rotor to make it more recognisable

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18901?vs=51323=51351

BRANCH
  drone-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18901

AFFECTED FILES
  icons-dark/devices/16/uav-quadcopter.svg
  icons-dark/devices/16/uav.svg
  icons-dark/devices/22/uav-quadcopter.svg
  icons-dark/devices/22/uav.svg
  icons/devices/16/uav-quadcopter.svg
  icons/devices/16/uav.svg
  icons/devices/22/uav-quadcopter.svg
  icons/devices/22/uav.svg

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18910: Use Kformat for bit and sample rate

[Alexander Stippich]

astippich added a comment.


  I actually have not started porting Dolphin to the new feature yet, since 
this will require Kf 5.56 and is probably stuff for 19.08. If a screenshot is a 
must I will adjust priorities :)

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18910

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Nathaniel Graham]

ngraham added a comment.


  Hmm actually maybe I take it back... is this in fact intended to fix 125102? 
Because the destination file is still destroyed when an overwrite operation is 
canceled in the middle. That's not what we want; we want the destination file 
to be left //untouched// when the user intentionally cancels an overwrite. This 
will probably require moving/copying to a temp file and replacing the 
destination at the end, once the operation has completed--if there's enough 
space on disk for this of course.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18910: Use Kformat for bit and sample rate

[Nathaniel Graham]

ngraham added a comment.


  Any chance you can attach a screenshot of what this looks like now in 
Dolphin's information panel?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18910

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Nathaniel Graham]

ngraham added a comment.


  Woohoo! Please add:
  
BUG: 125102
FIXED-IN: 5.56
  
  To the Summary section. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18910: Use Kformat for bit and sample rate

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Format bit and sample rate to 3 significant digits

REPOSITORY
  R286 KFileMetaData

BRANCH
  format_samplerate

REVISION DETAIL
  https://phabricator.kde.org/D18910

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/formatstrings.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> jobtest.cpp:2019
> +QSignalSpy spyCancelCopy(this, ::cancelCopy);
> +connect (copyJob, ::Job::processedSize, this, [this](KJob *job, 
> qulonglong processedSize) {
> +if (processedSize > 0) {

no space after `connect`

> jobtest.cpp:2022
> +Q_UNUSED(job);
> +emit cancelCopy();
> +}

I'm curious, why this signal, just to call another lambda? Can't you move the 
code of the second lambda into this one? It's not like the signal is queued 
right now, it's a direct call.

> jobtest.cpp:2033
> +QCOMPARE(spyCancelCopy.count(), 1);
> +}
> +

Add `f.remove()` here, to avoid leaving a 10MB file around...

(The alternative would be to use QTemporaryFile)

> filecopyjob.cpp:478
> +// If result comes from one of the file writing jobs,
> +// then we are probably not writing anymore.
> +if (job == d->m_copyJob) {

Why the "probably"? ;-)

> filecopyjob.cpp:577
> +// source file is intact (m_delJob == NULL).
> +if (!isSuspended() && d->m_bFileWriteInProgress) {
> +if (d->m_copyJob && !d->m_delJob) {

Why "not suspended"? If we suspend and kill, don't we want the cleanup?

> filecopyjob.cpp:578
> +if (!isSuspended() && d->m_bFileWriteInProgress) {
> +if (d->m_copyJob && !d->m_delJob) {
> +QFile::remove(d->m_dest.toLocalFile());

This `if` makes little sense as is, since `d->m_delJob` can only be set when 
`d->m_copyJob` is nullptr (see line 515). So it's redundant, and the same as 
writing `if (d->m_copyJob)` -- and it looks less scary, I was initially worried 
when reading your line about what would happen before m_delJob was set or after 
m_delJob was null again.

> filecopyjob.cpp:579
> +if (d->m_copyJob && !d->m_delJob) {
> +QFile::remove(d->m_dest.toLocalFile());
> +}

A test for isLocalFile() is missing first.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18317: Display an error message if loading a dictionary fails

[Ahmad Samir]

ahmadsamir added a comment.


  I've split the changes to the Loader in https://phabricator.kde.org/D18907.
  
  And will hopefully try to handle the Ui part in this current diff.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D18907: Handle the case if createSpeller is passed an unavailable language

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: sandsmark, cullmann, dhaumann.
ahmadsamir added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  In Loader::createSpeller, retun early if lang isn't one of the available
  languages(); otherwise a dud entry will be created for it in
  dictionarycombobox.
  
  Emit a signal when loading a dictionary fails, so that Ui parts can
  display an appropriate error message informing the user about the issue,
  instead of failing silently.
  
  This is a first step to fix bug 325541.

REPOSITORY
  R246 Sonnet

BRANCH
  speller-loader (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18907

AFFECTED FILES
  src/core/loader.cpp
  src/core/loader_p.h

To: ahmadsamir, sandsmark, cullmann, dhaumann
Cc: dhaumann, cullmann, loh.tar, kde-frameworks-devel, michaelh, ngraham, bruns

D18900: Avoid side effects due to stale errno value

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18900

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18877: Optimize Baloo::File copy assign operator, fix Baloo::File::load(url)

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, makes sense.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18877

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: dfaure, dmitrio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This patch borrows code from D10663 .
  
  The destination file is deleted if a copy job is in progress and 
  delete job is yet to start (in case of move).
  
  One additional change I made is to exclude put operation as there's
  a possibility that someone might try to resume the partial copy at a 
  later date.

TEST PLAN
  Unit testing and manual testing done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D10663

REVISION DETAIL
  https://phabricator.kde.org/D18904

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/jobtest.h
  src/core/filecopyjob.cpp
  src/core/filecopyjob.h

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

harald marked 2 inline comments as done.
harald added a comment.


  In D18864#408305 , @dhaumann wrote:
  
  > Hi Harald, nice hearing from you. Patch looks good and can almost go in as 
is. But could you address the two comments and also add a test file for unit 
testing? It can be short, is not required to make sense, and best is also MIT 
licensed.
  
  
  Hi Dominik, thanks so much for the review :) I took the default flatbuffers 
file from their docs as that has most of the keywords/attributes. Their 
documentation is Apache licensed, so I guess this should be OK?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

To: harald, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

D18864: FlatBuffers schema syntax highlighting

[Harald Fernengel]

harald updated this revision to Diff 51331.
harald added a comment.


  Added test, license and highlighting of attributes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18864?vs=51217=51331

BRANCH
  flatbuffers (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18864

AFFECTED FILES
  autotests/folding/test.fbs.fold
  autotests/html/test.fbs.html
  autotests/input/test.fbs
  autotests/reference/test.fbs.ref
  data/syntax/flatbuffers.xml

To: harald, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, cullmann, sars

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 10 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/10/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 17:36:06 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 250 lines...]-- Found LibExiv2: /usr/lib64/libexiv2.so (found suitable version "0.26", minimum required is "0.21") -- Checking for module 'libavcodec>=57.48'--   Found libavcodec, version 58.35.100-- Checking for module 'libavformat>=57.48'--   Found libavformat, version 58.20.100-- Checking for module 'libavdevice>=57.48'--   Found libavdevice, version 58.5.100-- Checking for module 'libavutil>=57.48'--   Requested 'libavutil >= 57.48' but version of libavutil is 56.22.100-- Checking for module 'libswscale>=57.48'--   Requested 'libswscale >= 57.48' but version of libswscale is 5.3.100-- Checking for module 'libpostproc>=57.48'--   Requested 'libpostproc >= 57.48' but version of libpostproc is 55.3.100-- Found FFmpeg: /usr/lib64/libavcodec.so (Required is at least version "57.48") found components:  AVCODEC -- Found FFmpeg: /usr/lib64/libavcodec.so (Required is at least version "57.40") found components:  AVFORMAT -- Found FFmpeg: /usr/lib64/libavcodec.so (Required is at least version "55.27") found components:  AVUTIL -- Performing Test HAVE_AVSTREAM_CODECPAR-- Performing Test HAVE_AVSTREAM_CODECPAR - Success-- Found EPub: /usr/lib64/libepub.so  -- Found xattr-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot -- Found QHelpGenerator executable: /usr/lib64/qt5/bin/qhelpgenerator-- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.-- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.5") -- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have been found: * KF5Archive (required version >= 5.55.0), KDE Frameworks 5: Archive Framework,Archive is needed to build ODF and OOXML 2007 extractors * Poppler (required version >= 0.12.1), A PDF rendering library,Support for PDF files * Taglib (required version >= 1.11.1), Id3 tag reader,Support for music metadata * LibExiv2 (required version >= 0.21), Image metadata support,Support for image metadata * PkgConfig * FFmpeg (required version >= 55.27), Video Tag reader,Support for video metadata * EPub, Ebook epub reader,Support for epub metadata * Qt5Gui (required version >= 5.12.0) * Qt5Widgets (required version >= 5.12.0) * Qt5Sql (required version >= 5.12.0) * Qt5Help * Qt5Core * PythonInterp, Python Interpreter,Python interpreter is needed to execute test for external extractors or writers-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Xml * Gettext * KF5I18n (required version >= 5.55.0) * KF5 (required version >= 5.55.0) * Xattr, library libattr ,Extended attribute shared library * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Test * Qt5 (required version >= 5.10.0)-- The following RUNTIME packages have not been found: * CatDoc, catdoc executable,Extract text from office 98 files - RUNTIME dependency-- The following REQUIRED packages have not been found: * KF5CoreAddons (required version >= 5.55.0), KDE Frameworks 5: Core Addons Framework,Needed for the formatting of properties for display purposesCMake Error at /usr/share/cmake/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:142 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.12/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kfilemetadata » kf5-qt5 WindowsMSVCQt5.11 - Build # 87 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/87/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 10 Feb 2019 17:36:06 +
 Build duration:
34 sec and counting
   CONSOLE OUTPUT
  [...truncated 233 lines...]-- Could not set up the appstream test. appstreamcli is missing.-- Found KF5Archive: C:/CI/Software Installs/kfilemetadata/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.56.0") -- Found KF5: success (found suitable version "5.56.0", minimum required is "5.55.0") found components:  Archive -- Could NOT find KF5CoreAddons (missing: KF5CoreAddons_DIR)-- Could NOT find KF5CoreAddons: found neither KF5CoreAddonsConfig.cmake nor kf5coreaddons-config.cmake -- Could NOT find KF5 (missing: CoreAddons) (Required is at least version "5.55.0")-- Found Gettext: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/msgmerge.exe (found version "0.19.8.1") -- Found KF5I18n: C:/CI/Software Installs/kfilemetadata/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.56.0") -- Found KF5: success (found suitable version "5.56.0", minimum required is "5.55.0") found components:  I18n -- Poppler: Qt5 requires Core-- Found PkgConfig: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/pkg-config.exe (found version "0.29.2") -- Could NOT find Poppler_Core (missing: Poppler_Core_LIBRARY Poppler_Core_INCLUDE_DIR) (found version "")-- Could NOT find Poppler_Qt5 (missing: Poppler_Qt5_LIBRARY Poppler_Qt5_INCLUDE_DIR Poppler_Core_FOUND) (found version "")-- Could NOT find Poppler (missing: Poppler_LIBRARIES Qt5) (Required is at least version "0.12.1")-- Found Taglib: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/include/taglib (Required is at least version "1.11.1") -- Found LibExiv2: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/lib/exiv2.lib (found suitable version "0.25.0", minimum required is "0.21") -- Could NOT find FFmpeg (missing: FFMPEG_LIBRARIES FFMPEG_INCLUDE_DIRS AVCODEC_LIBRARIES AVCODEC_INCLUDE_DIRS AVCODEC) (Required is at least version "57.48")-- Could NOT find FFmpeg (missing: FFMPEG_LIBRARIES FFMPEG_INCLUDE_DIRS AVFORMAT_LIBRARIES AVFORMAT_INCLUDE_DIRS AVFORMAT) (Required is at least version "57.40")-- Could NOT find FFmpeg (missing: FFMPEG_LIBRARIES FFMPEG_INCLUDE_DIRS AVUTIL_LIBRARIES AVUTIL_INCLUDE_DIRS AVUTIL) (Required is at least version "55.27")-- Could NOT find EPub (missing: EPUB_LIBRARIES EPUB_INCLUDE_DIR) -- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Failed-- Performing Test COMPILER_HAS_DEPRECATED-- Performing Test COMPILER_HAS_DEPRECATED - Success-- Found Doxygen: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/dev-utils/bin/doxygen.exe (found suitable version "1.8.14", minimum required is "1.8.13") found components:  doxygen missing components:  dot-- Found QHelpGenerator executable: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/qhelpgenerator.exe-- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.-- Found PythonInterp: C:/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/dev-utils/bin/python.exe (found version "3.6.5") -- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have been found: * KF5Archive (required version >= 5.55.0), KDE Frameworks 5: Archive Framework,Archive is needed to build ODF and OOXML 2007 extractors * Taglib (required version >= 1.11.1), Id3 tag reader,Support for music metadata * PkgConfig * LibExiv2 (required version >= 0.21), Image metadata support,Support for image metadata * Qt5Gui (required version >= 5.11.2) * Qt5Widgets (required version >= 5.11.2) * Qt5Sql (required version >= 5.11.2) * Qt5Help * Qt5Core * PythonInterp, Python Interpreter,Python interpreter is needed to execute test for external extractors or writers-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Xml * Gettext * KF5I18n (required version >= 5.55.0) * KF5 (required version >= 5.55.0) * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Test * Qt5 (required version >= 5.10.0)-- The following RUNTIME packages have not been found: * CatDoc, catdoc executable,Extract text from office 98 files - RUNTIME dependency-- The following OPTIONAL packages have not been found: * Poppler (required version >= 0.12.1), A PDF rendering library,Support for PDF files * FFmpeg (required version >= 55.27), Video Tag reader,Support for video metadata * EPub, Ebook epub reader,Support for epub metadata-- The following REQUIRED packages have not been found: * KF5CoreAddons (required version >= 5.55.0), KDE Frameworks 5: Core Addons Framework,Needed for the formatting of properties for display purposesCMake 

D17245: Add string formatting function to property info

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4bedfd6609c6: Add string formatting function to property 
info (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17245?vs=51271=51330

REVISION DETAIL
  https://phabricator.kde.org/D17245

AFFECTED FILES
  CMakeLists.txt
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h
  src/CMakeLists.txt
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp
  src/propertyinfo.h

To: astippich, broulik, bruns, mgallien, #frameworks
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 10 Feb 2019 17:36:06 +
 Build duration:
19 sec and counting
   CONSOLE OUTPUT
  [...truncated 186 lines...]-- Found LibExiv2: /usr/local/lib/libexiv2.so (found suitable version "0.26", minimum required is "0.21") -- Checking for module 'libavcodec>=57.48'--   Found libavcodec, version 58.35.100-- Checking for module 'libavformat>=57.48'--   Found libavformat, version 58.20.100-- Checking for module 'libavdevice>=57.48'--   Found libavdevice, version 58.5.100-- Checking for module 'libavutil>=57.48'--   Package dependency requirement 'libavutil >= 57.48' could not be satisfied.Package 'libavutil' has version '56.22.100', required version is '>= 57.48'-- Checking for module 'libswscale>=57.48'--   Package dependency requirement 'libswscale >= 57.48' could not be satisfied.Package 'libswscale' has version '5.3.100', required version is '>= 57.48'-- Checking for module 'libpostproc>=57.48'--   Package dependency requirement 'libpostproc >= 57.48' could not be satisfied.Package 'libpostproc' has version '55.3.100', required version is '>= 57.48'-- Found FFmpeg: /usr/local/lib/libavcodec.so (Required is at least version "57.48") found components:  AVCODEC -- Found FFmpeg: /usr/local/lib/libavcodec.so (Required is at least version "57.40") found components:  AVFORMAT -- Found FFmpeg: /usr/local/lib/libavcodec.so (Required is at least version "55.27") found components:  AVUTIL -- Performing Test HAVE_AVSTREAM_CODECPAR-- Performing Test HAVE_AVSTREAM_CODECPAR - Success-- Found EPub: /usr/local/lib/libepub.so  -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.14", minimum required is "1.8.13") found components:  doxygen dot -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator-- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.8") -- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following RUNTIME packages have been found: * CatDoc, catdoc executable,Extract text from office 98 files - RUNTIME dependency-- The following OPTIONAL packages have been found: * KF5Archive (required version >= 5.55.0), KDE Frameworks 5: Archive Framework,Archive is needed to build ODF and OOXML 2007 extractors * Poppler (required version >= 0.12.1), A PDF rendering library,Support for PDF files * Taglib (required version >= 1.11.1), Id3 tag reader,Support for music metadata * LibExiv2 (required version >= 0.21), Image metadata support,Support for image metadata * PkgConfig * FFmpeg (required version >= 55.27), Video Tag reader,Support for video metadata * EPub, Ebook epub reader,Support for epub metadata * Qt5Gui (required version >= 5.12.0) * Qt5Widgets (required version >= 5.12.0) * Qt5Sql (required version >= 5.12.0) * Qt5Help * Qt5Core * PythonInterp, Python Interpreter,Python interpreter is needed to execute test for external extractors or writers-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Xml * Gettext * KF5I18n (required version >= 5.55.0) * KF5 (required version >= 5.55.0) * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Test * Qt5 (required version >= 5.10.0)-- The following REQUIRED packages have not been found: * KF5CoreAddons (required version >= 5.55.0), KDE Frameworks 5: Core Addons Framework,Needed for the formatting of properties for display purposesCMake Error at /usr/local/share/cmake/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:142 (feature_summary)-- Configuring incomplete, errors occurred!See also "/usr/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 FreeBSDQt5.12/build/CMakeFiles/CMakeOutput.log".See also "/usr/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 FreeBSDQt5.12/build/CMakeFiles/CMakeError.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 15 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/15/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Feb 2019 17:36:06 +
 Build duration:
42 sec and counting
   CONSOLE OUTPUT
  [...truncated 250 lines...]-- Found LibExiv2: /usr/lib64/libexiv2.so (found suitable version "0.26", minimum required is "0.21") -- Checking for module 'libavcodec>=57.48'--   Found libavcodec, version 58.35.100-- Checking for module 'libavformat>=57.48'--   Found libavformat, version 58.20.100-- Checking for module 'libavdevice>=57.48'--   Found libavdevice, version 58.5.100-- Checking for module 'libavutil>=57.48'--   Requested 'libavutil >= 57.48' but version of libavutil is 56.22.100-- Checking for module 'libswscale>=57.48'--   Requested 'libswscale >= 57.48' but version of libswscale is 5.3.100-- Checking for module 'libpostproc>=57.48'--   Requested 'libpostproc >= 57.48' but version of libpostproc is 55.3.100-- Found FFmpeg: /usr/lib64/libavcodec.so (Required is at least version "57.48") found components:  AVCODEC -- Found FFmpeg: /usr/lib64/libavcodec.so (Required is at least version "57.40") found components:  AVFORMAT -- Found FFmpeg: /usr/lib64/libavcodec.so (Required is at least version "55.27") found components:  AVUTIL -- Performing Test HAVE_AVSTREAM_CODECPAR-- Performing Test HAVE_AVSTREAM_CODECPAR - Success-- Found EPub: /usr/lib64/libepub.so  -- Found xattr-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- Found Doxygen: /usr/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot -- Found QHelpGenerator executable: /usr/lib64/qt5/bin/qhelpgenerator-- No such target Qt5Core_QCH defined when calling ecm_add_qch(), ignored.-- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.5") -- The following features have been enabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have been found: * KF5Archive (required version >= 5.55.0), KDE Frameworks 5: Archive Framework,Archive is needed to build ODF and OOXML 2007 extractors * Poppler (required version >= 0.12.1), A PDF rendering library,Support for PDF files * Taglib (required version >= 1.11.1), Id3 tag reader,Support for music metadata * LibExiv2 (required version >= 0.21), Image metadata support,Support for image metadata * PkgConfig * FFmpeg (required version >= 55.27), Video Tag reader,Support for video metadata * EPub, Ebook epub reader,Support for epub metadata * Qt5Gui (required version >= 5.10.1) * Qt5Widgets (required version >= 5.10.1) * Qt5Sql (required version >= 5.10.1) * Qt5Help * Qt5Core * PythonInterp, Python Interpreter,Python interpreter is needed to execute test for external extractors or writers-- The following REQUIRED packages have been found: * ECM (required version >= 5.55.0), Extra CMake Modules.,  * Qt5Xml * Gettext * KF5I18n (required version >= 5.55.0) * KF5 (required version >= 5.55.0) * Xattr, library libattr ,Extended attribute shared library * Doxygen (required version >= 1.8.13)   Needed for API dox QCH file generation * QHelpGenerator, Part of Qt5 tools   Needed for API dox QCH file generation * Qt5Test * Qt5 (required version >= 5.10.0)-- The following RUNTIME packages have not been found: * CatDoc, catdoc executable,Extract text from office 98 files - RUNTIME dependency-- The following REQUIRED packages have not been found: * KF5CoreAddons (required version >= 5.55.0), KDE Frameworks 5: Core Addons Framework,Needed for the formatting of properties for display purposesCMake Error at /usr/share/cmake/Modules/FeatureSummary.cmake:459 (message):  feature_summary() Error: REQUIRED package(s) are missing, aborting CMake  run.Call Stack (most recent call first):  CMakeLists.txt:142 (feature_summary)-- Configuring incomplete, errors occurred!See also "/home/jenkins/workspace/Frameworks/kfilemetadata/kf5-qt5 SUSEQt5.10/build/CMakeFiles/CMakeOutput.log".[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D18873: add baloo engine debugging category

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added a comment.


  Also, remove the second paragraph from the summary - a commit message is not 
a TODO list.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  In D18901#409255 , @ngraham wrote:
  
  > From a distance, I wonder if those stationary rotors really connote the 
right thing. How hard would it be to make them look spinning, by replacing them 
with circles instead?
  
  
  I agree. I will experiment with different circles as rotors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added a comment.


  Also, these should only be CCBUG, as it is only an assumption it fixes any of 
these.
  
  Actually, I have seen the database return corrupt data, not caused by a 
failed call, but because the entry did contain garbage.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18894: [RFC] General config interface

[loh tar]

loh.tar added a comment.


  Contrary to my announcement to use an enum as key I chosed the string for 
maximum simplicity. 
  Yes, this way you notice a typo only at runtime, but in any case you have to 
know how some stuff has to be written. An enum key offer not only complile time 
checks but also to use QVector instead of QHash which may be more perfomand but 
need some more effort when add new stuff and probably longer longer keys, 
prefixed by namespace.
  
  My only goal is to get rid of all these tiny functions. But I understand you 
so, that you don't see a need for that.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18894

To: loh.tar, cullmann, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18901: Add device icons for drones

[Nathaniel Graham]

ngraham added a comment.


  From a distance, I wonder if those stationary rotors really connote the right 
thing. How hard would it be to make them look spinning, by replacing them with 
circles instead?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added reviewers: VDG, hein.
trickyricky26 added a subscriber: hein.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D18901: Add device icons for drones

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  drone-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18901

AFFECTED FILES
  icons-dark/devices/16/uav-quadcopter.svg
  icons-dark/devices/16/uav.svg
  icons-dark/devices/22/uav-quadcopter.svg
  icons-dark/devices/22/uav.svg
  icons/devices/16/uav-quadcopter.svg
  icons/devices/16/uav.svg
  icons/devices/22/uav-quadcopter.svg
  icons/devices/22/uav.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18664: Baloo engine: treat every non-success code as a failure

[Stefan Brüns]

bruns added a comment.


  looks almost good to me, can someone else please crosscheck?

INLINE COMMENTS

> documenturldb.h:140
> +qWarning() << "DocumentUrlDB::del"
> +  << "This folder still has 
> sub-files in its cache. It cannot be deleted";
> +}

indentation

> mtimedb.cpp:110
>  rc = mdb_cursor_get(cursor, , , MDB_NEXT_DUP);
> -if (rc == MDB_NOTFOUND) {
> +if (rc) {
> +qCDebug(ENGINE) << "MTimeDB::get (loop)" << mtime << 
> mdb_strerror(rc);

`if  (rc != MDB_NOTFOUND)` for the message

> bruns wrote in postingdb.cpp:232
> not done ... you have to always `mdb_cursor_close`
> 
> Also, MDB_NOTFOUND is not an error here.

For the debug message, level warning is sufficient ;-)

> transaction.cpp:304
> +if (rc) {
> +qCDebug(ENGINE) << "Transaction::commit" << mdb_strerror(rc);
> +}

This should also be a warning IMHO

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18664

To: valeriymalov, #baloo, bruns, poboiko
Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, ashaposhnikov, 
michaelh, astippich, spoorun, abrahams

D18900: Avoid side effects due to stale errno value

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  UserMetaData::hasAttribute and isSupported use errno to check if the
  syscall was successful. This is insufficient, as a succesful syscall
  (return value >= 0) does not reset the errno value.
  
  Also do some minor optimization, there is no need to actually fetch
  the value for hasAttribute/isSupported.

TEST PLAN
  run usermetadatawritertest
  old code fails for added test

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18900

AFFECTED FILES
  autotests/usermetadatawritertest.cpp
  src/xattr_p.h

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/9/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 10 Feb 2019 15:00:41 +
 Build duration:
2 min 12 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3158/3860)48%
(4679/9808)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(864/883)49%
(1873/3805)src75%
(18/24)75%
(18/24)80%
(1060/1328)45%
(477/1058)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/14/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 10 Feb 2019 15:00:41 +
 Build duration:
2 min 14 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(48/55)87%
(48/55)82%
(3158/3860)48%
(4679/9808)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(864/883)49%
(1873/3805)src75%
(18/24)75%
(18/24)80%
(1060/1328)45%
(477/1058)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D18891: Avoid leaking a QObject in ExternalExtractor

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:73d5fbbf5fb0: Avoid leaking a QObject in 
ExternalExtractor (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18891?vs=51298=51316

REVISION DETAIL
  https://phabricator.kde.org/D18891

AFFECTED FILES
  src/externalextractor.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: dhaumann, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18891: Avoid leaking a QObject in ExternalExtractor

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18891

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: dhaumann, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18891: Avoid leaking a QObject in ExternalExtractor

[Stefan Brüns]

bruns added a comment.


  In D18891#409003 , @dhaumann wrote:
  
  > That looks reasonable, if ExtractorPlugin even has `QObject * parent = 
nullptr` I'd even remove nullptr as well.
  
  
  No, no default value ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18891

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: dhaumann, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18895: AsciiDoc: Add folding for sections

[Andreas Gratzer]

andreasgr created this revision.
andreasgr added reviewers: Framework: Syntax Highlighting, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
andreasgr requested review of this revision.

REVISION SUMMARY
  As D18516  is commited now, we can add 
sound folding for sections.
  
  - Add contexts to support section folding in highlighting definition 
`asciidoc.xml`.
  - Update and improve test file `asciidoc.adoc`.
  - Update created `.fold`, `.html` and `.ref` files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18895

AFFECTED FILES
  autotests/folding/asciidoc.adoc.fold
  autotests/html/asciidoc.adoc.html
  autotests/input/asciidoc.adoc
  autotests/reference/asciidoc.adoc.ref
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D18788: Refactor KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e)

[Shubham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b9a52834ec45: Refactor 
KateViewInternal::mouseDoubleClickEvent(QMouseEvent *e) (authored by shubham).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18788?vs=51102=51313

REVISION DETAIL
  https://phabricator.kde.org/D18788

AFFECTED FILES
  src/view/kateviewinternal.cpp

To: shubham, cullmann, dhaumann
Cc: dhaumann, sars, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, cullmann

D18894: [RFC] General config interface

[Dominik Haumann]

dhaumann added a subscriber: mwolff.
dhaumann added a comment.


  This approach spreads they key "Word Wrap Column" across many files. You have 
to know the key and avoid typos. Currently we have this hard-coded and 
therefore statically checked by the compiler, which is very good.
  
  In grneral, I am not against the string based approach in addition to a 
statically checked approach. The string based setter then would take a QVariant 
as value. This way, we would also be close to the KTextEditor::ConfigInterface 
and could have a KTextEditor::Command 'set', i.e. F7: set word-wrap-column 80.
  
  @mwolff Didn't you once propose a template based approach to this?
  
  I have the feeling there are better solutions that perform just as well.
  
  Other comments?
  
  PS: yes, currently we have to write a lot of boilerplate code, but this is 
simple, the code is fast, and the functions are compile time checked.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18894

To: loh.tar, cullmann, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18770: [KStatusNotifierItem] use fallback sizes when none is available

[Pino Toscano]

pino added a subscriber: davidedmundson.
pino added a comment.


  @davidedmundson any idea about this?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D18770

To: pino
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> dhaumann wrote in pdfcreator.cpp:62
> Does this also give nice results with high dpi displays?

KIO Thumbnailer doesn't support high dpi at all at this point.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D18894: [RFC] General config interface

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  
  
  - Remove unneeded bool configIsRunning, add m_ prefix to configSessionNumber
  - Remove unneeded inline keyword
  
  Pro
  
  - Much easier to add new options/settings
  - Less ever the same boring code
  
  Cons
  
  - Slower access
  - Presumably more memory consumption
  
  Notes
  
  - Only three example settings in use, "Word Wrap"/bool, "Word Wrap 
Column"/int and "Indentation Mode"/string
  - No use of enum as key, but const char *, to keep it simple
  - Use Q_ASSERT to avoid wrong written keys
  
  TODO/NeedHelp
  
  - See code comments
  - FIX constness of getter functions
  - Apply in a general way to
- DocumentPrivate::readVariableLine
- KateCommands::CoreCommands
- VariableLineEdit::addKateItems
  - Finish/improve documentation
  
  Questions/Hints
  
  - See code comments
  - Is setting "BackupFlags" really needed?
  - Are all these SomeClass:: get/set functions really needed? e.g: 
DocumentPrivate::wordWrapAt() seems to be unused; 
DocumentPrivate::setWordWrapAt(uint col) effective only 4 times used; Instead 
is often accessed directly by doc->config()->foo(); So perhaps could the way 
over fooClass()->config() be done in general

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18894

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/completion/katecompletionconfig.h
  src/dialogs/katedialogs.cpp
  src/document/editorconfig.cpp
  src/document/katebuffer.cpp
  src/document/katedocument.cpp
  src/render/katerenderer.cpp
  src/utils/kateautoindent.cpp
  src/utils/katecmds.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/variableeditor/variablelineedit.cpp
  src/view/kateviewinternal.cpp

To: loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18873: add baloo engine debugging category

[Laurent Montel]

mlaurent accepted this revision.
mlaurent added a comment.


  Now it's ok for me :)
  Thanks

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18873

To: valeriymalov, #baloo, mlaurent, bruns
Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, abrahams

D18883: Add PDF thumbnailer

[Dominik Haumann]

dhaumann added inline comments.

INLINE COMMENTS

> pdfcreator.cpp:62
> +// Compute a dpi that results in a thumbnail roughly the size we 
> requested
> +const qreal fakeDpiX = width / page->pageSizeF().width() * 72.0;
> +const qreal fakeDpiY = height / page->pageSizeF().height() * 72.0;

Does this also give nice results with high dpi displays?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D18878: Force NT1 protocol when listing smb:// network

[Mikhail Novosyolov]

mikhailnov edited the summary of this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov