D18941: Fix build with cmake 3.5

2019-02-11 Thread Wolfgang Bauer 
wbauer edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18941

To: wbauer
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

2019-02-11 Thread Wolfgang Bauer 
wbauer edited the test plan for this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18941

To: wbauer
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18941: Fix build with cmake 3.5

2019-02-11 Thread Wolfgang Bauer 
wbauer created this revision.
wbauer added a project: Frameworks.
Herald added subscribers: Baloo, kde-frameworks-devel.
Herald added a project: Baloo.
wbauer requested review of this revision.

REVISION SUMMARY
  VERSION_GREATER_EQUAL requires cmake 3.7 or higher.
  So use NOT VERSION_LESS instead, which is logically the same and also works 
with older cmake versions.

TEST PLAN
  Builds fine with cmake 3.5.2 now.
  Before, I got this cmake error:
  
CMake Error at src/extractors/CMakeLists.txt:39 (if):
  if given arguments:

"0.25" "VERSION_GREATER_EQUAL" "0.26"

  Unknown arguments specified

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18941

AFFECTED FILES
  src/extractors/CMakeLists.txt

To: wbauer
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18940: Add battery icons

2019-02-11 Thread Noah Davis 
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

2019-02-11 Thread Noah Davis 
ndavis updated this revision to Diff 51462.
ndavis added a comment.


  Fix missing PositiveText stylesheet for battery-020-charging

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18940?vs=51461&id=51462

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/32/battery-000-charging.svg
  icons-dark/status/32/battery-000.svg
  icons-dark/status/32/battery-010-charging.svg
  icons-dark/status/32/battery-010.svg
  icons-dark/status/32/battery-020-charging.svg
  icons-dark/status/32/battery-020.svg
  icons-dark/status/32/battery-030-charging.svg
  icons-dark/status/32/battery-030.svg
  icons-dark/status/32/battery-040-charging.svg
  icons-dark/status/32/battery-040.svg
  icons-dark/status/32/battery-050-charging.svg
  icons-dark/status/32/battery-050.svg
  icons-dark/status/32/battery-060-charging.svg
  icons-dark/status/32/battery-060.svg
  icons-dark/status/32/battery-070-charging.svg
  icons-dark/status/32/battery-070.svg
  icons-dark/status/32/battery-080-charging.svg
  icons-dark/status/32/battery-080.svg
  icons-dark/status/32/battery-090-charging.svg
  icons-dark/status/32/battery-090.svg
  icons-dark/status/32/battery-100-charging.svg
  icons-dark/status/32/battery-100.svg
  icons-dark/status/32/battery-caution-charging.svg
  icons-dark/status/32/battery-caution.svg
  icons-dark/status/32/battery-empty-charging.svg
  icons-dark/status/32/battery-empty.svg
  icons-dark/status/32/battery-full-charging.svg
  icons-dark/status/32/battery-full.svg
  icons-dark/status/32/battery-good-charging.svg
  icons-dark/status/32/battery-good.svg
  icons-dark/status/32/battery-low-charging.svg
  icons-dark/status/32/battery-low.svg
  icons-dark/status/32/battery-missing.svg
  icons/index.theme
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icon

D18940: Add battery icons

2019-02-11 Thread Noah Davis 
ndavis added a comment.


  Not certain if I've got the `index.theme`s right

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

2019-02-11 Thread Noah Davis 
ndavis updated this revision to Diff 51461.
ndavis added a comment.


  Add `status/32` to `index.theme`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18940?vs=51460&id=51461

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

AFFECTED FILES
  icons-dark/index.theme
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/32/battery-000-charging.svg
  icons-dark/status/32/battery-000.svg
  icons-dark/status/32/battery-010-charging.svg
  icons-dark/status/32/battery-010.svg
  icons-dark/status/32/battery-020-charging.svg
  icons-dark/status/32/battery-020.svg
  icons-dark/status/32/battery-030-charging.svg
  icons-dark/status/32/battery-030.svg
  icons-dark/status/32/battery-040-charging.svg
  icons-dark/status/32/battery-040.svg
  icons-dark/status/32/battery-050-charging.svg
  icons-dark/status/32/battery-050.svg
  icons-dark/status/32/battery-060-charging.svg
  icons-dark/status/32/battery-060.svg
  icons-dark/status/32/battery-070-charging.svg
  icons-dark/status/32/battery-070.svg
  icons-dark/status/32/battery-080-charging.svg
  icons-dark/status/32/battery-080.svg
  icons-dark/status/32/battery-090-charging.svg
  icons-dark/status/32/battery-090.svg
  icons-dark/status/32/battery-100-charging.svg
  icons-dark/status/32/battery-100.svg
  icons-dark/status/32/battery-caution-charging.svg
  icons-dark/status/32/battery-caution.svg
  icons-dark/status/32/battery-empty-charging.svg
  icons-dark/status/32/battery-empty.svg
  icons-dark/status/32/battery-full-charging.svg
  icons-dark/status/32/battery-full.svg
  icons-dark/status/32/battery-good-charging.svg
  icons-dark/status/32/battery-good.svg
  icons-dark/status/32/battery-low-charging.svg
  icons-dark/status/32/battery-low.svg
  icons-dark/status/32/battery-missing.svg
  icons/index.theme
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-010-charging.svg
  icons/status/16/battery-010.svg
  icons/status/16/battery-020-charging.svg
  icons/status/16/battery-020.svg
  icons/status/16/battery-030-char

D18940: Add battery icons

2019-02-11 Thread Noah Davis 
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: kde-frameworks-devel, hein, michaelh, ngraham, bruns

D18940: Add battery icons

2019-02-11 Thread Noah Davis 
ndavis created this revision.
ndavis added reviewers: VDG, hein.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Adds battery icons at 16, 22 and 32 px. Adds `status/32` to `index.theme`. 
Includes symlinks for symbolic icons and standard icon names. Requested by 
@hein for drone control app.

REPOSITORY
  R266 Breeze Icons

BRANCH
  battery-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18940

AFFECTED FILES
  icons-dark/status/16/battery-000-charging.svg
  icons-dark/status/16/battery-000.svg
  icons-dark/status/16/battery-010-charging.svg
  icons-dark/status/16/battery-010.svg
  icons-dark/status/16/battery-020-charging.svg
  icons-dark/status/16/battery-020.svg
  icons-dark/status/16/battery-030-charging.svg
  icons-dark/status/16/battery-030.svg
  icons-dark/status/16/battery-040-charging.svg
  icons-dark/status/16/battery-040.svg
  icons-dark/status/16/battery-050-charging.svg
  icons-dark/status/16/battery-050.svg
  icons-dark/status/16/battery-060-charging.svg
  icons-dark/status/16/battery-060.svg
  icons-dark/status/16/battery-070-charging.svg
  icons-dark/status/16/battery-070.svg
  icons-dark/status/16/battery-080-charging.svg
  icons-dark/status/16/battery-080.svg
  icons-dark/status/16/battery-090-charging.svg
  icons-dark/status/16/battery-090.svg
  icons-dark/status/16/battery-100-charging.svg
  icons-dark/status/16/battery-100.svg
  icons-dark/status/16/battery-caution-charging.svg
  icons-dark/status/16/battery-caution.svg
  icons-dark/status/16/battery-empty-charging.svg
  icons-dark/status/16/battery-empty.svg
  icons-dark/status/16/battery-full-charging.svg
  icons-dark/status/16/battery-full.svg
  icons-dark/status/16/battery-good-charging.svg
  icons-dark/status/16/battery-good.svg
  icons-dark/status/16/battery-low-charging.svg
  icons-dark/status/16/battery-low.svg
  icons-dark/status/16/battery-missing.svg
  icons-dark/status/22/battery-000-charging.svg
  icons-dark/status/22/battery-000.svg
  icons-dark/status/22/battery-010-charging.svg
  icons-dark/status/22/battery-010.svg
  icons-dark/status/22/battery-020-charging.svg
  icons-dark/status/22/battery-020.svg
  icons-dark/status/22/battery-030-charging.svg
  icons-dark/status/22/battery-030.svg
  icons-dark/status/22/battery-040-charging.svg
  icons-dark/status/22/battery-040.svg
  icons-dark/status/22/battery-050-charging.svg
  icons-dark/status/22/battery-050.svg
  icons-dark/status/22/battery-060-charging.svg
  icons-dark/status/22/battery-060.svg
  icons-dark/status/22/battery-070-charging.svg
  icons-dark/status/22/battery-070.svg
  icons-dark/status/22/battery-080-charging.svg
  icons-dark/status/22/battery-080.svg
  icons-dark/status/22/battery-090-charging.svg
  icons-dark/status/22/battery-090.svg
  icons-dark/status/22/battery-100-charging.svg
  icons-dark/status/22/battery-100.svg
  icons-dark/status/22/battery-caution-charging.svg
  icons-dark/status/22/battery-caution.svg
  icons-dark/status/22/battery-empty-charging.svg
  icons-dark/status/22/battery-empty.svg
  icons-dark/status/22/battery-full-charging.svg
  icons-dark/status/22/battery-full.svg
  icons-dark/status/22/battery-good-charging.svg
  icons-dark/status/22/battery-good.svg
  icons-dark/status/22/battery-low-charging.svg
  icons-dark/status/22/battery-low.svg
  icons-dark/status/22/battery-missing.svg
  icons-dark/status/32/battery-000-charging.svg
  icons-dark/status/32/battery-000.svg
  icons-dark/status/32/battery-010-charging.svg
  icons-dark/status/32/battery-010.svg
  icons-dark/status/32/battery-020-charging.svg
  icons-dark/status/32/battery-020.svg
  icons-dark/status/32/battery-030-charging.svg
  icons-dark/status/32/battery-030.svg
  icons-dark/status/32/battery-040-charging.svg
  icons-dark/status/32/battery-040.svg
  icons-dark/status/32/battery-050-charging.svg
  icons-dark/status/32/battery-050.svg
  icons-dark/status/32/battery-060-charging.svg
  icons-dark/status/32/battery-060.svg
  icons-dark/status/32/battery-070-charging.svg
  icons-dark/status/32/battery-070.svg
  icons-dark/status/32/battery-080-charging.svg
  icons-dark/status/32/battery-080.svg
  icons-dark/status/32/battery-090-charging.svg
  icons-dark/status/32/battery-090.svg
  icons-dark/status/32/battery-100-charging.svg
  icons-dark/status/32/battery-100.svg
  icons-dark/status/32/battery-caution-charging.svg
  icons-dark/status/32/battery-caution.svg
  icons-dark/status/32/battery-empty-charging.svg
  icons-dark/status/32/battery-empty.svg
  icons-dark/status/32/battery-full-charging.svg
  icons-dark/status/32/battery-full.svg
  icons-dark/status/32/battery-good-charging.svg
  icons-dark/status/32/battery-good.svg
  icons-dark/status/32/battery-low-charging.svg
  icons-dark/status/32/battery-low.svg
  icons-dark/status/32/battery-missing.svg
  icons/status/16/battery-000-charging.svg
  icons/status/16/battery-000.svg
  icons/status/16/battery-0

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Mikhail Novosyolov 
mikhailnov added a comment.


  I've done some tests in a clean virtual environment, and must say that this 
patch actually does not work, because
  
kioclient5 ls smb:/
  
  does not detect workgroups without setting
  
[global]
client max protocol = NT1
  
  in ~/.smb/smb.conf
  
  I am very sorry, but I did not notice that it was set on my main machine when 
I thought that it works...
  Does any one have ideas?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/15/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Feb 2019 23:11:37 +
 Build duration:
4 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 3 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)56%
(5344/9466)41%
(2115/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)87%
(772/883)49%
(254/522)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)38%
(635/1653)36%
(378/1050)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/22/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Feb 2019 23:11:37 +
 Build duration:
3 min 9 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 2 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5366/9466)41%
(2130/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)90%
(794/883)51%
(268/522)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)38%
(635/1653)36%
(379/1050)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Feb 2019 23:11:37 +
 Build duration:
3 min 1 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtest

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/21/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Feb 2019 22:56:39 +
 Build duration:
4 min 42 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 2 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5366/9466)41%
(2130/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)90%
(794/883)51%
(268/522)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)38%
(635/1653)36%
(379/1050)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Feb 2019 22:57:37 +
 Build duration:
3 min 30 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 3 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)56%
(5344/9466)41%
(2115/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)87%
(772/883)49%
(254/522)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)38%
(635/1653)36%
(378/1050)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%

D17302: Add test for adding properties to result

2019-02-11 Thread Alexander Stippich 
astippich added a comment.


  In D17302#410189 , @bruns wrote:
  
  > Currently, both
  >  `Result::add(prop, "value1"); Result::add(prop, "value2");`
  > and
  >  `Result::add(prop, {"value1", "value2"});`
  >  are serialized (JSON) in the same way as `{prop: ["value1", "value2"]}` by 
Baloo, which is IMHO fine.
  
  
  This can lead to issues if e.g. two ReleaseYears are added from different 
extractors. That is probably impossible right now since KFileMetaData does not 
have multiple extractors for the same mimetype, but still. 
  The result after deserialization is then a QVariantList with the values, and 
probably no client currently handles that since they expect no list.
  IMHO Baloo should not alter the output of KFileMetaData in any way (e.g. 
merging, which it currently relies on for stringlist).
  
  > On the other hand,
  >  `Result::add(prop, "value1"); Result::add(prop, {"value2", "value3"});`
  >  ends up as `{prop: ["value1", ["value2", "value3"] ]}`, which is nonsense, 
should be `{prop: ["value1", "value2", "value3"]}`
  
  I have patches ready for that and was waiting on this revision to land in 
order to continue...
  But as stated above, I also changed my mind, I do not think this is a good 
idea. This can happen if there are two extractors for the same mimetype.
  In that case, the entries may also be duplicated and merging is not a good 
idea.
  
  > After deserializing, we should have `KFM::Propertymap pm.values(prop)` -> 
`QList>({"value1", "value2", "value3"})`.
  > 
  > I am currently moving the serialization (in file/result.cpp) 
/deserialization (in file/file.cpp) into a separate function so it becomes 
testable.
  
  Anyways, the test tests how Baloo::Result _currently_ behaves. If another 
patch then modifies this behavior, the test should be changed when it lands.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 11 Feb 2019 22:53:42 +
 Build duration:
3 min 54 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 3 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtestFailed: projectroot.autotests.unit.file.kinotifytest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)56%
(5344/9466)41%
(2115/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)87%
(772/883)49%
(254/522)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)38%
(635/1653)36%
(378/1050)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 11 Feb 2019 22:53:42 +
 Build duration:
2 min 57 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlcompat_reports/KF5Baloo_compat_report.htmllogs/KF5Baloo/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 2 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 33 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtestFailed: projectroot.autotests.unit.file.filewatchtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report43%
(10/23)60%
(100/168)60%
(100/168)57%
(5366/9466)41%
(2130/5222)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.benchmarks100%
(2/2)100%
(2/2)100%
(58/58)100%
(22/22)autotests.integration100%
(3/3)100%
(3/3)92%
(373/406)76%
(168/220)autotests.unit.codecs100%
(3/3)100%
(3/3)100%
(70/70)64%
(23/36)autotests.unit.engine100%
(17/17)100%
(17/17)100%
(752/752)55%
(212/382)autotests.unit.file91%
(10/11)91%
(10/11)90%
(794/883)51%
(268/522)autotests.unit.lib67%
(4/6)67%
(4/6)87%
(358/411)43%
(80/184)src.codecs100%
(5/5)100%
(5/5)89%
(130/146)76%
(35/46)src.engine95%
(35/37)95%
(35/37)81%
(1732/2146)60%
(688/1151)src.file39%
(15/38)39%
(15/38)38%
(635/1653)36%
(379/1050)src.file.extractor0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/76)src.kioslaves.kded0%
(0/1)0%
(0/1)0%
(0/38)0%
(0/42)src.kioslaves.search0%
(0/1)0%
(0/1)0%
(0/105)0%
(0/32)src.kioslaves.tags0%
(0/1)0%
(0/1)0%
(0/273)0%
(0/223)src.kioslaves.timeline0%
(0/2)0%
(0/2)0%
(0/211)0%
(0/119)src.lib55%
(6/11)55%
(6/11)49%
(464/945)45%
(255/573)src.qml0%
(0/2)0%
(0/2)0%
(0/69)0%

KDE CI: Frameworks » baloo » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Unstable!

2019-02-11 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 11 Feb 2019 22:53:42 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.autotests.unit Failed: 1 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 32 test(s)Failed: projectroot.autotests.unit.file.fileindexerconfigtest

D18830: Handle folders matching substrings of included/excluded folders correctly

2019-02-11 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:97aa68252c4a: Handle folders matching substrings of 
included/excluded folders correctly (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18830?vs=51132&id=51451

REVISION DETAIL
  https://phabricator.kde.org/D18830

AFFECTED FILES
  src/file/fileindexerconfig.cpp
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

2019-02-11 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:24223306d59c: [balooctl] Normalize include/exclude pathes 
before using it for the config (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18829?vs=51131&id=51450

REVISION DETAIL
  https://phabricator.kde.org/D18829

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

2019-02-11 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops, forgot to accept.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17302: Add test for adding properties to result

2019-02-11 Thread Stefan Brüns 
bruns added a comment.


  Currently, both
  `Result::add(prop, "value1"); Result::add(prop, "value2");`
  and
  `Result::add(prop, {"value1", "value2"});`
  are serialized (JSON) in the same way as `{prop: ["value1", "value2"]}` by 
Baloo, which is IMHO fine.
  On the other hand,
  `Result::add(prop, "value1"); Result::add(prop, {"value2", "value3"});`
  ends up as `{prop: ["value1", ["value2", "value3"] ]}`, which is nonsense, 
should be `{prop: ["value1", "value2", "value3"]}`
  
  I am currently moving the serialization (in file/result.cpp) /deserialization 
(in file/file.cpp) into a separate function so it becomes testable.
  
  After deserializing, we should have `KFM::Propertymap pm.values(prop)` -> 
`QList>({"value1", "value2", "value3"})`.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18829: [balooctl] Normalize include/exclude pathes before using it for the config

2019-02-11 Thread Stefan Brüns 
bruns added a comment.


  Ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D18829

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Mikhail Novosyolov 
mikhailnov updated this revision to Diff 51443.
mikhailnov added a comment.


  fixed patch

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18878?vs=51302&id=51443

REVISION DETAIL
  https://phabricator.kde.org/D18878

AFFECTED FILES
  cmake/FindSamba.cmake
  smb/kio_smb_browse.cpp

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18895: AsciiDoc: Add folding for sections

2019-02-11 Thread Dominik Haumann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:54ac6d34a339: AsciiDoc: Add folding for sections 
(authored by dhaumann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18895?vs=51314&id=51442#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18895?vs=51314&id=51442

REVISION DETAIL
  https://phabricator.kde.org/D18895

AFFECTED FILES
  autotests/folding/asciidoc.adoc.fold
  autotests/html/asciidoc.adoc.html
  autotests/input/asciidoc.adoc
  autotests/reference/asciidoc.adoc.ref
  data/syntax/asciidoc.xml

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17302: Add test for adding properties to result

2019-02-11 Thread Alexander Stippich 
astippich added a comment.


  Is this a please don't merge or can I land it?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18933: Send optional events from wl_pointer v5

2019-02-11 Thread Vlad Zagorodniy 
zzag edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Send optional events from wl_pointer v5

2019-02-11 Thread Vlad Zagorodniy 
zzag retitled this revision from "Implement optional events from wl_pointer v5" 
to "Send optional events from wl_pointer v5".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D18933

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18933: Implement optional events from wl_pointer v5

2019-02-11 Thread Vlad Zagorodniy 
zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
zzag requested review of this revision.

REVISION SUMMARY
  So far not all v5 features were implemented because most of them are
  optional. But given that XWayland needs axis_discrete event maybe it's
  time to implement them.

REPOSITORY
  R127 KWayland

BRANCH
  pointer-axis-value-discrete

REVISION DETAIL
  https://phabricator.kde.org/D18933

AFFECTED FILES
  autotests/client/test_wayland_seat.cpp
  src/client/pointer.cpp
  src/client/pointer.h
  src/server/pointer_interface.cpp
  src/server/pointer_interface.h
  src/server/seat_interface.cpp
  src/server/seat_interface.h

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Mikhail Novosyolov 
mikhailnov added a comment.


  Forgot to write that SMB1 is used to list the network, then, when connection 
is done, protocol version must be chosen again automatically, SMB3 is default 
in newest samba.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18901: Add device icons for drones

2019-02-11 Thread Eike Hein 
hein added a comment.


  Thank you! Just what I needed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18901

To: trickyricky26, #vdg, hein, ngraham, rooty
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

2019-02-11 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:b23f4198a22a: ECMGeneratePkgConfigFile API dox: fix 
"Since" for DESCRIPTION arg (authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18913?vs=51370&id=51422

REVISION DETAIL
  https://phabricator.kde.org/D18913

AFFECTED FILES
  modules/ECMGeneratePkgConfigFile.cmake

To: kossebau, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Mikhail Novosyolov 
mikhailnov added a comment.


  In D18878#409822 , @sitter wrote:
  
  > https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/
  >
  > I cannot approve this. It is opening potential security issues, overrides 
sysadmin configs, diverges from sound upstream defaults, goes against advise 
and practises set forth by Microsoft, continues to avoid moving away from a 
deprecated 30 year old protocol.
  
  
  Those who want highest security desiable smb1 on server side, not client. 
Also, don't forget about some old versions of Windows or proprietary NAS. 
Please llet users decide themselves, what is more important for them.
  We don't use SMB1 to connect in this patch, we use it _only_ for listing 
smb://. If you do
  
smbclient -L localhost
  
  you will see:
  
Reconnecting with SMB1 for workgroup listing.
  
  But only smbclient command line utility does it, not libsmbclient.so.0, 
that's why this patch is needed.
  
  In D18878#409931 , @sitter wrote:
  
  > No. This is already unnecessary. If a user requires SMB1 it may be tuned 
via /etc/samba/smb.conf.
  >  And that tuning would never be necessary if we had ws-discovery support I 
think... there is no Windows version which doesn't have ws-discovery and (all?) 
non-windows systems have DNSSD implementations available. So, between 
ws-discovery and dnssd pretty much all systems would be supported.
  >
  > Edit: ...with any possible remainder being up to drop down to SMB1 if the 
system admin finds that necessary
  
  
  I've made this patch mainly to discover Linux machines in the network, and 
Samba has no implementation of ws-discovery. External not common software like 
wsdd https://github.com/christgau/wsdd/ has to be installed (and not properly 
tested network daemons may be a securitry risk without propper isolation like 
chroot).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18380: KIO: make file dialog columns resizable again (and movable)

2019-02-11 Thread Nathaniel Graham 
ngraham added a comment.


  I hope not, but that's the problem with the wall-of-text communication style. 
Eventually people get exhausted and the discussion peters out with nothing 
getting done.
  
  What's the minimum viable change here?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg
Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-02-11 Thread Nathaniel Graham 
ngraham added a comment.


  Yes, obviously this won't work when disk space is limited and we'll need to 
check for that. In this case, I would like the the confirmation dialog to 
actually say to the user that the overwrite operation cannot be canceled 
without destroying the target file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-02-11 Thread David Faure 
dfaure added a comment.


  Your reasoning seems to forget that there is a first confirmation, in case of 
overwriting, in the form of the "Overwrite/Skip/Cancel" dialog?
  
  Otherwise I kind of like the idea, but there's the problem of overwriting a 
4GB file on a 5GB partition... (no space for 4*2 GB temporarily).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18901: Add device icons for drones

2019-02-11 Thread Phabricator 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:d2dce05fa05e: Add device icons for drones (authored by 
Rafael Brandmaier ).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18901?vs=51351&id=51414

REVISION DETAIL
  https://phabricator.kde.org/D18901

AFFECTED FILES
  icons-dark/devices/16/uav-quadcopter.svg
  icons-dark/devices/16/uav.svg
  icons-dark/devices/22/uav-quadcopter.svg
  icons-dark/devices/22/uav.svg
  icons/devices/16/uav-quadcopter.svg
  icons/devices/16/uav.svg
  icons/devices/22/uav-quadcopter.svg
  icons/devices/22/uav.svg

To: trickyricky26, #vdg, hein, ngraham, rooty
Cc: ngraham, hein, kde-frameworks-devel, michaelh, bruns

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Harald Sitter 
sitter added a comment.


  No. This is already unnecessary. If a user requires SMB1 it may be tuned via 
/etc/samba/smb.conf.
  And that tuning would never be necessary if we had ws-discovery support I 
think... there is no Windows version which doesn't have ws-discovery and (all?) 
non-windows systems have DNSSD implementations available. So, between 
ws-discovery and dnssd pretty much all systems would be supported.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Nathaniel Graham 
ngraham added a comment.


  In D18878#409822 , @sitter wrote:
  
  > https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/
  >
  > I cannot approve this. It is opening potential security issues, overrides 
sysadmin configs, diverges from sound upstream defaults, goes against advise 
and practises set forth by Microsoft, continues to avoid moving away from a 
deprecated 30 year old protocol.
  
  
  Will implementing the WS-DISCOVERY protocol allow discovery of old SMB1 
servers too, rendering this unnecessary?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18904: [FileCopyJob] Clean up after file copy operation is cancelled

2019-02-11 Thread Nathaniel Graham 
ngraham added a comment.


  In D18904#409667 , @chinmoyr wrote:
  
  > @ngraham The destination file is corrupted as soon as the user clicks 
overwrite.
  
  
  That's exactly the problem we need to fix.
  
  For example, if the user starts an overwrite by accident and then cancels it, 
their original file in the destination has been destroyed. This is bad. 
Canceling an accidental action should never be destructive.
  
  That's why I'm recommending that for overwrite operations, we don't instantly 
delete or start overwriting the destination file, but rather move or copy the 
source file to a separate location, and //then// overwrite the destination 
file. This preserves the user's ability to cancel the job during the move or 
copy portion of the operation without destroying their own files.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18904

To: chinmoyr, dfaure, dmitrio
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D18878: Force NT1 protocol when listing smb:// network

2019-02-11 Thread Harald Sitter 
sitter added a comment.


  https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/
  
  I cannot approve this. It is opening potential security issues, overrides 
sysadmin configs, diverges from sound upstream defaults, goes against advise 
and practises set forth by Microsoft, continues to avoid moving away from a 
deprecated 30 year old protocol.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18878

To: mikhailnov, #dolphin, #frameworks, sitter, broulik
Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanuelp, 
mikesomov

D18895: AsciiDoc: Add folding for sections

2019-02-11 Thread Andreas Gratzer 
andreasgr added a comment.


  In D18895#409743 , @dhaumann wrote:
  
  > ... Although, adding many RegExprs is slow compared to other rules.
  
  
  I understand that.
  I just don't see how to achieve the needed matches using other rules.
  E.g. a simple string rule using `== ` is not sufficient to correctly match a 
level 1 section title.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18895

To: andreasgr, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18864: FlatBuffers schema syntax highlighting

2019-02-11 Thread Harald Fernengel 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:926feb55fa02: FlatBuffers schema syntax highlighting 
(authored by harald).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18864?vs=51331&id=51398

REVISION DETAIL
  https://phabricator.kde.org/D18864

AFFECTED FILES
  autotests/folding/test.fbs.fold
  autotests/html/test.fbs.html
  autotests/input/test.fbs
  autotests/reference/test.fbs.ref
  data/syntax/flatbuffers.xml

To: harald, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, 
ngraham, bruns, demsking, sars

D18380: KIO: make file dialog columns resizable again (and movable)

2019-02-11 Thread René J . V . Bertin 
rjvbb added a comment.


  So this is just going to become a victim of the better-is-the-enemy-of-good 
principle?
  
  I'm not saying there can be better ways to do this but AFAIC this is already 
pretty good, certainly good enough and even too good in practice to keep me 
from more interesting things to come back and look at other implementations.
  
  So I'm really inclined either to push this in a couple of days in accordance 
with Nate's green light, or else abandon things and keep using my own solution 
until someone else pushes a fix (that suits me just as well).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18380

To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg
Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg

2019-02-11 Thread Christophe Giboudeaux 
cgiboudeaux accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  fixsincelocationfordescription

REVISION DETAIL
  https://phabricator.kde.org/D18913

To: kossebau, cgiboudeaux
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

2019-02-11 Thread cfoster 
cfoster added inline comments.

INLINE COMMENTS

> abalaji wrote in batchrenamejob.cpp:62
> You can just `QString dot = "."`, but you should use a single character 
> instead of a string, since it's just a single character

Without the fromStdString() I get the following compilation error.

src/core/batchrenamejob.cpp:64:15: error: 'QString::QString(const char*)' is 
private within this context

  QString dot= ".";

I must admit I don't fully understand the compilation error however adding 
fromStdString seemed the most reasonable way to fix it.

> abalaji wrote in batchrenamejob.cpp:64
> I wonder if just getting rid of `.toLower()` fixes this bug

I tested just removing the .toLower() however this didn't fix it. It seems that 
QMimeDatabase::suffixForFileName() converts it to lower case unless I 
overlooked something. See the code snippet below.

I tested this with the following lines in a standalone program:
QMimeDatabase db;
QUrl url = (QString) "foo.TXT";
const QString extension = db.suffixForFileName(url.toDisplayString());
qDebug(qUtf8Printable(extension)); //Outputs "txt"

> abalaji wrote in batchrenamejob.cpp:68
> Rather than using `contains` here, you can just use `lastIndexOf`, check if 
> it's not `-1`, and go from there. Just simply `urlStr.lastIndexOf('.')`.

Fair point will do.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns