KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/22/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Feb 2019 05:33:20 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 19 Feb 2019 05:33:21 +
 Build duration:
3 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/14/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 19 Feb 2019 05:33:21 +
 Build duration:
2 min 46 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty updated this revision to Diff 52021.
rooty added a comment.


  Use side view for all three icon versions

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=51970&id=52021

BRANCH
  video-camera-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19056: Tell people they should mostly be using KF5::AuthCore

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:1e3b43bfa0f3: Tell people they should mostly be using 
KF5::AuthCore (authored by aacid).

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19056?vs=51840&id=52019

REVISION DETAIL
  https://phabricator.kde.org/D19056

AFFECTED FILES
  README.md

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19056: Tell people they should mostly be using KF5::AuthCore

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R283 KAuth

BRANCH
  arcpatch-D19056 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19056

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19099: Add a test for ffmpeg extractor

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D19099

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19098: Add PropertyMap to QVariantMap conversion function using names

[Stefan Brüns]

bruns added a comment.


  In D19098#414729 , @astippich 
wrote:
  
  > It already does at two different places, because it fuses different 
information into a single QMap later on (xattr, file size etc...) 
  >  
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
  >  
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62
  
  
  This can be done by using a KFM::PropertyMap directly, and adding property 
types for the UserMetaData (tags, comment, rating). Note, the strings returned 
by PropertyInfo::name() are not shared ...
  
  > I would like to consolidate the two different implementations of the 
conversion functions. I think it is also useful for debugging purposes, e.g. 
dumping a property map to cmd line.
  
  The latter can be achieved by making KFM::Property known to QDebug.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19098

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/32/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 22:06:27 +
 Build duration:
7 min 41 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19109: [Extractor] Add metadata to extractors

[Stefan Brüns]

bruns added a comment.


  In D19109#414758 , @astippich 
wrote:
  
  > A few general remarks:
  >
  > - I really do not like that there are two lists of supported mimetypes now 
which have to be kept in sync
  
  
  I think this is trivial enough. Also this is covered by the unit test.
  
  > - Do we really need versioning per mimetype? IMHO it is sufficient to have 
a version number per extractor. From my experience, fixing an extractor usually 
impacts all its supported mimetypes, and rarily affects only one mimetype.
  
  Past experience tells otherwise. There have been feature extensions and 
bugfixes for specific mimetypes, just look at your own commits
  
  - "fix ape disc number extraction"
  - "implement more tags for asf metadata"
  - ...
  
  I want to reduce reindexing as much as possible.
  
  >   Also, this makes the list hard to maintain, also regarding file types 
which have multiple mime types, e.g. audio/wav and audio/x-wav
  > 
  > - Do we need an x.y version? I think a single integer is enough or what do 
you have in mind?
  
  Changes only affecting failed files are minor versions, changes affecting 
already indexed files (i.e. support for new properties) get a new major version.
  
  > - I prefer to directly construct the qvariantmap in the extractors, and 
re-use the mimetype list which is already available.
  
  Requires changing the plugin interface. Does not allow to query extractor 
properties without fully loading the plugin (which is expensive). Read 
https://vizzzion.org/blog/2013/08/ "K_PLUGIN_FACTORY_WITH_JSON or where is the 
metadata?"

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19109

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D18849: [KPropertiesDialog] Fix group combobox

[Christoph Feck]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:2bba2c0795d7: [KPropertiesDialog] Fix group combobox 
(authored by cfeck).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18849?vs=51180&id=52017

REVISION DETAIL
  https://phabricator.kde.org/D18849

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: cfeck, #frameworks, #dolphin, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

[Jos van den Oever]

vandenoever updated this revision to Diff 52015.
vandenoever added a comment.


  - Remove VALUE define.
  - Spelling fix.

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19107?vs=51933&id=52015

BRANCH
  utf8

REVISION DETAIL
  https://phabricator.kde.org/D19107

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigini.cpp

To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

[Jos van den Oever]

vandenoever added inline comments.

INLINE COMMENTS

> dfaure wrote in kconfigtest.cpp:1774
> What's the purpose of this very short-lived define, compared to just inlining 
> this into the next line?

Right, copy-paste leftover. I'll fix it.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

[Jos van den Oever]

vandenoever added a reviewer: thiago.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

[David Faure]

dfaure added a comment.


  No objection from me, but I'm no utf-8 expert.
  
  Thiago's input would be very valuable...

INLINE COMMENTS

> kconfigtest.cpp:1774
> +#endif
> +#define VALUE 
> "v1=Téléchargements\nv2=$¢ह€𐍈\nv3=\\xc2\\xe0\\xa4\\xf0\\x90\\x8d"
> +QCOMPARE(fileBytes, QByteArrayLiteral("[General]\n" VALUE "\n"));

What's the purpose of this very short-lived define, compared to just inlining 
this into the next line?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol, #frameworks
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham added a task: T10325: 5.16 Login screen redesign.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: cullmann, KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This patch is very similar to D17949  but 
in this state not a full replacement for that.
  
  Here is some core function touched which need some watchfulness to make it 
not even worse.
  Here is the existing behavior what will wrapped without a selection not 
changed.
  With this patch could be D17949  
simplified or perhaps their extra features added here.
  
  This patch has in static wrap mode the potential to re-wrap the paragraph 
nicely on-the-fly, similar to dynamic wrap, whereas without this patch only the 
current line is wrapped, but not the following, with the result that the 
paragraph became cluttered or the preceding line with the result that the 
paragraph became not optimal wrapped in some situations.
  
  Looking at other code parts indicate that this behavior is/was desired but 
seems to got lost at sometime. See also D19051 
, which looks with this patch obsolete.
  
  - The "auto-rewrap" can only work when the text is fresh entered, not after 
some load from disk. Doing a join of the paragraph should trigger the needed 
change
  - The old wrapText function is now split in three functions
  - The new wrapLine function is very close to old code but some variables are 
renamed
  
  Two main issues which needs to be fixed
  
  - Based on TextLine::isAutoWrapped. This info gets lost when you undo some 
change
  - The cursor is sometimes misplaced, see pic where the x was DELeted and 
should be now in line 1 in the middle of the 
  
  F6622028: pic.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19131

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h

To: loh.tar, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/13/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Feb 2019 19:44:02 +
 Build duration:
6 min 46 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a dependent revision: D19129: [sddm-theme] Apply new username 
prompt and user list icons.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/21/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 18 Feb 2019 19:40:19 +
 Build duration:
5 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13330)18%
(1817/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(299/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/12/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Feb 2019 19:33:20 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 19:35:59 +
 Build duration:
5 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/20/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 18 Feb 2019 19:33:20 +
 Build duration:
6 min 58 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13330)18%
(1818/9850)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2253)7%
(96/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1415/3501)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(673/1570)29%
(300/1032)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2013)18%
(310/1713)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 19:33:20 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3b88babfed6c: [breeze-icons] Use new suspend, hibernate 
and switch user icons in Breeze icon… (authored by rooty).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51996&id=52002

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414802 , @ngraham wrote:
  
  > I love it. Looks perfect to me now.
  
  
  Thanks :D Will be landing it shortly

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  I love it. Looks perfect to me now.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I love it. Looks perfect to me now.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51997.
rooty added a comment.


  Use more integers

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51993&id=51997

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51996.
rooty added a comment.


  Make all the Z's bigger

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51986&id=51996

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414750 , @ngraham wrote:
  
  > Or they could all be a bit bigger, and the snowflake versions could simply 
take up a teensy bit more of the snowflake's top-right corner.
  
  
  Yeah I made all the Z's bigger, it should be better now

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19109: [Extractor] Add metadata to extractors

[Alexander Stippich]

astippich added a comment.


  A few general remarks:
  
  - I really do not like that there are two lists of supported mimetypes now 
which have to be kept in sync
  - Do we really need versioning per mimetype? IMHO it is sufficient to have a 
version number per extractor. From my experience, fixing an extractor usually 
impacts all its supported mimetypes, and rarily affects only one mimetype. 
Also, this makes the list hard to maintain, also regarding file types which 
have multiple mime types, e.g. audio/wav and audio/x-wav
  - Do we need an x.y version? I think a single integer is enough or what do 
you have in mind?
  - I prefer to directly construct the qvariantmap in the extractors, and 
re-use the mimetype list which is already available.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19109

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51993.
rooty added a comment.


  Make Z's larger

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51985&id=51993

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  Or they could all be a bit bigger, and the snowflake versions could simply 
take up a teensy bit more of the snowflake's top-right corner.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19099: Add a test for ffmpeg extractor

[Alexander Stippich]

astippich marked an inline comment as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in ffmpegextractortest.cpp:45
> I find it somewhat difficult to grasp `Title` is 
> KFileMetaData::Property::Title. 
> You can use something like:
> 
>   namespace KFMProp = KFileMetaData::Property;
>   ...
>   ... value(KFMProp::Title).toString()

In that case, just using Property::X is probably best

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19099

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19099: Add a test for ffmpeg extractor

[Alexander Stippich]

astippich updated this revision to Diff 51990.
astippich added a comment.


  - emphasize test properties

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19099?vs=51915&id=51990

BRANCH
  ffmpeg_tests

REVISION DETAIL
  https://phabricator.kde.org/D19099

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ffmpegextractortest.cpp
  autotests/ffmpegextractortest.h
  autotests/samplefiles/test.webm

To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19098: Add PropertyMap to QVariantMap conversion function using names

[Alexander Stippich]

astippich added a comment.


  It already does at two different places, because it fuses different 
information into a single QMap later on (xattr, file size etc...) 
  
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/extractor.cpp$65
  
https://phabricator.kde.org/source/baloo-widgets/browse/master/src/filefetchjob.cpp$62
  I would like to consolidate the two different implementations of the 
conversion functions. I think it is also useful for debugging purposes, e.g. 
dumping a property map to cmd line.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19098

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  F6621821: image.png 
  
  I'm gonna edit system.svgz too, for consistency's sake

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414687 , @ngraham wrote:
  
  > Getting there! I'm not sure the shadow on the top handle works though.
  
  
  Fixed it
  
  F6621810: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  Just for the smaller versions.
  
  Yes, let's add Hibernate too.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414706 , @ngraham wrote:
  
  > That could work, yeah. Give it a try!
  
  
  22 px or 32 px too?
  
  Because the 32 px version matches the desktop theme 32 px version as is
  
  P.S. What about hibernate? I don't have that icon in Kickoff but other people 
might?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414687 , @ngraham wrote:
  
  > Getting there! I'm not sure the shadow on the top handle works though.
  
  
  Oh that's just inkscape being difficult - that's not supposed to be there 
hahaha

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  That could work, yeah. Give it a try!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty added a comment.


  In D19074#414689 , @ngraham wrote:
  
  > The Zs look a bit small in Kickoff and especially Kicker when using a 
non-high-DPI display:
  >
  > F6621746: Screenshot_20190218_105639.png 

  >
  > F6621748: Screenshot_20190218_105747.png 

  >
  > We might need to simplify the icons for the small sizes and/or make the Zs 
bigger.
  
  
  What about just two (big) Z's?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Krešimir Čohar]

rooty updated this revision to Diff 51986.
rooty added a comment.


  Resize 22 px switch user icon

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19074?vs=51910&id=51986

BRANCH
  arcpatch-D19074

REVISION DETAIL
  https://phabricator.kde.org/D19074

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/22/system-switch-user.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons-dark/actions/32/system-switch-user.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/22/system-switch-user.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg
  icons/actions/32/system-switch-user.svg

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19074: [breeze-icons] Use new suspend, hibernate and switch user icons in Breeze icon theme

[Nathaniel Graham]

ngraham added a comment.


  The Zs look a bit small in Kickoff and especially Kicker when using a 
non-high-DPI display:
  
  F6621746: Screenshot_20190218_105639.png 

  
  F6621748: Screenshot_20190218_105747.png 

  
  We might need to simplify the icons for the small sizes and/or make the Zs 
bigger.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19074

To: rooty, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  I actually did resize this one too because you can never be quite sure which 
22 px icon will be used hahahah
  And I grazed the top margin a little bit but I actually managed to stay 
within all the other margins

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Nathaniel Graham]

ngraham added a comment.


  Getting there! I'm not sure the shadow on the top handle works though.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51985.
rooty added a comment.


  Resize 22 px switch user icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51982&id=51985

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Actually those concerns should be in the icon theme patch, never mind.
  
  I'm good with this now! Thoughts, other #vdg 
 people? Shall we land this?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham added a comment.


  Oh and one more minor thing: the Zs look a bit small in Kickoff and 
especially Kicker when using a non-high-DPI display:
  
  F6621746: Screenshot_20190218_105639.png 

  
  F6621748: Screenshot_20190218_105747.png 

  
  I guess the moon and snowflake iconography will have to hold the line :)
  
  The new switch user also doesn't seem to handle being scaled down very well. 
Can we make it a tiny bit bigger if it's not already at the edge of its margins?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51982.
rooty added a comment.


  Remove second filled in user from 22 px switch user icon

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51954&id=51982

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D19020: [breeze-icons] Revamp system.svgz

[Nathaniel Graham]

ngraham added a comment.


  Almost perfect! I have one remaining visual nitpick:
  
  F6621734: Black.png 
  
  Can we make the small version of the switch user icon have a body that's not 
filled in with Shade Black? That way it will match the small versions of all 
the icons user-style icons, all of which have outline bodies and black heads.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  More progress. How's this
  
  F6621740: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19107: Write valid UTF8 characters without escaping.

[Nathaniel Graham]

ngraham added a reviewer: Frameworks.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol, #frameworks
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D19107

To: vandenoever, dfaure, arichardson, apol
Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Nathaniel Graham]

ngraham added a comment.


  In D18986#414641 , @rooty wrote:
  
  > F6621699: image.png 
  >
  > This is a rough draft of what a side view 64 px version would look like 
with a microphone on top (I can't stand film reels in icons, sorry...)
  
  
  Nice, that's much better than the previous side version!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414635 , @ngraham wrote:
  
  > I will admit that the current head-on view is more attractive than the 
previous side view version. :)
  
  
  Tongue in cheek :D
  Which size are you talking about though? The monochrome ones or the color one?
  
  P.S.
  F6621699: image.png 
  
  This is a rough draft of what a side view 64 px version would look like with 
a microphone on top (I can't stand film reels in icons, sorry...)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19005: android: don't default to gcc anymore

[Volker Krause]

vkrause added a comment.


  In D19005#414313 , @apol wrote:
  
  > In D19005#412258 , @vkrause 
wrote:
  >
  > > Actually having tested this, "deprecated_value" looks wrong there, 
shouldn't this be "default_value"?
  >
  >
  > no, the value is coming from the cache, so that's the one we're setting. 
What this patch tries to make sure is that we don't forward an empty value 
(resetting a proper variable to "").
  
  
  ah, that makes more sense, no idea why that seemed to break things here then 
though

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19005

To: apol, #frameworks, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Nathaniel Graham]

ngraham added a comment.


  I will admit that the current head-on view is more attractive than the 
previous side view version. :) But I still worry about recognizability. Here's 
what the icon will look like in Kamoso, for example: F6621676: Video.png 

  
  Regardless, let's remove the plasma logo and replace it with the common 
mountain-and-sun scene from `viewimage`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Filip Fila]

filipf added a comment.


  It's perhaps not the most used video camera design, but I'm cool with this. I 
too wouldn't use the Plasma icon; it makes more sense to put some multimedia 
icon there.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  In D18986#414602 , @ngraham wrote:
  
  > Doesn't that logic also apply to a head-on-view icon for a video camera? 
It's not re-using the familiarity people generally have with the very common 
side-view video camera icons. A search on flaticon turns up the following, for 
example:
  
  
  I don't know. Using a head-on view might make the icon more consistent with 
the rest of //Plasma// (not what people generally use and are familiar with).
  F6621663: image.png 
  
  Using an icon with the video camera in profile will require us to either 
break consistency with the other camera icons or change the other icons to 
accommodate the new video camera icon.
  
  Most searches turn up this
  
  F6621642: image.png 
  but at the same time turn up something along the lines of
  
  F6621647: image.png 
  
  If you're okay with the inconsistency, I can do a side view. But there 
definitely is an inconsistency.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D19098: Add PropertyMap to QVariantMap conversion function using names

[Stefan Brüns]

bruns added a comment.


  Why would we want to use a QVariantMap in baloo-widgets, and not a 
KFM::PropertyMap?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19098

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Aleix Pol Gonzalez]

apol added a comment.


  Should they really be joined? It seems like this will fail with more than one 
url.
  
  I'd suggest changing arrayToList to provide quoted urls.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D18853

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19094: Use KCM name in KCM header

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:a4041266241f: Use KCM name in KCM header (authored by 
GB_2).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19094?vs=51906&id=51977

REVISION DETAIL
  https://phabricator.kde.org/D19094

AFFECTED FILES
  src/kcmultidialog.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/31/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 16:26:51 +
 Build duration:
8 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18952: new find module for Canberra

[Harald Sitter]

sitter updated this revision to Diff 51976.
sitter added a comment.


  fix bad copy paste in compat setup

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18952?vs=51952&id=51976

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18952

AFFECTED FILES
  docs/find-module/FindCanberra.rst
  find-modules/FindCanberra.cmake

To: sitter, cgiboudeaux
Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/30/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 16:15:26 +
 Build duration:
8 min 16 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D19020: [breeze-icons] Revamp system.svgz

[Filip Fila]

filipf added a comment.


  I think the current revision is quite nice. We could always pick apart 
details and other potential solutions, but the icons get the point across and 
look good.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns

D18883: Add PDF thumbnailer

[Stefan Brüns]

bruns added a comment.


  In D18883#414517 , @broulik wrote:
  
  > However, you will get a Dr Konqi each time it encounters that file as it 
will try to generate a thumbnail for it every time you open the folder.
  
  
  Shouldn't this be covered somehow by
  
https://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-0.8.0.html#FAILURES

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, 
alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, 
emmanuelp, mikesomov

D18986: [breeze-icons] Add video camera icons

[Nathaniel Graham]

ngraham added a comment.


  In D18986#414556 , @rooty wrote:
  
  > I don't know... I've been mulling this over for the last couple of days 
and... I'm //not// sold on the side view, because any variant of a side view 
will look broadly different from the other camera icons we already have
  
  
  Doesn't that logic also apply to a head-on-view icon for a video camera? It's 
not re-using the familiarity people generally have with the very common 
side-view video camera icons. A search on flaticon turns up the following, for 
example:
  
  F6621602: Screenshot_20190218_091751.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18725: properly attempt to locate the kioslave bin in $libexec AND $libexec/kf5

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d14f77b87dbe: properly attempt to locate the kioslave bin 
in $libexec AND $libexec/kf5 (authored by sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18725?vs=50849&id=51975

REVISION DETAIL
  https://phabricator.kde.org/D18725

AFFECTED FILES
  src/core/slave.cpp

To: sitter, davidedmundson, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty updated this revision to Diff 51970.
rooty added a comment.


  Use head-on versions of the 16 px and 22 px icons

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18986?vs=51636&id=51970

BRANCH
  video-camera-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18986

AFFECTED FILES
  icons-dark/devices/16/camera-video.svg
  icons-dark/devices/22/camera-video.svg
  icons-dark/devices/64/camera-video.svg
  icons/devices/16/camera-video.svg
  icons/devices/22/camera-video.svg
  icons/devices/64/camera-video.svg

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18986: [breeze-icons] Add video camera icons

[Krešimir Čohar]

rooty added a comment.


  I don't know... I've been mulling this over for the last couple of days 
and... I'm //not// sold on the side view, because any variant of a side view 
will look broadly different from the other camera icons we already have 
(probably because it's harder to flatten a side view and get away with it the 
way you can with a head-on view ?).
  
  For example,
  F6621526: image.png 
  We'd basically have to redo all of them.
  
  So I've decided to change just the 16/22 px icons to make them head-on - it 
looks a lot better when you take the camera-photo icon into consideration:
  
  F6621553: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns

D18793: Handle text completion with block selection mode

[Ahmad Samir]

ahmadsamir added a comment.


  Ping?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18793

To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop
Cc: kde-frameworks-devel, kwrite-devel, #ktexteditor, gennad, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19111: Have ShareFileItemAction provide an output or an error if they are provided

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> menu.cpp:84
>  });
> +connect(this, &Menu::finished, this, [this]{ qDebug() << "omgomgomg" << 
> this; });
>  }

Is this necessary? If so, maybe it should have a more descriptive string...

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D19111

To: apol, #dolphin, #frameworks, nicolasfella
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/23/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 18 Feb 2019 14:16:30 +
 Build duration:
5 min 33 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3286/4010)48%
(4797/10090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(901/920)49%
(1986/4031)src76%
(19/25)76%
(19/25)80%
(1151/1441)43%
(482/1114)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/18/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Feb 2019 14:16:30 +
 Build duration:
4 min 37 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yaml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(49/56)88%
(49/56)82%
(3286/4010)48%
(4797/10090)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)98%
(901/920)49%
(1986/4031)src76%
(19/25)76%
(19/25)80%
(1151/1441)43%
(482/1114)src.extractors100%
(13/13)100%
(13/13)75%
(1176/1564)47%
(2258/4784)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> lbeltrame wrote in externalextractor.cpp:120
> Will this block anything?

At most 3 seconds (non gui task), also see the waitforfinished below ...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19108

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19108: [ExternalExtractor] Provide more helpful output when extractor fails

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:36dafc3cb668: [ExternalExtractor] Provide more helpful 
output when extractor fails (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19108?vs=51935&id=51965

REVISION DETAIL
  https://phabricator.kde.org/D19108

AFFECTED FILES
  src/externalextractor.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D18883: Add PDF thumbnailer

[Kai Uwe Broulik]

broulik added a comment.


  However, you will get a Dr Konqi each time it encounters that file as it will 
try to generate a thumbnail for it every time you open the folder.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D19110: Don't show the tooltip when the drop-down menu is shown

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:368ed3bf3df8: Don't show the tooltip when the 
drop-down menu is shown (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19110?vs=51937&id=51959

REVISION DETAIL
  https://phabricator.kde.org/D19110

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, #frameworks, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19110: Don't show the tooltip when the drop-down menu is shown

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19110

To: apol, #kirigami, #frameworks, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Krešimir Čohar]

rooty closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  gamepad-icon-16-22-px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19030: Add 16 px and 22 px versions of the gamepad icon to devices/

[Eike Hein]

hein added a comment.


  LGTM, thanks!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19030

To: rooty, hein, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty added a comment.


  In D19020#414339 , @ndavis wrote:
  
  > That last little square in the username bothers me.
  
  
  If only I could use text/lettering...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty updated this revision to Diff 51954.
rooty added a comment.


  Remove second square from username bar

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19020?vs=51938&id=51954

BRANCH
  user-prompt-list-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19020

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svgz

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D19020: [breeze-icons] Revamp system.svgz

[Krešimir Čohar]

rooty edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, ngraham, 
bruns

D18952: new find module for Canberra

[Harald Sitter]

sitter updated this revision to Diff 51952.
sitter added a comment.


  - pkgconfig is now quiet
  - variables are now camelcase
- old variables are still set for compat
  - new imported target (also sets pkgconfig's cflags, which I presume is the 
sane thing to do)
  - set package description url & description

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18952?vs=51576&id=51952

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18952

AFFECTED FILES
  docs/find-module/FindCanberra.rst
  find-modules/FindCanberra.cmake

To: sitter, cgiboudeaux
Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18952: new find module for Canberra

[Harald Sitter]

sitter marked 5 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18952

To: sitter, cgiboudeaux
Cc: aacid, apol, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19001: katetextbuffer: refactor TextBuffer::save() to better separate code paths

[Matthias Gerstner]

mgerstner updated this revision to Diff 51951.
mgerstner added a comment.


  Use a C++11 enum class with KDE style CamelCase identifiers.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19001?vs=51662&id=51951

REVISION DETAIL
  https://phabricator.kde.org/D19001

AFFECTED FILES
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h

To: mgerstner, dhaumann, cullmann, #ktexteditor, chinmoyr, fvogt
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18957: Use natural sorting in ActivityModel

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R6:b344bc2e3468: Use natural sorting in ActivityModel 
(authored by davidedmundson).

REPOSITORY
  R6 KActivities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18957?vs=51497&id=51948

REVISION DETAIL
  https://phabricator.kde.org/D18957

AFFECTED FILES
  src/imports/activitymodel.h
  src/lib/activitiesmodel_p.h

To: davidedmundson, #plasma, ngraham
Cc: apol, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 197 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/197/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 18 Feb 2019 10:03:49 +
 Build duration:
6 min 4 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 196 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/196/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 18 Feb 2019 09:55:37 +
 Build duration:
8 min 3 sec and counting

D19075: Fix FindEGL

[Ben Cooksley]

bcooksley added a comment.


  If someone could please trigger all of the Dependency Builds for FreeBSD once 
this has been landed that would be appreciated: 
https://build.kde.org/view/Failing/

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19075

To: tcberner, #automotive, hausmann, #freebsd, apol
Cc: bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18853: Fix sharing files with spaces or quotes in names via Telegram

[Mikhail Rudenko]

mikhailru added a comment.


  ping

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D18853

To: mikhailru, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns