KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/55/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 16 Mar 2019 04:44:50 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32897/60429)39%
(17117/44396)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4370/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8417/14403)51%
(4749/9335)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)55%
(4353/7987)40%
(1917/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 41 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/41/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 16 Mar 2019 04:44:50 +
 Build duration:
9 min 28 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5KIO-5.57.0.xmlcompat_reports/KF5KIO_compat_report.htmllogs/KF5KIO/5.57.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/398)66%
(264/398)54%
(32905/60436)39%
(17123/44399)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9279/9720)48%
(4371/9113)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8432/14411)51%
(4759/9338)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4350/7987)40%
(1914/4777)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(556/1055)39%
(346/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1304/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/59/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sat, 16 Mar 2019 04:44:50 +
 Build duration:
7 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18845: authority: add support for passing details to polkit

[Stefan Brüns]

bruns added a comment.


  LGTM - @fvogt , @chinmoyr  ?

REVISION DETAIL
  https://phabricator.kde.org/D18845

To: mgerstner, #frameworks, chinmoyr, fvogt, bruns
Cc: mati865, kde-frameworks-devel

D19762: Only get clearTextPath when used

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D19762

To: broulik, #frameworks, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R373 Image Thumbnailers

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 77 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/77/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Mar 2019 22:32:18 +
 Build duration:
6 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(231/299)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(190/243)58%
(95/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 54 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/54/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 Mar 2019 22:32:18 +
 Build duration:
5 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(231/299)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(190/243)58%
(95/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 85 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/85/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Mar 2019 22:32:18 +
 Build duration:
2 min 0 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

D19602: [KParts] Fix compilation for Qt 5.13

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R306:3f3c760d7f52: [KParts] Fix compilation for Qt 5.13 
(authored by matthieugras, committed by mlaurent).

REPOSITORY
  R306 KParts

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19602?vs=53396=53976

REVISION DETAIL
  https://phabricator.kde.org/D19602

AFFECTED FILES
  src/browserrun.cpp

To: matthieugras, apol, mlaurent
Cc: mlaurent, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19795: Add Variable interface to KTextEditor::Editor

[Dominik Haumann]

dhaumann added a comment.


  What I wonder is whether we really need the "Variable" class. Maybe it would 
be better to just have
  
  - registerExactMatch(QString name, QString description, function)
  - registerPrefixMatch(QString prefix, QString description, function)
  
  If such a change would be preferred, then I can easily change the patch.
  
  ...and as the unit test currently shows, recursive macro expansion is not 
supported, but I think it's needed for e.g. %{JS: bla %{...} : %[...}}.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19795

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19795: Add Variable interface to KTextEditor::Editor

[Dominik Haumann]

dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.

REVISION SUMMARY
  The Variable interface allows to register either exact matches
  of the form %{Document:Text} or prefix matches of the form
  %{Date:} where the text after the colon (separator) is passed
  to the evaluation of the variable.
  
  This functionality is required for the External Tools plugin,
  that will use this interface to do its macro expansion.
  
  A unit test demonstrates a bit how it works.
  
  Some possible/fictive examples:
  
  - %{CurrentDocument:Text} evaluates to documents contents
  - %{UUID} evaluates to a random uuid
  - %{Time:hh-mm} evaluates to 17-35
  
  Currently, none of these variables are added, it's just the
  interface.

TEST PLAN
  make && make test

REPOSITORY
  R39 KTextEditor

BRANCH
  variable-interface

REVISION DETAIL
  https://phabricator.kde.org/D19795

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/src/variable_test.cpp
  autotests/src/variable_test.h
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/editor.h
  src/include/ktexteditor/variable.h
  src/utils/kateglobal.h
  src/utils/katemacroexpander.cpp
  src/utils/katemacroexpander.h
  src/utils/ktexteditor.cpp

To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19784: Avoid calling QT_LSTAT and accessing recent documents

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> recentusagemodel.cpp:261
>  
>  if (!url.isValid() || !(fileItem.isFile() || fileItem.isDir())) {
>  return QVariant();

How do you expect isFile() and isDir() to work without a QT_LSTAT call?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D19787#431712 , @apol wrote:
  
  > Does this solve the fluffy bunny issue?
  
  
  Yes, both approaches solve the broken rendering for Fluffy Bunny, as they 
both prevent width/height to be set to 0. Given the fuzzy nature of the border 
samples it is not that important whether full sample copies are used or if the 
last is only shown partially.  Also if stretched/squashed a bit they look still 
okay. But that is due to the nature of this theme.
  
  > Otherwise it could be that the theme needs adapting to tell plasma to 
repeat the pattern instead of stretching it.
  
  No, tiling already happens as it should (that's also why this code is 
reached).

INLINE COMMENTS

> apol wrote in framesvgitem.cpp:148
> Makes sense to me. Should we also use qRound?

qRound would mean that samples are also stretched beyond their original size if 
rounding up is done, right? In that case the pixel quality might be an issue 
perhaps.
Though the max variations then would be only half as much off from the original 
sample, which seems attractive indeed.

For the stretching needs I smell this could get input from the fractional 
resolution experts, to know if oversampling better also gets support for 
higher-resolution samples.

Seems this really depends on the nature of the look, and for the case of 
stretching with full sample copies one might provide a higher resolution 
sample, to keep quality.
I sense one could really would want another hint flag. Time to draft another 
theme where full copies are interesting. Where are pages with some Greek/Roman 
meander patterns to get inspired? :)

Makes me wonder how complex this should get and if theme authors actually 
really need all such options :)

Possibly the best for now is to just keep the existing behaviour, but limit to 
the minimum 1.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19787

To: kossebau, #plasma, mart
Cc: apol, sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

[loh tar]

loh.tar added a comment.


  For me is your distinction between Find/Search not very intuitive. But OK, in 
terms of HIG may that somehow a wanted subtlety. Filter on the other hand is 
something else, yes, and here not fitting. So "Find..." in both cases.
  
  Not answered are the questions about the removed label and if triple dots are 
bad, OK or in any case to substitute by true a ellipsis. Well, the latter I 
asked elsewhere T10258#178907 .
  
  All these Q/A should be added as examples to the HIG 
https://hig.kde.org/style/writing/placeholder.html

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> recentusagemodel.cpp:254
> +// return any useful information for our purposes here.
> +url.setScheme(QString());
> +KFileItem fileItem(url);

This looks very much like a workaround. How about adding an argument to the 
KFileItem to skip the stat if it's a desirable behaviour?

> recentusagemodel.cpp:277
> +// We want MatchMode mode = MatchExtension
> +if (url.scheme() == "file") {
> +url.setScheme(QString());

url.isLocalFile()

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

[Aleix Pol Gonzalez]

apol added a comment.


  Does this solve the fluffy bunny issue?
  Otherwise it could be that the theme needs adapting to tell plasma to repeat 
the pattern instead of stretching it.

INLINE COMMENTS

> framesvgitem.cpp:148
>  if (m_border == FrameSvg::TopBorder || m_border == 
> FrameSvg::BottomBorder || m_border == FrameSvg::NoBorder) {
> -textureRect.setWidth(nodeRect.width() / 
> m_elementNativeSize.width());
> +textureRect.setWidth((qreal)nodeRect.width() / 
> m_elementNativeSize.width());
>  }

Makes sense to me. Should we also use qRound?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19787

To: kossebau, #plasma, mart
Cc: apol, sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D19783: [kitemview] compile without foreach

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> kwidgetitemdelegatepool.cpp:136
> +const auto lst = d->widgetInIndex.keys();
> +for (QWidget *widget : lst) {
>  const QAbstractProxyModel *proxyModel = qobject_cast QAbstractProxyModel *>(d->delegate->d->model);

This one clearly should be using iterators instead of foreach

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D19783

To: mlaurent, dfaure
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19696: Add blender thumbnailer

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 53971.
chinmoyr added a comment.


  Removed unused headers.

REPOSITORY
  R373 Image Thumbnailers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19696?vs=53848=53971

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19696

AFFECTED FILES
  CMakeLists.txt
  blend/CMakeLists.txt
  blend/blendercreator.cpp
  blend/blendercreator.h
  blend/blenderthumbnail.desktop

To: chinmoyr, #frameworks, bruns
Cc: bruns, ngraham, broulik, ltoscano, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, 
mikesomov

D19771: Use placeholder instead of label

[Nathaniel Graham]

ngraham added a comment.


  That's different. "Filter" actually hides non-matched entries. "Find" 
highlights them while keeping the context and surrounding content.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D19533: Don't crash on malformed syntax highlighting files

[Dāvis Mosāns]

davispuh updated this revision to Diff 53970.
davispuh added a comment.


  Also check for present formats

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19533?vs=53237=53970

BRANCH
  malformed

REVISION DETAIL
  https://phabricator.kde.org/D19533

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: davispuh, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Nathaniel Graham]

ngraham added a comment.


  Yep, I always do.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 added a comment.


  In D19733#431693 , @ngraham wrote:
  
  > So now this happens:
  >
  > F6693594: Weird.gif 
  >
  > Does the category Icon in System Settings itself need to be updated too?
  
  
  Did you clear your cache?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19791: Make KFontRequester consistent

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0c04c4c8c450: Make KFontRequester consistent (authored by 
GB_2).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19791?vs=53968=53969#toc

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19791?vs=53968=53969

REVISION DETAIL
  https://phabricator.kde.org/D19791

AFFECTED FILES
  src/kfontrequester.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Nathaniel Graham]

ngraham added a comment.


  So now this happens:
  
  F6693594: Weird.gif 
  
  Does the category Icon in System Settings itself need to be updated too?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19791: Make KFontRequester consistent

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  make-kfontrequester-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19791

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D19786: Fix WebDAV directory renaming if KeepAlive is off

[Nathaniel Graham]

ngraham added reviewers: Frameworks, Dolphin, dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19786

To: hoffmannrobert, #frameworks, #dolphin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19784: Avoid calling QT_LSTAT and accessing recent documents

[Nathaniel Graham]

ngraham added reviewers: Frameworks, dfaure, Dolphin.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19784

To: hoffmannrobert, #frameworks, dfaure, #dolphin
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19771: Use placeholder instead of label

[Christoph Feck]

cfeck added a comment.


  In D19771#431674 , @ngraham wrote:
  
  > - "Find" is limited to items in the current view only, and usually pertains 
to text.
  
  
  I prefer the term "Filter" for this. If there is no filter, you see 
everything, if there is a filter, you only see the items that match. No 
additional search is performed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Nathaniel Graham]

ngraham added a comment.


  "Find" and "search" are different things. Broadly:
  
  - "Find" is limited to items in the current view only, and usually pertains 
to text.
  - "Search" is anything broader than that.
  
  So for this, "Find" is the appropriate term.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars, dhaumann

D19791: Make KFontRequester consistent

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Make the KFontRequester widget consistent with the new font selection style 
in the Fonts KCM.
  F6693555: Consistent KFontRequester.png 

TEST PLAN
  Open the GTK Application Style KCM.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  make-kfontrequester-consistent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19791

AFFECTED FILES
  src/kfontrequester.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Méven Car]

meven added a comment.


  glibc 2.28 was released in August 2018, it is at least in (k)ubuntu 18.10, 
and I would expect in most other distros as well.
  I would be happy to help test this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin, fvogt
Cc: huftis, dakon, fvogt, kde-frameworks-devel, bruns, meven, ltoscano, 
#frameworks, michaelh, ngraham

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

[Friedrich W. H. Kossebau]

kossebau added a comment.


  An alternative approach might be to do instead
  
//if tiling horizontally
if (m_border == FrameSvg::TopBorder || m_border == FrameSvg::BottomBorder 
|| m_border == FrameSvg::NoBorder) {
textureRect.setWidth(qMax(1, nodeRect.width() / 
m_elementNativeSize.width()));
}
//if tiling vertically
if (m_border == FrameSvg::LeftBorder || m_border == FrameSvg::RightBorder 
|| m_border == FrameSvg::NoBorder) {
textureRect.setHeight(qMax(1, nodeRect.height() / 
m_elementNativeSize.height()));
}
  
  i.e. to use `1` as minimum, and continue to use full multiples. That might 
help potential themes where the subparts should properly align on the subpart 
borders (think something like sine wave), at the cost of having things being 
shrunk to fit.
  
  Both solutions are fine for the Fluffy Bunny theme :)
  
  Perhaps something to control via another flag? :P

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19787

To: kossebau, #plasma, mart
Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

[Friedrich W. H. Kossebau]

kossebau added a subscriber: sitter.
kossebau added a comment.


  I have to admit I am not exactly sure what this code does (being a noob to 
openGL), so my assumptions about the effects I saw by try & error might be 
wrong. Thus please check properly someone who understands this code.
  
  Broken rendering before:
  F6693268: Screenshot_20190315_152615.png 

  
  Find old copy of Fluffy Bunny here to test yourself:
  https://share.kde.org/s/RZenX3xAxsoapMM (thanks to @sitter)
  broken for panels, but otherwise works at least to test this.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19787

To: kossebau, #plasma, mart
Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns

D19787: FrameSvgItem: fix textureRect for tiled subitems to not shrink to 0

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The old logic results in broken rendering if the sample was bigger than the
  area to render, due to normalized texture rect being 0 in the respective
  dimansion. As well as stretched mapping of the sample for fractional
  relationships between the area to render and the sample size.

TEST PLAN
  Borders of backgrounds of FluffyBunny theme render properly, no other
  regressions seen (but unsure what else might rely on that artifact).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixtilingtexture

REVISION DETAIL
  https://phabricator.kde.org/D19787

AFFECTED FILES
  src/declarativeimports/core/framesvgitem.cpp

To: kossebau, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19786: Fix WebDAV directory renaming if KeepAlive is off

[Robert Hoffmann]

hoffmannrobert created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Reset m_request.isKeepAlive to true if responseCode == 301
  during renaming a directory. Otherwise the connection is gone
  and renaming fails, if the server is configured 'KeepAlive off'.
  
  After sending the not quite correct request 'MOVE dirurl'
  without trailing '/', an Apache webserver answers with a
  redirection (301) providing the correct dirurl with trailing
  '/'. But in this case the session is not reset, so if the
  server sets isKeepAlive to false the connection is ended
  too early.

TEST PLAN
  - Configure an Apache http server providing WebDAV and set KeepAlive to 'off'.
  - In dolphin, navigate to webdav://webdavserver/ and try to rename a 
directory there.
  - Without this patch the connection to webdavserver is broken (error message) 
and renaming fails, with this patch applied it works.

REPOSITORY
  R241 KIO

BRANCH
  fix_webdav_rename_directory

REVISION DETAIL
  https://phabricator.kde.org/D19786

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: hoffmannrobert
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19785: DocumentPrivate: Review del/backspace

[loh tar]

loh.tar added a comment.


  This patch is the byproduct of some playing with RTL text, Bug 385694. 
  But a sane solution may need some more effort, so I tend to not offer my 
current state of that playing.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19785: DocumentPrivate: Review del/backspace

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Avoid bad selection in some case of undo in block mode
  - Don't try to expand selection in block mode when cursor is in col 0 on 
backspace
  - Improve/fix documentation
  - Code cosmetic

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19785

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[loh tar]

loh.tar added subscribers: ngraham, loh.tar.
loh.tar added a comment.


  > So the change in Search and replace need to be reverted.
  
  That should @ngraham decide. See also 
https://phabricator.kde.org/T10258#178907
  
  I would badly suggest to use in both cases the same term, "Find" or "Search".
  
  Should it be keep as shown above, I suggest to remove the unneeded space left 
from the input fields in power mode, so that it fit to the left edge and looks 
like the normal mode GUI.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, gennad, domson, 
michaelh, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/84/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 15 Mar 2019 12:48:37 +
 Build duration:
50 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 53 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/53/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 15 Mar 2019 12:48:37 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 76 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/76/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 15 Mar 2019 12:48:37 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.dupe
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)84%
(252/299)64%
(117/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)73%
(41/56)56%
(10/18)autotests100%
(5/5)100%
(5/5)87%
(211/243)65%
(107/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 140 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/140/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 15 Mar 2019 12:48:37 +
 Build duration:
6 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

D19783: [kitemview] compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R276 KItemViews

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19783

AFFECTED FILES
  CMakeLists.txt
  src/kcategorizedview.cpp
  src/kextendableitemdelegate.cpp
  src/ktreewidgetsearchline.cpp
  src/kwidgetitemdelegate.cpp
  src/kwidgetitemdelegatepool.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:d0b4c3f2545f: Add preferences-desktop-theme-applications 
and preferences-desktop-theme… (authored by GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19733?vs=53936=53949

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-applications.svg
  icons-dark/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons/preferences/32/preferences-desktop-theme-applications.svg
  icons/preferences/32/preferences-desktop-theme-windowdecorations.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19602: [KParts] Fix compilation for Qt 5.13

[Matthieu Gras]

matthieugras added a comment.


  In D19602#431385 , @mlaurent wrote:
  
  > Ping  do you want that we commit for you ?
  >  Otherwise I will do it as I need this patch.
  
  
  Yes please, go ahead

REPOSITORY
  R306 KParts

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19602

To: matthieugras, apol, mlaurent
Cc: mlaurent, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19779: point readme to the wiki page

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the wiki page says the readme is duplicated into the wiki.
  
  so, what we end up with is either
  
  - they end up out of sync
  - someone gets real angry because the wiki needs format markup while the 
readme must not have markup
  - someone doesn't get angry and simply copies either markup or nomarkup to 
the respectively unsuitable target
  
  it's an unsustainable situation... so instead let's point the readme to
  the wiki and consider that the place where the documentation is maintained

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19779

AFFECTED FILES
  src/kconf_update/README.kconf_update

To: sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19767: Fix malloc/delete mismatch

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> aacid wrote in kio_sftp.cpp:446
> Use ssh_string_free_char ?

+1

"The caller needs to free the memory using ssh_string_free_char()."

http://api.libssh.org/stable/group__libssh__sftp.html#gab4860a441da019060f78c8d236d9ec91

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19767

To: hallas, #frameworks, dfaure, sitter
Cc: aacid, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D19733

REVISION DETAIL
  https://phabricator.kde.org/D19733

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D19778: [kitemmodels] make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  make it compile without foreach

TEST PLAN
  autotest ok

REPOSITORY
  R275 KItemModels

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19778

AFFECTED FILES
  CMakeLists.txt
  autotests/proxymodeltestsuite/dynamictreemodel.cpp
  autotests/proxymodeltestsuite/modeleventlogger.cpp
  autotests/proxymodeltestsuite/modeleventlogger.h
  autotests/proxymodeltestsuite/modelspy.cpp
  autotests/proxymodeltestsuite/modelspy.h
  autotests/proxymodeltestsuite/proxymodeltest.cpp
  autotests/proxymodeltestsuite/proxymodeltest.h
  autotests/test_model_helpers.h
  src/kbreadcrumbselectionmodel.cpp
  src/kcheckableproxymodel.cpp
  src/kconcatenaterowsproxymodel.cpp
  src/kdescendantsproxymodel.cpp
  src/kextracolumnsproxymodel.cpp
  src/klinkitemselectionmodel.cpp
  src/kmodelindexproxymapper.cpp
  src/krecursivefilterproxymodel.cpp
  src/kselectionproxymodel.cpp
  tests/proxymodeltestapp/breadcrumbswidget.cpp
  tests/proxymodeltestapp/kreparentingproxymodel.cpp
  tests/proxymodeltestapp/matchcheckingwidget.cpp
  tests/proxymodeltestapp/modelcommanderwidget.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19733: Add preferences-desktop-theme-applications and preferences-desktop-theme-windowdecorations icons

[Björn Feber]

GB_2 updated this revision to Diff 53936.
GB_2 added a comment.


  Use old style for preferences-desktop-theme-windowdecorations

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19733?vs=53883=53936

BRANCH
  arcpatch-D19733

REVISION DETAIL
  https://phabricator.kde.org/D19733

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-applications.svg
  icons-dark/preferences/32/preferences-desktop-theme-windowdecorations.svg
  icons/preferences/32/preferences-desktop-theme-applications.svg
  icons/preferences/32/preferences-desktop-theme-windowdecorations.svg

To: GB_2, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns