D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Albert Astals Cid]

aacid added a comment.


  That not ideal, ki18n should be usable for projects that don't use widgets 
too.
  
  I'd say the bug is on the calling cmake side, if it has a ui file it must 
surely depend on widgets on the calling side, so just add it there?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20008: Fix uninitialized value in SimpleJobPrivate

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  The patch is OK, but the commit message is scarier than the truth. There is 
no actual use of an uninitialized value in practice. Please add "compiler 
warning" to the commit log.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20008

To: mpyne, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20008: Fix uninitialized value in SimpleJobPrivate

[Michael Pyne]

mpyne created this revision.
mpyne added reviewers: dfaure, Frameworks, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mpyne requested review of this revision.

REVISION SUMMARY
  As reported in bug 404474 , GCC 
gives a warning about using an uninitialized value in KIO.
  
  The relevant portion of code is:
  
FileOperationType opType;
switch (command) {
case CMD_DEL:
opType = Delete;
break;
case CMD_RENAME:
opType = Rename;
break;
case CMD_SYMLINK:
opType = Symlink;
break;
}
job->d_func()->m_operationType = opType;
 
  
  `command` in this case is an `int` and there's no other checks here to let 
the compiler know that `command` could only be one of those three values. 
There's a comment here but even I don't know whether the comment discusses what 
*should* be true or what *is* actually checked elsewhere.
  
  Since even I was confused I don't blame the compiler. So I add a default 
branch that just returns the job unmodified. There may be a better error 
condition here.

TEST PLAN
  Builds, installs, KIO-using software works fine still.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20008

AFFECTED FILES
  src/core/job_p.h

To: mpyne, dfaure, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54640.
knauss added a comment.


  remove BLACKLSIT for httpcheck

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54639=54640

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/blacklist.list
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54639.
knauss added a comment.


  add httpupdate and split out blacklist file

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54617=54639

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/blacklist.list
  kde-modules/httpcheck.py
  kde-modules/httpupdate.py

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss added a comment.


  In D19996#436824 , @winterz wrote:
  
  > this would be a nice addition to Krazy.  on my todo list.
  
  
  we are actually planing to push the list of blacklisted matches to a single 
file, so other scripts can take the list too.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kprocesslist.h:56
> + */
> +KProcessList GetProcessList();
> +

This method should follow the Qt naming style, i.e. `processList()`.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[David Edmundson]

davidedmundson added a comment.


  To give a context for people who haven't seen the prior conversation.
  
  Right now kdevelop (optionally) pulls in libksysguard from plasma to show a 
simple process list, which isn't ideal. 
  We're not technically API stable and we'll go to Qt6 at a different time.
  
  A patch wants to add this in solid (and originally wanted to pull in 
libksysguard) which I've rejected because of the complicated dependency.
  
  We also have 2 other uses in plasma that use libksysguard just to get the 
name of a PID.
  
  I don't want to make libksysguard a framework as it's way too heavy for these 
usecases, it reads a billion /proc files populating a whole table full of stats 
and comes with a widgets dependency.
  
  IMHO a simpler portable process list of PID + name will be useful

INLINE COMMENTS

> hallas wrote in CMakeLists.txt:246
> Should util/kprocesslist.h also be added here?

yes

> hallas wrote in kprocesslist.h:1
> Is this license ok?

I think so, someone who's into licenses probably should check

> hallas wrote in kprocesslist.h:36
> I modified the interface slightly so that it fits better with other KDE APIs, 
> I don't know what you guys think about it?

Generally fine, I would put the method in a namespace

> kprocesslist.h:41
> + */
> +struct KProcessInfo {
> +unsigned int pid; ///< The pid of the process

This isn't future proof.

We probably need something with Pimpl (maybe a implicitly shared class)

> hallas wrote in kprocesslist.h:42
> I changed the pid to be a unsigned int instead, since both Windows and Unix 
> use a number as the pid

Needs to be qint64 to cover windows

> hallas wrote in kprocesslist.h:43
> What is the exact semantics of this field?

Reading the code back this is:

the full command line if available (full /proc/$pid/cmdline)
 failing that the executable name (/proc/$pid/stat) 
 failing that the executable name (from ps)

(I have no idea about windows)

> hallas wrote in kprocesslist.h:45
> Do we really need this? Should we document all the valid states?

Definitely needs some docs. An enum might be better when we figure out what we 
want.

(or maybe just kill it?)

> hallas wrote in kprocesslist.h:56
> Is this the interface we want?

Based on the use cases I've seen I think we want:

KProcessList GetProcessList(); <-- for the kdevelop etc case

KProcess GetProcess(qint64 pid); <-- for the device manager / plasma vaults case

> hallas wrote in kprocesslist.h:56
> I haven't written any tests for the code as I am not sure how I can do that 
> in a portable and reproduceable way.

As for unit tests, maybe something like:

- spawn an app with qprocess
- find it in the list

We'll know the PID from qprocess, we know our own user id, we know the name

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19876: Fix: apply correctly the text colors of the chosen scheme

[Dominik Haumann]

dhaumann added a comment.


  I think such a workaround is ok, but the real issue here is that KTextEditor 
does not fully use the KSyntaxHighlighting Theme colors. Instead, it still has 
its own configuration, such that hacks like this are introduced to somehow make 
it work. But it's just a matter of time until it breaks again.
  
  Any other comments?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19876

To: nibags, #ktexteditor, #kate
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D19974: Add extensions to groovy highlighting

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19974

To: apushnov, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D20007: Add GetProcessList for retrieving the list of currently active processes

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> CMakeLists.txt:246
>util/kformat.h
>util/kuser.h
>util/kshell.h

Should util/kprocesslist.h also be added here?

> kprocesslist.h:1
> +/**
> +**

Is this license ok?

> kprocesslist.h:36
> +#include 
> +
> +/**

I modified the interface slightly so that it fits better with other KDE APIs, I 
don't know what you guys think about it?

> kprocesslist.h:42
> +struct KProcessInfo {
> +unsigned int pid; ///< The pid of the process
> +QString name; ///< The name of the process - this is not the full path 
> to the executable

I changed the pid to be a unsigned int instead, since both Windows and Unix use 
a number as the pid

> kprocesslist.h:43
> +unsigned int pid; ///< The pid of the process
> +QString name; ///< The name of the process - this is not the full path 
> to the executable
> +QString image; ///< What is this?

What is the exact semantics of this field?

> kprocesslist.h:44
> +QString name; ///< The name of the process - this is not the full path 
> to the executable
> +QString image; ///< What is this?
> +QString state; ///< Running state - should we have this?

This appears to be a Windows only field, should we really keep this?

> kprocesslist.h:45
> +QString image; ///< What is this?
> +QString state; ///< Running state - should we have this?
> +QString user; ///< Owner of the process

Do we really need this? Should we document all the valid states?

> kprocesslist.h:56
> + */
> +KProcessList GetProcessList();
> +

Is this the interface we want?

> kprocesslist.h:56
> + */
> +KProcessList GetProcessList();
> +

I haven't written any tests for the code as I am not sure how I can do that in 
a portable and reproduceable way.

> kprocesslist_win.cpp:1
> +/**
> +**

I do not have access to a Windows PC so I haven't built the Windows version

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D20007

To: hallas, davidedmundson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20007: Add GetProcessList for retrieving the list of currently active processes

[David Hallas]

hallas created this revision.
hallas added reviewers: davidedmundson, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Add GetProcessList for retrieving the list of currently active
  processes. This code is taken from:
  https://github.com/KDAB/GammaRay/blob/master/launcher/ui/processlist.h
  and modified slightly to better suit the needs of KDE.

REPOSITORY
  R244 KCoreAddons

BRANCH
  adds_kprocesslist (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20007

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/util/kprocesslist.h
  src/lib/util/kprocesslist_unix.cpp
  src/lib/util/kprocesslist_win.cpp

To: hallas, davidedmundson, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[t-ask]

taskf added a comment.


  Hmm, still I somehow like the stroked version, while I wouldn't recommend 
using it this particular case. Even the transparent version can easily be 
controlled the `disabled` state of this icon object. Currently, I think it 
would be good to add both icons to Breeze iconset, just in case there is 
another use case for it some day. I added all the other mockups I did just to 
let you know.
  F6716206: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Alexander Potashev]

aspotashev added a comment.


  I'm not sure about this because
  
  1. Not a find_package() guru
  2. We may need to add Qt5Widgets as a new dependency of ki18n. For now ki18n 
won't pull qtwidgets, and your projects may fail compiling which is not very 
developer-friendly.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

[Alexander Potashev]

aspotashev created this revision.
aspotashev added a reviewer: Frameworks.
aspotashev added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aspotashev requested review of this revision.

REVISION SUMMARY
  If I have
  
find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUIRED)
  
  in CMakeLists.txt, cmake failed with the following error:
  
get_target_property() called with non-existent target "Qt5::uic".
  
  referencing the following line in KF5I18nMacros.cmake:
  
get_target_property(QT_UIC_EXECUTABLE Qt5::uic LOCATION)

TEST PLAN
  Run cmake on a project with the following lines:
  
find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUIRED)
ki18n_wrap_ui(foo_SRCS bar.ui)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D20005

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: aspotashev, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19811: Add Smali syntax highlighting file

[Dāvis Mosāns]

davispuh updated this revision to Diff 54631.
davispuh added a comment.


  Reduce size of test file

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19811?vs=54120=54631

BRANCH
  smali

REVISION DETAIL
  https://phabricator.kde.org/D19811

AFFECTED FILES
  autotests/folding/test.smali.fold
  autotests/html/test.smali.html
  autotests/input/test.smali
  autotests/reference/test.smali.ref
  data/syntax/smali.xml

To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Arvid Hansson]

arvidhansson added a comment.


  In D19952#436834 , @taskf wrote:
  
  > There is one issue I'm not sure about. The user might feel pressured to 
check something if the symbol is stroked as it fells like "something is wrong". 
In that case I would suggest just using the ON version and make it 50% 
transparent in OFF mode.
  
  
  I agree, it isn't  even an caps-lock-off key.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

[Kurt Hindenburg]

hindenburg added a comment.


  There's a FOREACH still in the macpoller.cpp file

REPOSITORY
  R274 KIdleTime

REVISION DETAIL
  https://phabricator.kde.org/D19318

To: mlaurent, dfaure
Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[t-ask]

taskf added a comment.


  There is one issue I'm not sure about. The user might feel pressured to check 
something if the symbol is stroked as it fells like "something is wrong". In 
that case I would suggest just using the ON version and make it 50% transparent 
in OFF mode.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

[Dominik Haumann]

dhaumann added a comment.


  Looks good to me. Anyone else?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D1

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[t-ask]

taskf added a comment.


  Here is another try with rounded corners to mimik a keyboard key. To me the 
stroke is not that a of problem if it goes the other direction, as it feels 
more natural. Right handed people would probably stroke something that way than 
it is done with traffic signs or is it something else I need to consider?
  F6715635: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: arvidhansson, #vdg, ndavis
Cc: taskf, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Allen Winter]

winterz added a comment.


  this would be a nice addition to Krazy.  on my todo list.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, 
michaelh, ngraham, bruns

D19992: Update URLs to use https

[Yuri Chornoivan]

yurchor accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19992

To: vkrause, yurchor
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19992: Update URLs to use https

[Volker Krause]

vkrause updated this revision to Diff 54626.
vkrause added a comment.


  Update build from source link.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19992?vs=54600=54626

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19992

AFFECTED FILES
  cmake/FindPerlModules.cmake
  common/en/kde-default.css
  docs/meinproc5/man-meinproc5.1.docbook
  docs/qt5options/man-qt5options.7.docbook
  src/customization/en/entities/install-compile.docbook
  src/customization/en/entities/install-intro.docbook
  src/customization/en/entities/update-doc.docbook
  src/template.docbook

To: vkrause
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in KDECMakeSettings.cmake:189
> PythonInterp is also not a solution :) See 6c1db934e 
>  
> in ki18n.
> 
> CMake 3.5.0 was found acceptable for most frameworks, it would be nice to 
> make it work with this version.

ugh, I see... so how could we solve this here? run find_package in the ecm 
cmakelists.txt and configure_file the python exe path into a wrapper for the 
python script?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D1

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, 
vkrause.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D1

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19999: Fix endRegion folding in rules with beginRegion+endRegion (use length=0)

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 405585
  
  There is a problem of folding in rules with beginRegion + endRegion.
  
  Example:
  
xml

  
  In this case, the "hello" string is part of the "region1" and "region2" 
regions simultaneously, which generates folding problems. The ideal behavior is 
that "hello" isn't part of "region1", but of "region2". That is, don't publish 
length of endRegion folding in rules with beginRegion+endRegion.
  
  The following XML files use rules with beginRegion + endRegion:
  
ansforth94.xml apparmor.xml asciidoc.xml asp.xml c.xml cisco.xml 
desktop.xml fortran.xml
haml.xml ini.xml isocpp.xml julia.xml lex.xml lua.xml makefile.xml perl.xml 
pony.xml
rhtml.xml rpmspec.xml ruby.xml template-toolkit.xml txt2tags.xml yacc.xml

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  folding-endRegion-beginRegion

REVISION DETAIL
  https://phabricator.kde.org/D1

AFFECTED FILES
  autotests/folding/Makefile.fold
  autotests/folding/folding.cpp.fold
  autotests/folding/highlight.asp.fold
  autotests/folding/highlight.cpp.fold
  autotests/folding/highlight.f90.fold
  autotests/folding/highlight.lex.fold
  autotests/folding/highlight.pl.fold
  autotests/folding/highlight.pony.fold
  autotests/folding/highlight.prg.fold
  autotests/folding/highlight.rb.fold
  autotests/folding/highlight.spec.fold
  autotests/folding/highlight.t2t.fold
  autotests/folding/highlight.y.fold
  autotests/folding/test.desktop.fold
  autotests/folding/test.ini.fold
  autotests/folding/usr.bin.apparmor-profile-test.fold
  autotests/html/test.desktop.html
  autotests/input/test.desktop
  autotests/reference/test.desktop.ref
  src/lib/abstracthighlighter.cpp

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54617.
knauss added a comment.


  search for http://\S
  
  and update blacklist.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54615=54617

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> vkrause wrote in KDECMakeSettings.cmake:189
> Right, the feature is just silently ignored in older versions. We can 
> probably switch that to PythonIterp if we want this for older versions as 
> well. But let's first see if this approach actually works and if people will 
> access getting that test forced upon them :)

PythonInterp is also not a solution :) See 6c1db934e 
 in 
ki18n.

CMake 3.5.0 was found acceptable for most frameworks, it would be nice to make 
it work with this version.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Volker Krause]

vkrause added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in KDECMakeSettings.cmake:189
> FindPython3.cmake only exists in CMake >= 3.12.0

Right, the feature is just silently ignored in older versions. We can probably 
switch that to PythonIterp if we want this for older versions as well. But 
let's first see if this approach actually works and if people will access 
getting that test forced upon them :)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54615.
knauss added a comment.


  add more excludes.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54613=54615

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19876: Fix: apply correctly the text colors of the chosen scheme

[Nibaldo González]

nibags updated this revision to Diff 54614.
nibags added a comment.


  - Add some comments

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19876?vs=54404=54614

BRANCH
  fix-schemas

REVISION DETAIL
  https://phabricator.kde.org/D19876

AFFECTED FILES
  src/schema/kateschema.cpp
  src/syntax/katehighlight.cpp

To: nibags, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54613.
knauss added a comment.


  update http regex

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54612=54613

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Sandro Knauß]

knauss updated this revision to Diff 54612.
knauss added a comment.


  update python script.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19996?vs=54611=54612

BRANCH
  arcpatch-D19996

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> KDECMakeSettings.cmake:189
>  
> +find_package(Python3 COMPONENTS Interpreter QUIET)
> +function(httpcheck)

FindPython3.cmake only exists in CMake >= 3.12.0

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D19996

To: vkrause
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This is supposed to trigger a unit test failure when using http: rather
  than https: URLs. This is obviously imperfect, so it has support for
  module or line specific overrides. This should also not get enabled by
  default as long as this basically triggers everywhere.
  
  The Python script is from Sandro, the CMake integration and URI blacklist
  from me.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19996

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/httpcheck.py

To: vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19974: Add extensions to groovy highlighting

[Aleksei Pushnov]

apushnov updated this revision to Diff 54602.
apushnov added a comment.


  Updated groovy.xml version from 5 to 6

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19974?vs=54559=54602

REVISION DETAIL
  https://phabricator.kde.org/D19974

AFFECTED FILES
  data/syntax/groovy.xml

To: apushnov, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars

D19992: Update URLs to use https

[Yuri Chornoivan]

yurchor added a comment.


  Thanks in advance for fixing the Techbase link.

INLINE COMMENTS

> install-compile.docbook:4
>  For information on how to compile and install  
> -applications visit the http://techbase.kde.org/;>
> +applications visit the https://techbase.kde.org/;>
>   Techbase

Moved from techbase to community: 
https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source

> install-compile.docbook:5
> +applications visit the https://techbase.kde.org/;>
>   Techbase
>  

 Community wiki

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19992

To: vkrause
Cc: yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, 
bruns, skadinna

D19992: Update URLs to use https

[Volker Krause]

vkrause created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  I haven't touched affected localized content in here, assuming that will
  be updated via the translation process?

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19992

AFFECTED FILES
  cmake/FindPerlModules.cmake
  common/en/kde-default.css
  docs/meinproc5/man-meinproc5.1.docbook
  docs/qt5options/man-qt5options.7.docbook
  src/customization/en/entities/install-compile.docbook
  src/customization/en/entities/install-intro.docbook
  src/customization/en/entities/update-doc.docbook
  src/template.docbook

To: vkrause
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, 
skadinna

D19979: Don't create thumbnails for encrypted Vaults

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> previewjob.cpp:307
>  
> +auto mountsList = KMountPoint::currentMountPoints();
> +KMountPoint::List encryptedMountsList;

Did you profile the impact of this call? I don't think it's cached. Can this 
maybe be moved to the thumbnail KIO so it's done out of process?

> previewjob.cpp:325
> +
> +if (encryptedMountsList.findByPath(item.item.url().toLocalFile())) {
> +continue;

Use `KFileItem::localPath()`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D19979

To: ivan, davidedmundson, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D19990: Switch URLs to https

[Kai Uwe Broulik]

broulik added a reviewer: leinir.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19990

To: vkrause, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19990: Switch URLs to https

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Also remove two apparently dead services from the KMoreTools preset.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19990

AFFECTED FILES
  README.md
  docs/packaging.txt
  src/downloaddialog.h
  src/downloadwidget.h
  src/downloadwidget.ui
  src/kmoretools/kmoretoolspresets.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19974: Add extensions to groovy highlighting

[Dominik Haumann]

dhaumann added a comment.


  You also have to increase the "version" from 5 to 6. Could you provide an 
updated patch?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19974

To: apushnov, #framework_syntax_highlighting
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars