D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis added a comment.


  One concern:
  
  Previously, the `go-up` icon in `go.svg` used a completely different style 
from the other `go-*` icons. Does anyone know why that was? I can't find any 
reason for it to use a different style.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20623

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20623: Update audio, drive, edit, go, list, media, plasmavault icons to match breeze-icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  update-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20623

AFFECTED FILES
  src/desktoptheme/breeze/icons/audio.svg
  src/desktoptheme/breeze/icons/drive.svg
  src/desktoptheme/breeze/icons/edit.svg
  src/desktoptheme/breeze/icons/go.svg
  src/desktoptheme/breeze/icons/list.svg
  src/desktoptheme/breeze/icons/media.svg
  src/desktoptheme/breeze/icons/plasmavault.svg
  src/desktoptheme/breeze/icons/plasmavault_error.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20608: Declare properties as meta type

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  enum_meta

REVISION DETAIL
  https://phabricator.kde.org/D20608

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20529: add license to python test files

[Stefan Brüns]

bruns added a comment.


  In D20529#451147 , @bcooksley 
wrote:
  
  > can we get the full command it's running?
  
  
  `ctest -V -R externalextractortest`

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20529

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20529: add license to python test files

[Stefan Brüns]

bruns added a comment.


  In D20529#451147 , @bcooksley 
wrote:
  
  > The Python installation on the CI nodes is most definitely complete (the CI 
Tooling itself used to perform the builds is written entirely in Python)
  >
  > I'd therefore suggest that something isn't entirely right with how Python 
is being executed by the tests here... can we get the full command it's running?
  
  
  Honestly, **I** don't care why it fails, or if it works at all. I also have 
neither time nor means to debug this.
  
  #windows   - I will give this a 
timeframe of one month to get this fixed. If nothing has been submitted till 
then, I will disable the test for windows.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20529

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns updated this revision to Diff 56405.
bruns added a comment.


  disable configure action when in configuration mode

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20525?vs=56287=56405

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D20525

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/panels/information/filemetadataconfigurationdialog.cpp
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanel.cpp
  src/panels/information/informationpanel.h
  src/panels/information/informationpanelcontent.cpp
  src/panels/information/informationpanelcontent.h

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20617: [balooctl] Factor out file index status collection from output

[Stefan Brüns]

bruns added a dependent revision: D20620: [balooctl] Switch multiline output to 
new helper.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20617

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20620: [balooctl] Switch multiline output to new helper

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Output is mostly unchanged, but symlinks are no longer shown
  as "Basic Indexing: Scheduled."
  
  Depends on D20617 .

TEST PLAN
  balooctl status 

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_status

REVISION DETAIL
  https://phabricator.kde.org/D20620

AFFECTED FILES
  src/tools/balooctl/statuscommand.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20616

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20619: [balooctl] Use new helper in json output

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The output is mostly the same, save for the following fixes:
  
  - symlinks are no longer listed as "indexing=basic, state=scheduled", but are 
omitted from output
  - in case "onlyBasicIndexing" is active, indexing now shows "basic" instead 
of "content"
  - excluded files are now "indexing=none, state=disabled" instead of 
"indexing=basic, state=disabled"
  
  Depends on D20617 

TEST PLAN
  balooctl status -f json 

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_status

REVISION DETAIL
  https://phabricator.kde.org/D20619

AFFECTED FILES
  src/tools/balooctl/statuscommand.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20617: [balooctl] Factor out file index status collection from output

[Stefan Brüns]

bruns added a dependent revision: D20619: [balooctl] Use new helper in json 
output.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20617

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  We shouldn't indeed. Maybe it's a candidate to get in KGuiAddons

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20616

To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20617: [balooctl] Factor out file index status collection from output

[Stefan Brüns]

bruns added a dependent revision: D20618: [balooctl] Use new helper for simple 
format output.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20617

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20618: [balooctl] Use new helper for simple format output

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Symlinks are no longer reported as "Basic indexing scheduled",
  otherwise the output is unchanged.
  
  Depends on D20617 .

TEST PLAN
  balooctl status -f simple 

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_status

REVISION DETAIL
  https://phabricator.kde.org/D20618

AFFECTED FILES
  src/tools/balooctl/statuscommand.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20617: [balooctl] Factor out file index status collection from output

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The three output formats (singleline, multiline, json) each implement
  the collection of the file status individually.

REPOSITORY
  R293 Baloo

BRANCH
  balooctl_status

REVISION DETAIL
  https://phabricator.kde.org/D20617

AFFECTED FILES
  src/tools/balooctl/statuscommand.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20616: KeySequenceHelperPrivate::updateShortcutDisplay: Don't show english text to the user

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  This is a port of 1b49ea4d3154630f79b604a191265cff687c18ad 
 in 
kxmlgui
  
  We shouldn't really have duplicated code like this :(

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20616

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/19/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 16 Apr 2019 21:59:22 +
 Build duration:
8 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.58.0.xmllogs/KF5WindowSystem/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7176/9550)55%
(3540/6399)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3046/3138)53%
(1293/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(786/1391)45%
(303/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3337/4664)60%
(1941/3219)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D20614: KKeySequenceWidget: Don't show English strings to the user

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D20614

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/20/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 16 Apr 2019 21:59:22 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D20613

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20614: KKeySequenceWidget: Don't show English strings to the user

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20614

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20614: KKeySequenceWidget: Don't show English strings to the user

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  KKeyServer::modToStringUser is only for english texts
  
  BUGS: 405925

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20614

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  autotests/kxmlgui_unittest.h
  src/kkeysequencewidget.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20613

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20606: Toggle folding of child ranges by right click

[Dominik Haumann]

dhaumann added a comment.


  I would prefer a context menu that has this as action. This is much better 
discoverable and also extensible with more folding actions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20613: Document that modToStringUser and stringUserToMod only deal with english strings

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R278 KWindowSystem

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20613

AFFECTED FILES
  src/kkeyserver.h

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20565: Ensure not to fold the end marker

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Yes, I am in favor. thanks

REVISION DETAIL
  https://phabricator.kde.org/D20565

To: loh.tar, #ktexteditor, cullmann, dhaumann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18996: Fix building with namespaced Qt

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  The build issue got fixed.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18996

To: davschul, vkrause
Cc: cgiboudeaux, cullmann, kwrite-devel, kde-frameworks-devel, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, vkrause, 
sars, dhaumann

D20606: Toggle folding of child ranges by right click

[Christoph Cullmann]

cullmann added reviewers: ngraham, dhaumann.
cullmann added a comment.


  I think the feature is nice.
  
  For the code: I would like to have comments for the function decls. to tell 
what they really do.
  e.g. toggleFoldingInRange needs a short summary what it does, the comments in 
the function themself are helpful.
  
  Others, feedback?
  
  The only real issue for the "usability" is imho the lack of discoverability.
  Perhaps this should in addition get an action in the "Code Folding" menu?
  The people can have a shortcut for it, too, if wanted.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/85/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Apr 2019 17:54:41 +
 Build duration:
9 min 6 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1260/1290)49%
(2542/5209)src79%
(22/28)79%
(22/28)79%
(1215/1537)43%
(492/1138)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

D20604: Fix stack-buffer-overflow read on malformed files

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D20604

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20605: Fix null-dereference on malformed tar files

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R243:084dabd35bfb: Fix null-dereference on malformed tar files 
(authored by aacid).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20605?vs=56373=56389

REVISION DETAIL
  https://phabricator.kde.org/D20605

AFFECTED FILES
  src/ktar.cpp

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20604: Fix stack-buffer-overflow read on malformed files

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20604

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20605: Fix null-dereference on malformed tar files

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20605

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/84/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Apr 2019 17:45:54 +
 Build duration:
8 min 45 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1260/1290)49%
(2542/5209)src79%
(22/28)79%
(22/28)79%
(1215/1537)43%
(492/1138)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/79/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 16 Apr 2019 17:51:07 +
 Build duration:
2 min 25 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1260/1290)49%
(2542/5209)src79%
(22/28)79%
(22/28)79%
(1215/1537)43%
(492/1138)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/78/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 16 Apr 2019 17:45:54 +
 Build duration:
5 min 12 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(54/61)89%
(54/61)85%
(3667/4319)48%
(5101/10694)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1268/1298)49%
(2558/5241)src79%
(22/28)79%
(22/28)79%
(1229/1551)43%
(490/1136)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/84/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 16 Apr 2019 17:48:27 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/83/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 16 Apr 2019 17:45:54 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20608: Declare properties as meta type

[Alexander Stippich]

astippich created this revision.
astippich added a reviewer: bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Will be used in another test

REPOSITORY
  R286 KFileMetaData

BRANCH
  enum_meta

REVISION DETAIL
  https://phabricator.kde.org/D20608

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/properties.h

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20528: Change properties attributes for consistency

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:4808263e41bf: Change properties attributes for 
consistency (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20528?vs=56173=56385

REVISION DETAIL
  https://phabricator.kde.org/D20528

AFFECTED FILES
  autotests/taglibextractortest.cpp
  src/formatstrings.cpp
  src/formatstrings_p.h
  src/propertyinfo.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20529: add license to python test files

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:eb9b1ef9b30d: add license to python test files (authored 
by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20529?vs=56174=56383

REVISION DETAIL
  https://phabricator.kde.org/D20529

AFFECTED FILES
  autotests/samplefiles/testexternalextractor/main.py
  autotests/samplefiles/testexternalwriter/main.py

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19445: Handle variant list in formatting functions

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ffdee4011145: Handle variant list in formatting functions 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19445?vs=55926=56384

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: apol, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

Re: grantlee commit access

[Volker Krause]

On Monday, 15 April 2019 23:20:58 CEST David Faure wrote:
> Thanks for the merge of the Qt 5.13 build fix.
> 
> I would certainly welcome grantlee as a KF5 framework, I think it makes
> things easier from a KDE point of view, and it reduces the bus factor in
> terms of who can actually push to the repository. At the same time, we
> still need you as the maintainer, so I hope this isn't a push-and-forget,
> but just a different contribution model and a different release model.
> 
> My releasing of KF5 is very very automated, I certainly don't mind one more
> framework, if it follows the rules :)
> 
> Some reorganization will be needed, see
> https://community.kde.org/Frameworks/Policies#Framework_directory_structure
> 
> Then there is the checklist at
> https://community.kde.org/Frameworks/CreationGuidelines
> 
> I also noted that the current README.md mentions "Grantlee Templates and
> Grantlee TextDocument" but then only explains what the first one is, nothing
> else is said about TextDocument?

very nice, definitely +1 on Grantlee joining Frameworks! The predictable 
release cycle would make it much more practical to upstream additions that we 
are currently having spread over a few KDE PIM modules.
If there's anything I can help with for making Grantlee KF5-compliant just let 
me know :)

Regards,
Volker

> On lundi 15 avril 2019 09:59:15 CEST Stephen Kelly wrote:
> > Hi David,
> > 
> > I'm just merging that now. Thanks for the heads-up.
> > 
> > I have been thinking of putting making Grantlee a KF5 Framework, as I
> > haven't been fast with maintenance lately.
> > 
> > My idea would be that I'll go through the github issues/PRs etc and make
> > one more release, then push it to KDE.
> > 
> > That would have a few implications, such as you would be releasing it
> > etc. Do you think that would work?
> > 
> > Thanks,
> > 
> > Stephen.
> > 
> > On 15/04/2019 08:01, David Faure wrote:
> > > Hi Stephen,
> > > 
> > > can you merge https://github.com/steveire/grantlee/pull/48 ?
> > > 
> > > This is blocking builds with Qt 5.13.
> > > 
> > > Can you give me push access so we're not blocked if you have moved on?
> > > Alternatively we'll have to fork it on kde.org



signature.asc
Description: This is a digitally signed message part.

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  Oh, may that fit too?
  Bug 352868 - Folding for all nodes (not just top-level) and/or siblings to 
current

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  A possible improvement could be to add slots to make the folding accessible 
by some keyboard action, but I'm not in the mood for that now.
  Bug 343060 - global folding code keyboard shortcuts

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar added a comment.


  This patch supersedes D20565 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20606: Toggle folding of child ranges by right click

[loh tar]

loh.tar created this revision.
loh.tar added reviewers: KTextEditor, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  With this patch will all, and only, the nested foldings of a range
  (un)folded by right mouse click on the left hand icon border.
  
  The range itself keep untouched, not toggled.
  
  For convenience toggle the right button also a range which doesn't
  contain other folding ranges.
  
  The noted bug report request a slightly different behavior, but I think
  it's close enough to considered that as "fixed".
  
  BUG: 344414
  FIXED-IN: 5.58

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20605: Fix null-dereference on malformed tar files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  findOrCreate can return nullptr so fail if it does
  
  oss-fuzz #14275

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20605

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20604: Fix stack-buffer-overflow read on malformed files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Make sure we read at most 32 bytes for the user/group
  
  oss-fuzz #14264

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20604

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Nathaniel Graham]

ngraham added a comment.


  Good idea, but the problem I keep running into is that 
`flickable.contentHeight` is set to 0 here.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20498: Change namespace of MobileCursor

[Dimitris Kardarakos]

dkardarakos abandoned this revision.
dkardarakos added a comment.


  Not relevant anymore,  @mart fixed it 
 as 
a separate commit.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20498

To: dkardarakos, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

bruns added a comment.


  In D20525#449801 , @bruns wrote:
  
  > In D20525#449788 , @ngraham 
wrote:
  >
  > > +1, this is a much nicer UI. Some of the text gets cut off horizontally 
though when the panel is narrow:
  > >
  > > F6771538: Screenshot_20190414_081327.png 

  > >
  > > I imagine it would be even worse in German or with a Romance language. 
Maybe in edit mode, you can just show the properties and not their values as 
well?
  >
  >
  > This is probably a caused by the minimum width calculation now being off.
  >
  > I think it is quite useful to have the values, especially for some more 
"obscure" properties. The user gets an immediate feedback if the property is 
the one she/he is interested in. Maybe just cutoff or ellide the value, and 
make sure the label is visible.
  
  
  This is actually not a regression caused by this change, although the change 
makes it somewhat more obvious.
  
  Currently, the minimum width is essentially set by the preview above, which 
gives suffifient space for labels like "Permissions:". When you disable the 
preview, you can shrink down the information panel down to 60 px. The problem 
is somewhere in the widget stacking not respecting or setting a minimum width.
  
  I think this problem should not be tackled here.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D20525

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20602

To: kossebau, #plasma, #vdg
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20283: [SimpleKCM] Base the maximum height on the screen height, not some random value

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Instead of swapping out one random number for another, please correctly 
calculate the implicit size of the page, like `GridViewKCM` does:
  Something like
  
implicitHeight: Math.min(flickable.contentHeight, Kirigami.Units.gridUnit * 
20)
+ topPadding + bottomPadding
+ (header && header.visible ? header.height + 
header.topPadding + header.bottomPadding : 0)
+ (footer && footer.visible ? footer.height + 
footer.topPadding + footer.bottomPadding : 0) + Kirigami.Units.gridUnit
  
  plus the page's own padding or so. :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20283

To: ngraham, #plasma, mart, broulik
Cc: broulik, davidedmundson, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns

D20602: Air/Oxygen desktoptheme: fix progressbar height using "hint-bar-size"

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  During Pre-Plasma5 the hard-coded height of 20 of the progressbar was
  changed to instead be taken from the theme via the "hint-bar-size":
  commit cee9c928e3855b68daf14760ed71aa961f231172 

  
  As fallback for old themes in absence of the hint the default height
  since some time later has been derived from the sum of the heights of
  the elements "bar-inactive-top" & "bar-inactive-bottom".
  
  Which though for the Air and Oxygen themes results in the small heights
  of respective 10 & 4. As a result the visual appearance of the theme
  differs from what people remember of the time when the themes were
  designed.
  Ideally the theme designer would tune the actual value to something they
  prefer. Until then setting the hint to restore the visual appearance over
  the currently pretty slim or even too slim one should improve things
  already.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixairoxygenprogressbarheight

REVISION DETAIL
  https://phabricator.kde.org/D20602

AFFECTED FILES
  src/desktoptheme/air/widgets/bar_meter_horizontal.svg
  src/desktoptheme/oxygen/widgets/bar_meter_horizontal.svg

To: kossebau, #plasma, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/78/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Apr 2019 12:46:22 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3626/13355)18%
(1818/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/71/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 16 Apr 2019 12:46:22 +
 Build duration:
5 min 10 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/81/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 16 Apr 2019 12:46:22 +
 Build duration:
4 min 20 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:0ff81fe4c728: Align zs to pixel grid in system.svg 
(authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20597?vs=56356=56365

REVISION DETAIL
  https://phabricator.kde.org/D20597

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20597

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[David Faure]

dfaure added a comment.


  This change also introduced regressions in two unittests: jobtest and 
kdirmodeltest. I'll let you look into those :-)
  
  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/junit/projectroot/autotests/kiocore_jobtest/
  
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/87/testReport/projectroot/autotests/kiowidgets_kdirmodeltest/
  
  The first one is probably just an extra file in the dir (I know, bad 
isolation of the tests), the second one is more unexpected.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20599: Fix compilation error on window

[Méven Car]

meven abandoned this revision.
meven added a comment.


  Already merged: 
https://cgit.kde.org/kio.git/commit/?id=8f9f0f8db2480f0e8392048b3ca9cb974ec266b7

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20599

To: meven, dfaure, #frameworks, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/90/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Apr 2019 10:39:02 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32987/60664)39%
(16870/43765)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9306/9772)47%
(4282/9015)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8473/1)51%
(4704/9223)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4346/8049)40%
(1877/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(573/1080)39%
(344/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1296/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
   

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/87/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 16 Apr 2019 10:39:02 +
 Build duration:
8 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/77/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 16 Apr 2019 10:39:02 +
 Build duration:
7 min 12 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 5 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kfileitemtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestFailed: projectroot.autotests.kiowidgets_kurifiltertestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(32978/60670)39%
(16857/43768)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9308/9772)47%
(4282/9015)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8457/14451)51%
(4697/9226)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4353/8049)40%
(1885/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(572/1080)39%
(343/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4291)35%
(1294/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
 

D20599: Fix compilation error on window

[David Faure]

dfaure added a comment.


  Sorry, I was faster :/
  
  https://commits.kde.org/kio/8f9f0f8db2480f0e8392048b3ca9cb974ec266b7
  
  At least we agree on the exact patch, thanks for the confirmation :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20599

To: meven, dfaure, #frameworks, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 260 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/260/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 16 Apr 2019 10:39:02 +
 Build duration:
5 min 48 sec and counting

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Méven Car]

meven added a comment.


  In D20096#451148 , @bcooksley 
wrote:
  
  > MSVC doesn't like this change i'm afraid - see 
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/console
  >  Looks like you're making use of C++17 features?
  
  
  I am a bit surprised. I used std:c++11 as for the rest of current kde compli
  
  In D20096#451150 , @dfaure wrote:
  
  > Nah, no C++17 here, the compiler is just confused because it doesn't know 
the types uid_t and gid_t.
  >
  > I'll add some #ifndef Q_OS_WIN.
  
  
  
  
  In D20096#451150 , @dfaure wrote:
  
  > Nah, no C++17 here, the compiler is just confused because it doesn't know 
the types uid_t and gid_t.
  >
  > I'll add some #ifndef Q_OS_WIN.
  
  
  @bcooksley 
  Could you test https://phabricator.kde.org/D20599 ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20599: Fix compilation error on window

[Méven Car]

meven created this revision.
meven added reviewers: dfaure, Frameworks, bcooksley.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  https://phabricator.kde.org/D20096#451148

TEST PLAN
  Compiles on MSVC

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20599

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: meven, dfaure, #frameworks, bcooksley
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[David Faure]

dfaure added a comment.


  Nah, no C++17 here, the compiler is just confused because it doesn't know the 
types uid_t and gid_t.
  
  I'll add some #ifndef Q_OS_WIN.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

[Ben Cooksley]

bcooksley added a comment.


  MSVC doesn't like this change i'm afraid - see 
https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/259/console
  Looks like you're making use of C++17 features?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20096

To: meven, #frameworks, dfaure, fvogt, bruns, broulik
Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, 
bruns

D20529: add license to python test files

[Ben Cooksley]

bcooksley added a comment.


  The Python installation on the CI nodes is most definitely complete (the CI 
Tooling itself used to perform the builds is written entirely in Python)
  
  I'd therefore suggest that something isn't entirely right with how Python is 
being executed by the tests here... can we get the full command it's running?

REPOSITORY
  R286 KFileMetaData

BRANCH
  py_license

REVISION DETAIL
  https://phabricator.kde.org/D20529

To: astippich, bruns
Cc: bcooksley, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/70/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 16 Apr 2019 09:28:43 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.57.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3636/13356)18%
(1822/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(689/1579)29%
(304/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

D20594: Fix MobileTextSelection namespacing

[Marco Martin]

mart added a comment.


  sorry, didn't notice it :(

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20594

To: broulik, #plasma, mart, hein, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/80/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 16 Apr 2019 09:28:42 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/77/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 16 Apr 2019 09:28:42 +
 Build duration:
6 min 46 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13355)18%
(1819/9856)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2259)6%
(91/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D20594: Fix MobileTextSelection namespacing

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://cgit.kde.org/plasma-framework.git/commit/?id=8431223542110fd112cda5a4b352ab4a8a21bb51

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20594

To: broulik, #plasma, mart, hein, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20594

To: broulik, #plasma, mart, hein, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[Vlad Zagorodniy]

zzag added a comment.


  > Maybe we can revisit once I've done the kwin side?
  
  Sure.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[David Edmundson]

davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.


  > What about xdg_shell_unstable_v6?
  
  Code wise it's a super easy copy + paste.  
  I'm somewhat torn when it comes to adding new "features" to deprecated specs 
that I can't do real-world testing of.
  
  Maybe we can revisit once I've done the kwin side?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[David Edmundson]

davidedmundson updated this revision to Diff 56357.
davidedmundson added a comment.


  update

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20595?vs=56353=56357

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20595

AFFECTED FILES
  autotests/client/test_xdg_shell_stable.cpp
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_stable_interface.cpp

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> xdgshell_interface.h:283
> + * @brief windowGeometry
> + * The position of the window within the buffer
> + *

s/position/geometry/

> xdgshell_stable_interface.cpp:524
> +if (s->m_topLevel) {
> +s->m_topLevel->d_func()->windowGeometry = QRect(windowRect);
> +emit s->m_topLevel->windowGeometryChanged(windowRect);

The copy constructor is redundant (most likely a leftover I guess).

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20597

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20597: Align z's to pixel grid in system.svg

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  This does the same thing as D20586 , but 
for the Breeze desktop theme

TEST PLAN
  Looks exactly the same as D20586 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fix-z (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20597

AFFECTED FILES
  src/desktoptheme/breeze/icons/system.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20586: Sharpen Z's in system-suspend* icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:db9fdceac1ac: Sharpen Zs in system-suspend* icons 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20586?vs=56331=56355

REVISION DETAIL
  https://phabricator.kde.org/D20586

AFFECTED FILES
  icons-dark/actions/22/system-suspend-hibernate.svg
  icons-dark/actions/22/system-suspend.svg
  icons-dark/actions/32/system-suspend-hibernate.svg
  icons-dark/actions/32/system-suspend.svg
  icons/actions/22/system-suspend-hibernate.svg
  icons/actions/22/system-suspend.svg
  icons/actions/32/system-suspend-hibernate.svg
  icons/actions/32/system-suspend.svg

To: ndavis, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[Vlad Zagorodniy]

zzag added a comment.


  What about xdg_shell_unstable_v6?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D20595

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D20595: Implement set_window_geometry

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Used by clients to say where their true window geometry is relative to
  the buffer size. Important if a client has client side shadows which
  shouldn't be included for positioning tasks.
  
  Technically this should be double buffered, but for consistency with all
  other XdgShell properties this will be a task left to ShellClient.

TEST PLAN
  Unit test

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20595

AFFECTED FILES
  autotests/client/test_xdg_shell_stable.cpp
  src/client/xdgshell.cpp
  src/client/xdgshell.h
  src/client/xdgshell_p.h
  src/client/xdgshell_stable.cpp
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_stable_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

[Kai Uwe Broulik]

broulik edited the summary of this revision.
broulik added a reviewer: lbeltrame.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20594

To: broulik, #plasma, mart, hein, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20594: Fix MobileTextSelection namespacing

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart, hein.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is all in `MobileTextSelection` instead of `Private` now.

TEST PLAN
  I dont understand why in every component there's two of them, one in a 
`Component` and the other not but whatever. This works now.
  
  Note that when moving files about in plasmacomponents 3 you must do a clean 
build as our cmake foo to change the import numbers doesn't pick that up which 
is probably why this breakage went unnoticed. It also only broke here once I 
did a clean build or got the packages shipped from neon... Also, I would 
appreciate if you could test media controller when you do plasma components 3 
changes as this seems to be the only user of that stuff right now and 
constantly breaks for doing so ...

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20594

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ComboBox.qml
  src/declarativeimports/plasmacomponents3/TextArea.qml
  src/declarativeimports/plasmacomponents3/TextField.qml

To: broulik, #plasma, mart, hein
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20592: Set correct kwalletd_bin_path

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R311:25f9723e87ce: Set correct kwalletd_bin_path (authored by 
broulik).

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20592?vs=56347=56349

REVISION DETAIL
  https://phabricator.kde.org/D20592

AFFECTED FILES
  src/api/KWallet/KF5WalletConfig.cmake.in

To: broulik, davidedmundson, jriddell
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20592: Set correct kwalletd_bin_path

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D20592

To: broulik, davidedmundson, jriddell
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20592: Set correct kwalletd_bin_path

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: davidedmundson, jriddell.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is installed as `kwalletd5`

TEST PLAN
  Compiled this and kwallet-pam, logged out and back in, still asked for 
password but maybe I didn't test it properly or didn't reinitialize something, 
dunno

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D20592

AFFECTED FILES
  src/api/KWallet/KF5WalletConfig.cmake.in

To: broulik, davidedmundson, jriddell
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 172 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/172/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 16 Apr 2019 07:02:45 +
 Build duration:
5 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)