D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R294 KBookmarks

BRANCH
  add_tabs_open (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20606: Add action to toggle folding of child ranges

[loh tar]

loh.tar added a comment.


  In D20606#451744 , @mwolff wrote:
  
  > In D20606#451459 , @dhaumann 
wrote:
  >
  > > I would prefer a context menu that has this as action. This is much 
better discoverable and also extensible with more folding actions.
  >
  >
  > I agree. Right-click should show a context menu. Middle-click could toggle, 
if you need it.
  
  
  Me wrote:
  
  > But a context menu on the icon border would I very much dislike. Middle 
click is not so handy and perform atm "paste to begin of line"
  
  Well, as long the menu works everywhere but not the folding area, may that 
indeed not so bad. There could also be actions to toggle the visibility of 
parts of the border. 
  Or you make the current right-click the left-click action. That may even more 
handy and give current left-click the middle button.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20606

To: loh.tar, #ktexteditor, cullmann, ngraham, dhaumann
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 84 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 23 Apr 2019 19:48:33 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.58.0.xmllogs/KF5TextEditor/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)68%
(33271/48697)51%
(15910/31087)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4658/4998)49%
(1753/3606)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1711/1903)76%
(1215/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)60%
(1929/3207)48%
(1616/3349)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(958/1246)67%
(631/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
   

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.10 - Build # 98 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.10/98/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 23 Apr 2019 19:48:33 +
 Build duration:
8 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5TextEditor-5.58.0.xmllogs/KF5TextEditor/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(258/293)88%
(258/293)68%
(33220/48695)51%
(15876/31087)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)93%
(4658/4998)49%
(1753/3606)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5471/5512)58%
(993/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1711/1903)76%
(1215/1602)src.completion100%
(11/11)100%
(11/11)57%
(1781/3125)43%
(1164/2735)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(184/459)22%
(76/348)src.dialogs0%
(0/4)0%
(0/4)0%
(0/799)0%
(0/192)src.document100%
(4/4)100%
(4/4)60%
(1927/3207)48%
(1616/3349)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)41%
(171/417)40%
(111/275)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/834)0%
(0/294)src.render100%
(7/7)100%
(7/7)77%
(958/1246)67%
(631/944)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%
(268/465)src.search100%
(7/7)100%
 

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 101 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/101/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 23 Apr 2019 19:48:33 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7c6559bdb86f: Add edit-remove icon symlink 
and add 22px version of paint-none and edit… (authored by 
GB_2).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20700?vs=56835=56844

REVISION DETAIL
  https://phabricator.kde.org/D20700

AFFECTED FILES
  icons-dark/actions/16/edit-none.svg
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/16/paint-none.svg
  icons-dark/actions/22/edit-none.svg
  icons-dark/actions/22/edit-remove.svg
  icons-dark/actions/22/paint-none.svg
  icons/actions/16/edit-none.svg
  icons/actions/16/edit-remove.svg
  icons/actions/16/paint-none.svg
  icons/actions/22/edit-none.svg
  icons/actions/22/edit-remove.svg
  icons/actions/22/paint-none.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20697: Review IconBorder

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:57781f34d234: Review IconBorder (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56839=56843

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  This works for me fine with KDevelop.
  Please commit.
  Thanks

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[loh tar]

loh.tar updated this revision to Diff 56839.
loh.tar edited the test plan for this revision.
loh.tar added a comment.


  try to fix annotation issue
  
  completely untested :-/

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20697?vs=56694=56839

REVISION DETAIL
  https://phabricator.kde.org/D20697

AFFECTED FILES
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[Christoph Cullmann]

cullmann added a comment.


  I am not sure one can delay the updateGeometry stuff until one paints.

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20697: Review IconBorder

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Unfortunately, the annotation stuff regressed.
  I tried KDevelop, right click on text => Git -> Annotation...
  See pre-patch and post-patch pictures below, the too small one is the post 
patch one.
  F6788986: pre-patch.png 
  F6788988: with-patch.png 

REVISION DETAIL
  https://phabricator.kde.org/D20697

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in kbookmarkmenu.cpp:150
> Technically this is only needed if the number of open tabs went from "< 2" to 
> ">= 2" or vice versa.
> When going from, say, 20 to 21, we don't need to refill the menu.
> So the code could be
> 
>   m_bDirty = (d->numberOfOpenTabs < 2) != (numberOfOpenTabs < 2);
>   d->numberOfOpenTabs = numberOfOpenTabs;

Good point :D

> dfaure wrote in kbookmarkmenu.h:104
> All the "unsigned int" in this patch is a bit unusual in Qt/KDE code, we use 
> int everywhere.

Ok - I have changed it to use int all over instead.

REPOSITORY
  R294 KBookmarks

REVISION DETAIL
  https://phabricator.kde.org/D20209

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20209: Add support for KBookmarkOwner to communicate if it has tabs open

[David Hallas]

hallas updated this revision to Diff 56837.
hallas marked an inline comment as done.
hallas added a comment.


  Review comments

REPOSITORY
  R294 KBookmarks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20209?vs=56744=56837

BRANCH
  add_tabs_open (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20209

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kbookmarkmenutest.cpp
  src/kbookmarkmenu.cpp
  src/kbookmarkmenu.h

To: hallas, #frameworks, ngraham, cfeck, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20766: Use appropriate background color for text previews

[Christoph Cullmann]

cullmann added a comment.


  I actually think the theme should contain all colors hard-coded and 
KTextEditor should properly use that instead of currently the mix of 
hardcoded/defaults.
  The only automatism should be (in my eyes) to switch between a light/dark 
variant automatic depending on the base color of the current window.
  But that is only my opinion.
  I think the "we adapt to the color scheme" stuff is flawed.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel, 
kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

[Björn Feber]

GB_2 updated this revision to Diff 56835.
GB_2 added a comment.


  Fix one 16px path point

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20700?vs=56834=56835

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

AFFECTED FILES
  icons-dark/actions/16/edit-none.svg
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/16/paint-none.svg
  icons-dark/actions/22/edit-none.svg
  icons-dark/actions/22/edit-remove.svg
  icons-dark/actions/22/paint-none.svg
  icons/actions/16/edit-none.svg
  icons/actions/16/edit-remove.svg
  icons/actions/16/paint-none.svg
  icons/actions/22/edit-none.svg
  icons/actions/22/edit-remove.svg
  icons/actions/22/paint-none.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none" and "edit-none"

[Björn Feber]

GB_2 retitled this revision from "Add "edit-remove" icon symlink and add 22px 
version of "paint-none"" to "Add "edit-remove" icon symlink and add 22px 
version of "paint-none" and "edit-none"".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Björn Feber]

GB_2 updated this revision to Diff 56834.
GB_2 added a comment.


  (Hopefully) fix icons and add 22px version of `edit-none`

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20700?vs=56747=56834

BRANCH
  add-edit-remove-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20700

AFFECTED FILES
  icons-dark/actions/16/edit-none.svg
  icons-dark/actions/16/edit-remove.svg
  icons-dark/actions/16/paint-none.svg
  icons-dark/actions/22/edit-none.svg
  icons-dark/actions/22/edit-remove.svg
  icons-dark/actions/22/paint-none.svg
  icons/actions/16/edit-none.svg
  icons/actions/16/edit-remove.svg
  icons/actions/16/paint-none.svg
  icons/actions/22/edit-none.svg
  icons/actions/22/edit-remove.svg
  icons/actions/22/paint-none.svg

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20766: Use appropriate background color for text previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  I am even more confused that switching back to "Breeze" from "Breeze Dark", I 
can still reproduce things when just switching to dark color themes only. So 
possibly that is enough, and I was before potentially fooled by some running 
processes, despite making sure no thumbnailer kio-slave was idling, or by some 
improperly propagated UI color palette changes).
  So possibly indeed just the UI color palette effective here, Plasma unrelated.
  
  Re: Kate: seems from its text document UI schemas "Normal", "Printing", 
"KDE", "Breeze Dark", "Solarized (light)", Solarized (dark", "Vim (dark)". the 
"KDE" one is the one which adapts to current workspace UI color theme, while 
the others all have a completely hard-coded palette?
  
  @vkrause Given the API dox claiming that enum 
KSyntaxHighlighting::Repository::DefaultTheme lists "Built-in default theme 
types", to me it comes a bit of a surprise that the theme actually adapts to 
the UI color theme, as this is not documented. E.g. if one uses this for 
printing on paper, getting different results depending on current UI color 
theme would result in a bit randomness.
  
  Perhaps there should be additional option(s) for default theme(s) which adapt 
to the UI theme. Though this also needs support for adapting in case the user 
changes the theme (e.g. think of discussion about day & night modes using 
different color themes).
  
  So: IMHO the default themes should be hard-coded. And support for 
highlighting themes adapting to the currently active UI color palette should be 
officially added and documented.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel, 
kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

T3689: Add abi compliance checker to CI

[Sandro Knauß]

knauss added a revision: D20769: abi-compliance-checker: disable clang include 
directories completly..

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D20766: Use appropriate background color for text previews

[Volker Krause]

vkrause added subscribers: cullmann, dhaumann.
vkrause added a comment.


  In D20766#454891 , @kossebau wrote:
  
  > So, switching also the Plasma Theme to "Breeze Dark", I started to be able 
to reproduce: seems that the default text color is influenced by that. Which 
seems a side-effect not to be expected. And this patch here just a work-around 
for the symptom. We ask KSyntaxHighlighting::Repository for a light theme, we 
do expect one.
  >  IMHO this seems rather a bug in KSyntaxHighlighting and should be fixed 
there.
  
  
  @dhaumann @cullmann  ^ this sounds like we are making the assumption that the 
current system color theme from the palette matches the syntax highlighting 
theme, ie. the palette provided text color is compatible with the selected 
theme. That's probably true in the common editor case, but it seems to be an 
issue here. Should the syntax highlighting themes always have a hardcoded text 
color? Doesn't seem entirely clean either, as following the system color makes 
sense for different color schemes with the same "lightness"/"darkness". Or 
should we try to detect insufficient contrast between foreground and 
background, and use an alternate color in that case?

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel, 
kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Eugene Shalygin]

eshalygin added a comment.


  I would welcome the same palette in the file preview as the one I see in 
ktexteditor when open the file

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Christoph Feck]

cfeck requested changes to this revision.
cfeck added a comment.


  Before we can support both dark and light themes we need to investigate the 
KSyntaxHighlighting issue found by Friedrich.
  
  Later we could request a light or dark theme depending on the lightness of 
the QPalette entry, but I would suggest to use View instead of Window, because 
window backgrounds are gray with some themes, while view backgrounds usually 
have more contrast (either darker or brighter than gray).

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  So, switching also the Plasma Theme to "Breeze Dark", I started to be able to 
reproduce: seems that the default text color is influenced by that. Which seems 
a side-effect not to be expected. And this patch here just a work-around for 
the symptom. We ask KSyntaxHighlighting::Repository, we do expect one.
  IMHO this seems rather a bug in KSyntaxHighlighting and should be fixed there.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Friedrich W. H. Kossebau]

kossebau requested changes to this revision.
kossebau added a subscriber: vkrause.
kossebau added a comment.
This revision now requires changes to proceed.


  For one, I cannot reproduce the bug. With all the dark UI color themes I 
tested, I always had proper contrasted dark text colors in the plain text 
thumbnail.
  
  Then, whatever people prefer how the thing should be rendered, the current 
patch proposed though does not go well along the current codebase where it asks 
KSyntaxHighlighting for a theme:
  
const auto highlightingTheme = 
m_highlightingRepository.defaultTheme(KSyntaxHighlighting::Repository::LightTheme);
  
  "LightTheme: Theme with a light background color. " (see API dox 

  
  @vkrause What would you recommend us to do here, in case people want previews 
matching the current UI theme? For the other case, how could it happen that 
"LightTheme" seems to give some people bright highlight colors for the people 
affected?

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, 
feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, 
bruns, emmanuelp, mikesomov

D20693: Remove pixelated border

[Nathaniel Graham]

ngraham added a comment.


  To show that a thumbnail clickable, switching to the pointing hand cursor 
when hovering over a thumbnail could work.
  
  However I notice that the actual list delegates in the browse view seem to 
add frames and shadows to the thumbnails there, and they look okay. The frame's 
proportions even perfectly match the aspect ratio of the thumbnail: F6788649: 
Screenshot_20190423_074013.png 
  
  Why doesn't any of that work here?
  
  Aesthetics-wise, I'm okay deleting the shadow, but I'm less thrilled about 
also deleting the frame surrounding the image. Without that, the images look 
naked in the view, like they're just floating there, disconnected from 
everything: F6788651: Screenshot_20190423_074053.png 

  
  Rewriting this in QML would be lovely (not in this patch though, obviously). 
I think we have a mockup of a new UI for it somewhere which I can't find right 
now but I'll try to dig it up.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20766: Use appropriate background color for text previews

[Friedrich W. H. Kossebau]

kossebau added a comment.


  BTW, just a note while testing: while the thumbnails curently are not cached 
but always rerendered on demand (due to flag in metadata), there currently is 
no update mechanism to update the thumbnails already shown e.g. in Dolphin when 
the UI color theme changes.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Nathaniel Graham]

ngraham edited the summary of this revision.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Friedrich W. H. Kossebau]

kossebau added a reviewer: cfeck.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau, cfeck
Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Friedrich W. H. Kossebau]

kossebau added a subscriber: cfeck.
kossebau added a comment.


  Thanks for the patch. Hm, somehow I remember from my testing for D19432 
 that highlighting color did not take 
active UI color theme into account, has that changed meanwhile?
  
  In any case, IMHO there should be first a decision whether thumbnails for 
plain text documents should be done taking the UI color theme into account, or 
should be similar to pdf, doc & Co, where usually a print out on paper is 
assumed for the look (at least by the native formats). Personally I would 
favour this, and the one doing the hard-coded background color (@cfeck) seems 
at one point done to have as well.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau
Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20092: New class KOSRelease - a parser for os-release files

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:1bedee3ca534: New class KOSRelease - a parser for 
os-release files (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D20092?vs=55338=56813#toc

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20092?vs=55338=56813

REVISION DETAIL
  https://phabricator.kde.org/D20092

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/data/os-release
  autotests/kosreleasetest.cpp
  src/lib/CMakeLists.txt
  src/lib/util/kosrelease.cpp
  src/lib/util/kosrelease.h

To: sitter, apol, mpyne
Cc: davidedmundson, pino, aacid, mpyne, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/38/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 23 Apr 2019 11:32:18 +
 Build duration:
1 min 51 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D20196: Add Notify capability to KConfigXT

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20693#454799 , @sitter wrote:
  
  > In D20693#454750 , @leinir wrote:
  >
  > > So yes, in principle i'd certainly like there to be some kind of 
background or outline to suggest clickability, but the current state (and any 
other generic rectangular background we might come up with, higher resolution 
or not) would yield the same suboptimal result...
  >
  >
  > QGraphicsDropShadowEffect via QWidget::setGraphicsEffect may work for that?
  >
  > Another approach would likely be to write a custom blur implementation 
since we fiddle with qpainter anyway, TBH I think finding a way to use the 
effect is likely the wise use of time though.
  
  
  Yes, using the dropshadoweffect certainly seems like the more appropriate way 
of doing this (given appropriate bounding areas and whatnot).
  
  > Or... you know... rewrite the entire dialog in qml ;)
  
  Yes, rewriting in Qt Quick would also be good, and i kind of want to do 
that... though it's going to need a not inconsiderable amount of thought when 
it comes to design, which... i believe @ngraham had thoughts on this a while 
back, or perhaps the VDG?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20196: Add Notify capability to KConfigXT

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D20196

To: broulik, #frameworks, dfaure, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Harald Sitter]

sitter added a comment.


  In D20693#454750 , @leinir wrote:
  
  > So yes, in principle i'd certainly like there to be some kind of background 
or outline to suggest clickability, but the current state (and any other 
generic rectangular background we might come up with, higher resolution or not) 
would yield the same suboptimal result...
  
  
  QGraphicsDropShadowEffect via QWidget::setGraphicsEffect may work for that?
  
  Another approach would likely be to write a custom blur implementation since 
we fiddle with qpainter anyway, TBH I think finding a way to use the effect is 
likely the wise use of time though.
  
  Or... you know... rewrite the entire dialog in qml ;)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20693#454783 , @sitter wrote:
  
  > LGTM on a technical level. On a visual level also +1 because I hate that 
drop shadow with a fierce passion.
  >
  > @leinir lxr says a similar thumb is also used for some of the KAboutPerson 
stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it 
looks equally dated.
  
  
  Hmm, certainly worth a look. It'll be less terminally broken than this is, 
though, as there is more tight control over the content being used there. At 
the same time, though, i imagine there will be a non-zero number of 
non-rectangular images used for those avatars as well, so... yeah, probably 
makes good sense to retire this particular bit of heavily assumption based 
design ;)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20765: Add input methods to input method status bar button

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:14ff5dd8674f: Add input methods to input method status bar 
button (authored by broulik).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20765?vs=56804=56809

REVISION DETAIL
  https://phabricator.kde.org/D20765

AFFECTED FILES
  src/view/katestatusbar.cpp

To: broulik, #kate, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20765: Add input methods to input method status bar button

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Good idea!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20765

To: broulik, #kate, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20693: Remove pixelated border

[Harald Sitter]

sitter added a comment.


  LGTM on a technical level. On a visual level also +1 because I hate that drop 
shadow with a fierce passion.
  
  @leinir lxr says a similar thumb is also used for some of the KAboutPerson 
stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it 
looks equally dated.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20525: [InformationPanel] Use the new inline configuration mode

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R318:ecf1ae6d0b16: [InformationPanel] Use the new inline 
configuration mode (authored by bruns).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20525?vs=56732=56808

REVISION DETAIL
  https://phabricator.kde.org/D20525

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/panels/information/filemetadataconfigurationdialog.cpp
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanel.cpp
  src/panels/information/informationpanel.h
  src/panels/information/informationpanelcontent.cpp
  src/panels/information/informationpanelcontent.h

To: bruns, #dolphin, #baloo, #frameworks, ngraham, astippich, #vdg, 
elvisangelaccio
Cc: elvisangelaccio, meven, kfm-devel, alexde, feverfew, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Eugene Shalygin]

eshalygin marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau
Cc: meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> textcreator.cpp:7


Too many lines removed here, it should not compile anymore.
Just a small editing mistake I guess.

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau
Cc: meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20700: Add "edit-remove" icon symlink and add 22px version of "paint-none"

[Noah Davis]

ndavis added a comment.


  More like center version in this SVG:
  F6788395: paint-none.svg.2019_04_23_05_53_37.0.svg 

  
  F6788396: Screenshot_20190423_055953.png 

  
  Notice how the lines appear to have a thickness more similar to the square 
outline above while the original version on the right appears to be thicker.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20700

To: GB_2, #vdg, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, #vdg, michaelh, bruns

D20766: Use appropriate background color for text previews

[Eugene Shalygin]

eshalygin updated this revision to Diff 56806.
eshalygin added a comment.


  Replace KColorScheme with QPalette

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20766?vs=56805=56806

REVISION DETAIL
  https://phabricator.kde.org/D20766

AFFECTED FILES
  thumbnail/textcreator.cpp

To: eshalygin, kossebau
Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Kai Uwe Broulik]

broulik added a reviewer: kossebau.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin, kossebau
Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20693#454733 , @ndavis wrote:
  
  > +1 for the change to the large thumbnail, but I think the smaller 
thumbnails need something to show that they can be clicked.
  
  
  The problem as described in my comment where i added the VDG as reviewer is 
that this is what it looks like currently: F6788383: image.png 

  
  So yes, in principle i'd certainly like there to be some kind of background 
or outline to suggest clickability, but the current state (and any other 
generic rectangular background we might come up with, higher resolution or not) 
would yield the same suboptimal result...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20766: Use appropriate background color for text previews

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> textcreator.cpp:140
>  
> -QColor bgColor = QColor ( 245, 245, 245 ); // light-grey 
> background
> -m_pixmap.fill( bgColor );
> +m_pixmap.fill( 
> KColorScheme(QPalette::Active).background().color() );
>  

Can't you use `QPalette` instead of `KColorScheme`? The latter parses config 
files on disk and is somewhat heavy

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D20766

To: eshalygin
Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

[Eugene Shalygin]

eshalygin created this revision.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
eshalygin requested review of this revision.

REVISION SUMMARY
  Text previews are unreadable (in fact look empty) with dark colour schemes 
because of the hard-coded background color.
  
  https://bugs.kde.org/show_bug.cgi?id=406404
  https://bugs.kde.org/show_bug.cgi?id=406745

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D20766

AFFECTED FILES
  thumbnail/CMakeLists.txt
  thumbnail/textcreator.cpp

To: eshalygin
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D20693: Remove pixelated border

[Noah Davis]

ndavis added a comment.


  +1 for the change to the large thumbnail, but I think the smaller thumbnails 
need something to show that they can be clicked.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: ndavis, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20765: Add input methods to input method status bar button

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Kate, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Even though it indicates VI mode vs Normal mode clicking it only toggles 
Insert vs Replace.
  Add the input methods into its context menu.

TEST PLAN
  Accidentally enabled VI mode and couldn't figure out how to exit it (found 
the modes buried in the Edit mode), didn't find a quick way where I expected it.
  Code is a bit ugly though
  F6788345: Screenshot_20190423_111856.png 


REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20765

AFFECTED FILES
  src/view/katestatusbar.cpp

To: broulik, #kate, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/84/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 23 Apr 2019 08:34:33 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13358)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2262)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/77/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 23 Apr 2019 08:34:33 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13358)18%
(1819/9858)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2262)6%
(91/1458)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/87/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 23 Apr 2019 08:34:33 +
 Build duration:
6 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a reviewer: VDG.
leinir added a comment.


  Adding VDG because this is a visual change. To the visual commenters: This is 
intended as a first step, removing the old drop-shadow method (see also the 
related bug for a more severe version of that drop-shadow being shown very 
incorrectly). If we decide we do want a drop shadow, then that will want to be 
done separately. Note also that as we cannot guarantee the image will not have 
any translucent areas (which is the cause of the highly nasty look in the bug 
report, rather than just the basic nastiness shown in the screenshots here), we 
will need to do something considerably more clever than just putting a 9-slice 
drop image around the image (for example), which might well be a fair bit more 
expensive computationally than we'd probably want.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter, #vdg
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20761: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a reviewer: VDG.
leinir added a comment.


  Adding VDG because this is a visual change. To the visual commenters: This is 
intended as a first step, removing the old drop-shadow method (see also the 
related bug  for a more severe 
version of that drop-shadow being shown very incorrectly). If we decide we do 
want a drop shadow, then that will want to be done separately. Note also that 
as we cannot guarantee the image will not have any translucent areas (which is 
the cause of the highly nasty look in the bug report, rather than just the 
basic nastiness shown in the screenshots here), we will need to do something 
considerably more clever than just putting a 9-slice drop image around the 
image (for example), which might well be a fair bit more expensive 
computationally than we'd probably want.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20761

To: leinir, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 24 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/24/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 23 Apr 2019 07:44:18 +
 Build duration:
2 min 8 sec and counting
   BUILD ARTIFACTS
  acc/KF5Package-5.58.0.xmllogs/KF5Package/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1614/2221)51%
(1022/2020)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(562/759)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.12 - Build # 21 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.12/21/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 23 Apr 2019 07:44:18 +
 Build duration:
1 min 53 sec and counting
   BUILD ARTIFACTS
  acc/KF5Package-5.58.0.xmllogs/KF5Package/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)73%
(1614/2221)51%
(1022/2020)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(529/531)48%
(212/442)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(562/759)63%
(532/845)src.kpackage.private100%
(7/7)100%
(7/7)80%
(304/382)47%
(94/199)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/531)34%
(177/522)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/23/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 23 Apr 2019 07:44:18 +
 Build duration:
1 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D20749: autotests: don't fail appstream test because of anything on stderr

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:131715c8dcd0: autotests: dont fail appstream test 
because of anything on stderr (authored by dfaure).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20749?vs=56772=56795

REVISION DETAIL
  https://phabricator.kde.org/D20749

AFFECTED FILES
  autotests/kpackagetoolappstreamtest.cmake

To: dfaure, sitter, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Before patch: F6788195: image.png 
  
  After patch: F6788193: image.png 

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20693#454173 , @ngraham wrote:
  
  > This patch doesn't apply:
  >
  >INFO  Base commit is not in local repository; trying to fetch.
  >   Created and checked out branch arcpatch-D20693.
  >   Checking patch src/ui/imagepreviewwidget_p.h...
  >   Checking patch src/ui/imagepreviewwidget.cpp...
  >   Checking patch data/thumb_frame.png...
  >   error: the patch applies to 'data/thumb_frame.png' 
(afaf432793864e1fb3f1fc27aa1d53689f2243b5), which does not match the current 
contents.
  >   error: data/thumb_frame.png: patch does not apply
  >   Checking patch data/CMakeLists.txt...
  >   Applied patch src/ui/imagepreviewwidget_p.h cleanly.
  >   Applied patch src/ui/imagepreviewwidget.cpp cleanly.
  >   Applied patch data/CMakeLists.txt cleanly.
  >  
  >Patch Failed! 
  >   Usage Exception: Unable to apply patch!
  >
  >
  > Also it would be helpful if you used `arc` for your patches, since then you 
can see the context here in the web UI: 
https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches
  
  
  This yielded less problems than last couple of times i attempted to use it. 
It also was a smoother experience in general, it would seem that development 
has progressed since last i tried to use it and it ended up hosing a few weeks' 
worth of work for me, which was a whole big trash fire of fun.
  
  > Additionally, it's nice if you can add a screenshot to the Test Plan 
section for patches that involve UI changes: 
https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots
  
  Yup, totally forgot those, mabad, incoming

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20693

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20693: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 56794.
leinir added a comment.


  Attempt to use arcanist, hopefully with less data loss this time

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20693?vs=56613=56794

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20693

AFFECTED FILES
  data/CMakeLists.txt
  data/thumb_frame.png
  src/ui/imagepreviewwidget.cpp
  src/ui/imagepreviewwidget_p.h

To: leinir, #knewstuff, ngraham, sitter
Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D20761: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir abandoned this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D20761

To: leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20761: Remove pixelated border

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  In the before-times, drop shadows were considered vitally
  important on everything, and so it was introduced to
  KNewStuff's dialogues as well. It was, however, never done
  quite right, and it's making our dialogues look all silly.
  So, we remove it for now, and if we still want it, we can
  reintroduce them in a more modern fashion.
  
  BUG:391108

REPOSITORY
  R304 KNewStuff

BRANCH
  no-pixelated-border (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20761

AFFECTED FILES
  data/CMakeLists.txt
  data/thumb_frame.png
  src/ui/imagepreviewwidget.cpp
  src/ui/imagepreviewwidget_p.h

To: leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns