D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich marked 2 inline comments as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich updated this revision to Diff 57157.
astippich marked an inline comment as done.
astippich added a comment.


  - add line break

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20877?vs=57135=57157

BRANCH
  fix_exiv_crash

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19455: [knotification] compile without deprecated methods

[Laurent Montel]

mlaurent added a comment.


  +1 with albert idea.
  Or in CMakeLists.txt
  if (NOT APPLE)
  
add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00)
  
  endif()
  
  As I can't compile against MacOsX we can exclude it. It will fix when we will 
switch to qt6 by os dev.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19455

To: mlaurent, dfaure
Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 41 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/41/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Apr 2019 03:33:02 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.58.0.xmllogs/KF5Purpose/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltestFailed: projectroot.autotests.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)18%
(406/2235)14%
(144/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)85%
(133/156)44%
(44/100)src100%
(8/8)100%
(8/8)62%
(202/324)43%
(78/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 89 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/89/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 29 Apr 2019 03:32:54 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3638/13368)18%
(1822/9873)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(689/1579)29%
(304/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/82/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 29 Apr 2019 03:32:54 +
 Build duration:
7 min 33 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9873)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/92/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 29 Apr 2019 03:32:53 +
 Build duration:
2 min 37 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 36 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 29 Apr 2019 00:50:25 +
 Build duration:
3 min 16 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.58.0.xmllogs/KF5Purpose/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(458/2242)18%
(175/996)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(151/156)58%
(58/100)src100%
(8/8)100%
(8/8)68%
(223/329)49%
(88/180)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/16)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/76)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 35 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 28 Apr 2019 19:03:23 +
 Build duration:
5 hr 47 min and counting

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 38 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/38/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 28 Apr 2019 18:00:26 +
 Build duration:
6 hr 46 min and counting

D20752: Add missing properties in kpackage-generic.desktop

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20752

To: dfaure, mart, apol, sitter
Cc: #frameworks

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/20/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 28 Apr 2019 19:03:31 +
 Build duration:
4 hr 56 min and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.58.0.xmllogs/KF5WindowSystem/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7176/9550)55%
(3535/6399)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)97%
(3045/3138)52%
(1289/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)72%
(3337/4664)60%
(1941/3219)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/82/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 28 Apr 2019 19:03:16 +
 Build duration:
4 hr 45 min and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2541/5207)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kauth » kf5-qt5 WindowsMSVCQt5.11 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kauth/job/kf5-qt5%20WindowsMSVCQt5.11/43/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 28 Apr 2019 18:00:48 +
 Build duration:
4 hr 9 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

D20589: Add QML to source code types

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:26d90fec2c74: Add QML to source code types (authored by 
nicolasfella).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20589?vs=56335=57150

REVISION DETAIL
  https://phabricator.kde.org/D20589

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: nicolasfella, #baloo, ngraham
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/81/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 28 Apr 2019 19:03:03 +
 Build duration:
1 hr 8 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9873)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.12/21/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:56 +
 Build duration:
2 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_kwindowinfox11test

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:53 +
 Build duration:
2 hr 1 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/87/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:41 +
 Build duration:
1 hr 56 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/22/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:39 +
 Build duration:
1 hr 54 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D20877: Fix exivextractor crash with malformed files

[Stefan Brüns]

bruns added a comment.


  Otherwise, LGTM

INLINE COMMENTS

> astippich wrote in exiv2extractor.cpp:303
> Yep, forgot

Can you add a line break here as well?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/24/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:36 +
 Build duration:
1 hr 39 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 29 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/29/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 28 Apr 2019 19:03:01 +
 Build duration:
29 min and counting
   BUILD ARTIFACTS
  acc/KF5Wayland-5.58.0.xmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(238/262)91%
(238/262)82%
(25866/31444)51%
(10272/20181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(42/43)98%
(42/43)94%
(11702/12390)48%
(6138/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client97%
(72/74)97%
(72/74)81%
(5971/7372)59%
(1658/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7739/9029)66%
(2299/3506)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

KDE CI: Frameworks » kbookmarks » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kbookmarks/job/kf5-qt5%20WindowsMSVCQt5.11/40/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 28 Apr 2019 18:00:25 +
 Build duration:
1 hr 23 min and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:32 +
 Build duration:
1 hr 11 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/91/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:31 +
 Build duration:
1 hr 4 min and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/19/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:31 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:29 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.12 - Build # 37 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/37/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:29 +
 Build duration:
46 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/96/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:28 +
 Build duration:
39 min and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 53 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/53/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sun, 28 Apr 2019 18:00:19 +
 Build duration:
30 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.autotests.kiconloader_unittest

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.12 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.12/17/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Sun, 28 Apr 2019 17:56:27 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/88/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Apr 2019 16:18:33 +
 Build duration:
55 min and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3645/4297)48%
(5087/10664)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1259/1289)49%
(2541/5207)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(962/1234)46%
(1649/3569)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 88 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/88/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Apr 2019 16:18:20 +
 Build duration:
24 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9873)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 33 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/33/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 28 Apr 2019 16:18:18 +
 Build duration:
18 min and counting
   BUILD ARTIFACTS
  acc/KF5Wayland-5.58.0.xmllogs/KF5Wayland/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(240/262)92%
(240/262)85%
(26872/31490)53%
(10781/20181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12318/12393)50%
(6483/12887)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client99%
(73/74)99%
(73/74)85%
(6287/7396)65%
(1812/2799)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server98%
(117/119)98%
(117/119)86%
(7813/9048)66%
(2309/3506)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1291)0%
(0/313)

D19455: [knotification] compile without deprecated methods

[Albert Astals Cid]

aacid added a comment.


  In D19455#457367 , @bcooksley 
wrote:
  
  > This change has broken builds on macOS.
  >  Please see 
https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console
  >
  > Whilst not documented in the Qt Documentation, the `qmacfunctions.h` header 
(which is what is included by `#include `)  has the following:
  >
  >   #ifdef Q_OS_OSX
  >#if QT_DEPRECATED_SINCE(5, 12)
  >QT_DEPRECATED_X("Use NSApp.dockTile.badgeLabel") Q_MACEXTRAS_EXPORT void 
setBadgeLabelText(const QString );
  >QT_DEPRECATED_X("Use NSApp.dockTile.badgeLabel") Q_MACEXTRAS_EXPORT 
QString badgeLabelText();
  >   
  >QT_DEPRECATED_X("Use QPixmap::toImage, QImage::toCGImage, and -[NSImage 
initWithCGImage:size:]")
  >Q_MACEXTRAS_EXPORT NSImage *toNSImage(const QPixmap );
  >#endif
  >
  > Thoughts on the best way forward for macOS builds?
  
  
  i guess add an 
  #undef QT_DISABLE_DEPRECATED_BEFORE
  inside the 
  #ifdef Q_OS_MACOS
  of src/kstatusnotifieritem.cpp would get us going?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19455

To: mlaurent, dfaure
Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich marked an inline comment as done.
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractor.cpp:303
> Shouldn't there be  a check here as well? And probably move the 
> `ratio.second` to after its assignment and immediately return.

Yep, forgot

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich updated this revision to Diff 57135.
astippich added a comment.


  - also check for altitude ref

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20877?vs=57130=57135

BRANCH
  fix_exiv_crash

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in exiv2extractor.cpp:299
> Unfortunately, empty() does not exist. Same was done in 
> https://phabricator.kde.org/D16165

Yes, probably as `count()` is O(1).

> exiv2extractor.cpp:303
>  it = data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitudeRef"));
>  if ((ratio.second != 0) && (it != data.end()) && 
> (it->value().typeId() == Exiv2::unsignedByte || it->value().typeId() == 
> Exiv2::signedByte)) {
>  auto altRef = it->value().toLong();

Shouldn't there be  a check here as well? And probably move the `ratio.second` 
to after its assignment and immediately return.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in exiv2extractor.cpp:299
> `!it->empty()` ?

Unfortunately, empty() does not exist. Same was done in 
https://phabricator.kde.org/D16165

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> exiv2extractor.cpp:299
>  Exiv2::ExifData::const_iterator it = 
> data.findKey(Exiv2::ExifKey("Exif.GPSInfo.GPSAltitude"));
> -if (it != data.end() && (it->value().typeId() == Exiv2::unsignedRational 
> || it->value().typeId() == Exiv2::signedRational)) {
> +if (it != data.end() && it->count() > 0 &&
> +(it->value().typeId() == Exiv2::unsignedRational || 
> it->value().typeId() == Exiv2::signedRational)) {

`!it->empty()` ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich added a reviewer: bruns.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20877

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20877: Fix exivextractor crash with malformed files

[Alexander Stippich]

astippich created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Prevent a segfault by explicitly checking everywhere
  for valid entries.
  
  BUG: 405210

REPOSITORY
  R286 KFileMetaData

BRANCH
  fix_exiv_crash

REVISION DETAIL
  https://phabricator.kde.org/D20877

AFFECTED FILES
  src/extractors/exiv2extractor.cpp

To: astippich
Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[loh tar]

loh.tar updated this revision to Diff 57125.
loh.tar retitled this revision from "DocumentPrivate: Treat some chars also as 
"auto bracket" only when we have a selection" to "Add option to treat some 
chars also as "auto bracket" only when we have a selection".
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a subscriber: ngraham.
loh.tar added a comment.


  - Make feature optional by new config interface
  - Make feature independent from auto bracket option
  - Remove redundant const QChar typedChar
  - Use dummy config value from dialog
  
  TODO
  
  - Add QLineEdit or similar to config dialog
  - Oops, remove/change special angle bracket stuff
  
  QUESTIONS
  
  - Would it be this way in general OK? @mwolff
  - Is the chosen option name fitting and descriptive enough? @ngraham

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17693?vs=50061=57125

REVISION DETAIL
  https://phabricator.kde.org/D17693

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

D20838: Allow to drop one file or one folder on KDirOperator

[Méven Car]

meven added a comment.


  In D20838#456847 , @ngraham wrote:
  
  > In D20838#456831 , @meven wrote:
  >
  > > I have tested on my side, I don't understand why it does not work.
  > >  From dolphin desktop:/ you can drag'n drop fine but not from the folder 
view.
  > >  I receive events and desktop:/ urls but the drag is not accepted 
whatever I do, like always calling event->accept() in the "case 
QEvent::DragEnter".
  > >  Could it be a because of the folder view filtering where it accepts to 
get dragged for instance ?
  >
  >
  > Sounds like it. If it works from `desktop:/` in Dolphin, but not from 
Folder view, I bet the drag isn't being sent the right way.
  >
  > However, testing with a file in `desktop:/`, the drag and drop happens 
successfully, but the path listed in the filename field is invalid (e.g. 
`desktop:IMG_0713.JPG` and the file can't actually be opened:
  >
  > F6795316: Screenshot_20190426_111318.png 

  >
  > Looks like the protocol is missing a trailing slash before the file path 
part. Interestingly, I notice that if I drag the same file from 
`desktop:/` the filename field, the path is listed as 
`file:///home/dev/Desktop/IMG_0713.JPG` which is different, but also correct. 
Perhaps the path just needs to be sanitized in the same way when dragged to the 
file view?
  
  
  I have fixed those two issues :
  
  - the path are now translated from kde url to mostlocal urls (dropping from 
desktop:/ works fine) (not from trash:/ though, but it currently does not work 
currently in the filename field either)
  - the drop action moveAction needed to be allowed in the KDirModel for the 
drop from the folder view to work.
  
  Todo :
  
  - add an automated test
  - check the KDirModel change is sane and does not introduce weird behavior
  - To test: what if the filewidget has a mime filter ?
  - To test: what if the filewidget is in folder mode ?
  
  Thoughts ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

[Méven Car]

meven updated this revision to Diff 57124.
meven added a comment.


  Allow KDirModel to accept more actions when dropping on the model, simplify 
implementation, translates kde url to mostlocalurls when dropping

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57101=57124

BRANCH
  drop-kdiroperator

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20827: Reword some text, a couple clean ups, add a separator

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @meven FYI this change broke the Frameworks string freeze: 
https://community.kde.org/Schedules/Frameworks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20827

To: meven, ngraham, #frameworks, #vdg, GB_2
Cc: elvisangelaccio, kde-frameworks-devel, cblack, arvidhansson, ian, jguidon, 
hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, mglb, michaelh, crozbo, ndavis, firef, ngraham, bruns, skadinna, 
aaronhoneycutt, mbohlender

[craft-blueprints-kde] kde/frameworks/tier3/knotifications: Circumvent deprecated before breakage on macOS within KNotifications by removing that requirement until it can be fixed properly.

[Ben Cooksley]

Git commit aeaac2863f7383780197c667a6a961256af6b4f5 by Ben Cooksley.
Committed on 28/04/2019 at 09:00.
Pushed by bcooksley into branch 'master'.

Circumvent deprecated before breakage on macOS within KNotifications by 
removing that requirement until it can be fixed properly.
This is a Craft level patch, so the proper patch still needs to go into 
knotifications, but at the very least this should hopefully let us get the 
Binary Factory up and running again.

CCMAIL: fa...@kde.org
CCMAIL: mon...@kde.org
CCMAIL: kde-frameworks-devel@kde.org

A  +13   -0
kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch
M  +1-0kde/frameworks/tier3/knotifications/knotifications.py

https://commits.kde.org/craft-blueprints-kde/aeaac2863f7383780197c667a6a961256af6b4f5

diff --git 
a/kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch 
b/kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch
new file mode 100644
index 000..536ae92
--- /dev/null
+++ b/kde/frameworks/tier3/knotifications/disabled-deprecated-before.patch
@@ -0,0 +1,13 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 9b2c70a..0cded49 100644
+--- a/CMakeLists.txt
 b/CMakeLists.txt
+@@ -98,7 +98,7 @@ remove_definitions(-DQT_NO_CAST_FROM_BYTEARRAY)
+ if (IS_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/po")
+ ecm_install_po_files_as_qm(po)
+ endif()
+-add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00)
++#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00)
+ add_subdirectory(src)
+ if (BUILD_TESTING)
+ add_subdirectory(tests)
diff --git a/kde/frameworks/tier3/knotifications/knotifications.py 
b/kde/frameworks/tier3/knotifications/knotifications.py
index 1ca952a..9bb4411 100644
--- a/kde/frameworks/tier3/knotifications/knotifications.py
+++ b/kde/frameworks/tier3/knotifications/knotifications.py
@@ -4,6 +4,7 @@ import info
 class subinfo(info.infoclass):
 def setTargets(self):
 self.versionInfo.setDefaultValues()
+self.patchToApply['5.57.0'] = [("disabled-deprecated-before.patch", 1)]
 
 self.description = "TODO"
 

D19455: [knotification] compile without deprecated methods

[Ben Cooksley]

bcooksley added a comment.


  This change has broken builds on macOS.
  Please see 
https://binary-factory.kde.org/view/MacOS/job/Kig_Nightly_macos/407/console
  
  Whilst not documented in the Qt Documentation, the `qmacfunctions.h` header 
(which is what is included by `#include `)  has the following:
  
#ifdef Q_OS_OSX
#if QT_DEPRECATED_SINCE(5, 12)
QT_DEPRECATED_X("Use NSApp.dockTile.badgeLabel") Q_MACEXTRAS_EXPORT void 
setBadgeLabelText(const QString );
QT_DEPRECATED_X("Use NSApp.dockTile.badgeLabel") Q_MACEXTRAS_EXPORT QString 
badgeLabelText();

QT_DEPRECATED_X("Use QPixmap::toImage, QImage::toCGImage, and -[NSImage 
initWithCGImage:size:]")
Q_MACEXTRAS_EXPORT NSImage *toNSImage(const QPixmap );
#endif
  
  Thoughts on the best way forward for macOS builds?
  
  This change due to being in a Framework has KOed all Binary Factory builds 
for macOS.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19455

To: mlaurent, dfaure
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns