KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/90/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 01 May 2019 03:58:30 +
 Build duration:
22 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9873)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/93/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 01 May 2019 03:58:30 +
 Build duration:
4 min 29 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/83/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 01 May 2019 03:58:29 +
 Build duration:
8 min 12 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1819/9873)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(315/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

D20844: KTar::KTarPrivate::readLonglink: Fix crash in malformed files

[Albert Astals Cid]

aacid updated this revision to Diff 57296.
aacid edited the summary of this revision.
aacid added a comment.


  better fix

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20844?vs=57042=57296

BRANCH
  arcpatch-D20844

REVISION DETAIL
  https://phabricator.kde.org/D20844

AFFECTED FILES
  src/ktar.cpp

To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19455: [knotification] compile without deprecated methods

[Albert Astals Cid]

aacid added a comment.


  In D19455#457849 , @bcooksley 
wrote:
  
  > I'm fine with either fix, any objection to that being committed directly?
  
  
  Sorry if you were waiting for me, sure just go ahead

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D19455

To: mlaurent, dfaure
Cc: aacid, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar updated this revision to Diff 57293.
loh.tar edited the summary of this revision.
loh.tar added a comment.


  - ShowScrollBarPreview
  - ShowScrollBarMarks
  - ShowLineNumbers
  - Add some validator functions, please look at them

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20924?vs=57285=57293

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  autotests/src/vimode/base.cpp
  src/dialogs/katedialogs.cpp
  src/document/katedocument.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: New framework: KCalCore

[Allen Winter]

Clazy is complaining about missing assign operators.  Do we care?
If so, I can take a look at adding them or if anyone else wants to do that.
-Allen

./src/calendar.cpp
line 305: for (it = vals.constBegin(); it != vals.constEnd(); ++it) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has 
copy-ctor but no assign operator

./src/calfilter.cpp
line 161: for (it = attendees.begin(); it != attendees.end(); ++it) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has 
copy-ctor but no assign operator

./src/freebusy.cpp
line 120: for (it = eventList.constBegin(); it != eventList.constEnd(); 
++it) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has copy-ctor 
but no assign operator
line 299: for (it = periods.constBegin(); it != periods.constEnd(); ++it) {
=> Using assign operator but class 
QTypedArrayData::const_iterator has copy-ctor but no assign 
operator

./src/icalformat_p.cpp
line 628: for (atIt = attachments.constBegin(); atIt != 
attachments.constEnd(); ++atIt) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has 
copy-ctor but no assign operator

./src/icaltimezones.cpp
line 493: begin = phase.transitions.cbegin();
=> Using assign operator but class 
QTypedArrayData::const_iterator has copy-ctor but no assign operator

./src/incidencebase.cpp
line 513: for (it = d->mAttendees.constBegin(); it != 
d->mAttendees.constEnd(); ++it) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has 
copy-ctor but no assign operator
line 530: for (itA = d->mAttendees.constBegin(); itA != 
d->mAttendees.constEnd(); ++itA) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has 
copy-ctor but no assign operator
line 544: for (it = d->mAttendees.constBegin(); it != 
d->mAttendees.constEnd(); ++it) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has 
copy-ctor but no assign operator

./src/vcalformat.cpp
line 1603: for (eIt = d->mEventsRelate.constBegin(); eIt != 
d->mEventsRelate.constEnd(); ++eIt) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has copy-ctor 
but no assign operator
line 1607: for (tIt = d->mTodosRelate.constBegin(); tIt != 
d->mTodosRelate.constEnd(); ++tIt) {
=> Using assign operator but class 
QTypedArrayData >::const_iterator has copy-ctor 
but no assign operator


 Sunday, April 7, 2019 8:45:09 AM EDT Volker Krause wrote:
> Hi,
> 
> I'd like to propose KCalCore for review to move from KDE PIM to KF5.
> 
> KCalCore is an implementation of the iCalendar standard based on libical, 
> covering the data model, input/output and the rather complex recurrence 
> algorithms defined in that standard. It's used outside of KDE PIM as well, 
> e.g. by Zanshin or the Plasma Mobile calendar app.
> 
> KCalCore depends on Qt and libical only, making it a Tier 1 functional 
> framework.
> 
> KCalCore used to be part of part of kdepimlibs in the KDE4 era, so it's well 
> prepared for complying with the API and ABI guarantees.
> 
> I'd suggest the same timeline as proposed for KContacts [1]. During the PIM 
> sprint we did a number of fixes and cleanups as part of the review for KF5 
> that make 19.08 the earliest release after which we can switch as well, so we 
> are looking at a switch in Sep/Oct this year.
> 
> 
> Thanks,
> Volker
> 
> [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2019-April/084057.html

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar added a comment.


  Ah, last hint: The diff is not against master. Should you really like to try 
it, I can fix that earlier, otherwise will do it when I'm done

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20924

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20924: [WIP] ViewConfig: Use new generic config interface

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Done so far:
  
  - DynWordWrapAlignIndent
  - DynWordWrapIndicators
  - DynWrapAtStaticMarker
  - DynamicWordWrap
  - ShowWordCount
  - MaxHistorySize
  - SearchFlags
  - BackspaceRemoveComposedCharacters

TEST PLAN
  Please take a look, point me to mistakes, but wait until WIP is gone for a 
final "OK"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20924

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/dialogs/katedialogs.cpp
  src/search/katesearchbar.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateview.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D17693: Add option to treat some chars also as "auto bracket" only when we have a selection

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think this would be some initial solution for this issue. An highlighting 
specific config would be even cooler, but giving the user the choice to add 
additional chars (or alter the wanted ones) is definitely a step in the right 
direction.
  Therefore I would say: proceed with this.
  I think it would be best to have as default value here the current chars that 
we use to allow people even to remove some they dislike.
  With the new config entry framework we can even expose this as mode-line 
thing later.

REVISION DETAIL
  https://phabricator.kde.org/D17693

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: ngraham, mwolff, cullmann, sars, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, domson, michaelh, bruns, demsking, dhaumann

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 91 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/91/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 30 Apr 2019 17:32:37 +
 Build duration:
6 min 34 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3661/4314)48%
(5109/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1272/1302)49%
(2548/5221)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/90/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 30 Apr 2019 17:24:33 +
 Build duration:
8 min 3 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3661/4314)48%
(5109/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1272/1302)49%
(2548/5221)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/85/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 30 Apr 2019 17:30:42 +
 Build duration:
1 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3661/4314)48%
(5109/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1272/1302)49%
(2548/5221)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 84 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/84/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 30 Apr 2019 17:24:32 +
 Build duration:
6 min 8 sec and counting
   BUILD ARTIFACTS
  acc/KF5FileMetaData-5.58.0.xmllogs/KF5FileMetaData/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.taglibextractortestFailed: projectroot.autotests.taglibwritertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)89%
(55/62)89%
(55/62)85%
(3661/4314)48%
(5109/10703)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(18/18)100%
(18/18)98%
(1272/1302)49%
(2548/5221)src79%
(23/29)79%
(23/29)79%
(1216/1538)43%
(493/1140)src.extractors100%
(13/13)100%
(13/13)78%
(965/1238)46%
(1664/3594)src.writers100%
(1/1)100%
(1/1)99%
(208/210)54%
(404/742)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/6)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 90 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/90/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 30 Apr 2019 17:25:51 +
 Build duration:
1 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

KDE CI: Frameworks » kfilemetadata » kf5-qt5 FreeBSDQt5.12 - Build # 89 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/89/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 30 Apr 2019 17:24:33 +
 Build duration:
1 min 15 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.extractorcoveragetest

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:c14869f1b9af: [TaglibExtractor] Feed non-ogg *.spx file 
into extractor test (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20914?vs=57230=57282

REVISION DETAIL
  https://phabricator.kde.org/D20914

AFFECTED FILES
  autotests/samplefiles/misdetected/test_arcgis_geodata.spx
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20913: [TagLibExtractor] Fix crash on invalid Speex files

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:61b1916c3e87: [TagLibExtractor] Fix crash on invalid 
Speex files (authored by bruns).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20913?vs=57229=57281

REVISION DETAIL
  https://phabricator.kde.org/D20913

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20918: [balooctl] Add command to show files failed to index

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:74c8fcf5bb0d: [balooctl] Add command to show files failed 
to index (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20918?vs=57251=57280

REVISION DETAIL
  https://phabricator.kde.org/D20918

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

[Alexander Stippich]

astippich accepted this revision.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Nathaniel Graham]

ngraham added a comment.


  Any news on this @emateli? I'd really love to see it in Dolphin!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D20913: [TagLibExtractor] Fix crash on invalid Speex files

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.


  Given the outcome, I wish I never added support for speex files to the 
extractor because it was "easy to add".

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20913

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20903: Fix bookmark pixmap painting on icon bar

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:08d1537b7565: Fix bookmark pixmap painting on icon bar 
(authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20903?vs=57203=57268

REVISION DETAIL
  https://phabricator.kde.org/D20903

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20897: Ensure the left border miss no change of the count of line number digits

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:34fec148d283: Ensure the left border miss no change of the 
count of line number digits (authored by loh.tar).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20897?vs=57180=57267

REVISION DETAIL
  https://phabricator.kde.org/D20897

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20913: [TagLibExtractor] Fix crash on invalid Speex files

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Gross! Confirmed the fix.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20913

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20914: [TaglibExtractor] Feed non-ogg *.spx file into extractor test

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice.

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20914

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20918: [balooctl] Add command to show files failed to index

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Quite nice, quite nice.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20918

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20918: [balooctl] Add command to show files failed to index

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Baloo was missing any means to retrieve the list of files which failed
  to index.
  
  CCBUG: 406116

TEST PLAN
  $> balooctl failed

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20918

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/tools/balooctl/main.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20630: [Dialog] Add CriticalNotification type

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D20630

To: broulik, #plasma, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20897: Ensure the left border miss no change of the count of line number digits

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20897

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D20903: Fix bookmark pixmap painting on icon bar

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20903

To: loh.tar, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann