D20838: Allow to drop one file or one folder on KDirOperator

[Méven Car]

meven updated this revision to Diff 57441.
meven added a comment.


  Fix an issue where the closuser would be called for each finished event once 
set

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57124&id=57441

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

[Méven Car]

meven updated this revision to Diff 57442.
meven added a comment.


  Grab the focus so that the currentItem becomes the kfilewidget selected item, 
otherwise the user needs to give the kdiroperator the focus first

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20838?vs=57441&id=57442

BRANCH
  arcpatch-D20838

REVISION DETAIL
  https://phabricator.kde.org/D20838

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  tests/kfilewidgettest_gui.cpp

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Having to maintain and sync the module identifier in multiple places and
  variants runs the chance of missing one place when changing it.
  Also is having to explicitly writing the qmldir file cumbersome when the
  buildsystem already has all needed information.
  
  For now there is just one macro, for the installation of C++ plugins. Future
  extension might be macros for the installation of QML files modules.
  Further extension could also allow to specifiy additional content of the
  qmldir, like "depends", "designersupported" & Co.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMInstallQmlModules.rst
  modules/ECMInstallQmlModules.cmake

To: kossebau, #plasma
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Possibly the ECMGenerateQmlTypes 
 could be also merged 
somehow, but I have no experience with that, so leaving to someone else to 
improve here.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Even more noticeable when using high dpi (Plasmashell doesn't use scaling on 
X): 
  Before
  F6805353: Screenshot_20190503_105021.png 

  After
  F6805355: Screenshot_20190503_105047.png 


REPOSITORY
  R296 KDeclarative

BRANCH
  same-button-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20977

To: filipf, #vdg, ngraham, #frameworks, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  same-button-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20977

To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20986: Don't call click on the delegate, when we just want it to become current item

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  If you have any actions in your GridDelegate, activating them would previously
  cause the delegate's onClicked signal to fire, which isn't always desirable.
  
  The logic behind the original code was that it was supposed to set that item
  as the current one in the gridview, so a little bit of working around nested
  delegates (understandably) not forwarding models, and we have the ability to
  set the delegate as the current item.

TEST PLAN
  See any KCM which performs an action on clicking the thumbnail, and which has 
actions
  
  - Prior to patch, both the action and the thumbnail slot would be called
  - With this patch, only the action is called

REPOSITORY
  R296 KDeclarative

BRANCH
  dont-click-just-set-current (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20986

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: leinir, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 57450.
kossebau added a comment.


  Add DEPENDS & DESIGNERSUPPORTED, nothing complicated there (besides going
  for asking string with pair of identifier & version, to avoid any arg clash
  & make parsing easier)

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=57444&id=57450

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMInstallQmlModules.rst
  modules/ECMInstallQmlModules.cmake

To: kossebau, #plasma
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma
Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20986: Don't call click on the delegate, when we just want it to become current item

[Kai Uwe Broulik]

broulik added a comment.


  -1
  
  Most KCMs actually use `onClicked` to update the selected plugin and other 
bits. They don't actually set `currentIndex` on the `ListView` directly but 
have it updated based on whatever current scheme or theme etc is selected.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20986

To: leinir, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20986: Don't call click on the delegate, when we just want it to become current item

[Dan Leinir Turthra Jensen]

leinir added a comment.


  In D20986#460112 , @broulik wrote:
  
  > -1
  >
  > Most KCMs actually use `onClicked` to update the selected plugin and other 
bits. They don't actually set `currentIndex` on the `ListView` directly but 
have it updated based on whatever current scheme or theme etc is selected.
  >
  > Can it be fixed such that the `onClicked` isn't fired when the action is 
invoked? From what I can see the actions don't rely on `currentIndex`
  
  
  Unless i'm misunderstanding you, that's precisely what this code does - 
onClicked still gets triggered when clicking the thumbnail itself, this patch 
only affects the action buttons. The previous code was specifically added to 
set the current index, according to Nate in 
https://phabricator.kde.org/D18649#459586 :)

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20986

To: leinir, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20986: Don't call click on the delegate, when we just want it to become current item

[Kai Uwe Broulik]

broulik added a comment.


  oh, crap, right, I thought that was the delegate code, not the buttons.
  
  I think it just shouldn't do anything then since when changing the 
`currentIndex` if the KCM isn't prepared for that might cause the visual index 
and actual selected setting to become out of sync.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20986

To: leinir, ngraham
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20955: use actually existing breeze icon for the new file Program.desktop

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b127112914df: use actually existing breeze icon for the 
new file Program.desktop (authored by sitter).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20955?vs=57368&id=57451

REVISION DETAIL
  https://phabricator.kde.org/D20955

AFFECTED FILES
  src/new_file_templates/Program.desktop

To: sitter, #vdg, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/98/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 10:18:53 +
 Build duration:
8 min 28 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D7732: Force KAuth helpers to have UTF-8 support

[David Edmundson]

davidedmundson closed this revision.
davidedmundson added a comment.


  This was merged, phabricator ignored it for some reason

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D7732

To: davidedmundson, apol, aacid
Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 101 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/101/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 May 2019 10:18:54 +
 Build duration:
25 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.58.0.xmllogs/KF5KIO/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/399)66%
(264/399)54%
(33015/60673)39%
(16908/43781)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9332/9782)48%
(4303/9029)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8474/14446)51%
(4719/9225)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)54%
(4342/8044)40%
(1878/4697)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(578/1082)39%
(345/888)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4291)35%
(1296/3672)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Aleix Pol Gonzalez]

apol added a comment.


  wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the 
code is to construct the file.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D20958: New menu of syntax highlighting in the status bar

[Nibaldo González]

nibags added a comment.


  Thanks for the comments, in a while I will update the diff with the 
suggestions/corrections.
  
  > The only thing I would like to have is an auto generated "most often used" 
list. That was also suggested somewhere. This way you could quickly change 
between preferred styles instead to search for them.
  
  I could add a "Recent" section to the beginning of the menu, it would be 
useful.
  
  > When the menu is opened, clear any text in the search field left over from 
a prior search
  
  Also I could keep all the search text as selected, to delete it with a single 
button.
  I hope more comments about it, I'm not sure which will be the best option: S
  
  > Single-clicking on an item in the list should select it and close the menu; 
double-click doesn't gain us anything here
  
  To me the double-click works correctly. It may also be necessary to add a 
special case for double-click to avoid problems.
  
  > .cp does not show c++, same for cp
  
  I checked the XML file of "C++", and `*.cp` isn't an extension associated 
with that language, so it isn't displayed.
  
  > These ctrl-return is handy! Would be good to have this on right or middle 
too or in conjunction with some modifier key alt/ctrl/shift
  
  Good idea! I will also add shift and alt and combinations.
  
  > The blue frame (in dark theme) looks compared to the other plain menus 
slightly strange, any possibility to remove this?
  
  You can erase the edge, but I'm not sure if the brightness. I will try, 
although I don't know if it will be a good idea, since that brightness 
indicates that the widget is in focus.
  As @ngraham says, it might be better to reduce the brightness in the Breeze 
Dark theme.
  
  > Is your new great menu easy usable for other parts? Like the encoding?
  
  It could be done. I would have to separate the menu into two classes that are 
inherited, one with the menu only, so that it can be implemented elsewhere.
  
  > As first feedback: much better than current state :)
  
  ;-D

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, bruns, demsking, sars, dhaumann

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D20984#460128 , @apol wrote:
  
  > wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the 
code is to construct the file.
  
  
  You mean, replace `file(GENERATE` with `file(WRITE ... qmldir)`? Might be an 
idea now given the code has grown, will give a try later today.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D20984

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D20959: Allow to change the Mode, after changing the Highlighting

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0a6ea0624228: Allow to change the Mode, after changing the 
Highlighting (authored by nibags).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20959?vs=57373&id=57455

REVISION DETAIL
  https://phabricator.kde.org/D20959

AFFECTED FILES
  src/document/katedocument.cpp

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 57457.
kossebau added a comment.


  Use file(WRITE/APPEND) over file(GENERATE), for less intermediate vars

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=57450&id=57457

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMInstallQmlModules.rst
  modules/ECMInstallQmlModules.cmake

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:a2e42b49: [KeySequenceItem] Make the clear button 
have the same height as shortcut button (authored by filipf).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20977?vs=57420&id=57458

REVISION DETAIL
  https://phabricator.kde.org/D20977

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 57459.
kossebau added a comment.


  get rid of newer list(TRANSFORM)

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=57457&id=57459

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMInstallQmlModules.rst
  modules/ECMInstallQmlModules.cmake

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D20983: Exclude .gcode and .vdi files from indexing consideration

[Nathaniel Graham]

ngraham updated this revision to Diff 57460.
ngraham added a comment.


  Add more useless Virtualbox files that Baloo shouldn't try to index

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20983?vs=57432&id=57460

BRANCH
  more-excluded-files (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20983

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ngraham, bruns, #baloo
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20983: Exclude .gcode and .vdi files from indexing consideration

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D20983

To: ngraham, bruns, #baloo
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D20938: Add Mounts Backend

[Nathaniel Graham]

ngraham added a comment.


  In D20938#460029 , @hallas wrote:
  
  > I have tried to modify the fstab backend to also show fuse mounts and a 
//very// simple prototype is this:
  >
  >   diff --git a/src/solid/devices/backends/fstab/fstabhandling.cpp 
b/src/solid/devices/backends/fstab/fstabhandling.cpp
  >   index 63130c6..3632b52 100644
  >   --- a/src/solid/devices/backends/fstab/fstabhandling.cpp
  >   +++ b/src/solid/devices/backends/fstab/fstabhandling.cpp
  >   @@ -121,6 +121,11 @@ bool _k_isFstabNetworkFileSystem(const QString 
&fstype, const QString &devName)
  >return false;
  >}
  >   
  >   +bool _k_isFstabFuseFileSystem(const QString &fstype)
  >   +{
  >   +return fstype.startsWith(QLatin1String("fuse."));
  >   +}
  >   +
  >void 
Solid::Backends::Fstab::FstabHandling::_k_updateFstabMountPointsCache()
  >{
  >if (globalFstabCache->m_fstabCacheValid) {
  >   @@ -288,7 +293,7 @@ void 
Solid::Backends::Fstab::FstabHandling::_k_updateMtabMountPointsCache()
  >STRUCT_MNTENT fe;
  >while (GETMNTENT(mnttab, fe)) {
  >QString type = QFile::decodeName(MOUNTTYPE(fe));
  >   -if (_k_isFstabNetworkFileSystem(type, QString())) {
  >   +if (_k_isFstabNetworkFileSystem(type, QString()) || 
_k_isFstabFuseFileSystem(type)) {
  >const QString device = QFile::decodeName(FSNAME(fe));
  >const QString mountpoint = QFile::decodeName(MOUNTPOINT(fe));
  >globalFstabCache->m_mtabCache.insert(device, mountpoint);
  >
  >
  > the only caveat is that the mount points shows up in the "Remote" list, but 
that is probably easy to fix.
  
  
  Yeah, that'll be fixable in 
https://cgit.kde.org/kio.git/tree/src/filewidgets/kfileplacesmodel.cpp

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20938

To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns
Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

D20958: New menu of syntax highlighting in the status bar

[Nathaniel Graham]

ngraham added a comment.


  In D20958#460130 , @nibags wrote:
  
  > > Single-clicking on an item in the list should select it and close the 
menu; double-click doesn't gain us anything here
  >
  > To me the double-click works correctly. It may also be necessary to add a 
special case for double-click to avoid problems.
  
  
  Double-click is not the correct UX here. Here is the rule for when something 
should be double-clickable:
  
  - Is the item selectable, and when selected, you can perform more than one 
action with it?
- If so, make it double-clickable and expose those actions while it is 
selected.
- If not, because the only action available is "activate this item", make 
it only single-clickable, even when using the systemwide double-click setting. 
This is for example why buttons are always single-clickable: if they were 
selectable, there would still be only one thing you can do with them 
("activate").
  
  I need to finally put this in a HIG page...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, bruns, demsking, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[loh tar]

loh.tar added a comment.


  
  
  > I could add a "Recent" section to the beginning of the menu, it would be 
useful.
  
  Nice! Just to be clear. That should to be work over session borders, not only 
the current one.
  
  >> The blue frame (in dark theme) looks compared to the other plain menus 
slightly strange, any possibility to remove this?
  > 
  > You can erase the edge, but I'm not sure if the brightness..., since that 
brightness indicates that the widget is in focus.
  
  These focus is in general fine, and I didn't wanted to poke around here to 
get rid of it. Just to use perhaps some differend construction of these popup. 
Know idea what exactly :-) These "edge" may enough.
  
  >> Is your new great menu easy usable for other parts? Like the encoding?
  > 
  > It could be done.
  
  Nice! Maybe on Kde-Wide level? :-) But Kate-Only as first step may great 
enough.
  
  >> .cp does not show c++, same for cp
  > 
  > I checked the XML file of "C++", and *.cp isn't an extension associated 
with that language, so it isn't displayed.
  
  It's a little strange that while enter "c-p-p" it is shown/gone/shown iirc. 
How about some fuzzy search?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: cullmann, ngraham, loh.tar, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, bruns, demsking, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> katemodemenulist.cpp:65
> +m_list->setVerticalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
> +m_list->setIconSize(QSize(16, 16));
> +m_list->setResizeMode(QListView::Adjust);

As well for icon size.

> katemodemenulist.cpp:129
> + */
> +const int maxWidthText = m_list->sizeHint().width() - 
> m_scroll->sizeHint().width() - 28;
> +

You can make a static const int iconSize = 16 or something to use it everywhere?

> katemodemenulist.cpp:141
> +if ( !hl->translatedSection.isEmpty() && (prevHlSection == nullptr 
> || hl->translatedSection != *prevHlSection) ) {
> +QPixmap transparent = QPixmap(8, 8);
> +transparent.fill(Qt::transparent);

Here as well, if it's 16/2

> katemodemenulist.cpp:266
> +if (m_selectedItem) {
> +QPixmap emptyIcon(16, 16);
> +emptyIcon.fill(Qt::transparent);

Ditto

> katemodemenulist.cpp:407
> +// set empty icon
> +QPixmap emptyIcon(16, 16);
> +emptyIcon.fill(Qt::transparent);

Ditto

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars, dhaumann

D20958: New menu of syntax highlighting in the status bar

[Anthony Fieroni]

anthonyfieroni added a comment.


  dymanic_cast is expensive, prefer qobject_cast if you want to check result 
against nullptr, if you don't want - static_cast.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars, dhaumann

D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20977

To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson
Cc: abetts, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

[Nathaniel Graham]

ngraham added a task: T8552: Polish Open/Save dialogs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20838

To: meven, ngraham
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20939: Aztec: Fix padding if the last partial codeword is all one bits

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:608370e85a77: Aztec: Fix padding if the last partial 
codeword is all one bits (authored by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20939?vs=57321&id=57466

REVISION DETAIL
  https://phabricator.kde.org/D20939

AFFECTED FILES
  autotests/aztecbarcodetest.cpp
  src/lib/aztecbarcode.cpp

To: vkrause, svuorela, nicolasfella
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> ngraham wrote in kfilewidget.cpp:745
> I did it in `setMimeFilter` since that's where it's determined whether or not 
> there's a limited assortment of mimetypes, which is what controls what the 
> string should be. Conditionalizing it based on mode seemed safe enough 
> considering that there's mode-specific code a few lines above, on 741.

::setOperationMode would need to update that as well, no? Then it would need 
splitting into a separate function, otherwise 
setOperationMode(Saving); setOperationMode(Opening) will have the wrong 
behaviour.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, ngraham, hallas.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Currently, the fstab backend only lists NFS and SMB share, although
  the majority of the code could handle any other file system, e.g.
  encfs.fuse used for Vaults.
  
  Fix up description to make it more generic, and restructure
  devicesFromQuery() to allow extension for other Solid interfaces. The
  apparent code duplication will go away as soon as e.g. the
  StorageVolume interface has to be handled.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20990

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabmanager.cpp

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, ngraham, hallas.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  This is required for efficient lookup of the device filesystem
  
  Depends on D20990 

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20991

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

[Stefan Brüns]

bruns added a dependent revision: D20991: [FsTab] Add cache for device file 
system type.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20990

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, ngraham, hallas.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  solid-hardware list details:
  
udi = '/org/kde/fstab/fuse.encfs/home/stefan/Vaults/TestVault'
  parent = '/org/kde/fstab'  (string)
  vendor = 'fuse.encfs'  (string)
  product = '~/Vaults/TestVault'  (string)
  description = '~/Vaults/TestVault (fuse.encfs)'  (string)
  icon = 'folder'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/home/stefan/Vaults/TestVault'  (string)
  StorageAccess.ignored = false  (bool)

udi = '/org/kde/fstab/fuse.cryfs/home/stefan/Vaults/CryTest'
  parent = '/org/kde/fstab'  (string)
  vendor = 'fuse.cryfs'  (string)
  product = '~/Vaults/CryTest'  (string)
  description = '~/Vaults/CryTest (fuse.cryfs)'  (string)
  icon = 'folder'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/home/stefan/Vaults/CryTest'  (string)
  StorageAccess.ignored = false  (bool)

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20995

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

[Stefan Brüns]

bruns added a dependent revision: D20995: [Fstab] Add support for non-network 
filesystems.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20991

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

[Stefan Brüns]

bruns edited the summary of this revision.
bruns added a dependency: D20991: [FsTab] Add cache for device file system type.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 57481.
kossebau added a comment.


  Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes
  
  This allows e.g. to replace
  
install(TARGETS platformcomponentsplugin DESTINATION 
${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponents)
install(FILES qmldir DESTINATION 
${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponents)

ecm_generate_qmltypes(org.kde.plasma.platformcomponents 2.0 DESTINATION 
${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponents)
  
  and the file qmldir
  
module org.kde.plasma.platformcomponents
plugin platformcomponentsplugin
  
  with this code
  
ecm_install_qmlplugin(platformcomponentsplugin
IDENTIFIER org.kde.plasma.platformcomponents
DESTINATION ${KDE_INSTALL_QMLDIR}
TYPEINFO plugins.qmltypes
VERSION 2.0
)
  
  which avoids the need for repeating and ensures consistent data, even more
  when creating new plugins or changing names.

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20984?vs=57459&id=57481

BRANCH
  addinstallqmlplugin

REVISION DETAIL
  https://phabricator.kde.org/D20984

AFFECTED FILES
  docs/module/ECMInstallQmlModules.rst
  modules/ECMInstallQmlModules.cmake

To: kossebau, #plasma
Cc: apol, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, 
bruns

D20995: [Fstab] Add support for non-network filesystems

[Stefan Brüns]

bruns added a comment.


  F6806745: Screenshot_20190503_180519.png 


REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11820: Handle properties with multiple values

[Alexander Stippich]

astippich commandeered this revision.
astippich added a reviewer: michaelh.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11820

To: astippich, #baloo, #frameworks, michaelh
Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, 
spoorun, abrahams

D11820: Handle properties with multiple values

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D11820

To: astippich, #baloo, #frameworks, michaelh
Cc: bruns, astippich, mgallien, elvisangelaccio, gennad, domson, ashaposhnikov, 
spoorun, abrahams

D20999: IconItem: remove remaining & unused smooth property bits

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  fix-up for 18a2ca50ab092e27a3464fca8d515cb7791c7d5a 


REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  removelastsmoothbits

REVISION DETAIL
  https://phabricator.kde.org/D20999

AFFECTED FILES
  src/declarativeimports/core/iconitem.h

To: kossebau, #plasma, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  The Q_PLUGIN_METADATA IID should be the one of the implemented interface.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixiid

REVISION DETAIL
  https://phabricator.kde.org/D21000

AFFECTED FILES
  src/declarativeimports/platformcomponents/platformextensionplugin.cpp

To: kossebau, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21001: Update *.qmltypes to current API of QML modules

[Friedrich W. H. Kossebau]

kossebau added a comment.


  I am not exactly sure why the diff is so large, compared to last run in 2017? 
Done against Qt 5.12.3 on my openSUSE TW.
  
  I also got the log ouput
  
Could not find any platform plugin
  
  not sure if this is any relevant on calculating the deps, should not, or?
  
  Diff anticipates already the acceptance of D20999 
 (which I actually found when looking at 
this diffs :) ).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21001

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21001: Update *.qmltypes to current API of QML modules

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Plasma, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  updateqmltypes

REVISION DETAIL
  https://phabricator.kde.org/D21001

AFFECTED FILES
  src/declarativeimports/calendar/plugins.qmltypes
  src/declarativeimports/core/plugins.qmltypes
  src/declarativeimports/plasmacomponents/plugins.qmltypes
  src/declarativeimports/plasmaextracomponents/plugins.qmltypes
  src/declarativeimports/platformcomponents/plugins.qmltypes

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21002: Remove kde4 migration agent completely

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The migration agent is some quite weird mechanism:
  
  - it starts the KDE4 kwalletd
  - to do this, it asks DBus to start it
  - as the old kwalletd never shipped a service file, kwalletd5 ships a service 
file for kwalletd(4), hardcoding its likely path.
  - it merges the old wallets via DBus requests
  
  When the migration has finished, a flag is set in the config and on the
  next start, the migration agent is skipped. When the migration fails
  (e.g. because kwalletd(4) is not installed), the migration is attempted
  on each start.
  
  Shipping a a service file pointing to the old daemon also breaks
  autostart of kwalletd5 for old applications - kwalletd5 provides the
  kwalletd interface, but only if it has been started already. This leads
  to a race during startup.
  
  See D16520  - proper kwalletd dbus 
service file for the legacy name
  CCBUG: 400462

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21002

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/kwalletd.h
  src/runtime/kwalletd/main.cpp
  src/runtime/kwalletd/migrationagent.cpp
  src/runtime/kwalletd/migrationagent.h
  src/runtime/kwalletd/migrationwizard.cpp
  src/runtime/kwalletd/migrationwizard.h
  src/runtime/kwalletd/migrationwizard1.ui
  src/runtime/kwalletd/migrationwizard2.ui
  src/runtime/kwalletd/org.kde.kwalletd.service

To: bruns, #frameworks, cfeck
Cc: kde-frameworks-devel, damjang, michaelh, ngraham, bruns

D20515: KCharSelect: add unittest. Hits the assert in QHeaderView.

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:b93ef73701a2: KCharSelect: add unittest. Hits the assert 
in QHeaderView. (authored by dfaure).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20515?vs=56155&id=57490

REVISION DETAIL
  https://phabricator.kde.org/D20515

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcharselect_unittest.cpp
  src/kcharselect.cpp
  src/kcharselect_p.h

To: dfaure, cfeck, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.12 - Build # 31 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.12/31/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 17:46:18 +
 Build duration:
1 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcharselect_unittest

D20516: KCharSelect: remove unnecessary call

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d47a8fa3010b: KCharSelect: remove unnecessary call 
(authored by dfaure).
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20516?vs=56156&id=57491

REVISION DETAIL
  https://phabricator.kde.org/D20516

AFFECTED FILES
  src/kcharselect.cpp

To: dfaure, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 30 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/30/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 May 2019 17:46:18 +
 Build duration:
3 min 15 sec and counting
   BUILD ARTIFACTS
  acc/KF5WidgetsAddons-5.58.0.xmllogs/KF5WidgetsAddons/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcharselect_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)42%
(70/168)42%
(70/168)30%
(4549/15067)22%
(1734/7823)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests95%
(19/20)95%
(19/20)99%
(1662/1679)50%
(799/1610)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src45%
(51/114)45%
(51/114)24%
(2887/12264)15%
(935/6056)tests0%
(0/33)0%
(0/33)0%
(0/1107)0%
(0/155)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.12 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.12/32/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 17:47:58 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcharselect_unittestFailed: projectroot.autotests.ksqueezedtextlabelautotest

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Nathaniel Graham]

ngraham updated this revision to Diff 57493.
ngraham added a comment.


  Revert unintentional change to `KFileWidget::currentMimeFilter()`

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20964?vs=57492&id=57493

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Nathaniel Graham]

ngraham updated this revision to Diff 57492.
ngraham marked 3 inline comments as done.
ngraham added a comment.


  Put it in a function and then call that function in all the places where 
things might change

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20964?vs=57383&id=57492

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.10/31/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 May 2019 17:49:34 +
 Build duration:
2 min 59 sec and counting
   BUILD ARTIFACTS
  acc/KF5WidgetsAddons-5.58.0.xmllogs/KF5WidgetsAddons/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcharselect_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)43%
(73/168)43%
(73/168)32%
(4777/15081)23%
(1774/7823)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1671/1681)50%
(800/1610)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src46%
(53/114)46%
(53/114)25%
(3106/12276)16%
(974/6056)tests0%
(0/33)0%
(0/33)0%
(0/1107)0%
(0/155)

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 25 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 May 2019 17:46:18 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  acc/KF5WidgetsAddons-5.58.0.xmllogs/KF5WidgetsAddons/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcharselect_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)43%
(73/168)43%
(73/168)32%
(4771/15080)23%
(1773/7823)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1671/1681)50%
(800/1610)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src46%
(53/114)46%
(53/114)25%
(3100/12275)16%
(973/6056)tests0%
(0/33)0%
(0/33)0%
(0/1107)0%
(0/155)

D16116: [KPropertiesDialog] Show a filename for the / directory

[Stefan Brüns]

bruns added a comment.


  Is this still relevant - for me, the properties dialog has "Properties for /".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 May 2019 18:00:51 +
 Build duration:
4 min 6 sec and counting
   BUILD ARTIFACTS
  acc/KF5WidgetsAddons-5.58.0.xmllogs/KF5WidgetsAddons/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kcharselect_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)43%
(73/168)43%
(73/168)32%
(4771/15080)23%
(1773/7823)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(20/20)100%
(20/20)99%
(1671/1681)50%
(800/1610)examples.kmessagebox0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/2)src46%
(53/114)46%
(53/114)25%
(3100/12275)16%
(973/6056)tests0%
(0/33)0%
(0/33)0%
(0/1107)0%
(0/155)

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20990

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:144
> +const QString fstype = QFile::decodeName(fe->mnt_type);
> +if (_k_isFstabNetworkFileSystem(fstype, fsname)) {
>  const QString mountpoint = QFile::decodeName(fe->mnt_dir);

Only network mounts?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20991

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20995: [Fstab] Add support for non-network filesystems

[Nathaniel Graham]

ngraham added a comment.


  Nice! Can we make the Places panel display the product rather than the 
description? I don't think it's necessary to have the fs type listed there in 
the label. Interested parties can always look that up in the Properties dialog.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20995

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20990: [Fstab] Preparatory work for enabling filesystems beyond NFS/SMB

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:7aad0e183b3d: [Fstab] Preparatory work for enabling 
filesystems beyond NFS/SMB (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20990?vs=57473&id=57501

REVISION DETAIL
  https://phabricator.kde.org/D20990

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabmanager.cpp

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/25/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 18:46:18 +
 Build duration:
2 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D20967: [UserMetaData] Add method to query which attributes are set

[Stefan Brüns]

bruns added a dependent revision: D21004: [UserMetaData] Shortcut attribute 
queries for the common case.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D20967

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D21004: [UserMetaData] Shortcut attribute queries for the common case

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added a project: Baloo.
bruns requested review of this revision.

REVISION SUMMARY
  Optimize the common case of only a few or no attributes set, no functional
  changes.

TEST PLAN
  ctest
  
  Depends on D20967 

REPOSITORY
  R824 Baloo Widgets

BRANCH
  bulk_query

REVISION DETAIL
  https://phabricator.kde.org/D21004

AFFECTED FILES
  src/filemetadatautil.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: gennad, domson, ashaposhnikov, astippich, spoorun, abrahams

D20991: [FsTab] Add cache for device file system type

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> ngraham wrote in fstabhandling.cpp:144
> Only network mounts?

Others are added in D20995 

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20991

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

[Stefan Brüns]

bruns marked an inline comment as done.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D20991

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20991

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20991: [FsTab] Add cache for device file system type

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:a0320ae774fe: [FsTab] Add cache for device file system 
type (authored by bruns).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20991?vs=57474&id=57509

REVISION DETAIL
  https://phabricator.kde.org/D20991

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabhandling.cpp
  src/solid/devices/backends/fstab/fstabhandling.h

To: bruns, #frameworks, ngraham, hallas
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/26/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 19:18:33 +
 Build duration:
1 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D20924: ViewConfig: Use new generic config interface

[Dominik Haumann]

dhaumann added a comment.


  PS: I know this comment comes too late, but this could have waited 2 more 
days after the next KF5 tag  tomorrow :-) we had 1 day of testing now. Maybe we 
are lucky and there is no regression - let's try now.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20924

To: loh.tar, #ktexteditor, dhaumann, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, 
domson, michaelh, ngraham, bruns, demsking, sars

D20958: New menu of syntax highlighting in the status bar

[Dominik Haumann]

dhaumann added a comment.


  My comments are very vague, but I think this patch could even be better. Only 
did a review half through due to lack of time.

INLINE COMMENTS

> katemodemenulist.h:141
> + */
> +class ModeListWidget : public QListWidget
> +{

Can you make this a QListView? I once heard the QListWidget will be deprecated 
in Qt6, rule of thumb is: always use Q***View instead of Q***Widget, since this 
then will also work in QML.

> katemodemenulist.h:175
> + */
> +class ModeListWidgetItem : public QListWidgetItem
> +{

This should use QStandardItem, iiuc.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20958

To: nibags, #ktexteditor, #kate, #vdg
Cc: dhaumann, anthonyfieroni, cullmann, ngraham, loh.tar, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  fixiid

REVISION DETAIL
  https://phabricator.kde.org/D21000

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20999: IconItem: remove remaining & unused smooth property bits

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  removelastsmoothbits

REVISION DETAIL
  https://phabricator.kde.org/D20999

To: kossebau, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21001: Update *.qmltypes to current API of QML modules

[Aleix Pol Gonzalez]

apol added a comment.


  Looks like we were exporting the qmltypes for QtQuick Controls within the 
calendar file?
  
  LGTM overall, but an additional set of eyes would be useful.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21001

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[seb sasch]

sasch added a comment.


  What's blocking here to merge this in Master?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: sasch, adridg, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Aleix Pol Gonzalez]

apol added a comment.


  +1 looks good to me besides the nitpick.

INLINE COMMENTS

> kfilewidget.cpp:594
>  // the Filter label/edit
> -whatsThisText = i18n("This is the filter to apply to the file list. "
> - "File names that do not match the filter will not 
> be shown."
> - "You may select from one of the preset filters in 
> the "
> - "drop down menu, or you may enter a custom filter "
> - "directly into the text area."
> - "Wildcards such as * and ? are allowed.");
> -d->filterLabel = new QLabel(i18n("&Filter:"), this);
> -d->filterLabel->setWhatsThis(whatsThisText);
> +d->filterLabel = new QLabel;
>  d->filterWidget = new KFileFilterCombo(this);

Pass this as parent, I guess when it's added to the layouts somehow it will get 
reparented, but I'd say it's a good practice.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D20964

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20999: IconItem: remove remaining & unused smooth property bits

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c8fe7bc5ac73: IconItem: remove remaining & unused 
smooth property bits (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20999?vs=57484&id=57514

REVISION DETAIL
  https://phabricator.kde.org/D20999

AFFECTED FILES
  src/declarativeimports/core/iconitem.h

To: kossebau, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21000: PlatformComponentsPlugin: fix plugin iid to QQmlExtensionInterface

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7f4e171ef7ea: PlatformComponentsPlugin: fix plugin iid to 
QQmlExtensionInterface (authored by kossebau).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21000?vs=57485&id=57515

REVISION DETAIL
  https://phabricator.kde.org/D21000

AFFECTED FILES
  src/declarativeimports/platformcomponents/platformextensionplugin.cpp

To: kossebau, #plasma, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/95/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 23:53:04 +
 Build duration:
2 min 8 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/92/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 May 2019 23:53:04 +
 Build duration:
4 min 11 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/96/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 03 May 2019 23:55:16 +
 Build duration:
7 min 39 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/93/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 May 2019 23:57:17 +
 Build duration:
6 min 41 sec and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/85/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 03 May 2019 23:53:04 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 86 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/86/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 04 May 2019 00:07:29 +
 Build duration:
19 min and counting
   BUILD ARTIFACTS
  acc/KF5Plasma-5.58.0.xmlacc/KF5PlasmaQuick-5.58.0.xmllogs/KF5Plasma/5.58.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3628/13367)18%
(1821/9879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(311/2271)6%
(91/1473)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1417/3503)28%
(792/2827)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1184)0%
(0/1022)tests.dpi0%
   

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Nathaniel Graham]

ngraham updated this revision to Diff 57516.
ngraham marked an inline comment as done.
ngraham added a comment.


  Don't forget to set the parent

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20964?vs=57493&id=57516

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20964: [FileWidget] Replace "Filter:" with "File type:" when saving with a limited list of mimetypes

[Nathaniel Graham]

ngraham updated this revision to Diff 57517.
ngraham added a comment.


  Fix typo in comment

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20964?vs=57516&id=57517

BRANCH
  file-type-when-saving-and-mimetype-is-defined (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20964

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: ngraham, #vdg, elvisangelaccio, GB_2
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21007: Review kate config pages to improve maintenance friendliness

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  - Use new signal/slot style by new added helper functions
  - Unified comments, added some new, removed some obsolete

TEST PLAN
  I hope nothing got damaged

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21007

AFFECTED FILES
  src/dialogs/kateconfigpage.cpp
  src/dialogs/kateconfigpage.h
  src/dialogs/katedialogs.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D21007: Review kate config pages to improve maintenance friendliness

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I guess this is more easy on the eyes.
  
  Alternatively, one could consider making observeCanges a free function, but 
please commit for now.

INLINE COMMENTS

> katedialogs.cpp:156
> +// NOTE Should we have more use of such info stuff, consider to make it part
> +// of KateConfigPage and add a sililar function like observeChanges(..)
>  void KateIndentConfigTab::showWhatsThis(const QString &text)

Typo: sililar

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D21007

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D21007: Review kate config pages to improve maintenance friendliness

[loh tar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2af8bdae9ae2: Review kate config pages to improve 
maintenance friendliness (authored by loh.tar).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21007?vs=57518&id=57522#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21007?vs=57518&id=57522

REVISION DETAIL
  https://phabricator.kde.org/D21007

AFFECTED FILES
  src/dialogs/kateconfigpage.cpp
  src/dialogs/kateconfigpage.h
  src/dialogs/katedialogs.cpp

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars