D21486: Don't fetch device statistics upon construction

[Jan Grulich]

jgrulich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21486

To: apol, #plasma, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 106 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/106/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 30 May 2019 00:46:34 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13384)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 113 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/113/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 30 May 2019 00:46:34 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3633/13384)18%
(1823/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/116/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Thu, 30 May 2019 00:46:34 +
 Build duration:
4 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21378: Make Breeze Light/Dark use more system colors

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:fb8f02de76d5: Make Breeze Light/Dark use more system 
colors (authored by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21378?vs=58575=58880

REVISION DETAIL
  https://phabricator.kde.org/D21378

AFFECTED FILES
  src/desktoptheme/breeze-dark/colors
  src/desktoptheme/breeze-light/colors

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21486: Don't fetch device statistics upon construction

[Aleix Pol Gonzalez]

apol edited the summary of this revision.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D21486

To: apol, #plasma, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

[Nathaniel Graham]

ngraham added a task: T10958: Faster Startup.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21486: Don't fetch device statistics upon construction

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Herald added 1 blocking reviewer(s): jgrulich.
apol requested review of this revision.

REVISION SUMMARY
  To get proper data we'll have to change the refresh rate, so just wait until
  it's done and we'll get all the data.

TEST PLAN
  tests pass, the plasmoid still shows the statistics when asked to.

REPOSITORY
  R282 NetworkManagerQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21486

AFFECTED FILES
  src/devicestatistics.cpp

To: apol, #plasma, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a comment.


  In D21315#471780 , @ngraham wrote:
  
  > We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches 
like this, sometimes it's worth waiting for the next release to give it a month 
of testing rather than rushing it in close to the deadline. I say let's wait 
until after tagging to land it, or else if you get a thumbs-up review from 
anyone else before June 1st then we can get it in for 5.59. Does that sound 
sane and sensible?
  
  
  Good suggestion, I keep forgetting about the monthly release and the 
opportunity of beginning to get things merged.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21425: [UDev Backend] Filter for ID_MEDIA_PLAYER already when querying

[Stefan Brüns]

bruns added a comment.


  In D21425#470819 , @broulik wrote:
  
  > However in `queryDeviceInterface` we actually check for it being `"1"`
  
  
  and also here in `UDevManager::Private::checkOfInterest`.
  
  It is somewhat unfortunate we have the checks in 3 places now.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21425

To: broulik, #frameworks, davidedmundson, bruns
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Nathaniel Graham]

ngraham added a comment.


  We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches 
like this, sometimes it's worth waiting for the next release to give it a month 
of testing rather than rushing it in close to the deadline. I say let's wait 
until after tagging to land it, or else if you get a thumbs-up review from 
anyone else before June 1st then we can get it in for 5.59. Does that sound 
sane and sensible?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> meven wrote in kdiroperator.cpp:2691
> Perhaps we could use a more sensible default value for ColumnView.
> 
> What would you say about 32px ?

That sounds like a good default size.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Delay running UnindexedFileIndexer and IndexCleaner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes perfect sense to me.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson, ngraham
Cc: ngraham, poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, 
michaelh, astippich, spoorun, bruns, abrahams

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven updated this revision to Diff 58854.
meven added a comment.


  Rebasing

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21459?vs=58816=58854

BRANCH
  new-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 65 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/65/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 29 May 2019 14:59:48 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest

D21440: Delay running UnindexedFileIndexer and IndexCleaner

[Kai Uwe Broulik]

broulik added a task: T10958: Faster Startup.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21440: Delay running UnindexedFileIndexer and IndexCleaner

[Kai Uwe Broulik]

broulik updated this revision to Diff 58853.
broulik retitled this revision from "Start baloo_file later" to "Delay running 
UnindexedFileIndexer and IndexCleaner".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Delay indexer

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21440?vs=58754=58853

REVISION DETAIL
  https://phabricator.kde.org/D21440

AFFECTED FILES
  src/file/mainhub.cpp

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20833: Simpler check for flatpak

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:458e4770d43f: Simpler check for flatpak (authored by 
apol).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20833?vs=58848=58851

REVISION DETAIL
  https://phabricator.kde.org/D20833

AFFECTED FILES
  src/knotificationmanager.cpp

To: apol, #frameworks, broulik
Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

[Kai Uwe Broulik]

broulik added a comment.


  I would assume so. In the graph, which is a VM, ksplashqml is signalled to 
quit 2 seconds into the startup at which point plasmashell is pretty much done. 
So if we delay it by 5 seconds or so that could already be plenty I think. I'll 
give it a go next week.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21440: Start baloo_file later

[Stefan Brüns]

bruns added a comment.


  I think everything below 10 seconds would be completely fine, is that 
sufficient to let the remaining ones start?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/35/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 29 May 2019 14:45:27 +
 Build duration:
2 min 59 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D21440: Start baloo_file later

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Look into delaying the `UnindexedFileIndexer` and `IndexCleaner`. Can I just 
use `QTimer` or do you want something more sophisticated?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D20833: Simpler check for flatpak

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20833

To: apol, #frameworks, broulik
Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

[Stefan Brüns]

bruns added a comment.


  I would very much prefer only delaying the UnindexedFileIndexer and the 
IndexCleaner. These two are stopgap measures.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21379: [UDev Backend] Narrow device queried for

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:079b2bc91cb2: [UDev Backend] Narrow device queried for 
(authored by broulik).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21379?vs=58839=58850

REVISION DETAIL
  https://phabricator.kde.org/D21379

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20833: Simpler check for flatpak

[Aleix Pol Gonzalez]

apol updated this revision to Diff 58848.
apol added a comment.


  A more compact approach

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20833?vs=57023=58848

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20833

AFFECTED FILES
  src/knotificationmanager.cpp

To: apol, #frameworks
Cc: jgrulich, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in udevqtclient.cpp:223
> This is just copied from the other code. I can fixup all of them separately 
> later if you want.

Yes, thats completely fine for me - I was just looking through the code and 
picking up everything that should be fixed.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/112/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 29 May 2019 14:24:42 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3631/13384)18%
(1822/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(679/1578)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
 

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 105 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/105/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 29 May 2019 14:24:42 +
 Build duration:
8 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.59.0.xmlacc/KF5PlasmaQuick-5.59.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.59.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3641/13385)18%
(1826/9887)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1119)29%
(315/1090)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)14%
(314/2281)6%
(92/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1419/3511)28%
(793/2831)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(689/1579)29%
(304/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(578/2014)18%
(317/1727)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
   

D21483: Don't modify a temporary object

[Aleix Pol Gonzalez]

apol updated this revision to Diff 58845.
apol added a comment.


  arcanist decided to also push a bunch of unrelated stuff :(

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21483?vs=58844=58845

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21483

AFFECTED FILES
  src/plasma/private/storagethread.cpp

To: apol, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 115 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/115/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Wed, 29 May 2019 14:24:41 +
 Build duration:
3 min 3 sec and counting
   JUnit Tests
  Name: projectroot Failed: 6 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.dialognativetestFailed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_fallbackpackagetestFailed: projectroot.autotests.plasma_iconitemtestFailed: projectroot.autotests.plasma_packagestructuretestFailed: projectroot.autotests.plasma_storagetest

D21483: Don't modify a temporary object

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Instead copy the object, operate it and update it into the object.

TEST PLAN
  just used plasma shell and ran the tests. I'm not sure who uses this.
  Issue found with clazy.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21483

AFFECTED FILES
  src/plasma/CMakeLists.txt
  src/plasma/corona.cpp
  src/plasma/private/applet_p.cpp
  src/plasma/private/storagethread.cpp
  src/scriptengines/qml/plasmoid/containmentinterface.cpp

To: apol, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21481: Don't notify about changing to the same state it was at

[Aleix Pol Gonzalez]

apol added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21481

To: apol, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21481: Don't notify about changing to the same state it was at

[Aleix Pol Gonzalez]

apol created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  The object tracker was telling me it's notifying the same value it
  already got, and reading the code it seems to be already notifying when it
  actually changes.

TEST PLAN
  tests pass, plasma runs fine.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21481

AFFECTED FILES
  src/plasma/private/containment_p.cpp

To: apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21480: Pass fully-qualified arguments and return values to moc

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise it thinks it's different types.

TEST PLAN
  tests pass, plasmashell works

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21480

AFFECTED FILES
  src/plasma/datacontainer.h
  src/plasma/dataengine.h
  src/plasma/service.h

To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> kdiroperator.cpp:2691
> +// Simple view decoration left, aka compact view
> +return {QStringLiteral("listViewIconSize"), 0};
> +}

Perhaps we could use a more sensible default value for ColumnView.

What would you say about 32px ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow device queried for

[Kai Uwe Broulik]

broulik updated this revision to Diff 58839.
broulik retitled this revision from "[UDev Backend] Narrow subsystems queried 
for cameras" to "[UDev Backend] Narrow device queried for".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Merge D21425  into this

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21379?vs=58706=58839

REVISION DETAIL
  https://phabricator.kde.org/D21379

AFFECTED FILES
  src/solid/devices/backends/shared/udevqtclient.cpp
  src/solid/devices/backends/shared/udevqtclient.h
  src/solid/devices/backends/udev/udevmanager.cpp

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21440: Start baloo_file later

[Kai Uwe Broulik]

broulik added a comment.


  So, I can haz shipit?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21440: Start baloo_file later

[Igor Poboiko]

poboiko added a comment.


  In D21440#471144 , @broulik wrote:
  
  > The idle tracking is only in the extractor process, not in baloo_file 
itself. On startup it runs the `UnindexedFileIndexer` and iterates all the 
folders looking for files to re-index, consuming a considerable amount of CPU 
time, spending most of its time doing regexp matching, mime type determination, 
and date time processing. Only after that it may run the extractor process when 
there's new files to be indexed.
  >  So I think starting `baloo_file` later is safe since it checks all the 
files anyway? Otherwise/additionally, we should look into making the 
`UnindexedFileIndexer` start delayed.
  
  
  I think it should be pretty safe to start `baloo_file` later. 
  The very reason to add `UnindexedFileIndexer` was to make sure we index those 
files which were changed/added when Baloo wasn't running (as well as 
`IndexCleaner` to take care of files which were removed).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21440

To: broulik, bruns, #baloo, davidedmundson
Cc: poboiko, kde-frameworks-devel, gennad, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> bruns wrote in udevqtclient.cpp:223
> Nitpick - the existing code uses `toLatin1()`, and for the ASCII subset it 
> doesn't matter, but I am quite sure properties and values are UTF8 in general.
> 
> I have no strong proof, but the udev changelog has:
> 
> > udev 069
> >  
> >  A bunch of mostly trivial bugfixes. From now on no node name or
> >  symlink name can contain any character than plain whitelisted ascii
> >  characters or validated **utf8** byte-streams. This is needed for the
> >  /dev/disk/by-label/* links, because we import untrusted data and
> >  export it to the filesystem.

This is just copied from the other code. I can fixup all of them separately 
later if you want.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven added a comment.


  I have made a small code change.
  
  Should I wait for some more review before landing this ?

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

[Méven Car]

meven updated this revision to Diff 58832.
meven marked an inline comment as done.
meven added a comment.


  Avoid using Toggle in view activation callback names

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21315?vs=58776=58832

BRANCH
  arcpatch-D21315

REVISION DETAIL
  https://phabricator.kde.org/D21315

AFFECTED FILES
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kdiroperatoriconview_p.h
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham, #vdg
Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> udevqtclient.cpp:223
> +for (const QString  : subsystems) {
> +udev_enumerate_add_match_subsystem(en, 
> subsystem.toLatin1().constData());
> +}

Nitpick - the existing code uses `toLatin1()`, and for the ASCII subset it 
doesn't matter, but I am quite sure properties and values are UTF8 in general.

I have no strong proof, but the udev changelog has:

> udev 069
>  
>  A bunch of mostly trivial bugfixes. From now on no node name or
>  symlink name can contain any character than plain whitelisted ascii
>  characters or validated **utf8** byte-streams. This is needed for the
>  /dev/disk/by-label/* links, because we import untrusted data and
>  export it to the filesystem.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Stefan Brüns]

bruns added a comment.


  In D21379#471513 , @broulik wrote:
  
  > So, you want me to change that `1` to `QVariant()` then?
  
  
  I think that is completely sufficient, yes.
  
  In all the other places, the `!QVariant::toString().isEmpty()` and 
`QVariant::toInt() == 1` should be replaced by just `QVariant::isValid()`

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21379: [UDev Backend] Narrow subsystems queried for cameras

[Kai Uwe Broulik]

broulik added a comment.


  So, you want me to change that `1` to `QVariant()` then?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21379

To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven added a comment.


  In D21459#471238 , @ngraham wrote:
  
  > Nice! What do you think about moving the `if (configGroup && itemView) {` 
into the new function and calling it something more conditional, like 
`writeIconZoomSettingsIfNeeded`? Also it seems like there could be some code 
shared in a new function so that `KDirOperator::Private::iconSizeForViewType()` 
and `KDirOperator::Private::writeIconZoomSettings()` don't have to have so much 
duplicated code. They're both in the same scope so they have access to the same 
set of variables which should hopefully make it possible.
  
  
  I did your two nice suggestions. See `writeIconZoomSettingsIfNeeded` and 
`zoomSettingsForViewForView`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven updated this revision to Diff 58816.
meven added a comment.


  Add a zoomSettingsForViewForView to group viewKind to zoom setting name and 
default value

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21459?vs=58811=58816

BRANCH
  icon-save2

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21367: kioexec: change the scary debug messages for delayed deletion

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21367

To: Lekensteyn, elvisangelaccio, dfaure
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21459: Always save view settings when switching from one view mode to another

[Méven Car]

meven updated this revision to Diff 58811.
meven added a comment.


  Rename writeIconZoomSettings to writeIconZoomSettingsIfNeeded, some code 
improvements

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21459?vs=58780=58811

BRANCH
  icon-save2

REVISION DETAIL
  https://phabricator.kde.org/D21459

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns