D22733: Delete redundant and monochrome versions of applications-internet

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Ha! I was just about to start working on this myself. Obviously, I agree that 
this should be done. However, we should take note of all of the instances where 
`applications-internet` is currently used so that we can switch apps that 
intentionally use the monochrome version over to another icon like 
`internet-services` or `globe`.
  
  https://lxr.kde.org/search?_filestring=&_string=applications-internet
  In case the above link doesn't work for anyone, here's a list of all the 
references I found in the KDE repos that I've downloaded. It's not as complete 
as the info in the link above.
  F7093996: applications-internet_uses.txt 


REPOSITORY
  R266 Breeze Icons

BRANCH
  only-colorful-applications-intetnet-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22733

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Pino Toscano]

pino requested changes to this revision.
pino added a comment.
This revision now requires changes to proceed.


  other than building, please also check that it actually still works on Linux

INLINE COMMENTS

> kio_sftp.cpp:383
>  fileType = QT_STAT_MASK - 1;
> -#ifdef Q_OS_WIN
> -access = static_cast(perms::owner_all | perms::group_all | 
> perms::others_all);
> -#else
> -access = S_IRWXU | S_IRWXG | S_IRWXO;
> -#endif
> +access = QFileDevice::Permission::ReadOwner | 
> QFileDevice::Permission::WriteOwner | QFileDevice::Permission::ExeOwner
> +| QFileDevice::Permission::ReadGroup | 
> QFileDevice::Permission::WriteGroup | QFileDevice::Permission::ExeGroup

sounds like you need to use the *User enums, not the *Owner ones

> kio_sftp.cpp:1757
>  if (permissions != -1) {
> -#ifdef Q_OS_WIN
> -initialMode = permissions | 
> static_cast(perms::owner_write | perms::owner_read);
> -#else
> -initialMode = permissions | S_IWUSR | S_IRUSR;
> -#endif
> +initialMode = permissions | 
> QFileDevice::Permission::WriteOwner | QFileDevice::Permission::ReadOwner;
>  } else {

ditto

> kio_sftp.cpp:1964
>  if (permissions != -1)
> -#ifdef Q_OS_WIN
> -initialMode = permissions | static_cast(perms::owner_write);
> -#else
> -initialMode = permissions | S_IWUSR;
> -#endif
> +initialMode = permissions | QFileDevice::Permission::WriteOwner;
>  else

ditto

> kio_sftp.cpp:
>  fileType = QT_STAT_MASK - 1;
> -#ifdef Q_OS_WIN
> -access = static_cast(perms::owner_all | perms::group_all 
> | perms::others_all);
> -#else
> -access = S_IRWXU | S_IRWXG | S_IRWXO;
> -#endif
> +access = QFileDevice::Permission::ReadOwner | 
> QFileDevice::Permission::WriteOwner | QFileDevice::Permission::ExeOwner
> +| QFileDevice::Permission::ReadGroup | 
> QFileDevice::Permission::WriteGroup | QFileDevice::Permission::ExeGroup

ditto

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: pino, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, 
sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22723: Fix RunnerManager::queryFinished()

[Aleix Pol Gonzalez]

apol added a comment.


  In D22723#501690 , @fvogt wrote:
  
  > Looks like a hack still, with two Job objects for each job...
  >
  > What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by 
basically just adding a custom `done` signal and ignoring the entire 
"decorators which are actually wrappers" business?
  >
  > IMO this new `FindMatchesJobInternal` class makes it even less obvious 
what's actually going on.
  
  
  This is how ThreadWeaver and especially QObjectDecorator is meant to be used.
  I don't really know why you say it's confusing. The confusing part so far was 
that jobDone slot was never called.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 149 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/149/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 23:19:21 +
 Build duration:
11 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4590/13199)26%
(2505/9662)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(872/917)52%
(438/848)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(782/2302)27%
(396/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1499/3481)33%
(944/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(749/1574)37%
(386/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2025)19%
(324/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
 

D22733: Delete redundant and monochrome versions of applications-internet

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, ndavis.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  `applications-internet` is the only category icon that has monochrome 
versions at small
  sizes. In addition, there's a copy of it (same name and appearance) in 
preferences.
  
  This patch corrects those two issues by deleting the monochrome and redundant 
versions.

TEST PLAN
  Only the colorful version shows up in Cuttlefish: F7092986: Only colorful 
versions.png 
  
  With the patch to add icons to Discover's sidebar (D22716 
), all icons are now colorful:
  F7092985: All colorful in sidebar too.png 


REPOSITORY
  R266 Breeze Icons

BRANCH
  only-colorful-applications-intetnet-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22733

AFFECTED FILES
  icons-dark/apps/16/applications-internet.svg
  icons-dark/apps/22/applications-internet.svg
  icons-dark/preferences/32/applications-internet.svg
  icons/apps/16/applications-internet.svg
  icons/apps/22/applications-internet.svg
  icons/preferences/32/applications-internet.svg

To: ngraham, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 26 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/26/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 23:19:21 +
 Build duration:
8 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4584/13198)26%
(2504/9662)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)95%
(870/917)52%
(438/848)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(782/2302)27%
(396/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1499/3481)33%
(944/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(749/1574)37%
(386/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(584/2024)19%
(323/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 23:19:21 +
 Build duration:
3 min 14 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 11 test(s)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 148 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/148/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 22:57:34 +
 Build duration:
9 min 45 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4574/13194)26%
(2500/9658)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)94%
(856/912)51%
(432/844)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(782/2302)27%
(396/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1498/3481)33%
(942/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(750/1574)37%
(389/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2025)19%
(324/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/25/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 22:57:34 +
 Build duration:
6 min 47 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)35%
(44/124)35%
(44/124)35%
(4569/13193)26%
(2498/9658)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests92%
(11/12)92%
(11/12)94%
(855/912)51%
(431/844)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core44%
(7/16)44%
(7/16)34%
(782/2302)27%
(396/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)43%
(1498/3481)33%
(942/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)48%
(750/1574)37%
(389/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(584/2024)19%
(323/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/21/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 22:57:34 +
 Build duration:
5 min 2 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest

D22730: KZip::openArchive: Remove "bad" assert

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D22730

To: aacid, apol
Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22732: Install plasma theme into local XDG_DATA_DIR for icon test

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:08a6a4a7cd53: Install plasma theme into local 
XDG_DATA_DIR for icon test (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22732?vs=62513=62515

REVISION DETAIL
  https://phabricator.kde.org/D22732

AFFECTED FILES
  autotests/dialognativetest.cpp
  autotests/iconitemtest.cpp
  autotests/utils.h

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22732: Install plasma theme into local XDG_DATA_DIR for icon test

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22732

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22730: KZip::openArchive: Remove "bad" assert

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22730

To: aacid, apol
Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22732: Install plasma theme into local XDG_DATA_DIR for icon test

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Relevant code is moved from dialognativetest into a header for sharing

TEST PLAN
  Unit test

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22732

AFFECTED FILES
  autotests/dialognativetest.cpp
  autotests/iconitemtest.cpp
  autotests/utils.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

Re: Qt dependency policy

[Albert Astals Cid]

El diumenge, 21 de juliol de 2019, a les 12:55:21 CEST, David Faure va escriure:
> Taking into account the feedback from the SUSE packagers
> (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes 
> out is a problem since not everyone can upgrade to Qt 5.12 LTS right away)
> I have modified the policy to temporarily support 4 versions when the oldest 
> (and newest) are LTS.
> 
> https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

+1

Cheers,
  Albert

> 
> 

D22730: KZip::openArchive: Remove "bad" assert

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  There's nothing the caller of this function can do to control the assert
  condition, so asserting is "too rude", and on top of that there's
  a perfectly valid if below that already handles the condition properly

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22730

AFFECTED FILES
  src/kzip.cpp

To: aacid
Cc: apol, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22729: KZip::openArchive: Return false instead of asserting in broken files

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D22729

To: aacid, apol
Cc: kde-frameworks-devel, dfaure, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22729: KZip::openArchive: Return false instead of asserting in broken files

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22729

To: aacid, apol
Cc: kde-frameworks-devel, dfaure, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22729: KZip::openArchive: Return false instead of asserting in broken files

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  We can easily return false, so do that instead of asserting

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22729

AFFECTED FILES
  src/kzip.cpp

To: aacid
Cc: kde-frameworks-devel, dfaure, apol, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 added a comment.


  In D22727#501824 , @vonreth wrote:
  
  > Looks good.
  >  Why not the first time 
  
  
  I was afraid of reverts 

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Hannah von Reth]

vonreth accepted this revision.
vonreth added a reviewer: dfaure.
vonreth added a comment.
This revision is now accepted and ready to land.


  Looks good.
  Why not the first time 

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D11156: add autotest for zips within zips

[David Faure]

dfaure added a comment.
Herald added a subscriber: kde-frameworks-devel.


  @sandsmark can you add an expected list of files like other tests do?

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D11156

To: sandsmark, dfaure, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> klistopenfilestest.cpp:45
> +eventLoop.exec();
> +QVERIFY(processInfoList.empty() == false);
> +auto testProcessIterator = std::find_if(processInfoList.begin(), 
> processInfoList.end(), [](const KProcessList::KProcessInfo& info)

QVERIFY(!processInfoList.empty())

> klistopenfilestest.cpp:52
> +const auto& processInfo = *testProcessIterator;
> +QVERIFY(processInfo.isValid() == true);
> +QCOMPARE(processInfo.pid(), QCoreApplication::applicationPid());

The `== true` can be removed

(repeats)

> klistopenfiles.cpp:39
> +KProcessList::KProcessInfoList processInfoList;
> +for (const auto& pidStr : pidList) {
> +qint64 pid = pidStr.toLongLong();

qAsConst(pidList) to avoid a detach

> hallas wrote in klistopenfiles.cpp:49
> What should we do for Windows? Do we support any other platforms that doesn't 
> have lsof?

This reminds me of KCoreAddons' new KProcessInfo class, although that one 
doesn't actually do this.

I see that FreeBSD and OSX have lsof (and the man page doesn't say those 
options are missing there) so it should be fine, everywhere except Windows.

In general I don't really like starting executables like this, but indeed 
writing a clone of lsof sounds like much work.

> hallas wrote in klistopenfiles.h:40
> I am very much in doubt about what a nice interface for this should be? I was 
> thinking of an alternative approach where you would instantiate a class, 
> connect to a signal on the class and then invoke a method to start the 
> listing process, you would then receive the result on a slot instead. What do 
> you guys think?

Reading the unittest, I definitely agree that a signal would be better. Then 
you could use QSignalSpy::wait() without the need to use QEventLoop by hand :-)

This is really a job. I would inherit KJob for this, actually. It's the way we 
do such things everywhere else.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

[Piyush Aggarwal]

brute4s99 created this revision.
brute4s99 added a reviewer: vonreth.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
brute4s99 requested review of this revision.

TEST PLAN
  should build on windows with mingw as compiler
  
  should build on linux with gcc

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22727

AFFECTED FILES
  sftp/kio_sftp.cpp

To: brute4s99, vonreth
Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, 
fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, 
firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22701: [kfileutils] Add isExecutableFile from KRun

[David Faure]

dfaure added a comment.


  I started to write a KIO::OpenUrlJob, as a core-only version of KRun. I think 
this method actually belongs there, because it means "can be executed by KRun" 
(or soon OpenUrlJob).
  In isolation I don't think this method is useful. I looked at all users of 
this method on lxr.kde.org and they all check this in connection with KRun.
  With this in mind, is there still a good reason to move it to kfileutils?

INLINE COMMENTS

> kfileutils.h:48
> + * -# The mime type must inherit application/x-executable, 
> application/x-executable-script or application/x-sharedlib.
> + * To allow a script to run when the above rules are satisfied add the entry
> + * @code

Please remove the docu starting from this line to the end (i.e. 48-52), it 
describes KDE3 mimetype desktop files...

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D22701

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I can't remember what's the use case for building KIO with that flag

REPOSITORY
  R241 KIO

BRANCH
  missingcheck

REVISION DETAIL
  https://phabricator.kde.org/D22714

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Joining with `ResourceEvent` is a problem. At least make it not get joined if 
the date filter is not present.

INLINE COMMENTS

> QueryTest.h:53
>  void testFancySyntaxOrderingDefinition();
> +void tesDateSyntaxOrderingDefinition();
>  

tes -> test

> resultset.cpp:182
>  
> +QString dateClause(const QDate ) const {
> +return date.isNull() ? QStringLiteral("1") :

setDate above is by value, here it is const-ref. Check for the size of the type 
and decide on one of these.

> resultset.cpp:298
>  ON rl.targettedResource = ri.targettedResource
> +   LEFT JOIN
> +   ResourceEvent re

This is a potential efficiency problem - ResourceEvent is the quickest growing 
table. I don't like the idea for it to always be joined.

> resultset.cpp:416
>  ResourceScoreCache rsc
> +LEFT JOIN
> +   ResourceEvent re

Also, add an empty line above - I know I like empty lines too much, but ... :)

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22717

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 147 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/147/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 19:13:39 +
 Build duration:
9 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)33%
(40/123)33%
(40/123)29%
(3817/13170)22%
(2118/9660)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)60%
(546/907)38%
(320/846)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)18%
(412/2285)13%
(189/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)41%
(1442/3480)32%
(902/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)46%
(729/1573)35%
(366/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2025)19%
(324/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

D22698: Support passing target to ki18n_wrap_ui macro

[Daan De Meyer]

daandemeyer added a comment.


  I want to keep the changes in KDE Frameworks focused on what's necessary to 
clean up Kate's CMake scripts. I'll leave the general cleanup for another 
revision.

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/24/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 19:13:39 +
 Build duration:
4 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)33%
(40/123)33%
(40/123)29%
(3815/13169)22%
(2117/9660)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)60%
(548/907)38%
(320/846)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)18%
(412/2285)13%
(189/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)41%
(1442/3480)32%
(902/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)46%
(729/1573)35%
(366/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(584/2024)19%
(323/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 19:13:39 +
 Build duration:
2 min 19 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:31cd4f8d8ee8: Apply busy indicator duration change of 
D22646 to the QQC2 style (authored by jbbgameich).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22720?vs=62487=62497

REVISION DETAIL
  https://phabricator.kde.org/D22720

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml

To: jbbgameich, #vdg, #plasma:_mobile, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22698: Support passing target to ki18n_wrap_ui macro

[Alex Turbov]

turbov added inline comments.

INLINE COMMENTS

> KF5I18nMacros.cmake.in:76
> +  endif()
> endforeach (_current_FILE)
>  endmacro (KI18N_WRAP_UI)

Its _Modern CMake_ :) no need to use that crap anymore %)
(I'm talking about matched `end*()` things %)

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22698: Support passing target to ki18n_wrap_ui macro

[Alex Turbov]

turbov added a comment.


  @daandemeyer 
  Cool stuff! :))
  
  one more proposal is to turn it into a function to avoid pollution of the 
outer scope w/ inner used (**and still unset**) variables %)
  Using `set(${RESULT_VAR} "blah-blah" PARENT_SCOPE)` could help to do that %)

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: turbov, cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

[Fabian Vogt]

fvogt added a reviewer: davidedmundson.
fvogt added a comment.


  Looks like a hack still, with two Job objects for each job...
  
  What about just merging `QObjectDecorator` into `FindMatchesJobInternal` by 
basically just adding a custom `done` signal and ignoring the entire 
"decorators which are actually wrappers" business?
  
  IMO this new `FindMatchesJobInternal` class makes it even less obvious what's 
actually going on.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Daan De Meyer]

daandemeyer updated this revision to Diff 62496.
daandemeyer added a comment.


  Update CMake minimum required version to 3.1 (for `target_sources`).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22699?vs=62438=62496

REVISION DETAIL
  https://phabricator.kde.org/D22699

AFFECTED FILES
  CMakeLists.txt
  addons/CMakeLists.txt
  addons/backtracebrowser/CMakeLists.txt
  addons/backtracebrowser/autotests/CMakeLists.txt
  addons/close-except-like/CMakeLists.txt
  addons/close-except-like/close_except_plugin.cpp
  addons/close-except-like/config.h.in
  addons/filebrowser/CMakeLists.txt
  addons/filetree/CMakeLists.txt
  addons/filetree/autotests/CMakeLists.txt
  addons/gdbplugin/CMakeLists.txt
  addons/kate-ctags/CMakeLists.txt
  addons/katebuild-plugin/CMakeLists.txt
  addons/katesql/CMakeLists.txt
  addons/konsole/CMakeLists.txt
  addons/lspclient/CMakeLists.txt
  addons/lspclient/tests/CMakeLists.txt
  addons/lumen/CMakeLists.txt
  addons/openheader/CMakeLists.txt
  addons/preview/CMakeLists.txt
  addons/project/CMakeLists.txt
  addons/project/autotests/CMakeLists.txt
  addons/project/kateprojectplugin.cpp
  addons/replicode/CMakeLists.txt
  addons/rustcompletion/CMakeLists.txt
  addons/search/CMakeLists.txt
  addons/sessionapplet/CMakeLists.txt
  addons/sessionapplet/engine/CMakeLists.txt
  addons/snippets/CMakeLists.txt
  addons/symbolviewer/CMakeLists.txt
  addons/tabswitcher/CMakeLists.txt
  addons/tabswitcher/autotests/CMakeLists.txt
  addons/tabswitcher/tests/CMakeLists.txt
  addons/textfilter/CMakeLists.txt
  addons/xmlcheck/CMakeLists.txt
  addons/xmltools/CMakeLists.txt
  config.h.cmake

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  So many busy indicators!

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22720

To: jbbgameich, #vdg, #plasma:_mobile, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau added a dependency: D22724: [WIP] Add ECMAddQtDesignerPlugin.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D22725

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau added a dependent revision: D22725: [WIP] Add option to build Qt 
Designer plugin (BUILD_DESIGNERPLUGIN, default ON.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22725: [WIP] Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  createdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22725

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/designer/CMakeLists.txt
  src/designer/pics/kactionselector.png
  src/designer/pics/kcharselect.png
  src/designer/pics/kcolorbutton.png
  src/designer/pics/kcolorcombo.png
  src/designer/pics/kdatepicker.png
  src/designer/pics/keditlistwidget.png
  src/designer/pics/kfontrequester.png
  src/designer/pics/kgradientselector.png
  src/designer/pics/kled.png
  src/designer/pics/kpasswordlineedit.png
  src/designer/pics/kruler.png
  src/designer/pics/ksqueezedtextlabel.png
  src/designer/pics/kurllabel.png

To: kossebau
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22724

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22724: [WIP] Add ECMAddQtDesignerPlugin

[Friedrich W. H. Kossebau]

kossebau created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Goal is to replace KDesignerPlugin.
  So options & defaults are tried to be met.
  Only difference is the need to define the widgets in cmake code, using a
  util method, instead of external ".widgets" files.
  
  Porting of ".widgets" files basically means:
  copy content into cmake, transform ini code into arguments to util method.
  Key names need a bit of adaption, current names are open for dicussion.
  
  Porting example:
  
  [KActionSelector]
  IncludeFile=kactionselector.h
  ToolTip=A widget for selecting and arranging actions/objects
  Group=Views (KF5)
  
  gets
  
  ecm_qtdesignerplugin_widget(KActionSelector
  
INCLUDE_FILE kactionselector.h
TOOLTIP "A widget for selecting and arranging actions/objects"
GROUP "Views (KF5)"
  
  )

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  addqtdesignerplugin

REVISION DETAIL
  https://phabricator.kde.org/D22724

AFFECTED FILES
  modules/ECMAddQtDesignerPlugin.cmake

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22723: Fix RunnerManager::queryFinished()

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, fvogt.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  This actually looks like the port to the QObjectDecorator was done wrong. 
QObjectDecorator::done was never emitted because the decorator doesn't notify 
about changes in the decoratee (which is potentially something to improve in 
ThreadWeaver).
  This patch changes the internal FindMatchesJob to be a QObjectDecorator which 
will allow us to get notified when the jobs get done.
  
  Deprecates D21606  which forced emitting 
done from the thread.

TEST PLAN
  Tested with D22514 

REPOSITORY
  R308 KRunner

BRANCH
  arcpatch-D21606_1

REVISION DETAIL
  https://phabricator.kde.org/D22723

AFFECTED FILES
  src/runnerjobs.cpp
  src/runnerjobs_p.h
  src/runnermanager.cpp

To: apol, #frameworks, fvogt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

[Jonah Brüchert]

jbbgameich edited the summary of this revision.
jbbgameich added reviewers: VDG, Plasma: Mobile.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22720

To: jbbgameich, #vdg, #plasma:_mobile
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/23/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 16:11:16 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)33%
(40/123)33%
(40/123)29%
(3813/13169)22%
(2117/9660)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)60%
(546/907)38%
(320/846)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)18%
(412/2285)13%
(189/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)41%
(1442/3480)32%
(902/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)46%
(729/1573)35%
(366/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(584/2024)19%
(323/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 146 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/146/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 16:11:16 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report44%
(8/18)33%
(40/123)33%
(40/123)29%
(3819/13170)22%
(2118/9660)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)60%
(548/907)38%
(320/846)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)18%
(412/2285)13%
(189/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)41%
(1442/3480)32%
(902/2847)src.plasma.packagestructure43%
(3/7)43%
(3/7)36%
(49/137)42%
(5/12)src.plasma.private39%
(7/18)39%
(7/18)46%
(729/1573)35%
(366/1048)src.plasma.scripting33%
(1/3)33%
(1/3)12%
(20/171)6%
(7/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(588/2025)19%
(324/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  Match the duration (2 seconds) that was set in D22630 
.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22720

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/BusyIndicator.qml

To: jbbgameich
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 19 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/19/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 16:11:16 +
 Build duration:
4 min 54 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_iconitemtest

D22682: Compile package structure plugins into expected subdirectory

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:af2a7fbf69f1: Compile package structure plugins into 
expected subdirectory (authored by davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22682?vs=62390=62479

REVISION DETAIL
  https://phabricator.kde.org/D22682

AFFECTED FILES
  src/plasma/packagestructure/CMakeLists.txt

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22715: Save and load page margins

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2d02e5c684e3: Save and load page margins (authored by 
hoffmannrobert, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22715?vs=62475=62476

REVISION DETAIL
  https://phabricator.kde.org/D22715

AFFECTED FILES
  src/printing/kateprinter.cpp

To: hoffmannrobert, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D22715: Save and load page margins

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  save_and_load_page_margins

REVISION DETAIL
  https://phabricator.kde.org/D22715

To: hoffmannrobert, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D22715: Save and load page margins

[Robert Hoffmann]

hoffmannrobert updated this revision to Diff 62475.
hoffmannrobert added a comment.


  - Use KTextEditor::EditorPrivate::config()

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22715?vs=62470=62475

BRANCH
  save_and_load_page_margins

REVISION DETAIL
  https://phabricator.kde.org/D22715

AFFECTED FILES
  src/printing/kateprinter.cpp

To: hoffmannrobert, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D22653: Add view-barcode-qr icons

[Nathaniel Graham]

ngraham added a comment.


  In D22653#501534 , @ndavis wrote:
  
  > I think I do want the 32px version to not have the blue corners so that it 
is visually consistent with the smaller versions. Once that is done, I will 
accept this, as long as there aren't any issues with the colorscheme support.
  
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: ngraham, broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, bruns

D22653: Add view-barcode-qr icons

[Noah Davis]

ndavis added a comment.


  I think I do want the 32px version to not have the blue corners so that it is 
visually consistent with the smaller versions. Once that is done, I will accept 
this, as long as there aren't any issues with the colorscheme support.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22653: Add view-barcode-qr icons

[Mathis Brüchert]

mbruchert retitled this revision from "Add view-qrcode icons" to "Add 
view-barcode-qr icons".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22653

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

D22715: Save and load page margins

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I think this is a good idea.
  
  Instead of
  
  KSharedConfig::openConfig()
  
  one should use
  
  KTextEditor::EditorPrivate::config()
  
  otherwise this is fine for me.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D22715

To: hoffmannrobert, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven updated this revision to Diff 62473.
meven added a comment.


  Improve sql padding

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22717?vs=62472=62473

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22717

AFFECTED FILES
  autotests/QueryTest.cpp
  autotests/QueryTest.h
  src/query.cpp
  src/query.h
  src/resultset.cpp
  src/terms.cpp
  src/terms.h
  tests/model/window.cpp
  tests/model/window.ui

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

[Méven Car]

meven created this revision.
meven added reviewers: ivan, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Add a Term Date to Query to filter on ResourceEvent start column when 
querying for resources.
  Add two special cases : today and yesterday
  
  A followup feature would be to allow to filter on date ranges, to allow to 
filter something like :
  "Rescources accessed last week"
  
  The end goal is to add those filters to the recentlyused:/ ioslave introduced 
in D22144 

TEST PLAN
  Manual through the test app
  
  TODO
  autotests

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22717

AFFECTED FILES
  autotests/QueryTest.cpp
  autotests/QueryTest.h
  src/query.cpp
  src/query.h
  src/resultset.cpp
  src/terms.cpp
  src/terms.h
  tests/model/window.cpp
  tests/model/window.ui

To: meven, ivan, #frameworks
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22705: Deprecate KRun::runService

[David Faure]

dfaure added a comment.


  Wait I'm having second thoughts about that comment :-)
  
  Let's discuss this a bit later.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22715: Save and load page margins

[Robert Hoffmann]

hoffmannrobert created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
hoffmannrobert requested review of this revision.

REVISION SUMMARY
  Adapt and reapply former fix from
  
https://cgit.kde.org/kate.git/commit/?id=1aa12bace62fffbcad357623842a0fc01607b3c0
  which was removed when migrating to Qt5.

TEST PLAN
  Modify page margins in Printer Settings. Click OK and Print.
  Without the patch, the changes disappear, with the patch applied the changed
  margins are remembered in ~/.config/katerc and survive the restart of kate.

REPOSITORY
  R39 KTextEditor

BRANCH
  save_and_load_page_margins

REVISION DETAIL
  https://phabricator.kde.org/D22715

AFFECTED FILES
  src/printing/kateprinter.cpp

To: hoffmannrobert
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22708: [WIP] Add a kded module infra for fuse mount services

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 62469.
chinmoyr added a comment.


  Added KRun changes

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22708?vs=62453=62469

BRANCH
  monitorprotocol

REVISION DETAIL
  https://phabricator.kde.org/D22708

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kdiskfreespaceinfo.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/kcms/kio/CMakeLists.txt
  src/kcms/kio/fusemanager.cpp
  src/kcms/kio/fusemanager.desktop
  src/kcms/kio/fusemanager.h
  src/kcms/kio/fusemanager.ui
  src/kcms/kio/fuseserviceselector.ui
  src/kcms/kio/main.cpp
  src/mountserviced/CMakeLists.txt
  src/mountserviced/mountservicemanager.cpp
  src/mountserviced/mountservicemanager.desktop
  src/mountserviced/mountservicemanager.h
  src/mountserviced/org.kde.kio.MountServiceManager.xml
  src/widgets/CMakeLists.txt
  src/widgets/krun.cpp

To: chinmoyr
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Daan De Meyer]

daandemeyer added a comment.


  I

INLINE COMMENTS

> cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133
> If the change cannot be made compatible with the minimum ECM version, I 
> suggest waiting for KF6.

Personally, I don't see the harm in adding a completely backwards compatible 
optional feature that requires a higher CMake version (that's already 
considered very old) but of course it's up to you guys to make the call.

If it is not accepted, can I just leave the revision open until it can be 
merged for KF6?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> daandemeyer wrote in ECMQtDeclareLoggingCategory.cmake:133
> I found that the CMake script of extra-cmake-modules itself specifies 2.8.12 
> as the minimum so I'm assuming that's the minimum version for the modules as 
> well. The advantage of specifying cmake_minimum_required inline here is that 
> cmake-extra-modules will continue to work with versions of CMake older than 
> 3.1 and give a better error message when the new functionality is used with 
> an older CMake version. Of course, if its not a problem to update the minimum 
> required version to 3.1 that's the preferred solution compared to specifying 
> cmake_minimum_required inline.

If the change cannot be made compatible with the minimum ECM version, I suggest 
waiting for KF6.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22714: Add missing KIOWIDGETS_NO_DEPRECTAED check

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It is marked as deprecated but didn't have the #ifdef check

REPOSITORY
  R241 KIO

BRANCH
  missingcheck

REVISION DETAIL
  https://phabricator.kde.org/D22714

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: nicolasfella, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Daan De Meyer]

daandemeyer added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133
> must be compatible **with** the project..

What's the alternative for extra-cmake-modules? Can I just remove the 
cmake_minimum_required call or do I need to update the version elsewhere?

> cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133
> must be compatible **with** the project..

I found that the CMake script of extra-cmake-modules itself specifies 2.8.12 as 
the minimum so I'm assuming that's the minimum version for the modules as well. 
The advantage of specifying cmake_minimum_required inline here is that 
cmake-extra-modules will continue to work with versions of CMake older than 3.1 
and give a better error message when the new functionality is used with an 
older CMake version. Of course, if its not a problem to update the minimum 
required version to 3.1 that's the preferred solution compared to specifying 
cmake_minimum_required inline.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22705: Deprecate KRun::runService

[Nicolas Fella]

nicolasfella updated this revision to Diff 62465.
nicolasfella added a comment.


  - Add @deprecated since

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22705?vs=62446=62465

BRANCH
  depre2

REVISION DETAIL
  https://phabricator.kde.org/D22705

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/krun.h

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22705: Deprecate KRun::runService

[Nicolas Fella]

nicolasfella marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked 2 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> ivan wrote in recentlyused.cpp:140-144
> Could this just be replaced with `query = query | 
> Agent(agentValue.split(QLatin1Char(',')));`?
> 
> Obviously, the downside is always creating a list (usually with a single item 
> in it), the upside is that it does not need to traverse the string twice 
> (once to chech for commas, and the second time to split the string.
> 
> The trade-off depends on internals of Qt - if  you don't have the time to 
> benchmark what is faster, leave it as is.

I have used count() as it allows not to keep the list in memory if not needed.
Same was done for the type parameter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven updated this revision to Diff 62464.
meven added a comment.


  Use QStringLiteral only check for commas in string once to check for multiple 
values parameters, typo

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22144?vs=62417=62464

BRANCH
  arcpatch-D22144

REVISION DETAIL
  https://phabricator.kde.org/D22144

AFFECTED FILES
  CMakeLists.txt
  kio-extras.categories
  recentlyused/CMakeLists.txt
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h
  recentlyused/recentlyused.json

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Ivan Čukić]

ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> recentlyused.cpp:140-144
> +if (agentValue.contains(QLatin1Char(','))) {
> +query = query | Agent(agentValue.split(QLatin1Char(',')));
> +} else {
> +query = query | Agent(agentValue);
> +}

Could this just be replaced with `query = query | 
Agent(agentValue.split(QLatin1Char(',')));`?

Obviously, the downside is always creating a list (usually with a single item 
in it), the upside is that it does not need to traverse the string twice (once 
to chech for commas, and the second time to split the string.

The trade-off depends on internals of Qt - if  you don't have the time to 
benchmark what is faster, leave it as is.

> recentlyused.cpp:250
> +if (isRootUrl(url)) {
> +mimeType(QString::fromLatin1("inode/directory"));
> +finished();

`QStringLiteral`?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, 
LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D22653: Add view-qrcode icons

[Mathis Brüchert]

mbruchert updated this revision to Diff 62460.
mbruchert added a comment.


  rename to view-barcode-qr as suggeste

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22653?vs=62346=62460

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22653

AFFECTED FILES
  icons-dark/actions/16/view-barcode-qr.svg
  icons-dark/actions/22/view-barcode-qr.svg
  icons-dark/actions/32/view-barcode-qr.svg
  icons/actions/16/view-barcode-qr.svg
  icons/actions/22/view-barcode-qr.svg
  icons/actions/32/view-barcode-qr.svg

To: mbruchert, #breeze, ndavis
Cc: broulik, ndavis, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 WindowsMSVCQt5.11 - Build # 61 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20WindowsMSVCQt5.11/61/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 24 Jul 2019 08:11:08 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 9 test(s), Passed: 30 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kdatetimetestFailed: projectroot.autotests.kdebug_unittestFailed: projectroot.autotests.kdelibs4support_klocaletestFailed: projectroot.autotests.klibloadertestFailed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstestFailed: projectroot.autotests.ktimezonestestFailed: projectroot.autotests.kuniqueapptestFailed: projectroot.autotests.kurltest

KDE CI: Frameworks » knewstuff » kf5-qt5 WindowsMSVCQt5.11 - Build # 102 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20WindowsMSVCQt5.11/102/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 24 Jul 2019 08:19:49 +
 Build duration:
4 min 13 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: projectroot.autotests.kmoretoolstest

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 329 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/329/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Wed, 24 Jul 2019 08:11:12 +
 Build duration:
7 min 13 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 150 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/150/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 08:01:06 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33456/61053)39%
(17063/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9341/9791)48%
(4286/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8528/14438)51%
(4699/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4596/8216)42%
(1999/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/8/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 08:10:29 +
 Build duration:
7 min 40 sec and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.61.0.xmlacc/KF5KDELibs4Support-5.61.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/290)43%
(124/290)47%
(21579/45932)38%
(13019/34261)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11348/11739)50%
(7172/14369)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9479/17867)48%
(5539/11439)src.kdeui19%
(13/67)19%
(13/67)8%
(742/9693)6%
(307/5396)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1242)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/855)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/186)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1530)0%
(0/487)

D22365: KNotification macOS native support by NSNotificationCenter

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> Inoki wrote in notifybymacosnotificationcenter.mm:169
> KDE Connect does set icon by pixmap, any idea how should we treat these?

Check for `pixmap().isNull()` and use `iconName()` then

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb
Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22689: Replace QString::null with QString

[Albert Astals Cid]

aacid abandoned this revision.
aacid added a comment.


  Fixed it manually, marking it as abandoned since i can't close any other way.
  
  Sorry, should have tested this a bit more, yesterday it was late :/

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22689

To: aacid, apol, nicolasfella
Cc: ltoscano, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.12 - Build # 37 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.12/37/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 08:10:26 +
 Build duration:
5 min 11 sec and counting
   BUILD ARTIFACTS
  acc/KF5KDE4Support-5.61.0.xmlacc/KF5KDELibs4Support-5.61.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 39 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/290)43%
(124/290)47%
(21579/45932)38%
(13019/34261)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11348/11739)50%
(7172/14369)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9479/17867)48%
(5539/11439)src.kdeui19%
(13/67)19%
(13/67)8%
(742/9693)6%
(307/5396)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1242)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/855)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/186)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1530)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 7 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/7/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 08:10:22 +
 Build duration:
4 min 25 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: projectroot.autotests.kmimetypetestFailed: projectroot.autotests.kstandarddirstest

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/18/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 08:01:09 +
 Build duration:
7 min 10 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.61.0.xmllogs/KF5KIO/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(264/402)66%
(264/402)55%
(33456/61052)39%
(17056/43959)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9341/9791)48%
(4288/9007)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)59%
(8528/14438)51%
(4695/9207)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4596/8216)42%
(1999/4771)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)54%
(653/1204)39%
(372/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1343)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
  

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 12 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/12/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 08:01:03 +
 Build duration:
7 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22698: Support passing target to ki18n_wrap_ui macro

[Daan De Meyer]

daandemeyer marked an inline comment as done.
daandemeyer added a comment.


  Removed the cmake_minimum_required call

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22698: Support passing target to ki18n_wrap_ui macro

[Daan De Meyer]

daandemeyer updated this revision to Diff 62459.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22698?vs=62434=62459

REVISION DETAIL
  https://phabricator.kde.org/D22698

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: daandemeyer, ilic
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.13 - Build # 6 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.13/6/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 08:01:01 +
 Build duration:
4 min 18 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5NewStuff-5.61.0.xmlacc/KF5NewStuffCore-5.61.0.xmlacc/KF5NewStuffQuick-5.61.0.xmlcompat_reports/KF5NewStuff_compat_report.htmlcompat_reports/KF5NewStuffCore_compat_report.htmllogs/KF5NewStuff/5.61.0/log.txtlogs/KF5NewStuffCore/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/65)17%
(11/65)15%
(920/6199)12%
(403/3277)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(90/90)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)71%
(199/279)43%
(63/148)src22%
(2/9)22%
(2/9)2%
(22/964)0%
(0/342)src.attica0%
(0/2)0%
(0/2)0%
(0/307)0%
(0/187)src.core16%
(3/19)16%
(3/19)10%
(190/1874)11%
(147/1291)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/87)src.kmoretools60%
(3/5)60%
(3/5)47%
(419/894)33%
(155/470)src.qtquick0%
(0/5)0%
(0/5)0%
(0/303)0%
(0/100)src.staticxml0%
(0/1)0%
(0/1)0%
(0/168)0%
(0/140)src.ui0%
(0/8)0%
(0/8)0%
(0/748)0%
(0/307)src.upload0%
(0/1)0%
(0/1)0%
(0/124)0%
(0/50)tests0%
(0/4)0%
(0/4)0%
(0/134)0%
(0/59)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/129)0%
(0/24)

KDE CI: Frameworks » knewstuff » kf5-qt5 FreeBSDQt5.13 - Build # 5 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20FreeBSDQt5.13/5/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 08:00:56 +
 Build duration:
1 min 11 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.12 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.12/48/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 07:56:03 +
 Build duration:
3 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5NewStuff-5.61.0.xmlacc/KF5NewStuffCore-5.61.0.xmlacc/KF5NewStuffQuick-5.61.0.xmlcompat_reports/KF5NewStuff_compat_report.htmlcompat_reports/KF5NewStuffCore_compat_report.htmllogs/KF5NewStuff/5.61.0/log.txtlogs/KF5NewStuffCore/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/65)17%
(11/65)15%
(920/6199)12%
(403/3277)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(90/90)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)71%
(199/279)43%
(63/148)src22%
(2/9)22%
(2/9)2%
(22/964)0%
(0/342)src.attica0%
(0/2)0%
(0/2)0%
(0/307)0%
(0/187)src.core16%
(3/19)16%
(3/19)10%
(190/1874)11%
(147/1291)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/87)src.kmoretools60%
(3/5)60%
(3/5)47%
(419/894)33%
(155/470)src.qtquick0%
(0/5)0%
(0/5)0%
(0/303)0%
(0/100)src.staticxml0%
(0/1)0%
(0/1)0%
(0/168)0%
(0/140)src.ui0%
(0/8)0%
(0/8)0%
(0/748)0%
(0/307)src.upload0%
(0/1)0%
(0/1)0%
(0/124)0%
(0/50)tests0%
(0/4)0%
(0/4)0%
(0/134)0%
(0/59)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/129)0%
(0/24)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 145 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/145/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 24 Jul 2019 07:35:59 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)29%
(36/123)29%
(36/123)28%
(3700/13167)22%
(2077/9660)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)57%
(517/907)36%
(303/846)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)18%
(412/2285)13%
(189/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)41%
(1440/3480)32%
(901/2847)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private39%
(7/18)39%
(7/18)46%
(720/1573)34%
(361/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(580/2025)18%
(318/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
 

D22698: Support passing target to ki18n_wrap_ui macro

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> KF5I18nMacros.cmake.in:72
> +  if(TARGET ${_sources})
> + cmake_minimum_required(VERSION 3.1)
> + target_sources(${_sources} PRIVATE ${_header})

same thing as D22699 . A macro must not 
change the minimum required version. (ki18n already requires CMake 3.5 anyway)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22698

To: daandemeyer, ilic
Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133
> -1 for changing the minimum CMake version in a macro. The change must be 
> compatible the project requirement.

must be compatible **with** the project..

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

D22699: Support passing target to ecm_qt_declare_logging_category

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> ECMQtDeclareLoggingCategory.cmake:133
> +if(TARGET ${sources_var})
> +cmake_minimum_required(VERSION 3.1)
> +target_sources(${sources_var} PRIVATE ${cpp_filename})

-1 for changing the minimum CMake version in a macro. The change must be 
compatible the project requirement.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
sbergeron, bencreasy, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.13 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.13/22/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 24 Jul 2019 07:35:58 +
 Build duration:
6 min 39 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Plasma-5.61.0.xmlacc/KF5PlasmaQuick-5.61.0.xmlcompat_reports/KF5Plasma_compat_report.htmllogs/KF5Plasma/5.61.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)29%
(36/123)29%
(36/123)28%
(3698/13166)21%
(2076/9660)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests82%
(9/11)82%
(9/11)57%
(519/907)36%
(303/846)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/471)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)18%
(412/2285)13%
(189/1479)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma45%
(10/22)45%
(10/22)41%
(1440/3480)32%
(901/2847)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private39%
(7/18)39%
(7/18)46%
(720/1573)34%
(361/1048)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/171)0%
(0/113)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)28%
(576/2024)18%
(317/1729)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1183)0%
(0/1020)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/18/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 24 Jul 2019 07:35:59 +
 Build duration:
4 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_configmodeltestFailed: projectroot.autotests.plasma_iconitemtest

D22670: Change Highlight to ButtonFocus

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:b0541ffbff28: Change Highlight to ButtonFocus (authored 
by ndavis).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22670?vs=62427=62457

REVISION DETAIL
  https://phabricator.kde.org/D22670

AFFECTED FILES
  src/desktoptheme/breeze/icons/konv_message.svg
  src/desktoptheme/breeze/icons/network.svg
  src/desktoptheme/breeze/icons/osd.svg
  src/desktoptheme/breeze/icons/quassel.svg
  src/desktoptheme/breeze/icons/software.svg
  src/desktoptheme/breeze/icons/window.svg
  src/desktoptheme/breeze/widgets/action-overlays.svg
  src/desktoptheme/breeze/widgets/bar_meter_horizontal.svg
  src/desktoptheme/breeze/widgets/bar_meter_vertical.svg
  src/desktoptheme/breeze/widgets/busywidget.svg
  src/desktoptheme/breeze/widgets/calendar.svg
  src/desktoptheme/breeze/widgets/checkmarks.svg
  src/desktoptheme/breeze/widgets/glowbar.svg
  src/desktoptheme/breeze/widgets/pager.svg
  src/desktoptheme/breeze/widgets/viewitem.svg

To: ndavis, #vdg, #plasma, #breeze, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22709: Support passing target to ecm_add_app_icon.

[Daan De Meyer]

daandemeyer created this revision.
daandemeyer added reviewers: alexmerry, dschmidt.
daandemeyer added a project: Frameworks.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
Herald added a project: Build System.
daandemeyer requested review of this revision.

REVISION SUMMARY
  Same as https://phabricator.kde.org/D22698 for `ecm_add_app_icon`.

TEST PLAN
  I don't have KDE setup on Windows or access to a Mac and I think this code is 
only fully exercised on those system. I confirmed it doesn't break anything on 
Linux by running kate's CMake configuration but that's only half of the work 
since most of the macro isn't used on Linux. If anyone could verify this patch 
works on Windows or Mac it would be much appreciated.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22709

AFFECTED FILES
  modules/ECMAddAppIcon.cmake

To: daandemeyer, alexmerry, dschmidt
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, 
michaelh, ngraham, bruns

D22689: Replace QString::null with QString

[Luigi Toscano]

ltoscano added a comment.


  I can see that several frameworks can't build anymore on build.kde.org after 
the change.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22689

To: aacid, apol, nicolasfella
Cc: ltoscano, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, 
michaelh, ngraham, bruns

D22705: Deprecate KRun::runService

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> krun.h:238
>   * @since 5.6
>   */
> +#ifndef KIOWIDGETS_NO_DEPRECATED

Add `@deprecated since` and what should be used instead

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22705

To: nicolasfella, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns

D22708: [WIP] Add a kded module infra for fuse mount services

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  This module watches the install directories of kded modules and curates a 
list of modules having plugin Category=MountService.
  This list will be used by a kio kcm which will allow users to configure mount 
service for remote protocol.
  Once loaded this module can be used in KIOSlave::listDir to mount the url and 
in KRun::resolveUrls to convert the
  remote URL to local URL.

REPOSITORY
  R241 KIO

BRANCH
  monitorprotocol

REVISION DETAIL
  https://phabricator.kde.org/D22708

AFFECTED FILES
  src/CMakeLists.txt
  src/core/kdiskfreespaceinfo.cpp
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file_unix.cpp
  src/kcms/kio/CMakeLists.txt
  src/kcms/kio/fusemanager.cpp
  src/kcms/kio/fusemanager.desktop
  src/kcms/kio/fusemanager.h
  src/kcms/kio/fusemanager.ui
  src/kcms/kio/fuseserviceselector.ui
  src/kcms/kio/main.cpp
  src/mountserviced/CMakeLists.txt
  src/mountserviced/mountservicemanager.cpp
  src/mountserviced/mountservicemanager.desktop
  src/mountserviced/mountservicemanager.h
  src/mountserviced/org.kde.kio.MountServiceManager.xml

To: chinmoyr
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns