D23420: Use solid to check if a KFileItem is located on a network mount

[Méven Car]

meven updated this revision to Diff 64715.
meven added a comment.


  better check file path

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23420?vs=64645&id=64715

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kfileitem.cpp

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Méven Car]

meven marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Kai Uwe Broulik]

broulik added a comment.


  Now we still need the `linkDest` check :)

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kfileitem.cpp:764
> Get it as `const Solid::StorageAccess`, you can use `auto storageAccess = ...`

Let clarify what David mean

  for (const Solid::Device& device : devices) {
  auto storageAccess = device.as();

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Méven Car]

meven updated this revision to Diff 64716.
meven added a comment.


  Add a const& clean unused variable

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23420?vs=64715&id=64716

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/kfileitem.cpp

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Méven Car]

meven marked an inline comment as done.
meven added a comment.


  In D23420#519949 , @broulik wrote:
  
  > Now we still need the `linkDest` check :)
  
  
  isSlow() didn't check linkDest before.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23420: Use solid to check if a KFileItem is located on a network mount

[Kai Uwe Broulik]

broulik added a comment.


  > isSlow() didn't check linkDest before.
  
  Even more reason to do it properly now :P
  
  `KFileSystemType` uses `statfs`. I didn't find any documentation on whether 
it follows symlinks, but it is documented to return an `ELOOP` error code "Too 
many symbolic links were encountered in translating path.", so maybe it does so 
implicitly, which we lost now.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D23420

REVISION DETAIL
  https://phabricator.kde.org/D23420

To: meven, dfaure, #frameworks
Cc: broulik, anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23483: Fix section hierachy in distributing.md

[Antonio Rojas]

arojas created this revision.
arojas added reviewers: bruns, kossebau.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Fixes QCH build with doxygen 1.8.16, which seems to be more strict when 
parsing markdown

TEST PLAN
  Build with BUILD_QCH=ON and doxygen 1.8.16, build suceeds instead of throwing 
an error "Error in line 20: Opening and ending tag mismatch."

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23483

AFFECTED FILES
  docs/distributing.md

To: arojas, bruns, kossebau
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23484: gcc naming conflict

[Mickael Bosch]

mickaelbo created this revision.
mickaelbo added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mickaelbo requested review of this revision.

REVISION SUMMARY
  With  gcc 7.4.0 (and maybe some other versions), "major" and "minor" are set 
as macro and expand to "gnu_dev_major" and "gnu_dev_minor".  
  See: https://bugzilla.redhat.com/show_bug.cgi?id=130601 

  
  These strings are used in the affected file for variable naming.
  The attached patch undef the gcc renaming.
  
  A syntax-highlighting user, Jonathan, reported the issue, provided the patch 
and tested it  after trying to compile the project when the last commit was 
authored by me. Thank you Jonathan.

TEST PLAN
  The compilation shall not fail with gcc 7.4.0.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23484

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: mickaelbo, #framework_syntax_highlighting
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23484: gcc naming conflict

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  I would prefer that we just rename the vars.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23484

To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: cullmann, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, sars, dhaumann

D23484: gcc naming conflict

[Mickael Bosch]

mickaelbo updated this revision to Diff 64727.
mickaelbo added a comment.


  It makes sense.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23484?vs=64719&id=64727

REVISION DETAIL
  https://phabricator.kde.org/D23484

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23484: gcc naming conflict

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  ok, thanks

REVISION DETAIL
  https://phabricator.kde.org/D23484

To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir retitled this revision from "[WIP] Bring KNewStuffQuick to feature 
parity with KNewStuff(Widgets)" to "Bring KNewStuffQuick to feature parity with 
KNewStuff(Widgets)".
leinir edited the summary of this revision.
leinir edited the test plan for this revision.
leinir added reviewers: KNewStuff, VDG, Frameworks.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven updated this revision to Diff 64736.
meven added a comment.


  Inherit from SlaveBase instead of ForwardingSlaveBase, rename url parameter 
to path parameter

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22144?vs=64504&id=64736

BRANCH
  arcpatch-D22144_1

REVISION DETAIL
  https://phabricator.kde.org/D22144

AFFECTED FILES
  CMakeLists.txt
  kio-extras.categories
  recentlyused/CMakeLists.txt
  recentlyused/recentlyused.cpp
  recentlyused/recentlyused.h
  recentlyused/recentlyused.json

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven edited the test plan for this revision.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga created this revision.
nhiga added a reviewer: kde-frameworks-devel.
nhiga added a project: Frameworks.
nhiga requested review of this revision.

REVISION SUMMARY
  With D23476 , this patch should let users 
who have Krusader installed to view files inside a 7z or RAR archive in KDE 
applications (such as Gwenview) without decompressing the whole archive to 
another location. They will also be able to navigate the archive using Dolphin.

TEST PLAN
  1. Apply D23476  (and add 
`application/vnd.rar` to `archiveMimetype` in `krArc/krarc.protocol` if it does 
not work) to Krusader.
  2. Apply this patch to KIO.
  3. Enable "Open archives as folder" in Dolphin, then open a 7z/RAR file. It 
should be using the `krarc` protocol.
  4. Browse (Navigate) and look around the archive. Click on the breadcrumb in 
the location area for a parent folder which is outside the archive to make sure 
Bug 386448 does not occur.
  5. Open Gwenview and view a 7z/RAR archive with photos. Browse and view an 
image inside the archive.
  6. To be safe, uninstall Krusader and see if there is any bug if `krarc` is 
unavailable.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: nhiga, kde-frameworks-devel
Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[N. Higa]

nhiga added a comment.


  This patch may be related to Bug 411330 
.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, kde-frameworks-devel
Cc: LeGast00n, GB_2, michaelh, ngraham, bruns

D23493: [server] Cache current mode

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  Instead of looping over all modes for retrieving current mode data copy it
  to a separate variable.

TEST PLAN
  KWin auto tests pass and KScreen in Wayland nested session shows correct
  information.

REPOSITORY
  R127 KWayland

BRANCH
  cacheMode

REVISION DETAIL
  https://phabricator.kde.org/D23493

AFFECTED FILES
  src/server/outputdevice_interface.cpp

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23493: [server] Cache current mode

[Roman Gilg]

romangg added a task: T11459: AbstractWaylandOutput and output device 
consolidation.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23493

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23103: Add decibel power units (dBW and multiples)

[Ismael Asensio]

iasensio added a comment.


  Friendly ping

REPOSITORY
  R292 KUnitConversion

BRANCH
  log_power_units

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R292 KUnitConversion

BRANCH
  log_power_units

REVISION DETAIL
  https://phabricator.kde.org/D23103

To: iasensio, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23103: Add decibel power units (dBW and multiples)

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R292:edca5ae10796: Add decibel power units (dBW and multiples) 
(authored by iasensio, committed by ngraham).

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23103?vs=63588&id=64741

REVISION DETAIL
  https://phabricator.kde.org/D23103

AFFECTED FILES
  src/power.cpp
  src/unit.h

To: iasensio, broulik, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23493: [server] Cache current mode

[Roman Gilg]

romangg added a dependent revision: D23495: Get output pixel size from output 
device.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23493

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23344: assert slave command finality

[Harald Sitter]

sitter updated this revision to Diff 64744.
sitter added a comment.


  - wrap in custom assert defines that either assert or qwarn based on a cmake 
option
  - new cmake option KIO_ASSERT_SLAVE_STATES enables the asserts. the option is 
only on by default when run on jenkins
  - fix a bunch of typos
  
  the long term plan here is still to always enable the assertions (conditional 
on build type anyway), to not break everyones systems the cmake option allows a 
few brave souls to opt into assertion. also by running jenkins slaves with 
assertions we'll have additional chances of finding bugs there

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23344?vs=64294&id=64744

BRANCH
  assert

REVISION DETAIL
  https://phabricator.kde.org/D23344

AFFECTED FILES
  CMakeLists.txt
  src/core/config-kiocore.h.cmake
  src/core/slavebase.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

[Dan Leinir Turthra Jensen]

leinir edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D21721

To: leinir, #knewstuff, #vdg, #frameworks
Cc: anthonyfieroni, pino, ngraham, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/38/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 27 Aug 2019 14:55:04 +
 Build duration:
8 min 22 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Harald Sitter]

sitter added a comment.


  Not knowing the background here at a glance I would argue that SlaveBase in 
KIO should be getting state verification on all of this,.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23497: Keep 'lib' as default libdir on Arch Linux based systems

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: apol.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Port of upstream commit 
https://gitlab.kitware.com/cmake/cmake/commit/18365587c86396f988e256b5acf4d2312f3be2bb

TEST PLAN
  Compile a project that uses LIBDIR under Arch without setting 
CMAKE_INSTALL_LIBDIR, libs are installed under lib/

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23497

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: arojas, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Alexander Saoutkin]

feverfew added a comment.


  In D23207#520233 , @sitter wrote:
  
  > Not knowing the background here at a glance I would argue that SlaveBase in 
KIO should be getting state verification on all of this,.
  
  
  Sorry, I'm not sure what you mean by "state verification" in this case and 
how it relates to SlaveBase.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23490: [KUrlNavigator] Add MIME types supported by krarc to isCompressedPath

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited reviewers, added: Frameworks, cfeck, pino, dfaure; removed: 
kde-frameworks-devel.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23490

To: nhiga, #frameworks, cfeck, pino, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

[Benjamin Buch]

bbuch created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
bbuch requested review of this revision.

REVISION SUMMARY
  Currently, Matlab source files display keywords, variables, and operators as
  normal text. So they don't get any special highlighting and their presentation
  can't be varied by themes. Especially for keywords this is very annoying.
  
  The patch assigns them to the appropriate theme category to fix this.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  highlight-matlab-keyword-variable-operator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23498

AFFECTED FILES
  data/syntax/matlab.xml

To: bbuch
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

[Harald Sitter]

sitter added a comment.


  SlaveBase (which the slaves derive from) runs a command loop, out of this 
command loop come the actual calls to the API functions. So, in said command 
loop we can verify which state the slave is in before and more importantly 
after any API call. Specifically about the defects you are repairing here I'd 
guess that none of the commands running on an open connection must result in 
the finished state. We already do this for (some) of the other commands.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D23207

To: feverfew, chinmoyr, fvogt, sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

[Benjamin Buch]

bbuch added a reviewer: cullmann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23498

To: bbuch, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23483: Fix section hierachy in distributing.md

[Friedrich W. H. Kossebau]

kossebau accepted this revision.
kossebau added a comment.
This revision is now accepted and ready to land.


  Seems to me more a bug of doxygen. Is it not allowed to put level-3 titles 
below level-1 titles? At least as long as one does not do numbering, there 
should not be a problem,  in   with HTML seems also fine.
  
  But well, in this case this change should not be that important, so let's 
make things digestible for that doxygen version. Perhaps still worth to file a 
bug with them, left for discoverer ;)
  
  And actually the current title size also looks strange on 
https://api.kde.org/frameworks/baloo/html/index.html (which uses some older 
doxygen).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D23483

To: arojas, bruns, kossebau
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23500: Support for native Matlab strings

[Benjamin Buch]

bbuch created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
bbuch requested review of this revision.

REVISION SUMMARY
  As of Matlab 2016b, a separate string data type and literal was introduced
  in Matlab.
  
  https://de.mathworks.com/help/matlab/matlab_prog/create-string-arrays.html
  
  The new literals are syntactically equivalent to the old character verctors
  except that they are delimited by double quote. The term 'character vector'
  is now consistently used for the old single quote literales.
  
  The patch renames single quote literals to CharVector and adds double
  quote literals as String.
  
  CharVector's are associated with the theme category dsSpecialString.
  String's are associated with the theme category dsString. Incomplete
  CharVector's and String's are consequently associated with the theme
  category dsError.
  
  The examples at the end of the file were extended by the new literals.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  matlab-2016b-strings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23500

AFFECTED FILES
  data/syntax/matlab.xml

To: bbuch
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23500: Support for native Matlab strings

[Benjamin Buch]

bbuch added a reviewer: cullmann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23500

To: bbuch, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23483: Fix section hierachy in distributing.md

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:33e042970075: Fix section hierachy in distributing.md 
(authored by arojas).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23483?vs=64721&id=64754

REVISION DETAIL
  https://phabricator.kde.org/D23483

AFFECTED FILES
  docs/distributing.md

To: arojas, bruns, kossebau
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, GB_2, domson, 
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D23500: Support for native Matlab strings

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Hi, I think it is very nice that you pickup the matlab file!
  
  Three things I would like to have changed:
  
  1. please move the example from the comment in the XML to 
autotests/input/test.m, then we can have reference results for this and see 
changes
  2. version of the file must be increased, otherwise the updating mechanism is 
tricked
  3. I would prefer not to have hardcoded colors if possible
  
  Thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23500

To: bbuch, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Actually, I can take care of the changes after applying this, is already a 
good start, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  ahmad/soft-hyphen (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23472

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0bf552243404: Mimic QInputControl::isAcceptableInput() 
when filtering typed characters (authored by ahmadsamir, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23472?vs=64709&id=64756

REVISION DETAIL
  https://phabricator.kde.org/D23472

AFFECTED FILES
  src/document/katedocument.cpp
  src/document/katedocument.h
  src/view/kateviewinternal.cpp
  src/view/kateviewinternal.h

To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23484: gcc naming conflict

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:3ff7f78ebcb7: gcc naming conflict (authored by mickaelbo, 
committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23484?vs=64727&id=64757

REVISION DETAIL
  https://phabricator.kde.org/D23484

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: jriddell, cullmann, kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D23498: Highlighting of keywords, variables and operators as such for Matlab source files

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Change looks ok modulo missing version update, for more input please take a 
look at the reply in D23500  Support for 
native Matlab strings

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23498

To: bbuch, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven added a comment.


  @kossebau what about my last changes ?
  
  @ivan I feel this is ok to have 
`${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp` in the test 
CMakeLists.txt file with the documentation associated with 
ECMQtDeclareLoggingCategory and my comment, no-one can miss where this file is 
coming from.

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Ivan Čukić]

ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.


  Change everything to plural.
  
  I agree with @kossebau, though I don't think it will lead to problems in 
future, so I could say it is bearable dirtyness.

INLINE COMMENTS

> CMakeLists.txt:22
> +   # Generated by macro ecm_qt_declare_logging_category in src/CMakeLists.txt
> +   ${CMAKE_BINARY_DIR}/src/kactivities-stat-logsettings.cpp
> +

plural `stats`

> kactivities-stats.categories:1
> +org.kde.kactivities.stats KActivities Stats DEFAULT_SEVERITY [WARNING] 
> IDENTIFIER [KACTIVITY_STAT_LOG]

You mixed singulars and plurals - go for plurals everywhere:

`s/KACTIVITY_STAT_LOG/KACTIVITIES_STATS_LOG/g`

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23512: Avoid overloading KCModule::changed

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KCModule contains a signal and a protected slot with the same name.
  With the new connect syntax this becomes messy, especially as
  this method is called from KCMs a lot.
  
  This patch introduces a new name for the slot, with the
  intention of dropping the old one in KF6

REPOSITORY
  R265 KConfigWidgets

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23512

AFFECTED FILES
  src/kcmodule.cpp
  src/kcmodule.h

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REVISION SUMMARY
  New style ("Translated String") for a string associated with msgstr and 
msgstr_plural. Normal String and some other styles are now spellChecking=false.
  
  BUG: 392612

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  po_spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23513

AFFECTED FILES
  autotests/html/highlight.po.html
  autotests/reference/highlight.po.ref
  data/syntax/gettext.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[jonathan poelen]

jpoelen edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23513

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[jonathan poelen]

jpoelen edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23513

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Nice! Please inc version and push.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  po_spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23513

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

[Kai Uwe Broulik]

broulik updated this revision to Diff 64777.
broulik added a comment.


  - Minimize unrelated changes...

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23145?vs=63697&id=64777

REVISION DETAIL
  https://phabricator.kde.org/D23145

AFFECTED FILES
  thumbnail/icoutils_wrestool.cpp

To: broulik, vonreth, pali, antlarr, bruns
Cc: apol, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, 
LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23515: Format class: add functions to know if XML files set style attributes

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann, 
vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  The functions isBold(), isItalic(), etc. return the resulting format between 
the combination of the Theme and the XML highlighting file. This one works very 
well. The problem is that if the Theme is empty, it isn't possible to correctly 
apply these attributes, especially the turn off of these.
  
  These new functions let you know if the attributes bold, italic, underline, 
strikeout, color, backgroundColor, selColor & selBackgroundColor are 
specifically set in the XML files.
  
  For example, if `Format::definitionHasBold()` is **true**, the 
`Format::isBold(...)` function returns the value of the `bold` attribute set in 
the XML file. If `Format::definitionHasBold()` is **false**, the `bold` 
attribute isn't in the XML file and `Format::isBold(...)` returns the value 
defined by the Theme.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  format-new-functions

REVISION DETAIL
  https://phabricator.kde.org/D23515

AFFECTED FILES
  src/lib/format.cpp
  src/lib/format.h

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23515: Format class: add functions to know if XML files set style attributes

[Nibaldo González]

nibags added a dependent revision: D23516: Fix for all themes: allow turn off 
attributes in XML highlighting files.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Depends on D23515 
  
  Use the new functions of KSyntaxHighlighting to verify if the bold, italic, 
underline & strikeout attributes are set in the XML files, so as to allow them 
to be turned off correctly in the themes that don't exist in 
KSyntaxHighlighting and that are applied by KTextEditor.

REPOSITORY
  R39 KTextEditor

BRANCH
  turnoff-attr

REVISION DETAIL
  https://phabricator.kde.org/D23516

AFFECTED FILES
  src/syntax/katehighlight.cpp

To: nibags, #ktexteditor, cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[jonathan poelen]

jpoelen updated this revision to Diff 64782.
jpoelen added a comment.


  - increase version

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23513?vs=64775&id=64782

BRANCH
  po_spellcheck (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23513

AFFECTED FILES
  autotests/html/highlight.po.html
  autotests/reference/highlight.po.ref
  data/syntax/gettext.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23497: Keep 'lib' as default libdir on Arch Linux based systems

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D23497

To: arojas, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[jonathan poelen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0f150cafac4b: Gettext: Add "Translated String" 
style and spellChecking attribute (authored by jpoelen).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23513?vs=64782&id=64783#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23513?vs=64782&id=64783

REVISION DETAIL
  https://phabricator.kde.org/D23513

AFFECTED FILES
  autotests/html/highlight.po.html
  autotests/reference/highlight.po.ref
  data/syntax/gettext.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23512: Avoid overloading KCModule::changed

[Aleix Pol Gonzalez]

apol added a comment.


  +1

INLINE COMMENTS

> kcmodule.h:382
>   */
>  void changed();
>  

Use KCONFIGWIDGETS_DEPRECATED?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D23512

To: davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 104 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/104/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 28 Aug 2019 03:11:39 +
 Build duration:
8 min 57 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.62.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltestFailed: projectroot.autotests.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report21%
(5/24)26%
(14/54)26%
(14/54)20%
(445/2244)17%
(166/999)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)89%
(139/156)49%
(49/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/80)0%
(0/22)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.save

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 28 Aug 2019 03:10:54 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven updated this revision to Diff 64784.
meven added a comment.


  kactivities-stat-logsettings.h -> kactivities-stats-logsettings.h, 
KACTIVITY_STAT_LOG -> KACTIVITIE_STATS_LOG

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22143?vs=62695&id=64784

BRANCH
  arcpatch-D22143

REVISION DETAIL
  https://phabricator.kde.org/D22143

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked 7 inline comments as done.
meven added inline comments.

INLINE COMMENTS

> dfaure wrote in recentlyused.cpp:91
> I'm confused. Which code from ForwardingSlaveBase is this class benefiting 
> from?
> With internalRewriteUrl returning false all SlaveBase reimplementations in 
> that class do nothing,
> 
> If you decide not to support listing/stat'ing subdirs then indeed you don't 
> need ForwardingSlaveBase as base class.

After more testing, inheriting from ForwardSlaveBase was not needed.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven marked 2 inline comments as done.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

[Méven Car]

meven added a comment.


  @dfaure A missing piece for this kio slave is to be able to filter to the 
current app, meaning the app using the slave.
  I am not sure there is a way to achieve this yet, please correct me if I am 
wrong, I've looked around but I could have missed something.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

D23497: Keep 'lib' as default libdir on Arch Linux based systems

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c806bd48a29f: Keep 'lib' as default LIBDIR on 
Arch Linux based systems (authored by arojas).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23497?vs=64746&id=64786

REVISION DETAIL
  https://phabricator.kde.org/D23497

AFFECTED FILES
  kde-modules/KDEInstallDirs.cmake

To: arojas, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 28 Aug 2019 05:49:19 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D23500: Support for native Matlab strings

[Dominik Haumann]

dhaumann added a comment.


  If you use kateversion="5.0" then you can use the new text styles we 
introduced with KDE 5: 
  
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  
  This allows to remove many of the hardcoded colors so that the highlighting 
works with all color themes.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23500

To: bbuch, cullmann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven updated this revision to Diff 64787.
meven added a comment.


  Rebase on master

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22143?vs=64784&id=64787

BRANCH
  arcpatch-D22143

REVISION DETAIL
  https://phabricator.kde.org/D22143

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 22 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/22/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 28 Aug 2019 05:49:19 +
 Build duration:
9 min 15 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.62.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 26 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(76/89)85%
(76/89)76%
(6786/8972)43%
(10658/24587)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(29/31)94%
(29/31)97%
(2822/2912)48%
(6094/12571)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(53/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(13/13)100%
(13/13)81%
(944/1163)50%
(983/1957)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 69 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/69/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 28 Aug 2019 05:49:19 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.62.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 26 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(76/89)85%
(76/89)76%
(6786/8973)43%
(10658/24587)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(29/31)94%
(29/31)97%
(2822/2912)48%
(6094/12571)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(53/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(13/13)100%
(13/13)81%
(944/1163)50%
(983/1957)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D23515: Format class: add functions to know if XML files set style attributes

[Dominik Haumann]

dhaumann added a comment.


  I am thinking about whether ` overwritesBold()` , ... is better than 
`definitionHasBold()`. Because the `Format` matches an `itemData` in xml. Or 
even `boldHardcoded()`.
  
  Any thoughts?
  
  PS: Another solution is to port all xml files to not use hard coded colors. 
That's a lot of work, though.

INLINE COMMENTS

> format.h:149
> +/** Returns @c true if the syntax definition file specifies a value for 
> the
> + *  italic text attribute. If the return is @c true, this value is
> + *  obtained by isItalic().

Better: If @p true is returned, ...

> format.h:155
> +bool definitionHasItalic() const;
> +/** Returns @c true if the syntax definition file specifies a value for 
> the
> + *  underlined text attribute. If the return is @c true, this value is

Could you add an empty line after a function such that the next doxygen block 
starts after the newline?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23515

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

[Dominik Haumann]

dhaumann added a comment.


  I like it, although this all will not be needed anymore oncee KTextEditor is 
fully ported to KSyntaxHighlighting::Theme. Still a long way to go.
  
  +1

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23516

To: nibags, #ktexteditor, cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[Dominik Haumann]

dhaumann reopened this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Lgtm.
  
  There are many dsStrings now, which could be distinguished by the default 
styles for strings in a later patch (dsVerbatim, ...):
  
https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23513

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23513: Gettext: Add "Translated String" style and spellChecking attribute

[Dominik Haumann]

dhaumann closed this revision.
dhaumann added a comment.


  Sorry accidentally reopened.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23513

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> kactivities-stats.categories:1
> +org.kde.kactivities.stats KActivities Stats DEFAULT_SEVERITY [WARNING] 
> IDENTIFIER [KACTIVITY_STAT_LOG]

Missed one here

> CMakeLists.txt:21
> +HEADER kactivities-stats-logsettings.h
> +IDENTIFIER KACTIVITIE_STATS_LOG
> +CATEGORY_NAME kf5.kactivity.stat)

KACTIVITIE -> KACTIVITIE**S **

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D22143

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/22/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 28 Aug 2019 06:26:20 +
 Build duration:
1 min 31 sec and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/40/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 28 Aug 2019 06:49:04 +
 Build duration:
8 min 23 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D22143: Add proper logging using ECMQtDeclareLoggingCategory

[Méven Car]

meven updated this revision to Diff 64789.
meven added a comment.


  Fix plural

REPOSITORY
  R159 KActivities Statistics

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22143?vs=64787&id=64789

BRANCH
  arcpatch-D22143

REVISION DETAIL
  https://phabricator.kde.org/D22143

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  kactivities-stats.categories
  src/CMakeLists.txt
  src/common/database/Database.cpp
  src/resultmodel.cpp
  src/resultset.cpp
  src/resultwatcher.cpp

To: meven, ivan, #frameworks, kossebau
Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns