D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fstabhandling.cpp:236
> +auto device = it.key();
> +QString deviceName = device;
> +if (deviceName.endsWith(QLatin1Char('/'))) {

You should check for `devices.contains(deviceName)` here and `continue`, avoids 
detaching deviceName when not necessary.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  Everything looks good and the new test passes for me.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23919: Make KSslError hold a QSslError internally

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23919

To: vkrause, dfaure, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 80 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/80/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 22:15:17 +
 Build duration:
17 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.62.0.xmllogs/KF5KIO/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33694/61201)39%
(17277/44136)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9375/9825)47%
(4351/9242)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8638/14459)51%
(4776/9299)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4646/8276)42%
(2050/4831)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(676/1209)40%
(382/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1788/4290)36%
(1316/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1331)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/18/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 22:15:15 +
 Build duration:
8 min 56 sec and counting
   BUILD ARTIFACTS
  acc/KF5Parts-5.62.0.xmllogs/KF5Parts/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)37%
(19/52)37%
(19/52)22%
(621/2807)13%
(179/1361)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)95%
(183/192)49%
(65/132)src40%
(17/42)40%
(17/42)19%
(438/2283)10%
(114/1147)tests0%
(0/8)0%
(0/8)0%
(0/332)0%
(0/82)

D23919: Make KSslError hold a QSslError internally

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23919

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23919: Make KSslError hold a QSslError internally

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This implies a bit back and forth conversion for now, but it enables
  migrating the code using KSslError to use QSslError instead, without
  breaking API compatibility. Using QSslError gives us a greater level
  of detail for the error messages, and enables deprecating KSslError.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23919

AFFECTED FILES
  src/core/ktcpsocket.cpp

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.13 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.13/17/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 22:15:15 +
 Build duration:
5 min 11 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Runner-5.62.0.xmlcompat_reports/KF5Runner_compat_report.htmllogs/KF5Runner/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(2/4)65%
(11/17)65%
(11/17)47%
(722/1537)32%
(256/796)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests67%
(2/3)67%
(2/3)76%
(111/147)51%
(46/90)src90%
(9/10)90%
(9/10)50%
(611/1213)35%
(210/606)src.declarative0%
(0/2)0%
(0/2)0%
(0/133)0%
(0/96)tests0%
(0/2)0%
(0/2)0%
(0/44)0%
(0/4)

D23904: Add QIcon setters for the password dialogs

[Volker Krause]

vkrause updated this revision to Diff 65948.
vkrause added a comment.


  Add icon() getter, deprecated pixmap methods, remove on demand pixmap label 
creation as we set an icon unconditionally.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23904?vs=65918&id=65948

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23904

AFFECTED FILES
  src/knewpassworddialog.cpp
  src/knewpassworddialog.h
  src/kpassworddialog.cpp
  src/kpassworddialog.h
  src/kpassworddialog.ui

To: vkrause, dfaure
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Let's get this in soon. We have plenty of time before Frameworks 5.63.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R245 Solid

BRANCH
  arcpatch-D21204

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks, ngraham
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag added a comment.


  In D23917#530297 , @broulik wrote:
  
  > If the container is `const` already there's no real reason to explicitly 
use `constBegin` which is effectively the same
  
  
  Yes, however it's still a good idea to be explicit about it.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: broulik, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23917: Use const_iterator

[Kai Uwe Broulik]

broulik added a comment.


  If the container is `const` already there's no real reason to explicitly use 
`constBegin` which is effectively the same

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: broulik, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Sep 2019 20:06:22 +
 Build duration:
7 min 38 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 15 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> registry.cpp:879
>  });
>  if (it == m_interfaces.end()) {
>  qCDebug(KWAYLAND_CLIENT) << "Don't have interface " << 
> int(interface) << "with name " << name << "and minimum version" << version;

constEnd

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> output_interface.cpp:119
> +auto rit = std::find_if(resources.constBegin(), 
> resources.constEnd(), [native] (const ResourceData &data) { return 
> data.resource == native; });
>  if (rit != resources.end()) {
>  return (*it);

constEnd

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

[Frederik Gladhorn]

gladhorn updated this revision to Diff 65946.
gladhorn added a comment.


  fixup

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23917?vs=65945&id=65946

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23917: Use const_iterator

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  When trivial, replace iterators with the const versrion.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

[Frederik Gladhorn]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:858d9255f722: Remove capture of this in lambda (authored 
by gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23916?vs=65943&id=65944

REVISION DETAIL
  https://phabricator.kde.org/D23916

AFFECTED FILES
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp

To: gladhorn, #kwin, zzag, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

[Frederik Gladhorn]

gladhorn updated this revision to Diff 65943.
gladhorn added a comment.


  Remove more lambda this captures

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23916?vs=65942&id=65943

BRANCH
  arcpatch-D23916

REVISION DETAIL
  https://phabricator.kde.org/D23916

AFFECTED FILES
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp

To: gladhorn, #kwin, zzag, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

[Kai Uwe Broulik]

broulik accepted this revision.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23916

To: gladhorn, #kwin, zzag, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

[Vlad Zahorodnii]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23916

To: gladhorn, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23916: Remove capture of this in lambda

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  When this is not used, there is no point in capturing it.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23916

AFFECTED FILES
  src/server/seat_interface.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23915: Add some docstrings

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  When first reading the KWayland code, some explanations
  help getting around.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/dpms_interface.h

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kossebau wrote in kkeysequencewidget.cpp:127
> Still unsure what you mean with the constness, as the QHash `shortcuts` has 
> been const all the time, and thus the access methods and its returned 
> references.  If you meant the initially proposed `const QKeySequence &seq = 
> it.key();` that was just an alias reference to something const ref before 
> (`it.key()`), whose idea was to not touch the other existing code as well as 
> make it more obvious to the code reader what `it.key()` is. It did not change 
> any constness.
> 
> Back to your original comment:
> So here my 2 penny collected over decades: avoid that. One change/aspect at a 
> time. No additional clean-up., as basic as it is (even no whitespace changes, 
>  unless line touched anyway).
> 
> - The commit message might miss to mention that change, or make it more 
> complicated to read because it lists all the while-at-it changes.
> - There are no obvious changes, unless documented. What is clear to the 
> commit creator, might be unclear to the commit reader, as they have another 
> context
> - Line-wise commit annotation mark-up will be set for lines which are changed 
> while not relevant for the actual main change (which only would be mentioned 
> in the commit message first line/title)
> - One is concentrated on the main change, and might miss important details 
> relevant to that other change, and introduce regressions.
> 
> You may discard these 2 penny of mine, but let's talk again in some years ;) 
> Better though ask the search engine for what other people recommend as best 
> commit practice & compare. Still you are free to collect your own experience: 
> if young people only did what old people tell them, new discoveries would 
> never be made ;) But most of the times...

I do try to keep commits atomic, and detail my changes in the commit message. 
(And no, I won't discard your 2 pennies, I am too poor, experience-wise, to 
afford that). What I should have done was read the code starting at the top, 
where shortcuts is declared const. Anyway thanks for explaining things, that's 
always appreciated. :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

[David Hallas]

hallas marked 2 inline comments as done.
hallas added inline comments.

INLINE COMMENTS

> dfaure wrote in klistopenfilesjobtest_unix.cpp:67
> Please use QSKIP instead, otherwise the test output looks like the test 
> passed, rather than was skipped.

Good point, I didn't know that :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23884

To: hallas, dfaure
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

[David Hallas]

hallas updated this revision to Diff 65937.
hallas added a comment.


  Use QSKIP to skip tests

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23884?vs=65870&id=65937

BRANCH
  fix_unittest_if_lsof_is_not_installed

REVISION DETAIL
  https://phabricator.kde.org/D23884

AFFECTED FILES
  autotests/klistopenfilesjobtest_unix.cpp

To: hallas, dfaure
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kkeysequencewidget.cpp:127
> I admit "making them const as needed" is badly phrased; I meant whether the 
> container iterated-over is const to begin with, or can be made const in the 
> range-for to avoid a detach/deep-copy ... etc, depending on the code and what 
> it does. The same for the first argument of the range-for loop.
> 
> The "addition"/change I was mainly talking about is the micro-optimization of 
> not calling toString() twice; I think such basic coding practice changes are 
> OK in this context.

Still unsure what you mean with the constness, as the QHash `shortcuts` has 
been const all the time, and thus the access methods and its returned 
references.  If you meant the initially proposed `const QKeySequence &seq = 
it.key();` that was just an alias reference to something const ref before 
(`it.key()`), whose idea was to not touch the other existing code as well as 
make it more obvious to the code reader what `it.key()` is. It did not change 
any constness.

Back to your original comment:
So here my 2 penny collected over decades: avoid that. One change/aspect at a 
time. No additional clean-up., as basic as it is (even no whitespace changes,  
unless line touched anyway).

- The commit message might miss to mention that change, or make it more 
complicated to read because it lists all the while-at-it changes.
- There are no obvious changes, unless documented. What is clear to the commit 
creator, might be unclear to the commit reader, as they have another context
- Line-wise commit annotation mark-up will be set for lines which are changed 
while not relevant for the actual main change (which only would be mentioned in 
the commit message first line/title)
- One is concentrated on the main change, and might miss important details 
relevant to that other change, and introduce regressions.

You may discard these 2 penny of mine, but let's talk again in some years ;) 
Better though ask the search engine for what other people recommend as best 
commit practice & compare. Still you are free to collect your own experience: 
if young people only did what old people tell them, new discoveries would never 
be made ;) But most of the times...

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kossebau wrote in kkeysequencewidget.cpp:127
> Is it?
> This patch as is now has 3 changes:
> 
> - change a foreach loop over extracted key list of a QHash to then also 
> access values (2 discouraged things) to iterator-based for loop over the QHash
> - change a foreach loop over a QList to a range-based for loop over the QList
> - cache the result of toString() outside of the inner loop
> 
> Each of those is an independent change. The first two both fall into the 
> domain of "port away from foreach". The last one, as could be also seen in 
> the first version of this patch, has nothing to do with them, `seq` was a 
> const reference before and has been after (well, then represented/replaced 
> by`it.key()`).
> 
> Where would you see that "making them const as needed" that you based your 
> reply on? :)

I admit "making them const as needed" is badly phrased; I meant whether the 
container iterated-over is const to begin with, or can be made const in the 
range-for to avoid a detach/deep-copy ... etc, depending on the code and what 
it does. The same for the first argument of the range-for loop.

The "addition"/change I was mainly talking about is the micro-optimization of 
not calling toString() twice; I think such basic coding practice changes are OK 
in this context.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[Méven Car]

meven updated this revision to Diff 65931.
meven marked 2 inline comments as done.
meven added a comment.


  Clean up and update @since

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23523?vs=65374&id=65931

BRANCH
  arcpatch-D23523

REVISION DETAIL
  https://phabricator.kde.org/D23523

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/81/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Sep 2019 14:24:55 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.completion_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D23904: Add QIcon setters for the password dialogs

[Christoph Feck]

cfeck added a comment.


  A getter would be nice. I am also fine with deprecating the pixmap calls. You 
can create an icon from a pixmap using QIcon.
  
  (Why is there no setIcon() in QLabel?)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23904

To: vkrause, dfaure
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23903: Remove dead icon loading code

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:6e5a8901cb03: Remove dead icon loading code (authored by 
vkrause).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23903?vs=65911&id=65921

REVISION DETAIL
  https://phabricator.kde.org/D23903

AFFECTED FILES
  src/ui/itemsviewbasedelegate.cpp
  src/ui/itemsviewbasedelegate_p.h

To: vkrause, dfaure, davidedmundson, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kkeysequencewidget.cpp:127
> I understand. but I was talking about this case specifically, it's about 
> foreach two arguments, and making them const as needed, so that seqAsString 
> change is in inline with replacing foreach with range-for.

Is it?
This patch as is now has 3 changes:

- change a foreach loop over extracted key list of a QHash to then also access 
values (2 discouraged things) to iterator-based for loop over the QHash
- change a foreach loop over a QList to a range-based for loop over the QList
- cache the result of toString() outside of the inner loop

Each of those is an independent change. The first two both fall into the domain 
of "port away from foreach". The last one, as could be also seen in the first 
version of this patch, has nothing to do with them, `seq` was a const reference 
before and has been after (well, then represented/replaced by`it.key()`).

Where would you see that "making them const as needed" that you based your 
reply on? :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[Volker Krause]

vkrause updated this revision to Diff 65920.
vkrause added a comment.


  Make use of D23904 .

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23899?vs=65906&id=65920

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23899

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/kbetterthankdialog.cpp
  src/runtime/kwalletd/kwalletd.cpp
  src/runtime/kwalletd/kwalletwizard.cpp
  tests/kwalletd/CMakeLists.txt

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23904: Add QIcon setters for the password dialogs

[Volker Krause]

vkrause added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23904

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23903: Remove dead icon loading code

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  The code is referred to in src/ui/itemsviewdelegate.cpp:322 in a 
commented-out section, which will likely want to be reimplemented in some other 
way. However, the code is entirely unused, and i'm fine with this disappearing, 
that was more a comment for context :)

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23903

To: vkrause, dfaure, davidedmundson, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23904: Add QIcon setters for the password dialogs

[Volker Krause]

vkrause added a comment.


  Should we deprecate the pixmap methods in favor of the icon ones? Do we need 
an QIcon getter too?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D23904

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23904: Add QIcon setters for the password dialogs

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  This avoids having to pass in QPixmaps with a fixed size.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23904

AFFECTED FILES
  src/knewpassworddialog.cpp
  src/knewpassworddialog.h
  src/kpassworddialog.cpp
  src/kpassworddialog.h

To: vkrause, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23903: Remove dead icon loading code

[Volker Krause]

vkrause added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D23903

To: vkrause, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[Volker Krause]

vkrause added a comment.


  Yep, makes sense.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D23899

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kossebau wrote in kkeysequencewidget.cpp:127
> As someone who looked at a lot of commit history, my recommendation is: don't 
> do in the same commit. Make it a separate commit with a dedicated commit 
> message.
> While-at-it changes are annoying for future code history readers, which 
> includes one older-self. So not only for that reason be friendly to them :)

I understand. but I was talking about this case specifically, it's about 
foreach two arguments, and making them const as needed, so that seqAsString 
change is in inline with replacing foreach with range-for.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23903: Remove dead icon loading code

[Volker Krause]

vkrause created this revision.
vkrause added reviewers: dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23903

AFFECTED FILES
  src/ui/itemsviewbasedelegate.cpp
  src/ui/itemsviewbasedelegate_p.h

To: vkrause, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23902: [KCoreDirLister] replace foreach with range-for

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: kde-frameworks-devel, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Also change directoriesForCanonicalPath() to return const

TEST PLAN
  The code compiles and all tests pass (except kacltest, but that's
  probably something on my machine)

REPOSITORY
  R241 KIO

BRANCH
  ahmad/foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23902

AFFECTED FILES
  src/core/kcoredirlister.cpp
  src/core/kcoredirlister_p.h

To: ahmadsamir, kde-frameworks-devel, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kwalletd.cpp:636
>  kpd->setWindowTitle(i18n("KDE Wallet Service"));
> -kpd->setPixmap(
> -
> KIconLoader::global()->loadIcon(QStringLiteral("kwalletmanager"),
> -KIconLoader::Desktop, KIconLoader::SizeHuge));
> +
> kpd->setPixmap(QIcon::fromTheme(QStringLiteral("kwalletmanager")).pixmap(64));
>  if (w != KWindowSystem::activeWindow() && w != 0L) {

The 64 seems a bit too hardcoded, and KPasswordDialog internally defaults to 
`q->style()->pixelMetric(QStyle::PM_MessageBoxIconSize, &option, q)` (when 
setPixmap isn't called).

I think the first step is to add a setIcon to KPasswordDialog.

> kwalletwizard.cpp:52
>  ui.ktitlewidget->setText("" + i18n("KWallet") + "");
> -
> -int iconSize = 3 * fontMetrics().height();
> -// round to multiple of 16
> -iconSize = (iconSize + 8) & ~15;
> -QPixmap pix = 
> KIconLoader::global()->loadIcon(QStringLiteral("kwalletmanager"), 
> KIconLoader::Dialog, iconSize);
> -ui.ktitlewidget->setPixmap(pix);
> +
> ui.ktitlewidget->setPixmap(QIcon::fromTheme(QStringLiteral("kwalletmanager")));
>  

(we should add a setIcon overload to KTitleWidget, this setPixmap method is 
misnamed).

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D23899

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[Volker Krause]

vkrause added a task: T11637: Investigate if KIconThemes is needed as a 
framework.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D23899

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23899: Port from KIconLoader to QIcon::fromTheme

[Volker Krause]

vkrause created this revision.
vkrause added reviewers: davidedmundson, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23899

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/kbetterthankdialog.cpp
  src/runtime/kwalletd/kwalletd.cpp
  src/runtime/kwalletd/kwalletwizard.cpp
  tests/kwalletd/CMakeLists.txt

To: vkrause, davidedmundson, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> slavebase.cpp:38
>  
> +#include 
>  #include 

what is this used for?

> meven wrote in slavebase.cpp:281
> That's on purpose, the first use of mapConfig is in rebuildConfig and is a 
> clear() call.

So? This line is not needed, an empty map is an empty map, no need to assign an 
empty map to it.

> dfaure wrote in slavebase.h:342
> missing @since

Time passed, this is for 5.63 now, sorry about that.

> dfaure wrote in slavebase.h:353
> @deprecated since 5.xx

@deprecated since 5.63, use mapConfig() instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23523

To: meven, davidedmundson, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

[David Faure]

dfaure added a comment.


  In D23898#529947 , 
@elvisangelaccio wrote:
  
  > I don't have 5.14 around atm, so I trust you've tested this :)
  
  
  Well the only new thing in 5.14 is a runtime warning. This patch should work 
with older versions of Qt too :-)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23895: [KDeclarative autotests] Replace fork of old modeltest with QAbstractItemModelTester

[David Faure]

dfaure closed this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23895

To: dfaure, mart, davidedmundson, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23895: [KDeclarative autotests] Replace fork of old modeltest with QAbstractItemModelTester

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  modeltest

REVISION DETAIL
  https://phabricator.kde.org/D23895

To: dfaure, mart, davidedmundson, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

[David Faure]

dfaure updated this revision to Diff 65905.
dfaure added a comment.


  Clean up autotest code

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23898?vs=65903&id=65905

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

AFFECTED FILES
  autotests/kurlnavigatortest.cpp
  autotests/kurlnavigatortest.h
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorbutton_p.h

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  I don't have 5.14 around atm, so I trust you've tested this :)

INLINE COMMENTS

> kurlnavigatortest.cpp:265
> +KFilePlacesModel model;
> +const QString pwd = QDir::currentPath();
> +const QUrl url = QUrl::fromLocalFile(pwd);

Did you mean `cwd` ?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23551: CMake config files: use as dep version the Qt one built against (private API)

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "CMake config files: use as min dep 
version the Qt version we built against" to "CMake config files: use as dep 
version the Qt one built against (private API)".

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23551

To: kossebau, #frameworks, aacid, #build_system
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23898: [KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: elvisangelaccio.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Since Qt-5.14 this leads to a runtime warning from QCharRef.
  
  The solution resizes "big" before hand, and then resizes again at
  the end, to the final size.

TEST PLAN
  running dolphin; new unittest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23898

AFFECTED FILES
  autotests/kurlnavigatortest.cpp
  autotests/kurlnavigatortest.h
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorbutton_p.h

To: dfaure, elvisangelaccio
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in kkeysequencewidget.cpp:127
> My two (inexperienced) pennyworth: if it makes sense, and should have been 
> done to begin with (so most likely it's an oversight), I'd always go for it 
> (who knows how long it'll be before that bit of code is looked at again).

As someone who looked at a lot of commit history, my recommendation is: don't 
do in the same commit. Make it a separate commit with a dedicated commit 
message.
While-at-it changes are annoying for future code history readers, which 
includes one older-self. So not only for that reason be friendly to them :)

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23813: Port away from foreach loops over arguments without calls to owner class

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> kossebau wrote in kkeysequencewidget.cpp:127
> I try (hard, there are many temptations when looking at all exisiting loop 
> code) to usually do not too much other improvements but stay on-topic of 
> commit message change, but will do an exception given you asked for it, and 
> the change will not confuse commit history reader too much :)

My two (inexperienced) pennyworth: if it makes sense, and should have been done 
to begin with (so most likely it's an oversight), I'd always go for it (who 
knows how long it'll be before that bit of code is looked at again).

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23813

To: kossebau, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/69/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Sep 2019 10:32:35 +
 Build duration:
9 min 24 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_jobtestFailed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 79 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/79/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 10:32:35 +
 Build duration:
6 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 1883 lines...][2019-09-12T10:39:18.695Z] [ 88%] Building CXX object autotests/CMakeFiles/kfilecopytomenutest.dir/kfilecopytomenutest.cpp.o[2019-09-12T10:39:18.695Z] [ 88%] Building CXX object autotests/CMakeFiles/kurlrequestertest.dir/kurlrequestertest.cpp.o[2019-09-12T10:39:18.695Z] [ 88%] Building CXX object autotests/CMakeFiles/kfileplacesmodeltest.dir/kfileplacesmodeltest.cpp.o[2019-09-12T10:39:18.695Z] [ 88%] Built target kfilewidgettest_autogen[2019-09-12T10:39:18.695Z] [ 89%] Building CXX object src/designer/CMakeFiles/kiowidgets.dir/qrc_designerplugin.cpp.o[2019-09-12T10:39:18.695Z] Scanning dependencies of target kurlcomboboxtest[2019-09-12T10:39:18.695Z] [ 89%] Building CXX object autotests/CMakeFiles/kurlcomboboxtest.dir/kurlcomboboxtest_autogen/mocs_compilation.cpp.o[2019-09-12T10:39:19.257Z] [ 89%] Building CXX object autotests/CMakeFiles/kurlnavigatortest.dir/kurlnavigatortest.cpp.o[2019-09-12T10:39:19.517Z] [ 89%] Building CXX object autotests/CMakeFiles/kurlcomboboxtest.dir/kurlcomboboxtest.cpp.o[2019-09-12T10:39:19.773Z] Scanning dependencies of target udsentrybenchmark_autogen[2019-09-12T10:39:19.773Z] [ 89%] Automatic MOC for target udsentrybenchmark[2019-09-12T10:39:19.773Z] Scanning dependencies of target kfilecustomdialogtest[2019-09-12T10:39:19.773Z] [ 89%] Building CXX object autotests/CMakeFiles/kfilecustomdialogtest.dir/kfilecustomdialogtest_autogen/mocs_compilation.cpp.o[2019-09-12T10:39:19.773Z] [ 89%] Linking CXX shared module ../../bin/kio5widgets.so[2019-09-12T10:39:20.029Z] [ 89%] Built target udsentrybenchmark_autogen[2019-09-12T10:39:20.029Z] [ 89%] Building CXX object autotests/CMakeFiles/kfilecustomdialogtest.dir/kfilecustomdialogtest.cpp.o[2019-09-12T10:39:20.285Z] [ 89%] Built target kiowidgets[2019-09-12T10:39:20.285Z] Scanning dependencies of target kdiroperatortest_autogen[2019-09-12T10:39:20.285Z] [ 89%] Automatic MOC for target kdiroperatortest[2019-09-12T10:39:20.285Z] Scanning dependencies of target kfileplacesviewtest[2019-09-12T10:39:20.285Z] [ 90%] Building CXX object autotests/CMakeFiles/kfileplacesviewtest.dir/kfileplacesviewtest_autogen/mocs_compilation.cpp.o[2019-09-12T10:39:20.285Z] [ 90%] Building CXX object autotests/CMakeFiles/kfileplacesviewtest.dir/kfileplacesviewtest.cpp.o[2019-09-12T10:39:20.542Z] [ 90%] Built target kdiroperatortest_autogen[2019-09-12T10:39:20.542Z] Scanning dependencies of target knewfilemenutest[2019-09-12T10:39:20.799Z] [ 90%] Building CXX object autotests/CMakeFiles/knewfilemenutest.dir/knewfilemenutest_autogen/mocs_compilation.cpp.o[2019-09-12T10:39:20.799Z] [ 90%] Building CXX object autotests/CMakeFiles/knewfilemenutest.dir/knewfilemenutest.cpp.o[2019-09-12T10:39:20.799Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/autotests/kurlnavigatortest.cpp: In member function ���void KUrlNavigatorTest::testButtonUrl()���:[2019-09-12T10:39:20.799Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/autotests/kurlnavigatortest.cpp:252:56: warning: ���QUrl KUrlNavigator::url(int) const��� is deprecated [-Wdeprecated-declarations][2019-09-12T10:39:20.799Z]   252 | const QUrl buttonUrl = m_navigator->url(buttonIndex);[2019-09-12T10:39:20.799Z]   |^[2019-09-12T10:39:20.799Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/autotests/kurlnavigatortest.cpp:25:[2019-09-12T10:39:20.799Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/filewidgets/kurlnavigator.h:309:36: note: declared here[2019-09-12T10:39:20.799Z]   309 | KIOFILEWIDGETS_DEPRECATED QUrl url(int index) const;[2019-09-12T10:39:20.799Z]   |^~~[2019-09-12T10:39:20.799Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/autotests/kurlnavigatortest.cpp: In member function ���void KUrlNavigatorTest::testInitWithRedundantPathSeparators()���:[2019-09-12T10:39:20.799Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/autotests/kurlnavigatortest.cpp:262:42: warning: ���QUrl KUrlNavigator::url(int) const��� is deprecated [-Wdeprecated-declarations][2019-09-12T10:39:20.799Z]   262 | const QUrl buttonUrl = temp_nav.url(3);[2019-09-12T10:39:20.799Z]   |  ^[2019-09-12T10:39:20.799Z] In file included from /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/autotests/kurlnavigatortest.cpp:25:[2019-09-12T10:39:20.799Z] /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.13/src/filewidgets/kurlnavigator.h:309:36: note: declared here[2019-09-12T10:39:20.799Z]   309 | KIOFILEWIDGETS_DEPRECATED QUrl url(int index) const;[2019-09-12T10:39:20.799Z]   |  

D23893: [KIO] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23893

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » krunner » kf5-qt5 SUSEQt5.13 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/krunner/job/kf5-qt5%20SUSEQt5.13/16/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 10:30:55 +
 Build duration:
1 min 12 sec and counting
   CONSOLE OUTPUT
  [...truncated 432 lines...][2019-09-12T10:32:00.428Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:196:50: note: declared here[2019-09-12T10:32:00.428Z]   196 | static KSERVICE_DEPRECATED KPluginInfo::List fromServices(const KService::List &services, const KConfigGroup &config = KConfigGroup());[2019-09-12T10:32:00.428Z]   |  ^~~~[2019-09-12T10:32:00.428Z] /home/jenkins/workspace/Frameworks/krunner/kf5-qt5 SUSEQt5.13/src/runnermanager.cpp:713:44: warning: ���static KPluginInfo::List KPluginInfo::fromServices(const List&, const KConfigGroup&)��� is deprecated [-Wdeprecated-declarations][2019-09-12T10:32:00.428Z]   713 | return KPluginInfo::fromServices(offers);[2019-09-12T10:32:00.428Z]   |^[2019-09-12T10:32:00.428Z] In file included from /home/jenkins/workspace/Frameworks/krunner/kf5-qt5 SUSEQt5.13/src/runnermanager.h:28,[2019-09-12T10:32:00.428Z]  from /home/jenkins/workspace/Frameworks/krunner/kf5-qt5 SUSEQt5.13/src/runnermanager.cpp:22:[2019-09-12T10:32:00.428Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:196:50: note: declared here[2019-09-12T10:32:00.428Z]   196 | static KSERVICE_DEPRECATED KPluginInfo::List fromServices(const KService::List &services, const KConfigGroup &config = KConfigGroup());[2019-09-12T10:32:00.428Z]   |  ^~~~[2019-09-12T10:32:00.428Z] /home/jenkins/workspace/Frameworks/krunner/kf5-qt5 SUSEQt5.13/src/runnermanager.cpp:713:44: warning: ���static KPluginInfo::List KPluginInfo::fromServices(const List&, const KConfigGroup&)��� is deprecated [-Wdeprecated-declarations][2019-09-12T10:32:00.428Z]   713 | return KPluginInfo::fromServices(offers);[2019-09-12T10:32:00.428Z]   |^[2019-09-12T10:32:00.428Z] In file included from /home/jenkins/workspace/Frameworks/krunner/kf5-qt5 SUSEQt5.13/src/runnermanager.h:28,[2019-09-12T10:32:00.428Z]  from /home/jenkins/workspace/Frameworks/krunner/kf5-qt5 SUSEQt5.13/src/runnermanager.cpp:22:[2019-09-12T10:32:00.428Z] /home/jenkins/install-prefix/include/KF5/KService/kplugininfo.h:196:50: note: declared here[2019-09-12T10:32:00.428Z]   196 | static KSERVICE_DEPRECATED KPluginInfo::List fromServices(const KService::List &services, const KConfigGroup &config = KConfigGroup());[2019-09-12T10:32:00.428Z]   |  ^~~~[2019-09-12T10:32:01.352Z] [ 30%] Linking CXX shared library ../bin/libKF5Runner.so[2019-09-12T10:32:01.607Z] [ 30%] Built target KF5Runner[2019-09-12T10:32:01.607Z] Scanning dependencies of target runnermodeltest_autogen[2019-09-12T10:32:01.607Z] Scanning dependencies of target runnermodelplugin_autogen[2019-09-12T10:32:01.607Z] Scanning dependencies of target dbusrunnertest_autogen[2019-09-12T10:32:01.607Z] Scanning dependencies of target runnertest_autogen[2019-09-12T10:32:01.607Z] Scanning dependencies of target testremoterunner_autogen[2019-09-12T10:32:01.607Z] Scanning dependencies of target runnercontexttest_autogen[2019-09-12T10:32:01.607Z] [ 32%] Automatic MOC for target runnermodeltest[2019-09-12T10:32:01.607Z] [ 34%] Automatic MOC for target testremoterunner[2019-09-12T10:32:01.607Z] [ 37%] Automatic MOC for target runnercontexttest[2019-09-12T10:32:01.607Z] [ 39%] Automatic MOC for target runnertest[2019-09-12T10:32:01.607Z] [ 41%] Automatic MOC for target dbusrunnertest[2019-09-12T10:32:01.607Z] [ 44%] Automatic MOC for target runnermodelplugin[2019-09-12T10:32:01.607Z] [ 44%] Built target runnertest_autogen[2019-09-12T10:32:01.607Z] Scanning dependencies of target runnertest[2019-09-12T10:32:01.863Z] [ 46%] Building CXX object tests/CMakeFiles/runnertest.dir/runnertest_autogen/mocs_compilation.cpp.o[2019-09-12T10:32:01.863Z] [ 48%] Building CXX object tests/CMakeFiles/runnertest.dir/runnertest.cpp.o[2019-09-12T10:32:01.863Z] [ 48%] Built target runnermodelplugin_autogen[2019-09-12T10:32:01.863Z] [ 48%] Built target runnermodeltest_autogen[2019-09-12T10:32:01.863Z] [ 48%] Built target testremoterunner_autogen[2019-09-12T10:32:01.863Z] [ 51%] Generating krunner1adaptor.cpp, krunner1adaptor.h[2019-09-12T10:32:01.863Z] [ 53%] Generating krunner1adaptor.moc[2019-09-12T10:32:01.863Z] Scanning dependencies of target runnermodeltest[2019-09-12T10:32:01.863Z] Scanning dependencies of target runnermodelplugin[2019-09-12T10:32:01.863Z] [ 55%] Building CXX object tests/CMakeFiles/runnermodeltest.dir/runnermodeltest_autogen/mocs_compilation.cpp.o[2019-09-12T10:32:01.863Z] [ 58%] Building CXX object tests/CMak

D23896: [KDeclarative] Port away from deprecated QQuickWindow::sendEvent

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  The code in QQuickWindow::sendEvent doesn't do anything special
  for UngrabMouse events, it just calls QCoreApplication::sendEvent
  [This code says QGuiApplication::sendEvent everywhere so I used
  that for consistency]

TEST PLAN
  Builds

REPOSITORY
  R296 KDeclarative

BRANCH
  quickwindow_sendevent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23896

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp

To: dfaure, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/17/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 10:26:33 +
 Build duration:
1 min 42 sec and counting
   CONSOLE OUTPUT
  [...truncated 442 lines...][2019-09-12T10:28:06.423Z] [ 47%] Built target KF5Parts[2019-09-12T10:28:06.423Z] Scanning dependencies of target partviewer_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target notepadpart_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target spellcheckplugin_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target normalktmtest_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target terminal_test_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target kpartstest_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target openorsavequestion_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target openorsavequestion_unittest_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target parttest_autogen[2019-09-12T10:28:06.423Z] [ 48%] Automatic MOC for target partviewer[2019-09-12T10:28:06.423Z] [ 50%] Automatic MOC for target notepadpart[2019-09-12T10:28:06.423Z] [ 51%] Automatic MOC for target openorsavequestion[2019-09-12T10:28:06.423Z] [ 52%] Automatic MOC for target normalktmtest[2019-09-12T10:28:06.423Z] [ 53%] Automatic MOC for target spellcheckplugin[2019-09-12T10:28:06.423Z] [ 55%] Automatic MOC for target terminal_test[2019-09-12T10:28:06.423Z] [ 56%] Automatic MOC for target parttest[2019-09-12T10:28:06.423Z] [ 57%] Automatic MOC for target openorsavequestion_unittest[2019-09-12T10:28:06.423Z] [ 59%] Automatic MOC for target kpartstest[2019-09-12T10:28:06.423Z] [ 59%] Built target terminal_test_autogen[2019-09-12T10:28:06.423Z] Scanning dependencies of target terminal_test[2019-09-12T10:28:06.423Z] [ 60%] Building CXX object tests/CMakeFiles/terminal_test.dir/terminal_test_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.423Z] [ 60%] Built target openorsavequestion_autogen[2019-09-12T10:28:06.423Z] [ 60%] Built target parttest_autogen[2019-09-12T10:28:06.423Z] [ 60%] Built target partviewer_autogen[2019-09-12T10:28:06.423Z] [ 61%] Building CXX object tests/CMakeFiles/terminal_test.dir/terminal_test.cpp.o[2019-09-12T10:28:06.423Z] [ 61%] Built target spellcheckplugin_autogen[2019-09-12T10:28:06.424Z] Scanning dependencies of target openorsavequestion[2019-09-12T10:28:06.424Z] [ 63%] Building CXX object tests/CMakeFiles/openorsavequestion.dir/openorsavequestion_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.424Z] [ 63%] Built target notepadpart_autogen[2019-09-12T10:28:06.424Z] Scanning dependencies of target parttest[2019-09-12T10:28:06.424Z] Scanning dependencies of target partviewer[2019-09-12T10:28:06.424Z] [ 63%] Built target kpartstest_autogen[2019-09-12T10:28:06.424Z] [ 63%] Built target normalktmtest_autogen[2019-09-12T10:28:06.424Z] [ 63%] Built target openorsavequestion_unittest_autogen[2019-09-12T10:28:06.424Z] Scanning dependencies of target spellcheckplugin[2019-09-12T10:28:06.424Z] [ 64%] Building CXX object autotests/CMakeFiles/parttest.dir/parttest_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.424Z] [ 65%] Building CXX object tests/CMakeFiles/openorsavequestion.dir/openorsavequestion.cpp.o[2019-09-12T10:28:06.424Z] [ 67%] Building CXX object tests/CMakeFiles/partviewer.dir/partviewer_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.424Z] [ 68%] Building CXX object autotests/CMakeFiles/parttest.dir/parttest.cpp.o[2019-09-12T10:28:06.424Z] [ 69%] Building CXX object tests/CMakeFiles/spellcheckplugin.dir/spellcheckplugin_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.424Z] Scanning dependencies of target notepadpart[2019-09-12T10:28:06.424Z] [ 71%] Building CXX object tests/CMakeFiles/notepadpart.dir/notepadpart_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.424Z] Scanning dependencies of target normalktmtest[2019-09-12T10:28:06.424Z] Scanning dependencies of target kpartstest[2019-09-12T10:28:06.424Z] [ 72%] Building CXX object tests/CMakeFiles/spellcheckplugin.dir/plugin_spellcheck.cpp.o[2019-09-12T10:28:06.424Z] [ 73%] Building CXX object tests/CMakeFiles/kpartstest.dir/kpartstest_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:06.424Z] [ 75%] Building CXX object tests/CMakeFiles/normalktmtest.dir/normalktmtest_autogen/mocs_compilation.cpp.o[2019-09-12T10:28:07.031Z] [ 76%] Building CXX object tests/CMakeFiles/normalktmtest.dir/normalktm.cpp.o[2019-09-12T10:28:07.606Z] [ 77%] Building CXX object tests/CMakeFiles/notepadpart.dir/notepad.cpp.o[2019-09-12T10:28:07.606Z] [ 78%] Building CXX object tests/CMakeFiles/partviewer.dir/partviewer.cpp.o[2019-09-12T10:28:07.606Z] [ 80%] Linking CXX executable ../bin/terminal_test[2019-09-12T10:28:07.606Z] [ 81%] Building CXX object tests/CMakeFiles/normalktmtest.dir/parts.cpp.o[2019-09-12T10:28:07.606Z] [ 82%] Linking CXX executable ../bin/openorsav

D23895: [KDeclarative autotests] Replace fork of old modeltest with QAbstractItemModelTester

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R296 KDeclarative

BRANCH
  modeltest

REVISION DETAIL
  https://phabricator.kde.org/D23895

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/columnproxymodeltest.cpp
  autotests/modeltest.cpp
  autotests/modeltest.h

To: dfaure, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 199 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/199/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Sep 2019 10:13:51 +
 Build duration:
7 min 6 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.62.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/19)0%
(0/19)0%
(0/2377)0%
(0/1602)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/12)0%
(0/12)0%
(0/1831)0%
(0/1247)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/538)0%
(0/355)

D23894: [KDeclarative] Port from deprecated QWheelEvent::delta() to angleDelta()

[David Faure]

dfaure created this revision.
dfaure added reviewers: mart, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I'm assuming we don't want to rename the property just yet, for SC?
  Are the TODO KF6 correct?

TEST PLAN
  Builds

REPOSITORY
  R296 KDeclarative

BRANCH
  qwheelevent

REVISION DETAIL
  https://phabricator.kde.org/D23894

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp
  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h

To: dfaure, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.13/18/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 12 Sep 2019 10:13:51 +
 Build duration:
3 min 15 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 48 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/48/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 10:13:51 +
 Build duration:
2 min 56 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.62.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/3)0%
(0/19)0%
(0/19)0%
(0/2377)0%
(0/1602)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsexamples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src0%
(0/12)0%
(0/12)0%
(0/1831)0%
(0/1247)src.libkirigami0%
(0/6)0%
(0/6)0%
(0/538)0%
(0/355)

D23893: [KIO] Port away from deprecated methods in Qt 5.14

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  port_to_qt_514

REVISION DETAIL
  https://phabricator.kde.org/D23893

To: dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 46 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/46/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Thu, 12 Sep 2019 10:13:50 +
 Build duration:
1 min 15 sec and counting

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Sep 2019 10:13:51 +
 Build duration:
49 sec and counting

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 212 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/212/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Sep 2019 09:59:03 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.62.0.xmllogs/KF5KIO/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 52 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(265/403)66%
(265/403)55%
(33701/61208)39%
(17288/44142)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9376/9826)47%
(4347/9242)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(108/160)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(101/117)86%
(101/117)60%
(8640/14459)51%
(4786/9299)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4653/8280)43%
(2057/4837)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(7/7)100%
(7/7)56%
(674/1209)40%
(382/954)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1342)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1793/4290)36%
(1314/3670)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1332)56%
(601/1081)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
   

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 79 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/79/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Sep 2019 09:58:11 +
 Build duration:
12 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.62.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.klistopenfilesjobtest_unix
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6854/9069)43%
(10725/24785)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2855/2956)48%
(6141/12707)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)81%
(979/1215)50%
(1002/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kirigami » kf5-qt5 AndroidQt5.13 - Build # 45 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20AndroidQt5.13/45/
 Project:
kf5-qt5 AndroidQt5.13
 Date of build:
Thu, 12 Sep 2019 10:04:24 +
 Build duration:
3 min 22 sec and counting
   CONSOLE OUTPUT
  [...truncated 229 lines...][2019-09-12T10:06:30.994Z]  * Qt5Widgets (required version >= 5.13.0)[2019-09-12T10:06:30.994Z]  * Qt5Svg[2019-09-12T10:06:30.994Z]  * Qt5QuickControls2[2019-09-12T10:06:30.994Z]  * Qt5 (required version >= 5.11.0)[2019-09-12T10:06:30.994Z]  * ECM (required version >= 5.62.0), Extra CMake Modules., [2019-09-12T10:06:30.994Z]  * Qt5AndroidExtras (required version >= 5.11.0)[2019-09-12T10:06:30.994Z]  * Qt5Core[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z] -- The following features have been disabled:[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z] -- The following RUNTIME packages have not been found:[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z]  * QtGraphicalEffects-QMLModule, QML module 'QtGraphicalEffects' is a runtime dependency.[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z] -- Configuring done[2019-09-12T10:06:30.994Z] -- Generating done[2019-09-12T10:06:30.994Z] CMake Warning:[2019-09-12T10:06:30.994Z]   Manually-specified variables were not used by the project:[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z] KF5_HOST_TOOLING[2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z] [2019-09-12T10:06:30.994Z] -- Build files have been written to: /home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-12T10:06:33.479Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform AndroidQt5.13 --usingInstall /home/user/install-prefix/[2019-09-12T10:06:33.479Z] Scanning dependencies of target KF5Kirigami2_autogen[2019-09-12T10:06:33.479Z] [  3%] Automatic MOC for target KF5Kirigami2[2019-09-12T10:06:35.155Z] [  3%] Built target KF5Kirigami2_autogen[2019-09-12T10:06:35.155Z] Scanning dependencies of target copy[2019-09-12T10:06:35.155Z] [  3%] Built target copy[2019-09-12T10:06:35.155Z] Scanning dependencies of target applicationitemapp_autogen[2019-09-12T10:06:35.155Z] [  7%] Automatic MOC for target applicationitemapp[2019-09-12T10:06:35.155Z] [  7%] Built target applicationitemapp_autogen[2019-09-12T10:06:35.155Z] Scanning dependencies of target KF5Kirigami2[2019-09-12T10:06:35.155Z] [ 10%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:35.155Z] [ 14%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2019-09-12T10:06:38.314Z] /home/user/workspace/Frameworks/kirigami/kf5-qt5 AndroidQt5.13/src/libkirigami/platformtheme.cpp:700:71: warning: unused parameter 'customColor' [-Wunused-parameter][2019-09-12T10:06:38.314Z] QIcon PlatformTheme::iconFromTheme(const QString &name, const QColor &customColor)[2019-09-12T10:06:38.314Z]   ^[2019-09-12T10:06:39.384Z] 1 warning generated.[2019-09-12T10:06:39.384Z] [ 17%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2019-09-12T10:06:43.406Z] [ 21%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2019-09-12T10:06:45.770Z] [ 25%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2019-09-12T10:06:46.821Z] [ 28%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2019-09-12T10:06:49.175Z] [ 32%] Linking CXX shared library ../../bin/libKF5Kirigami2.so[2019-09-12T10:06:49.694Z] [ 32%] Built target KF5Kirigami2[2019-09-12T10:06:49.694Z] [ 35%] Generating qrc_resources.cpp[2019-09-12T10:06:50.202Z] Scanning dependencies of target applicationitemapp[2019-09-12T10:06:50.202Z] [ 39%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:50.202Z] [ 42%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2019-09-12T10:06:56.379Z] [ 46%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2019-09-12T10:06:56.379Z] [ 50%] Linking CXX executable ../../bin/applicationitemapp[2019-09-12T10:06:56.379Z] clang++: warning: argument unused during compilation: '-pie' [-Wunused-command-line-argument][2019-09-12T10:06:56.379Z] [ 50%] Built target applicationitemapp[2019-09-12T10:06:56.379Z] Scanning dependencies of target kirigamiplugin_autogen[2019-09-12T10:06:56.379Z] [ 53%] Automatic MOC for target kirigamiplugin[2019-09-12T10:06:59.597Z] [ 

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.13 - Build # 16 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.13/16/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 10:02:18 +
 Build duration:
4 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 430 lines...][2019-09-12T10:06:37.919Z] [ 32%] Building CXX object src/CMakeFiles/KF5Parts.dir/browserrun.cpp.o[2019-09-12T10:06:37.919Z] [ 34%] Building CXX object src/CMakeFiles/KF5Parts.dir/browseropenorsavequestion.cpp.o[2019-09-12T10:06:37.919Z] [ 35%] Building CXX object src/CMakeFiles/KF5Parts.dir/statusbarextension.cpp.o[2019-09-12T10:06:38.419Z] [ 36%] Building CXX object src/CMakeFiles/KF5Parts.dir/scriptableextension.cpp.o[2019-09-12T10:06:38.918Z] [ 38%] Building CXX object src/CMakeFiles/KF5Parts.dir/textextension.cpp.o[2019-09-12T10:06:38.918Z] [ 39%] Building CXX object src/CMakeFiles/KF5Parts.dir/htmlextension.cpp.o[2019-09-12T10:06:40.596Z] [ 40%] Building CXX object src/CMakeFiles/KF5Parts.dir/htmlsettingsinterface.cpp.o[2019-09-12T10:06:40.596Z] [ 42%] Building CXX object src/CMakeFiles/KF5Parts.dir/selectorinterface.cpp.o[2019-09-12T10:06:40.596Z] [ 43%] Building CXX object src/CMakeFiles/KF5Parts.dir/fileinfoextension.cpp.o[2019-09-12T10:06:41.648Z] [ 44%] Building CXX object src/CMakeFiles/KF5Parts.dir/listingfilterextension.cpp.o[2019-09-12T10:06:41.648Z] [ 46%] Building CXX object src/CMakeFiles/KF5Parts.dir/listingnotificationextension.cpp.o[2019-09-12T10:06:43.303Z] [ 47%] Linking CXX shared library ../bin/libKF5Parts.so[2019-09-12T10:06:46.417Z] [ 47%] Built target KF5Parts[2019-09-12T10:06:46.417Z] Scanning dependencies of target terminal_test_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target kpartstest_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target notepadpart_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target partviewer_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target spellcheckplugin_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target normalktmtest_autogen[2019-09-12T10:06:46.417Z] [ 48%] Automatic MOC for target notepadpart[2019-09-12T10:06:46.417Z] [ 51%] Automatic MOC for target terminal_test[2019-09-12T10:06:46.417Z] [ 51%] Automatic MOC for target kpartstest[2019-09-12T10:06:46.417Z] [ 52%] Automatic MOC for target partviewer[2019-09-12T10:06:46.417Z] [ 53%] Automatic MOC for target spellcheckplugin[2019-09-12T10:06:46.417Z] [ 55%] Automatic MOC for target normalktmtest[2019-09-12T10:06:46.417Z] [ 55%] Built target partviewer_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target openorsavequestion_autogen[2019-09-12T10:06:46.417Z] [ 56%] Automatic MOC for target openorsavequestion[2019-09-12T10:06:46.417Z] [ 56%] Built target terminal_test_autogen[2019-09-12T10:06:46.417Z] [ 56%] Built target openorsavequestion_autogen[2019-09-12T10:06:46.417Z] Scanning dependencies of target openorsavequestion_unittest_autogen[2019-09-12T10:06:46.417Z] [ 57%] Automatic MOC for target openorsavequestion_unittest[2019-09-12T10:06:46.417Z] Scanning dependencies of target parttest_autogen[2019-09-12T10:06:46.417Z] [ 59%] Automatic MOC for target parttest[2019-09-12T10:06:46.916Z] [ 59%] Built target spellcheckplugin_autogen[2019-09-12T10:06:46.916Z] [ 59%] Built target parttest_autogen[2019-09-12T10:06:46.916Z] Scanning dependencies of target spellcheckplugin[2019-09-12T10:06:46.916Z] [ 60%] Building CXX object tests/CMakeFiles/spellcheckplugin.dir/spellcheckplugin_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:46.916Z] [ 61%] Building CXX object tests/CMakeFiles/spellcheckplugin.dir/plugin_spellcheck.cpp.o[2019-09-12T10:06:47.416Z] Scanning dependencies of target partviewer[2019-09-12T10:06:47.416Z] [ 63%] Building CXX object tests/CMakeFiles/partviewer.dir/partviewer_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:47.416Z] [ 63%] Built target normalktmtest_autogen[2019-09-12T10:06:47.416Z] [ 63%] Built target openorsavequestion_unittest_autogen[2019-09-12T10:06:47.416Z] [ 63%] Built target kpartstest_autogen[2019-09-12T10:06:47.416Z] [ 63%] Built target notepadpart_autogen[2019-09-12T10:06:47.416Z] [ 64%] Building CXX object tests/CMakeFiles/partviewer.dir/partviewer.cpp.o[2019-09-12T10:06:47.416Z] Scanning dependencies of target openorsavequestion[2019-09-12T10:06:47.416Z] Scanning dependencies of target terminal_test[2019-09-12T10:06:47.416Z] [ 65%] Building CXX object tests/CMakeFiles/openorsavequestion.dir/openorsavequestion_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:47.416Z] [ 67%] Building CXX object tests/CMakeFiles/terminal_test.dir/terminal_test_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:47.416Z] Scanning dependencies of target openorsavequestion_unittest[2019-09-12T10:06:47.416Z] [ 68%] Building CXX object autotests/CMakeFiles/openorsavequestion_unittest.dir/openorsavequestion_unittest_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:47.416Z] [ 69%] Building CXX object tests/CMakeFiles/t

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 47 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/47/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 10:04:25 +
 Build duration:
1 min 45 sec and counting
   CONSOLE OUTPUT
  [...truncated 259 lines...][2019-09-12T10:06:02.176Z]  * Qt5Network (required version >= 5.13.1)[2019-09-12T10:06:02.176Z]  * Qt5Qml (required version >= 5.13.1)[2019-09-12T10:06:02.176Z]  * Qt5Quick[2019-09-12T10:06:02.176Z]  * Qt5Gui[2019-09-12T10:06:02.176Z]  * Qt5Widgets (required version >= 5.13.1)[2019-09-12T10:06:02.176Z]  * Qt5Svg[2019-09-12T10:06:02.176Z]  * Qt5QuickControls2[2019-09-12T10:06:02.176Z]  * Qt5 (required version >= 5.11.0)[2019-09-12T10:06:02.176Z]  * ECM (required version >= 5.62.0), Extra CMake Modules., [2019-09-12T10:06:02.176Z]  * Doxygen (required version >= 1.8.13)[2019-09-12T10:06:02.176Z]Needed for API dox QCH file generation[2019-09-12T10:06:02.176Z]  * QHelpGenerator, Part of Qt5 tools[2019-09-12T10:06:02.176Z]Needed for API dox QCH file generation[2019-09-12T10:06:02.176Z]  * Qt5Core[2019-09-12T10:06:02.176Z] [2019-09-12T10:06:02.176Z] -- Configuring done[2019-09-12T10:06:02.176Z] -- Generating done[2019-09-12T10:06:02.176Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-12T10:06:03.484Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.13 --usingInstall /home/jenkins//install-prefix/[2019-09-12T10:06:03.484Z] Scanning dependencies of target copy[2019-09-12T10:06:03.484Z] Scanning dependencies of target KF5Kirigami2_autogen[2019-09-12T10:06:03.484Z] Scanning dependencies of target KF5Kirigami2_QCH[2019-09-12T10:06:03.484Z] Scanning dependencies of target applicationitemapp_autogen[2019-09-12T10:06:03.484Z] [  3%] Automatic MOC for target KF5Kirigami2[2019-09-12T10:06:03.484Z] [  6%] Automatic MOC for target applicationitemapp[2019-09-12T10:06:03.484Z] [  9%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2019-09-12T10:06:03.484Z] [  9%] Built target applicationitemapp_autogen[2019-09-12T10:06:03.484Z] [  9%] Built target copy[2019-09-12T10:06:03.484Z] [ 12%] Generating qrc_resources.cpp[2019-09-12T10:06:03.484Z] Building up file structure...[2019-09-12T10:06:03.484Z] Insert custom filters...[2019-09-12T10:06:03.484Z] Insert help data for filter section (1 of 1)...[2019-09-12T10:06:03.484Z] Insert files...[2019-09-12T10:06:03.484Z] Insert contents...[2019-09-12T10:06:03.484Z] Insert indices...[2019-09-12T10:06:03.484Z] Documentation successfully generated.[2019-09-12T10:06:03.484Z] [ 12%] Built target KF5Kirigami2_QCH[2019-09-12T10:06:03.742Z] Scanning dependencies of target applicationitemapp[2019-09-12T10:06:03.742Z] [ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:03.742Z] [ 21%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2019-09-12T10:06:03.742Z] [ 21%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2019-09-12T10:06:03.742Z] [ 21%] Built target KF5Kirigami2_autogen[2019-09-12T10:06:03.742Z] [ 25%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2019-09-12T10:06:03.742Z] [ 28%] Generating tabletmodemanager_interface.moc[2019-09-12T10:06:03.742Z] Scanning dependencies of target KF5Kirigami2[2019-09-12T10:06:03.742Z] [ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2019-09-12T10:06:03.742Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2019-09-12T10:06:03.742Z] [ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2019-09-12T10:06:03.742Z] [ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2019-09-12T10:06:03.742Z] [ 43%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2019-09-12T10:06:03.742Z] [ 46%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2019-09-12T10:06:03.742Z] [ 50%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2019-09-12T10:06:05.111Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/libkirigami/platformtheme.cpp: In member function ���virtual QIcon Kirigami::PlatformTheme::iconFromTheme(const QString&, const QColor&)���:[2019-09-12T10:06:05.111Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.13/src/libkirigami/platformtheme.cpp:700:71: warning: unused parameter ���customColor��� [-Wunused-parameter][2019-09-12T10:06:05.111Z]   7

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.13 - Build # 17 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.13/17/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 12 Sep 2019 10:04:25 +
 Build duration:
1 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 272 lines...][2019-09-12T10:05:16.653Z] -- Build files have been written to: C:/CI/workspace/Frameworks/kirigami/kf5-qt5 WindowsMSVCQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] bat[2019-09-12T10:05:18.991Z] [2019-09-12T10:05:18.991Z] C:\CI\workspace\Frameworks\kirigami\kf5-qt5 WindowsMSVCQt5.13>call "C:/Program Files (x86)/Microsoft Visual Studio/2019/Professional/VC/Auxiliary/Build/vcvars64.bat" -vcvars_ver=14.16 [2019-09-12T10:05:18.991Z] **[2019-09-12T10:05:18.991Z] ** Visual Studio 2019 Developer Command Prompt v16.2.4[2019-09-12T10:05:18.991Z] ** Copyright (c) 2019 Microsoft Corporation[2019-09-12T10:05:18.991Z] **[2019-09-12T10:05:20.366Z] [vcvarsall.bat] Environment initialized for: 'x64'[2019-09-12T10:05:20.624Z] [2019-09-12T10:05:20.624Z] jom 1.1.3 - empower your cores[2019-09-12T10:05:20.624Z] [2019-09-12T10:05:20.624Z] jom: parallel job execution disabled for Makefile[2019-09-12T10:05:20.624Z] Scanning dependencies of target copy[2019-09-12T10:05:20.624Z] Scanning dependencies of target KF5Kirigami2_autogen[2019-09-12T10:05:20.624Z] Scanning dependencies of target KF5Kirigami2_QCH[2019-09-12T10:05:20.624Z] Scanning dependencies of target applicationitemapp_autogen[2019-09-12T10:05:20.890Z] [ 10%] Automatic MOC for target applicationitemapp[2019-09-12T10:05:20.890Z] [ 10%] Built target applicationitemapp_autogen[2019-09-12T10:05:21.152Z] [  6%] Automatic MOC for target KF5Kirigami2[2019-09-12T10:05:21.152Z] [ 13%] Built target KF5Kirigami2_autogen[2019-09-12T10:05:21.152Z] [ 13%] Built target copy[2019-09-12T10:05:21.152Z] [  6%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2019-09-12T10:05:21.152Z] [ 13%] Generating qrc_resources.cpp[2019-09-12T10:05:21.152Z] Scanning dependencies of target applicationitemapp[2019-09-12T10:05:21.152Z] Scanning dependencies of target KF5Kirigami2[2019-09-12T10:05:21.427Z] [ 17%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.obj[2019-09-12T10:05:21.427Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.obj[2019-09-12T10:05:21.427Z] [ 31%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.obj[2019-09-12T10:05:21.427Z] main.cpp[2019-09-12T10:05:21.427Z] [ 37%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.obj[2019-09-12T10:05:21.427Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.obj[2019-09-12T10:05:21.427Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.obj[2019-09-12T10:05:21.427Z] [ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.obj[2019-09-12T10:05:21.427Z] [ 41%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.obj[2019-09-12T10:05:21.427Z] [ 44%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.obj[2019-09-12T10:05:21.427Z] platformtheme.cpp[2019-09-12T10:05:21.427Z] mocs_compilation.cpp[2019-09-12T10:05:21.427Z] mocs_compilation.cpp[2019-09-12T10:05:21.427Z] qrc_resources.cpp[2019-09-12T10:05:21.687Z] [ 44%] Built target KF5Kirigami2_QCH[2019-09-12T10:05:22.625Z] tabletmodewatcher.cpp[2019-09-12T10:05:22.625Z] loggingcategory.cpp[2019-09-12T10:05:22.625Z] kirigamipluginfactory.cpp[2019-09-12T10:05:23.197Z] basictheme.cpp[2019-09-12T10:05:23.456Z] [ 48%] Linking CXX shared library ..\..\bin\KF5Kirigami2.dll[2019-09-12T10:05:23.715Z]Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp[2019-09-12T10:05:23.972Z] [ 51%] Linking CXX executable ..\..\bin\applicationitemapp.exe[2019-09-12T10:05:24.234Z]Creating library ..\..\lib\KF5Kirigami2.lib and object ..\..\lib\KF5Kirigami2.exp[2019-09-12T10:05:24.234Z] [ 51%] Built target KF5Kirigami2[2019-09-12T10:05:24.234Z] Scanning dependencies of target kirigamiplugin_autogen[2019-09-12T10:05:24.493Z]Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp[2019-09-12T10:05:24.751Z] [ 55%] Automatic MOC for target kirigamiplugin[2019-09-12T10:05:24.751Z] [ 55%] Built target kirigamiplugin_autogen[2019-09-12T10:05:25.009Z]Creating library ..\..\lib\applicationitemapp.lib and object ..\..\lib\applicationitemapp.exp[2019-09-12T10:05:25.009Z] [ 55%] Built target applicationitemapp[2019-09-1

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 198 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/198/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 12 Sep 2019 10:04:25 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2019-09-12T10:05:07.675Z]  * Qt5Network (required version >= 5.12.4)[2019-09-12T10:05:07.675Z]  * Qt5Qml (required version >= 5.12.4)[2019-09-12T10:05:07.675Z]  * Qt5Quick[2019-09-12T10:05:07.675Z]  * Qt5Gui[2019-09-12T10:05:07.675Z]  * Qt5Widgets (required version >= 5.12.4)[2019-09-12T10:05:07.675Z]  * Qt5Svg[2019-09-12T10:05:07.675Z]  * Qt5QuickControls2[2019-09-12T10:05:07.675Z]  * Qt5 (required version >= 5.11.0)[2019-09-12T10:05:07.675Z]  * ECM (required version >= 5.62.0), Extra CMake Modules., [2019-09-12T10:05:07.675Z]  * Doxygen (required version >= 1.8.13)[2019-09-12T10:05:07.675Z]Needed for API dox QCH file generation[2019-09-12T10:05:07.675Z]  * QHelpGenerator, Part of Qt5 tools[2019-09-12T10:05:07.675Z]Needed for API dox QCH file generation[2019-09-12T10:05:07.675Z]  * Qt5Core[2019-09-12T10:05:07.675Z] [2019-09-12T10:05:07.675Z] -- Configuring done[2019-09-12T10:05:07.931Z] -- Generating done[2019-09-12T10:05:07.931Z] -- Build files have been written to: /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-12T10:05:09.595Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-09-12T10:05:09.595Z] Scanning dependencies of target KF5Kirigami2_autogen[2019-09-12T10:05:09.595Z] Scanning dependencies of target applicationitemapp_autogen[2019-09-12T10:05:09.595Z] Scanning dependencies of target KF5Kirigami2_QCH[2019-09-12T10:05:09.595Z] Scanning dependencies of target copy[2019-09-12T10:05:09.595Z] [  6%] Automatic MOC for target applicationitemapp[2019-09-12T10:05:09.595Z] [  6%] Automatic MOC for target KF5Kirigami2[2019-09-12T10:05:09.595Z] [  9%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2019-09-12T10:05:09.595Z] [  9%] Built target copy[2019-09-12T10:05:09.595Z] [  9%] Built target applicationitemapp_autogen[2019-09-12T10:05:09.595Z] [ 12%] Generating qrc_resources.cpp[2019-09-12T10:05:09.595Z] Building up file structure...[2019-09-12T10:05:09.595Z] Insert custom filters...[2019-09-12T10:05:09.595Z] Insert help data for filter section (1 of 1)...[2019-09-12T10:05:09.595Z] Insert files...[2019-09-12T10:05:09.595Z] Insert contents...[2019-09-12T10:05:09.595Z] Insert indices...[2019-09-12T10:05:09.595Z] Documentation successfully generated.[2019-09-12T10:05:09.853Z] [ 12%] Built target KF5Kirigami2_QCH[2019-09-12T10:05:09.853Z] Scanning dependencies of target applicationitemapp[2019-09-12T10:05:09.853Z] [ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2019-09-12T10:05:09.853Z] [ 18%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2019-09-12T10:05:09.853Z] [ 21%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2019-09-12T10:05:09.853Z] [ 21%] Built target KF5Kirigami2_autogen[2019-09-12T10:05:09.853Z] [ 25%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2019-09-12T10:05:09.853Z] [ 28%] Generating tabletmodemanager_interface.moc[2019-09-12T10:05:09.853Z] Scanning dependencies of target KF5Kirigami2[2019-09-12T10:05:09.853Z] [ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2019-09-12T10:05:09.853Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2019-09-12T10:05:09.853Z] [ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2019-09-12T10:05:09.853Z] [ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2019-09-12T10:05:09.853Z] [ 43%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2019-09-12T10:05:09.853Z] [ 46%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2019-09-12T10:05:09.854Z] [ 50%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2019-09-12T10:05:11.235Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/libkirigami/platformtheme.cpp: In member function ���virtual QIcon Kirigami::PlatformTheme::iconFromTheme(const QString&, const QColor&)���:[2019-09-12T10:05:11.236Z] /home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 SUSEQt5.12/src/libkirigami/platformtheme.cpp:700:71: warning: unused parameter ���customColor��� [-Wunused-parameter][2019-09-12T10:05:11.236Z]   700 | 

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.13/43/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 12 Sep 2019 10:04:25 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 204 lines...][2019-09-12T10:04:58.193Z]  * Qt5Svg[2019-09-12T10:04:58.193Z]  * Qt5QuickControls2[2019-09-12T10:04:58.193Z]  * Qt5 (required version >= 5.11.0)[2019-09-12T10:04:58.193Z]  * ECM (required version >= 5.62.0), Extra CMake Modules., [2019-09-12T10:04:58.193Z]  * Doxygen (required version >= 1.8.13)[2019-09-12T10:04:58.193Z]Needed for API dox QCH file generation[2019-09-12T10:04:58.193Z]  * QHelpGenerator, Part of Qt5 tools[2019-09-12T10:04:58.193Z]Needed for API dox QCH file generation[2019-09-12T10:04:58.193Z]  * Qt5Core[2019-09-12T10:04:58.193Z] [2019-09-12T10:04:58.193Z] -- Configuring done[2019-09-12T10:04:58.449Z] -- Generating done[2019-09-12T10:04:58.449Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-09-12T10:04:59.881Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kirigami --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2019-09-12T10:05:00.138Z] Scanning dependencies of target KF5Kirigami2_autogen[2019-09-12T10:05:00.138Z] Scanning dependencies of target copy[2019-09-12T10:05:00.138Z] Scanning dependencies of target applicationitemapp_autogen[2019-09-12T10:05:00.138Z] Scanning dependencies of target Qt5Core_QCH[2019-09-12T10:05:00.138Z] [  3%] Automatic MOC for target applicationitemapp[2019-09-12T10:05:00.138Z] [  6%] Automatic MOC for target KF5Kirigami2[2019-09-12T10:05:00.138Z] [  6%] Built target Qt5Core_QCH[2019-09-12T10:05:00.138Z] Scanning dependencies of target KF5Kirigami2_QCH[2019-09-12T10:05:00.138Z] [  9%] Generating src/libkirigami/KF5Kirigami2.qch, src/libkirigami/KF5Kirigami2.tags[2019-09-12T10:05:00.138Z] [  9%] Built target copy[2019-09-12T10:05:00.395Z] [  9%] Built target applicationitemapp_autogen[2019-09-12T10:05:00.395Z] [ 12%] Generating qrc_resources.cpp[2019-09-12T10:05:00.395Z] Scanning dependencies of target applicationitemapp[2019-09-12T10:05:00.395Z] [ 15%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/applicationitemapp_autogen/mocs_compilation.cpp.o[2019-09-12T10:05:00.395Z] [ 21%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/qrc_resources.cpp.o[2019-09-12T10:05:00.395Z] [ 21%] Building CXX object examples/applicationitemapp/CMakeFiles/applicationitemapp.dir/main.cpp.o[2019-09-12T10:05:00.973Z] [ 21%] Built target KF5Kirigami2_autogen[2019-09-12T10:05:00.973Z] [ 25%] Generating tabletmodemanager_interface.cpp, tabletmodemanager_interface.h[2019-09-12T10:05:00.973Z] [ 28%] Generating tabletmodemanager_interface.moc[2019-09-12T10:05:00.973Z] Building up file structure...[2019-09-12T10:05:00.973Z] Insert custom filters...[2019-09-12T10:05:00.973Z] Insert help data for filter section (1 of 1)...[2019-09-12T10:05:00.973Z] Insert files...[2019-09-12T10:05:00.973Z] Insert contents...[2019-09-12T10:05:00.973Z] Insert indices...[2019-09-12T10:05:00.973Z] Documentation successfully generated.[2019-09-12T10:05:00.973Z] [ 28%] Built target KF5Kirigami2_QCH[2019-09-12T10:05:00.973Z] Scanning dependencies of target KF5Kirigami2[2019-09-12T10:05:00.973Z] [ 31%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/KF5Kirigami2_autogen/mocs_compilation.cpp.o[2019-09-12T10:05:00.973Z] [ 34%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/platformtheme.cpp.o[2019-09-12T10:05:00.973Z] [ 37%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/basictheme.cpp.o[2019-09-12T10:05:00.973Z] [ 40%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/kirigamipluginfactory.cpp.o[2019-09-12T10:05:00.973Z] [ 43%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodewatcher.cpp.o[2019-09-12T10:05:00.973Z] [ 46%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/loggingcategory.cpp.o[2019-09-12T10:05:00.973Z] [ 50%] Building CXX object src/libkirigami/CMakeFiles/KF5Kirigami2.dir/tabletmodemanager_interface.cpp.o[2019-09-12T10:05:02.356Z] /usr/home/jenkins/workspace/Frameworks/kirigami/kf5-qt5 FreeBSDQt5.13/src/libkirigami/platformtheme.cpp:700:71: warning: unused parameter 'customColor' [-Wunused-parameter][2019-09-12T10:05:02.356Z] QIcon PlatformTheme::iconFromTheme(const QString &name, const QColor &customColor)[2019-09-12T10:05:02.356Z]   ^[2019-09-12T10:05:02.619Z] 1 warning generated.[2019-09-12T10:05:02.619Z] [ 53%] Linking CXX executable ../../bin/applicationitemapp[2019-09-12T10:05:02.878Z] [ 53%] Built target applicationitem

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 31 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/31/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 12 Sep 2019 09:58:19 +
 Build duration:
5 min 1 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.62.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6879/9068)43%
(10759/24785)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2866/2956)48%
(6161/12707)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D23893: [KIO] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  make; ctest

REPOSITORY
  R241 KIO

BRANCH
  port_to_qt_514

REVISION DETAIL
  https://phabricator.kde.org/D23893

AFFECTED FILES
  autotests/jobtest.cpp
  autotests/kdirlistertest.cpp
  autotests/kdirmodeltest.cpp
  autotests/kurifiltertest.cpp
  autotests/udsentry_benchmark.cpp
  src/core/copyjob.cpp
  src/core/ksslcertificatemanager.cpp
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperatoriconview.cpp
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kstatusbarofflineindicator.cpp
  src/filewidgets/kurlnavigatorbutton.cpp
  src/filewidgets/kurlnavigatorprotocolcombo.cpp
  src/ioslaves/ftp/ftp.cpp
  src/ioslaves/http/http.cpp
  src/ioslaves/http/http_cache_cleaner.cpp
  src/ioslaves/http/kcookiejar/kcookiejar.cpp
  src/ioslaves/http/kcookiejar/kcookiewin.cpp
  src/kcms/kio/kcookiesmanagement.cpp
  src/kcms/kio/useragentselectordlg.cpp
  src/widgets/delegateanimationhandler_p.h
  src/widgets/kbuildsycocaprogressdialog.cpp
  src/widgets/kopenwithdialog.cpp
  src/widgets/krun.cpp

To: dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Meanwhile lsof was installed on the Linux CI nodes, but this fix is still 
good to have of course, just in case.

INLINE COMMENTS

> klistopenfilesjobtest_unix.cpp:34
> +
> +bool HasLsofInstalled()
> +{

Method names start with a lowercase letter in Qt/KDE code.

> klistopenfilesjobtest_unix.cpp:67
> +if (!HasLsofInstalled()) {
> +qDebug() << "lsof is not installed - skipping test";
> +return;

Please use QSKIP instead, otherwise the test output looks like the test passed, 
rather than was skipped.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23884

To: hallas, dfaure
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.13/19/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 12 Sep 2019 06:46:15 +
 Build duration:
2 hr 18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest