D24012: Supress mouse events in KCMs causing window moves

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kcmoduleqml.cpp:265-268
> +bool rc = KCModule::event(event);
> +if (event->type () == QEvent::MouseButtonPress || event->type() == 
> QEvent::MouseButtonRelease) {
> +event->accept();
> +}

Should we check `if (rc && ...)` if rc is false event is not handled no?

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D24012

To: davidedmundson, #plasma
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[Pino Toscano]

pino added a comment.


  In D23815#528543 , @dfaure wrote:
  
  > If we want to enable this flag (to "punish" the first KDE developer who 
upgrades Qt, like me currently), then at least we should only do so in git 
checkouts, not in release tarballs.
  >  This is easy to do: `if (EXISTS "${CMAKE_SOURCE_DIR}/.git")`.
  
  
  Note that "being in git" does not imply "this is the development repository": 
there are distributions that maintain the sources expanded in git repositories 
[1], so the check would be mistakenly triggered in those cases.
  
  [1] https://wiki.debian.org/PackagingWithGit

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson, vkrause
Cc: pino, arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 82 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/82/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Sep 2019 04:19:22 +
 Build duration:
10 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.63.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.63.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6884/9077)43%
(10766/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2871/2964)48%
(6168/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

[David Hallas]

hallas closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23884

To: hallas, dfaure
Cc: dhaumann, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24014: [KWayland] Port away from deprecated API in Qt 5.14

[David Faure]

dfaure created this revision.
dfaure added reviewers: davidedmundson, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24014

AFFECTED FILES
  autotests/client/test_wayland_surface.cpp
  src/client/region.cpp
  src/client/surface.cpp
  src/server/surface_interface_p.h
  src/tools/generator.cpp
  src/tools/testserver/testserver.cpp

To: dfaure, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23815: [KConfig] port away from deprecated methods in Qt 5.14

[David Faure]

dfaure added a reviewer: vkrause.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D23815

To: dfaure, mdawson, arichardson, vkrause
Cc: arojas, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 9 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/9/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 19:58:08 +
 Build duration:
2 min 57 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kplotting » kf5-qt5 WindowsMSVCQt5.13 - Build # 8 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20WindowsMSVCQt5.13/8/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 19:51:52 +
 Build duration:
3 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

D24012: Supress mouse events in KCMs causing window moves

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If a mouse press is handled by the new input handlers the mouse evnet is
  not accepted at a window level.
  
  This causes the breeze style to start a window drag.
  
  Marking all mouse events as accepted after being processed supresses
  them reaching the widget.
  
  This is noticable in the rewritten kscreen KCM when running on XCB. (it
  would also affect wayland, but the breeze window management is currently
  broken there)

TEST PLAN
  Dragged a monitor in kscreen kcm. The monitor representation moved not the 
whole window

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24012

AFFECTED FILES
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

[Aleix Pol Gonzalez]

apol updated this revision to Diff 66271.
apol added a comment.


  Also make the property lowercase
  
  QML doesn't like properties that start uppercase

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24010?vs=66270&id=66271

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24010

AFFECTED FILES
  autotests/kconfig_compiler/test13.kcfg
  src/kconfig_compiler/kconfig_compiler.cpp

To: apol, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

[Albert Astals Cid]

aacid added a comment.


  Doesn't this create any change on the other test13 files?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D24010

To: apol, #frameworks
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  We were not adjusting the property name to the getter letter-casing.

TEST PLAN
  See added test, also fixes the issue that made me realize this issue.

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24010

AFFECTED FILES
  autotests/kconfig_compiler/test13.kcfg
  src/kconfig_compiler/kconfig_compiler.cpp

To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Nathaniel Graham]

ngraham added a comment.


  Thanks a bunch!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[David Faure]

dfaure added a comment.


  Done, I released a KIO 5.62.1 and informed packagers.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22365: KNotification macOS native support by NSNotificationCenter

[René J . V . Bertin]

rjvbb added a comment.


  >   Yeah, you're right that we should check system version for 
back-compatibility.
  
  Actually, I didn't want to suggest that. I haven't checked, but I think that 
the Qt requirement already ensures that the Cocoa APIs that you are using are 
present.
  
  >   AFAIU, we can check it before the creation of notification backend 
instance, if not compatible, use the old implementation, right?
  
  Yes - but if the backend compiles (without or with #ifdefs).
  
  >   I don't know XCB QPA stuff. Investigating then...
  
  Don't take my XCB QPA remarks as a blocker, but do have a look if there's 
some kind of mechanism in place to check whether an application is running in a 
full GUI environment. Not necessarily as part of this change request - I'm 
thinking out loud here, in fact.

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 8 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/8/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 19:51:53 +
 Build duration:
1 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 49 lines...][2019-09-16T19:52:05.142Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:05.464Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:52:05.508Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:52:05.551Z]  > git checkout -f 108d1dd7a3576bbdf825ecf04bd66f9e9dceb954 # timeout=10[Pipeline] checkout[2019-09-16T19:52:04.384Z] No credentials specified[2019-09-16T19:52:04.387Z] Cloning the remote Git repository[2019-09-16T19:52:05.990Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:52:05.991Z]  > git init C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13\ci-tooling\repo-metadata # timeout=10[2019-09-16T19:52:06.050Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:52:06.051Z]  > git --version # timeout=10[2019-09-16T19:52:06.095Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:07.764Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-09-16T19:52:07.806Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:07.845Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-09-16T19:52:07.882Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:52:07.882Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:06.642Z] Checking out Revision ad16c293e8a0caf000157d4a1a589515ddc0f2e4 (origin/master)[2019-09-16T19:52:08.201Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:52:08.247Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:52:08.289Z]  > git checkout -f ad16c293e8a0caf000157d4a1a589515ddc0f2e4 # timeout=10[2019-09-16T19:52:07.786Z] Commit message: "Move Ruqola to KDE Review per the request of Laurent Montel."[Pipeline] checkout[2019-09-16T19:52:08.175Z] No credentials specified[2019-09-16T19:52:08.178Z] Cloning the remote Git repository[2019-09-16T19:52:09.781Z] Cloning repository https://anongit.kde.org/kde-build-metadata[2019-09-16T19:52:09.784Z]  > git init C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13\ci-tooling\kde-build-metadata # timeout=10[2019-09-16T19:52:09.852Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-09-16T19:52:09.852Z]  > git --version # timeout=10[2019-09-16T19:52:09.901Z]  > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:12.532Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-09-16T19:52:12.748Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:12.964Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-09-16T19:52:13.379Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-09-16T19:52:13.379Z]  > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:52:15.345Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:52:14.030Z] Checking out Revision d394f7151c095c0d4e4a86f04a28e94f56358de6 (origin/master)[2019-09-16T19:52:14.508Z] Commit message: "Add deps for kpeoplevcard"[2019-09-16T19:52:15.636Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:52:15.806Z]  > git checkout -f d394f7151c095c0d4e4a86f04a28e94f56358de6 # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[2019-09-16T19:52:57.074Z] [2019-09-16T19:52:57.074Z] C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13>python -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kholidays --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.13 --installTo "C:/CI/Software Installs/kholidays/" [2019-09-16T19:53:07.323Z] Traceback (most recent call last):[2019-09-16T19:53:07.323Z]   File "C:\Program Files\Python36-32\lib\urllib\request.py", line 1318, in do_open[2019-09-16T19:53:07.323Z] encode_chunked=req.has_header('Transfer-encoding'))[2019-09-16T19:53:07.323Z]   File "C:\Program Files\Python36-32\lib\http\client.py", line 1239, in request[2019-09-16T19:53:07.323Z] self._send_request(me

[IMPORTANT] Binary Factory & CI System Maintenance

[Ben Cooksley]

Hi all,

As part of changes to help improve the capacity, capability and
security of the Binary Factory and CI system, i'm going to be
performing a rebuild of several of the physical hosts responsible for
performing builds on the CI system.

Following these changes, signing operations for Flatpak and Android
builds will have been shifted away from the machines responsible for
handling the actual builds, and the system will have an additional
machine added to handle builds.

This will also pave the way for the build process for Snaps being
brought to the Binary Factory (although there are other issues which
may hold up the delivery of that due to excessive requirements imposed
by the Snap tooling)

During this time however, the overall capacity of the system may be
reduced and the capability to perform some builds may be unavailable.

Should anyone have any upcoming releases that require the services of
the Binary Factory & CI system it would be appreciated if you could
please let me know so I can take that into account for scheduling the
various changes.

Thanks,
Ben Cooksley
KDE Sysadmin

D24003: kwaylandScanner produce version enum per class

[Vlad Zahorodnii]

zzag added a comment.


  FYI, https://phabricator.kde.org/D22362#493722

INLINE COMMENTS

> generator.cpp:431
>  auto it = std::find_if(m_interfaces.constBegin(), 
> m_interfaces.constEnd(), [] (const Interface &i) { return i.isGlobal(); });
> -if (it != m_interfaces.constEnd()) {
> +while (it != m_interfaces.constEnd()) {
>  const QString templateString = QStringLiteral(

Is it correct thogugh? Can you provide some test input so it's easier to see 
the problem?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24003

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kholidays » kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kholidays/job/kf5-qt5%20WindowsMSVCQt5.13/7/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 19:42:33 +
 Build duration:
1 min 19 sec and counting
   CONSOLE OUTPUT
  [...truncated 49 lines...][2019-09-16T19:43:09.370Z] Commit message: "Blacklist kglobalaccel on Android"[2019-09-16T19:43:11.445Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:43:11.491Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:43:11.530Z]  > git checkout -f 108d1dd7a3576bbdf825ecf04bd66f9e9dceb954 # timeout=10[Pipeline] checkout[2019-09-16T19:43:14.415Z] No credentials specified[2019-09-16T19:43:14.430Z] Cloning the remote Git repository[2019-09-16T19:43:16.762Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:43:16.765Z]  > git init C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13\ci-tooling\repo-metadata # timeout=10[2019-09-16T19:43:16.952Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:43:16.952Z]  > git --version # timeout=10[2019-09-16T19:43:17.082Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:43:21.185Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-09-16T19:43:21.526Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:43:21.869Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-09-16T19:43:22.181Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:43:22.184Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:43:23.419Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:43:21.251Z] Checking out Revision ad16c293e8a0caf000157d4a1a589515ddc0f2e4 (origin/master)[2019-09-16T19:43:23.587Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:43:23.753Z]  > git checkout -f ad16c293e8a0caf000157d4a1a589515ddc0f2e4 # timeout=10[2019-09-16T19:43:23.007Z] Commit message: "Move Ruqola to KDE Review per the request of Laurent Montel."[Pipeline] checkout[2019-09-16T19:43:25.128Z] No credentials specified[2019-09-16T19:43:25.132Z] Cloning the remote Git repository[2019-09-16T19:43:27.464Z] Cloning repository https://anongit.kde.org/kde-build-metadata[2019-09-16T19:43:27.464Z]  > git init C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13\ci-tooling\kde-build-metadata # timeout=10[2019-09-16T19:43:27.515Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-09-16T19:43:27.515Z]  > git --version # timeout=10[2019-09-16T19:43:27.562Z]  > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:43:27.744Z] Checking out Revision d394f7151c095c0d4e4a86f04a28e94f56358de6 (origin/master)[2019-09-16T19:43:27.851Z] Commit message: "Add deps for kpeoplevcard"[2019-09-16T19:43:29.539Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-09-16T19:43:29.580Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:43:29.641Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-09-16T19:43:29.691Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-09-16T19:43:29.691Z]  > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:43:30.027Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:43:30.076Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:43:30.117Z]  > git checkout -f d394f7151c095c0d4e4a86f04a28e94f56358de6 # timeout=10[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[2019-09-16T19:43:32.508Z] [2019-09-16T19:43:32.508Z] C:\CI\workspace\Frameworks\kholidays\kf5-qt5 WindowsMSVCQt5.13>python -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kholidays --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.13 --installTo "C:/CI/Software Installs/kholidays/" [2019-09-16T19:43:40.658Z] Traceback (most recent call last):[2019-09-16T19:43:40.658Z]   File "C:\Program Files\Python36-32\lib\urllib\request.py", line 1318, in do_open[2019-09-16T19:43:40.658Z] encode_chunked=req.has_header('Transfer-encoding'))[2019-09-16T19:43:40.658Z]   File "C:\Program Files\Python36-32\lib\http\client.py", line 1239, in request[2019-09-16T19:43:40.658Z] self._send_request(method, url, body, headers, encode_chunked)[2019-09-16T19:43:40.658Z]   Fi

KDE CI: Frameworks » kplotting » kf5-qt5 WindowsMSVCQt5.13 - Build # 7 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kplotting/job/kf5-qt5%20WindowsMSVCQt5.13/7/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Mon, 16 Sep 2019 19:39:58 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 49 lines...][2019-09-16T19:40:33.364Z] Commit message: "Blacklist kglobalaccel on Android"[2019-09-16T19:40:35.137Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:40:35.280Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:40:35.397Z]  > git checkout -f 108d1dd7a3576bbdf825ecf04bd66f9e9dceb954 # timeout=10[Pipeline] checkout[2019-09-16T19:40:41.922Z] No credentials specified[2019-09-16T19:40:41.926Z] Cloning the remote Git repository[2019-09-16T19:40:44.256Z] Cloning repository https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:40:44.257Z]  > git init C:\CI\workspace\Frameworks\kplotting\kf5-qt5 WindowsMSVCQt5.13\ci-tooling\repo-metadata # timeout=10[2019-09-16T19:40:44.312Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:40:44.312Z]  > git --version # timeout=10[2019-09-16T19:40:44.358Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:40:44.802Z] Checking out Revision ad16c293e8a0caf000157d4a1a589515ddc0f2e4 (origin/master)[2019-09-16T19:40:46.582Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-09-16T19:40:46.641Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:40:46.693Z]  > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10[2019-09-16T19:40:46.733Z] Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata[2019-09-16T19:40:46.733Z]  > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:40:47.080Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:40:47.130Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:40:47.180Z]  > git checkout -f ad16c293e8a0caf000157d4a1a589515ddc0f2e4 # timeout=10[2019-09-16T19:40:46.567Z] Commit message: "Move Ruqola to KDE Review per the request of Laurent Montel."[Pipeline] checkout[2019-09-16T19:40:48.601Z] No credentials specified[2019-09-16T19:40:48.605Z] Cloning the remote Git repository[2019-09-16T19:40:50.935Z] Cloning repository https://anongit.kde.org/kde-build-metadata[2019-09-16T19:40:50.936Z]  > git init C:\CI\workspace\Frameworks\kplotting\kf5-qt5 WindowsMSVCQt5.13\ci-tooling\kde-build-metadata # timeout=10[2019-09-16T19:40:50.991Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-09-16T19:40:50.991Z]  > git --version # timeout=10[2019-09-16T19:40:51.043Z]  > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:40:52.821Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-09-16T19:40:52.916Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:40:53.011Z]  > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10[2019-09-16T19:40:53.180Z] Fetching upstream changes from https://anongit.kde.org/kde-build-metadata[2019-09-16T19:40:53.180Z]  > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* # timeout=10[2019-09-16T19:40:55.110Z]  > git rev-parse "origin/master^{commit}" # timeout=10[2019-09-16T19:40:52.999Z] Checking out Revision d394f7151c095c0d4e4a86f04a28e94f56358de6 (origin/master)[2019-09-16T19:40:53.479Z] Commit message: "Add deps for kpeoplevcard"[Pipeline] }[Pipeline] // stage[2019-09-16T19:40:55.330Z]  > git config core.sparsecheckout # timeout=10[2019-09-16T19:40:55.513Z]  > git checkout -f d394f7151c095c0d4e4a86f04a28e94f56358de6 # timeout=10[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] bat[2019-09-16T19:41:00.220Z] [2019-09-16T19:41:00.220Z] C:\CI\workspace\Frameworks\kplotting\kf5-qt5 WindowsMSVCQt5.13>python -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kplotting --branchGroup kf5-qt5 --environment production --platform WindowsMSVCQt5.13 --installTo "C:/CI/Software Installs/kplotting/" [2019-09-16T19:41:10.370Z] Traceback (most recent call last):[2019-09-16T19:41:10.370Z]   File "C:\Program Files\Python36-32\lib\urllib\request.py", line 1318, in do_open[2019-09-16T19:41:10.370Z] encode_chunked=req.has_header('Transfer-encoding'))[2019-09-16T19:41:10.370Z]   File "C:\Program Files\Python36-32\lib\http\client.py", line 1239, in request[2019-09-16T19:41:10.370Z] self._send_request(method, url, body, headers, encode_chunked)[2019-09-16T19:41:10.370Z]   Fi

D24002: Sort files alphabetically in cmake list

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> CMakeLists.txt:49-50
>  shell_interface.cpp
>  surface_interface.cpp
>  subcompositor_interface.cpp
>  textinput_interface.cpp

Open vim, select all relevant lines in visual mode, and run sort command.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24002

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24004: Teach kwaylandscanner about PrimarySelection

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  This allows generating the skeleton classes for the primary selection 
protocol.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24004

AFFECTED FILES
  src/tools/mapping.txt

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24003: kwaylandScanner produce version enum per class

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  Otherwise it only creates the enum for the first class encountered.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24003

AFFECTED FILES
  src/tools/generator.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24002: Sort files alphabetically in cmake list

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  Adding further files is confusing, since the list is almost alphabetical.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24002

AFFECTED FILES
  src/server/CMakeLists.txt

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Marcin Dłubakowski]

mdlubakowski added a comment.


  In D23989#532692 , @ngraham wrote:
  
  > I wonder if this should maybe be backported to 5.62, since it represents a 
regression introduced in that release. Thoughts?
  
  
  I would say yes, since I imagine this may be annoyance to some people (the 
patch basically traded one functionality for another, my fault though). Also 
not many distros have updated yet (well, Tumbleweed hasn't).
  
  Thanks for landing!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/83/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 16:04:02 +
 Build duration:
8 min 47 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:fdb10a52bfe8: Fixed interaction with DOS/Windows 
executables in KRun::runUrl (authored by mdlubakowski, committed by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23989?vs=66226&id=66237

REVISION DETAIL
  https://phabricator.kde.org/D23989

AFFECTED FILES
  src/widgets/krun.cpp

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Nathaniel Graham]

ngraham added a comment.


  I wonder if this should maybe be backported to 5.62, since it represents a 
regression introduced in that release. Thoughts?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D22365: KNotification macOS native support by NSNotificationCenter

[Weixuan Xiao]

Inoki added a comment.


  In D22365#532294 , @rjvbb wrote:
  
  > I haven't been able to give this much attention, sorry.
  >
  > After backporting the patch to OS X 10.9 it does work so I presume it'll 
work even better with the full functionality availability.
  >
  > One thing: it has a hardcoded assumption that the Cocoa notication APIs 
will always be available and usable - IOW, that the Cocoa QPA plugin will 
always be the one in use. Of course it's very unlikely to encounter other QPAs 
in the wild that support full-fledged GUIs but what about the few other 
cross-platform QPA plugins (minimal and offscreen to name just 2)? Will 
notifications be disabled upstream of the platform implementation when those 
are used, for whatever reason?
  >
  > Because if not, the SDK will throw an exception, or (more likely), 
something will crash because the integration layer returns nullptr for a 
required platform function. I found that out when a notification was triggered 
while I was using the XCB QPA (I use Konsole as my X11 terminal emulator under 
XQuartz, and also do some remote displaying).
  >
  > I haven't looked closely at the implementation but I assume it should not 
be costly to check the platform name before deciding to use the new Mac 
notification backend, just as a preparation for possible future changes (Qt 
don't formally outlaw the XCB QPA, for instance).
  
  
  Yeah, you're right that we should check system version for back-compatibility.
  AFAIU, we can check it before the creation of notification backend instance, 
if not compatible, use the old implementation, right?
  
  I don't know XCB QPA stuff. Investigating then...

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D23145: [Exe Thumbnailer] Match 16 bit executables and don't request icon types wrestool cannot handle

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:920784722205: [Exe Thumbnailer] Match 16 bit executables 
and don't request icon types… (authored by broulik).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23145?vs=64777&id=66235

REVISION DETAIL
  https://phabricator.kde.org/D23145

AFFECTED FILES
  thumbnail/icoutils_wrestool.cpp

To: broulik, vonreth, pali, antlarr, bruns
Cc: apol, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

[Nathaniel Graham]

ngraham added a comment.


  Ooh, I'm so excited that this will be landing soon!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, andreaska, gregormi, markg, alexeymin, broulik, elvisangelaccio, 
dfaure, davidedmundson, ltoscano, #konqueror, iasensio, fprice, LeGast00n, 
MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D23985: Consider UNC paths as NetworkShare context

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works great, looks great.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D23985

To: broulik, #plasma, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure closed this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D23994

To: dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thank you!

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23994

To: dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/82/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 14:24:54 +
 Build duration:
7 min 21 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23991: GIT_SILENT fix comment about passwords in debug output

[David Faure]

dfaure closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23991

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

[Ahmad Samir]

ahmadsamir updated this revision to Diff 66227.
ahmadsamir added a comment.


  Remove redundant comments

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23991?vs=66217&id=66227

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

[David Faure]

dfaure closed this revision.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D23995

To: dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23995

To: dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  exe-file-handling

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Marcin Dłubakowski]

mdlubakowski marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Marcin Dłubakowski]

mdlubakowski marked 3 inline comments as done.
mdlubakowski added inline comments.

INLINE COMMENTS

> dfaure wrote in krun.cpp:390
> Can you split this into two "else if" conditions? It will be more readable 
> (both the condition, and the comment). This only duplicates a trivial "canRun 
> = false" statement.
> 
> And then we could further simplify this by checking the new bool first, so it 
> only needs to be checked once...
> 
>   if (!supportsRunningExecutable) {
>   canRun = false;
>   } else if (!isFileExecutable && !isTextFile) {
>   []
>   } else if (!isFileExecutable && isTextFile) {
>   canRun = false;
>   }
> 
> What do you think?

Agree, it looks cleaner like that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Marcin Dłubakowski]

mdlubakowski updated this revision to Diff 66226.
mdlubakowski added a comment.


  - Incorporated feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23989?vs=66215&id=66226

BRANCH
  exe-file-handling

REVISION DETAIL
  https://phabricator.kde.org/D23989

AFFECTED FILES
  src/widgets/krun.cpp

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure closed this revision.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D23990

To: dfaure, apol, ngraham, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23995: [KComboBox] Properly disable Qt's builtin completer [regression fix]

[David Faure]

dfaure created this revision.
dfaure added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  It is set by setLineEdit when the deprecated bool autoCompletion hasn't
  previously been set to false. So the commit that removed
  setAutoCompletion(false) led to an unwanted QCompleter, indirectly.

TEST PLAN
  kfind's "Look in" combobox no longer offers completion
  from the combo items (preselected, in the lineedit)

REPOSITORY
  R284 KCompletion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23995

AFFECTED FILES
  src/kcombobox.cpp

To: dfaure, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> broulik wrote in kcombobox.cpp:59
> With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind 
> autocompletes history entries rather than paths when hitting tab.

Good catch!

More precisely, history entries are offered in the lineedit edit, pre-selected, 
and only hitting "Del" allows to get normal path completion.

Amazing. setAutoCompletion(false) really only does setCompleter(nullptr) like 
we do (and setting the bool for the old unused property).

Ah unless we're not yet editable when coming here, and we're made editable 
later, then no code is doing the setCompleter(nullptr) anymore. Tricky!

In fact, due to the way init() is called, isEditable() is *NEVER* true here.

I'll keep working on a fix, just wanted to let you know I'm on it.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D23842

To: dfaure, cfeck, dhaumann, aacid, vkrause
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Looks good :)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23990

To: dfaure, apol, ngraham, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure created this revision.
dfaure added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  make && ctest

REPOSITORY
  R307 KPeople

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23994

AFFECTED FILES
  examples/contactlistwidgets.cpp
  src/widgets/mergedelegate.cpp

To: dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23842: [KCompletion] Port away from deprecated methods in Qt 5.14

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> kcombobox.cpp:59
>  Q_Q(KComboBox);
> -q->QComboBox::setAutoCompletion(false); // otherwise setLineEdit will 
> create a completer...
>  

With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind autocompletes 
history entries rather than paths when hitting tab.

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D23842

To: dfaure, cfeck, dhaumann, aacid, vkrause
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  There isn't even a QString around in this code, so you could just remove the 
comment altogether.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Thanks for the quick fix.

INLINE COMMENTS

> krun.cpp:366
> +// On Windows, run all executables normally
> +bool runWindowsExecutable = true;
> +#else

const bool ...

> krun.cpp:370
> +// from being run, so that programs like Wine can handle 
> them instead.
> +bool runWindowsExecutable = 
> !mime.inherits(QStringLiteral("application/x-ms-dos-executable"));
> +#endif

const bool ...

Also, the name of this bool is very confusing in my opinion.
It's true if the file is NOT a windows executable...

Maybe name it something like supportsRunningExecutable?

> krun.cpp:390
>  }
> -} else if (!isFileExecutable && isTextFile) {
> -// Don't try to run scripts without execute bit, instead
> -// open them with default application
> +} else if ((!isFileExecutable && isTextFile) || 
> !runWindowsExecutable) {
> +// Don't try to run scripts without execute bit or any 

Can you split this into two "else if" conditions? It will be more readable 
(both the condition, and the comment). This only duplicates a trivial "canRun = 
false" statement.

And then we could further simplify this by checking the new bool first, so it 
only needs to be checked once...

  if (!supportsRunningExecutable) {
  canRun = false;
  } else if (!isFileExecutable && !isTextFile) {
  []
  } else if (!isFileExecutable && isTextFile) {
  canRun = false;
  }

What do you think?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23991: GIT_SILENT fix comment about passwords in debug output

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  QUrls in debug output always have the password removed (upstream impl.)

REPOSITORY
  R241 KIO

BRANCH
  ahmad/url-debug-output-passwords (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23991

AFFECTED FILES
  src/core/kcoredirlister.cpp

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Marcin Dłubakowski]

mdlubakowski added a comment.


  In D22510#532295 , @broulik wrote:
  
  > This patch breaks running Windows EXE files. Clicking them does nothing 
now. Right clicking and explicitly choosing "Run with wine program launcher" 
works.
  
  
  Indeed it does, thanks for reporting. I submitted a fix: D23989 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

[David Faure]

dfaure created this revision.
dfaure added reviewers: apol, ngraham, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

TEST PLAN
  Builds. If there were any unittests, I would have run them...
  If there was a maintainer, I would have added him as reviewer...
  Many things one could do, with "ifs" ;-)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23990

AFFECTED FILES
  src/kcmultidialog.cpp
  src/kpluginselector.cpp
  src/ksettings/dialog.cpp

To: dfaure, apol, ngraham, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D23988

To: dfaure, drosca
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl

[Marcin Dłubakowski]

mdlubakowski retitled this revision from "Fixed DOS/Windows executable handling 
by KRun" to "Fixed interaction with DOS/Windows executables in KRun::runUrl".
mdlubakowski edited the summary of this revision.
mdlubakowski added reviewers: dfaure, Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D23989

To: mdlubakowski, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23989: Fixed DOS/Windows executable handling by KRun

[Marcin Dłubakowski]

mdlubakowski created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mdlubakowski requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  exe-file-handling

REVISION DETAIL
  https://phabricator.kde.org/D23989

AFFECTED FILES
  src/widgets/krun.cpp

To: mdlubakowski
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23988

To: dfaure, drosca
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

[David Faure]

dfaure updated this revision to Diff 66213.
dfaure added a comment.


  link to task

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23988?vs=66212&id=66213

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23988

AFFECTED FILES
  src/adapter_p.cpp
  src/device_p.cpp
  src/macros.h
  src/mediaplayer_p.cpp
  src/mediatransport_p.cpp
  src/obextransfer.cpp

To: dfaure, drosca
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23988: [Bluez-Qt] Port away from deprecated QSharedPointer::data() method.

[David Faure]

dfaure created this revision.
dfaure added a reviewer: drosca.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I did this the lazy way (s/data()/lock()/) because apparently this
  is just the q pointer being weak to avoid a cyclic reference,
  and the Device always holds a ref to q, so it's never null.
  (and no multithreaded usage here)

TEST PLAN
  make && ctest

REPOSITORY
  R269 BluezQt

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23988

AFFECTED FILES
  src/adapter_p.cpp
  src/device_p.cpp
  src/macros.h
  src/mediaplayer_p.cpp
  src/mediatransport_p.cpp
  src/obextransfer.cpp

To: dfaure, drosca
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/81/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 11:56:46 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8e3b39635cb5: [KUrlNavigatorPlacesSelector] Properly 
identify teardown action (authored by broulik).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18425?vs=64792&id=66204

REVISION DETAIL
  https://phabricator.kde.org/D18425

AFFECTED FILES
  src/filewidgets/kurlnavigatorplacesselector.cpp

To: broulik, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18425

To: broulik, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/79/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 15 Sep 2019 16:55:50 +
 Build duration:
8 hr 15 min and counting

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/10/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 00:18:41 +
 Build duration:
53 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 00:21:47 +
 Build duration:
55 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/30/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 00:00:09 +
 Build duration:
8 min 1 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 16 Sep 2019 00:13:10 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18425

To: broulik, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23968: Use app specific location for DB on Android

[Aleix Pol Gonzalez]

apol added a comment.


  In D23968#532237 , @nicolasfella 
wrote:
  
  > I thought the same thing, but I'm not sure if changing that could break 
some apps
  
  
  I don't see how many apps would be using a writtableLocation they can't write 
into. :/

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D23968

To: nicolasfella, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23985: Consider UNC paths as NetworkShare context

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Location runner uses `KUriFilter` which translates "\\foo\bar" to 
smb://foo/bar" but we don't want to go through all of the URI filtering in 
KRunner itself.

TEST PLAN
  Searched for "\\foo\bar" and got it as "NetworkShare" with higher score in 
location runner than before.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D23985

AFFECTED FILES
  src/runnercontext.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22510: Added dialog to set execute permission for executable file when trying to run it.

[Kai Uwe Broulik]

broulik added a comment.


  This patch breaks running Windows EXE files. Clicking them does nothing now. 
Right clicking and explicitly choosing "Run with wine program launcher" works.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22510

To: mdlubakowski, #frameworks, dfaure, cfeck, pino
Cc: broulik, ngraham, probono, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D22365: KNotification macOS native support by NSNotificationCenter

[René J . V . Bertin]

rjvbb added a comment.


  I haven't been able to give this much attention, sorry.
  
  After backporting the patch to OS X 10.9 it does work so I presume it'll work 
even better with the full functionality availability.
  
  One thing: it has a hardcoded assumption that the Cocoa notication APIs will 
always be available and usable - IOW, that the Cocoa QPA plugin will always be 
the one in use. Of course it's very unlikely to encounter other QPAs in the 
wild that support full-fledged GUIs but what about the few other cross-platform 
QPA plugins (minimal and offscreen to name just 2)? Will notifications be 
disabled upstream of the platform implementation when those are used, for 
whatever reason?
  
  Because if not, the SDK will throw an exception, or (more likely), something 
will crash because the integration layer returns nullptr for a required 
platform function. I found that out when a notification was triggered while I 
was using the XCB QPA (I use Konsole as my X11 terminal emulator under XQuartz, 
and also do some remote displaying).
  
  I haven't looked closely at the implementation but I assume it should not be 
costly to check the platform name before deciding to use the new Mac 
notification backend, just as a preparation for possible future changes (Qt 
don't formally outlaw the XCB QPA, for instance).

REVISION DETAIL
  https://phabricator.kde.org/D22365

To: Inoki, rjvbb, nicolasfella
Cc: nicolasfella, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns