D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kmaterka wrote in kstatusnotifieritemprivate_p.h:158
> Sure, but this is not my code and this is not related. What I want to do here 
> is more like hack/workaround, so it is better to keep it as simple as 
> possible.

It's related and you don't need to any hacks here. QPointer takes care of 
ownership.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24671: Use ECMGenerateExportHeader to manage deprecated API better

[Laurent Montel]

mlaurent added a comment.


  Seems ok for me +1

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D24671

To: kossebau, #frameworks, #plasma, mart, apol
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added inline comments.

INLINE COMMENTS

> bruns wrote in fstabdevice.cpp:56
> fuseiso itself uses setmntent/addmntent/endmntent, so I see no reason 
> getmntent should not work.
> Most importantly, the same implementation should be used for writing and 
> reading.
> 
> https://sourceforge.net/p/fuseiso/code/HEAD/tree/trunk/src/fuseiso.c#l112

Yes i know :) But when I played around with the existing code in 
`fstabhandling.cpp` for reading out the fsname it kept being empty. But now I 
just wrote my own little test program that dumps every field in the `mntent` 
struct and there the fsname contains the full path to the iso file. So, I must 
have screwed up when fiddling with the `fstabhandling.cpp` code, let me give it 
another go, I think it would be much nicer to reuse that code then to have our 
own parser :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 67 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/67/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 19 Oct 2019 03:21:03 +
 Build duration:
2 min 23 sec and counting
   BUILD ARTIFACTS
  acc/KF5Purpose-5.64.0.xml
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.autotests.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)30%
(14/47)30%
(14/47)22%
(457/2046)18%
(172/947)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)94%
(147/156)54%
(54/100)src100%
(8/8)100%
(8/8)68%
(226/334)49%
(89/183)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/18)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/8)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/64)0%
(0/24)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/63)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/6)src.plugins.kdeconnect_sms0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/2)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/6)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/23)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/216)0%
(0/74)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/22)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/70)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/80)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)61%
(23/38)src.plugins.telegram0%
   

D24753: Add edit-opacity icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24700: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:d6c413a0b779: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24700?vs=68059&id=68275

REVISION DETAIL
  https://phabricator.kde.org/D24700

AFFECTED FILES
  CMakeLists.txt
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  src/CMakeLists.txt
  src/klocalizedstring.cpp
  src/klocalizedstring.h

To: kossebau, #frameworks, ilic, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24261: Modernize code: use range-based for loop in more places

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24261

To: kossebau, dfaure
Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24678: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:df7f98189060: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24678?vs=68001&id=68273#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24678?vs=68001&id=68273

REVISION DETAIL
  https://phabricator.kde.org/D24678

AFFECTED FILES
  CMakeLists.txt
  src/plasma/CMakeLists.txt
  src/plasma/applet.h
  src/plasma/corona.h
  src/plasma/package.h
  src/plasma/packagestructure.h
  src/plasma/pluginloader.cpp
  src/plasma/pluginloader.h
  src/plasmaquick/CMakeLists.txt
  src/plasmaquick/appletquickitem.h
  src/plasmaquick/shellpluginloader.h
  src/plasmaquick/view.h

To: kossebau, #plasma, mart, davidedmundson, apol, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24671: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @apol Hi. Any chance you can give this a review soon, given this is almost 
the last one remaining before the complete of all (affected) KF modules to 
ECMGenerateExportHeader is done, and we can enable the respective KF_* macros?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D24671

To: kossebau, #frameworks, #plasma, mart, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in kstatusnotifieritemprivate_p.h:158
> It should be QPointer, no other changes are needed.

Sure, but this is not my code and this is not related. What I want to do here 
is more like hack/workaround, so it is better to keep it as simple as possible.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24753: Add edit-opacity icons

[Nathaniel Graham]

ngraham accepted this revision as: ngraham.
ngraham added a subscriber: ndavis.
ngraham added a comment.
This revision is now accepted and ready to land.


  @ndavis, you good with this?

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg, ngraham
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto marked 2 inline comments as done.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto added a comment.


  In D24746#549960 , @ngraham wrote:
  
  > [...]
  >  If we improve the properties dialog for disks in general, that will also 
improve the display for other kinds of disks and mounted volumes.
  >  What do you think?
  
  
  I like this idea. However this is exceeds my skill set :)

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto edited the summary of this revision.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto updated this revision to Diff 68263.
tienisto added a comment.


  show 'Mounted on' again

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68228&id=68263

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 updated this revision to Diff 68262.
trickyricky26 added a comment.


  - Remove top stripe, reduce the opacity of the remaining stripes

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24753?vs=68223&id=68262

BRANCH
  arcpatch-D24753

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24496: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb37084b3e7c: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24496?vs=67735&id=68261#toc

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24496?vs=67735&id=68261

REVISION DETAIL
  https://phabricator.kde.org/D24496

AFFECTED FILES
  CMakeLists.txt
  autotests/kconfigtest.cpp
  autotests/kdesktopfiletest.cpp
  autotests/kdesktopfiletest.h
  src/core/CMakeLists.txt
  src/core/kauthorized.cpp
  src/core/kauthorized.h
  src/core/kconfig.cpp
  src/core/kconfig.h
  src/core/kconfiggroup.cpp
  src/core/kconfiggroup.h
  src/core/kcoreconfigskeleton.cpp
  src/core/kcoreconfigskeleton.h
  src/core/kdesktopfile.cpp
  src/core/kdesktopfile.h
  src/core/kemailsettings.cpp
  src/core/kemailsettings.h
  src/gui/CMakeLists.txt
  src/gui/kconfiggui.cpp
  src/gui/kconfiggui.h
  src/gui/kconfigloader.cpp
  src/gui/kconfigloader.h
  src/gui/kstandardshortcut.cpp
  src/gui/kstandardshortcut.h

To: kossebau, #frameworks, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Nathaniel Graham]

ngraham added a comment.


  In principle I like the idea of customizing the display to be more 
appropriate. However I feel like the best way to do this might be to go in a 
different direction: instead of adding overrides for `/`, maybe we should take 
advantage of the fact that `/` is always a mounted volume and instead make the 
properties dialog reflect the name and icon of the disk in question. Otherwise 
when you look at the properties for that disk, the dialog that appears shows a 
different name and icon from the thing that was clicked on.
  
  F7623965: Screenshot_20191018_120133.png 

  
  If we improve the properties dialog for disks in general, that will also 
improve the display for other kinds of disks and mounted volumes.
  
  What do you think?

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> hallas wrote in fstabdevice.cpp:56
> This implements a crude parser of the fuseiso mtab file. I can't use the 
> regular getmnt suite of functions to retrieve the path to the iso file, so 
> that is why I implemented this :/

fuseiso itself uses setmntent/addmntent/endmntent, so I see no reason getmntent 
should not work.
Most importantly, the same implementation should be used for writing and 
reading.

https://sourceforge.net/p/fuseiso/code/HEAD/tree/trunk/src/fuseiso.c#l112

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11627: Improve KIO asynchronicity

[Nathaniel Graham]

ngraham added projects: Frameworks, Dolphin.
ngraham added subscribers: Frameworks, Dolphin.

TASK DETAIL
  https://phabricator.kde.org/T11627

To: meven, ngraham
Cc: #dolphin, #frameworks, meven, dfaure, iasensio, fprice, LeGast00n, MrPepe, 
fbampaloukas, alexde, GB_2, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 146 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/146/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 17:16:36 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24753: Add edit-opacity icons

[Nathaniel Graham]

ngraham added a comment.


  Nice. I think the filled in areas might benefit from being a little bit more 
transparent to make it more obvious, particularly for the Breeze Dark version. 
Just a smidge.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 145 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/145/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 16:50:39 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:aa5b0d89b2ed: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24684?vs=68210&id=68257#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24684?vs=68210&id=68257

REVISION DETAIL
  https://phabricator.kde.org/D24684

AFFECTED FILES
  CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/copyjob.h
  src/core/global.cpp
  src/core/global.h
  src/core/job_base.h
  src/core/jobuidelegateextension.h
  src/core/kcoredirlister.h
  src/core/kfileitem.cpp
  src/core/kfileitem.h
  src/core/krecentdocument.h
  src/core/ksambashare.cpp
  src/core/ksambashare.h
  src/core/ksslcertificatemanager.h
  src/core/ktcpsocket.h
  src/core/scheduler.cpp
  src/core/scheduler.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.h
  src/core/statjob.cpp
  src/core/statjob.h
  src/core/transferjob.cpp
  src/core/transferjob.h
  src/core/udsentry.cpp
  src/core/udsentry.h
  src/filewidgets/CMakeLists.txt
  src/filewidgets/kfilepreviewgenerator.h
  src/filewidgets/kfilewidget.cpp
  src/filewidgets/kfilewidget.h
  src/filewidgets/knewfilemenu.h
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h
  src/widgets/CMakeLists.txt
  src/widgets/accessmanager.cpp
  src/widgets/accessmanager.h
  src/widgets/kdirmodel.cpp
  src/widgets/kdirmodel.h
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog.h
  src/widgets/krun.cpp
  src/widgets/krun.h
  src/widgets/kurifilter.cpp
  src/widgets/kurifilter.h
  src/widgets/kurlrequester.cpp
  src/widgets/kurlrequester.h
  src/widgets/kurlrequesterdialog.cpp
  src/widgets/kurlrequesterdialog.h
  src/widgets/paste.cpp
  src/widgets/paste.h
  src/widgets/previewjob.cpp
  src/widgets/previewjob.h
  src/widgets/renamedialog.cpp
  src/widgets/renamedialog.h
  src/widgets/sslui.h
  src/widgets/thumbcreator.h

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24762: Remove two unused member variables using KSslError

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24762

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24764

To: vkrause, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24681: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:0d0b688643d8: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24681?vs=68006&id=68254#toc

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24681?vs=68006&id=68254

REVISION DETAIL
  https://phabricator.kde.org/D24681

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/core/CMakeLists.txt
  src/core/engine.h
  src/core/entryinternal.h
  src/core/installation.h
  src/core/security.h
  src/downloadmanager.h

To: kossebau, #frameworks, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24762: Remove two unused member variables using KSslError

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24762

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

[Volker Krause]

vkrause added a task: T11620: Port from KSslError to QSslError.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24742

To: vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

[Volker Krause]

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24764

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24764: Deprecate KIconTheme::assignIconsToContextMenu

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  It's no longer necessary as Qt sets icons on context menu actions itself
  by now.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24764

AFFECTED FILES
  src/CMakeLists.txt
  src/kicontheme.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24762: Remove two unused member variables using KSslError

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24762

AFFECTED FILES
  src/core/ksslcertificatemanager_p.h

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

[Volker Krause]

vkrause updated this revision to Diff 68248.
vkrause added a comment.


  Fix return value.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24742?vs=68168&id=68248

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24742

AFFECTED FILES
  src/core/ksslcertificatemanager.cpp
  src/core/ksslcertificatemanager.h

To: vkrause
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24673: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:00bc9b132e66: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24673?vs=67994&id=68247

REVISION DETAIL
  https://phabricator.kde.org/D24673

AFFECTED FILES
  CMakeLists.txt
  src/kdeclarative/CMakeLists.txt
  src/kdeclarative/kdeclarative.cpp
  src/kdeclarative/kdeclarative.h
  tests/kdeclarativetest.cpp

To: kossebau, #plasma, mart, broulik
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK it's very likely that KIOCORE_NO_DEPRECATED didn't work anyway, as I found 
out in other frameworks where I tried enabling this kind of thing.

REPOSITORY
  R241 KIO

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R235:f79367c1aff3: Use ECMGenerateExportHeader to manage 
deprecated API better (authored by kossebau).

REPOSITORY
  R235 Attica

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24650?vs=67936&id=68244

REVISION DETAIL
  https://phabricator.kde.org/D24650

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/downloaddescription.cpp
  src/downloaddescription.h
  src/provider.cpp
  src/provider.h
  src/providermanager.cpp
  src/providermanager.h

To: kossebau, #frameworks, gladhorn, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> dfaure wrote in global.h:105
> LOL 3.4 was long ago ;)
> 
> good find :)

Thankfully phabricator and its locate-file, go-to-version-before-commit & tags 
listing for commit was helpful here to good degrees, so that usually tool < 1 
min to find where the deprecation happened.
So the temptation to just say "since 5.0" and spare the digging work was not 
big enough compared to effort needed to be able to have correct history notes :)

https://phabricator.kde.org/source/kdelibs/repository/frameworks/ is currently 
still highranked by my firefox ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  In D24684#549785 , @dfaure wrote:
  
  > The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in 
the commit log, but only there, right?
  
  
  Typo indeed, fixed.

INLINE COMMENTS

> dfaure wrote in global.cpp:99
> Isn't some ifdef still needed for this deprecated method?

I forgot to explicitly mention this in the commit message: no support for 
EXCLUDE_DEPRECATED_BEFORE_AND_AT for KIO here yet, as version-level-based 
disabling of API needs some work first, as some undeprecated API is implemented 
in terms of deprecated still, as I found when testing that support.
The currently existing `#ifndef KIOCORE_NO_DEPRECATED` in the source files thus 
got only removed.

Gzess that should get an explicit TODO comment, e.g. near the 
ecm_generate_export_header marcos?

> dfaure wrote in kfileitem.cpp:1242
> I'm confused, isn't this what *_BUILD_DEPRECATED_SINCE is for?
> 
> [repeats]

See other comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

[Rik Mills]

rikmills accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-knscore-cache (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24754

To: leinir, rikmills, #frameworks, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

[Rik Mills]

rikmills added a comment.


  Patched knewstuff build with this and tested. Switching between KCMs in 
systemsettings now seems to pull the correct KNS results.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D24754

To: leinir, rikmills, #frameworks, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> global.cpp:99
>  
> -#ifndef KIOCORE_NO_DEPRECATED
>  KIOCORE_EXPORT QTime KIO::calculateRemaining(KIO::filesize_t totalSize, 
> KIO::filesize_t processedSize, KIO::filesize_t speed)

Isn't some ifdef still needed for this deprecated method?

> global.h:105
>   * @return calculated remaining time
> + * @deprecated Since 3.4, use calculateRemainingSeconds() instead, as QTime 
> is limited to 23:59:59
>   */

LOL 3.4 was long ago ;)

good find :)

> kfileitem.cpp:1242
>  
> -#ifndef KIOCORE_NO_DEPRECATED
>  bool KFileItem::acceptsDrops() const

I'm confused, isn't this what *_BUILD_DEPRECATED_SINCE is for?

[repeats]

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[David Faure]

dfaure added a comment.


  The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in 
the commit log, but only there, right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Ping... would be happy if this one could get reviewed ASAP, so we have the 
patches for all of KF modules in and can enable the group KF_* macros, so 
people can conveniently use -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0Xxx in 
their projects :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24684

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

[Friedrich W. H. Kossebau]

kossebau added a comment.


  @zzag Hi. Any chance you can have time to review this today/the WE? One of 
the last ECMGenerateExportHeader patches.
  
  I would be happy if we could have all in ASAP so we can enable the KF_* 
macros and test them in git master for two weeks before 5.64 gets tagged for 
release.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24663

To: kossebau, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kstatusnotifieritemprivate_p.h:158
>  
>  QMenu *menu;
>  QHash actionCollection;

It should be QPointer, no other changes are needed.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24673: Use ECMGenerateExportHeader to manage deprecated API better

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24673

To: kossebau, #plasma, mart, broulik
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24678: Use ECMGenerateExportHeader to manage deprecated API better

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24678

To: kossebau, #plasma, mart, davidedmundson, apol, mlaurent
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas added a comment.


  Currently you have the 'unmount' action if you right click on the device in 
dolphin, but it cannot unmount, so should we hide it? Or should we fix it so 
that it can actually unmount?

INLINE COMMENTS

> fstabdevice.cpp:56
> +
> +QString GetFilePathFromFuseIsoMtabFile(const QString& mountPath)
> +{

This implements a crude parser of the fuseiso mtab file. I can't use the 
regular getmnt suite of functions to retrieve the path to the iso file, so that 
is why I implemented this :/

REPOSITORY
  R245 Solid

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka added a comment.


  Continuation of D24667 . I know this 
solution sucks, but I have no idea how this can be done better.
  
  I have another idea, probably even crazier: set "DO_NOT_DELETE" flag as a 
QObject property. Then in destructor check it:
  if (d->m_menu->property("DO_NOT_DELETE") == true) // ignore
  
  Obviously that would be undocumented, ugly hack... Any other idea how to fix 
bug 365105?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D24755

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

[David Hallas]

hallas updated this revision to Diff 68230.
hallas added a comment.


  Implemented parsing of the fuseiso mtab file

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21235?vs=58147&id=68230

BRANCH
  add_handling_of_fuseiso (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21235

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabdevice.cpp
  src/solid/devices/backends/fstab/fstabdevice.h
  src/solid/devices/backends/fstab/fstabhandling.cpp

To: hallas, bruns, ngraham
Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto added a comment.


  In D24746#549637 , @meven wrote:
  
  > I would suggest keeping "Location" and "Mounted on" fields to actually 
display '/' to the user.
  
  
  To me users should know that / is the root folder and has the highest level 
in the directory structure. And that the location of '/' is '/' is quite 
confusing.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24755: [KStatusNotifierItem] Optionaly, do not take menu ownership

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Frameworks, davidedmundson, broulik, nicolasfella.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  It is not possible to handle ownership of QMenu the Qt way, because
  QMenu takes QWidget as a parent, but KSNI is a QObject. In some
  situations (Qt QPA plugin) we don't want QMenu to be destroyed.
  
  CCBUG: 365105

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24755

AFFECTED FILES
  src/kstatusnotifieritem.cpp
  src/kstatusnotifieritem.h
  src/kstatusnotifieritemprivate_p.h

To: kmaterka, #frameworks, davidedmundson, broulik, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

[Kai Uwe Broulik]

broulik added a comment.


  However, `setDummyHistoryEntry` has some logic for icon being `null` and 
"reuse previous pixmap if null" which would be moot if I change it to always 
fall back to `application-octet-stream`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15451

To: broulik, #frameworks, dfaure, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Yes.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15451

To: broulik, #frameworks, dfaure, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Tien Do Nam]

tienisto updated this revision to Diff 68228.
tienisto added a comment.


  use 'Unknown' instead of 'unknown'

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24746?vs=68206&id=68228

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

[Dan Leinir Turthra Jensen]

leinir added reviewers: rikmills, Frameworks, KNewStuff.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D24754

To: leinir, rikmills, #frameworks, #knewstuff
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 68227.
leinir added a comment.


  - Revert unrelated change

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24754?vs=68226&id=68227

BRANCH
  fix-knscore-cache (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24754

AFFECTED FILES
  src/core/engine.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24754: Fix KNSCore::Cache fetching when initialising Engine

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  During the moving-around of the config files, the Cache was left
  behind unfixed, and we ended up with all caches being the same,
  because we attempted to request a cache for a config file which
  was not found, and consequently resulted in the requested cache
  being named "", which consequently failed rather badly.
  
  BUG:408716

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-knscore-cache (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24754

AFFECTED FILES
  CMakeLists.txt
  src/core/engine.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24263: edit mode action

[David Edmundson]

davidedmundson accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24263: edit mode action

[Marco Martin]

mart updated this revision to Diff 68224.
mart added a comment.


  - text is always Customize Layout...

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24263?vs=67896&id=68224

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

AFFECTED FILES
  src/plasma/corona.cpp
  src/plasma/corona.h

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Méven Car]

meven added a comment.


  I would suggest keeping "Location" and "Mounted on" fields to actually 
display '/' to the user.
  Especially for newbies users who might not know what "Root Directory" means.
  But for more advanced user it would make sense too as / is currently visible 
only in the icon, it would feel amiss.
  / is not such a special case as other mount points, and consistency matter, 
even if redundant on this edge case.
  To me the size, the name and icon change are sufficient here.

INLINE COMMENTS

> kpropertiesdialog.cpp:1113
>  } else {
> +d->m_sizeLabel->setText(i18n("unknown"));
>  d->m_sizeStopButton->setEnabled(false);

Replace with Unkwown

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: meven, ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D24263: edit mode action

[David Edmundson]

davidedmundson added a comment.


  GB_2's comment needs fixing, two strings are out of sync.
  
  Other than that, ship it.

INLINE COMMENTS

> GB_2 wrote in corona.cpp:502
> Missing ellipsis (...)

Given how easy it is to get these out of sync, can I suggest removing all the 
code to update editAction's text from Corona::setEditMode   and put it in a 
connect here. It'll keep the editAction logic altogether.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, 
michaelh, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24753

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24753: Add edit-opacity icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  This patch adds edit-opacity icons requested by Okular for D15580 
.
  
  I'm not quite sure about the naming, and even if the Qt SVG renderer can 
handle this transparency. I also considered a style with a checkerboard 
pattern, which is the symbol for transparency e.g. in GIMP, but I felt this is 
not recognizable enough to most people.
  
  I think this should be the last icon needed for 
https://bugs.kde.org/show_bug.cgi?id=408283, so I'm tagging this as closing 
that bug.
  
  BUG: 408283
  FIXED-IN: 5.64

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-opacity-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24753

AFFECTED FILES
  icons-dark/actions/16/edit-opacity.svg
  icons-dark/actions/22/edit-opacity.svg
  icons/actions/16/edit-opacity.svg
  icons/actions/22/edit-opacity.svg

To: trickyricky26
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24752: WIP: Use a separate worker thread to run the actual deletion of files

[Méven Car]

meven updated this revision to Diff 68222.
meven added a comment.


  Clean debug code

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24752?vs=68221&id=68222

BRANCH
  threadedDelete

REVISION DETAIL
  https://phabricator.kde.org/D24752

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24752: WIP: Use a separate worker thread to run the actual deletion of files

[Méven Car]

meven created this revision.
meven added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Part of T11627 

REPOSITORY
  R241 KIO

BRANCH
  threadedDelete

REVISION DETAIL
  https://phabricator.kde.org/D24752

AFFECTED FILES
  src/core/deletejob.cpp

To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 144 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/144/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 08:31:23 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24263: edit mode action

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> corona.cpp:502
> +});
> +editAction->setText(i18n("Customize Layout"));
> +editAction->setAutoRepeat(true);

Missing ellipsis (...)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/editModeActionwq!

REVISION DETAIL
  https://phabricator.kde.org/D24263

To: mart, #plasma, #vdg, ngraham
Cc: broulik, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D24650: Use ECMGenerateExportHeader to manage deprecated API better

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  Very nicely, go for it :)

REPOSITORY
  R235 Attica

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24650

To: kossebau, #frameworks, gladhorn, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24681: Use ECMGenerateExportHeader to manage deprecated API better

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.


  In D24681#547798 , @kossebau wrote:
  
  > No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT, as some deprecated API is 
still used internally, so this needs more clean-up by someone(tm) first.
  
  
  It's indeed annoying, and i've been trying to get rid of the internal usage 
(i do very much like clean build output), but of course it's just not that 
straightforward, and in particular things like where things in KNS have been 
deprecated in favour of things in KNSCore we can't just get rid, because 
getting rid of that would cause havoc with BCI. Basically a bunch of TODO KF6 
things :P
  
  But, apart from that, yes, this is really good work, and whether or not 
that's in, definitely fire away :) i especially like the second half of those 
"don't use this, use THIS" bits :D

REPOSITORY
  R304 KNewStuff

BRANCH
  useECMGenerateExportHeader

REVISION DETAIL
  https://phabricator.kde.org/D24681

To: kossebau, #frameworks, leinir, mlaurent
Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Björn Feber]

GB_2 accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  kpropertiesdialog-root-directory (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks, GB_2
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D24746: [kpropertiesdialog] adjust ui for root directory

[Björn Feber]

GB_2 added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24746

To: tienisto, #vdg, ngraham, #frameworks
Cc: ahmadsamir, GB_2, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 143 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/143/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 18 Oct 2019 07:07:03 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d576ec8ae0e5: Avoid sending KDirNotify::emitFilesAdded 
when the emptytrashjob finishes (authored by meven).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23851?vs=68214&id=68215

REVISION DETAIL
  https://phabricator.kde.org/D23851

AFFECTED FILES
  src/core/emptytrashjob.cpp

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D23851: Avoid sending KDirNotify::emitFilesAdded when the emptytrashjob finishes

[Méven Car]

meven updated this revision to Diff 68214.
meven added a comment.


  Rebase on master

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23851?vs=66028&id=68214

BRANCH
  arcpatch-D23851_1

REVISION DETAIL
  https://phabricator.kde.org/D23851

AFFECTED FILES
  src/core/emptytrashjob.cpp

To: meven, broulik, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns