D24433: Move URL parsing methods from kioslave to query object
bruns added a subscriber: broulik.
bruns added inline comments.
INLINE COMMENTS
> kio_search.cpp:88
> -return jsonQueryForType(QStringLiteral("Document"));
> -} else if (path.endsWith(QLatin1String("/images"))) {
> -return jsonQueryForType(QStringLiteral("Image"));
@broulik - why `endsWith()`?
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
Cc: broulik, bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs,
LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, abrahams
D25267: Improve XCF support
sandsmark updated this revision to Diff 69618. sandsmark added a comment. Fixed masks as well, now even some more complex XCF files work again. REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25267?vs=69617=69618 REVISION DETAIL https://phabricator.kde.org/D25267 AFFECTED FILES src/imageformats/gimp_p.h src/imageformats/xcf.cpp To: sandsmark, aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25267: Improve XCF support
sandsmark updated this revision to Diff 69617. sandsmark added a comment. Forgot to fix the layer offset reading, and read the precision after instead of before the image properties REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25267?vs=69616=69617 REVISION DETAIL https://phabricator.kde.org/D25267 AFFECTED FILES src/imageformats/gimp_p.h src/imageformats/xcf.cpp To: sandsmark, aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25267: Improve XCF support
sandsmark created this revision. sandsmark added reviewers: aacid, cfeck, apol, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sandsmark requested review of this revision. REVISION SUMMARY Now it can at least handle the simplest XCF files I have. Biggest difference seems to be that they changed to 64bit for offsets from version 11 and upwards. Still some issues with more complex layers (aka. not completely plain images), but this is better than nothing. TEST PLAN Tested with some simple XCFs I had laying around that didn't get thumbnails earlier. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25267 AFFECTED FILES src/imageformats/gimp_p.h src/imageformats/xcf.cpp To: sandsmark, aacid, cfeck, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25265: Support adding a contact to a specific backend
jbbgameich added a reviewer: Plasma: Mobile. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25265 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
Re: Bulk replacement of projects.kde.org on Frameworks modules
Elvis Angelaccio ha scritto: > > > On 11/11/19 22:52, Luigi Toscano wrote: >> Hi, >> basically all Frameworks components reference the ECM website >> using the old projects.kde.org URL, which is long gone and >> it is just a (partial) redirect. >> >> See for example: >> >> set_package_properties(ECM PROPERTIES TYPE REQUIRED >> DESCRIPTION "Extra CMake Modules." >> URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) >> >> Can I go around a bulk-replace all the URLs with >> https://commits.kde.org/extra-cmake-modules, so that it would look like: >> >> set_package_properties(ECM PROPERTIES TYPE REQUIRED >> DESCRIPTION "Extra CMake Modules." >> URL "https://commits.kde.org/extra-cmake-modules;) > > +1 > > Using commits.kde.org like this feels weird though (i.e. using it > without a commit hash). commits.kde.org is the general redirector, and it will continue to work even after the switch to gitlab. We have a bit of documentation here: https://techbase.kde.org/Projects/Documentation/KDE_(health_table)#Links_to_kde_repos Ciao -- Luigi
Re: Bulk replacement of projects.kde.org on Frameworks modules
On 11/11/19 22:52, Luigi Toscano wrote: > Hi, > basically all Frameworks components reference the ECM website > using the old projects.kde.org URL, which is long gone and > it is just a (partial) redirect. > > See for example: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra CMake Modules." > URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) > > Can I go around a bulk-replace all the URLs with > https://commits.kde.org/extra-cmake-modules, so that it would look like: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED > DESCRIPTION "Extra CMake Modules." > URL "https://commits.kde.org/extra-cmake-modules;) +1 Using commits.kde.org like this feels weird though (i.e. using it without a commit hash). Something like https://code.kde.org/extra-cmake-modules would look much better imho. Just my 2c, maybe something that could be done after the move to gitlab. > > There are few additional URLs which use the old website and I would replace > them as well using the same pattern. > > I'm asking to avoid ~70 almost-identical review requests. > > Ciao > Ciao Elvis
D24433: Move URL parsing methods from kioslave to query object
iasensio updated this revision to Diff 69613. iasensio marked 2 inline comments as done. iasensio added a comment. Simplify helper function REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24433?vs=67361=69613 BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 AFFECTED FILES src/kioslaves/search/kio_search.cpp src/lib/query.cpp To: iasensio, #baloo, meven, ngraham, astippich Cc: bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
Bulk replacement of projects.kde.org on Frameworks modules
Hi, basically all Frameworks components reference the ECM website using the old projects.kde.org URL, which is long gone and it is just a (partial) redirect. See for example: set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules;) Can I go around a bulk-replace all the URLs with https://commits.kde.org/extra-cmake-modules, so that it would look like: set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://commits.kde.org/extra-cmake-modules;) There are few additional URLs which use the old website and I would replace them as well using the same pattern. I'm asking to avoid ~70 almost-identical review requests. Ciao -- Luigi
D25265: Support adding a contact to a specific backend
jbbgameich updated this revision to Diff 69608. jbbgameich added a comment. Use more future proof roleNames and Enum REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25265?vs=69603=69608 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25265 AFFECTED FILES src/CMakeLists.txt src/datasourcemodel.cpp src/datasourcemodel.h src/declarative/peopleqmlplugin.cpp src/personpluginmanager.cpp src/personpluginmanager.h To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25265: Support adding a contact to a specific backend
jbbgameich added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25265 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25265: Support adding a contact to a specific backend
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY - Add overload of PersonPluginManager::addContact that takes a pluginId - Add a DataSourceModel that can later be extended with additional metadata on the backends. TEST PLAN - Functionality works in plasma-phonebook (https://invent.kde.org/jbbgameich/plasma-phonebook/commit/5e370222059fb093fdbfb99f52b87845c78bedf2) REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D25265 AFFECTED FILES src/CMakeLists.txt src/datasourcemodel.cpp src/datasourcemodel.h src/declarative/peopleqmlplugin.cpp src/personpluginmanager.cpp src/personpluginmanager.h To: jbbgameich Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D23411: Fix crash in writer collection and cleanup
astippich added a comment. Thanks! I pushed a fix which disables the test if taglib is not installed REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D24686: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue
This revision was automatically updated to reflect the committed changes. Closed by commit R320:49440c0cbea1: Replace usage of deprecated SlaveBase::config() by SlaveBase::configValue (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24686?vs=68023=69592 REVISION DETAIL https://phabricator.kde.org/D24686 AFFECTED FILES CMakeLists.txt nfs/nfsv2.cpp nfs/nfsv3.cpp sftp/kio_sftp.cpp smb/kio_smb_dir.cpp To: meven, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
D24433: Move URL parsing methods from kioslave to query object
bruns added inline comments.
INLINE COMMENTS
> query.cpp:317
> +{
> +const QString jsonQuery(QStringLiteral("{\"dayFilter\": 0,\
> + \"monthFilter\": 0, \
dayFilter/monthFilter/yearFilter are pointless, as they just default, but have
to be parsed in `fromJSON`.
> query.cpp:329
> +if (path == QLatin1String("/documents")) {
> +return jsonQueryForType(QStringLiteral("Document"));
> +} else if (path.endsWith(QLatin1String("/images"))) {
can be replaced by `QStringLiteral("{\"type\":[\"Document\"]}")`, dito below.
REPOSITORY
R293 Baloo
BRANCH
extend_query_url
REVISION DETAIL
https://phabricator.kde.org/D24433
To: iasensio, #baloo, meven, ngraham, astippich
Cc: bruns, kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n,
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, abrahams
D24433: Move URL parsing methods from kioslave to query object
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Tested and works REPOSITORY R293 Baloo BRANCH extend_query_url REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D24433: Move URL parsing methods from kioslave to query object
meven added a reviewer: astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham, astippich Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D24433: Move URL parsing methods from kioslave to query object
meven added a reviewer: ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24433 To: iasensio, #baloo, meven, ngraham Cc: kde-frameworks-devel, #dolphin, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D23411: Fix crash in writer collection and cleanup
justinkb added a comment. The test incorrectly fails when a user builds kfilemetadata without taglib REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: justinkb, apol, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 155 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/155/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 11 Nov 2019 10:02:01 + Build duration: 12 min and counting
D25249: KDirModel: port to qCDebug, with its own category
ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25249 To: dfaure, mlaurent, sandsmark, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25079: [CopyJob] Increase the amount of data sendfile can copy at once
meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > file_unix.cpp:266 > #ifdef USE_SENDFILE > -bool use_sendfile = buff_src.st_size < 0x7FFF; > +bool use_sendfile = true; > #endif This prevented using sendfile for file bigger than 2 GB. Our code has no reason to have this restriction. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
D25079: [CopyJob] Increase the amount of data sendfile can copy at once
meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
